Smallhash: add reserve option to avoid resizing when size is known
[blender-staging.git] / source / blender / editors / mesh / editmesh_knife.c
1 /*
2  * ***** BEGIN GPL LICENSE BLOCK *****
3  *
4  * This program is free software; you can redistribute it and/or
5  * modify it under the terms of the GNU General Public License
6  * as published by the Free Software Foundation; either version 2
7  * of the License, or (at your option) any later version.
8  *
9  * This program is distributed in the hope that it will be useful,
10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12  * GNU General Public License for more details.
13  *
14  * You should have received a copy of the GNU General Public License
15  * along with this program; if not, write to the Free Software Foundation,
16  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17  *
18  * The Original Code is Copyright (C) 2007 Blender Foundation.
19  * All rights reserved.
20  *
21  * 
22  * Contributor(s): Joseph Eagar, Joshua Leung, Howard Trickey,
23  *                 Campbell Barton
24  *
25  * ***** END GPL LICENSE BLOCK *****
26  */
27
28 /** \file blender/editors/mesh/editmesh_knife.c
29  *  \ingroup edmesh
30  */
31
32 #ifdef _MSC_VER
33 #  define _USE_MATH_DEFINES
34 #endif
35
36 #include "MEM_guardedalloc.h"
37
38 #include "BLI_listbase.h"
39 #include "BLI_string.h"
40 #include "BLI_array.h"
41 #include "BLI_alloca.h"
42 #include "BLI_linklist.h"
43 #include "BLI_math.h"
44 #include "BLI_smallhash.h"
45 #include "BLI_memarena.h"
46
47 #include "BLF_translation.h"
48
49 #include "BKE_DerivedMesh.h"
50 #include "BKE_context.h"
51 #include "BKE_editmesh.h"
52 #include "BKE_editmesh_bvh.h"
53 #include "BKE_report.h"
54
55 #include "BIF_gl.h"
56 #include "BIF_glutil.h" /* for paint cursor */
57
58 #include "ED_screen.h"
59 #include "ED_space_api.h"
60 #include "ED_view3d.h"
61 #include "ED_mesh.h"
62
63 #include "WM_api.h"
64 #include "WM_types.h"
65
66 #include "DNA_object_types.h"
67 #include "UI_resources.h"
68
69 #include "RNA_access.h"
70 #include "RNA_define.h"
71
72 #include "mesh_intern.h"  /* own include */
73
74 /* this code here is kindof messy. . .I might need to eventually rework it - joeedh */
75
76 #define KMAXDIST    10  /* max mouse distance from edge before not detecting it */
77
78 #define KNIFE_FLT_EPS          0.00001f
79 #define KNIFE_FLT_EPS_SQUARED  (KNIFE_FLT_EPS * KNIFE_FLT_EPS)
80 #define KNIFE_FLT_EPSBIG       0.001f
81
82 typedef struct KnifeColors {
83         unsigned char line[3];
84         unsigned char edge[3];
85         unsigned char curpoint[3];
86         unsigned char curpoint_a[4];
87         unsigned char point[3];
88         unsigned char point_a[4];
89 } KnifeColors;
90
91 /* knifetool operator */
92 typedef struct KnifeVert {
93         BMVert *v; /* non-NULL if this is an original vert */
94         ListBase edges;
95         ListBase faces;
96
97         float co[3], cageco[3], sco[2]; /* sco is screen coordinates for cageco */
98         bool is_face, in_space;
99         bool draw;
100 } KnifeVert;
101
102 typedef struct Ref {
103         struct Ref *next, *prev;
104         void *ref;
105 } Ref;
106
107 typedef struct KnifeEdge {
108         KnifeVert *v1, *v2;
109         BMFace *basef; /* face to restrict face fill to */
110         ListBase faces;
111
112         BMEdge *e /* , *e_old */; /* non-NULL if this is an original edge */
113         bool draw;
114 } KnifeEdge;
115
116 typedef struct KnifeLineHit {
117         float hit[3], cagehit[3];
118         float schit[2];
119         float l; /* lambda along cut line */
120         float perc; /* lambda along hit line */
121         float m; /* depth front-to-back */
122
123         /* Exactly one of kfe, v, or f should be non-NULL,
124          * saying whether cut line crosses and edge,
125          * is snapped to a vert, or is in the middle of some face. */
126         KnifeEdge *kfe;
127         KnifeVert *v;
128         BMFace *f;
129 } KnifeLineHit;
130
131 typedef struct KnifePosData {
132         float co[3];
133         float cage[3];
134
135         /* At most one of vert, edge, or bmface should be non-NULL,
136          * saying whether the point is snapped to a vertex, edge, or in a face.
137          * If none are set, this point is in space and is_space should be true. */
138         KnifeVert *vert;
139         KnifeEdge *edge;
140         BMFace *bmface;
141         bool is_space;
142
143         float mval[2]; /* mouse screen position (may be non-integral if snapped to something) */
144 } KnifePosData;
145
146 /* struct for properties used while drawing */
147 typedef struct KnifeTool_OpData {
148         ARegion *ar;        /* region that knifetool was activated in */
149         void *draw_handle;  /* for drawing preview loop */
150         ViewContext vc;     /* note: _don't_ use 'mval', instead use the one we define below */
151         float mval[2];      /* mouse value with snapping applied */
152         //bContext *C;
153
154         Object *ob;
155         BMEditMesh *em;
156
157         MemArena *arena;
158
159         GHash *origvertmap;
160         GHash *origedgemap;
161         GHash *kedgefacemap;
162         GHash *facetrimap;
163
164         BMBVHTree *bmbvh;
165
166         BLI_mempool *kverts;
167         BLI_mempool *kedges;
168
169         float vthresh;
170         float ethresh;
171
172         /* used for drag-cutting */
173         KnifeLineHit *linehits;
174         int totlinehit;
175
176         /* Data for mouse-position-derived data (cur) and previous click (prev) */
177         KnifePosData curr, prev;
178
179         int totkedge, totkvert;
180
181         BLI_mempool *refs;
182
183         float projmat[4][4];
184
185         KnifeColors colors;
186
187         /* run by the UI or not */
188         bool is_interactive;
189
190         /* operatpr options */
191         bool cut_through;    /* preference, can be modified at runtime (that feature may go) */
192         bool only_select;    /* set on initialization */
193         bool select_result;  /* set on initialization */
194
195         bool is_ortho;
196         float ortho_extent;
197         float clipsta, clipend;
198
199         enum {
200                 MODE_IDLE,
201                 MODE_DRAGGING,
202                 MODE_CONNECT,
203                 MODE_PANNING
204         } mode;
205
206         int prevmode;
207         bool snap_midpoints;
208         bool ignore_edge_snapping;
209         bool ignore_vert_snapping;
210
211         enum {
212                 ANGLE_FREE,
213                 ANGLE_0,
214                 ANGLE_45,
215                 ANGLE_90,
216                 ANGLE_135
217         } angle_snapping;
218
219         const float (*cagecos)[3];
220 } KnifeTool_OpData;
221
222 static ListBase *knife_get_face_kedges(KnifeTool_OpData *kcd, BMFace *f);
223
224 static void knife_input_ray_segment(KnifeTool_OpData *kcd, const float mval[2], const float ofs,
225                                     float r_origin[3], float r_dest[3]);
226
227 static bool knife_verts_edge_in_face(KnifeVert *v1, KnifeVert *v2, BMFace *f);
228
229 static void knife_update_header(bContext *C, KnifeTool_OpData *kcd)
230 {
231 #define HEADER_LENGTH 256
232         char header[HEADER_LENGTH];
233
234         BLI_snprintf(header, HEADER_LENGTH, IFACE_("LMB: define cut lines, Return/Spacebar: confirm, Esc or RMB: cancel, "
235                                                    "E: new cut, Ctrl: midpoint snap (%s), Shift: ignore snap (%s), "
236                                                    "C: angle constrain (%s), Z: cut through (%s)"),
237                      WM_bool_as_string(kcd->snap_midpoints),
238                      WM_bool_as_string(kcd->ignore_edge_snapping),
239                      WM_bool_as_string(kcd->angle_snapping),
240                      WM_bool_as_string(kcd->cut_through));
241         ED_area_headerprint(CTX_wm_area(C), header);
242 #undef HEADER_LENGTH
243 }
244
245 static void knife_project_v2(const KnifeTool_OpData *kcd, const float co[3], float sco[2])
246 {
247         ED_view3d_project_float_v2_m4(kcd->ar, co, sco, (float (*)[4])kcd->projmat);
248 }
249
250 static void knife_pos_data_clear(KnifePosData *kpd)
251 {
252         zero_v3(kpd->co);
253         zero_v3(kpd->cage);
254         kpd->vert = NULL;
255         kpd->edge = NULL;
256         kpd->bmface = NULL;
257         zero_v2(kpd->mval);
258 }
259
260 static ListBase *knife_empty_list(KnifeTool_OpData *kcd)
261 {
262         ListBase *lst;
263
264         lst = BLI_memarena_alloc(kcd->arena, sizeof(ListBase));
265         lst->first = lst->last = NULL;
266         return lst;
267 }
268
269 static void knife_append_list(KnifeTool_OpData *kcd, ListBase *lst, void *elem)
270 {
271         Ref *ref;
272
273         ref = BLI_mempool_calloc(kcd->refs);
274         ref->ref = elem;
275         BLI_addtail(lst, ref);
276 }
277
278 static Ref *find_ref(ListBase *lb, void *ref)
279 {
280         Ref *ref1;
281
282         for (ref1 = lb->first; ref1; ref1 = ref1->next) {
283                 if (ref1->ref == ref)
284                         return ref1;
285         }
286
287         return NULL;
288 }
289
290 static void knife_append_list_no_dup(KnifeTool_OpData *kcd, ListBase *lst, void *elem)
291 {
292         if (!find_ref(lst, elem))
293                 knife_append_list(kcd, lst, elem);
294 }
295
296 static KnifeEdge *new_knife_edge(KnifeTool_OpData *kcd)
297 {
298         kcd->totkedge++;
299         return BLI_mempool_calloc(kcd->kedges);
300 }
301
302 static void knife_add_to_vert_edges(KnifeTool_OpData *kcd, KnifeEdge *kfe)
303 {
304         knife_append_list(kcd, &kfe->v1->edges, kfe);
305         knife_append_list(kcd, &kfe->v2->edges, kfe);
306 }
307
308 /* Add faces of an edge to a KnifeVert's faces list.  No checks for dups. */
309 static void knife_add_edge_faces_to_vert(KnifeTool_OpData *kcd, KnifeVert *kfv, BMEdge *e)
310 {
311         BMIter bmiter;
312         BMFace *f;
313
314         BM_ITER_ELEM (f, &bmiter, e, BM_FACES_OF_EDGE) {
315                 knife_append_list(kcd, &kfv->faces, f);
316         }
317 }
318
319 /* Find a face in common in the two faces lists.
320  * If more than one, return the first; if none, return NULL */
321 static BMFace *knife_find_common_face(ListBase *faces1, ListBase *faces2)
322 {
323         Ref *ref1, *ref2;
324
325         for (ref1 = faces1->first; ref1; ref1 = ref1->next) {
326                 for (ref2 = faces2->first; ref2; ref2 = ref2->next) {
327                         if (ref1->ref == ref2->ref)
328                                 return (BMFace *)(ref1->ref);
329                 }
330         }
331         return NULL;
332 }
333
334 static KnifeVert *new_knife_vert(KnifeTool_OpData *kcd, const float co[3], const float cageco[3])
335 {
336         KnifeVert *kfv = BLI_mempool_calloc(kcd->kverts);
337
338         kcd->totkvert++;
339
340         copy_v3_v3(kfv->co, co);
341         copy_v3_v3(kfv->cageco, cageco);
342
343         knife_project_v2(kcd, kfv->co, kfv->sco);
344
345         return kfv;
346 }
347
348 /* get a KnifeVert wrapper for an existing BMVert */
349 static KnifeVert *get_bm_knife_vert(KnifeTool_OpData *kcd, BMVert *v)
350 {
351         KnifeVert *kfv = BLI_ghash_lookup(kcd->origvertmap, v);
352         const float *cageco;
353
354         if (!kfv) {
355                 BMIter bmiter;
356                 BMFace *f;
357
358                 if (BM_elem_index_get(v) >= 0)
359                         cageco = kcd->cagecos[BM_elem_index_get(v)];
360                 else
361                         cageco = v->co;
362                 kfv = new_knife_vert(kcd, v->co, cageco);
363                 kfv->v = v;
364                 BLI_ghash_insert(kcd->origvertmap, v, kfv);
365                 BM_ITER_ELEM (f, &bmiter, v, BM_FACES_OF_VERT) {
366                         knife_append_list(kcd, &kfv->faces, f);
367                 }
368         }
369
370         return kfv;
371 }
372
373 /* get a KnifeEdge wrapper for an existing BMEdge */
374 static KnifeEdge *get_bm_knife_edge(KnifeTool_OpData *kcd, BMEdge *e)
375 {
376         KnifeEdge *kfe = BLI_ghash_lookup(kcd->origedgemap, e);
377         if (!kfe) {
378                 BMIter bmiter;
379                 BMFace *f;
380
381                 kfe = new_knife_edge(kcd);
382                 kfe->e = e;
383                 kfe->v1 = get_bm_knife_vert(kcd, e->v1);
384                 kfe->v2 = get_bm_knife_vert(kcd, e->v2);
385
386                 knife_add_to_vert_edges(kcd, kfe);
387
388                 BLI_ghash_insert(kcd->origedgemap, e, kfe);
389
390                 BM_ITER_ELEM (f, &bmiter, e, BM_FACES_OF_EDGE) {
391                         knife_append_list(kcd, &kfe->faces, f);
392                 }
393         }
394
395         return kfe;
396 }
397
398 /* Record the index in kcd->em->looptris of first looptri triple for a given face,
399  * given an index for some triple in that array.
400  * This assumes that all of the triangles for a given face are contiguous
401  * in that array (as they are by the current tesselation routines).
402  * Actually store index + 1 in the hash, because 0 looks like "no entry"
403  * to hash lookup routine; will reverse this in the get routine.
404  * Doing this lazily rather than all at once for all faces.
405  */
406 static void set_lowest_face_tri(KnifeTool_OpData *kcd, BMFace *f, int index)
407 {
408         int i;
409
410         if (BLI_ghash_lookup(kcd->facetrimap, f))
411                 return;
412
413         BLI_assert(index >= 0 && index < kcd->em->tottri);
414         BLI_assert(kcd->em->looptris[index][0]->f == f);
415         for (i = index - 1; i >= 0; i--) {
416                 if (kcd->em->looptris[i][0]->f != f) {
417                         i++;
418                         break;
419                 }
420         }
421         if (i == -1)
422                 i++;
423
424         BLI_ghash_insert(kcd->facetrimap, f, SET_INT_IN_POINTER(i + 1));
425 }
426
427 /* This should only be called for faces that have had a lowest face tri set by previous function */
428 static int get_lowest_face_tri(KnifeTool_OpData *kcd, BMFace *f)
429 {
430         int ans;
431
432         ans = GET_INT_FROM_POINTER(BLI_ghash_lookup(kcd->facetrimap, f));
433         BLI_assert(ans != 0);
434         return ans - 1;
435 }
436
437 /* User has just clicked for first time or first time after a restart (E key).
438  * Copy the current position data into prev. */
439 static void knife_start_cut(KnifeTool_OpData *kcd)
440 {
441         kcd->prev = kcd->curr;
442         kcd->curr.is_space = 0; /*TODO: why do we do this? */
443
444         if (kcd->prev.vert == NULL && kcd->prev.edge == NULL && is_zero_v3(kcd->prev.cage)) {
445                 /* Make prevcage a point on the view ray to mouse closest to a point on model: choose vertex 0 */
446                 float origin[3], origin_ofs[3];
447                 BMVert *v0;
448
449                 knife_input_ray_segment(kcd, kcd->curr.mval, 1.0f, origin, origin_ofs);
450                 v0 = BM_vert_at_index_find(kcd->em->bm, 0);
451                 if (v0) {
452                         closest_to_line_v3(kcd->prev.cage, v0->co, origin_ofs, origin);
453                         copy_v3_v3(kcd->prev.co, kcd->prev.cage); /*TODO: do we need this? */
454                         copy_v3_v3(kcd->curr.cage, kcd->prev.cage);
455                         copy_v3_v3(kcd->curr.co, kcd->prev.co);
456                 }
457         }
458 }
459
460 static ListBase *knife_get_face_kedges(KnifeTool_OpData *kcd, BMFace *f)
461 {
462         ListBase *lst = BLI_ghash_lookup(kcd->kedgefacemap, f);
463
464         if (!lst) {
465                 BMIter bmiter;
466                 BMEdge *e;
467
468                 lst = knife_empty_list(kcd);
469
470                 BM_ITER_ELEM (e, &bmiter, f, BM_EDGES_OF_FACE) {
471                         knife_append_list(kcd, lst, get_bm_knife_edge(kcd, e));
472                 }
473
474                 BLI_ghash_insert(kcd->kedgefacemap, f, lst);
475         }
476
477         return lst;
478 }
479
480 static void knife_edge_append_face(KnifeTool_OpData *kcd, KnifeEdge *kfe, BMFace *f)
481 {
482         knife_append_list(kcd, knife_get_face_kedges(kcd, f), kfe);
483         knife_append_list(kcd, &kfe->faces, f);
484 }
485
486 static KnifeVert *knife_split_edge(KnifeTool_OpData *kcd, KnifeEdge *kfe, float co[3], KnifeEdge **newkfe_out)
487 {
488         KnifeEdge *newkfe = new_knife_edge(kcd);
489         Ref *ref;
490         BMFace *f;
491         float perc, cageco[3], l12;
492
493         l12 = len_v3v3(kfe->v1->co, kfe->v2->co);
494         if (l12 < KNIFE_FLT_EPS) {
495                 copy_v3_v3(cageco, kfe->v1->cageco);
496         }
497         else {
498                 perc = len_v3v3(co, kfe->v1->co) / l12;
499                 interp_v3_v3v3(cageco, kfe->v1->cageco, kfe->v2->cageco, perc);
500         }
501
502         newkfe->v1 = kfe->v1;
503         newkfe->v2 = new_knife_vert(kcd, co, cageco);
504         newkfe->v2->draw = 1;
505         if (kfe->e) {
506                 knife_add_edge_faces_to_vert(kcd, newkfe->v2, kfe->e);
507         }
508         else {
509                 /* kfe cuts across an existing face.
510                  * If v1 and v2 are in multiple faces together (e.g., if they
511                  * are in doubled polys) then this arbitrarily chooses one of them */
512                 f = knife_find_common_face(&kfe->v1->faces, &kfe->v2->faces);
513                 if (f)
514                         knife_append_list(kcd, &newkfe->v2->faces, f);
515         }
516         newkfe->basef = kfe->basef;
517
518         ref = find_ref(&kfe->v1->edges, kfe);
519         BLI_remlink(&kfe->v1->edges, ref);
520
521         kfe->v1 = newkfe->v2;
522         BLI_addtail(&kfe->v1->edges, ref);
523
524         for (ref = kfe->faces.first; ref; ref = ref->next)
525                 knife_edge_append_face(kcd, newkfe, ref->ref);
526
527         knife_add_to_vert_edges(kcd, newkfe);
528
529         newkfe->draw = kfe->draw;
530         newkfe->e = kfe->e;
531
532         *newkfe_out = newkfe;
533
534         return newkfe->v2;
535 }
536
537 /* primary key: lambda along cut
538  * secondary key: lambda along depth
539  * tertiary key: pointer comparisons of verts if both snapped to verts
540  */
541 static int linehit_compare(const void *vlh1, const void *vlh2)
542 {
543         const KnifeLineHit *lh1 = vlh1;
544         const KnifeLineHit *lh2 = vlh2;
545
546         if      (lh1->l < lh2->l) return -1;
547         else if (lh1->l > lh2->l) return  1;
548         else {
549                 if      (lh1->m < lh2->m) return -1;
550                 else if (lh1->m > lh2->m) return  1;
551                 else {
552                         if      (lh1->v < lh2->v) return -1;
553                         else if (lh1->v > lh2->v) return  1;
554                         else return 0;
555                 }
556         }
557 }
558
559 /*
560  * Sort linehits by distance along cut line, and secondarily from
561  * front to back (from eye), and tertiarily by snap vertex,
562  * and remove any duplicates.
563  */
564 static void prepare_linehits_for_cut(KnifeTool_OpData *kcd)
565 {
566         KnifeLineHit *linehits, *lhi, *lhj;
567         int i, j, n;
568
569         n = kcd->totlinehit;
570         linehits = kcd->linehits;
571         if (n == 0)
572                 return;
573
574         qsort(linehits, n, sizeof(KnifeLineHit), linehit_compare);
575
576         /* Remove any edge hits that are preceded or followed
577          * by a vertex hit that is very near. Mark such edge hits using
578          * l == -1 and then do another pass to actually remove.
579          * Also remove all but one of a series of vertex hits for the same vertex. */
580         for (i = 0; i < n; i++) {
581                 lhi = &linehits[i];
582                 if (lhi->v) {
583                         for (j = i - 1; j >= 0; j--) {
584                                 lhj = &linehits[j];
585                                 if (!lhj->kfe ||
586                                     fabsf(lhi->l - lhj->l) > KNIFE_FLT_EPSBIG ||
587                                     fabsf(lhi->m - lhj->m) > KNIFE_FLT_EPSBIG)
588                                 {
589                                         break;
590                                 }
591                                 lhj->l = -1.0f;
592                         }
593                         for (j = i + 1; j < n; j++) {
594                                 lhj = &linehits[j];
595                                 if (fabsf(lhi->l - lhj->l) > KNIFE_FLT_EPSBIG ||
596                                     fabsf(lhi->m - lhj->m) > KNIFE_FLT_EPSBIG)
597                                 {
598                                         break;
599                                 }
600                                 if (lhj->kfe || lhi->v == lhj->v) {
601                                         lhj->l = -1.0f;
602                                 }
603                         }
604                 }
605         }
606
607         /* delete-in-place loop: copying from pos j to pos i+1 */
608         i = 0;
609         j = 1;
610         while (j < n) {
611                 lhi = &linehits[i];
612                 lhj = &linehits[j];
613                 if (lhj->l == -1.0f) {
614                         j++; /* skip copying this one */
615                 }
616                 else {
617                         /* copy unless a no-op */
618                         if (lhi->l == -1.0f) {
619                                 /* could happen if linehits[0] is being deleted */
620                                 memcpy(&linehits[i], &linehits[j], sizeof(KnifeLineHit));
621                         }
622                         else {
623                                 if (i + 1 != j)
624                                         memcpy(&linehits[i + 1], &linehits[j], sizeof(KnifeLineHit));
625                                 i++;
626                         }
627                         j++;
628                 }
629         }
630         kcd->totlinehit = i + 1;
631 }
632
633 /* Add hit to list of hits in facehits[f], where facehits is a map, if not already there */
634 static void add_hit_to_facehits(KnifeTool_OpData *kcd, GHash *facehits, BMFace *f, KnifeLineHit *hit)
635 {
636         ListBase *lst = BLI_ghash_lookup(facehits, f);
637
638         if (!lst) {
639                 lst = knife_empty_list(kcd);
640                 BLI_ghash_insert(facehits, f, lst);
641         }
642         knife_append_list_no_dup(kcd, lst, hit);
643 }
644
645 static void knife_add_single_cut(KnifeTool_OpData *kcd, KnifeLineHit *lh1, KnifeLineHit *lh2, BMFace *f)
646 {
647         KnifeEdge *kfe, *kfe2;
648
649         if ((lh1->v && lh1->v == lh2->v) ||
650             (lh1->kfe && lh1->kfe == lh2->kfe))
651         {
652                 return;
653         }
654
655         /* Check if edge actually lies within face (might not, if this face is concave) */
656         if (lh1->v && lh2->v) {
657                 if (!knife_verts_edge_in_face(lh1->v, lh2->v, f)) {
658                         return;
659                 }
660         }
661
662         kfe = new_knife_edge(kcd);
663         kfe->draw = true;
664         kfe->basef = f;
665
666         if (lh1->v) {
667                 kfe->v1 = lh1->v;
668         }
669         else if (lh1->kfe) {
670                 kfe->v1 = knife_split_edge(kcd, lh1->kfe, lh1->cagehit, &kfe2);
671                 lh1->v = kfe->v1;  /* record the KnifeVert for this hit  */
672         }
673         else {
674                 BLI_assert(lh1->f);
675                 kfe->v1 = new_knife_vert(kcd, lh1->hit, lh1->cagehit);
676                 kfe->v1->draw = true;
677                 kfe->v1->is_face = true;
678                 knife_append_list(kcd, &kfe->v1->faces, lh1->f);
679                 lh1->v = kfe->v1;  /* record the KnifeVert for this hit */
680         }
681
682         if (lh2->v) {
683                 kfe->v2 = lh2->v;
684         }
685         else if (lh2->kfe) {
686                 kfe->v2 = knife_split_edge(kcd, lh2->kfe, lh2->cagehit, &kfe2);
687                 lh2->v = kfe->v2;  /* future uses of lh2 won't split again */
688         }
689         else {
690                 BLI_assert(lh2->f);
691                 kfe->v2 = new_knife_vert(kcd, lh2->hit, lh2->cagehit);
692                 kfe->v2->draw = true;
693                 kfe->v2->is_face = true;
694                 knife_append_list(kcd, &kfe->v2->faces, lh2->f);
695                 lh2->v = kfe->v2;  /* record the KnifeVert for this hit */
696         }
697
698         knife_add_to_vert_edges(kcd, kfe);
699
700         /* TODO: check if this is ever needed */
701         if (kfe->basef && !find_ref(&kfe->faces, kfe->basef))
702                 knife_edge_append_face(kcd, kfe, kfe->basef);
703
704 }
705
706 /* Given a list of KnifeLineHits for one face, sorted by l
707  * and then by m, make the required KnifeVerts and
708  * KnifeEdges.
709  */
710 static void knife_cut_face(KnifeTool_OpData *kcd, BMFace *f, ListBase *hits)
711 {
712         Ref *r;
713         KnifeLineHit *lh, *prevlh;
714         int n;
715
716         (void) kcd;
717
718         n = BLI_countlist(hits);
719         if (n < 2)
720                 return;
721
722         prevlh = NULL;
723         for (r = hits->first; r; r = r->next) {
724                 lh = (KnifeLineHit *)r->ref;
725                 if (prevlh)
726                         knife_add_single_cut(kcd, prevlh, lh, f);
727                 prevlh = lh;
728         }
729
730 }
731
732 /* User has just left-clicked after the first time.
733  * Add all knife cuts implied by line from prev to curr.
734  * If that line crossed edges then kcd->linehits will be non-NULL.
735  * Make all of the KnifeVerts and KnifeEdges implied by this cut.
736  */
737 static void knife_add_cut(KnifeTool_OpData *kcd)
738 {
739         int i;
740         KnifeLineHit *lh;
741         GHash *facehits;
742         BMFace *f;
743         Ref *r;
744         GHashIterator giter;
745         ListBase *lst;
746
747         prepare_linehits_for_cut(kcd);
748         if (kcd->totlinehit == 0) {
749                 kcd->prev = kcd->curr;
750                 return;
751         }
752
753         /* make facehits: map face -> list of linehits touching it */
754         facehits = BLI_ghash_ptr_new("knife facehits");
755         for (i = 0; i < kcd->totlinehit; i++) {
756                 lh = &kcd->linehits[i];
757                 if (lh->f) {
758                         add_hit_to_facehits(kcd, facehits, lh->f, lh);
759                 }
760                 if (lh->v) {
761                         for (r = lh->v->faces.first; r; r = r->next) {
762                                 add_hit_to_facehits(kcd, facehits, r->ref, lh);
763                         }
764                 }
765                 if (lh->kfe) {
766                         for (r = lh->kfe->faces.first; r; r = r->next) {
767                                 add_hit_to_facehits(kcd, facehits, r->ref, lh);
768                         }
769                 }
770         }
771
772         /* Note: as following loop progresses, the 'v' fields of
773          * the linehits will be filled in (as edges are split or
774          * in-face verts are made), so it may be true that both
775          * the v and the kfe or f fields will be non-NULL. */
776         GHASH_ITER (giter, facehits) {
777                 f = (BMFace *)BLI_ghashIterator_getKey(&giter);
778                 lst = (ListBase *)BLI_ghashIterator_getValue(&giter);
779                 knife_cut_face(kcd, f, lst);
780         }
781
782         /* set up for next cut */
783         kcd->prev = kcd->curr;
784         if (kcd->prev.bmface) {
785                 /* was "in face" but now we have a KnifeVert it is snapped to */
786                 kcd->prev.bmface = NULL;
787                 kcd->prev.vert = kcd->linehits[kcd->totlinehit - 1].v;
788         }
789
790         BLI_ghash_free(facehits, NULL, NULL);
791         MEM_freeN(kcd->linehits);
792         kcd->linehits = NULL;
793         kcd->totlinehit = 0;
794 }
795
796 static void knife_finish_cut(KnifeTool_OpData *kcd)
797 {
798         if (kcd->linehits) {
799                 MEM_freeN(kcd->linehits);
800                 kcd->linehits = NULL;
801                 kcd->totlinehit = 0;
802         }
803 }
804
805 static void knifetool_draw_angle_snapping(const KnifeTool_OpData *kcd)
806 {
807         bglMats mats;
808         double u[3], u1[2], u2[2], v1[3], v2[3], dx, dy;
809         double wminx, wminy, wmaxx, wmaxy;
810
811         /* make u the window coords of prevcage */
812         view3d_get_transformation(kcd->ar, kcd->vc.rv3d, kcd->ob, &mats);
813         gluProject(kcd->prev.cage[0], kcd->prev.cage[1], kcd->prev.cage[2],
814                    mats.modelview, mats.projection, mats.viewport,
815                    &u[0], &u[1], &u[2]);
816
817         /* make u1, u2 the points on window going through u at snap angle */
818         wminx = kcd->ar->winrct.xmin;
819         wmaxx = kcd->ar->winrct.xmin + kcd->ar->winx;
820         wminy = kcd->ar->winrct.ymin;
821         wmaxy = kcd->ar->winrct.ymin + kcd->ar->winy;
822
823         switch (kcd->angle_snapping) {
824                 case ANGLE_0:
825                         u1[0] = wminx;
826                         u2[0] = wmaxx;
827                         u1[1] = u2[1] = u[1];
828                         break;
829                 case ANGLE_90:
830                         u1[0] = u2[0] = u[0];
831                         u1[1] = wminy;
832                         u2[1] = wmaxy;
833                         break;
834                 case ANGLE_45:
835                         /* clip against left or bottom */
836                         dx = u[0] - wminx;
837                         dy = u[1] - wminy;
838                         if (dy > dx) {
839                                 u1[0] = wminx;
840                                 u1[1] = u[1] - dx;
841                         }
842                         else {
843                                 u1[0] = u[0] - dy;
844                                 u1[1] = wminy;
845                         }
846                         /* clip against right or top */
847                         dx = wmaxx - u[0];
848                         dy = wmaxy - u[1];
849                         if (dy > dx) {
850                                 u2[0] = wmaxx;
851                                 u2[1] = u[1] + dx;
852                         }
853                         else {
854                                 u2[0] = u[0] + dy;
855                                 u2[1] = wmaxy;
856                         }
857                         break;
858                 case ANGLE_135:
859                         /* clip against right or bottom */
860                         dx = wmaxx - u[0];
861                         dy = u[1] - wminy;
862                         if (dy > dx) {
863                                 u1[0] = wmaxx;
864                                 u1[1] = u[1] - dx;
865                         }
866                         else {
867                                 u1[0] = u[0] + dy;
868                                 u1[1] = wminy;
869                         }
870                         /* clip against left or top */
871                         dx = u[0] - wminx;
872                         dy = wmaxy - u[1];
873                         if (dy > dx) {
874                                 u2[0] = wminx;
875                                 u2[1] = u[1] + dx;
876                         }
877                         else {
878                                 u2[0] = u[0] - dy;
879                                 u2[1] = wmaxy;
880                         }
881                         break;
882                 default:
883                         return;
884         }
885
886         /* unproject u1 and u2 back into object space */
887         gluUnProject(u1[0], u1[1], 0.0,
888                      mats.modelview, mats.projection, mats.viewport,
889                      &v1[0], &v1[1], &v1[2]);
890         gluUnProject(u2[0], u2[1], 0.0,
891                      mats.modelview, mats.projection, mats.viewport,
892                      &v2[0], &v2[1], &v2[2]);
893
894         UI_ThemeColor(TH_TRANSFORM);
895         glLineWidth(2.0);
896         glBegin(GL_LINES);
897         glVertex3dv(v1);
898         glVertex3dv(v2);
899         glEnd();
900 }
901
902 static void knife_init_colors(KnifeColors *colors)
903 {
904         /* possible BMESH_TODO: add explicit themes or calculate these by
905          * figuring out contrasting colors with grid / edges / verts
906          * a la UI_make_axis_color */
907         UI_GetThemeColor3ubv(TH_NURB_VLINE, colors->line);
908         UI_GetThemeColor3ubv(TH_NURB_ULINE, colors->edge);
909         UI_GetThemeColor3ubv(TH_HANDLE_SEL_VECT, colors->curpoint);
910         UI_GetThemeColor3ubv(TH_HANDLE_SEL_VECT, colors->curpoint_a);
911         colors->curpoint_a[3] = 102;
912         UI_GetThemeColor3ubv(TH_ACTIVE_SPLINE, colors->point);
913         UI_GetThemeColor3ubv(TH_ACTIVE_SPLINE, colors->point_a);
914         colors->point_a[3] = 102;
915 }
916
917 /* modal loop selection drawing callback */
918 static void knifetool_draw(const bContext *C, ARegion *UNUSED(ar), void *arg)
919 {
920         View3D *v3d = CTX_wm_view3d(C);
921         const KnifeTool_OpData *kcd = arg;
922
923         if (v3d->zbuf) glDisable(GL_DEPTH_TEST);
924
925         glPolygonOffset(1.0f, 1.0f);
926
927         glPushMatrix();
928         glMultMatrixf(kcd->ob->obmat);
929
930         if (kcd->mode == MODE_DRAGGING) {
931                 if (kcd->angle_snapping != ANGLE_FREE)
932                         knifetool_draw_angle_snapping(kcd);
933
934                 glColor3ubv(kcd->colors.line);
935                 
936                 glLineWidth(2.0);
937
938                 glBegin(GL_LINES);
939                 glVertex3fv(kcd->prev.cage);
940                 glVertex3fv(kcd->curr.cage);
941                 glEnd();
942
943                 glLineWidth(1.0);
944         }
945
946         if (kcd->prev.vert) {
947                 glColor3ubv(kcd->colors.point);
948                 glPointSize(11);
949
950                 glBegin(GL_POINTS);
951                 glVertex3fv(kcd->prev.cage);
952                 glEnd();
953         }
954
955         if (kcd->prev.bmface) {
956                 glColor3ubv(kcd->colors.curpoint);
957                 glPointSize(9);
958
959                 glBegin(GL_POINTS);
960                 glVertex3fv(kcd->prev.cage);
961                 glEnd();
962         }
963
964         if (kcd->curr.edge) {
965                 glColor3ubv(kcd->colors.edge);
966                 glLineWidth(2.0);
967
968                 glBegin(GL_LINES);
969                 glVertex3fv(kcd->curr.edge->v1->cageco);
970                 glVertex3fv(kcd->curr.edge->v2->cageco);
971                 glEnd();
972
973                 glLineWidth(1.0);
974         }
975         else if (kcd->curr.vert) {
976                 glColor3ubv(kcd->colors.point);
977                 glPointSize(11);
978
979                 glBegin(GL_POINTS);
980                 glVertex3fv(kcd->curr.cage);
981                 glEnd();
982         }
983
984         if (kcd->curr.bmface) {
985                 glColor3ubv(kcd->colors.curpoint);
986                 glPointSize(9);
987
988                 glBegin(GL_POINTS);
989                 glVertex3fv(kcd->curr.cage);
990                 glEnd();
991         }
992
993         if (kcd->totlinehit > 0) {
994                 KnifeLineHit *lh;
995                 int i;
996
997                 glEnable(GL_BLEND);
998                 glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
999
1000                 /* draw any snapped verts first */
1001                 glColor4ubv(kcd->colors.point_a);
1002                 glPointSize(11);
1003                 glBegin(GL_POINTS);
1004                 lh = kcd->linehits;
1005                 for (i = 0; i < kcd->totlinehit; i++, lh++) {
1006                         if (lh->v)
1007                                 glVertex3fv(lh->cagehit);
1008                 }
1009                 glEnd();
1010
1011                 /* now draw the rest */
1012                 glColor4ubv(kcd->colors.curpoint_a);
1013                 glPointSize(7);
1014                 glBegin(GL_POINTS);
1015                 lh = kcd->linehits;
1016                 for (i = 0; i < kcd->totlinehit; i++, lh++) {
1017                         if (!lh->v)
1018                                 glVertex3fv(lh->cagehit);
1019                 }
1020                 glEnd();
1021                 glDisable(GL_BLEND);
1022         }
1023
1024         if (kcd->totkedge > 0) {
1025                 BLI_mempool_iter iter;
1026                 KnifeEdge *kfe;
1027
1028                 glLineWidth(1.0);
1029                 glBegin(GL_LINES);
1030
1031                 BLI_mempool_iternew(kcd->kedges, &iter);
1032                 for (kfe = BLI_mempool_iterstep(&iter); kfe; kfe = BLI_mempool_iterstep(&iter)) {
1033                         if (!kfe->draw)
1034                                 continue;
1035
1036                         glColor3ubv(kcd->colors.line);
1037
1038                         glVertex3fv(kfe->v1->cageco);
1039                         glVertex3fv(kfe->v2->cageco);
1040                 }
1041
1042                 glEnd();
1043                 glLineWidth(1.0);
1044         }
1045
1046         if (kcd->totkvert > 0) {
1047                 BLI_mempool_iter iter;
1048                 KnifeVert *kfv;
1049
1050                 glPointSize(5.0);
1051
1052                 glBegin(GL_POINTS);
1053                 BLI_mempool_iternew(kcd->kverts, &iter);
1054                 for (kfv = BLI_mempool_iterstep(&iter); kfv; kfv = BLI_mempool_iterstep(&iter)) {
1055                         if (!kfv->draw)
1056                                 continue;
1057
1058                         glColor3ubv(kcd->colors.point);
1059
1060                         glVertex3fv(kfv->cageco);
1061                 }
1062
1063                 glEnd();
1064         }
1065
1066         glPopMatrix();
1067
1068         if (v3d->zbuf) glEnable(GL_DEPTH_TEST);
1069 }
1070
1071 /* Find intersection of v1-v2 with face f.
1072  * Only take intersections that are at least face_tol (in screen space) away
1073  * from other intersection elements.
1074  * If v1-v2 is coplanar with f, call that "no intersection though
1075  * it really means "infinite number of intersections".
1076  * In such a case we should have gotten hits on edges or verts of the face. */
1077 static bool knife_ray_intersect_face(KnifeTool_OpData *kcd,
1078                                      const float s[2],
1079                                      const float v1[3], const float v2[3],
1080                                      BMFace *f,
1081                                      const float face_tol,
1082                                      float intersectp[3])
1083 {
1084         int tottri, tri_i;
1085         float lv1[3], lv2[3], lv3[3], raydir[3];
1086         float tri_norm[3], tri_plane[4];
1087         float se1[2], se2[2];
1088         float d, lambda;
1089         BMLoop **tri;
1090         ListBase *lst;
1091         Ref *ref;
1092         KnifeEdge *kfe;
1093
1094         sub_v3_v3v3(raydir, v2, v1);
1095         normalize_v3(raydir);
1096         tri_i = get_lowest_face_tri(kcd, f);
1097         tottri = kcd->em->tottri;
1098         BLI_assert(tri_i >= 0 && tri_i < tottri);
1099
1100         for (; tri_i < tottri; tri_i++) {
1101                 tri = kcd->em->looptris[tri_i];
1102                 if (tri[0]->f != f)
1103                         break;
1104                 copy_v3_v3(lv1, kcd->cagecos[BM_elem_index_get(tri[0]->v)]);
1105                 copy_v3_v3(lv2, kcd->cagecos[BM_elem_index_get(tri[1]->v)]);
1106                 copy_v3_v3(lv3, kcd->cagecos[BM_elem_index_get(tri[2]->v)]);
1107                 /* using epsilon test in case ray is directly through an internal
1108                  * tesselation edge and might not hit either tesselation tri with
1109                  * an exact test;
1110                  * we will exclude hits near real edges by a later test */
1111                 if (isect_ray_tri_epsilon_v3(v1, raydir, lv1, lv2, lv3, &lambda, NULL, KNIFE_FLT_EPS)) {
1112                         /* check if line coplanar with tri */
1113                         normal_tri_v3(tri_norm, lv1, lv2, lv3);
1114                         plane_from_point_normal_v3(tri_plane, lv1, tri_norm);
1115                         if ((fabsf(dist_squared_to_plane_v3(v1, tri_plane)) < KNIFE_FLT_EPS) &&
1116                             (fabsf(dist_squared_to_plane_v3(v2, tri_plane)) < KNIFE_FLT_EPS))
1117                         {
1118                                 return false;
1119                         }
1120                         copy_v3_v3(intersectp, v1);
1121                         madd_v3_v3fl(intersectp, raydir, lambda);
1122                         /* Now check that far enough away from verts and edges */
1123                         lst = knife_get_face_kedges(kcd, f);
1124                         for (ref = lst->first; ref; ref = ref->next) {
1125                                 kfe = ref->ref;
1126                                 knife_project_v2(kcd, kfe->v1->cageco, se1);
1127                                 knife_project_v2(kcd, kfe->v2->cageco, se2);
1128                                 d = dist_to_line_segment_v2(s, se1, se2);
1129                                 if (d < face_tol) {
1130                                         return false;
1131                                 }
1132                         }
1133                         return true;
1134                 }
1135         }
1136         return false;
1137 }
1138
1139 /* Calculate maximum excursion from (0,0,0) of mesh */
1140 static void calc_ortho_extent(KnifeTool_OpData *kcd)
1141 {
1142         BMIter iter;
1143         BMVert *v;
1144         BMesh *bm = kcd->em->bm;
1145         float max_xyz = 0.0f;
1146         int i;
1147
1148         BM_ITER_MESH (v, &iter, bm, BM_VERTS_OF_MESH) {
1149                 for (i = 0; i < 3; i++)
1150                         max_xyz = max_ff(max_xyz, fabs(v->co[i]));
1151         }
1152         kcd->ortho_extent = max_xyz;
1153 }
1154
1155 /* Check if p is visible (not clipped, not occluded by another face).
1156  * s in screen projection of p. */
1157 static bool point_is_visible(KnifeTool_OpData *kcd, const float p[3], const float s[2], bglMats *mats)
1158 {
1159         float p1[3], no[3], view[3];
1160         BMFace *f_hit;
1161
1162         /* If not cutting through, make sure no face is in front of p */
1163         if (!kcd->cut_through) {
1164                 /* TODO: I think there's a simpler way to get the required raycast ray */
1165                 ED_view3d_unproject(mats, view, s[0], s[1], 0.0f);
1166                 mul_m4_v3(kcd->ob->imat, view);
1167
1168                 /* make p1 a little towards view, so ray doesn't hit p's face. */
1169                 copy_v3_v3(p1, p);
1170                 sub_v3_v3(view, p1);
1171                 normalize_v3(view);
1172                 copy_v3_v3(no, view);
1173                 mul_v3_fl(no, 3.0f * KNIFE_FLT_EPSBIG);
1174                 add_v3_v3(p1, no);
1175
1176                 /* see if there's a face hit between p1 and the view */
1177                 f_hit = BKE_bmbvh_ray_cast(kcd->bmbvh, p1, no, KNIFE_FLT_EPS, NULL, NULL, NULL);
1178                 if (f_hit)
1179                         return false;
1180         }
1181
1182         /* If box clipping on, make sure p is not clipped */
1183         if (kcd->vc.rv3d->rflag & RV3D_CLIPPING &&
1184             ED_view3d_clipping_test(kcd->vc.rv3d, p, true))
1185         {
1186                 return false;
1187         }
1188
1189         return true;
1190 }
1191
1192 /* Clip the line (v1, v2) to planes perpendicular to it and distances d from
1193  * the closest point on the line to the origin */
1194 static void clip_to_ortho_planes(float v1[3], float v2[3], float d)
1195 {
1196         float closest[3];
1197         const float origin[3] = {0.0f, 0.0f, 0.0f};
1198
1199         closest_to_line_v3(closest, origin, v1, v2);
1200         dist_ensure_v3_v3fl(v1, closest, d);
1201         dist_ensure_v3_v3fl(v2, closest, d);
1202 }
1203
1204 static void set_linehit_depth(KnifeTool_OpData *kcd, KnifeLineHit *lh)
1205 {
1206         float vnear[3], vfar[3];
1207
1208         ED_view3d_win_to_segment(kcd->ar, kcd->vc.v3d, lh->schit, vnear, vfar, true);
1209         mul_m4_v3(kcd->ob->imat, vnear);
1210         if (kcd->is_ortho) {
1211                 if (kcd->ortho_extent == 0.0f)
1212                         calc_ortho_extent(kcd);
1213                 clip_to_ortho_planes(vnear, vfar, kcd->ortho_extent + 10.0f);
1214         }
1215         lh->m = len_v3v3(vnear, lh->cagehit);
1216 }
1217
1218 /* Finds visible (or all, if cutting through) edges that intersects the current screen drag line */
1219 static void knife_find_line_hits(KnifeTool_OpData *kcd)
1220 {
1221         bglMats mats;
1222         SmallHash faces, kfes, kfvs;
1223         float v1[3], v2[3], v3[3], v4[3], s1[2], s2[2];
1224         BVHTree *planetree, *tree;
1225         BVHTreeOverlap *results, *result;
1226         BMLoop **ls;
1227         BMFace *f;
1228         KnifeEdge *kfe;
1229         KnifeVert *v;
1230         ListBase *lst;
1231         Ref *ref;
1232         KnifeLineHit *linehits = NULL;
1233         BLI_array_declare(linehits);
1234         SmallHashIter hiter;
1235         KnifeLineHit hit;
1236         void *val;
1237         float plane_cos[12];
1238         float s[2], se1[2], se2[2], sint[2];
1239         float p[3], p2[3], r1[3], r2[3];
1240         float d, d1, d2, lambda;
1241         float vert_tol, vert_tol_sq, line_tol, face_tol;
1242         int isect_kind;
1243         unsigned int tot;
1244         int i;
1245
1246         bgl_get_mats(&mats);
1247
1248         if (kcd->linehits) {
1249                 MEM_freeN(kcd->linehits);
1250                 kcd->linehits = NULL;
1251                 kcd->totlinehit = 0;
1252         }
1253
1254         copy_v3_v3(v1, kcd->prev.cage);
1255         copy_v3_v3(v2, kcd->curr.cage);
1256
1257         /* project screen line's 3d coordinates back into 2d */
1258         knife_project_v2(kcd, v1, s1);
1259         knife_project_v2(kcd, v2, s2);
1260
1261         if (kcd->is_interactive) {
1262                 if (len_squared_v2v2(s1, s2) < 1.0f) {
1263                         return;
1264                 }
1265         }
1266         else {
1267                 if (len_squared_v2v2(s1, s2) < KNIFE_FLT_EPS_SQUARED) {
1268                         return;
1269                 }
1270         }
1271
1272         /* unproject screen line */
1273         ED_view3d_win_to_segment(kcd->ar, kcd->vc.v3d, s1, v1, v3, true);
1274         ED_view3d_win_to_segment(kcd->ar, kcd->vc.v3d, s2, v2, v4, true);
1275
1276         mul_m4_v3(kcd->ob->imat, v1);
1277         mul_m4_v3(kcd->ob->imat, v2);
1278         mul_m4_v3(kcd->ob->imat, v3);
1279         mul_m4_v3(kcd->ob->imat, v4);
1280
1281         /* numeric error, 'v1' -> 'v2', 'v2' -> 'v4' can end up being ~2000 units apart in otho mode
1282          * (from ED_view3d_win_to_segment_clip() above)
1283          * this gives precision error; rather then solving properly
1284          * (which may involve using doubles everywhere!),
1285          * limit the distance between these points */
1286         if (kcd->is_ortho) {
1287                 if (kcd->ortho_extent == 0.0f)
1288                         calc_ortho_extent(kcd);
1289                 clip_to_ortho_planes(v1, v3, kcd->ortho_extent + 10.0f);
1290                 clip_to_ortho_planes(v2, v4, kcd->ortho_extent + 10.0f);
1291         }
1292
1293         /* First use bvh tree to find faces, knife edges, and knife verts that might
1294          * intersect the cut plane with rays v1-v3 and v2-v4.
1295          * This deduplicates the candidates before doing more expensive intersection tests. */
1296
1297         tree = BKE_bmbvh_tree_get(kcd->bmbvh);
1298         planetree = BLI_bvhtree_new(4, FLT_EPSILON * 4, 8, 8);
1299         copy_v3_v3(plane_cos + 0, v1);
1300         copy_v3_v3(plane_cos + 3, v2);
1301         copy_v3_v3(plane_cos + 6, v3);
1302         copy_v3_v3(plane_cos + 9, v4);
1303         BLI_bvhtree_insert(planetree, 0, plane_cos, 4);
1304         BLI_bvhtree_balance(planetree);
1305
1306         results = BLI_bvhtree_overlap(tree, planetree, &tot);
1307         if (!results) {
1308                 BLI_bvhtree_free(planetree);
1309                 return;
1310         }
1311
1312         BLI_smallhash_init(&faces);
1313         BLI_smallhash_init(&kfes);
1314         BLI_smallhash_init(&kfvs);
1315
1316         for (i = 0, result = results; i < tot; i++, result++) {
1317                 ls = (BMLoop **)kcd->em->looptris[result->indexA];
1318                 f = ls[0]->f;
1319                 set_lowest_face_tri(kcd, f, result->indexA);
1320                 /* for faces, store index of lowest hit looptri in hash */
1321                 if (BLI_smallhash_haskey(&faces, (uintptr_t)f)) {
1322                         continue;
1323                 }
1324                 /* don't care what the value is except that it is non-NULL, for iterator */
1325                 BLI_smallhash_insert(&faces, (uintptr_t)f, f);
1326
1327                 lst = knife_get_face_kedges(kcd, f);
1328                 for (ref = lst->first; ref; ref = ref->next) {
1329                         kfe = ref->ref;
1330                         if (BLI_smallhash_haskey(&kfes, (uintptr_t)kfe))
1331                                 continue;
1332                         BLI_smallhash_insert(&kfes, (uintptr_t)kfe, kfe);
1333                         v = kfe->v1;
1334                         if (!BLI_smallhash_haskey(&kfvs, (uintptr_t)v))
1335                                 BLI_smallhash_insert(&kfvs, (uintptr_t)v, v);
1336                         v = kfe->v2;
1337                         if (!BLI_smallhash_haskey(&kfvs, (uintptr_t)v))
1338                                 BLI_smallhash_insert(&kfvs, (uintptr_t)v, v);
1339                 }
1340         }
1341
1342         /* Now go through the candidates and find intersections */
1343         /* These tolerances, in screen space, are for intermediate hits, as ends are already snapped to screen */
1344         vert_tol = KNIFE_FLT_EPS * 2000.0f;
1345         line_tol = KNIFE_FLT_EPS * 2000.0f;
1346         vert_tol_sq = vert_tol * vert_tol;
1347         face_tol = max_ff(vert_tol, line_tol);
1348         /* Assume these tolerances swamp floating point rounding errors in calculations below */
1349
1350         /* first look for vertex hits */
1351         for (val = BLI_smallhash_iternew(&kfvs, &hiter, (uintptr_t *)&v); val;
1352              val = BLI_smallhash_iternext(&hiter, (uintptr_t *)&v))
1353         {
1354                 knife_project_v2(kcd, v->cageco, s);
1355                 d = dist_squared_to_line_segment_v2(s, s1, s2);
1356                 if (d <= vert_tol_sq) {
1357                         if (point_is_visible(kcd, v->cageco, s, &mats)) {
1358                                 memset(&hit, 0, sizeof(hit));
1359                                 hit.v = v;
1360                                 copy_v3_v3(hit.hit, v->cageco);
1361                                 copy_v3_v3(hit.cagehit, v->cageco);
1362                                 copy_v2_v2(hit.schit, s);
1363                                 set_linehit_depth(kcd, &hit);
1364                                 BLI_array_append(linehits, hit);
1365                         }
1366                 }
1367         }
1368         /* now edge hits; don't add if a vertex at end of edge should have hit */
1369         for (val = BLI_smallhash_iternew(&kfes, &hiter, (uintptr_t *)&kfe); val;
1370              val = BLI_smallhash_iternext(&hiter, (uintptr_t *)&kfe))
1371         {
1372                 knife_project_v2(kcd, kfe->v1->cageco, se1);
1373                 knife_project_v2(kcd, kfe->v2->cageco, se2);
1374                 isect_kind = isect_seg_seg_v2_point(s1, s2, se1, se2, sint);
1375                 if (isect_kind == -1) {
1376                         /* isect_seg_seg_v2 doesn't do tolerance test around ends of s1-s2 */
1377                         closest_to_line_segment_v2(sint, s1, se1, se2);
1378                         if (len_squared_v2v2(sint, s1) <= vert_tol_sq)
1379                                 isect_kind = 1;
1380                         else {
1381                                 closest_to_line_segment_v2(sint, s2, se1, se2);
1382                                 if (len_squared_v2v2(sint, s2) <= vert_tol_sq)
1383                                         isect_kind = 1;
1384                         }
1385                 }
1386                 if (isect_kind == 1) {
1387                         d1 = len_v2v2(sint, se1);
1388                         d2 = len_v2v2(se2, se1);
1389                         if (!(d1 <= vert_tol || d2 <= vert_tol || fabsf(d1 - d2) <= vert_tol)) {
1390                                 lambda = d1 / d2;
1391                                 /* Can't just interpolate between ends of kfe because
1392                                 * that doesn't work with perspective transformation.
1393                                 * Need to find 3d intersection of ray through sint */
1394                                 knife_input_ray_segment(kcd, sint, 1.0f, r1, r2);
1395                                 isect_kind = isect_line_line_v3(kfe->v1->cageco, kfe->v2->cageco, r1, r2, p, p2);
1396                                 if (isect_kind >= 1 && point_is_visible(kcd, p, sint, &mats)) {
1397                                         memset(&hit, 0, sizeof(hit));
1398                                         hit.kfe = kfe;
1399                                         copy_v3_v3(hit.hit, p);
1400                                         copy_v3_v3(hit.cagehit, p);
1401                                         copy_v2_v2(hit.schit, sint);
1402                                         hit.perc = lambda;
1403                                         set_linehit_depth(kcd, &hit);
1404                                         BLI_array_append(linehits, hit);
1405                                 }
1406                         }
1407                 }
1408         }
1409         /* now face hits; don't add if a vertex or edge in face should have hit */
1410         for (val = BLI_smallhash_iternew(&faces, &hiter, (uintptr_t *)&f); val;
1411              val = BLI_smallhash_iternext(&hiter, (uintptr_t *)&f))
1412         {
1413                 if (knife_ray_intersect_face(kcd, s1, v1, v3, f, face_tol, p)) {
1414                         if (point_is_visible(kcd, p, s1, &mats)) {
1415                                 memset(&hit, 0, sizeof(hit));
1416                                 hit.f = f;
1417                                 copy_v3_v3(hit.hit, p);
1418                                 copy_v3_v3(hit.cagehit, p);
1419                                 copy_v2_v2(hit.schit, s1);
1420                                 set_linehit_depth(kcd, &hit);
1421                                 BLI_array_append(linehits, hit);
1422                         }
1423                 }
1424                 if (knife_ray_intersect_face(kcd, s2, v2, v4, f, face_tol, p)) {
1425                         if (point_is_visible(kcd, p, s2, &mats)) {
1426                                 memset(&hit, 0, sizeof(hit));
1427                                 hit.f = f;
1428                                 copy_v3_v3(hit.hit, p);
1429                                 copy_v3_v3(hit.cagehit, p);
1430                                 copy_v2_v2(hit.schit, s2);
1431                                 set_linehit_depth(kcd, &hit);
1432                                 BLI_array_append(linehits, hit);
1433                         }
1434                 }
1435         }
1436
1437         kcd->linehits = linehits;
1438         kcd->totlinehit = BLI_array_count(linehits);
1439
1440         /* find position along screen line, used for sorting */
1441         for (i = 0; i < kcd->totlinehit; i++) {
1442                 KnifeLineHit *lh = kcd->linehits + i;
1443
1444                 lh->l = len_v2v2(lh->schit, s1) / len_v2v2(s2, s1);
1445         }
1446
1447         BLI_smallhash_release(&faces);
1448         BLI_smallhash_release(&kfes);
1449         BLI_smallhash_release(&kfvs);
1450         BLI_bvhtree_free(planetree);
1451         if (results)
1452                 MEM_freeN(results);
1453 }
1454
1455 static void knife_input_ray_segment(KnifeTool_OpData *kcd, const float mval[2], const float ofs,
1456                                     float r_origin[3], float r_origin_ofs[3])
1457 {
1458         bglMats mats;
1459
1460         bgl_get_mats(&mats);
1461
1462         /* unproject to find view ray */
1463         ED_view3d_unproject(&mats, r_origin,     mval[0], mval[1], 0.0f);
1464         ED_view3d_unproject(&mats, r_origin_ofs, mval[0], mval[1], ofs);
1465
1466         /* transform into object space */
1467         invert_m4_m4(kcd->ob->imat, kcd->ob->obmat); 
1468
1469         mul_m4_v3(kcd->ob->imat, r_origin);
1470         mul_m4_v3(kcd->ob->imat, r_origin_ofs);
1471 }
1472
1473 static BMFace *knife_find_closest_face(KnifeTool_OpData *kcd, float co[3], float cageco[3], bool *is_space)
1474 {
1475         BMFace *f;
1476         float dist = KMAXDIST;
1477         float origin[3];
1478         float origin_ofs[3];
1479         float ray[3];
1480
1481         /* unproject to find view ray */
1482         knife_input_ray_segment(kcd, kcd->curr.mval, 1.0f, origin, origin_ofs);
1483         sub_v3_v3v3(ray, origin_ofs, origin);
1484
1485         f = BKE_bmbvh_ray_cast(kcd->bmbvh, origin, ray, 0.0f, NULL, co, cageco);
1486
1487         if (is_space)
1488                 *is_space = !f;
1489
1490         if (!f) {
1491                 if (kcd->is_interactive) {
1492                         /* try to use backbuffer selection method if ray casting failed */
1493                         f = EDBM_face_find_nearest(&kcd->vc, &dist);
1494
1495                         /* cheat for now; just put in the origin instead
1496                          * of a true coordinate on the face.
1497                          * This just puts a point 1.0f infront of the view. */
1498                         add_v3_v3v3(co, origin, ray);
1499                 }
1500         }
1501
1502         return f;
1503 }
1504
1505 /* find the 2d screen space density of vertices within a radius.  used to scale snapping
1506  * distance for picking edges/verts.*/
1507 static int knife_sample_screen_density(KnifeTool_OpData *kcd, const float radius)
1508 {
1509         BMFace *f;
1510         bool is_space;
1511         float co[3], cageco[3], sco[2];
1512
1513         BLI_assert(kcd->is_interactive == true);
1514
1515         f = knife_find_closest_face(kcd, co, cageco, &is_space);
1516
1517         if (f && !is_space) {
1518                 const float radius_sq = radius * radius;
1519                 ListBase *lst;
1520                 Ref *ref;
1521                 float dis_sq;
1522                 int c = 0;
1523
1524                 knife_project_v2(kcd, cageco, sco);
1525
1526                 lst = knife_get_face_kedges(kcd, f);
1527                 for (ref = lst->first; ref; ref = ref->next) {
1528                         KnifeEdge *kfe = ref->ref;
1529                         int i;
1530
1531                         for (i = 0; i < 2; i++) {
1532                                 KnifeVert *kfv = i ? kfe->v2 : kfe->v1;
1533
1534                                 knife_project_v2(kcd, kfv->cageco, kfv->sco);
1535
1536                                 dis_sq = len_squared_v2v2(kfv->sco, sco);
1537                                 if (dis_sq < radius_sq) {
1538                                         if (kcd->vc.rv3d->rflag & RV3D_CLIPPING) {
1539                                                 if (ED_view3d_clipping_test(kcd->vc.rv3d, kfv->cageco, true) == 0) {
1540                                                         c++;
1541                                                 }
1542                                         }
1543                                         else {
1544                                                 c++;
1545                                         }
1546                                 }
1547                         }
1548                 }
1549
1550                 return c;
1551         }
1552
1553         return 0;
1554 }
1555
1556 /* returns snapping distance for edges/verts, scaled by the density of the
1557  * surrounding mesh (in screen space)*/
1558 static float knife_snap_size(KnifeTool_OpData *kcd, float maxsize)
1559 {
1560         float density;
1561
1562         if (kcd->is_interactive) {
1563                 density = (float)knife_sample_screen_density(kcd, maxsize * 2.0f);
1564         }
1565         else {
1566                 density = 1.0f;
1567         }
1568
1569         if (density < 1.0f)
1570                 density = 1.0f;
1571
1572         return min_ff(maxsize / (density * 0.5f), maxsize);
1573 }
1574
1575 /* p is closest point on edge to the mouse cursor */
1576 static KnifeEdge *knife_find_closest_edge(KnifeTool_OpData *kcd, float p[3], float cagep[3],
1577                                           BMFace **fptr, bool *is_space)
1578 {
1579         BMFace *f;
1580         float co[3], cageco[3], sco[2];
1581         float maxdist = knife_snap_size(kcd, kcd->ethresh);
1582
1583         if (kcd->ignore_vert_snapping)
1584                 maxdist *= 0.5f;
1585
1586         f = knife_find_closest_face(kcd, co, cageco, NULL);
1587         *is_space = !f;
1588
1589         /* set p to co, in case we don't find anything, means a face cut */
1590         copy_v3_v3(p, co);
1591         copy_v3_v3(cagep, cageco);
1592
1593         kcd->curr.bmface = f;
1594
1595         if (f) {
1596                 const float maxdist_sq = maxdist * maxdist;
1597                 KnifeEdge *cure = NULL;
1598                 ListBase *lst;
1599                 Ref *ref;
1600                 float dis_sq, curdis_sq = FLT_MAX;
1601
1602                 knife_project_v2(kcd, cageco, sco);
1603
1604                 /* look through all edges associated with this face */
1605                 lst = knife_get_face_kedges(kcd, f);
1606                 for (ref = lst->first; ref; ref = ref->next) {
1607                         KnifeEdge *kfe = ref->ref;
1608
1609                         /* project edge vertices into screen space */
1610                         knife_project_v2(kcd, kfe->v1->cageco, kfe->v1->sco);
1611                         knife_project_v2(kcd, kfe->v2->cageco, kfe->v2->sco);
1612
1613                         dis_sq = dist_squared_to_line_segment_v2(sco, kfe->v1->sco, kfe->v2->sco);
1614                         if (dis_sq < curdis_sq && dis_sq < maxdist_sq) {
1615                                 if (kcd->vc.rv3d->rflag & RV3D_CLIPPING) {
1616                                         float lambda = line_point_factor_v2(sco, kfe->v1->sco, kfe->v2->sco);
1617                                         float vec[3];
1618
1619                                         interp_v3_v3v3(vec, kfe->v1->cageco, kfe->v2->cageco, lambda);
1620
1621                                         if (ED_view3d_clipping_test(kcd->vc.rv3d, vec, true) == 0) {
1622                                                 cure = kfe;
1623                                                 curdis_sq = dis_sq;
1624                                         }
1625                                 }
1626                                 else {
1627                                         cure = kfe;
1628                                         curdis_sq = dis_sq;
1629                                 }
1630                         }
1631                 }
1632
1633                 if (fptr)
1634                         *fptr = f;
1635
1636                 if (cure) {
1637                         if (!kcd->ignore_edge_snapping || !(cure->e)) {
1638                                 KnifeVert *edgesnap = NULL;
1639
1640                                 if (kcd->snap_midpoints) {
1641                                         mid_v3_v3v3(p, cure->v1->co, cure->v2->co);
1642                                         mid_v3_v3v3(cagep, cure->v1->cageco, cure->v2->cageco);
1643                                 }
1644                                 else {
1645                                         float d;
1646
1647                                         closest_to_line_segment_v3(cagep, cageco, cure->v1->cageco, cure->v2->cageco);
1648                                         d = len_v3v3(cagep, cure->v1->cageco) / len_v3v3(cure->v1->cageco, cure->v2->cageco);
1649                                         interp_v3_v3v3(p, cure->v1->co, cure->v2->co, d);
1650                                 }
1651
1652                                 /* update mouse coordinates to the snapped-to edge's screen coordinates
1653                                  * this is important for angle snap, which uses the previous mouse position */
1654                                 edgesnap = new_knife_vert(kcd, p, cagep);
1655                                 kcd->curr.mval[0] = edgesnap->sco[0];
1656                                 kcd->curr.mval[1] = edgesnap->sco[1];
1657
1658                         }
1659                         else {
1660                                 return NULL;
1661                         }
1662                 }
1663
1664                 return cure;
1665         }
1666
1667         if (fptr)
1668                 *fptr = NULL;
1669
1670         return NULL;
1671 }
1672
1673 /* find a vertex near the mouse cursor, if it exists */
1674 static KnifeVert *knife_find_closest_vert(KnifeTool_OpData *kcd, float p[3], float cagep[3], BMFace **fptr,
1675                                           bool *is_space)
1676 {
1677         BMFace *f;
1678         float co[3], cageco[3], sco[2], maxdist = knife_snap_size(kcd, kcd->vthresh);
1679
1680         if (kcd->ignore_vert_snapping)
1681                 maxdist *= 0.5f;
1682
1683         f = knife_find_closest_face(kcd, co, cageco, is_space);
1684
1685         /* set p to co, in case we don't find anything, means a face cut */
1686         copy_v3_v3(p, co);
1687         copy_v3_v3(cagep, cageco);
1688         kcd->curr.bmface = f;
1689
1690         if (f) {
1691                 const float maxdist_sq = maxdist * maxdist;
1692                 ListBase *lst;
1693                 Ref *ref;
1694                 KnifeVert *curv = NULL;
1695                 float dis_sq, curdis_sq = FLT_MAX;
1696
1697                 knife_project_v2(kcd, cageco, sco);
1698
1699                 lst = knife_get_face_kedges(kcd, f);
1700                 for (ref = lst->first; ref; ref = ref->next) {
1701                         KnifeEdge *kfe = ref->ref;
1702                         int i;
1703
1704                         for (i = 0; i < 2; i++) {
1705                                 KnifeVert *kfv = i ? kfe->v2 : kfe->v1;
1706
1707                                 knife_project_v2(kcd, kfv->cageco, kfv->sco);
1708
1709                                 dis_sq = len_squared_v2v2(kfv->sco, sco);
1710                                 if (dis_sq < curdis_sq && dis_sq < maxdist_sq) {
1711                                         if (kcd->vc.rv3d->rflag & RV3D_CLIPPING) {
1712                                                 if (ED_view3d_clipping_test(kcd->vc.rv3d, kfv->cageco, true) == 0) {
1713                                                         curv = kfv;
1714                                                         curdis_sq = dis_sq;
1715                                                 }
1716                                         }
1717                                         else {
1718                                                 curv = kfv;
1719                                                 curdis_sq = dis_sq;
1720                                         }
1721                                 }
1722                         }
1723                 }
1724
1725                 if (!kcd->ignore_vert_snapping || !(curv && curv->v)) {
1726                         if (fptr)
1727                                 *fptr = f;
1728
1729                         if (curv) {
1730                                 copy_v3_v3(p, curv->co);
1731                                 copy_v3_v3(cagep, curv->cageco);
1732
1733                                 /* update mouse coordinates to the snapped-to vertex's screen coordinates
1734                                  * this is important for angle snap, which uses the previous mouse position */
1735                                 kcd->curr.mval[0] = curv->sco[0];
1736                                 kcd->curr.mval[1] = curv->sco[1];
1737                         }
1738
1739                         return curv;
1740                 }
1741                 else {
1742                         if (fptr)
1743                                 *fptr = f;
1744
1745                         return NULL;
1746                 }
1747         }
1748
1749         if (fptr)
1750                 *fptr = NULL;
1751
1752         return NULL;
1753 }
1754
1755 /* update both kcd->curr.mval and kcd->mval to snap to required angle */
1756 static void knife_snap_angle(KnifeTool_OpData *kcd)
1757 {
1758         float dx, dy;
1759         float w, abs_tan;
1760
1761         dx = kcd->curr.mval[0] - kcd->prev.mval[0];
1762         dy = kcd->curr.mval[1] - kcd->prev.mval[1];
1763         if (dx == 0.0f && dy == 0.0f)
1764                 return;
1765
1766         if (dx == 0.0f) {
1767                 kcd->angle_snapping = ANGLE_90;
1768                 kcd->curr.mval[0] = kcd->prev.mval[0];
1769         }
1770
1771         w = dy / dx;
1772         abs_tan = fabsf(w);
1773         if (abs_tan <= 0.4142f) { /* tan(22.5 degrees) = 0.4142 */
1774                 kcd->angle_snapping = ANGLE_0;
1775                 kcd->curr.mval[1] = kcd->prev.mval[1];
1776         }
1777         else if (abs_tan < 2.4142f) { /* tan(67.5 degrees) = 2.4142 */
1778                 if (w > 0) {
1779                         kcd->angle_snapping = ANGLE_45;
1780                         kcd->curr.mval[1] = kcd->prev.mval[1] + dx;
1781                 }
1782                 else {
1783                         kcd->angle_snapping = ANGLE_135;
1784                         kcd->curr.mval[1] = kcd->prev.mval[1] - dx;
1785                 }
1786         }
1787         else {
1788                 kcd->angle_snapping = ANGLE_90;
1789                 kcd->curr.mval[0] = kcd->prev.mval[0];
1790         }
1791
1792         copy_v2_v2(kcd->mval, kcd->curr.mval);
1793 }
1794
1795 /* update active knife edge/vert pointers */
1796 static int knife_update_active(KnifeTool_OpData *kcd)
1797 {
1798         knife_pos_data_clear(&kcd->curr);
1799         copy_v2_v2(kcd->curr.mval, kcd->mval);
1800         if (kcd->angle_snapping != ANGLE_FREE && kcd->mode == MODE_DRAGGING)
1801                 knife_snap_angle(kcd);
1802
1803         /* XXX knife_snap_angle updates the view coordinate mouse values to constrained angles,
1804          * which current mouse values are set to current mouse values are then used
1805          * for vertex and edge snap detection, without regard to the exact angle constraint */
1806         kcd->curr.vert = knife_find_closest_vert(kcd, kcd->curr.co, kcd->curr.cage, &kcd->curr.bmface, &kcd->curr.is_space);
1807
1808         if (!kcd->curr.vert) {
1809                 kcd->curr.edge = knife_find_closest_edge(kcd, kcd->curr.co, kcd->curr.cage,
1810                                                          &kcd->curr.bmface, &kcd->curr.is_space);
1811         }
1812
1813         /* if no hits are found this would normally default to (0, 0, 0) so instead
1814          * get a point at the mouse ray closest to the previous point.
1815          * Note that drawing lines in `free-space` isn't properly supported
1816          * but theres no guarantee (0, 0, 0) has any geometry either - campbell */
1817         if (kcd->curr.vert == NULL && kcd->curr.edge == NULL && kcd->curr.bmface == NULL) {
1818                 float origin[3];
1819                 float origin_ofs[3];
1820
1821                 knife_input_ray_segment(kcd, kcd->curr.mval, 1.0f, origin, origin_ofs);
1822
1823                 closest_to_line_v3(kcd->curr.cage, kcd->prev.cage, origin_ofs, origin);
1824                 copy_v3_v3(kcd->curr.co, kcd->curr.cage);
1825         }
1826
1827         if (kcd->mode == MODE_DRAGGING) {
1828                 knife_find_line_hits(kcd);
1829         }
1830         return 1;
1831 }
1832
1833 /* sort list of kverts by fraction along edge e */
1834 static void sort_by_frac_along(ListBase *lst, BMEdge *e)
1835 {
1836         /* note, since we know the point is along the edge, sort from distance to v1co */
1837         const float *v1co = e->v1->co;
1838         Ref *cur = NULL, *prev = NULL, *next = NULL;
1839
1840         if (lst->first == lst->last)
1841                 return;
1842
1843         for (cur = ((Ref *)lst->first)->next; cur; cur = next) {
1844                 KnifeVert *vcur = cur->ref;
1845                 const float vcur_fac = len_squared_v3v3(v1co, vcur->co);
1846
1847                 next = cur->next;
1848                 prev = cur->prev;
1849
1850                 BLI_remlink(lst, cur);
1851
1852                 while (prev) {
1853                         KnifeVert *vprev = prev->ref;
1854                         if (len_squared_v3v3(v1co, vprev->co) <= vcur_fac)
1855                                 break;
1856                         prev = prev->prev;
1857                 }
1858
1859                 BLI_insertlinkafter(lst, prev, cur);
1860         }
1861 }
1862
1863 /* The chain so far goes from an instantiated vertex to kfv (some may be reversed).
1864  * If possible, complete the chain to another instantiated vertex and return 1, else return 0.
1865  * The visited hash says which KnifeVert's have already been tried, not including kfv. */
1866 static bool find_chain_search(KnifeTool_OpData *kcd, KnifeVert *kfv, ListBase *fedges, SmallHash *visited,
1867                               ListBase *chain)
1868 {
1869         Ref *r;
1870         KnifeEdge *kfe;
1871         KnifeVert *kfv_other;
1872
1873         if (kfv->v)
1874                 return true;
1875
1876         BLI_smallhash_insert(visited, (uintptr_t)kfv, NULL);
1877         /* Try all possible next edges. Could either go through fedges
1878          * (all the KnifeEdges for the face being cut) or could go through
1879          * kve->edges and restrict to cutting face and uninstantiated edges.
1880          * Not clear which is better. Let's do the first. */
1881         for (r = fedges->first; r; r = r->next) {
1882                 kfe = r->ref;
1883                 kfv_other = NULL;
1884                 if (kfe->v1 == kfv)
1885                         kfv_other = kfe->v2;
1886                 else if (kfe->v2 == kfv)
1887                         kfv_other = kfe->v1;
1888                 if (kfv_other && !BLI_smallhash_haskey(visited, (uintptr_t)kfv_other)) {
1889                         knife_append_list(kcd, chain, kfe);
1890                         if (find_chain_search(kcd, kfv_other, fedges, visited, chain))
1891                                 return true;
1892                         BLI_remlink(chain, chain->last);
1893                 }
1894         }
1895         return false;
1896 }
1897
1898 static ListBase *find_chain_from_vertex(KnifeTool_OpData *kcd, KnifeEdge *kfe, BMVert *v, ListBase *fedges)
1899 {
1900         SmallHash visited_, *visited = &visited_;
1901         ListBase *ans;
1902         bool found;
1903
1904         ans = knife_empty_list(kcd);
1905         knife_append_list(kcd, ans, kfe);
1906         found = false;
1907         BLI_smallhash_init(visited);
1908         if (kfe->v1->v == v) {
1909                 BLI_smallhash_insert(visited, (uintptr_t)(kfe->v1), NULL);
1910                 found = find_chain_search(kcd, kfe->v2, fedges, visited, ans);
1911         }
1912         else {
1913                 BLI_assert(kfe->v2->v == v);
1914                 BLI_smallhash_insert(visited, (uintptr_t)(kfe->v2), NULL);
1915                 found = find_chain_search(kcd, kfe->v1, fedges, visited, ans);
1916         }
1917
1918         BLI_smallhash_release(visited);
1919
1920         if (found)
1921                 return ans;
1922         else
1923                 return NULL;
1924 }
1925
1926 /* Find a chain in fedges from one instantiated vertex to another.
1927  * Remove the edges in the chain from fedges and return a separate list of the chain. */
1928 static ListBase *find_chain(KnifeTool_OpData *kcd, ListBase *fedges)
1929 {
1930         Ref *r, *ref;
1931         KnifeEdge *kfe;
1932         BMVert *v1, *v2;
1933         ListBase *ans;
1934
1935         ans = NULL;
1936
1937         for (r = fedges->first; r; r = r->next) {
1938                 kfe = r->ref;
1939                 v1 = kfe->v1->v;
1940                 v2 = kfe->v2->v;
1941                 if (v1 && v2) {
1942                         ans = knife_empty_list(kcd);
1943                         knife_append_list(kcd, ans, kfe);
1944                         break;
1945                 }
1946                 if (v1)
1947                         ans = find_chain_from_vertex(kcd, kfe, v1, fedges);
1948                 else if (v2)
1949                         ans = find_chain_from_vertex(kcd, kfe, v2, fedges);
1950                 if (ans)
1951                         break;
1952         }
1953         if (ans) {
1954                 BLI_assert(BLI_countlist(ans) > 0);
1955                 for (r = ans->first; r; r = r->next) {
1956                         ref = find_ref(fedges, r->ref);
1957                         BLI_assert(ref != NULL);
1958                         BLI_remlink(fedges, ref);
1959                 }
1960         }
1961         return ans;
1962 }
1963
1964 /* The hole so far goes from kfvfirst to kfv (some may be reversed).
1965  * If possible, complete the hole back to kfvfirst and return 1, else return 0.
1966  * The visited hash says which KnifeVert's have already been tried, not including kfv or kfvfirst. */
1967 static bool find_hole_search(KnifeTool_OpData *kcd, KnifeVert *kfvfirst, KnifeVert *kfv, ListBase *fedges,
1968                              SmallHash *visited, ListBase *hole)
1969 {
1970         Ref *r;
1971         KnifeEdge *kfe, *kfelast;
1972         KnifeVert *kfv_other;
1973
1974         if (kfv == kfvfirst)
1975                 return true;
1976
1977         BLI_smallhash_insert(visited, (uintptr_t)kfv, NULL);
1978         kfelast = ((Ref *)hole->last)->ref;
1979         for (r = fedges->first; r; r = r->next) {
1980                 kfe = r->ref;
1981                 if (kfe == kfelast)
1982                         continue;
1983                 if (kfe->v1->v || kfe->v2->v)
1984                         continue;
1985                 kfv_other = NULL;
1986                 if (kfe->v1 == kfv)
1987                         kfv_other = kfe->v2;
1988                 else if (kfe->v2 == kfv)
1989                         kfv_other = kfe->v1;
1990                 if (kfv_other && !BLI_smallhash_haskey(visited, (uintptr_t)kfv_other)) {
1991                         knife_append_list(kcd, hole, kfe);
1992                         if (find_hole_search(kcd, kfvfirst, kfv_other, fedges, visited, hole))
1993                                 return true;
1994                         BLI_remlink(hole, hole->last);
1995                 }
1996         }
1997         return false;
1998 }
1999
2000 /* Find a hole (simple cycle with no instantiated vertices).
2001  * Remove the edges in the cycle from fedges and return a separate list of the cycle */
2002 static ListBase *find_hole(KnifeTool_OpData *kcd, ListBase *fedges)
2003 {
2004         ListBase *ans;
2005         Ref *r, *ref;
2006         KnifeEdge *kfe;
2007         SmallHash visited_, *visited = &visited_;
2008         bool found;
2009
2010         ans = NULL;
2011         found = false;
2012
2013         for (r = fedges->first; r && !found; r = r->next) {
2014                 kfe = r->ref;
2015                 if (kfe->v1->v || kfe->v2->v || kfe->v1 == kfe->v2)
2016                         continue;
2017
2018                 BLI_smallhash_init(visited);
2019                 ans = knife_empty_list(kcd);
2020                 knife_append_list(kcd, ans, kfe);
2021
2022                 found = find_hole_search(kcd, kfe->v1, kfe->v2, fedges, visited, ans);
2023
2024                 BLI_smallhash_release(visited);
2025         }
2026
2027         if (found) {
2028                 for (r = ans->first; r; r = r->next) {
2029                         kfe = r->ref;
2030                         ref = find_ref(fedges, r->ref);
2031                         if (ref)
2032                                 BLI_remlink(fedges, ref);
2033                 }
2034                 return ans;
2035         }
2036         else {
2037                 return NULL;
2038         }
2039 }
2040
2041 /* Try to find "nice" diagonals - short, and far apart from each other.
2042  * If found, return true and make a 'main chain' going across f which uses
2043  * the two diagonals and one part of the hole, and a 'side chain' that
2044  * completes the hole. */
2045 static bool find_hole_chains(KnifeTool_OpData *kcd, ListBase *hole, BMFace *f, ListBase **mainchain,
2046                              ListBase **sidechain)
2047 {
2048         float **fco, **hco;
2049         BMVert **fv;
2050         KnifeVert **hv;
2051         KnifeEdge **he;
2052         Ref *r;
2053         KnifeVert *kfv, *kfvother;
2054         KnifeEdge *kfe;
2055         ListBase *chain;
2056         BMVert *v;
2057         BMIter iter;
2058         int nh, nf, i, j, k, m, ax, ay, sep = 0 /* Quite warnings */, bestsep;
2059         int besti[2], bestj[2];
2060         float d, bestd;
2061
2062         nh = BLI_countlist(hole);
2063         nf = f->len;
2064         if (nh < 2 || nf < 3)
2065                 return false;
2066
2067         /* Gather 2d projections of hole and face vertex coordinates.
2068          * Use best-axis projection - not completely accurate, maybe revisit */
2069         axis_dominant_v3(&ax, &ay, f->no);
2070         hco = BLI_memarena_alloc(kcd->arena, nh * sizeof(float *));
2071         fco = BLI_memarena_alloc(kcd->arena, nf * sizeof(float *));
2072         hv = BLI_memarena_alloc(kcd->arena, nh * sizeof(KnifeVert *));
2073         fv = BLI_memarena_alloc(kcd->arena, nf * sizeof(BMVert *));
2074         he = BLI_memarena_alloc(kcd->arena, nh * sizeof(KnifeEdge *));
2075
2076         i = 0;
2077         kfv = NULL;
2078         kfvother = NULL;
2079         for (r = hole->first; r; r = r->next) {
2080                 kfe = r->ref;
2081                 he[i] = kfe;
2082                 if (kfvother == NULL) {
2083                         kfv = kfe->v1;
2084                 }
2085                 else {
2086                         kfv = kfvother;
2087                         BLI_assert(kfv == kfe->v1 || kfv == kfe->v2);
2088                 }
2089                 hco[i] = BLI_memarena_alloc(kcd->arena, 2 * sizeof(float));
2090                 hco[i][0] = kfv->co[ax];
2091                 hco[i][1] = kfv->co[ay];
2092                 hv[i] = kfv;
2093                 kfvother = (kfe->v1 == kfv) ? kfe->v2 : kfe->v1;
2094                 i++;
2095         }
2096
2097         j = 0;
2098         BM_ITER_ELEM (v, &iter, f, BM_VERTS_OF_FACE) {
2099                 fco[j] = BLI_memarena_alloc(kcd->arena, 2 * sizeof(float));
2100                 fco[j][0] = v->co[ax];
2101                 fco[j][1] = v->co[ay];
2102                 fv[j] = v;
2103                 j++;
2104         }
2105
2106         /* For first diagonal  (m == 0), want shortest length.
2107          * For second diagonal (m == 1), want max separation of index of hole
2108          * vertex from the hole vertex used in the first diagonal, and from there
2109          * want the one with shortest length not to the same vertex as the first diagonal. */
2110         for (m = 0; m < 2; m++) {
2111                 besti[m] = -1;
2112                 bestj[m] = -1;
2113                 bestd = FLT_MAX;
2114                 bestsep = 0;
2115                 for (i = 0; i < nh; i++) {
2116                         if (m == 1) {
2117                                 if (i == besti[0])
2118                                         continue;
2119                                 sep = (i + nh - besti[0]) % nh;
2120                                 sep = MIN2(sep, nh - sep);
2121                                 if (sep < bestsep)
2122                                         continue;
2123                                 bestd = FLT_MAX;
2124                         }
2125                         for (j = 0; j < nf; j++) {
2126                                 bool ok;
2127
2128                                 if (m == 1 && j == bestj[0])
2129                                         continue;
2130                                 d = len_squared_v2v2(hco[i], fco[j]);
2131                                 if (d > bestd)
2132                                         continue;
2133
2134                                 ok = true;
2135                                 for (k = 0; k < nh && ok; k++) {
2136                                         if (k == i || (k + 1) % nh == i)
2137                                                 continue;
2138                                         if (isect_line_line_v2(hco[i], fco[j], hco[k], hco[(k + 1) % nh]))
2139                                                 ok = false;
2140                                 }
2141                                 if (!ok)
2142                                         continue;
2143                                 for (k = 0; k < nf && ok; k++) {
2144                                         if (k == j || (k + 1) % nf == j)
2145                                                 continue;
2146                                         if (isect_line_line_v2(hco[i], fco[j], fco[k], fco[(k + 1) % nf]))
2147                                                 ok = false;
2148                                 }
2149                                 if (ok) {
2150                                         besti[m] = i;
2151                                         bestj[m] = j;
2152                                         if (m == 1)
2153                                                 bestsep = sep;
2154                                         bestd = d;
2155                                 }
2156                         }
2157                 }
2158         }
2159
2160         if (besti[0] != -1 && besti[1] != -1) {
2161                 BLI_assert(besti[0] != besti[1] && bestj[0] != bestj[1]);
2162                 kfe = new_knife_edge(kcd);
2163                 kfe->v1 = get_bm_knife_vert(kcd, fv[bestj[0]]);
2164                 kfe->v2 = hv[besti[0]];
2165                 chain = knife_empty_list(kcd);
2166                 knife_append_list(kcd, chain, kfe);
2167                 for (i = besti[0]; i != besti[1]; i = (i + 1) % nh) {
2168                         knife_append_list(kcd, chain, he[i]);
2169                 }
2170                 kfe = new_knife_edge(kcd);
2171                 kfe->v1 = hv[besti[1]];
2172                 kfe->v2 = get_bm_knife_vert(kcd, fv[bestj[1]]);
2173                 knife_append_list(kcd, chain, kfe);
2174                 *mainchain = chain;
2175
2176                 chain = knife_empty_list(kcd);
2177                 for (i = besti[1]; i != besti[0]; i = (i + 1) % nh) {
2178                         knife_append_list(kcd, chain, he[i]);
2179                 }
2180                 *sidechain = chain;
2181
2182                 return true;
2183         }
2184         else {
2185                 return false;
2186         }
2187 }
2188
2189 static bool knife_verts_edge_in_face(KnifeVert *v1, KnifeVert *v2, BMFace *f)
2190 {
2191         BMLoop *l1, *l2, *l;
2192         float mid[3];
2193         BMIter iter;
2194         int v1inside, v2inside;
2195
2196         if (!f || !v1 || !v2)
2197                 return false;
2198
2199         l1 = NULL;
2200         l2 = NULL;
2201
2202         /* find out if v1 and v2, if set, are part of the face */
2203         BM_ITER_ELEM (l, &iter, f, BM_LOOPS_OF_FACE) {
2204                 if (v1->v && l->v == v1->v)
2205                         l1 = l;
2206                 if (v2->v && l->v == v2->v)
2207                         l2 = l;
2208         }
2209
2210         /* BM_face_point_inside_test uses best-axis projection so this isn't most accurate test... */
2211         v1inside = l1 ? 0 : BM_face_point_inside_test(f, v1->co);
2212         v2inside = l2 ? 0 : BM_face_point_inside_test(f, v2->co);
2213         if ((l1 && v2inside) || (l2 && v1inside) || (v1inside && v2inside))
2214                 return true;
2215         if (l1 && l2) {
2216                 /* Can have case where v1 and v2 are on shared chain between two faces.
2217                  * BM_face_legal_splits does visibility and self-intersection tests,
2218                  * but it is expensive and maybe a bit buggy, so use a simple
2219                  * "is the midpoint in the face" test */
2220                 mid_v3_v3v3(mid, v1->co, v2->co);
2221                 return BM_face_point_inside_test(f, mid);
2222         }
2223         return false;
2224 }
2225
2226 static bool knife_edge_in_face(KnifeEdge *kfe, BMFace *f)
2227 {
2228         return knife_verts_edge_in_face(kfe->v1, kfe->v2, f);
2229 }
2230
2231 /* Split face f with KnifeEdges on chain.  f remains as one side, the face formed is put in *newface.
2232  * The new face will be on the left side of the chain as viewed from the normal-out side of f. */
2233 static void knife_make_chain_cut(KnifeTool_OpData *kcd, BMFace *f, ListBase *chain, BMFace **r_f_new)
2234 {
2235         BMesh *bm = kcd->em->bm;
2236         KnifeEdge *kfe, *kfelast;
2237         BMVert *v1, *v2;
2238         BMLoop *l_v1, *l_v2;
2239         BMFace *f_new;
2240         Ref *ref;
2241         KnifeVert *kfv, *kfvprev;
2242         BMLoop *l_new, *l_iter;
2243         int i;
2244         int nco = BLI_countlist(chain) - 1;
2245         float (*cos)[3] = BLI_array_alloca(cos, nco);
2246         KnifeVert **kverts = BLI_array_alloca(kverts, nco);
2247
2248         kfe = ((Ref *)chain->first)->ref;
2249         v1 = kfe->v1->v ? kfe->v1->v : kfe->v2->v;
2250         kfelast = ((Ref *)chain->last)->ref;
2251         v2 = kfelast->v2->v ? kfelast->v2->v : kfelast->v1->v;
2252         BLI_assert(v1 != NULL && v2 != NULL);
2253         kfvprev = kfe->v1->v == v1 ? kfe->v1 : kfe->v2;
2254         for (ref = chain->first, i = 0; i < nco && ref != chain->last; ref = ref->next, i++) {
2255                 kfe = ref->ref;
2256                 BLI_assert(kfvprev == kfe->v1 || kfvprev == kfe->v2);
2257                 kfv = kfe->v1 == kfvprev ? kfe->v2 : kfe->v1;
2258                 copy_v3_v3(cos[i], kfv->co);
2259                 kverts[i] = kfv;
2260                 kfvprev = kfv;
2261         }
2262         BLI_assert(i == nco);
2263         l_new = NULL;
2264
2265         if ((l_v1 = BM_face_vert_share_loop(f, v1)) &&
2266             (l_v2 = BM_face_vert_share_loop(f, v2)))
2267         {
2268                 if (nco == 0) {
2269                         /* Want to prevent creating two-sided polygons */
2270                         if (v1 == v2 || BM_edge_exists(v1, v2)) {
2271                                 f_new = NULL;
2272                         }
2273                         else {
2274                                 f_new = BM_face_split(bm, f, l_v1, l_v2, &l_new, NULL, true);
2275                         }
2276                 }
2277                 else {
2278                         f_new = BM_face_split_n(bm, f, l_v1, l_v2, cos, nco, &l_new, NULL);
2279                         if (f_new) {
2280                                 /* Now go through lnew chain matching up chain kv's and assign real v's to them */
2281                                 for (l_iter = l_new->next, i = 0; i < nco; l_iter = l_iter->next, i++) {
2282                                         BLI_assert(equals_v3v3(cos[i], l_iter->v->co));
2283                                         if (kcd->select_result) {
2284                                                 BM_edge_select_set(bm, l_iter->e, true);
2285                                         }
2286                                         kverts[i]->v = l_iter->v;
2287                                 }
2288                         }
2289                 }
2290         }
2291         else {
2292                 f_new = NULL;
2293         }
2294
2295         /* the select chain above doesnt account for the first loop */
2296         if (kcd->select_result) {
2297                 if (l_new) {
2298                         BM_edge_select_set(bm, l_new->e, true);
2299                 }
2300         }
2301         else if (f_new) {
2302                 BM_elem_select_copy(bm, bm, f_new, f);
2303         }
2304
2305         *r_f_new = f_new;
2306 }
2307
2308 static void knife_make_face_cuts(KnifeTool_OpData *kcd, BMFace *f, ListBase *kfedges)
2309 {
2310         BMesh *bm = kcd->em->bm;
2311         KnifeEdge *kfe;
2312         BMFace *fnew, *fnew2, *fhole;
2313         ListBase *chain, *hole, *sidechain;
2314         ListBase *fnew_kfedges, *fnew2_kfedges;
2315         Ref *ref, *refnext;
2316         int count, oldcount;
2317
2318         oldcount = BLI_countlist(kfedges);
2319         while ((chain = find_chain(kcd, kfedges)) != NULL) {
2320                 knife_make_chain_cut(kcd, f, chain, &fnew);
2321                 if (!fnew) {
2322                         return;
2323                 }
2324
2325                 /* Move kfedges to fnew_kfedges if they are now in fnew.
2326                  * The chain edges were removed already */
2327                 fnew_kfedges = knife_empty_list(kcd);
2328                 for (ref = kfedges->first; ref; ref = refnext) {
2329                         kfe = ref->ref;
2330                         refnext = ref->next;
2331                         if (knife_edge_in_face(kfe, fnew)) {
2332                                 BLI_remlink(kfedges, ref);
2333                                 kfe->basef = fnew;
2334                                 knife_append_list(kcd, fnew_kfedges, kfe);
2335                         }
2336                 }
2337                 if (fnew_kfedges->first)
2338                         knife_make_face_cuts(kcd, fnew, fnew_kfedges);
2339
2340                 /* find_chain should always remove edges if it returns true,
2341                  * but guard against infinite loop anyway */
2342                 count = BLI_countlist(kfedges);
2343                 if (count >= oldcount) {
2344                         BLI_assert(!"knife find_chain infinite loop");
2345                         return;
2346                 }
2347                 oldcount = count;
2348         }
2349
2350         while ((hole = find_hole(kcd, kfedges)) != NULL) {
2351                 if (find_hole_chains(kcd, hole, f, &chain, &sidechain)) {
2352                         /* chain goes across f and sidechain comes back
2353                          * from the second last vertex to the second vertex.
2354                          */
2355                         knife_make_chain_cut(kcd, f, chain, &fnew);
2356                         if (!fnew) {
2357                                 BLI_assert(!"knife failed hole cut");
2358                                 return;
2359                         }
2360                         kfe = ((Ref *)sidechain->first)->ref;
2361                         if (knife_edge_in_face(kfe, f)) {
2362                                 knife_make_chain_cut(kcd, f, sidechain, &fnew2);
2363                                 if (fnew2 == NULL) {
2364                                         return;
2365                                 }
2366                                 fhole = f;
2367                         }
2368                         else if (knife_edge_in_face(kfe, fnew)) {
2369                                 knife_make_chain_cut(kcd, fnew, sidechain, &fnew2);
2370                                 if (fnew2 == NULL) {
2371                                         return;
2372                                 }
2373                                 fhole = fnew2;
2374                         }
2375                         else {
2376                                 /* shouldn't happen except in funny edge cases */
2377                                 return;
2378                         }
2379                         BM_face_kill(bm, fhole);
2380                         /* Move kfedges to either fnew or fnew2 if appropriate.
2381                          * The hole edges were removed already */
2382                         fnew_kfedges = knife_empty_list(kcd);
2383                         fnew2_kfedges = knife_empty_list(kcd);
2384                         for (ref = kfedges->first; ref; ref = refnext) {
2385                                 kfe = ref->ref;
2386                                 refnext = ref->next;
2387                                 if (knife_edge_in_face(kfe, fnew)) {
2388                                         BLI_remlink(kfedges, ref);
2389                                         kfe->basef = fnew;
2390                                         knife_append_list(kcd, fnew_kfedges, kfe);
2391                                 }
2392                                 else if (knife_edge_in_face(kfe, fnew2)) {
2393                                         BLI_remlink(kfedges, ref);
2394                                         kfe->basef = fnew2;
2395                                         knife_append_list(kcd, fnew2_kfedges, kfe);
2396                                 }
2397                         }
2398                         /* We'll skip knife edges that are in the newly formed hole.
2399                          * (Maybe we shouldn't have made a hole in the first place?) */
2400                         if (fnew != fhole && fnew_kfedges->first)
2401                                 knife_make_face_cuts(kcd, fnew, fnew_kfedges);
2402                         if (fnew2 != fhole && fnew2_kfedges->first)
2403                                 knife_make_face_cuts(kcd, fnew2, fnew2_kfedges);
2404                         if (f == fhole)
2405                                 break;
2406                         /* find_hole should always remove edges if it returns true,
2407                          * but guard against infinite loop anyway */
2408                         count = BLI_countlist(kfedges);
2409                         if (count >= oldcount) {
2410                                 BLI_assert(!"knife find_hole infinite loop");
2411                                 return;
2412                         }
2413                         oldcount = count;
2414                 }
2415         }
2416 }
2417
2418 /* Use the network of KnifeEdges and KnifeVerts accumulated to make real BMVerts and BMEdedges */
2419 static void knife_make_cuts(KnifeTool_OpData *kcd)
2420 {
2421         BMesh *bm = kcd->em->bm;
2422         KnifeEdge *kfe;
2423         KnifeVert *kfv;
2424         BMFace *f;
2425         BMEdge *e, *enew;
2426         ListBase *lst;
2427         Ref *ref;
2428         float pct;
2429         SmallHashIter hiter;
2430         BLI_mempool_iter iter;
2431         SmallHash fhash_, *fhash = &fhash_;
2432         SmallHash ehash_, *ehash = &ehash_;
2433
2434         BLI_smallhash_init(fhash);
2435         BLI_smallhash_init(ehash);
2436
2437         /* put list of cutting edges for a face into fhash, keyed by face */
2438         BLI_mempool_iternew(kcd->kedges, &iter);
2439         for (kfe = BLI_mempool_iterstep(&iter); kfe; kfe = BLI_mempool_iterstep(&iter)) {
2440                 f = kfe->basef;
2441                 if (!f || kfe->e)
2442                         continue;
2443                 lst = BLI_smallhash_lookup(fhash, (uintptr_t)f);
2444                 if (!lst) {
2445                         lst = knife_empty_list(kcd);
2446                         BLI_smallhash_insert(fhash, (uintptr_t)f, lst);
2447                 }
2448                 knife_append_list(kcd, lst, kfe);
2449         }
2450
2451         /* put list of splitting vertices for an edge into ehash, keyed by edge */
2452         BLI_mempool_iternew(kcd->kverts, &iter);
2453         for (kfv = BLI_mempool_iterstep(&iter); kfv; kfv = BLI_mempool_iterstep(&iter)) {
2454                 if (kfv->v)
2455                         continue;  /* already have a BMVert */
2456                 for (ref = kfv->edges.first; ref; ref = ref->next) {
2457                         kfe = ref->ref;
2458                         e = kfe->e;
2459                         if (!e)
2460                                 continue;
2461                         lst = BLI_smallhash_lookup(ehash, (uintptr_t)e);
2462                         if (!lst) {
2463                                 lst = knife_empty_list(kcd);
2464                                 BLI_smallhash_insert(ehash, (uintptr_t)e, lst);
2465                         }
2466                         /* there can be more than one kfe in kfv's list with same e */
2467                         if (!find_ref(lst, kfv))
2468                                 knife_append_list(kcd, lst, kfv);
2469                 }
2470         }
2471
2472         /* split bmesh edges where needed */
2473         for (lst = BLI_smallhash_iternew(ehash, &hiter, (uintptr_t *)&e); lst;
2474              lst = BLI_smallhash_iternext(&hiter, (uintptr_t *)&e))
2475         {
2476                 sort_by_frac_along(lst, e);
2477                 for (ref = lst->first; ref; ref = ref->next) {
2478                         kfv = ref->ref;
2479                         pct = line_point_factor_v3(kfv->co, e->v1->co, e->v2->co);
2480                         kfv->v = BM_edge_split(bm, e, e->v1, &enew, pct);
2481                 }
2482         }
2483
2484         if (kcd->only_select) {
2485                 EDBM_flag_disable_all(kcd->em, BM_ELEM_SELECT);
2486         }
2487
2488         /* do cuts for each face */
2489         for (lst = BLI_smallhash_iternew(fhash, &hiter, (uintptr_t *)&f); lst;
2490              lst = BLI_smallhash_iternext(&hiter, (uintptr_t *)&f))
2491         {
2492                 knife_make_face_cuts(kcd, f, lst);
2493         }
2494
2495         BLI_smallhash_release(fhash);
2496         BLI_smallhash_release(ehash);
2497 }
2498
2499 /* called on tool confirmation */
2500 static void knifetool_finish_ex(KnifeTool_OpData *kcd)
2501 {
2502         knife_make_cuts(kcd);
2503
2504         EDBM_selectmode_flush(kcd->em);
2505         EDBM_mesh_normals_update(kcd->em);
2506         EDBM_update_generic(kcd->em, true, true);
2507 }
2508 static void knifetool_finish(wmOperator *op)
2509 {
2510         KnifeTool_OpData *kcd = op->customdata;
2511         knifetool_finish_ex(kcd);
2512 }
2513
2514 static void knife_recalc_projmat(KnifeTool_OpData *kcd)
2515 {
2516         invert_m4_m4(kcd->ob->imat, kcd->ob->obmat);
2517         ED_view3d_ob_project_mat_get(kcd->ar->regiondata, kcd->ob, kcd->projmat);
2518         //mul_m4_m4m4(kcd->projmat, kcd->vc.rv3d->winmat, kcd->vc.rv3d->viewmat);
2519
2520         kcd->is_ortho = ED_view3d_clip_range_get(kcd->vc.v3d, kcd->vc.rv3d,
2521                                                  &kcd->clipsta, &kcd->clipend, true);
2522 }
2523
2524 /* called when modal loop selection is done... */
2525 static void knifetool_exit_ex(bContext *C, KnifeTool_OpData *kcd)
2526 {
2527         if (!kcd)
2528                 return;
2529
2530         if (kcd->is_interactive) {
2531                 WM_cursor_modal_restore(CTX_wm_window(C));
2532
2533                 /* deactivate the extra drawing stuff in 3D-View */
2534                 ED_region_draw_cb_exit(kcd->ar->type, kcd->draw_handle);
2535         }
2536
2537         /* free the custom data */
2538         BLI_mempool_destroy(kcd->refs);
2539         BLI_mempool_destroy(kcd->kverts);
2540         BLI_mempool_destroy(kcd->kedges);
2541
2542         BLI_ghash_free(kcd->origedgemap, NULL, NULL);
2543         BLI_ghash_free(kcd->origvertmap, NULL, NULL);
2544         BLI_ghash_free(kcd->kedgefacemap, NULL, NULL);
2545         BLI_ghash_free(kcd->facetrimap, NULL, NULL);
2546
2547         BKE_bmbvh_free(kcd->bmbvh);
2548         BLI_memarena_free(kcd->arena);
2549
2550         /* tag for redraw */
2551         ED_region_tag_redraw(kcd->ar);
2552
2553         if (kcd->cagecos)
2554                 MEM_freeN((void *)kcd->cagecos);
2555
2556         if (kcd->linehits)
2557                 MEM_freeN(kcd->linehits);
2558
2559         /* destroy kcd itself */
2560         MEM_freeN(kcd);
2561 }
2562 static void knifetool_exit(bContext *C, wmOperator *op)
2563 {
2564         KnifeTool_OpData *kcd = op->customdata;
2565         knifetool_exit_ex(C, kcd);
2566         op->customdata = NULL;
2567 }
2568
2569 static void knifetool_update_mval(KnifeTool_OpData *kcd, const float mval[2])
2570 {
2571         knife_recalc_projmat(kcd);
2572         copy_v2_v2(kcd->mval, mval);
2573
2574         if (knife_update_active(kcd)) {
2575                 ED_region_tag_redraw(kcd->ar);
2576         }
2577 }
2578
2579 static void knifetool_update_mval_i(KnifeTool_OpData *kcd, const int mval_i[2])
2580 {
2581         float mval[2] = {UNPACK2(mval_i)};
2582         knifetool_update_mval(kcd, mval);
2583 }
2584
2585 /* called when modal loop selection gets set up... */
2586 static void knifetool_init(bContext *C, KnifeTool_OpData *kcd,
2587                            const bool only_select, const bool cut_through, const bool is_interactive)
2588 {
2589         Scene *scene = CTX_data_scene(C);
2590         Object *obedit = CTX_data_edit_object(C);
2591
2592         /* assign the drawing handle for drawing preview line... */
2593         kcd->ob = obedit;
2594         kcd->ar = CTX_wm_region(C);
2595
2596         em_setup_viewcontext(C, &kcd->vc);
2597
2598         kcd->em = BKE_editmesh_from_object(kcd->ob);
2599
2600         BM_mesh_elem_index_ensure(kcd->em->bm, BM_VERT);
2601
2602         kcd->cagecos = (const float (*)[3])BKE_editmesh_vertexCos_get(kcd->em, scene, NULL);
2603
2604         kcd->bmbvh = BKE_bmbvh_new_from_editmesh(kcd->em,
2605                                                  BMBVH_RETURN_ORIG |
2606                                                  (only_select ? BMBVH_RESPECT_SELECT : BMBVH_RESPECT_HIDDEN),
2607                                                  kcd->cagecos, false);
2608
2609         kcd->arena = BLI_memarena_new(MEM_SIZE_OPTIMAL(1 << 15), "knife");
2610         kcd->vthresh = KMAXDIST - 1;
2611         kcd->ethresh = KMAXDIST;
2612
2613         knife_recalc_projmat(kcd);
2614
2615         ED_region_tag_redraw(kcd->ar);
2616
2617         kcd->refs = BLI_mempool_create(sizeof(Ref), 1, 2048, 0);
2618         kcd->kverts = BLI_mempool_create(sizeof(KnifeVert), 1, 512, BLI_MEMPOOL_ALLOW_ITER);
2619         kcd->kedges = BLI_mempool_create(sizeof(KnifeEdge), 1, 512, BLI_MEMPOOL_ALLOW_ITER);
2620
2621         kcd->origedgemap = BLI_ghash_ptr_new("knife origedgemap");
2622         kcd->origvertmap = BLI_ghash_ptr_new("knife origvertmap");
2623         kcd->kedgefacemap = BLI_ghash_ptr_new("knife kedgefacemap");
2624         kcd->facetrimap = BLI_ghash_ptr_new("knife facetrimap");
2625
2626         /* cut all the way through the mesh if use_occlude_geometry button not pushed */
2627         kcd->is_interactive = is_interactive;
2628         kcd->cut_through = cut_through;
2629         kcd->only_select = only_select;
2630
2631         /* can't usefully select resulting edges in face mode */
2632         kcd->select_result = (kcd->em->selectmode != SCE_SELECT_FACE);
2633
2634         knife_pos_data_clear(&kcd->curr);
2635         knife_pos_data_clear(&kcd->prev);
2636
2637         if (is_interactive) {
2638                 kcd->draw_handle = ED_region_draw_cb_activate(kcd->ar->type, knifetool_draw, kcd, REGION_DRAW_POST_VIEW);
2639
2640                 knife_init_colors(&kcd->colors);
2641         }
2642 }
2643
2644 static void knifetool_cancel(bContext *C, wmOperator *op)
2645 {
2646         /* this is just a wrapper around exit() */
2647         knifetool_exit(C, op);
2648 }
2649
2650 static int knifetool_invoke(bContext *C, wmOperator *op, const wmEvent *event)
2651 {
2652         const bool only_select = RNA_boolean_get(op->ptr, "only_selected");
2653         const bool cut_through = !RNA_boolean_get(op->ptr, "use_occlude_geometry");
2654
2655         KnifeTool_OpData *kcd;
2656
2657         if (only_select) {
2658                 Object *obedit = CTX_data_edit_object(C);
2659                 BMEditMesh *em = BKE_editmesh_from_object(obedit);
2660                 if (em->bm->totfacesel == 0) {
2661                         BKE_report(op->reports, RPT_ERROR, "Selected faces required");
2662                         return OPERATOR_CANCELLED;
2663                 }
2664         }
2665
2666         view3d_operator_needs_opengl(C);
2667
2668         /* alloc new customdata */
2669         kcd = op->customdata = MEM_callocN(sizeof(KnifeTool_OpData), __func__);
2670
2671         knifetool_init(C, kcd, only_select, cut_through, true);
2672
2673         /* add a modal handler for this operator - handles loop selection */
2674         WM_cursor_modal_set(CTX_wm_window(C), BC_KNIFECURSOR);
2675         WM_event_add_modal_handler(C, op);
2676
2677         knifetool_update_mval_i(kcd, event->mval);
2678
2679         knife_update_header(C, kcd);
2680
2681         return OPERATOR_RUNNING_MODAL;
2682 }
2683
2684 enum {
2685         KNF_MODAL_CANCEL = 1,
2686         KNF_MODAL_CONFIRM,
2687         KNF_MODAL_MIDPOINT_ON,
2688         KNF_MODAL_MIDPOINT_OFF,
2689         KNF_MODAL_NEW_CUT,
2690         KNF_MODEL_IGNORE_SNAP_ON,
2691         KNF_MODEL_IGNORE_SNAP_OFF,
2692         KNF_MODAL_ADD_CUT,
2693         KNF_MODAL_ANGLE_SNAP_TOGGLE,
2694         KNF_MODAL_CUT_THROUGH_TOGGLE,
2695         KNF_MODAL_PANNING
2696 };
2697
2698 wmKeyMap *knifetool_modal_keymap(wmKeyConfig *keyconf)
2699 {
2700         static EnumPropertyItem modal_items[] = {
2701                 {KNF_MODAL_CANCEL, "CANCEL", 0, "Cancel", ""},
2702                 {KNF_MODAL_CONFIRM, "CONFIRM", 0, "Confirm", ""},
2703                 {KNF_MODAL_MIDPOINT_ON, "SNAP_MIDPOINTS_ON", 0, "Snap To Midpoints On", ""},
2704                 {KNF_MODAL_MIDPOINT_OFF, "SNAP_MIDPOINTS_OFF", 0, "Snap To Midpoints Off", ""},
2705                 {KNF_MODEL_IGNORE_SNAP_ON, "IGNORE_SNAP_ON", 0, "Ignore Snapping On", ""},
2706                 {KNF_MODEL_IGNORE_SNAP_OFF, "IGNORE_SNAP_OFF", 0, "Ignore Snapping Off", ""},
2707                 {KNF_MODAL_ANGLE_SNAP_TOGGLE, "ANGLE_SNAP_TOGGLE", 0, "Toggle Angle Snapping", ""},
2708                 {KNF_MODAL_CUT_THROUGH_TOGGLE, "CUT_THROUGH_TOGGLE", 0, "Toggle Cut Through", ""},
2709                 {KNF_MODAL_NEW_CUT, "NEW_CUT", 0, "End Current Cut", ""},
2710                 {KNF_MODAL_ADD_CUT, "ADD_CUT", 0, "Add Cut", ""},
2711                 {KNF_MODAL_PANNING, "PANNING", 0, "Panning", ""},
2712                 {0, NULL, 0, NULL, NULL}
2713         };
2714
2715         wmKeyMap *keymap = WM_modalkeymap_get(keyconf, "Knife Tool Modal Map");
2716
2717         /* this function is called for each spacetype, only needs to add map once */
2718         if (keymap && keymap->modal_items)
2719                 return NULL;
2720
2721         keymap = WM_modalkeymap_add(keyconf, "Knife Tool Modal Map", modal_items);
2722
2723         /* items for modal map */
2724         WM_modalkeymap_add_item(keymap, ESCKEY, KM_PRESS, KM_ANY, 0, KNF_MODAL_CANCEL);
2725         WM_modalkeymap_add_item(keymap, MIDDLEMOUSE, KM_ANY, KM_ANY, 0, KNF_MODAL_PANNING);
2726         WM_modalkeymap_add_item(keymap, LEFTMOUSE, KM_PRESS, KM_ANY, 0, KNF_MODAL_ADD_CUT);
2727         WM_modalkeymap_add_item(keymap, RIGHTMOUSE, KM_PRESS, KM_ANY, 0, KNF_MODAL_CANCEL);
2728         WM_modalkeymap_add_item(keymap, RETKEY, KM_PRESS, KM_ANY, 0, KNF_MODAL_CONFIRM);
2729         WM_modalkeymap_add_item(keymap, PADENTER, KM_PRESS, KM_ANY, 0, KNF_MODAL_CONFIRM);
2730         WM_modalkeymap_add_item(keymap, SPACEKEY, KM_PRESS, KM_ANY, 0, KNF_MODAL_CONFIRM);
2731         WM_modalkeymap_add_item(keymap, EKEY, KM_PRESS, 0, 0, KNF_MODAL_NEW_CUT);
2732
2733         WM_modalkeymap_add_item(keymap, LEFTCTRLKEY, KM_PRESS, KM_ANY, 0, KNF_MODAL_MIDPOINT_ON);
2734         WM_modalkeymap_add_item(keymap, LEFTCTRLKEY, KM_RELEASE, KM_ANY, 0, KNF_MODAL_MIDPOINT_OFF);
2735         WM_modalkeymap_add_item(keymap, RIGHTCTRLKEY, KM_PRESS, KM_ANY, 0, KNF_MODAL_MIDPOINT_ON);
2736         WM_modalkeymap_add_item(keymap, RIGHTCTRLKEY, KM_RELEASE, KM_ANY, 0, KNF_MODAL_MIDPOINT_OFF);
2737
2738         WM_modalkeymap_add_item(keymap, LEFTSHIFTKEY, KM_PRESS, KM_ANY, 0, KNF_MODEL_IGNORE_SNAP_ON);
2739         WM_modalkeymap_add_item(keymap, LEFTSHIFTKEY, KM_RELEASE, KM_ANY, 0, KNF_MODEL_IGNORE_SNAP_OFF);
2740         WM_modalkeymap_add_item(keymap, RIGHTSHIFTKEY, KM_PRESS, KM_ANY, 0, KNF_MODEL_IGNORE_SNAP_ON);
2741         WM_modalkeymap_add_item(keymap, RIGHTSHIFTKEY, KM_RELEASE, KM_ANY, 0, KNF_MODEL_IGNORE_SNAP_OFF);
2742
2743         WM_modalkeymap_add_item(keymap, CKEY, KM_PRESS, 0, 0, KNF_MODAL_ANGLE_SNAP_TOGGLE);
2744         WM_modalkeymap_add_item(keymap, ZKEY, KM_PRESS, 0, 0, KNF_MODAL_CUT_THROUGH_TOGGLE);
2745
2746         WM_modalkeymap_assign(keymap, "MESH_OT_knife_tool");
2747
2748         return keymap;
2749 }
2750
2751 static int knifetool_modal(bContext *C, wmOperator *op, const wmEvent *event)
2752 {
2753         Object *obedit = CTX_data_edit_object(C);
2754         KnifeTool_OpData *kcd = op->customdata;
2755         bool do_refresh = false;
2756
2757         if (!obedit || obedit->type != OB_MESH || BKE_editmesh_from_object(obedit) != kcd->em) {
2758                 knifetool_exit(C, op);
2759                 ED_area_headerprint(CTX_wm_area(C), NULL);
2760                 return OPERATOR_FINISHED;
2761         }
2762
2763         view3d_operator_needs_opengl(C);
2764         ED_view3d_init_mats_rv3d(obedit, kcd->vc.rv3d);  /* needed to initialize clipping */
2765
2766         if (kcd->mode == MODE_PANNING)
2767                 kcd->mode = kcd->prevmode;
2768
2769         /* handle modal keymap */
2770         if (event->type == EVT_MODAL_MAP) {
2771                 switch (event->val) {
2772                         case KNF_MODAL_CANCEL:
2773                                 /* finish */
2774                                 ED_region_tag_redraw(kcd->ar);
2775
2776                                 knifetool_exit(C, op);
2777                                 ED_area_headerprint(CTX_wm_area(C), NULL);
2778
2779                                 return OPERATOR_CANCELLED;
2780                         case KNF_MODAL_CONFIRM:
2781                                 /* finish */
2782                                 ED_region_tag_redraw(kcd->ar);
2783
2784                                 knifetool_finish(op);
2785                                 knifetool_exit(C, op);
2786                                 ED_area_headerprint(CTX_wm_area(C), NULL);
2787
2788                                 return OPERATOR_FINISHED;
2789                         case KNF_MODAL_MIDPOINT_ON:
2790                                 kcd->snap_midpoints = true;
2791
2792                                 knife_recalc_projmat(kcd);
2793                                 knife_update_active(kcd);
2794                                 knife_update_header(C, kcd);
2795                                 ED_region_tag_redraw(kcd->ar);
2796                                 do_refresh = true;
2797                                 break;
2798                         case KNF_MODAL_MIDPOINT_OFF:
2799                                 kcd->snap_midpoints = false;
2800
2801                                 knife_recalc_projmat(kcd);
2802                                 knife_update_active(kcd);
2803                                 knife_update_header(C, kcd);
2804                                 ED_region_tag_redraw(kcd->ar);
2805                                 do_refresh = true;
2806                                 break;
2807                         case KNF_MODEL_IGNORE_SNAP_ON:
2808                                 ED_region_tag_redraw(kcd->ar);
2809                                 kcd->ignore_vert_snapping = kcd->ignore_edge_snapping = true;
2810                                 knife_update_header(C, kcd);
2811                                 do_refresh = true;
2812                                 break;
2813                         case KNF_MODEL_IGNORE_SNAP_OFF:
2814                                 ED_region_tag_redraw(kcd->ar);
2815                                 kcd->ignore_vert_snapping = kcd->ignore_edge_snapping = false;
2816                                 knife_update_header(C, kcd);
2817                                 do_refresh = true;
2818                                 break;
2819                         case KNF_MODAL_ANGLE_SNAP_TOGGLE:
2820                                 kcd->angle_snapping = !kcd->angle_snapping;
2821                                 knife_update_header(C, kcd);
2822                                 do_refresh = true;
2823                                 break;
2824                         case KNF_MODAL_CUT_THROUGH_TOGGLE:
2825                                 kcd->cut_through = !kcd->cut_through;
2826                                 knife_update_header(C, kcd);
2827                                 do_refresh = true;
2828                                 break;
2829                         case KNF_MODAL_NEW_CUT:
2830                                 ED_region_tag_redraw(kcd->ar);
2831                                 knife_finish_cut(kcd);
2832                                 kcd->mode = MODE_IDLE;
2833                                 break;
2834                         case KNF_MODAL_ADD_CUT:
2835                                 knife_recalc_projmat(kcd);
2836
2837                                 if (kcd->mode == MODE_DRAGGING) {
2838                                         knife_add_cut(kcd);
2839                                 }
2840                                 else if (kcd->mode != MODE_PANNING) {
2841                                         knife_start_cut(kcd);
2842                                         kcd->mode = MODE_DRAGGING;
2843                                 }
2844
2845                                 ED_region_tag_redraw(kcd->ar);
2846                                 break;
2847                         case KNF_MODAL_PANNING:
2848                                 if (event->val != KM_RELEASE) {
2849                                         if (kcd->mode != MODE_PANNING) {
2850                                                 kcd->prevmode = kcd->mode;
2851                                                 kcd->mode = MODE_PANNING;
2852                                         }
2853                                 }
2854                                 else {
2855                                         kcd->mode = kcd->prevmode;
2856                                 }
2857
2858                                 ED_region_tag_redraw(kcd->ar);
2859                                 return OPERATOR_PASS_THROUGH;
2860                                 break;
2861                 }
2862         }
2863         else { /* non-modal-mapped events */
2864                 switch (event->type) {
2865                         case MOUSEPAN:
2866                         case MOUSEZOOM:
2867                         case MOUSEROTATE:
2868                         case WHEELUPMOUSE:
2869                         case WHEELDOWNMOUSE:
2870                                 return OPERATOR_PASS_THROUGH;
2871                         case MOUSEMOVE: /* mouse moved somewhere to select another loop */
2872                                 if (kcd->mode != MODE_PANNING) {
2873                                         knifetool_update_mval_i(kcd, event->mval);
2874                                 }
2875
2876                                 break;
2877                 }
2878         }
2879
2880         if (do_refresh) {
2881                 /* we don't really need to update mval,
2882                  * but this happens to be the best way to refresh at the moment */
2883                 knifetool_update_mval_i(kcd, event->mval);
2884         }
2885
2886         /* keep going until the user confirms */
2887         return OPERATOR_RUNNING_MODAL;
2888 }
2889
2890 void MESH_OT_knife_tool(wmOperatorType *ot)
2891 {
2892         /* description */
2893         ot->name = "Knife Topology Tool";
2894         ot->idname = "MESH_OT_knife_tool";
2895         ot->description = "Cut new topology";
2896
2897         /* callbacks */
2898         ot->invoke = knifetool_invoke;
2899         ot->modal = knifetool_modal;
2900         ot->cancel = knifetool_cancel;
2901         ot->poll = ED_operator_editmesh_view3d;
2902
2903         /* flags */
2904         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO | OPTYPE_BLOCKING;
2905
2906         RNA_def_boolean(ot->srna, "use_occlude_geometry", true, "Occlude Geometry", "Only cut the front most geometry");
2907         RNA_def_boolean(ot->srna, "only_selected", false, "Only Selected", "Only cut selected geometry");
2908 }
2909
2910
2911 /* -------------------------------------------------------------------- */
2912 /* Knife tool as a utility function
2913  * that can be used for internal slicing operations */
2914
2915 /**
2916  * Return a point inside the face.
2917  *
2918  * tessellation here seems way overkill,
2919  * but without this its very hard to know of a point is inside the face
2920  */
2921 static void edvm_mesh_knife_face_point(BMFace *f, float r_cent[3])
2922 {
2923         const int tottri = f->len - 2;
2924         BMLoop **loops = BLI_array_alloca(loops, f->len);
2925         unsigned int  (*index)[3] = BLI_array_alloca(index, tottri);
2926         int j;
2927
2928         float const *best_co[3] = {NULL};
2929         float best_area  = -1.0f;
2930         bool ok = false;
2931
2932         BM_face_calc_tessellation(f, loops, index);
2933
2934         for (j = 0; j < tottri; j++) {
2935                 const float *p1 = loops[index[j][0]]->v->co;
2936                 const float *p2 = loops[index[j][1]]->v->co;
2937                 const float *p3 = loops[index[j][2]]->v->co;
2938                 float area;
2939
2940                 float cross[3];
2941                 cross_v3_v3v3(cross, p2, p3);
2942                 area = fabsf(dot_v3v3(p1, cross));
2943                 if (area > best_area) {
2944                         best_co[0] = p1;
2945                         best_co[1] = p2;
2946                         best_co[2] = p3;
2947                         best_area = area;
2948                         ok = true;
2949                 }
2950         }
2951
2952         if (ok) {
2953                 mid_v3_v3v3v3(r_cent, best_co[0], best_co[1], best_co[2]);
2954         }
2955         else {
2956                 mid_v3_v3v3v3(r_cent, loops[0]->v->co, loops[1]->v->co, loops[2]->v->co);
2957         }
2958 }
2959
2960 static bool edbm_mesh_knife_face_isect(ARegion *ar, LinkNode *polys, BMFace *f, float projmat[4][4])
2961 {
2962         float cent_ss[2];
2963         float cent[3];
2964
2965         edvm_mesh_knife_face_point(f, cent);
2966
2967         ED_view3d_project_float_v2_m4(ar, cent, cent_ss, projmat);
2968
2969         /* check */
2970         {
2971                 LinkNode *p = polys;
2972                 int isect = 0;
2973
2974                 while (p) {
2975                         const float (*mval_fl)[2] = p->link;
2976                         const int mval_tot = MEM_allocN_len(mval_fl) / sizeof(*mval_fl);
2977                         isect += (int)isect_point_poly_v2(cent_ss, mval_fl, mval_tot - 1, false);
2978                         p = p->next;
2979                 }
2980
2981                 if (isect % 2) {
2982                         return true;
2983                 }
2984         }
2985
2986         return false;
2987 }
2988
2989 /**
2990  * \param use_tag  When set, tag all faces inside the polylines.
2991  */
2992 void EDBM_mesh_knife(bContext *C, LinkNode *polys, bool use_tag, bool cut_through)
2993 {
2994         KnifeTool_OpData *kcd;
2995
2996         view3d_operator_needs_opengl(C);
2997
2998         /* init */
2999         {
3000                 const bool only_select = false;
3001                 const bool is_interactive = false;  /* can enable for testing */
3002
3003                 kcd = MEM_callocN(sizeof(KnifeTool_OpData), __func__);
3004
3005                 knifetool_init(C, kcd, only_select, cut_through, is_interactive);
3006
3007                 kcd->ignore_edge_snapping = true;
3008                 kcd->ignore_vert_snapping = true;
3009
3010                 if (use_tag) {
3011                         BM_mesh_elem_hflag_enable_all(kcd->em->bm, BM_EDGE, BM_ELEM_TAG, false);
3012                 }
3013         }
3014
3015         /* execute */
3016         {
3017                 LinkNode *p = polys;
3018
3019                 knife_recalc_projmat(kcd);
3020
3021                 while (p) {
3022                         const float (*mval_fl)[2] = p->link;
3023                         const int mval_tot = MEM_allocN_len(mval_fl) / sizeof(*mval_fl);
3024                         int i;
3025
3026                         for (i = 0; i < mval_tot; i++) {
3027                                 knifetool_update_mval(kcd, mval_fl[i]);
3028                                 if (i == 0) {
3029                                         knife_start_cut(kcd);
3030                                         kcd->mode = MODE_DRAGGING;
3031                                 }
3032                                 else {
3033                                         knife_add_cut(kcd);
3034                                 }
3035                         }
3036                         knife_finish_cut(kcd);
3037                         kcd->mode = MODE_IDLE;
3038                         p = p->next;
3039                 }
3040         }
3041
3042         /* finish */
3043         {
3044                 knifetool_finish_ex(kcd);
3045
3046                 /* tag faces inside! */
3047                 if (use_tag) {
3048                         BMesh *bm = kcd->em->bm;
3049                         float projmat[4][4];
3050
3051                         BMEdge *e;
3052                         BMIter iter;
3053
3054                         bool keep_search;
3055
3056                         ED_view3d_ob_project_mat_get(kcd->ar->regiondata, kcd->ob, projmat);
3057
3058                         /* use face-loop tag to store if we have intersected */
3059 #define F_ISECT_IS_UNKNOWN(f)  BM_elem_flag_test(BM_FACE_FIRST_LOOP(f), BM_ELEM_TAG)
3060 #define F_ISECT_SET_UNKNOWN(f) BM_elem_flag_enable(BM_FACE_FIRST_LOOP(f), BM_ELEM_TAG)
3061 #define F_ISECT_SET_OUTSIDE(f) BM_elem_flag_disable(BM_FACE_FIRST_LOOP(f), BM_ELEM_TAG)
3062                         {
3063                                 BMFace *f;
3064                                 BM_ITER_MESH (f, &iter, bm, BM_FACES_OF_MESH) {
3065                                         F_ISECT_SET_UNKNOWN(f);
3066                                         BM_elem_flag_disable(f, BM_ELEM_TAG);
3067                                 }
3068                         }
3069
3070                         /* tag all faces linked to cut edges */
3071                         BM_ITER_MESH (e, &iter, bm, BM_EDGES_OF_MESH) {
3072                                 /* check are we tagged?, then we are an original face */
3073                                 if (BM_elem_flag_test(e, BM_ELEM_TAG) == false) {
3074                                         BMFace *f;