GSOC 2013 paint
[blender-staging.git] / source / blender / editors / sculpt_paint / sculpt_undo.c
index 053e17cde075c821bab05162f0f5d830f773a040..614c1f3ef1d4c7b21938ef7725a52e073763d592 100644 (file)
 #include "DNA_mesh_types.h"
 
 #include "BKE_ccg.h"
-#include "BKE_cdderivedmesh.h"
 #include "BKE_context.h"
 #include "BKE_depsgraph.h"
-#include "BKE_modifier.h"
 #include "BKE_multires.h"
 #include "BKE_paint.h"
 #include "BKE_key.h"
@@ -64,7 +62,9 @@
 
 #include "GPU_buffers.h"
 
-#include "ED_sculpt.h"
+#include "ED_paint.h"
+
+#include "bmesh.h"
 #include "paint_intern.h"
 #include "sculpt_intern.h"
 
 
 static void update_cb(PBVHNode *node, void *rebuild)
 {
-       BLI_pbvh_node_mark_update(node);
-       if (*((int *)rebuild))
-               BLI_pbvh_node_mark_rebuild_draw(node);
-       BLI_pbvh_node_fully_hidden_set(node, 0);
+       BKE_pbvh_node_mark_update(node);
+       if (*((bool *)rebuild))
+               BKE_pbvh_node_mark_rebuild_draw(node);
+       BKE_pbvh_node_fully_hidden_set(node, 0);
 }
 
 static void sculpt_undo_restore_deformed(const SculptSession *ss,
@@ -113,7 +113,7 @@ static int sculpt_undo_restore_coords(bContext *C, DerivedMesh *dm, SculptUndoNo
                        if (kb) {
                                ob->shapenr = BLI_findindex(&key->block, kb) + 1;
 
-                               sculpt_update_mesh_elements(scene, sd, ob, 0, FALSE);
+                               BKE_sculpt_update_mesh_elements(scene, sd, ob, 0, false);
                                WM_event_add_notifier(C, NC_OBJECT | ND_DATA, ob);
                        }
                        else {
@@ -130,7 +130,9 @@ static int sculpt_undo_restore_coords(bContext *C, DerivedMesh *dm, SculptUndoNo
                        vertCos = BKE_key_convert_to_vertcos(ob, ss->kb);
 
                        for (i = 0; i < unode->totvert; i++) {
-                               if (ss->modifiers_active) sculpt_undo_restore_deformed(ss, unode, i, index[i], vertCos[index[i]]);
+                               if (ss->modifiers_active) {
+                                       sculpt_undo_restore_deformed(ss, unode, i, index[i], vertCos[index[i]]);
+                               }
                                else {
                                        if (unode->orig_co) swap_v3_v3(vertCos[index[i]], unode->orig_co[i]);
                                        else swap_v3_v3(vertCos[index[i]], unode->co[i]);
@@ -142,13 +144,15 @@ static int sculpt_undo_restore_coords(bContext *C, DerivedMesh *dm, SculptUndoNo
 
                        /* pbvh uses it's own mvert array, so coords should be */
                        /* propagated to pbvh here */
-                       BLI_pbvh_apply_vertCos(ss->pbvh, vertCos);
+                       BKE_pbvh_apply_vertCos(ss->pbvh, vertCos);
 
                        MEM_freeN(vertCos);
                }
                else {
                        for (i = 0; i < unode->totvert; i++) {
-                               if (ss->modifiers_active) sculpt_undo_restore_deformed(ss, unode, i, index[i], mvert[index[i]].co);
+                               if (ss->modifiers_active) {
+                                       sculpt_undo_restore_deformed(ss, unode, i, index[i], mvert[index[i]].co);
+                               }
                                else {
                                        if (unode->orig_co) swap_v3_v3(mvert[index[i]].co, unode->orig_co[i]);
                                        else swap_v3_v3(mvert[index[i]].co, unode->co[i]);
@@ -192,9 +196,9 @@ static int sculpt_undo_restore_hidden(bContext *C, DerivedMesh *dm,
                
                for (i = 0; i < unode->totvert; i++) {
                        MVert *v = &mvert[unode->index[i]];
-                       int uval = BLI_BITMAP_GET(unode->vert_hidden, i);
+                       int uval = BLI_BITMAP_TEST(unode->vert_hidden, i);
 
-                       BLI_BITMAP_MODIFY(unode->vert_hidden, i,
+                       BLI_BITMAP_SET(unode->vert_hidden, i,
                                          v->flag & ME_HIDE);
                        if (uval)
                                v->flag |= ME_HIDE;
@@ -205,10 +209,10 @@ static int sculpt_undo_restore_hidden(bContext *C, DerivedMesh *dm,
                }
        }
        else if (unode->maxgrid && dm->getGridData) {
-               BLI_bitmap *grid_hidden = dm->getGridHidden(dm);
+               BLI_bitmap **grid_hidden = dm->getGridHidden(dm);
                
                for (i = 0; i < unode->totgrid; i++) {
-                       SWAP(BLI_bitmap,
+                       SWAP(BLI_bitmap *,
                             unode->grid_hidden[i],
                             grid_hidden[unode->grids[i]]);
                        
@@ -261,6 +265,133 @@ static int sculpt_undo_restore_mask(bContext *C, DerivedMesh *dm, SculptUndoNode
        return 1;
 }
 
+static void sculpt_undo_bmesh_restore_generic(bContext *C,
+                                              SculptUndoNode *unode,
+                                              Object *ob,
+                                              SculptSession *ss)
+{
+       if (unode->applied) {
+               BM_log_undo(ss->bm, ss->bm_log);
+               unode->applied = false;
+       }
+       else {
+               BM_log_redo(ss->bm, ss->bm_log);
+               unode->applied = true;
+       }
+
+       if (ELEM(unode->type, SCULPT_UNDO_MASK, SCULPT_UNDO_MASK)) {
+               int i, totnode;
+               PBVHNode **nodes;
+
+#ifdef _OPENMP
+               Sculpt *sd = CTX_data_tool_settings(C)->sculpt;
+#else
+               (void)C;
+#endif
+
+               BKE_pbvh_search_gather(ss->pbvh, NULL, NULL, &nodes, &totnode);
+
+#pragma omp parallel for schedule(guided) if (sd->flags & SCULPT_USE_OPENMP)
+               for (i = 0; i < totnode; i++) {
+                       BKE_pbvh_node_mark_redraw(nodes[i]);
+               }
+
+               if (nodes)
+                       MEM_freeN(nodes);
+       }
+       else {
+               sculpt_pbvh_clear(ob);
+       }
+}
+
+/* Create empty sculpt BMesh and enable logging */
+static void sculpt_undo_bmesh_enable(Object *ob,
+                                     SculptUndoNode *unode)
+{
+       SculptSession *ss = ob->sculpt;
+       Mesh *me = ob->data;
+
+       sculpt_pbvh_clear(ob);
+
+       /* Create empty BMesh and enable logging */
+       ss->bm = BM_mesh_create(&bm_mesh_allocsize_default);
+       BM_data_layer_add(ss->bm, &ss->bm->vdata, CD_PAINT_MASK);
+       sculpt_dyntopo_node_layers_add(ss);
+       me->flag |= ME_SCULPT_DYNAMIC_TOPOLOGY;
+
+       /* Restore the BMLog using saved entries */
+       ss->bm_log = BM_log_from_existing_entries_create(ss->bm,
+                                                        unode->bm_entry);
+}
+
+static void sculpt_undo_bmesh_restore_begin(bContext *C,
+                                            SculptUndoNode *unode,
+                                            Object *ob,
+                                            SculptSession *ss)
+{
+       if (unode->applied) {
+               sculpt_dynamic_topology_disable(C, unode);
+               unode->applied = false;
+       }
+       else {
+               sculpt_undo_bmesh_enable(ob, unode);
+
+               /* Restore the mesh from the first log entry */
+               BM_log_redo(ss->bm, ss->bm_log);
+
+               unode->applied = true;
+       }
+}
+
+static void sculpt_undo_bmesh_restore_end(bContext *C,
+                                          SculptUndoNode *unode,
+                                          Object *ob,
+                                          SculptSession *ss)
+{
+       if (unode->applied) {
+               sculpt_undo_bmesh_enable(ob, unode);
+
+               /* Restore the mesh from the last log entry */
+               BM_log_undo(ss->bm, ss->bm_log);
+
+               unode->applied = false;
+       }
+       else {
+               /* Disable dynamic topology sculpting */
+               sculpt_dynamic_topology_disable(C, NULL);
+               unode->applied = true;
+       }
+}
+
+/* Handle all dynamic-topology updates
+ *
+ * Returns true if this was a dynamic-topology undo step, otherwise
+ * returns false to indicate the non-dyntopo code should run. */
+static int sculpt_undo_bmesh_restore(bContext *C,
+                                     SculptUndoNode *unode,
+                                     Object *ob,
+                                     SculptSession *ss)
+{
+       switch (unode->type) {
+               case SCULPT_UNDO_DYNTOPO_BEGIN:
+                       sculpt_undo_bmesh_restore_begin(C, unode, ob, ss);
+                       return true;
+
+               case SCULPT_UNDO_DYNTOPO_END:
+                       sculpt_undo_bmesh_restore_end(C, unode, ob, ss);
+                       return true;
+
+               default:
+                       if (ss->bm_log) {
+                               sculpt_undo_bmesh_restore_generic(C, unode, ob, ss);
+                               return true;
+                       }
+                       break;
+       }
+
+       return false;
+}
+
 static void sculpt_undo_restore(bContext *C, ListBase *lb)
 {
        Scene *scene = CTX_data_scene(C);
@@ -269,26 +400,28 @@ static void sculpt_undo_restore(bContext *C, ListBase *lb)
        DerivedMesh *dm;
        SculptSession *ss = ob->sculpt;
        SculptUndoNode *unode;
-       MultiresModifierData *mmd;
-       int update = FALSE, rebuild = FALSE;
-       int need_mask = FALSE;
+       bool update = false, rebuild = false;
+       bool need_mask = false;
 
        for (unode = lb->first; unode; unode = unode->next) {
                if (strcmp(unode->idname, ob->id.name) == 0) {
                        if (unode->type == SCULPT_UNDO_MASK) {
                                /* is possible that we can't do the mask undo (below)
                                 * because of the vertex count */
-                               need_mask = TRUE;
+                               need_mask = true;
                                break;
                        }
                }
        }
 
-       sculpt_update_mesh_elements(scene, sd, ob, 0, need_mask);
+       BKE_sculpt_update_mesh_elements(scene, sd, ob, 0, need_mask);
 
        /* call _after_ sculpt_update_mesh_elements() which may update 'ob->derivedFinal' */
        dm = mesh_get_derived_final(scene, ob, 0);
 
+       if (lb->first && sculpt_undo_bmesh_restore(C, lb->first, ob, ss))
+               return;
+
        for (unode = lb->first; unode; unode = unode->next) {
                if (!(strcmp(unode->idname, ob->id.name) == 0))
                        continue;
@@ -306,54 +439,61 @@ static void sculpt_undo_restore(bContext *C, ListBase *lb)
                                continue;
                        }
                }
-               else {
-                       continue;
-               }
 
                switch (unode->type) {
                        case SCULPT_UNDO_COORDS:
                                if (sculpt_undo_restore_coords(C, dm, unode))
-                                       update = TRUE;
+                                       update = true;
                                break;
                        case SCULPT_UNDO_HIDDEN:
                                if (sculpt_undo_restore_hidden(C, dm, unode))
-                                       rebuild = TRUE;
+                                       rebuild = true;
                                break;
                        case SCULPT_UNDO_MASK:
                                if (sculpt_undo_restore_mask(C, dm, unode))
-                                       update = TRUE;
+                                       update = true;
+                               break;
+
+                       case SCULPT_UNDO_DYNTOPO_BEGIN:
+                       case SCULPT_UNDO_DYNTOPO_END:
+                       case SCULPT_UNDO_DYNTOPO_SYMMETRIZE:
+                               BLI_assert(!"Dynamic topology should've already been handled");
                                break;
                }
        }
 
        if (update || rebuild) {
-               int tag_update = 0;
+               bool tag_update = false;
                /* we update all nodes still, should be more clever, but also
                 * needs to work correct when exiting/entering sculpt mode and
                 * the nodes get recreated, though in that case it could do all */
-               BLI_pbvh_search_callback(ss->pbvh, NULL, NULL, update_cb, &rebuild);
-               BLI_pbvh_update(ss->pbvh, PBVH_UpdateBB | PBVH_UpdateOriginalBB | PBVH_UpdateRedraw, NULL);
+               BKE_pbvh_search_callback(ss->pbvh, NULL, NULL, update_cb, &rebuild);
+               BKE_pbvh_update(ss->pbvh, PBVH_UpdateBB | PBVH_UpdateOriginalBB | PBVH_UpdateRedraw, NULL);
 
-               if ((mmd = sculpt_multires_active(scene, ob))) {
+               if (BKE_sculpt_multires_active(scene, ob)) {
                        if (rebuild)
                                multires_mark_as_modified(ob, MULTIRES_HIDDEN_MODIFIED);
                        else
                                multires_mark_as_modified(ob, MULTIRES_COORDS_MODIFIED);
                }
 
-               tag_update = ((Mesh *)ob->data)->id.us > 1;
+               tag_update |= ((Mesh *)ob->data)->id.us > 1;
 
-               if (ss->modifiers_active) {
+               if (ss->kb || ss->modifiers_active) {
                        Mesh *mesh = ob->data;
                        BKE_mesh_calc_normals_tessface(mesh->mvert, mesh->totvert,
                                                       mesh->mface, mesh->totface, NULL);
 
-                       free_sculptsession_deformMats(ss);
-                       tag_update |= 1;
+                       BKE_free_sculptsession_deformMats(ss);
+                       tag_update |= true;
                }
 
-               if (tag_update)
+               if (tag_update) {
                        DAG_id_tag_update(&ob->id, OB_RECALC_DATA);
+               }
+               else {
+                       sculpt_update_object_bounding_box(ob);
+               }
 
                /* for non-PBVH drawing, need to recreate VBOs */
                GPU_drawobject_free(ob->derivedFinal);
@@ -387,7 +527,37 @@ static void sculpt_undo_free(ListBase *lb)
                }
                if (unode->mask)
                        MEM_freeN(unode->mask);
+
+               if (unode->bm_entry) {
+                       BM_log_entry_drop(unode->bm_entry);
+               }
+
+               if (unode->bm_enter_totvert)
+                       CustomData_free(&unode->bm_enter_vdata, unode->bm_enter_totvert);
+               if (unode->bm_enter_totedge)
+                       CustomData_free(&unode->bm_enter_edata, unode->bm_enter_totedge);
+               if (unode->bm_enter_totloop)
+                       CustomData_free(&unode->bm_enter_ldata, unode->bm_enter_totloop);
+               if (unode->bm_enter_totpoly)
+                       CustomData_free(&unode->bm_enter_pdata, unode->bm_enter_totpoly);
+       }
+}
+
+static bool sculpt_undo_cleanup(bContext *C, ListBase *lb)
+{
+       Object *ob = CTX_data_active_object(C);
+       SculptUndoNode *unode;
+
+       unode = lb->first;
+
+       if (unode && strcmp(unode->idname, ob->id.name) != 0) {
+               if (unode->bm_entry)
+                       BM_log_cleanup_entry(unode->bm_entry);
+
+               return true;
        }
+
+       return false;
 }
 
 SculptUndoNode *sculpt_undo_get_node(PBVHNode *node)
@@ -405,15 +575,15 @@ static void sculpt_undo_alloc_and_store_hidden(PBVH *pbvh,
                                                SculptUndoNode *unode)
 {
        PBVHNode *node = unode->node;
-       BLI_bitmap *grid_hidden;
+       BLI_bitmap **grid_hidden;
        int i, *grid_indices, totgrid;
 
-       grid_hidden = BLI_pbvh_grid_hidden(pbvh);
+       grid_hidden = BKE_pbvh_grid_hidden(pbvh);
 
-       BLI_pbvh_node_get_grids(pbvh, node, &grid_indices, &totgrid,
+       BKE_pbvh_node_get_grids(pbvh, node, &grid_indices, &totgrid,
                                NULL, NULL, NULL, NULL);
                        
-       unode->grid_hidden = MEM_mapallocN(sizeof(BLI_bitmap) * totgrid,
+       unode->grid_hidden = MEM_mapallocN(sizeof(*unode->grid_hidden) * totgrid,
                                           "unode->grid_hidden");
                
        for (i = 0; i < totgrid; i++) {
@@ -437,11 +607,15 @@ static SculptUndoNode *sculpt_undo_alloc_node(Object *ob, PBVHNode *node,
        unode->type = type;
        unode->node = node;
 
-       BLI_pbvh_node_num_verts(ss->pbvh, node, &totvert, &allvert);
-       BLI_pbvh_node_get_grids(ss->pbvh, node, &grids, &totgrid,
-                               &maxgrid, &gridsize, NULL, NULL);
+       if (node) {
+               BKE_pbvh_node_num_verts(ss->pbvh, node, &totvert, &allvert);
+               BKE_pbvh_node_get_grids(ss->pbvh, node, &grids, &totgrid,
+                                       &maxgrid, &gridsize, NULL, NULL);
 
-       unode->totvert = totvert;
+               unode->totvert = totvert;
+       }
+       else
+               maxgrid = 0;
        
        /* we will use this while sculpting, is mapalloc slow to access then? */
 
@@ -466,6 +640,11 @@ static SculptUndoNode *sculpt_undo_alloc_node(Object *ob, PBVHNode *node,
                        unode->mask = MEM_mapallocN(sizeof(float) * allvert, "SculptUndoNode.mask");
                        undo_paint_push_count_alloc(UNDO_PAINT_MESH, (sizeof(float) * sizeof(int)) * allvert);
                        break;
+               case SCULPT_UNDO_DYNTOPO_BEGIN:
+               case SCULPT_UNDO_DYNTOPO_END:
+               case SCULPT_UNDO_DYNTOPO_SYMMETRIZE:
+                       BLI_assert(!"Dynamic topology should've already been handled");
+                       break;
        }
        
        BLI_addtail(lb, unode);
@@ -494,7 +673,7 @@ static void sculpt_undo_store_coords(Object *ob, SculptUndoNode *unode)
        SculptSession *ss = ob->sculpt;
        PBVHVertexIter vd;
 
-       BLI_pbvh_vertex_iter_begin(ss->pbvh, unode->node, vd, PBVH_ITER_ALL)
+       BKE_pbvh_vertex_iter_begin(ss->pbvh, unode->node, vd, PBVH_ITER_ALL)
        {
                copy_v3_v3(unode->co[vd.i], vd.co);
                if (vd.no) copy_v3_v3_short(unode->no[vd.i], vd.no);
@@ -503,7 +682,7 @@ static void sculpt_undo_store_coords(Object *ob, SculptUndoNode *unode)
                if (ss->modifiers_active)
                        copy_v3_v3(unode->orig_co[vd.i], ss->orig_cos[unode->index[vd.i]]);
        }
-       BLI_pbvh_vertex_iter_end;
+       BKE_pbvh_vertex_iter_end;
 }
 
 static void sculpt_undo_store_hidden(Object *ob, SculptUndoNode *unode)
@@ -519,10 +698,10 @@ static void sculpt_undo_store_hidden(Object *ob, SculptUndoNode *unode)
                int *vert_indices, allvert;
                int i;
                
-               BLI_pbvh_node_num_verts(pbvh, node, NULL, &allvert);
-               BLI_pbvh_node_get_verts(pbvh, node, &vert_indices, &mvert);
+               BKE_pbvh_node_num_verts(pbvh, node, NULL, &allvert);
+               BKE_pbvh_node_get_verts(pbvh, node, &vert_indices, &mvert);
                for (i = 0; i < allvert; i++) {
-                       BLI_BITMAP_MODIFY(unode->vert_hidden, i,
+                       BLI_BITMAP_SET(unode->vert_hidden, i,
                                          mvert[vert_indices[i]].flag & ME_HIDE);
                }
        }
@@ -533,11 +712,100 @@ static void sculpt_undo_store_mask(Object *ob, SculptUndoNode *unode)
        SculptSession *ss = ob->sculpt;
        PBVHVertexIter vd;
 
-       BLI_pbvh_vertex_iter_begin(ss->pbvh, unode->node, vd, PBVH_ITER_ALL)
+       BKE_pbvh_vertex_iter_begin(ss->pbvh, unode->node, vd, PBVH_ITER_ALL)
        {
                unode->mask[vd.i] = *vd.mask;
        }
-       BLI_pbvh_vertex_iter_end;
+       BKE_pbvh_vertex_iter_end;
+}
+
+static SculptUndoNode *sculpt_undo_bmesh_push(Object *ob,
+                                              PBVHNode *node,
+                                              SculptUndoType type)
+{
+       ListBase *lb = undo_paint_push_get_list(UNDO_PAINT_MESH);
+       SculptUndoNode *unode = lb->first;
+       SculptSession *ss = ob->sculpt;
+       PBVHVertexIter vd;
+
+       if (!lb->first) {
+               unode = MEM_callocN(sizeof(*unode), __func__);
+
+               BLI_strncpy(unode->idname, ob->id.name, sizeof(unode->idname));
+               unode->type = type;
+               unode->applied = true;
+
+               if (type == SCULPT_UNDO_DYNTOPO_END) {
+                       unode->bm_entry = BM_log_entry_add(ss->bm_log);
+                       BM_log_before_all_removed(ss->bm, ss->bm_log);
+               }
+               else if (type == SCULPT_UNDO_DYNTOPO_BEGIN) {
+                       Mesh *me = ob->data;
+
+                       /* Store a copy of the mesh's current vertices, loops, and
+                        * polys. A full copy like this is needed because entering
+                        * dynamic-topology immediately does topological edits
+                        * (converting polys to triangles) that the BMLog can't
+                        * fully restore from */
+                       CustomData_copy(&me->vdata, &unode->bm_enter_vdata, CD_MASK_MESH,
+                                       CD_DUPLICATE, me->totvert);
+                       CustomData_copy(&me->edata, &unode->bm_enter_edata, CD_MASK_MESH,
+                                       CD_DUPLICATE, me->totedge);
+                       CustomData_copy(&me->ldata, &unode->bm_enter_ldata, CD_MASK_MESH,
+                                       CD_DUPLICATE, me->totloop);
+                       CustomData_copy(&me->pdata, &unode->bm_enter_pdata, CD_MASK_MESH,
+                                       CD_DUPLICATE, me->totpoly);
+                       unode->bm_enter_totvert = me->totvert;
+                       unode->bm_enter_totedge = me->totedge;
+                       unode->bm_enter_totloop = me->totloop;
+                       unode->bm_enter_totpoly = me->totpoly;
+
+                       unode->bm_entry = BM_log_entry_add(ss->bm_log);
+                       BM_log_all_added(ss->bm, ss->bm_log);
+               }
+               else {
+                       unode->bm_entry = BM_log_entry_add(ss->bm_log);
+               }
+
+               BLI_addtail(lb, unode);
+       }
+
+       if (node) {
+               switch (type) {
+                       case SCULPT_UNDO_COORDS:
+                       case SCULPT_UNDO_MASK:
+                               /* Before any vertex values get modified, ensure their
+                                * original positions are logged */
+                               BKE_pbvh_vertex_iter_begin(ss->pbvh, node, vd, PBVH_ITER_ALL) {
+                                       BM_log_vert_before_modified(ss->bm_log, vd.bm_vert, vd.cd_vert_mask_offset);
+                               }
+                               BKE_pbvh_vertex_iter_end;
+                               break;
+
+                       case SCULPT_UNDO_HIDDEN:
+                       {
+                               GSetIterator gs_iter;
+                               GSet *faces = BKE_pbvh_bmesh_node_faces(node);
+                               BKE_pbvh_vertex_iter_begin(ss->pbvh, node, vd, PBVH_ITER_ALL) {
+                                       BM_log_vert_before_modified(ss->bm_log, vd.bm_vert, vd.cd_vert_mask_offset);
+                               }
+                               BKE_pbvh_vertex_iter_end;
+
+                               GSET_ITER (gs_iter, faces) {
+                                       BMFace *f = BLI_gsetIterator_getKey(&gs_iter);
+                                       BM_log_face_modified(ss->bm_log, f);
+                               }
+                               break;
+                       }
+
+                       case SCULPT_UNDO_DYNTOPO_BEGIN:
+                       case SCULPT_UNDO_DYNTOPO_END:
+                       case SCULPT_UNDO_DYNTOPO_SYMMETRIZE:
+                               break;
+               }
+       }
+
+       return unode;
 }
 
 SculptUndoNode *sculpt_undo_push_node(Object *ob, PBVHNode *node,
@@ -549,7 +817,18 @@ SculptUndoNode *sculpt_undo_push_node(Object *ob, PBVHNode *node,
        /* list is manipulated by multiple threads, so we lock */
        BLI_lock_thread(LOCK_CUSTOM1);
 
-       if ((unode = sculpt_undo_get_node(node))) {
+       if (ss->bm ||
+           ELEM(type,
+                SCULPT_UNDO_DYNTOPO_BEGIN,
+                SCULPT_UNDO_DYNTOPO_END))
+       {
+               /* Dynamic topology stores only one undo node per stroke,
+                * regardless of the number of PBVH nodes modified */
+               unode = sculpt_undo_bmesh_push(ob, node, type);
+               BLI_unlock_thread(LOCK_CUSTOM1);
+               return unode;
+       }
+       else if ((unode = sculpt_undo_get_node(node))) {
                BLI_unlock_thread(LOCK_CUSTOM1);
                return unode;
        }
@@ -562,14 +841,14 @@ SculptUndoNode *sculpt_undo_push_node(Object *ob, PBVHNode *node,
 
        if (unode->grids) {
                int totgrid, *grids;
-               BLI_pbvh_node_get_grids(ss->pbvh, node, &grids, &totgrid,
+               BKE_pbvh_node_get_grids(ss->pbvh, node, &grids, &totgrid,
                                        NULL, NULL, NULL, NULL);
                memcpy(unode->grids, grids, sizeof(int) * totgrid);
        }
        else {
                int *vert_indices, allvert;
-               BLI_pbvh_node_num_verts(ss->pbvh, node, NULL, &allvert);
-               BLI_pbvh_node_get_verts(ss->pbvh, node, &vert_indices, NULL);
+               BKE_pbvh_node_num_verts(ss->pbvh, node, NULL, &allvert);
+               BKE_pbvh_node_get_verts(ss->pbvh, node, &vert_indices, NULL);
                memcpy(unode->index, vert_indices, sizeof(int) * unode->totvert);
        }
 
@@ -583,6 +862,11 @@ SculptUndoNode *sculpt_undo_push_node(Object *ob, PBVHNode *node,
                case SCULPT_UNDO_MASK:
                        sculpt_undo_store_mask(ob, unode);
                        break;
+               case SCULPT_UNDO_DYNTOPO_BEGIN:
+               case SCULPT_UNDO_DYNTOPO_END:
+               case SCULPT_UNDO_DYNTOPO_SYMMETRIZE:
+                       BLI_assert(!"Dynamic topology should've already been handled");
+                       break;
        }
 
        /* store active shape key */
@@ -594,8 +878,8 @@ SculptUndoNode *sculpt_undo_push_node(Object *ob, PBVHNode *node,
 
 void sculpt_undo_push_begin(const char *name)
 {
-       undo_paint_push_begin(UNDO_PAINT_MESH, name,
-                             sculpt_undo_restore, sculpt_undo_free);
+       ED_undo_paint_push_begin(UNDO_PAINT_MESH, name,
+                                sculpt_undo_restore, sculpt_undo_free, sculpt_undo_cleanup);
 }
 
 void sculpt_undo_push_end(void)
@@ -611,8 +895,8 @@ void sculpt_undo_push_end(void)
                }
 
                if (unode->node)
-                       BLI_pbvh_node_layer_disp_free(unode->node);
+                       BKE_pbvh_node_layer_disp_free(unode->node);
        }
 
-       undo_paint_push_end(UNDO_PAINT_MESH);
+       ED_undo_paint_push_end(UNDO_PAINT_MESH);
 }