Patch #34632: DPX/Cineon speed up
authorSergey Sharybin <sergey.vfx@gmail.com>
Fri, 15 Mar 2013 09:46:37 +0000 (09:46 +0000)
committerSergey Sharybin <sergey.vfx@gmail.com>
Fri, 15 Mar 2013 09:46:37 +0000 (09:46 +0000)
commit1ea16dcf9b5337a7f8983a09d7f92b6164a7670f
tree1e22b1bad4d657cb9d315ed51332b9366eb318b5
parent42660a204a553b331a7d99d4f49987c46707fa2c
Patch #34632: DPX/Cineon speed up

Done by Julien Enche (aka trap), thanks!

From the patch comment:
This patch speeds up Cineon/DPX file loading.
Some more checks are done in dpxOpen and cineonOpen functions so IB_test
flag can now be taken into account safely, and an unnecessary call to
IMB_rect_from_float has been removed.

DPX/Cineon file now loads around 3 times faster on my computer.

Own comment:
Ideally, IB_rect shall indeed indicate which buffers to load, however
currently all places which reads image uses this flag.

This fact already mentioned in OpenEXR reader and it shall be fine
to skip doing rect_from_float in readers themselves.
source/blender/imbuf/intern/cineon/cineon_dpx.c
source/blender/imbuf/intern/cineon/cineonlib.c
source/blender/imbuf/intern/cineon/dpxlib.c