Removed the "Show Cyclic Dependencies" operator for nodes. This operator is an old...
authorLukas Toenne <lukas.toenne@googlemail.com>
Wed, 6 Nov 2013 18:56:51 +0000 (18:56 +0000)
committerLukas Toenne <lukas.toenne@googlemail.com>
Wed, 6 Nov 2013 18:56:51 +0000 (18:56 +0000)
called the generic node tree update function, which is happening anyway after all relevant node operators (if it doesn't that has to be considered a bug).

It has been suggested to better use the C key for circle select, this remains to be discussed.

release/scripts/startup/bl_ui/space_node.py
source/blender/editors/space_node/node_intern.h
source/blender/editors/space_node/node_ops.c
source/blender/editors/space_node/node_relationships.c

index b9aa3feb60767609ed46a66bbc410a33339a806d..f9e322565663a67df5f525d429236ccbe87fe61a 100644 (file)
@@ -233,7 +233,6 @@ class NODE_MT_node(Menu):
 
         layout.separator()
 
-        layout.operator("node.show_cyclic_dependencies")
         layout.operator("node.read_renderlayers")
         layout.operator("node.read_fullsamplelayers")
 
index 176b81f950370fc871c228ce8c50e2e589ba583a..5e244b862f642f69aa0c0af007efeaeb84d08568 100644 (file)
@@ -169,7 +169,6 @@ void NODE_OT_join(struct wmOperatorType *ot);
 void NODE_OT_attach(struct wmOperatorType *ot);
 void NODE_OT_detach(struct wmOperatorType *ot);
 
-void NODE_OT_show_cyclic_dependencies(struct wmOperatorType *ot);
 void NODE_OT_link_viewer(struct wmOperatorType *ot);
 
 /* node_edit.c */
index f0d3deb24dfd12f0cf602cdae557fb69e6472a97..1d631d5c9e534bb29598bb5db961ba2eb04ae28c 100644 (file)
@@ -70,7 +70,6 @@ void node_operatortypes(void)
        WM_operatortype_append(NODE_OT_preview_toggle);
        WM_operatortype_append(NODE_OT_options_toggle);
        WM_operatortype_append(NODE_OT_hide_socket_toggle);
-       WM_operatortype_append(NODE_OT_show_cyclic_dependencies);
        WM_operatortype_append(NODE_OT_node_copy_color);
        
        WM_operatortype_append(NODE_OT_duplicate);
@@ -272,8 +271,6 @@ void node_keymap(struct wmKeyConfig *keyconf)
        WM_keymap_add_item(keymap, "NODE_OT_preview_toggle", HKEY, KM_PRESS, KM_SHIFT, 0);
        WM_keymap_add_item(keymap, "NODE_OT_hide_socket_toggle", HKEY, KM_PRESS, KM_CTRL, 0);
        
-       WM_keymap_add_item(keymap, "NODE_OT_show_cyclic_dependencies", CKEY, KM_PRESS, 0, 0);
-       
        WM_keymap_add_item(keymap, "NODE_OT_view_all", HOMEKEY, KM_PRESS, 0, 0);
        WM_keymap_add_item(keymap, "NODE_OT_view_selected", PADPERIOD, KM_PRESS, 0, 0);
 
index 8c4050766afc16af2e5e01529e83631c4ec28ddf..a8c619a15fbd3bdd08f9c5f46b594a27d05cc474 100644 (file)
@@ -876,34 +876,6 @@ void NODE_OT_links_detach(wmOperatorType *ot)
 }
 
 
-/* ****************** Show Cyclic Dependencies Operator  ******************* */
-
-static int node_show_cycles_exec(bContext *C, wmOperator *UNUSED(op))
-{
-       SpaceNode *snode = CTX_wm_space_node(C);
-
-       /* this is just a wrapper around this call... */
-       ntreeUpdateTree(CTX_data_main(C), snode->nodetree);
-       snode_notify(C, snode);
-
-       return OPERATOR_FINISHED;
-}
-
-void NODE_OT_show_cyclic_dependencies(wmOperatorType *ot)
-{
-       /* identifiers */
-       ot->name = "Show Cyclic Dependencies";
-       ot->description = "Sort the nodes and show the cyclic dependencies between the nodes";
-       ot->idname = "NODE_OT_show_cyclic_dependencies";
-
-       /* callbacks */
-       ot->exec = node_show_cycles_exec;
-       ot->poll = ED_operator_node_active;
-
-       /* flags */
-       ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
-}
-
 /* ****************** Set Parent ******************* */
 
 static int node_parent_set_exec(bContext *C, wmOperator *UNUSED(op))