Cleanup: Python context access
authorCampbell Barton <ideasman42@gmail.com>
Wed, 7 Feb 2018 04:47:54 +0000 (15:47 +1100)
committerCampbell Barton <ideasman42@gmail.com>
Wed, 7 Feb 2018 04:47:54 +0000 (15:47 +1100)
Avoid access from bpy when it's already declared.

release/scripts/startup/bl_operators/freestyle.py
release/scripts/startup/bl_operators/object_align.py
release/scripts/startup/bl_operators/wm.py
release/scripts/startup/bl_ui/properties_data_modifier.py
release/scripts/startup/bl_ui/space_time.py

index 2e46160aeeb0eaeb43208fbbe452b4cad328a8dc..f5da7d45256b88073695927493ee664b6a274191 100644 (file)
@@ -78,10 +78,10 @@ class SCENE_OT_freestyle_fill_range_by_selection(bpy.types.Operator):
             self.report({'ERROR'}, "Unexpected modifier type: " + m.type)
             return {'CANCELLED'}
         # Find selected vertices in editmesh
-        ob = bpy.context.active_object
+        ob = context.active_object
         if ob.type == 'MESH' and ob.mode == 'EDIT' and ob.name != ref.name:
             bpy.ops.object.mode_set(mode='OBJECT')
-            selected_verts = [v for v in bpy.context.active_object.data.vertices if v.select]
+            selected_verts = [v for v in ob.data.vertices if v.select]
             bpy.ops.object.mode_set(mode='EDIT')
             # Compute the min/max distance from the reference to mesh vertices
             min_dist = sys.float_info.max
index a4e601dc7d1b2c529406967fa2d7203be29ff737..8669c2ddbd6e047d59e270cc515ce711249d3600 100644 (file)
@@ -66,13 +66,13 @@ def GlobalBB_LQ(bb_world):
     return (Vector((left, front, up)), Vector((right, back, down)))
 
 
-def GlobalBB_HQ(obj):
+def GlobalBB_HQ(scene, obj):
 
     matrix_world = obj.matrix_world.copy()
 
     # Initialize the variables with the last vertex
 
-    me = obj.to_mesh(scene=bpy.context.scene, apply_modifiers=True, settings='PREVIEW')
+    me = obj.to_mesh(scene=scene, apply_modifiers=True, settings='PREVIEW')
     verts = me.vertices
 
     val = matrix_world * verts[-1].co
@@ -155,7 +155,7 @@ def align_objects(context,
     for obj, bb_world in objects:
 
         if bb_quality and obj.type == 'MESH':
-            GBB = GlobalBB_HQ(obj)
+            GBB = GlobalBB_HQ(scene, obj)
         else:
             GBB = GlobalBB_LQ(bb_world)
 
@@ -219,7 +219,7 @@ def align_objects(context,
         bb_world = [matrix_world * Vector(v[:]) for v in obj.bound_box]
 
         if bb_quality and obj.type == 'MESH':
-            GBB = GlobalBB_HQ(obj)
+            GBB = GlobalBB_HQ(scene, obj)
         else:
             GBB = GlobalBB_LQ(bb_world)
 
index cf07152d9797fb9dd1646cb1ad564d796a3d9945..022ee1576d80de22dabef22da4a9d4a09d27944b 100644 (file)
@@ -2223,7 +2223,7 @@ class WM_OT_addon_userpref_show(Operator):
             info = addon_utils.module_bl_info(mod)
             info["show_expanded"] = True
 
-            bpy.context.user_preferences.active_section = 'ADDONS'
+            context.user_preferences.active_section = 'ADDONS'
             context.window_manager.addon_filter = 'All'
             context.window_manager.addon_search = info["name"]
             bpy.ops.screen.userpref_show('INVOKE_DEFAULT')
index 9cd3b7435579d5b80f40c1e83758add04521b3fe..3b62d37181ad03a0cec662fd1e8651c18df60267 100644 (file)
@@ -938,12 +938,13 @@ class DATA_PT_modifiers(ModifierButtonsPanel, Panel):
         row.prop(md, "material_offset_rim", text="Rim")
 
     def SUBSURF(self, layout, ob, md):
+        from bpy import context
         layout.row().prop(md, "subdivision_type", expand=True)
 
         split = layout.split()
         col = split.column()
 
-        scene = bpy.context.scene
+        scene = context.scene
         engine = scene.render.engine
         show_adaptive_options = (
             engine == 'CYCLES' and md == ob.modifiers[-1] and
index 9930992e9bb60df0d1db4db5a2e4f3121f8a50e9..d1202adfce6fe4f5c578ddcaa0c546b9b3df1a66 100644 (file)
@@ -119,7 +119,7 @@ class TIME_MT_marker(Menu):
     def draw(self, context):
         layout = self.layout
 
-        marker_menu_generic(layout)
+        marker_menu_generic(layout, context)
 
 
 class TIME_MT_view(Menu):
@@ -239,6 +239,7 @@ class TIME_MT_autokey(Menu):
 
 
 def marker_menu_generic(layout):
+    from bpy import context
 
     # layout.operator_context = 'EXEC_REGION_WIN'
 
@@ -265,7 +266,7 @@ def marker_menu_generic(layout):
     layout.operator("screen.marker_jump", text="Jump to Previous Marker").next = False
 
     layout.separator()
-    ts = bpy.context.tool_settings
+    ts = context.tool_settings
     layout.prop(ts, "lock_markers")