Armature Ghosting Bugfix:
authorJoshua Leung <aligorith@gmail.com>
Tue, 13 Oct 2009 12:09:11 +0000 (12:09 +0000)
committerJoshua Leung <aligorith@gmail.com>
Tue, 13 Oct 2009 12:09:11 +0000 (12:09 +0000)
I noticed that armature drawing seemed to be using the wrong colours for ghosting in some situations (in particular, Cessen's biped rig for 2.5). Commented out what appears to be the offending code for now.

Not totally sure why this broke yet, but as possible bonus of this, we sometimes get coloured ghosted controls (if bone groups were in use).

source/blender/editors/space_view3d/drawarmature.c

index 028d666dc71955901452fe02249979affb52485d..26135cd8d31741f423c24814028f7c343dcc71ba 100644 (file)
@@ -1654,6 +1654,7 @@ static void draw_pose_channels(Scene *scene, View3D *v3d, ARegion *ar, Base *bas
                                                        /* prepare colors */
                                                        if (arm->flag & ARM_POSEMODE)   
                                                                set_pchan_colorset(ob, pchan);
+#if 0 // XXX - 13 October 2009, Disabled this to make ghosting show the right colors (Aligorith)
                                                        else {
                                                                if ((scene->basact)==base) {
                                                                        if (base->flag & (SELECT+BA_WAS_SEL)) UI_ThemeColor(TH_ACTIVE);
@@ -1664,6 +1665,7 @@ static void draw_pose_channels(Scene *scene, View3D *v3d, ARegion *ar, Base *bas
                                                                        else UI_ThemeColor(TH_WIRE);
                                                                }
                                                        }
+#endif
                                                                
                                                        /* catch exception for bone with hidden parent */
                                                        flag= bone->flag;
@@ -1755,7 +1757,7 @@ static void draw_pose_channels(Scene *scene, View3D *v3d, ARegion *ar, Base *bas
                                        
                                        /* extra draw service for pose mode */
                                        constflag= pchan->constflag;
-                                       if (pchan->flag & (POSE_ROT|POSE_LOC|POSE_SIZE))        // XXX this is useless crap
+                                       if (pchan->flag & (POSE_ROT|POSE_LOC|POSE_SIZE))
                                                constflag |= PCHAN_HAS_ACTION;
                                        if (pchan->flag & POSE_STRIDE)
                                                constflag |= PCHAN_HAS_STRIDE;