[#17850] Copying text from Eric4 to Blender crashes Blender
authorCampbell Barton <ideasman42@gmail.com>
Tue, 27 Jan 2009 08:17:35 +0000 (08:17 +0000)
committerCampbell Barton <ideasman42@gmail.com>
Tue, 27 Jan 2009 08:17:35 +0000 (08:17 +0000)
The crash is caused by calling XGetWindowProperty when xevent.xselection.property is zero.
Not a proper fix because clipboard can paste the data without trouble.

intern/ghost/intern/GHOST_SystemX11.cpp

index 8073756e453221a23c55d25b9ca07c7f86a770c1..9950ef8887976806be71ef5c9c0ff595be064143 100644 (file)
@@ -1031,15 +1031,20 @@ getClipboard(int flag
        //This needs to change so we do not wait for ever or check owner first
        while(1) {
                XNextEvent(m_display, &xevent);
-               if(xevent.type == SelectionNotify) {
-                       if(XGetWindowProperty(m_display, m_window, xevent.xselection.property, 0L, 4096L, False, AnyPropertyType, &rtype, &bits, &len, &bytes, &data) == Success) {
-                               if (data) {
-                                       tmp_data = (unsigned char*) malloc(strlen((char*)data)+1);
-                                       strcpy((char*)tmp_data, (char*)data);
-                                       XFree(data);
-                                       return (GHOST_TUns8*)tmp_data;
+               if(xevent.type == SelectionNotify) { 
+                       if (xevent.xselection.property ) { /* eric4 on linux gives zero Atom xevent.xselection.property value, closes blender instantly */
+                               if(XGetWindowProperty(m_display, m_window, xevent.xselection.property , 0L, 4096L, False, AnyPropertyType, &rtype, &bits, &len, &bytes, &data) == Success) {
+                                       if (data) {
+                                               tmp_data = (unsigned char*) malloc(strlen((char*)data)+1);
+                                               strcpy((char*)tmp_data, (char*)data);
+                                               XFree(data);
+                                               return (GHOST_TUns8*)tmp_data;
+                                       }
                                }
                        }
+                       else {
+                               fprintf(stderr, "error: cut buffer had a zero xevent.xselection.property, FIXME\n"); // XXX fix this problem!
+                       }
                        return NULL;
                }
        }