Fix T49617: Grease Pencil Stroke Placement regression
[blender.git] / source / blender / editors / gpencil / gpencil_paint.c
1 /*
2  * ***** BEGIN GPL LICENSE BLOCK *****
3  *
4  * This program is free software; you can redistribute it and/or
5  * modify it under the terms of the GNU General Public License
6  * as published by the Free Software Foundation; either version 2
7  * of the License, or (at your option) any later version.
8  *
9  * This program is distributed in the hope that it will be useful,
10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12  * GNU General Public License for more details.
13  *
14  * You should have received a copy of the GNU General Public License
15  * along with this program; if not, write to the Free Software Foundation,
16  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17  *
18  * The Original Code is Copyright (C) 2008, Blender Foundation, Joshua Leung
19  * This is a new part of Blender
20  *
21  * Contributor(s): Joshua Leung, Antonio Vazquez
22  *
23  * ***** END GPL LICENSE BLOCK *****
24  */
25
26 /** \file blender/editors/gpencil/gpencil_paint.c
27  *  \ingroup edgpencil
28  */
29
30
31 #include <stdio.h>
32 #include <stddef.h>
33 #include <stdlib.h>
34 #include <string.h>
35 #include <math.h>
36
37 #include "MEM_guardedalloc.h"
38
39 #include "BLI_blenlib.h"
40 #include "BLI_math.h"
41 #include "BLI_utildefines.h"
42 #include "BLI_rand.h"
43 #include "BLI_math_geom.h"
44
45 #include "BLT_translation.h"
46
47 #include "PIL_time.h"
48
49 #include "BKE_main.h"
50 #include "BKE_paint.h"
51 #include "BKE_gpencil.h"
52 #include "BKE_context.h"
53 #include "BKE_global.h"
54 #include "BKE_report.h"
55 #include "BKE_screen.h"
56 #include "BKE_tracking.h"
57 #include "BKE_colortools.h"
58
59 #include "DNA_object_types.h"
60 #include "DNA_scene_types.h"
61 #include "DNA_gpencil_types.h"
62 #include "DNA_brush_types.h"
63 #include "DNA_windowmanager_types.h"
64
65 #include "UI_view2d.h"
66
67 #include "ED_gpencil.h"
68 #include "ED_screen.h"
69 #include "ED_view3d.h"
70 #include "ED_clip.h"
71
72 #include "BIF_gl.h"
73 #include "BIF_glutil.h"
74
75 #include "RNA_access.h"
76 #include "RNA_define.h"
77
78 #include "WM_api.h"
79 #include "WM_types.h"
80
81 #include "gpencil_intern.h"
82
83 /* ******************************************* */
84 /* 'Globals' and Defines */
85
86 /* values for tGPsdata->status */
87 typedef enum eGPencil_PaintStatus {
88         GP_STATUS_IDLING = 0,   /* stroke isn't in progress yet */
89         GP_STATUS_PAINTING,     /* a stroke is in progress */
90         GP_STATUS_ERROR,        /* something wasn't correctly set up */
91         GP_STATUS_DONE          /* painting done */
92 } eGPencil_PaintStatus;
93
94 /* Return flags for adding points to stroke buffer */
95 typedef enum eGP_StrokeAdd_Result {
96         GP_STROKEADD_INVALID    = -2,       /* error occurred - insufficient info to do so */
97         GP_STROKEADD_OVERFLOW   = -1,       /* error occurred - cannot fit any more points */
98         GP_STROKEADD_NORMAL,                /* point was successfully added */
99         GP_STROKEADD_FULL                   /* cannot add any more points to buffer */
100 } eGP_StrokeAdd_Result;
101
102 /* Runtime flags */
103 typedef enum eGPencil_PaintFlags {
104         GP_PAINTFLAG_FIRSTRUN       = (1 << 0),    /* operator just started */
105         GP_PAINTFLAG_STROKEADDED    = (1 << 1),
106         GP_PAINTFLAG_V3D_ERASER_DEPTH = (1 << 2),
107         GP_PAINTFLAG_SELECTMASK     = (1 << 3),
108 } eGPencil_PaintFlags;
109
110
111 /* Temporary 'Stroke' Operation data
112  *   "p" = op->customdata
113  */
114 typedef struct tGPsdata {
115         Scene *scene;       /* current scene from context */
116         
117         wmWindow *win;      /* window where painting originated */
118         ScrArea *sa;        /* area where painting originated */
119         ARegion *ar;        /* region where painting originated */
120         View2D *v2d;        /* needed for GP_STROKE_2DSPACE */
121         rctf *subrect;      /* for using the camera rect within the 3d view */
122         rctf subrect_data;
123         
124         GP_SpaceConversion gsc; /* settings to pass to gp_points_to_xy() */
125         
126         PointerRNA ownerPtr; /* pointer to owner of gp-datablock */
127         bGPdata *gpd;       /* gp-datablock layer comes from */
128         bGPDlayer *gpl;     /* layer we're working on */
129         bGPDframe *gpf;     /* frame we're working on */
130         
131         char *align_flag;   /* projection-mode flags (toolsettings - eGPencil_Placement_Flags) */
132         
133         eGPencil_PaintStatus status;     /* current status of painting */
134         eGPencil_PaintModes  paintmode;  /* mode for painting */
135         eGPencil_PaintFlags  flags;      /* flags that can get set during runtime (eGPencil_PaintFlags) */
136         
137         short radius;       /* radius of influence for eraser */
138         
139         int mval[2];        /* current mouse-position */
140         int mvalo[2];       /* previous recorded mouse-position */
141         
142         float pressure;     /* current stylus pressure */
143         float opressure;    /* previous stylus pressure */
144         
145         /* These need to be doubles, as (at least under unix) they are in seconds since epoch,
146          * float (and its 7 digits precision) is definitively not enough here!
147          * double, with its 15 digits precision, ensures us millisecond precision for a few centuries at least.
148          */
149         double inittime;    /* Used when converting to path */
150         double curtime;     /* Used when converting to path */
151         double ocurtime;    /* Used when converting to path */
152         
153         float imat[4][4];   /* inverted transformation matrix applying when converting coords from screen-space
154                              * to region space */
155         float mat[4][4];
156         
157         float custom_color[4]; /* custom color - hack for enforcing a particular color for track/mask editing */
158         
159         void *erasercursor; /* radial cursor data for drawing eraser */
160
161         bGPDpalettecolor *palettecolor; /* current palette color */
162         bGPDbrush *brush; /* current drawing brush */
163         short straight[2];   /* 1: line horizontal, 2: line vertical, other: not defined, second element position */
164         int lock_axis;       /* lock drawing to one axis */
165 } tGPsdata;
166
167 /* ------ */
168
169 /* Macros for accessing sensitivity thresholds... */
170 /* minimum number of pixels mouse should move before new point created */
171 #define MIN_MANHATTEN_PX    (U.gp_manhattendist)
172 /* minimum length of new segment before new point can be added */
173 #define MIN_EUCLIDEAN_PX    (U.gp_euclideandist)
174
175 static bool gp_stroke_added_check(tGPsdata *p)
176 {
177         return (p->gpf && p->gpf->strokes.last && p->flags & GP_PAINTFLAG_STROKEADDED);
178 }
179
180 static void gp_stroke_added_enable(tGPsdata *p)
181 {
182         BLI_assert(p->gpf->strokes.last != NULL);
183         p->flags |= GP_PAINTFLAG_STROKEADDED;
184 }
185
186 /* ------ */
187 /* Forward defines for some functions... */
188
189 static void gp_session_validatebuffer(tGPsdata *p);
190
191 /* ******************************************* */
192 /* Context Wrangling... */
193
194 /* check if context is suitable for drawing */
195 static int gpencil_draw_poll(bContext *C)
196 {
197         if (ED_operator_regionactive(C)) {
198                 /* check if current context can support GPencil data */
199                 if (ED_gpencil_data_get_pointers(C, NULL) != NULL) {
200                         /* check if Grease Pencil isn't already running */
201                         if (ED_gpencil_session_active() == 0)
202                                 return 1;
203                         else
204                                 CTX_wm_operator_poll_msg_set(C, "Grease Pencil operator is already active");
205                 }
206                 else {
207                         CTX_wm_operator_poll_msg_set(C, "Failed to find Grease Pencil data to draw into");
208                 }
209         }
210         else {
211                 CTX_wm_operator_poll_msg_set(C, "Active region not set");
212         }
213         
214         return 0;
215 }
216
217 /* check if projecting strokes into 3d-geometry in the 3D-View */
218 static bool gpencil_project_check(tGPsdata *p)
219 {
220         bGPdata *gpd = p->gpd;
221         return ((gpd->sbuffer_sflag & GP_STROKE_3DSPACE) && (*p->align_flag & (GP_PROJECT_DEPTH_VIEW | GP_PROJECT_DEPTH_STROKE)));
222 }
223
224 /* ******************************************* */
225 /* Calculations/Conversions */
226
227 /* Utilities --------------------------------- */
228
229 /* get the reference point for stroke-point conversions */
230 static void gp_get_3d_reference(tGPsdata *p, float vec[3])
231 {
232         View3D *v3d = p->sa->spacedata.first;
233         const float *fp = ED_view3d_cursor3d_get(p->scene, v3d);
234         
235         /* the reference point used depends on the owner... */
236 #if 0 /* XXX: disabled for now, since we can't draw relative to the owner yet */
237         if (p->ownerPtr.type == &RNA_Object) {
238                 Object *ob = (Object *)p->ownerPtr.data;
239                 
240                 /* active Object
241                  *  - use relative distance of 3D-cursor from object center
242                  */
243                 sub_v3_v3v3(vec, fp, ob->loc);
244         }
245         else
246 #endif
247         {
248                 /* use 3D-cursor */
249                 copy_v3_v3(vec, fp);
250         }
251 }
252
253 /* Stroke Editing ---------------------------- */
254
255 /* check if the current mouse position is suitable for adding a new point */
256 static bool gp_stroke_filtermval(tGPsdata *p, const int mval[2], int pmval[2])
257 {
258         int dx = abs(mval[0] - pmval[0]);
259         int dy = abs(mval[1] - pmval[1]);
260         
261         /* if buffer is empty, just let this go through (i.e. so that dots will work) */
262         if (p->gpd->sbuffer_size == 0)
263                 return true;
264         
265         /* check if mouse moved at least certain distance on both axes (best case)
266          *      - aims to eliminate some jitter-noise from input when trying to draw straight lines freehand
267          */
268         else if ((dx > MIN_MANHATTEN_PX) && (dy > MIN_MANHATTEN_PX))
269                 return true;
270         
271         /* check if the distance since the last point is significant enough
272          *      - prevents points being added too densely
273          *      - distance here doesn't use sqrt to prevent slowness... we should still be safe from overflows though
274          */
275         else if ((dx * dx + dy * dy) > MIN_EUCLIDEAN_PX * MIN_EUCLIDEAN_PX)
276                 return true;
277         
278         /* mouse 'didn't move' */
279         else
280                 return false;
281 }
282
283 /* reproject the points of the stroke to a plane locked to axis to avoid stroke offset */
284 static void gp_project_points_to_plane(RegionView3D *rv3d, bGPDstroke *gps, const float origin[3], const int axis)
285 {
286         float plane_normal[3];
287         float vn[3];
288
289         float ray[3];
290         float rpoint[3];
291
292         /* normal vector for a plane locked to axis */
293         zero_v3(plane_normal);
294         plane_normal[axis] = 1.0f;
295
296         /* Reproject the points in the plane */
297         for (int i = 0; i < gps->totpoints; i++) {
298                 bGPDspoint *pt = &gps->points[i];
299
300                 /* get a vector from the point with the current view direction of the viewport */
301                 ED_view3d_global_to_vector(rv3d, &pt->x, vn);
302
303                 /* calculate line extrem point to create a ray that cross the plane */
304                 mul_v3_fl(vn, -50.0f);
305                 add_v3_v3v3(ray, &pt->x, vn);
306
307                 /* if the line never intersect, the point is not changed */
308                 if (isect_line_plane_v3(rpoint, &pt->x, ray, origin, plane_normal)) {
309                         copy_v3_v3(&pt->x, rpoint);
310                 }
311         }
312 }
313
314 /* reproject stroke to plane locked to axis in 3d cursor location */
315 static void gp_reproject_toplane(tGPsdata *p, bGPDstroke *gps)
316 {
317         bGPdata *gpd = p->gpd;
318         float origin[3];
319         float cursor[3];
320         RegionView3D *rv3d = p->ar->regiondata;
321
322         /* verify the stroke mode is CURSOR 3d space mode */
323         if ((gpd->sbuffer_sflag & GP_STROKE_3DSPACE) == 0) {
324                 return;
325         }
326         if ((*p->align_flag & GP_PROJECT_VIEWSPACE) == 0) {
327                 return;
328         }
329         if ((*p->align_flag & GP_PROJECT_DEPTH_VIEW) || (*p->align_flag & GP_PROJECT_DEPTH_STROKE)) {
330                 return;
331         }
332
333         /* get 3d cursor and set origin for locked axis only. Uses axis-1 because the enum for XYZ start with 1 */
334         gp_get_3d_reference(p, cursor);
335         zero_v3(origin);
336         origin[p->lock_axis - 1] = cursor[p->lock_axis - 1];
337
338         gp_project_points_to_plane(rv3d, gps, origin, p->lock_axis - 1);
339 }
340
341 /* convert screen-coordinates to buffer-coordinates */
342 /* XXX this method needs a total overhaul! */
343 static void gp_stroke_convertcoords(tGPsdata *p, const int mval[2], float out[3], float *depth)
344 {
345         bGPdata *gpd = p->gpd;
346         
347         /* in 3d-space - pt->x/y/z are 3 side-by-side floats */
348         if (gpd->sbuffer_sflag & GP_STROKE_3DSPACE) {
349                 if (gpencil_project_check(p) && (ED_view3d_autodist_simple(p->ar, mval, out, 0, depth))) {
350                         /* projecting onto 3D-Geometry
351                          *      - nothing more needs to be done here, since view_autodist_simple() has already done it
352                          */
353                 }
354                 else {
355                         float mval_prj[2];
356                         float rvec[3], dvec[3];
357                         float mval_f[2] = {UNPACK2(mval)};
358                         float zfac;
359                 
360                         /* Current method just converts each point in screen-coordinates to
361                          * 3D-coordinates using the 3D-cursor as reference. In general, this
362                          * works OK, but it could of course be improved.
363                          *
364                          * TODO:
365                          *      - investigate using nearest point(s) on a previous stroke as
366                          *        reference point instead or as offset, for easier stroke matching
367                          */
368                         
369                         gp_get_3d_reference(p, rvec);
370                         zfac = ED_view3d_calc_zfac(p->ar->regiondata, rvec, NULL);
371                         
372                         if (ED_view3d_project_float_global(p->ar, rvec, mval_prj, V3D_PROJ_TEST_NOP) == V3D_PROJ_RET_OK) {
373                                 sub_v2_v2v2(mval_f, mval_prj, mval_f);
374                                 ED_view3d_win_to_delta(p->ar, mval_f, dvec, zfac);
375                                 sub_v3_v3v3(out, rvec, dvec);
376                         }
377                         else {
378                                 zero_v3(out);
379                         }
380                 }
381         }
382         
383         /* 2d - on 'canvas' (assume that p->v2d is set) */
384         else if ((gpd->sbuffer_sflag & GP_STROKE_2DSPACE) && (p->v2d)) {
385                 UI_view2d_region_to_view(p->v2d, mval[0], mval[1], &out[0], &out[1]);
386                 mul_v3_m4v3(out, p->imat, out);
387         }
388         
389         /* 2d - relative to screen (viewport area) */
390         else {
391                 if (p->subrect == NULL) { /* normal 3D view */
392                         out[0] = (float)(mval[0]) / (float)(p->ar->winx) * 100;
393                         out[1] = (float)(mval[1]) / (float)(p->ar->winy) * 100;
394                 }
395                 else { /* camera view, use subrect */
396                         out[0] = ((mval[0] - p->subrect->xmin) / BLI_rctf_size_x(p->subrect)) * 100;
397                         out[1] = ((mval[1] - p->subrect->ymin) / BLI_rctf_size_y(p->subrect)) * 100;
398                 }
399         }
400 }
401
402 /* apply jitter to stroke */
403 static void gp_brush_jitter(bGPdata *gpd, bGPDbrush *brush, tGPspoint *pt, const int mval[2], int r_mval[2])
404 {
405         float pressure = pt->pressure;
406         float tmp_pressure = pt->pressure;
407         if (brush->draw_jitter > 0.0f) {
408                 float curvef = curvemapping_evaluateF(brush->cur_jitter, 0, pressure);
409                 tmp_pressure = curvef * brush->draw_sensitivity;
410         }
411         const float exfactor = (brush->draw_jitter + 2.0f) * (brush->draw_jitter + 2.0f); /* exponential value */
412         const float fac = BLI_frand() * exfactor * tmp_pressure;
413         /* Jitter is applied perpendicular to the mouse movement vector (2D space) */
414         float mvec[2], svec[2];
415         /* mouse movement in ints -> floats */
416         if (gpd->sbuffer_size > 1) {
417                 mvec[0] = (float)(mval[0] - (pt - 1)->x);
418                 mvec[1] = (float)(mval[1] - (pt - 1)->y);
419                 normalize_v2(mvec);
420         }
421         else {
422                 mvec[0] = 0.0f;
423                 mvec[1] = 0.0f;
424         }
425         /* rotate mvec by 90 degrees... */
426         svec[0] = -mvec[1];
427         svec[1] = mvec[0];
428         /* scale the displacement by the random, and apply */
429         if (BLI_frand() > 0.5f) {
430                 mul_v2_fl(svec, -fac);
431         }
432         else {
433                 mul_v2_fl(svec, fac);
434         }
435
436         r_mval[0] = mval[0] + svec[0];
437         r_mval[1] = mval[1] + svec[1];
438
439 }
440
441 /* apply pressure change depending of the angle of the stroke to simulate a pen with shape */
442 static void gp_brush_angle(bGPdata *gpd, bGPDbrush *brush, tGPspoint *pt, const int mval[2])
443 {
444         float mvec[2];
445         float sen = brush->draw_angle_factor; /* sensitivity */;
446         float fac;
447         float mpressure;
448
449         float angle = brush->draw_angle; /* default angle of brush in radians */;
450         float v0[2] = { cos(angle), sin(angle) }; /* angle vector of the brush with full thickness */
451
452         /* Apply to first point (only if there are 2 points because before no data to do it ) */
453         if (gpd->sbuffer_size == 1) {
454                 mvec[0] = (float)(mval[0] - (pt - 1)->x);
455                 mvec[1] = (float)(mval[1] - (pt - 1)->y);
456                 normalize_v2(mvec);
457
458                 /* uses > 1.0f to get a smooth transition in first point */
459                 fac = 1.4f - fabs(dot_v2v2(v0, mvec)); /* 0.0 to 1.0 */
460                 (pt - 1)->pressure = (pt - 1)->pressure - (sen * fac);
461
462                 CLAMP((pt - 1)->pressure, GPENCIL_ALPHA_OPACITY_THRESH, 1.0f);
463         }
464
465         /* apply from second point */
466         if (gpd->sbuffer_size >= 1) {
467                 mvec[0] = (float)(mval[0] - (pt - 1)->x);
468                 mvec[1] = (float)(mval[1] - (pt - 1)->y);
469                 normalize_v2(mvec);
470
471                 fac = 1.0f - fabs(dot_v2v2(v0, mvec)); /* 0.0 to 1.0 */
472                 /* interpolate with previous point for smoother transitions */
473                 mpressure = interpf(pt->pressure - (sen * fac), (pt - 1)->pressure, 0.3f);
474                 pt->pressure = mpressure; 
475
476                 CLAMP(pt->pressure, GPENCIL_ALPHA_OPACITY_THRESH, 1.0f);
477         }
478
479 }
480
481 /* add current stroke-point to buffer (returns whether point was successfully added) */
482 static short gp_stroke_addpoint(tGPsdata *p, const int mval[2], float pressure, double curtime)
483 {
484         bGPdata *gpd = p->gpd;
485         bGPDbrush *brush = p->brush;
486         tGPspoint *pt;
487         ToolSettings *ts = p->scene->toolsettings;
488
489         /* check painting mode */
490         if (p->paintmode == GP_PAINTMODE_DRAW_STRAIGHT) {
491                 /* straight lines only - i.e. only store start and end point in buffer */
492                 if (gpd->sbuffer_size == 0) {
493                         /* first point in buffer (start point) */
494                         pt = (tGPspoint *)(gpd->sbuffer);
495                         
496                         /* store settings */
497                         copy_v2_v2_int(&pt->x, mval);
498                         pt->pressure = 1.0f; /* T44932 - Pressure vals are unreliable, so ignore for now */
499                         pt->strength = 1.0f;
500                         pt->time = (float)(curtime - p->inittime);
501                         
502                         /* increment buffer size */
503                         gpd->sbuffer_size++;
504                 }
505                 else {
506                         /* just reset the endpoint to the latest value
507                          *      - assume that pointers for this are always valid...
508                          */
509                         pt = ((tGPspoint *)(gpd->sbuffer) + 1);
510                         
511                         /* store settings */
512                         copy_v2_v2_int(&pt->x, mval);
513                         pt->pressure = 1.0f; /* T44932 - Pressure vals are unreliable, so ignore for now */
514                         pt->strength = 1.0f;
515                         pt->time = (float)(curtime - p->inittime);
516                         
517                         /* now the buffer has 2 points (and shouldn't be allowed to get any larger) */
518                         gpd->sbuffer_size = 2;
519                 }
520                 
521                 /* can keep carrying on this way :) */
522                 return GP_STROKEADD_NORMAL;
523         }
524         else if (p->paintmode == GP_PAINTMODE_DRAW) { /* normal drawing */
525                 /* check if still room in buffer */
526                 if (gpd->sbuffer_size >= GP_STROKE_BUFFER_MAX)
527                         return GP_STROKEADD_OVERFLOW;
528                 
529                 /* get pointer to destination point */
530                 pt = ((tGPspoint *)(gpd->sbuffer) + gpd->sbuffer_size);
531                 
532                 /* store settings */
533                 /* pressure */
534                 if (brush->flag & GP_BRUSH_USE_PRESSURE) {
535                         float curvef = curvemapping_evaluateF(brush->cur_sensitivity, 0, pressure);
536                         pt->pressure = curvef * brush->draw_sensitivity;
537                 }
538                 else {
539                         pt->pressure = 1.0f;
540                 }
541                 /* Apply jitter to position */
542                 if (brush->draw_jitter > 0.0f) {
543                         int r_mval[2];
544                         gp_brush_jitter(gpd, brush, pt, mval, r_mval);
545                         copy_v2_v2_int(&pt->x, r_mval);
546                 }
547                 else {
548                         copy_v2_v2_int(&pt->x, mval);
549                 }
550                 /* apply randomness to pressure */
551                 if ((brush->draw_random_press > 0.0f) && (brush->flag & GP_BRUSH_USE_RANDOM_PRESSURE)) {
552                         float curvef = curvemapping_evaluateF(brush->cur_sensitivity, 0, pressure);
553                         float tmp_pressure = curvef * brush->draw_sensitivity;
554                         if (BLI_frand() > 0.5f) {
555                                 pt->pressure -= tmp_pressure * brush->draw_random_press * BLI_frand();
556                         }
557                         else {
558                                 pt->pressure += tmp_pressure * brush->draw_random_press * BLI_frand();
559                         }
560                         CLAMP(pt->pressure, GPENCIL_STRENGTH_MIN, 1.0f);
561                 }
562
563                 /* apply angle of stroke to brush size */
564                 if (brush->draw_angle_factor > 0.0f) {
565                         gp_brush_angle(gpd, brush, pt, mval);
566                 }
567
568                 /* color strength */
569                 if (brush->flag & GP_BRUSH_USE_STENGTH_PRESSURE) {
570                         float curvef = curvemapping_evaluateF(brush->cur_strength, 0, pressure);
571                         float tmp_pressure = curvef * brush->draw_sensitivity;
572
573                         pt->strength = tmp_pressure * brush->draw_strength;
574                 }
575                 else {
576                         pt->strength = brush->draw_strength;
577                 }
578                 CLAMP(pt->strength, GPENCIL_STRENGTH_MIN, 1.0f);
579
580                 /* apply randomness to color strength */
581                 if ((brush->draw_random_press > 0.0f) && (brush->flag & GP_BRUSH_USE_RANDOM_STRENGTH)) {
582                         if (BLI_frand() > 0.5f) {
583                                 pt->strength -= pt->strength * brush->draw_random_press * BLI_frand();
584                         }
585                         else {
586                                 pt->strength += pt->strength * brush->draw_random_press * BLI_frand();
587                         }
588                         CLAMP(pt->strength, GPENCIL_STRENGTH_MIN, 1.0f);
589                 }
590
591                 /* point time */
592                 pt->time = (float)(curtime - p->inittime);
593                 
594                 /* increment counters */
595                 gpd->sbuffer_size++;
596                 
597                 /* check if another operation can still occur */
598                 if (gpd->sbuffer_size == GP_STROKE_BUFFER_MAX)
599                         return GP_STROKEADD_FULL;
600                 else
601                         return GP_STROKEADD_NORMAL;
602         }
603         else if (p->paintmode == GP_PAINTMODE_DRAW_POLY) {
604                 
605                 bGPDlayer *gpl = BKE_gpencil_layer_getactive(gpd);
606                 /* get pointer to destination point */
607                 pt = (tGPspoint *)(gpd->sbuffer);
608                 
609                 /* store settings */
610                 copy_v2_v2_int(&pt->x, mval);
611                 pt->pressure = 1.0f; /* T44932 - Pressure vals are unreliable, so ignore for now */
612                 pt->strength = 1.0f;
613                 pt->time = (float)(curtime - p->inittime);
614                 
615                 /* if there's stroke for this poly line session add (or replace last) point
616                  * to stroke. This allows to draw lines more interactively (see new segment
617                  * during mouse slide, e.g.)
618                  */
619                 if (gp_stroke_added_check(p)) {
620                         bGPDstroke *gps = p->gpf->strokes.last;
621                         bGPDspoint *pts;
622                         
623                         /* first time point is adding to temporary buffer -- need to allocate new point in stroke */
624                         if (gpd->sbuffer_size == 0) {
625                                 gps->points = MEM_reallocN(gps->points, sizeof(bGPDspoint) * (gps->totpoints + 1));
626                                 gps->totpoints++;
627                         }
628                         
629                         pts = &gps->points[gps->totpoints - 1];
630                         
631                         /* special case for poly lines: normally,
632                          * depth is needed only when creating new stroke from buffer,
633                          * but poly lines are converting to stroke instantly,
634                          * so initialize depth buffer before converting coordinates
635                          */
636                         if (gpencil_project_check(p)) {
637                                 View3D *v3d = p->sa->spacedata.first;
638                                 
639                                 view3d_region_operator_needs_opengl(p->win, p->ar);
640                                 ED_view3d_autodist_init(p->scene, p->ar, v3d, (ts->gpencil_v3d_align & GP_PROJECT_DEPTH_STROKE) ? 1 : 0);
641                         }
642                         
643                         /* convert screen-coordinates to appropriate coordinates (and store them) */
644                         gp_stroke_convertcoords(p, &pt->x, &pts->x, NULL);
645                         /* if axis locked, reproject to plane locked (only in 3d space) */
646                         if (p->lock_axis > GP_LOCKAXIS_NONE) {
647                                 gp_reproject_toplane(p, gps);
648                         }
649                         /* if parented change position relative to parent object */
650                         if (gpl->parent != NULL) {
651                                 gp_apply_parent_point(gpl, pts);
652                         }
653                         /* copy pressure and time */
654                         pts->pressure = pt->pressure;
655                         pts->strength = pt->strength;
656                         pts->time = pt->time;
657                         /* force fill recalc */
658                         gps->flag |= GP_STROKE_RECALC_CACHES;
659                 }
660                 
661                 /* increment counters */
662                 if (gpd->sbuffer_size == 0)
663                         gpd->sbuffer_size++;
664                 
665                 return GP_STROKEADD_NORMAL;
666         }
667
668         /* return invalid state for now... */
669         return GP_STROKEADD_INVALID;
670 }
671
672 /* simplify a stroke (in buffer) before storing it
673  *      - applies a reverse Chaikin filter
674  *      - code adapted from etch-a-ton branch (editarmature_sketch.c)
675  */
676 static void gp_stroke_simplify(tGPsdata *p)
677 {
678         bGPdata *gpd = p->gpd;
679         tGPspoint *old_points = (tGPspoint *)gpd->sbuffer;
680         short num_points = gpd->sbuffer_size;
681         short flag = gpd->sbuffer_sflag;
682         short i, j;
683         
684         /* only simplify if simplification is enabled, and we're not doing a straight line */
685         if (!(U.gp_settings & GP_PAINT_DOSIMPLIFY) || (p->paintmode == GP_PAINTMODE_DRAW_STRAIGHT))
686                 return;
687         
688         /* don't simplify if less than 4 points in buffer */
689         if ((num_points <= 4) || (old_points == NULL))
690                 return;
691         
692         /* clear buffer (but don't free mem yet) so that we can write to it
693          *      - firstly set sbuffer to NULL, so a new one is allocated
694          *      - secondly, reset flag after, as it gets cleared auto
695          */
696         gpd->sbuffer = NULL;
697         gp_session_validatebuffer(p);
698         gpd->sbuffer_sflag = flag;
699         
700 /* macro used in loop to get position of new point
701  *      - used due to the mixture of datatypes in use here
702  */
703 #define GP_SIMPLIFY_AVPOINT(offs, sfac) \
704         { \
705                 co[0] += (float)(old_points[offs].x * sfac); \
706                 co[1] += (float)(old_points[offs].y * sfac); \
707                 pressure += old_points[offs].pressure * sfac; \
708                 time += old_points[offs].time * sfac; \
709         } (void)0
710         
711         /* XXX Here too, do not lose start and end points! */
712         gp_stroke_addpoint(p, &old_points->x, old_points->pressure, p->inittime + (double)old_points->time);
713         for (i = 0, j = 0; i < num_points; i++) {
714                 if (i - j == 3) {
715                         float co[2], pressure, time;
716                         int mco[2];
717                         
718                         /* initialize values */
719                         co[0] = 0.0f;
720                         co[1] = 0.0f;
721                         pressure = 0.0f;
722                         time = 0.0f;
723                         
724                         /* using macro, calculate new point */
725                         GP_SIMPLIFY_AVPOINT(j, -0.25f);
726                         GP_SIMPLIFY_AVPOINT(j + 1, 0.75f);
727                         GP_SIMPLIFY_AVPOINT(j + 2, 0.75f);
728                         GP_SIMPLIFY_AVPOINT(j + 3, -0.25f);
729                         
730                         /* set values for adding */
731                         mco[0] = (int)co[0];
732                         mco[1] = (int)co[1];
733                         
734                         /* ignore return values on this... assume to be ok for now */
735                         gp_stroke_addpoint(p, mco, pressure, p->inittime + (double)time);
736                         
737                         j += 2;
738                 }
739         }
740         gp_stroke_addpoint(p, &old_points[num_points - 1].x, old_points[num_points - 1].pressure,
741                            p->inittime + (double)old_points[num_points - 1].time);
742         
743         /* free old buffer */
744         MEM_freeN(old_points);
745 }
746
747 /* make a new stroke from the buffer data */
748 static void gp_stroke_newfrombuffer(tGPsdata *p)
749 {
750         bGPdata *gpd = p->gpd;
751         bGPDlayer *gpl = p->gpl;
752         bGPDstroke *gps;
753         bGPDspoint *pt;
754         tGPspoint *ptc;
755         bGPDbrush *brush = p->brush;
756         ToolSettings *ts = p->scene->toolsettings;
757         
758         int i, totelem;
759         /* since strokes are so fine, when using their depth we need a margin otherwise they might get missed */
760         int depth_margin = (ts->gpencil_v3d_align & GP_PROJECT_DEPTH_STROKE) ? 4 : 0;
761         
762         /* get total number of points to allocate space for
763          *      - drawing straight-lines only requires the endpoints
764          */
765         if (p->paintmode == GP_PAINTMODE_DRAW_STRAIGHT)
766                 totelem = (gpd->sbuffer_size >= 2) ? 2 : gpd->sbuffer_size;
767         else
768                 totelem = gpd->sbuffer_size;
769         
770         /* exit with error if no valid points from this stroke */
771         if (totelem == 0) {
772                 if (G.debug & G_DEBUG)
773                         printf("Error: No valid points in stroke buffer to convert (tot=%d)\n", gpd->sbuffer_size);
774                 return;
775         }
776         
777         /* special case for poly line -- for already added stroke during session
778          * coordinates are getting added to stroke immediately to allow more
779          * interactive behavior
780          */
781         if (p->paintmode == GP_PAINTMODE_DRAW_POLY) {
782                 if (gp_stroke_added_check(p)) {
783                         return;
784                 }
785         }
786         
787         /* allocate memory for a new stroke */
788         gps = MEM_callocN(sizeof(bGPDstroke), "gp_stroke");
789         
790         /* copy appropriate settings for stroke */
791         gps->totpoints = totelem;
792         gps->thickness = brush->thickness;
793         gps->flag = gpd->sbuffer_sflag;
794         gps->inittime = p->inittime;
795         
796         /* enable recalculation flag by default (only used if hq fill) */
797         gps->flag |= GP_STROKE_RECALC_CACHES;
798
799         /* allocate enough memory for a continuous array for storage points */
800         int sublevel = brush->sublevel;
801         int new_totpoints = gps->totpoints;
802         
803         for (i = 0; i < sublevel; i++) {
804                 new_totpoints += new_totpoints - 1;
805         }
806         gps->points = MEM_callocN(sizeof(bGPDspoint) * new_totpoints, "gp_stroke_points");
807         /* initialize triangle memory to dummy data */
808         gps->triangles = MEM_callocN(sizeof(bGPDtriangle), "GP Stroke triangulation");
809         gps->flag |= GP_STROKE_RECALC_CACHES;
810         gps->tot_triangles = 0;
811         /* set pointer to first non-initialized point */
812         pt = gps->points + (gps->totpoints - totelem);
813         
814         /* copy points from the buffer to the stroke */
815         if (p->paintmode == GP_PAINTMODE_DRAW_STRAIGHT) {
816                 /* straight lines only -> only endpoints */
817                 {
818                         /* first point */
819                         ptc = gpd->sbuffer;
820                         
821                         /* convert screen-coordinates to appropriate coordinates (and store them) */
822                         gp_stroke_convertcoords(p, &ptc->x, &pt->x, NULL);
823                         /* if axis locked, reproject to plane locked (only in 3d space) */
824                         if (p->lock_axis > GP_LOCKAXIS_NONE) {
825                                 gp_reproject_toplane(p, gps);
826                         }
827                         /* if parented change position relative to parent object */
828                         if (gpl->parent != NULL) {
829                                 gp_apply_parent_point(gpl, pt);
830                         }
831                         /* copy pressure and time */
832                         pt->pressure = ptc->pressure;
833                         pt->strength = ptc->strength;
834                         CLAMP(pt->strength, GPENCIL_STRENGTH_MIN, 1.0f);
835                         pt->time = ptc->time;
836                         
837                         pt++;
838                 }
839                 
840                 if (totelem == 2) {
841                         /* last point if applicable */
842                         ptc = ((tGPspoint *)gpd->sbuffer) + (gpd->sbuffer_size - 1);
843                         
844                         /* convert screen-coordinates to appropriate coordinates (and store them) */
845                         gp_stroke_convertcoords(p, &ptc->x, &pt->x, NULL);
846                         /* if axis locked, reproject to plane locked (only in 3d space) */
847                         if (p->lock_axis > GP_LOCKAXIS_NONE) {
848                                 gp_reproject_toplane(p, gps);
849                         }
850                         /* if parented change position relative to parent object */
851                         if (gpl->parent != NULL) {
852                                 gp_apply_parent_point(gpl, pt);
853                         }
854
855                         /* copy pressure and time */
856                         pt->pressure = ptc->pressure;
857                         pt->strength = ptc->strength;
858                         CLAMP(pt->strength, GPENCIL_STRENGTH_MIN, 1.0f);
859                         pt->time = ptc->time;
860                 }
861         }
862         else if (p->paintmode == GP_PAINTMODE_DRAW_POLY) {
863                 /* first point */
864                 ptc = gpd->sbuffer;
865                 
866                 /* convert screen-coordinates to appropriate coordinates (and store them) */
867                 gp_stroke_convertcoords(p, &ptc->x, &pt->x, NULL);
868                 /* if axis locked, reproject to plane locked (only in 3d space) */
869                 if (p->lock_axis > GP_LOCKAXIS_NONE) {
870                         gp_reproject_toplane(p, gps);
871                 }
872                 /* if parented change position relative to parent object */
873                 if (gpl->parent != NULL) {
874                         gp_apply_parent_point(gpl, pt);
875                 }
876                 /* copy pressure and time */
877                 pt->pressure = ptc->pressure;
878                 pt->strength = ptc->strength;
879                 CLAMP(pt->strength, GPENCIL_STRENGTH_MIN, 1.0f);
880                 pt->time = ptc->time;
881         }
882         else {
883                 float *depth_arr = NULL;
884
885                 /* get an array of depths, far depths are blended */
886                 if (gpencil_project_check(p)) {
887                         int mval[2], mval_prev[2] = { 0 };
888                         int interp_depth = 0;
889                         int found_depth = 0;
890
891                         depth_arr = MEM_mallocN(sizeof(float) * gpd->sbuffer_size, "depth_points");
892
893                         for (i = 0, ptc = gpd->sbuffer; i < gpd->sbuffer_size; i++, ptc++, pt++) {
894                                 copy_v2_v2_int(mval, &ptc->x);
895
896                                 if ((ED_view3d_autodist_depth(p->ar, mval, depth_margin, depth_arr + i) == 0) &&
897                                         (i && (ED_view3d_autodist_depth_seg(p->ar, mval, mval_prev, depth_margin + 1, depth_arr + i) == 0)))
898                                 {
899                                         interp_depth = true;
900                                 }
901                                 else {
902                                         found_depth = true;
903                                 }
904
905                                 copy_v2_v2_int(mval_prev, mval);
906                         }
907
908                         if (found_depth == false) {
909                                 /* eeh... not much we can do.. :/, ignore depth in this case, use the 3D cursor */
910                                 for (i = gpd->sbuffer_size - 1; i >= 0; i--)
911                                         depth_arr[i] = 0.9999f;
912                         }
913                         else {
914                                 if (ts->gpencil_v3d_align & GP_PROJECT_DEPTH_STROKE_ENDPOINTS) {
915                                         /* remove all info between the valid endpoints */
916                                         int first_valid = 0;
917                                         int last_valid = 0;
918
919                                         for (i = 0; i < gpd->sbuffer_size; i++) {
920                                                 if (depth_arr[i] != FLT_MAX)
921                                                         break;
922                                         }
923                                         first_valid = i;
924
925                                         for (i = gpd->sbuffer_size - 1; i >= 0; i--) {
926                                                 if (depth_arr[i] != FLT_MAX)
927                                                         break;
928                                         }
929                                         last_valid = i;
930
931                                         /* invalidate non-endpoints, so only blend between first and last */
932                                         for (i = first_valid + 1; i < last_valid; i++)
933                                                 depth_arr[i] = FLT_MAX;
934
935                                         interp_depth = true;
936                                 }
937
938                                 if (interp_depth) {
939                                         interp_sparse_array(depth_arr, gpd->sbuffer_size, FLT_MAX);
940                                 }
941                         }
942                 }
943
944
945                 pt = gps->points;
946
947                 /* convert all points (normal behavior) */
948                 for (i = 0, ptc = gpd->sbuffer; i < gpd->sbuffer_size && ptc; i++, ptc++, pt++) {
949                         /* convert screen-coordinates to appropriate coordinates (and store them) */
950                         gp_stroke_convertcoords(p, &ptc->x, &pt->x, depth_arr ? depth_arr + i : NULL);
951
952                         /* copy pressure and time */
953                         pt->pressure = ptc->pressure;
954                         pt->strength = ptc->strength;
955                         CLAMP(pt->strength, GPENCIL_STRENGTH_MIN, 1.0f);
956                         pt->time = ptc->time;
957                 }
958
959                 /* subdivide the stroke */
960                 if (sublevel > 0) {
961                         int totpoints = gps->totpoints;
962                         for (i = 0; i < sublevel; i++) {
963                                 /* we're adding one new point between each pair of verts on each step */
964                                 totpoints += totpoints - 1;
965
966                                 gp_subdivide_stroke(gps, totpoints);
967                         }
968                 }
969                 /* apply randomness to stroke */
970                 if (brush->draw_random_sub > 0.0f) {
971                         gp_randomize_stroke(gps, brush);
972                 }
973
974                 /* smooth stroke after subdiv - only if there's something to do
975                  * for each iteration, the factor is reduced to get a better smoothing without changing too much
976                  * the original stroke
977                  */
978                 if (brush->draw_smoothfac > 0.0f) {
979                         float reduce = 0.0f;
980                         for (int r = 0; r < brush->draw_smoothlvl; ++r) {
981                                 for (i = 0; i < gps->totpoints; i++) {
982                                         /* NOTE: No pressure smoothing, or else we get annoying thickness changes while drawing... */
983                                         gp_smooth_stroke(gps, i, brush->draw_smoothfac - reduce, false);
984                                 }
985                                 reduce += 0.25f;  // reduce the factor
986                         }
987                 }
988
989                 /* if axis locked, reproject to plane locked (only in 3d space) */
990                 if (p->lock_axis > GP_LOCKAXIS_NONE) {
991                         gp_reproject_toplane(p, gps);
992                 }
993                 /* if parented change position relative to parent object */
994                 if (gpl->parent != NULL) {
995                         gp_apply_parent(gpl, gps);
996                 }
997
998                 if (depth_arr)
999                         MEM_freeN(depth_arr);
1000         }
1001         /* Save palette color */
1002         bGPDpalette *palette = BKE_gpencil_palette_getactive(p->gpd);
1003         bGPDpalettecolor *palcolor = BKE_gpencil_palettecolor_getactive(palette);
1004         gps->palcolor = palcolor;
1005         BLI_strncpy(gps->colorname, palcolor->info, sizeof(gps->colorname));
1006
1007         /* add stroke to frame, usually on tail of the listbase, but if on back is enabled the stroke is added on listbase head 
1008         * because the drawing order is inverse and the head stroke is the first to draw. This is very useful for artist
1009         * when drawing the background
1010         */
1011         if ((ts->gpencil_flags & GP_TOOL_FLAG_PAINT_ONBACK) && (p->paintmode != GP_PAINTMODE_DRAW_POLY)) {
1012                 BLI_addhead(&p->gpf->strokes, gps);
1013         }
1014         else {
1015                 BLI_addtail(&p->gpf->strokes, gps);
1016         }
1017         gp_stroke_added_enable(p);
1018 }
1019
1020 /* --- 'Eraser' for 'Paint' Tool ------ */
1021
1022 /* which which point is infront (result should only be used for comparison) */
1023 static float view3d_point_depth(const RegionView3D *rv3d, const float co[3])
1024 {
1025         if (rv3d->is_persp) {
1026                 return ED_view3d_calc_zfac(rv3d, co, NULL);
1027         }
1028         else {
1029                 return -dot_v3v3(rv3d->viewinv[2], co);
1030         }
1031 }
1032
1033 /* only erase stroke points that are visible */
1034 static bool gp_stroke_eraser_is_occluded(tGPsdata *p, const bGPDspoint *pt, const int x, const int y)
1035 {
1036         if ((p->sa->spacetype == SPACE_VIEW3D) &&
1037             (p->flags & GP_PAINTFLAG_V3D_ERASER_DEPTH))
1038         {
1039                 RegionView3D *rv3d = p->ar->regiondata;
1040                 bGPDlayer *gpl = p->gpl;
1041
1042                 const int mval[2] = {x, y};
1043                 float mval_3d[3];
1044                 float fpt[3];
1045
1046                 float diff_mat[4][4];
1047                 /* calculate difference matrix if parent object */
1048                 ED_gpencil_parent_location(gpl, diff_mat);
1049
1050                 if (ED_view3d_autodist_simple(p->ar, mval, mval_3d, 0, NULL)) {
1051                         const float depth_mval = view3d_point_depth(rv3d, mval_3d);
1052
1053                         mul_v3_m4v3(fpt, diff_mat, &pt->x);
1054                         const float depth_pt   = view3d_point_depth(rv3d, fpt);
1055                         
1056                         if (depth_pt > depth_mval) {
1057                                 return true;
1058                         }
1059                 }
1060         }
1061         return false;
1062 }
1063
1064 /* apply a falloff effect to brush strength, based on distance */
1065 static float gp_stroke_eraser_calc_influence(tGPsdata *p, const int mval[2], const int radius, const int co[2])
1066 {
1067         /* Linear Falloff... */
1068         float distance = (float)len_v2v2_int(mval, co);
1069         float fac;
1070         
1071         CLAMP(distance, 0.0f, (float)radius);
1072         fac = 1.0f - (distance / (float)radius);
1073         
1074         /* Control this further using pen pressure */
1075         fac *= p->pressure;
1076         
1077         /* Return influence factor computed here */
1078         return fac;
1079 }
1080
1081 /* eraser tool - evaluation per stroke */
1082 /* TODO: this could really do with some optimization (KD-Tree/BVH?) */
1083 static void gp_stroke_eraser_dostroke(tGPsdata *p,
1084                                       bGPDlayer *gpl, bGPDframe *gpf, bGPDstroke *gps,
1085                                       const int mval[2], const int mvalo[2],
1086                                       const int radius, const rcti *rect)
1087 {
1088         bGPDspoint *pt1, *pt2;
1089         int pc1[2] = {0};
1090         int pc2[2] = {0};
1091         int i;
1092         float diff_mat[4][4];
1093
1094         /* calculate difference matrix if parent object */
1095         if (gpl->parent != NULL) {
1096                 ED_gpencil_parent_location(gpl, diff_mat);
1097         }
1098
1099         if (gps->totpoints == 0) {
1100                 /* just free stroke */
1101                 if (gps->points)
1102                         MEM_freeN(gps->points);
1103                 if (gps->triangles)
1104                         MEM_freeN(gps->triangles);
1105                 BLI_freelinkN(&gpf->strokes, gps);
1106         }
1107         else if (gps->totpoints == 1) {
1108                 /* only process if it hasn't been masked out... */
1109                 if (!(p->flags & GP_PAINTFLAG_SELECTMASK) || (gps->points->flag & GP_SPOINT_SELECT)) {
1110                         if (gpl->parent == NULL) {
1111                                 gp_point_to_xy(&p->gsc, gps, gps->points, &pc1[0], &pc1[1]);
1112                         }
1113                         else {
1114                                 bGPDspoint pt_temp;
1115                                 gp_point_to_parent_space(gps->points, diff_mat, &pt_temp);
1116                                 gp_point_to_xy(&p->gsc, gps, &pt_temp, &pc1[0], &pc1[1]);
1117                         }
1118                         /* do boundbox check first */
1119                         if ((!ELEM(V2D_IS_CLIPPED, pc1[0], pc1[1])) && BLI_rcti_isect_pt(rect, pc1[0], pc1[1])) {
1120                                 /* only check if point is inside */
1121                                 if (len_v2v2_int(mval, pc1) <= radius) {
1122                                         /* free stroke */
1123                                         // XXX: pressure sensitive eraser should apply here too?
1124                                         MEM_freeN(gps->points);
1125                                         if (gps->triangles)
1126                                                 MEM_freeN(gps->triangles);
1127                                         BLI_freelinkN(&gpf->strokes, gps);
1128                                 }
1129                         }
1130                 }
1131         }
1132         else {
1133                 /* Pressure threshold at which stroke should be culled: Calculated as pressure value
1134                  * below which we would have invisible strokes
1135                  */
1136                 const float cull_thresh = (gps->thickness) ?  1.0f / ((float)gps->thickness)  : 1.0f;
1137                 
1138                 /* Amount to decrease the pressure of each point with each stroke */
1139                 // TODO: Fetch from toolsettings, or compute based on thickness instead?
1140                 const float strength = 0.1f;
1141                 
1142                 /* Perform culling? */
1143                 bool do_cull = false;
1144                 
1145                 
1146                 /* Clear Tags
1147                  *
1148                  * Note: It's better this way, as we are sure that
1149                  * we don't miss anything, though things will be
1150                  * slightly slower as a result
1151                  */
1152                 for (i = 0; i < gps->totpoints; i++) {
1153                         bGPDspoint *pt = &gps->points[i];
1154                         pt->flag &= ~GP_SPOINT_TAG;
1155                 }
1156                 
1157                 /* First Pass: Loop over the points in the stroke
1158                  *   1) Thin out parts of the stroke under the brush
1159                  *   2) Tag "too thin" parts for removal (in second pass)
1160                  */
1161                 for (i = 0; (i + 1) < gps->totpoints; i++) {
1162                         /* get points to work with */
1163                         pt1 = gps->points + i;
1164                         pt2 = gps->points + i + 1;
1165
1166                         /* only process if it hasn't been masked out... */
1167                         if ((p->flags & GP_PAINTFLAG_SELECTMASK) && !(gps->points->flag & GP_SPOINT_SELECT))
1168                                 continue;
1169                         
1170                         if (gpl->parent == NULL) {
1171                                 gp_point_to_xy(&p->gsc, gps, pt1, &pc1[0], &pc1[1]);
1172                                 gp_point_to_xy(&p->gsc, gps, pt2, &pc2[0], &pc2[1]);
1173                         }
1174                         else {
1175                                 bGPDspoint npt;
1176                                 gp_point_to_parent_space(pt1, diff_mat, &npt);
1177                                 gp_point_to_xy(&p->gsc, gps, &npt, &pc1[0], &pc1[1]);
1178
1179                                 gp_point_to_parent_space(pt2, diff_mat, &npt);
1180                                 gp_point_to_xy(&p->gsc, gps, &npt, &pc2[0], &pc2[1]);
1181                         }
1182
1183                         /* Check that point segment of the boundbox of the eraser stroke */
1184                         if (((!ELEM(V2D_IS_CLIPPED, pc1[0], pc1[1])) && BLI_rcti_isect_pt(rect, pc1[0], pc1[1])) ||
1185                             ((!ELEM(V2D_IS_CLIPPED, pc2[0], pc2[1])) && BLI_rcti_isect_pt(rect, pc2[0], pc2[1])))
1186                         {
1187                                 /* Check if point segment of stroke had anything to do with
1188                                  * eraser region  (either within stroke painted, or on its lines)
1189                                  *  - this assumes that linewidth is irrelevant
1190                                  */
1191                                 if (gp_stroke_inside_circle(mval, mvalo, radius, pc1[0], pc1[1], pc2[0], pc2[1])) {
1192                                         if ((gp_stroke_eraser_is_occluded(p, pt1, pc1[0], pc1[1]) == false) ||
1193                                             (gp_stroke_eraser_is_occluded(p, pt2, pc2[0], pc2[1]) == false))
1194                                         {
1195                                                 /* Point is affected: */
1196                                                 /* 1) Adjust thickness
1197                                                  *  - Influence of eraser falls off with distance from the middle of the eraser
1198                                                  *  - Second point gets less influence, as it might get hit again in the next segment
1199                                                  */
1200                                                 pt1->pressure -= gp_stroke_eraser_calc_influence(p, mval, radius, pc1) * strength;
1201                                                 pt2->pressure -= gp_stroke_eraser_calc_influence(p, mval, radius, pc2) * strength / 2.0f;
1202                                                 
1203                                                 /* 2) Tag any point with overly low influence for removal in the next pass */
1204                                                 if (pt1->pressure < cull_thresh) {
1205                                                         pt1->flag |= GP_SPOINT_TAG;
1206                                                         do_cull = true;
1207                                                 }
1208                                                 if (pt2->pressure < cull_thresh) {
1209                                                         pt2->flag |= GP_SPOINT_TAG;
1210                                                         do_cull = true;
1211                                                 }
1212                                         }
1213                                 }
1214                         }
1215                 }
1216                 
1217                 /* Second Pass: Remove any points that are tagged */
1218                 if (do_cull) {
1219                         gp_stroke_delete_tagged_points(gpf, gps, gps->next, GP_SPOINT_TAG);
1220                 }
1221         }
1222 }
1223
1224 /* erase strokes which fall under the eraser strokes */
1225 static void gp_stroke_doeraser(tGPsdata *p)
1226 {
1227         bGPDlayer *gpl;
1228         bGPDstroke *gps, *gpn;
1229         rcti rect;
1230         
1231         /* rect is rectangle of eraser */
1232         rect.xmin = p->mval[0] - p->radius;
1233         rect.ymin = p->mval[1] - p->radius;
1234         rect.xmax = p->mval[0] + p->radius;
1235         rect.ymax = p->mval[1] + p->radius;
1236         
1237         if (p->sa->spacetype == SPACE_VIEW3D) {
1238                 if (p->flags & GP_PAINTFLAG_V3D_ERASER_DEPTH) {
1239                         View3D *v3d = p->sa->spacedata.first;
1240                         
1241                         view3d_region_operator_needs_opengl(p->win, p->ar);
1242                         ED_view3d_autodist_init(p->scene, p->ar, v3d, 0);
1243                 }
1244         }
1245         
1246         /* loop over all layers too, since while it's easy to restrict editing to
1247          * only a subset of layers, it is harder to perform the same erase operation
1248          * on multiple layers...
1249          */
1250         for (gpl = p->gpd->layers.first; gpl; gpl = gpl->next) {
1251                 bGPDframe *gpf = gpl->actframe;
1252                 
1253                 /* only affect layer if it's editable (and visible) */
1254                 if (gpencil_layer_is_editable(gpl) == false) {
1255                         continue;
1256                 }
1257                 else if (gpf == NULL) {
1258                         continue;
1259                 }
1260                 
1261                 /* loop over strokes, checking segments for intersections */
1262                 for (gps = gpf->strokes.first; gps; gps = gpn) {
1263                         gpn = gps->next;
1264                         /* check if the color is editable */
1265                         if (ED_gpencil_stroke_color_use(gpl, gps) == false) {
1266                                 continue;
1267                         }
1268                         /* Not all strokes in the datablock may be valid in the current editor/context
1269                          * (e.g. 2D space strokes in the 3D view, if the same datablock is shared)
1270                          */
1271                         if (ED_gpencil_stroke_can_use_direct(p->sa, gps)) {
1272                                 gp_stroke_eraser_dostroke(p, gpl, gpf, gps, p->mval, p->mvalo, p->radius, &rect);
1273                         }
1274                 }
1275         }
1276 }
1277
1278 /* ******************************************* */
1279 /* Sketching Operator */
1280
1281 /* clear the session buffers (call this before AND after a paint operation) */
1282 static void gp_session_validatebuffer(tGPsdata *p)
1283 {
1284         bGPdata *gpd = p->gpd;
1285         
1286         /* clear memory of buffer (or allocate it if starting a new session) */
1287         if (gpd->sbuffer) {
1288                 /* printf("\t\tGP - reset sbuffer\n"); */
1289                 memset(gpd->sbuffer, 0, sizeof(tGPspoint) * GP_STROKE_BUFFER_MAX);
1290         }
1291         else {
1292                 /* printf("\t\tGP - allocate sbuffer\n"); */
1293                 gpd->sbuffer = MEM_callocN(sizeof(tGPspoint) * GP_STROKE_BUFFER_MAX, "gp_session_strokebuffer");
1294         }
1295         
1296         /* reset indices */
1297         gpd->sbuffer_size = 0;
1298         
1299         /* reset flags */
1300         gpd->sbuffer_sflag = 0;
1301         
1302         /* reset inittime */
1303         p->inittime = 0.0;
1304 }
1305
1306 /* create a new palette color */
1307 static bGPDpalettecolor *gp_create_new_color(bGPDpalette *palette)
1308 {
1309         bGPDpalettecolor *palcolor;
1310
1311         palcolor = BKE_gpencil_palettecolor_addnew(palette, DATA_("Color"), true);
1312         
1313         return palcolor;
1314 }
1315
1316 /* initialize a drawing brush */
1317 static void gp_init_drawing_brush(ToolSettings *ts, tGPsdata *p)
1318 {
1319         bGPDbrush *brush;
1320
1321         /* if not exist, create a new one */
1322         if (BLI_listbase_is_empty(&ts->gp_brushes)) {
1323                 /* create new brushes */
1324                 BKE_gpencil_brush_init_presets(ts);
1325                 brush = BKE_gpencil_brush_getactive(ts);
1326         }
1327         else {
1328                 /* Use the current */
1329                 brush = BKE_gpencil_brush_getactive(ts);
1330         }
1331         /* be sure curves are initializated */
1332         curvemapping_initialize(brush->cur_sensitivity);
1333         curvemapping_initialize(brush->cur_strength);
1334         curvemapping_initialize(brush->cur_jitter);
1335
1336         /* asign to temp tGPsdata */
1337         p->brush = brush;
1338 }
1339
1340
1341 /* initialize a paint palette brush and a default color if not exist */
1342 static void gp_init_palette(tGPsdata *p)
1343 {
1344         bGPdata *gpd;
1345         bGPDpalette *palette;
1346         bGPDpalettecolor *palcolor;
1347
1348         gpd = p->gpd;
1349
1350         /* if not exist, create a new palette */
1351         if (BLI_listbase_is_empty(&gpd->palettes)) {
1352                 /* create new palette */
1353                 palette = BKE_gpencil_palette_addnew(gpd, DATA_("GP_Palette"), true);
1354                 /* now create a default color */
1355                 palcolor = gp_create_new_color(palette);
1356         }
1357         else {
1358                 /* Use the current palette and color */
1359                 palette = BKE_gpencil_palette_getactive(gpd);
1360                 /* the palette needs one color */
1361                 if (BLI_listbase_is_empty(&palette->colors)) {
1362                         palcolor = gp_create_new_color(palette);
1363                 }
1364                 else {
1365                         palcolor = BKE_gpencil_palettecolor_getactive(palette);
1366                 }
1367                 /* in some situations can be null, so use first */
1368                 if (palcolor == NULL) {
1369                         BKE_gpencil_palettecolor_setactive(palette, palette->colors.first);
1370                         palcolor = palette->colors.first;
1371                 }
1372         }
1373
1374         /* asign to temp tGPsdata */
1375         p->palettecolor = palcolor;
1376 }
1377
1378 /* (re)init new painting data */
1379 static bool gp_session_initdata(bContext *C, tGPsdata *p)
1380 {
1381         bGPdata **gpd_ptr = NULL;
1382         ScrArea *curarea = CTX_wm_area(C);
1383         ARegion *ar = CTX_wm_region(C);
1384         ToolSettings *ts = CTX_data_tool_settings(C);
1385         
1386         /* make sure the active view (at the starting time) is a 3d-view */
1387         if (curarea == NULL) {
1388                 p->status = GP_STATUS_ERROR;
1389                 if (G.debug & G_DEBUG)
1390                         printf("Error: No active view for painting\n");
1391                 return 0;
1392         }
1393         
1394         /* pass on current scene and window */
1395         p->scene = CTX_data_scene(C);
1396         p->win = CTX_wm_window(C);
1397         
1398         unit_m4(p->imat);
1399         unit_m4(p->mat);
1400         
1401         switch (curarea->spacetype) {
1402                 /* supported views first */
1403                 case SPACE_VIEW3D:
1404                 {
1405                         /* View3D *v3d = curarea->spacedata.first; */
1406                         /* RegionView3D *rv3d = ar->regiondata; */
1407                         
1408                         /* set current area
1409                          *      - must verify that region data is 3D-view (and not something else)
1410                          */
1411                         /* CAUTION: If this is the "toolbar", then this will change on the first stroke */
1412                         p->sa = curarea;
1413                         p->ar = ar;
1414                         p->align_flag = &ts->gpencil_v3d_align;
1415                         
1416                         if (ar->regiondata == NULL) {
1417                                 p->status = GP_STATUS_ERROR;
1418                                 if (G.debug & G_DEBUG)
1419                                         printf("Error: 3D-View active region doesn't have any region data, so cannot be drawable\n");
1420                                 return 0;
1421                         }
1422                         break;
1423                 }
1424                 case SPACE_NODE:
1425                 {
1426                         /* SpaceNode *snode = curarea->spacedata.first; */
1427                         
1428                         /* set current area */
1429                         p->sa = curarea;
1430                         p->ar = ar;
1431                         p->v2d = &ar->v2d;
1432                         p->align_flag = &ts->gpencil_v2d_align;
1433                         break;
1434                 }
1435                 case SPACE_SEQ:
1436                 {
1437                         SpaceSeq *sseq = curarea->spacedata.first;
1438                         
1439                         /* set current area */
1440                         p->sa = curarea;
1441                         p->ar = ar;
1442                         p->v2d = &ar->v2d;
1443                         p->align_flag = &ts->gpencil_seq_align;
1444                         
1445                         /* check that gpencil data is allowed to be drawn */
1446                         if (sseq->mainb == SEQ_DRAW_SEQUENCE) {
1447                                 p->status = GP_STATUS_ERROR;
1448                                 if (G.debug & G_DEBUG)
1449                                         printf("Error: In active view (sequencer), active mode doesn't support Grease Pencil\n");
1450                                 return 0;
1451                         }
1452                         break;
1453                 }
1454                 case SPACE_IMAGE:
1455                 {
1456                         /* SpaceImage *sima = curarea->spacedata.first; */
1457                         
1458                         /* set the current area */
1459                         p->sa = curarea;
1460                         p->ar = ar;
1461                         p->v2d = &ar->v2d;
1462                         p->align_flag = &ts->gpencil_ima_align;
1463                         break;
1464                 }
1465                 case SPACE_CLIP:
1466                 {
1467                         SpaceClip *sc = curarea->spacedata.first;
1468                         MovieClip *clip = ED_space_clip_get_clip(sc);
1469                         
1470                         if (clip == NULL) {
1471                                 p->status = GP_STATUS_ERROR;
1472                                 return false;
1473                         }
1474
1475                         /* set the current area */
1476                         p->sa = curarea;
1477                         p->ar = ar;
1478                         p->v2d = &ar->v2d;
1479                         p->align_flag = &ts->gpencil_v2d_align;
1480                         
1481                         invert_m4_m4(p->imat, sc->unistabmat);
1482                         
1483                         /* custom color for new layer */
1484                         p->custom_color[0] = 1.0f;
1485                         p->custom_color[1] = 0.0f;
1486                         p->custom_color[2] = 0.5f;
1487                         p->custom_color[3] = 0.9f;
1488                         
1489                         if (sc->gpencil_src == SC_GPENCIL_SRC_TRACK) {
1490                                 int framenr = ED_space_clip_get_clip_frame_number(sc);
1491                                 MovieTrackingTrack *track = BKE_tracking_track_get_active(&clip->tracking);
1492                                 MovieTrackingMarker *marker = track ? BKE_tracking_marker_get(track, framenr) : NULL;
1493
1494                                 if (marker) {
1495                                         p->imat[3][0] -= marker->pos[0];
1496                                         p->imat[3][1] -= marker->pos[1];
1497                                 }
1498                                 else {
1499                                         p->status = GP_STATUS_ERROR;
1500                                         return false;
1501                                 }
1502                         }
1503                         
1504                         invert_m4_m4(p->mat, p->imat);
1505                         copy_m4_m4(p->gsc.mat, p->mat);
1506                         break;
1507                 }
1508                 /* unsupported views */
1509                 default:
1510                 {
1511                         p->status = GP_STATUS_ERROR;
1512                         if (G.debug & G_DEBUG)
1513                                 printf("Error: Active view not appropriate for Grease Pencil drawing\n");
1514                         return 0;
1515                 }
1516         }
1517         
1518         /* get gp-data */
1519         gpd_ptr = ED_gpencil_data_get_pointers(C, &p->ownerPtr);
1520         if (gpd_ptr == NULL) {
1521                 p->status = GP_STATUS_ERROR;
1522                 if (G.debug & G_DEBUG)
1523                         printf("Error: Current context doesn't allow for any Grease Pencil data\n");
1524                 return 0;
1525         }
1526         else {
1527                 /* if no existing GPencil block exists, add one */
1528                 if (*gpd_ptr == NULL)
1529                         *gpd_ptr = BKE_gpencil_data_addnew("GPencil");
1530                 p->gpd = *gpd_ptr;
1531         }
1532         
1533         if (ED_gpencil_session_active() == 0) {
1534                 /* initialize undo stack,
1535                  * also, existing undo stack would make buffer drawn
1536                  */
1537                 gpencil_undo_init(p->gpd);
1538         }
1539         
1540         /* clear out buffer (stored in gp-data), in case something contaminated it */
1541         gp_session_validatebuffer(p);
1542         /* set brush and create a new one if null */
1543         gp_init_drawing_brush(ts, p);
1544         /* set palette info and create a new one if null */
1545         gp_init_palette(p);
1546         /* set palette colors */
1547         bGPDpalettecolor *palcolor = p->palettecolor;
1548         bGPdata *pdata = p->gpd;
1549         copy_v4_v4(pdata->scolor, palcolor->color);
1550         pdata->sflag = palcolor->flag;
1551         /* lock axis */
1552         p->lock_axis = ts->gp_sculpt.lock_axis;
1553
1554         return 1;
1555 }
1556
1557 /* init new painting session */
1558 static tGPsdata *gp_session_initpaint(bContext *C)
1559 {
1560         tGPsdata *p = NULL;
1561         
1562         /* create new context data */
1563         p = MEM_callocN(sizeof(tGPsdata), "GPencil Drawing Data");
1564         
1565         gp_session_initdata(C, p);
1566         
1567         /* radius for eraser circle is defined in userprefs now */
1568         /* NOTE: we do this here, so that if we exit immediately,
1569          *       erase size won't get lost
1570          */
1571         p->radius = U.gp_eraser;
1572
1573         /* return context data for running paint operator */
1574         return p;
1575 }
1576
1577 /* cleanup after a painting session */
1578 static void gp_session_cleanup(tGPsdata *p)
1579 {
1580         bGPdata *gpd = (p) ? p->gpd : NULL;
1581         
1582         /* error checking */
1583         if (gpd == NULL)
1584                 return;
1585         
1586         /* free stroke buffer */
1587         if (gpd->sbuffer) {
1588                 /* printf("\t\tGP - free sbuffer\n"); */
1589                 MEM_freeN(gpd->sbuffer);
1590                 gpd->sbuffer = NULL;
1591         }
1592         
1593         /* clear flags */
1594         gpd->sbuffer_size = 0;
1595         gpd->sbuffer_sflag = 0;
1596         p->inittime = 0.0;
1597 }
1598
1599 /* init new stroke */
1600 static void gp_paint_initstroke(tGPsdata *p, eGPencil_PaintModes paintmode)
1601 {
1602         Scene *scene = p->scene;
1603         ToolSettings *ts = scene->toolsettings;
1604         
1605         /* get active layer (or add a new one if non-existent) */
1606         p->gpl = BKE_gpencil_layer_getactive(p->gpd);
1607         if (p->gpl == NULL) {
1608                 p->gpl = BKE_gpencil_layer_addnew(p->gpd, "GP_Layer", true);
1609                 
1610                 if (p->custom_color[3])
1611                         copy_v3_v3(p->gpl->color, p->custom_color);
1612         }
1613         if (p->gpl->flag & GP_LAYER_LOCKED) {
1614                 p->status = GP_STATUS_ERROR;
1615                 if (G.debug & G_DEBUG)
1616                         printf("Error: Cannot paint on locked layer\n");
1617                 return;
1618         }
1619         
1620         /* get active frame (add a new one if not matching frame) */
1621         if (paintmode == GP_PAINTMODE_ERASER) {
1622                 /* Eraser mode:
1623                  * 1) Add new frames to all frames that we might touch,
1624                  * 2) Ensure that p->gpf refers to the frame used for the active layer
1625                  *    (to avoid problems with other tools which expect it to exist)
1626                  */
1627                 bool has_layer_to_erase = false;
1628                 
1629                 for (bGPDlayer *gpl = p->gpd->layers.first; gpl; gpl = gpl->next) {
1630                         /* Skip if layer not editable */
1631                         if (gpencil_layer_is_editable(gpl) == false)
1632                                 continue;
1633                         
1634                         /* Add a new frame if needed (and based off the active frame,
1635                          * as we need some existing strokes to erase)
1636                          *
1637                          * Note: We don't add a new frame if there's nothing there now, so
1638                          *       -> If there are no frames at all, don't add one
1639                          *       -> If there are no strokes in that frame, don't add a new empty frame
1640                          */
1641                         if (gpl->actframe && gpl->actframe->strokes.first) {
1642                                 gpl->actframe = BKE_gpencil_layer_getframe(gpl, CFRA, GP_GETFRAME_ADD_COPY);
1643                                 has_layer_to_erase = true;
1644                         }
1645                         
1646                         /* XXX: we omit GP_FRAME_PAINT here for now,
1647                          * as it is only really useful for doing
1648                          * paintbuffer drawing
1649                          */
1650                 }
1651                 
1652                 /* Ensure this gets set... */
1653                 p->gpf = p->gpl->actframe;
1654                 
1655                 /* Restrict eraser to only affecting selected strokes, if the "selection mask" is on
1656                  * (though this is only available in editmode)
1657                  */
1658                 if (p->gpd->flag & GP_DATA_STROKE_EDITMODE) {
1659                         if (ts->gp_sculpt.flag & GP_BRUSHEDIT_FLAG_SELECT_MASK) {
1660                                 p->flags |= GP_PAINTFLAG_SELECTMASK;
1661                         }
1662                 }
1663                 
1664                 if (has_layer_to_erase == false) {
1665                         p->status = GP_STATUS_ERROR;
1666                         //if (G.debug & G_DEBUG)
1667                                 printf("Error: Eraser will not be affecting anything (gpencil_paint_init)\n");
1668                         return;
1669                 }
1670         }
1671         else {
1672                 /* Drawing Modes - Add a new frame if needed on the active layer */
1673                 short add_frame_mode;
1674                 
1675                 if (ts->gpencil_flags & GP_TOOL_FLAG_RETAIN_LAST)
1676                         add_frame_mode = GP_GETFRAME_ADD_COPY;
1677                 else
1678                         add_frame_mode = GP_GETFRAME_ADD_NEW;
1679                         
1680                 p->gpf = BKE_gpencil_layer_getframe(p->gpl, CFRA, add_frame_mode);
1681                 
1682                 if (p->gpf == NULL) {
1683                         p->status = GP_STATUS_ERROR;
1684                         if (G.debug & G_DEBUG)
1685                                 printf("Error: No frame created (gpencil_paint_init)\n");
1686                         return;
1687                 }
1688                 else {
1689                         p->gpf->flag |= GP_FRAME_PAINT;
1690                 }
1691         }
1692         
1693         /* set 'eraser' for this stroke if using eraser */
1694         p->paintmode = paintmode;
1695         if (p->paintmode == GP_PAINTMODE_ERASER) {
1696                 p->gpd->sbuffer_sflag |= GP_STROKE_ERASER;
1697                 
1698                 /* check if we should respect depth while erasing */
1699                 if (p->sa->spacetype == SPACE_VIEW3D) {
1700                         if (p->gpl->flag & GP_LAYER_NO_XRAY) {
1701                                 p->flags |= GP_PAINTFLAG_V3D_ERASER_DEPTH;
1702                         }
1703                 }
1704         }
1705         else {
1706                 /* disable eraser flags - so that we can switch modes during a session */
1707                 p->gpd->sbuffer_sflag &= ~GP_STROKE_ERASER;
1708                 
1709                 if (p->sa->spacetype == SPACE_VIEW3D) {
1710                         if (p->gpl->flag & GP_LAYER_NO_XRAY) {
1711                                 p->flags &= ~GP_PAINTFLAG_V3D_ERASER_DEPTH;
1712                         }
1713                 }
1714         }
1715         
1716         /* set 'initial run' flag, which is only used to denote when a new stroke is starting */
1717         p->flags |= GP_PAINTFLAG_FIRSTRUN;
1718         
1719         
1720         /* when drawing in the camera view, in 2D space, set the subrect */
1721         p->subrect = NULL;
1722         if ((*p->align_flag & GP_PROJECT_VIEWSPACE) == 0) {
1723                 if (p->sa->spacetype == SPACE_VIEW3D) {
1724                         View3D *v3d = p->sa->spacedata.first;
1725                         RegionView3D *rv3d = p->ar->regiondata;
1726                         
1727                         /* for camera view set the subrect */
1728                         if (rv3d->persp == RV3D_CAMOB) {
1729                                 ED_view3d_calc_camera_border(p->scene, p->ar, v3d, rv3d, &p->subrect_data, true); /* no shift */
1730                                 p->subrect = &p->subrect_data;
1731                         }
1732                 }
1733         }
1734         
1735         /* init stroke point space-conversion settings... */
1736         p->gsc.gpd = p->gpd;
1737         p->gsc.gpl = p->gpl;
1738         
1739         p->gsc.sa = p->sa;
1740         p->gsc.ar = p->ar;
1741         p->gsc.v2d = p->v2d;
1742         
1743         p->gsc.subrect_data = p->subrect_data;
1744         p->gsc.subrect = p->subrect;
1745         
1746         copy_m4_m4(p->gsc.mat, p->mat);
1747         
1748         
1749         /* check if points will need to be made in view-aligned space */
1750         if (*p->align_flag & GP_PROJECT_VIEWSPACE) {
1751                 switch (p->sa->spacetype) {
1752                         case SPACE_VIEW3D:
1753                         {
1754                                 p->gpd->sbuffer_sflag |= GP_STROKE_3DSPACE;
1755                                 break;
1756                         }
1757                         case SPACE_NODE:
1758                         {
1759                                 p->gpd->sbuffer_sflag |= GP_STROKE_2DSPACE;
1760                                 break;
1761                         }
1762                         case SPACE_SEQ:
1763                         {
1764                                 p->gpd->sbuffer_sflag |= GP_STROKE_2DSPACE;
1765                                 break;
1766                         }
1767                         case SPACE_IMAGE:
1768                         {
1769                                 SpaceImage *sima = (SpaceImage *)p->sa->spacedata.first;
1770                                 
1771                                 /* only set these flags if the image editor doesn't have an image active,
1772                                  * otherwise user will be confused by strokes not appearing after they're drawn
1773                                  *
1774                                  * Admittedly, this is a bit hacky, but it works much nicer from an ergonomic standpoint!
1775                                  */
1776                                 if (ELEM(NULL, sima, sima->image)) {
1777                                         /* make strokes be drawn in screen space */
1778                                         p->gpd->sbuffer_sflag &= ~GP_STROKE_2DSPACE;
1779                                         *(p->align_flag) &= ~GP_PROJECT_VIEWSPACE;
1780                                 }
1781                                 else {
1782                                         p->gpd->sbuffer_sflag |= GP_STROKE_2DSPACE;
1783                                 }
1784                                 break;
1785                         }
1786                         case SPACE_CLIP:
1787                         {
1788                                 p->gpd->sbuffer_sflag |= GP_STROKE_2DSPACE;
1789                                 break;
1790                         }
1791                 }
1792         }
1793 }
1794
1795 /* finish off a stroke (clears buffer, but doesn't finish the paint operation) */
1796 static void gp_paint_strokeend(tGPsdata *p)
1797 {
1798         ToolSettings *ts = p->scene->toolsettings;
1799         /* for surface sketching, need to set the right OpenGL context stuff so that
1800          * the conversions will project the values correctly...
1801          */
1802         if (gpencil_project_check(p)) {
1803                 View3D *v3d = p->sa->spacedata.first;
1804                 
1805                 /* need to restore the original projection settings before packing up */
1806                 view3d_region_operator_needs_opengl(p->win, p->ar);
1807                 ED_view3d_autodist_init(p->scene, p->ar, v3d, (ts->gpencil_v3d_align & GP_PROJECT_DEPTH_STROKE) ? 1 : 0);
1808         }
1809         
1810         /* check if doing eraser or not */
1811         if ((p->gpd->sbuffer_sflag & GP_STROKE_ERASER) == 0) {
1812                 /* simplify stroke before transferring? */
1813                 gp_stroke_simplify(p);
1814                 
1815                 /* transfer stroke to frame */
1816                 gp_stroke_newfrombuffer(p);
1817         }
1818         
1819         /* clean up buffer now */
1820         gp_session_validatebuffer(p);
1821 }
1822
1823 /* finish off stroke painting operation */
1824 static void gp_paint_cleanup(tGPsdata *p)
1825 {
1826         /* p->gpd==NULL happens when stroke failed to initialize,
1827          * for example when GP is hidden in current space (sergey)
1828          */
1829         if (p->gpd) {
1830                 /* finish off a stroke */
1831                 gp_paint_strokeend(p);
1832         }
1833         
1834         /* "unlock" frame */
1835         if (p->gpf)
1836                 p->gpf->flag &= ~GP_FRAME_PAINT;
1837 }
1838
1839 /* ------------------------------- */
1840
1841 /* Helper callback for drawing the cursor itself */
1842 static void gpencil_draw_eraser(bContext *UNUSED(C), int x, int y, void *p_ptr)
1843 {
1844         tGPsdata *p = (tGPsdata *)p_ptr;
1845         
1846         if (p->paintmode == GP_PAINTMODE_ERASER) {
1847                 glPushMatrix();
1848                 
1849                 glTranslatef((float)x, (float)y, 0.0f);
1850                 
1851                 glEnable(GL_LINE_SMOOTH);
1852                 glEnable(GL_BLEND);
1853                 
1854                 glColor4ub(255, 100, 100, 20);
1855                 glutil_draw_filled_arc(0.0, M_PI * 2.0, p->radius, 40);
1856                 
1857                 setlinestyle(6);
1858                 
1859                 glColor4ub(255, 100, 100, 200);
1860                 glutil_draw_lined_arc(0.0, M_PI * 2.0, p->radius, 40);
1861                 
1862                 setlinestyle(0);
1863                 glDisable(GL_BLEND);
1864                 glDisable(GL_LINE_SMOOTH);
1865                 
1866                 glPopMatrix();
1867         }
1868 }
1869
1870 /* Turn brush cursor in 3D view on/off */
1871 static void gpencil_draw_toggle_eraser_cursor(bContext *C, tGPsdata *p, short enable)
1872 {
1873         if (p->erasercursor && !enable) {
1874                 /* clear cursor */
1875                 WM_paint_cursor_end(CTX_wm_manager(C), p->erasercursor);
1876                 p->erasercursor = NULL;
1877         }
1878         else if (enable && !p->erasercursor) {
1879                 /* enable cursor */
1880                 p->erasercursor = WM_paint_cursor_activate(CTX_wm_manager(C),
1881                                                            NULL, /* XXX */
1882                                                            gpencil_draw_eraser, p);
1883         }
1884 }
1885
1886 /* Check if tablet eraser is being used (when processing events) */
1887 static bool gpencil_is_tablet_eraser_active(const wmEvent *event)
1888 {
1889         if (event->tablet_data) {
1890                 const wmTabletData *wmtab = event->tablet_data;
1891                 return (wmtab->Active == EVT_TABLET_ERASER);
1892         }
1893         
1894         return false;
1895 }
1896
1897 /* ------------------------------- */
1898
1899 static void gpencil_draw_exit(bContext *C, wmOperator *op)
1900 {
1901         tGPsdata *p = op->customdata;
1902         
1903         /* clear undo stack */
1904         gpencil_undo_finish();
1905         
1906         /* restore cursor to indicate end of drawing */
1907         WM_cursor_modal_restore(CTX_wm_window(C));
1908         
1909         /* don't assume that operator data exists at all */
1910         if (p) {
1911                 /* check size of buffer before cleanup, to determine if anything happened here */
1912                 if (p->paintmode == GP_PAINTMODE_ERASER) {
1913                         /* turn off radial brush cursor */
1914                         gpencil_draw_toggle_eraser_cursor(C, p, false);
1915                 }
1916
1917                 /* always store the new eraser size to be used again next time
1918                  * NOTE: Do this even when not in eraser mode, as eraser may
1919                  *       have been toggled at some point.
1920                  */
1921                 U.gp_eraser = p->radius;
1922                 
1923                 /* cleanup */
1924                 gp_paint_cleanup(p);
1925                 gp_session_cleanup(p);
1926                 
1927                 /* finally, free the temp data */
1928                 MEM_freeN(p);
1929         }
1930         
1931         op->customdata = NULL;
1932 }
1933
1934 static void gpencil_draw_cancel(bContext *C, wmOperator *op)
1935 {
1936         /* this is just a wrapper around exit() */
1937         gpencil_draw_exit(C, op);
1938 }
1939
1940 /* ------------------------------- */
1941
1942
1943 static int gpencil_draw_init(bContext *C, wmOperator *op)
1944 {
1945         tGPsdata *p;
1946         eGPencil_PaintModes paintmode = RNA_enum_get(op->ptr, "mode");
1947         
1948         /* check context */
1949         p = op->customdata = gp_session_initpaint(C);
1950         if ((p == NULL) || (p->status == GP_STATUS_ERROR)) {
1951                 /* something wasn't set correctly in context */
1952                 gpencil_draw_exit(C, op);
1953                 return 0;
1954         }
1955         
1956         /* init painting data */
1957         gp_paint_initstroke(p, paintmode);
1958         if (p->status == GP_STATUS_ERROR) {
1959                 gpencil_draw_exit(C, op);
1960                 return 0;
1961         }
1962         
1963         /* everything is now setup ok */
1964         return 1;
1965 }
1966
1967
1968 /* ------------------------------- */
1969
1970 /* ensure that the correct cursor icon is set */
1971 static void gpencil_draw_cursor_set(tGPsdata *p)
1972 {
1973         if (p->paintmode == GP_PAINTMODE_ERASER)
1974                 WM_cursor_modal_set(p->win, BC_CROSSCURSOR);  /* XXX need a better cursor */
1975         else
1976                 WM_cursor_modal_set(p->win, BC_PAINTBRUSHCURSOR);
1977 }
1978
1979 /* update UI indicators of status, including cursor and header prints */
1980 static void gpencil_draw_status_indicators(tGPsdata *p)
1981 {
1982         /* header prints */
1983         switch (p->status) {
1984                 case GP_STATUS_PAINTING:
1985                         /* only print this for paint-sessions, otherwise it gets annoying */
1986                         if (GPENCIL_SKETCH_SESSIONS_ON(p->scene))
1987                                 ED_area_headerprint(p->sa, IFACE_("Grease Pencil: Drawing/erasing stroke... Release to end stroke"));
1988                         break;
1989                 
1990                 case GP_STATUS_IDLING:
1991                         /* print status info */
1992                         switch (p->paintmode) {
1993                                 case GP_PAINTMODE_ERASER:
1994                                         ED_area_headerprint(p->sa, IFACE_("Grease Pencil Erase Session: Hold and drag LMB or RMB to erase | "
1995                                                                           "ESC/Enter to end  (or click outside this area)"));
1996                                         break;
1997                                 case GP_PAINTMODE_DRAW_STRAIGHT:
1998                                         ED_area_headerprint(p->sa, IFACE_("Grease Pencil Line Session: Hold and drag LMB to draw | "
1999                                                                           "ESC/Enter to end  (or click outside this area)"));
2000                                         break;
2001                                 case GP_PAINTMODE_DRAW:
2002                                         ED_area_headerprint(p->sa, IFACE_("Grease Pencil Freehand Session: Hold and drag LMB to draw | "
2003                                                                           "E/ESC/Enter to end  (or click outside this area)"));
2004                                         break;
2005                                 case GP_PAINTMODE_DRAW_POLY:
2006                                         ED_area_headerprint(p->sa, IFACE_("Grease Pencil Poly Session: LMB click to place next stroke vertex | "
2007                                                                           "ESC/Enter to end  (or click outside this area)"));
2008                                         break;
2009                                 
2010                                 default: /* unhandled future cases */
2011                                         ED_area_headerprint(p->sa, IFACE_("Grease Pencil Session: ESC/Enter to end   (or click outside this area)"));
2012                                         break;
2013                         }
2014                         break;
2015                 
2016                 case GP_STATUS_ERROR:
2017                 case GP_STATUS_DONE:
2018                         /* clear status string */
2019                         ED_area_headerprint(p->sa, NULL);
2020                         break;
2021         }
2022 }
2023
2024 /* ------------------------------- */
2025
2026 /* create a new stroke point at the point indicated by the painting context */
2027 static void gpencil_draw_apply(wmOperator *op, tGPsdata *p)
2028 {
2029         /* handle drawing/erasing -> test for erasing first */
2030         if (p->paintmode == GP_PAINTMODE_ERASER) {
2031                 /* do 'live' erasing now */
2032                 gp_stroke_doeraser(p);
2033                 
2034                 /* store used values */
2035                 p->mvalo[0] = p->mval[0];
2036                 p->mvalo[1] = p->mval[1];
2037                 p->opressure = p->pressure;
2038         }
2039         /* only add current point to buffer if mouse moved (even though we got an event, it might be just noise) */
2040         else if (gp_stroke_filtermval(p, p->mval, p->mvalo)) {
2041                 /* try to add point */
2042                 short ok = gp_stroke_addpoint(p, p->mval, p->pressure, p->curtime);
2043                 
2044                 /* handle errors while adding point */
2045                 if ((ok == GP_STROKEADD_FULL) || (ok == GP_STROKEADD_OVERFLOW)) {
2046                         /* finish off old stroke */
2047                         gp_paint_strokeend(p);
2048                         /* And start a new one!!! Else, projection errors! */
2049                         gp_paint_initstroke(p, p->paintmode);
2050                         
2051                         /* start a new stroke, starting from previous point */
2052                         /* XXX Must manually reset inittime... */
2053                         /* XXX We only need to reuse previous point if overflow! */
2054                         if (ok == GP_STROKEADD_OVERFLOW) {
2055                                 p->inittime = p->ocurtime;
2056                                 gp_stroke_addpoint(p, p->mvalo, p->opressure, p->ocurtime);
2057                         }
2058                         else {
2059                                 p->inittime = p->curtime;
2060                         }
2061                         gp_stroke_addpoint(p, p->mval, p->pressure, p->curtime);
2062                 }
2063                 else if (ok == GP_STROKEADD_INVALID) {
2064                         /* the painting operation cannot continue... */
2065                         BKE_report(op->reports, RPT_ERROR, "Cannot paint stroke");
2066                         p->status = GP_STATUS_ERROR;
2067                         
2068                         if (G.debug & G_DEBUG)
2069                                 printf("Error: Grease-Pencil Paint - Add Point Invalid\n");
2070                         return;
2071                 }
2072                 
2073                 /* store used values */
2074                 p->mvalo[0] = p->mval[0];
2075                 p->mvalo[1] = p->mval[1];
2076                 p->opressure = p->pressure;
2077                 p->ocurtime = p->curtime;
2078         }
2079 }
2080
2081 /* handle draw event */
2082 static void gpencil_draw_apply_event(wmOperator *op, const wmEvent *event)
2083 {
2084         tGPsdata *p = op->customdata;
2085         PointerRNA itemptr;
2086         float mousef[2];
2087         int tablet = 0;
2088         
2089         /* convert from window-space to area-space mouse coordinates
2090          * NOTE: float to ints conversions, +1 factor is probably used to ensure a bit more accurate rounding...
2091          */
2092         p->mval[0] = event->mval[0] + 1;
2093         p->mval[1] = event->mval[1] + 1;
2094         
2095         /* verify key status for straight lines */
2096         if ((event->ctrl > 0) || (event->alt > 0)) {
2097                 if (p->straight[0] == 0) {
2098                         int dx = abs(p->mval[0] - p->mvalo[0]);
2099                         int dy = abs(p->mval[1] - p->mvalo[1]);
2100                         if ((dx > 0) || (dy > 0)) {
2101                                 /* check mouse direction to replace the other coordinate with previous values */
2102                                 if (dx >= dy) {
2103                                         /* horizontal */
2104                                         p->straight[0] = 1;
2105                                         p->straight[1] = p->mval[1]; /* save y */
2106                                 }
2107                                 else {
2108                                         /* vertical */
2109                                         p->straight[0] = 2;
2110                                         p->straight[1] = p->mval[0]; /* save x */
2111                                 }
2112                         }
2113                 }
2114         }
2115         else {
2116                 p->straight[0] = 0;
2117         }
2118
2119         p->curtime = PIL_check_seconds_timer();
2120         
2121         /* handle pressure sensitivity (which is supplied by tablets) */
2122         if (event->tablet_data) {
2123                 const wmTabletData *wmtab = event->tablet_data;
2124                 
2125                 tablet = (wmtab->Active != EVT_TABLET_NONE);
2126                 p->pressure = wmtab->Pressure;
2127                 
2128                 /* Hack for pressure sensitive eraser on D+RMB when using a tablet:
2129                  *  The pen has to float over the tablet surface, resulting in
2130                  *  zero pressure (T47101). Ignore pressure values if floating
2131                  *  (i.e. "effectively zero" pressure), and only when the "active"
2132                  *  end is the stylus (i.e. the default when not eraser)
2133                  */
2134                 if (p->paintmode == GP_PAINTMODE_ERASER) {
2135                         if ((wmtab->Active != EVT_TABLET_ERASER) && (p->pressure < 0.001f)) {
2136                                 p->pressure = 1.0f;
2137                         }
2138                 }
2139         }
2140         else {
2141                 /* No tablet data -> No pressure info is available */
2142                 p->pressure = 1.0f;
2143         }
2144         
2145         /* special exception for start of strokes (i.e. maybe for just a dot) */
2146         if (p->flags & GP_PAINTFLAG_FIRSTRUN) {
2147                 p->flags &= ~GP_PAINTFLAG_FIRSTRUN;
2148                 
2149                 p->mvalo[0] = p->mval[0];
2150                 p->mvalo[1] = p->mval[1];
2151                 p->opressure = p->pressure;
2152                 p->inittime = p->ocurtime = p->curtime;
2153                 p->straight[0] = 0;
2154                 p->straight[1] = 0;
2155
2156                 /* special exception here for too high pressure values on first touch in
2157                  *  windows for some tablets, then we just skip first touch...
2158                  */
2159                 if (tablet && (p->pressure >= 0.99f))
2160                         return;
2161         }
2162         
2163         /* check if alt key is pressed and limit to straight lines */
2164         if (p->straight[0] != 0) {
2165                 if (p->straight[0] == 1) {
2166                         /* horizontal */
2167                         p->mval[1] = p->straight[1]; /* replace y */
2168                 }
2169                 else {
2170                         /* vertical */
2171                         p->mval[0] = p->straight[1]; /* replace x */
2172                 }
2173         }
2174
2175         /* fill in stroke data (not actually used directly by gpencil_draw_apply) */
2176         RNA_collection_add(op->ptr, "stroke", &itemptr);
2177         
2178         mousef[0] = p->mval[0];
2179         mousef[1] = p->mval[1];
2180         RNA_float_set_array(&itemptr, "mouse", mousef);
2181         RNA_float_set(&itemptr, "pressure", p->pressure);
2182         RNA_boolean_set(&itemptr, "is_start", (p->flags & GP_PAINTFLAG_FIRSTRUN) != 0);
2183         
2184         RNA_float_set(&itemptr, "time", p->curtime - p->inittime);
2185         
2186         /* apply the current latest drawing point */
2187         gpencil_draw_apply(op, p);
2188         
2189         /* force refresh */
2190         ED_region_tag_redraw(p->ar); /* just active area for now, since doing whole screen is too slow */
2191 }
2192
2193 /* ------------------------------- */
2194
2195 /* operator 'redo' (i.e. after changing some properties, but also for repeat last) */
2196 static int gpencil_draw_exec(bContext *C, wmOperator *op)
2197 {
2198         tGPsdata *p = NULL;
2199         
2200         /* printf("GPencil - Starting Re-Drawing\n"); */
2201         
2202         /* try to initialize context data needed while drawing */
2203         if (!gpencil_draw_init(C, op)) {
2204                 if (op->customdata) MEM_freeN(op->customdata);
2205                 /* printf("\tGP - no valid data\n"); */
2206                 return OPERATOR_CANCELLED;
2207         }
2208         else
2209                 p = op->customdata;
2210         
2211         /* printf("\tGP - Start redrawing stroke\n"); */
2212         
2213         /* loop over the stroke RNA elements recorded (i.e. progress of mouse movement),
2214          * setting the relevant values in context at each step, then applying
2215          */
2216         RNA_BEGIN (op->ptr, itemptr, "stroke")
2217         {
2218                 float mousef[2];
2219                 
2220                 /* printf("\t\tGP - stroke elem\n"); */
2221                 
2222                 /* get relevant data for this point from stroke */
2223                 RNA_float_get_array(&itemptr, "mouse", mousef);
2224                 p->mval[0] = (int)mousef[0];
2225                 p->mval[1] = (int)mousef[1];
2226                 p->pressure = RNA_float_get(&itemptr, "pressure");
2227                 p->curtime = (double)RNA_float_get(&itemptr, "time") + p->inittime;
2228                 
2229                 if (RNA_boolean_get(&itemptr, "is_start")) {
2230                         /* if first-run flag isn't set already (i.e. not true first stroke),
2231                          * then we must terminate the previous one first before continuing
2232                          */
2233                         if ((p->flags & GP_PAINTFLAG_FIRSTRUN) == 0) {
2234                                 /* TODO: both of these ops can set error-status, but we probably don't need to worry */
2235                                 gp_paint_strokeend(p);
2236                                 gp_paint_initstroke(p, p->paintmode);
2237                         }
2238                 }
2239                 
2240                 /* if first run, set previous data too */
2241                 if (p->flags & GP_PAINTFLAG_FIRSTRUN) {
2242                         p->flags &= ~GP_PAINTFLAG_FIRSTRUN;
2243                         
2244                         p->mvalo[0] = p->mval[0];
2245                         p->mvalo[1] = p->mval[1];
2246                         p->opressure = p->pressure;
2247                         p->ocurtime = p->curtime;
2248                 }
2249                 
2250                 /* apply this data as necessary now (as per usual) */
2251                 gpencil_draw_apply(op, p);
2252         }
2253         RNA_END;
2254                 
2255         /* printf("\tGP - done\n"); */
2256         
2257         /* cleanup */
2258         gpencil_draw_exit(C, op);
2259         
2260         /* refreshes */
2261         WM_event_add_notifier(C, NC_GPENCIL | NA_EDITED, NULL);
2262         
2263         /* done */
2264         return OPERATOR_FINISHED;
2265 }
2266
2267 /* ------------------------------- */
2268
2269 /* start of interactive drawing part of operator */
2270 static int gpencil_draw_invoke(bContext *C, wmOperator *op, const wmEvent *event)
2271 {
2272         tGPsdata *p = NULL;
2273         
2274         if (G.debug & G_DEBUG)
2275                 printf("GPencil - Starting Drawing\n");
2276         
2277         /* try to initialize context data needed while drawing */
2278         if (!gpencil_draw_init(C, op)) {
2279                 if (op->customdata)
2280                         MEM_freeN(op->customdata);
2281                 if (G.debug & G_DEBUG)
2282                         printf("\tGP - no valid data\n");
2283                 return OPERATOR_CANCELLED;
2284         }
2285         else
2286                 p = op->customdata;
2287         
2288         /* TODO: set any additional settings that we can take from the events?
2289          * TODO? if tablet is erasing, force eraser to be on? */
2290         
2291         /* TODO: move cursor setting stuff to stroke-start so that paintmode can be changed midway... */
2292         
2293         /* if eraser is on, draw radial aid */
2294         if (p->paintmode == GP_PAINTMODE_ERASER) {
2295                 gpencil_draw_toggle_eraser_cursor(C, p, true);
2296         }
2297         /* set cursor 
2298          * NOTE: This may change later (i.e. intentionally via brush toggle,
2299          *       or unintentionally if the user scrolls outside the area)...
2300          */
2301         gpencil_draw_cursor_set(p);
2302
2303         /* only start drawing immediately if we're allowed to do so... */
2304         if (RNA_boolean_get(op->ptr, "wait_for_input") == false) {
2305                 /* hotkey invoked - start drawing */
2306                 /* printf("\tGP - set first spot\n"); */
2307                 p->status = GP_STATUS_PAINTING;
2308
2309                 /* handle the initial drawing - i.e. for just doing a simple dot */
2310                 gpencil_draw_apply_event(op, event);
2311                 op->flag |= OP_IS_MODAL_CURSOR_REGION;
2312         }
2313         else {
2314                 /* toolbar invoked - don't start drawing yet... */
2315                 /* printf("\tGP - hotkey invoked... waiting for click-drag\n"); */
2316                 op->flag |= OP_IS_MODAL_CURSOR_REGION;
2317         }
2318         
2319         WM_event_add_notifier(C, NC_GPENCIL | NA_EDITED, NULL);
2320         /* add a modal handler for this operator, so that we can then draw continuous strokes */
2321         WM_event_add_modal_handler(C, op);
2322         return OPERATOR_RUNNING_MODAL;
2323 }
2324
2325 /* gpencil modal operator stores area, which can be removed while using it (like fullscreen) */
2326 static bool gpencil_area_exists(bContext *C, ScrArea *sa_test)
2327 {
2328         bScreen *sc = CTX_wm_screen(C);
2329         return (BLI_findindex(&sc->areabase, sa_test) != -1);
2330 }
2331
2332 static tGPsdata *gpencil_stroke_begin(bContext *C, wmOperator *op)
2333 {
2334         tGPsdata *p = op->customdata;
2335         
2336         /* we must check that we're still within the area that we're set up to work from
2337          * otherwise we could crash (see bug #20586)
2338          */
2339         if (CTX_wm_area(C) != p->sa) {
2340                 printf("\t\t\tGP - wrong area execution abort!\n");
2341                 p->status = GP_STATUS_ERROR;
2342         }
2343         
2344         /* printf("\t\tGP - start stroke\n"); */
2345         
2346         /* we may need to set up paint env again if we're resuming */
2347         /* XXX: watch it with the paintmode! in future,
2348          *      it'd be nice to allow changing paint-mode when in sketching-sessions */
2349         
2350         if (gp_session_initdata(C, p))
2351                 gp_paint_initstroke(p, p->paintmode);
2352         
2353         if (p->status != GP_STATUS_ERROR) {
2354                 p->status = GP_STATUS_PAINTING;
2355                 op->flag &= ~OP_IS_MODAL_CURSOR_REGION;
2356         }
2357         
2358         return op->customdata;
2359 }
2360
2361 static void gpencil_stroke_end(wmOperator *op)
2362 {
2363         tGPsdata *p = op->customdata;
2364         
2365         gp_paint_cleanup(p);
2366         
2367         gpencil_undo_push(p->gpd);
2368         
2369         gp_session_cleanup(p);
2370         
2371         p->status = GP_STATUS_IDLING;
2372         op->flag |= OP_IS_MODAL_CURSOR_REGION;
2373         
2374         p->gpd = NULL;
2375         p->gpl = NULL;
2376         p->gpf = NULL;
2377 }
2378
2379 /* Move last stroke in the listbase to the head to be drawn below all previous strokes in the layer */
2380 static void gpencil_move_last_stroke_to_back(bContext *C)
2381 {
2382         /* move last stroke (the polygon) to head of the listbase stroke to draw on back of all previous strokes */
2383         bGPdata *gpd = ED_gpencil_data_get_active(C);
2384         bGPDlayer *gpl = BKE_gpencil_layer_getactive(gpd);
2385
2386         /* sanity checks */
2387         if (ELEM(NULL, gpd, gpl, gpl->actframe)) {
2388                 return;
2389         }
2390
2391         bGPDframe *gpf = gpl->actframe;
2392         bGPDstroke *gps = gpf->strokes.last;
2393         if (ELEM(NULL, gps)) {
2394                 return;
2395         }
2396
2397         BLI_remlink(&gpf->strokes, gps);
2398         BLI_insertlinkbefore(&gpf->strokes, gpf->strokes.first, gps);
2399 }
2400
2401 /* events handling during interactive drawing part of operator */
2402 static int gpencil_draw_modal(bContext *C, wmOperator *op, const wmEvent *event)
2403 {
2404         tGPsdata *p = op->customdata;
2405         ToolSettings *ts = CTX_data_tool_settings(C);
2406         int estate = OPERATOR_PASS_THROUGH; /* default exit state - pass through to support MMB view nav, etc. */
2407         
2408         /* if (event->type == NDOF_MOTION)
2409          *    return OPERATOR_PASS_THROUGH;
2410          * -------------------------------
2411          * [mce] Not quite what I was looking
2412          * for, but a good start! GP continues to
2413          * draw on the screen while the 3D mouse
2414          * moves the viewpoint. Problem is that
2415          * the stroke is converted to 3D only after
2416          * it is finished. This approach should work
2417          * better in tools that immediately apply
2418          * in 3D space.
2419          */
2420         
2421         if (p->status == GP_STATUS_IDLING) {
2422                 ARegion *ar = CTX_wm_region(C);
2423                 p->ar = ar;
2424         }
2425
2426         /* we don't pass on key events, GP is used with key-modifiers - prevents Dkey to insert drivers */
2427         if (ISKEYBOARD(event->type)) {
2428                 if (ELEM(event->type, LEFTARROWKEY, DOWNARROWKEY, RIGHTARROWKEY, UPARROWKEY, ZKEY)) {
2429                         /* allow some keys:
2430                          *   - for frame changing [#33412]
2431                          *   - for undo (during sketching sessions)
2432                          */
2433                 }
2434                 else if (ELEM(event->type, PAD0, PAD1, PAD2, PAD3, PAD4, PAD5, PAD6, PAD7, PAD8, PAD9)) {
2435                         /* allow numpad keys so that camera/view manipulations can still take place
2436                          * - PAD0 in particular is really important for Grease Pencil drawing,
2437                          *   as animators may be working "to camera", so having this working
2438                          *   is essential for ensuring that they can quickly return to that view
2439                          */
2440                 }
2441                 else if ((ELEM(event->type, DKEY)) && (event->val == KM_RELEASE)) {
2442                         /* enable continuous if release D key in mid drawing */
2443                         p->scene->toolsettings->gpencil_flags |= GP_TOOL_FLAG_PAINTSESSIONS_ON;
2444                 }
2445                 else if ((event->type == BKEY) && (event->val == KM_RELEASE)) {
2446                         /* Add Blank Frame
2447                          * - Since this operator is non-modal, we can just call it here, and keep going...
2448                  * - This operator is especially useful when animating
2449                          */
2450                         WM_operator_name_call(C, "GPENCIL_OT_blank_frame_add", WM_OP_EXEC_DEFAULT, NULL);
2451                         estate = OPERATOR_RUNNING_MODAL;
2452                 }
2453                 else {
2454                         estate = OPERATOR_RUNNING_MODAL;
2455                 }
2456         }
2457         
2458         //printf("\tGP - handle modal event...\n");
2459         
2460         /* exit painting mode (and/or end current stroke)
2461          * NOTE: cannot do RIGHTMOUSE (as is standard for canceling) as that would break polyline [#32647]
2462          */
2463         if (ELEM(event->type, RETKEY, PADENTER, ESCKEY, SPACEKEY, EKEY)) {
2464                 /* exit() ends the current stroke before cleaning up */
2465                 /* printf("\t\tGP - end of paint op + end of stroke\n"); */
2466                 /* if drawing polygon and enable on back, must move stroke */
2467                 if (ts) {
2468                         if ((ts->gpencil_flags & GP_TOOL_FLAG_PAINT_ONBACK) && (p->paintmode == GP_PAINTMODE_DRAW_POLY)) {
2469                                 if (p->flags & GP_PAINTFLAG_STROKEADDED) {
2470                                         gpencil_move_last_stroke_to_back(C);
2471                                 }
2472                         }
2473                 }
2474                 p->status = GP_STATUS_DONE;
2475                 estate = OPERATOR_FINISHED;
2476         }
2477         
2478         /* toggle painting mode upon mouse-button movement
2479          *  - LEFTMOUSE  = standard drawing (all) / straight line drawing (all) / polyline (toolbox only)
2480          *  - RIGHTMOUSE = polyline (hotkey) / eraser (all)
2481          *    (Disabling RIGHTMOUSE case here results in bugs like [#32647])
2482          * also making sure we have a valid event value, to not exit too early
2483          */
2484         if (ELEM(event->type, LEFTMOUSE, RIGHTMOUSE) && (event->val != KM_NOTHING)) {
2485                 /* if painting, end stroke */
2486                 if (p->status == GP_STATUS_PAINTING) {
2487                         int sketch = 0;
2488                         
2489                         /* basically, this should be mouse-button up = end stroke
2490                          * BUT what happens next depends on whether we 'painting sessions' is enabled
2491                          */
2492                         sketch |= GPENCIL_SKETCH_SESSIONS_ON(p->scene);
2493                         /* polyline drawing is also 'sketching' -- all knots should be added during one session */
2494                         sketch |= (p->paintmode == GP_PAINTMODE_DRAW_POLY);
2495                         
2496                         if (sketch) {
2497                                 /* end stroke only, and then wait to resume painting soon */
2498                                 /* printf("\t\tGP - end stroke only\n"); */
2499                                 gpencil_stroke_end(op);
2500                                 
2501                                 /* If eraser mode is on, turn it off after the stroke finishes
2502                                  * NOTE: This just makes it nicer to work with drawing sessions
2503                                  */
2504                                 if (p->paintmode == GP_PAINTMODE_ERASER) {
2505                                         p->paintmode = RNA_enum_get(op->ptr, "mode");
2506                                         
2507                                         /* if the original mode was *still* eraser,
2508                                          * we'll let it say for now, since this gives
2509                                          * users an opportunity to have visual feedback
2510                                          * when adjusting eraser size
2511                                          */
2512                                         if (p->paintmode != GP_PAINTMODE_ERASER) {      
2513                                                 /* turn off cursor...
2514                                                  * NOTE: this should be enough for now
2515                                                  *       Just hiding this makes it seem like
2516                                                  *       you can paint again...
2517                                                  */
2518                                                 gpencil_draw_toggle_eraser_cursor(C, p, false);
2519                                         }
2520                                 }
2521                                 
2522                                 /* we've just entered idling state, so this event was processed (but no others yet) */
2523                                 estate = OPERATOR_RUNNING_MODAL;
2524                                 
2525                                 /* stroke could be smoothed, send notifier to refresh screen */
2526                                 WM_event_add_notifier(C, NC_GPENCIL | NA_EDITED, NULL);
2527                         }
2528                         else {
2529                                 /* printf("\t\tGP - end of stroke + op\n"); */
2530                                 /* if drawing polygon and enable on back, must move stroke */
2531                                 if (ts) {
2532                                         if ((ts->gpencil_flags & GP_TOOL_FLAG_PAINT_ONBACK) && (p->paintmode == GP_PAINTMODE_DRAW_POLY)) {
2533                                                 if (p->flags & GP_PAINTFLAG_STROKEADDED) {
2534                                                         gpencil_move_last_stroke_to_back(C);
2535                                                 }
2536                                         }
2537                                 }
2538                                 p->status = GP_STATUS_DONE;
2539                                 estate = OPERATOR_FINISHED;
2540                         }
2541                 }
2542                 else if (event->val == KM_PRESS) {
2543                         bool in_bounds = false;
2544                         
2545                         /* Check if we're outside the bounds of the active region
2546                          * NOTE: An exception here is that if launched from the toolbar,
2547                          *       whatever region we're now in should become the new region
2548                          */
2549                         if ((p->ar) && (p->ar->regiontype == RGN_TYPE_TOOLS)) {
2550                                 /* Change to whatever region is now under the mouse */
2551                                 ARegion *current_region = BKE_area_find_region_xy(p->sa, RGN_TYPE_ANY, event->x, event->y);
2552                                 
2553                                 if (G.debug & G_DEBUG) {
2554                                         printf("found alternative region %p (old was %p) - at %d %d (sa: %d %d -> %d %d)\n",
2555                                                 current_region, p->ar, event->x, event->y,
2556                                                 p->sa->totrct.xmin, p->sa->totrct.ymin, p->sa->totrct.xmax, p->sa->totrct.ymax);
2557                                 }
2558                                 
2559                                 if (current_region) {
2560                                         /* Assume that since we found the cursor in here, it is in bounds
2561                                          * and that this should be the region that we begin drawing in
2562                                          */
2563                                         p->ar = current_region;
2564                                         in_bounds = true;
2565                                 }
2566                                 else {
2567                                         /* Out of bounds, or invalid in some other way */
2568                                         p->status = GP_STATUS_ERROR;
2569                                         estate = OPERATOR_CANCELLED;
2570                                         
2571                                         if (G.debug & G_DEBUG)
2572                                                 printf("%s: Region under cursor is out of bounds, so cannot be drawn on\n", __func__);
2573                                 }
2574                         }
2575                         else if (p->ar) {
2576                                 rcti region_rect;
2577                                 
2578                                 /* Perform bounds check using  */
2579                                 ED_region_visible_rect(p->ar, &region_rect);
2580                                 in_bounds = BLI_rcti_isect_pt_v(&region_rect, event->mval);
2581                         }
2582                         else {
2583                                 /* No region */
2584                                 p->status = GP_STATUS_ERROR;
2585                                 estate = OPERATOR_CANCELLED;
2586                                 
2587                                 if (G.debug & G_DEBUG)
2588                                         printf("%s: No active region found in GP Paint session data\n", __func__);
2589                         }
2590                         
2591                         if (in_bounds) {
2592                                 /* Switch paintmode (temporarily if need be) based on which button was used
2593                                  * NOTE: This is to make it more convenient to erase strokes when using drawing sessions
2594                                  */
2595                                 if ((event->type == RIGHTMOUSE) || gpencil_is_tablet_eraser_active(event)) {
2596                                         /* turn on eraser */
2597                                         p->paintmode = GP_PAINTMODE_ERASER;
2598                                 }
2599                                 else if (event->type == LEFTMOUSE) {
2600                                         /* restore drawmode to default */
2601                                         p->paintmode = RNA_enum_get(op->ptr, "mode");
2602                                 }
2603                                 
2604                                 gpencil_draw_toggle_eraser_cursor(C, p, p->paintmode == GP_PAINTMODE_ERASER);
2605                                 
2606                                 /* not painting, so start stroke (this should be mouse-button down) */
2607                                 p = gpencil_stroke_begin(C, op);
2608                                 
2609                                 if (p->status == GP_STATUS_ERROR) {
2610                                         estate = OPERATOR_CANCELLED;
2611                                 }
2612                         }
2613                         else if (p->status != GP_STATUS_ERROR) {
2614                                 /* User clicked outside bounds of window while idling, so exit paintmode 
2615                                  * NOTE: Don't enter this case if an error occurred while finding the
2616                                  *       region (as above)
2617                                  */
2618                                 /* if drawing polygon and enable on back, must move stroke */
2619                                 if (ts) {
2620                                         if ((ts->gpencil_flags & GP_TOOL_FLAG_PAINT_ONBACK) && (p->paintmode == GP_PAINTMODE_DRAW_POLY)) {
2621                                                 if (p->flags & GP_PAINTFLAG_STROKEADDED) {
2622                                                         gpencil_move_last_stroke_to_back(C);
2623                                                 }
2624                                         }
2625                                 }
2626                                 p->status = GP_STATUS_DONE;
2627                                 estate = OPERATOR_FINISHED;
2628                         }
2629                 }
2630                 else {
2631                         p->status = GP_STATUS_IDLING;
2632                         op->flag |= OP_IS_MODAL_CURSOR_REGION;
2633                 }
2634         }
2635         
2636         /* handle mode-specific events */
2637         if (p->status == GP_STATUS_PAINTING) {
2638                 /* handle painting mouse-movements? */
2639                 if (ELEM(event->type, MOUSEMOVE, INBETWEEN_MOUSEMOVE) || (p->flags & GP_PAINTFLAG_FIRSTRUN)) {
2640                         /* handle drawing event */
2641                         /* printf("\t\tGP - add point\n"); */
2642                         gpencil_draw_apply_event(op, event);
2643                         
2644                         /* finish painting operation if anything went wrong just now */
2645                         if (p->status == GP_STATUS_ERROR) {
2646                                 printf("\t\t\t\tGP - add error done!\n");
2647                                 estate = OPERATOR_CANCELLED;
2648                         }
2649                         else {
2650                                 /* event handled, so just tag as running modal */
2651                                 /* printf("\t\t\t\tGP - add point handled!\n"); */
2652                                 estate = OPERATOR_RUNNING_MODAL;
2653                         }
2654                 }
2655                 /* eraser size */
2656                 else if ((p->paintmode == GP_PAINTMODE_ERASER) &&
2657                          ELEM(event->type, WHEELUPMOUSE, WHEELDOWNMOUSE, PADPLUSKEY, PADMINUS))
2658                 {
2659                         /* just resize the brush (local version)
2660                          * TODO: fix the hardcoded size jumps (set to make a visible difference) and hardcoded keys
2661                          */
2662                         /* printf("\t\tGP - resize eraser\n"); */
2663                         switch (event->type) {
2664                                 case WHEELDOWNMOUSE: /* larger */
2665                                 case PADPLUSKEY:
2666                                         p->radius += 5;
2667                                         break;
2668                                 
2669                                 case WHEELUPMOUSE: /* smaller */
2670                                 case PADMINUS:
2671                                         p->radius -= 5;
2672                                         
2673                                         if (p->radius <= 0)
2674                                                 p->radius = 1;
2675                                         break;
2676                         }
2677                         
2678                         /* force refresh */
2679                         ED_region_tag_redraw(p->ar); /* just active area for now, since doing whole screen is too slow */
2680                         
2681                         /* event handled, so just tag as running modal */
2682                         estate = OPERATOR_RUNNING_MODAL;
2683                 }
2684                 /* there shouldn't be any other events, but just in case there are, let's swallow them
2685                  * (i.e. to prevent problems with undo)
2686                  */
2687                 else {
2688                         /* swallow event to save ourselves trouble */
2689                         estate = OPERATOR_RUNNING_MODAL;
2690                 }
2691         }
2692         
2693         /* gpencil modal operator stores area, which can be removed while using it (like fullscreen) */
2694         if (0 == gpencil_area_exists(C, p->sa))
2695                 estate = OPERATOR_CANCELLED;
2696         else {
2697                 /* update status indicators - cursor, header, etc. */
2698                 gpencil_draw_status_indicators(p);
2699                 gpencil_draw_cursor_set(p); /* cursor may have changed outside our control - T44084 */
2700         }
2701         
2702         /* process last operations before exiting */
2703         switch (estate) {
2704                 case OPERATOR_FINISHED:
2705                         /* one last flush before we're done */
2706                         gpencil_draw_exit(C, op);
2707                         WM_event_add_notifier(C, NC_GPENCIL | NA_EDITED, NULL);
2708                         break;
2709                 
2710                 case OPERATOR_CANCELLED:
2711                         gpencil_draw_exit(C, op);
2712                         break;
2713                 
2714                 case OPERATOR_RUNNING_MODAL | OPERATOR_PASS_THROUGH:
2715                         /* event doesn't need to be handled */
2716 #if 0
2717                         printf("unhandled event -> %d (mmb? = %d | mmv? = %d)\n",
2718                                event->type, event->type == MIDDLEMOUSE, event->type==MOUSEMOVE);
2719 #endif
2720                         break;
2721         }
2722         
2723         /* return status code */
2724         return estate;
2725 }
2726
2727 /* ------------------------------- */
2728
2729 static EnumPropertyItem prop_gpencil_drawmodes[] = {
2730         {GP_PAINTMODE_DRAW, "DRAW", 0, "Draw Freehand", "Draw freehand stroke(s)"},
2731         {GP_PAINTMODE_DRAW_STRAIGHT, "DRAW_STRAIGHT", 0, "Draw Straight Lines", "Draw straight line segment(s)"},
2732         {GP_PAINTMODE_DRAW_POLY, "DRAW_POLY", 0, "Draw Poly Line", "Click to place endpoints of straight line segments (connected)"},
2733         {GP_PAINTMODE_ERASER, "ERASER", 0, "Eraser", "Erase Grease Pencil strokes"},
2734         {0, NULL, 0, NULL, NULL}
2735 };
2736
2737 void GPENCIL_OT_draw(wmOperatorType *ot)
2738 {
2739         /* identifiers */
2740         ot->name = "Grease Pencil Draw";
2741         ot->idname = "GPENCIL_OT_draw";
2742         ot->description = "Make annotations on the active data";
2743         
2744         /* api callbacks */
2745         ot->exec = gpencil_draw_exec;
2746         ot->invoke = gpencil_draw_invoke;
2747         ot->modal = gpencil_draw_modal;
2748         ot->cancel = gpencil_draw_cancel;
2749         ot->poll = gpencil_draw_poll;
2750         
2751         /* flags */
2752         ot->flag = OPTYPE_UNDO | OPTYPE_BLOCKING;
2753         
2754         /* settings for drawing */
2755         ot->prop = RNA_def_enum(ot->srna, "mode", prop_gpencil_drawmodes, 0, "Mode", "Way to interpret mouse movements");
2756         RNA_def_collection_runtime(ot->srna, "stroke", &RNA_OperatorStrokeElement, "Stroke", "");
2757         
2758         /* NOTE: wait for input is enabled by default, so that all UI code can work properly without needing users to know about this */
2759         RNA_def_boolean(ot->srna, "wait_for_input", true, "Wait for Input", "Wait for first click instead of painting immediately");
2760 }