code cleanup: remove paranoid NULL checks (these cases would crash earlier of the...
[blender.git] / source / blender / editors / armature / editarmature.c
1 /*
2  * ***** BEGIN GPL LICENSE BLOCK *****
3  *
4  * This program is free software; you can redistribute it and/or
5  * modify it under the terms of the GNU General Public License
6  * as published by the Free Software Foundation; either version 2
7  * of the License, or (at your option) any later version.
8  *
9  * This program is distributed in the hope that it will be useful,
10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12  * GNU General Public License for more details.
13  *
14  * You should have received a copy of the GNU General Public License
15  * along with this program; if not, write to the Free Software Foundation,
16  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17  *
18  * The Original Code is Copyright (C) 2001-2002 by NaN Holding BV.
19  * All rights reserved.
20  *
21  * Contributor(s): Blender Foundation, 2002-2009 full recode.
22  *
23  * ***** END GPL LICENSE BLOCK *****
24  */
25
26 /** \file blender/editors/armature/editarmature.c
27  *  \ingroup edarmature
28  */
29
30
31 #include <ctype.h>
32 #include <stdlib.h>
33 #include <stddef.h>
34 #include <string.h>
35 #include <math.h> 
36 #include <float.h> 
37 #include <assert.h> 
38
39
40 #include "DNA_anim_types.h"
41 #include "DNA_mesh_types.h"
42 #include "DNA_armature_types.h"
43 #include "DNA_constraint_types.h"
44 #include "DNA_meshdata_types.h"
45 #include "DNA_object_types.h"
46 #include "DNA_scene_types.h"
47
48 #include "MEM_guardedalloc.h"
49
50 #include "BLI_blenlib.h"
51 #include "BLI_math.h"
52 #include "BLI_utildefines.h"
53 #include "BLI_ghash.h"
54
55 #include "BKE_animsys.h"
56 #include "BKE_action.h"
57 #include "BKE_armature.h"
58 #include "BKE_constraint.h"
59 #include "BKE_context.h"
60 #include "BKE_deform.h"
61 #include "BKE_depsgraph.h"
62 #include "BKE_DerivedMesh.h"
63 #include "BKE_global.h"
64 #include "BKE_idprop.h"
65 #include "BKE_main.h"
66 #include "BKE_object.h"
67 #include "BKE_report.h"
68 #include "BKE_subsurf.h"
69 #include "BKE_modifier.h"
70 #include "DNA_object_types.h"
71
72 #include "BIF_gl.h"
73
74 #include "RNA_access.h"
75 #include "RNA_define.h"
76
77 #include "WM_api.h"
78 #include "WM_types.h"
79
80 #include "ED_armature.h"
81 #include "ED_keyframing.h"
82 #include "ED_mesh.h"
83 #include "ED_object.h"
84 #include "ED_screen.h"
85 #include "ED_util.h"
86 #include "ED_view3d.h"
87
88 #include "UI_interface.h"
89 #include "UI_resources.h"
90
91 #include "armature_intern.h"
92 #include "meshlaplacian.h"
93
94 #if 0
95 #include "reeb.h"
96 #endif
97
98 /* **************** tools on Editmode Armature **************** */
99
100 /* Sync selection to parent for connected children */
101 void ED_armature_sync_selection(ListBase *edbo)
102 {
103         EditBone *ebo;
104         
105         for (ebo = edbo->first; ebo; ebo = ebo->next) {
106                 /* if bone is not selectable, we shouldn't alter this setting... */
107                 if ((ebo->flag & BONE_UNSELECTABLE) == 0) {
108                         if ((ebo->flag & BONE_CONNECTED) && (ebo->parent)) {
109                                 if (ebo->parent->flag & BONE_TIPSEL)
110                                         ebo->flag |= BONE_ROOTSEL;
111                                 else
112                                         ebo->flag &= ~BONE_ROOTSEL;
113                         }
114                         
115                         if ((ebo->flag & BONE_TIPSEL) && (ebo->flag & BONE_ROOTSEL))
116                                 ebo->flag |= BONE_SELECTED;
117                         else
118                                 ebo->flag &= ~BONE_SELECTED;
119                 }
120         }                               
121 }
122
123 void ED_armature_validate_active(struct bArmature *arm)
124 {
125         EditBone *ebone = arm->act_edbone;
126
127         if (ebone) { 
128                 if (ebone->flag & BONE_HIDDEN_A)
129                         arm->act_edbone = NULL;
130         }
131 }
132
133 static void bone_free(bArmature *arm, EditBone *bone)
134 {
135         if (arm->act_edbone == bone)
136                 arm->act_edbone = NULL;
137
138         if (bone->prop) {
139                 IDP_FreeProperty(bone->prop);
140                 MEM_freeN(bone->prop);
141         }
142
143         BLI_freelinkN(arm->edbo, bone);
144 }
145
146 void ED_armature_edit_bone_remove(bArmature *arm, EditBone *exBone)
147 {
148         EditBone *curBone;
149
150         /* Find any bones that refer to this bone */
151         for (curBone = arm->edbo->first; curBone; curBone = curBone->next) {
152                 if (curBone->parent == exBone) {
153                         curBone->parent = exBone->parent;
154                         curBone->flag &= ~BONE_CONNECTED;
155                 }
156         }
157
158         bone_free(arm, exBone);
159 }
160
161 /* context: editmode armature */
162 EditBone *ED_armature_bone_get_mirrored(ListBase *edbo, EditBone *ebo)
163 {
164         EditBone *eboflip = NULL;
165         char name[MAXBONENAME];
166         
167         if (ebo == NULL)
168                 return NULL;
169         
170         flip_side_name(name, ebo->name, FALSE);
171         
172         for (eboflip = edbo->first; eboflip; eboflip = eboflip->next) {
173                 if (ebo != eboflip) {
174                         if (!strcmp(name, eboflip->name))
175                                 break;
176                 }
177         }
178         
179         return eboflip;
180 }
181
182 /* helper function for tools to work on mirrored parts.
183  * it leaves mirrored bones selected then too, which is a good indication of what happened */
184 static void armature_select_mirrored(bArmature *arm)
185 {
186         /* Select mirrored bones */
187         if (arm->flag & ARM_MIRROR_EDIT) {
188                 EditBone *curBone, *ebone_mirr;
189                 
190                 for (curBone = arm->edbo->first; curBone; curBone = curBone->next) {
191                         if (arm->layer & curBone->layer) {
192                                 if (curBone->flag & BONE_SELECTED) {
193                                         ebone_mirr = ED_armature_bone_get_mirrored(arm->edbo, curBone);
194                                         if (ebone_mirr)
195                                                 ebone_mirr->flag |= BONE_SELECTED;
196                                 }
197                         }
198                 }
199         }
200         
201 }
202
203 static void armature_tag_select_mirrored(bArmature *arm)
204 {
205         EditBone *curBone;
206
207         /* always untag */
208         for (curBone = arm->edbo->first; curBone; curBone = curBone->next) {
209                 curBone->flag &= ~BONE_DONE;
210         }
211
212         /* Select mirrored bones */
213         if (arm->flag & ARM_MIRROR_EDIT) {
214                 for (curBone = arm->edbo->first; curBone; curBone = curBone->next) {
215                         if (arm->layer & curBone->layer) {
216                                 if (curBone->flag & (BONE_SELECTED | BONE_ROOTSEL | BONE_TIPSEL)) {
217                                         EditBone *ebone_mirr = ED_armature_bone_get_mirrored(arm->edbo, curBone);
218                                         if (ebone_mirr && (ebone_mirr->flag & BONE_SELECTED) == 0) {
219                                                 ebone_mirr->flag |= BONE_DONE;
220                                         }
221                                 }
222                         }
223                 }
224
225                 for (curBone = arm->edbo->first; curBone; curBone = curBone->next) {
226                         if (curBone->flag & BONE_DONE) {
227                                 EditBone *ebone_mirr = ED_armature_bone_get_mirrored(arm->edbo, curBone);
228                                 curBone->flag |= ebone_mirr->flag & (BONE_SELECTED | BONE_ROOTSEL | BONE_TIPSEL);
229                         }
230                 }
231         }
232 }
233
234
235 /* only works when tagged */
236 static void armature_tag_unselect(bArmature *arm)
237 {
238         EditBone *curBone;
239
240         for (curBone = arm->edbo->first; curBone; curBone = curBone->next) {
241                 if (curBone->flag & BONE_DONE) {
242                         curBone->flag &= ~(BONE_SELECTED | BONE_ROOTSEL | BONE_TIPSEL | BONE_DONE);
243                 }
244         }
245 }
246
247 /* converts Bones to EditBone list, used for tools as well */
248 EditBone *make_boneList(ListBase *edbo, ListBase *bones, EditBone *parent, Bone *actBone)
249 {
250         EditBone    *eBone;
251         EditBone    *eBoneAct = NULL;
252         EditBone    *eBoneTest = NULL;
253         Bone        *curBone;
254                 
255         for (curBone = bones->first; curBone; curBone = curBone->next) {
256                 eBone = MEM_callocN(sizeof(EditBone), "make_editbone");
257                 
258                 /*      Copy relevant data from bone to eBone */
259                 eBone->parent = parent;
260                 BLI_strncpy(eBone->name, curBone->name, sizeof(eBone->name));
261                 eBone->flag = curBone->flag;
262                 
263                 /* fix selection flags */
264
265                 if (eBone->flag & BONE_SELECTED) {
266                         /* if the bone is selected the copy its root selection to the parents tip */
267                         eBone->flag |= BONE_TIPSEL;
268                         if (eBone->parent && (eBone->flag & BONE_CONNECTED)) {
269                                 eBone->parent->flag |= BONE_TIPSEL;
270                                 eBone->flag &= ~BONE_ROOTSEL; /* this is ignored when there is a connected parent, so unset it */
271                         }
272                         else {
273                                 eBone->flag |= BONE_ROOTSEL;
274                         }
275                 }
276                 else {
277                         /* if the bone is not selected, but connected to its parent
278                          *  copy the parents tip selection state */
279                         if (eBone->parent && (eBone->flag & BONE_CONNECTED)) {
280                                 /* selecting with the mouse gives this behavior */
281                                 if (eBone->parent->flag & BONE_TIPSEL) {
282                                         eBone->flag |= BONE_ROOTSEL;
283                                 }
284                                 else {
285                                         eBone->flag &= ~BONE_ROOTSEL;
286                                 }
287
288                                 /* probably not selected but just in case */
289                                 eBone->flag &= ~BONE_TIPSEL;
290                         }
291                 }
292
293                 copy_v3_v3(eBone->head, curBone->arm_head);
294                 copy_v3_v3(eBone->tail, curBone->arm_tail);
295                 eBone->roll = curBone->arm_roll;
296                 
297                 /* rest of stuff copy */
298                 eBone->length = curBone->length;
299                 eBone->dist = curBone->dist;
300                 eBone->weight = curBone->weight;
301                 eBone->xwidth = curBone->xwidth;
302                 eBone->zwidth = curBone->zwidth;
303                 eBone->ease1 = curBone->ease1;
304                 eBone->ease2 = curBone->ease2;
305                 eBone->rad_head = curBone->rad_head;
306                 eBone->rad_tail = curBone->rad_tail;
307                 eBone->segments = curBone->segments;            
308                 eBone->layer = curBone->layer;
309
310                 if (curBone->prop)
311                         eBone->prop = IDP_CopyProperty(curBone->prop);
312                 
313                 BLI_addtail(edbo, eBone);
314                 
315                 /*      Add children if necessary */
316                 if (curBone->childbase.first) {
317                         eBoneTest = make_boneList(edbo, &curBone->childbase, eBone, actBone);
318                         if (eBoneTest)
319                                 eBoneAct = eBoneTest;
320                 }
321
322                 if (curBone == actBone)
323                         eBoneAct = eBone;
324         }
325
326         return eBoneAct;
327 }
328
329 /* nasty stuff for converting roll in editbones into bones */
330 /* also sets restposition in armature (arm_mat) */
331 static void fix_bonelist_roll(ListBase *bonelist, ListBase *editbonelist)
332 {
333         Bone *curBone;
334         EditBone *ebone;
335         float premat[3][3];
336         float postmat[3][3];
337         float difmat[3][3];
338         float imat[3][3];
339         float delta[3];
340         
341         for (curBone = bonelist->first; curBone; curBone = curBone->next) {
342                 /* sets local matrix and arm_mat (restpos) */
343                 BKE_armature_where_is_bone(curBone, curBone->parent);
344                 
345                 /* Find the associated editbone */
346                 for (ebone = editbonelist->first; ebone; ebone = ebone->next)
347                         if ((Bone *)ebone->temp == curBone)
348                                 break;
349                 
350                 if (ebone) {
351                         /* Get the ebone premat */
352                         sub_v3_v3v3(delta, ebone->tail, ebone->head);
353                         vec_roll_to_mat3(delta, ebone->roll, premat);
354                         
355                         /* Get the bone postmat */
356                         copy_m3_m4(postmat, curBone->arm_mat);
357                         
358                         invert_m3_m3(imat, premat);
359                         mul_m3_m3m3(difmat, imat, postmat);
360 #if 0
361                         printf("Bone %s\n", curBone->name);
362                         print_m4("premat", premat);
363                         print_m4("postmat", postmat);
364                         print_m4("difmat", difmat);
365                         printf("Roll = %f\n",  RAD2DEGF(-atan2(difmat[2][0], difmat[2][2])));
366 #endif
367                         curBone->roll = (float)-atan2(difmat[2][0], difmat[2][2]);
368                         
369                         /* and set restposition again */
370                         BKE_armature_where_is_bone(curBone, curBone->parent);
371                 }
372                 fix_bonelist_roll(&curBone->childbase, editbonelist);
373         }
374 }
375
376 /* put EditMode back in Object */
377 void ED_armature_from_edit(Object *obedit)
378 {
379         bArmature *arm = obedit->data;
380         EditBone *eBone, *neBone;
381         Bone *newBone;
382         Object *obt;
383         
384         /* armature bones */
385         BKE_armature_bonelist_free(&arm->bonebase);
386         
387         /* remove zero sized bones, this gives instable restposes */
388         for (eBone = arm->edbo->first; eBone; eBone = neBone) {
389                 float len = len_v3v3(eBone->head, eBone->tail);
390                 neBone = eBone->next;
391                 if (len <= 0.000001f) {  /* FLT_EPSILON is too large? */
392                         EditBone *fBone;
393                         
394                         /*      Find any bones that refer to this bone  */
395                         for (fBone = arm->edbo->first; fBone; fBone = fBone->next) {
396                                 if (fBone->parent == eBone)
397                                         fBone->parent = eBone->parent;
398                         }
399                         if (G.debug & G_DEBUG)
400                                 printf("Warning: removed zero sized bone: %s\n", eBone->name);
401                         bone_free(arm, eBone);
402                 }
403         }
404         
405         /*      Copy the bones from the editData into the armature */
406         for (eBone = arm->edbo->first; eBone; eBone = eBone->next) {
407                 newBone = MEM_callocN(sizeof(Bone), "bone");
408                 eBone->temp = newBone;   /* Associate the real Bones with the EditBones */
409                 
410                 BLI_strncpy(newBone->name, eBone->name, sizeof(newBone->name));
411                 copy_v3_v3(newBone->arm_head, eBone->head);
412                 copy_v3_v3(newBone->arm_tail, eBone->tail);
413                 newBone->arm_roll = eBone->roll;
414                 
415                 newBone->flag = eBone->flag;
416                 
417                 if (eBone == arm->act_edbone) {
418                         /* don't change active selection, this messes up separate which uses
419                          * editmode toggle and can separate active bone which is de-selected originally */
420                         /* newBone->flag |= BONE_SELECTED; */ /* important, editbones can be active with only 1 point selected */
421                         arm->act_edbone = NULL;
422                         arm->act_bone = newBone;
423                 }
424                 newBone->roll = 0.0f;
425                 
426                 newBone->weight = eBone->weight;
427                 newBone->dist = eBone->dist;
428                 
429                 newBone->xwidth = eBone->xwidth;
430                 newBone->zwidth = eBone->zwidth;
431                 newBone->ease1 = eBone->ease1;
432                 newBone->ease2 = eBone->ease2;
433                 newBone->rad_head = eBone->rad_head;
434                 newBone->rad_tail = eBone->rad_tail;
435                 newBone->segments = eBone->segments;
436                 newBone->layer = eBone->layer;
437                 
438                 if (eBone->prop)
439                         newBone->prop = IDP_CopyProperty(eBone->prop);
440         }
441         
442         /* Fix parenting in a separate pass to ensure ebone->bone connections
443          * are valid at this point */
444         for (eBone = arm->edbo->first; eBone; eBone = eBone->next) {
445                 newBone = (Bone *)eBone->temp;
446                 if (eBone->parent) {
447                         newBone->parent = (Bone *)eBone->parent->temp;
448                         BLI_addtail(&newBone->parent->childbase, newBone);
449                         
450                         {
451                                 float M_parentRest[3][3];
452                                 float iM_parentRest[3][3];
453                                 float delta[3];
454                                 
455                                 /* Get the parent's  matrix (rotation only) */
456                                 sub_v3_v3v3(delta, eBone->parent->tail, eBone->parent->head);
457                                 vec_roll_to_mat3(delta, eBone->parent->roll, M_parentRest);
458                                 
459                                 /* Invert the parent matrix */
460                                 invert_m3_m3(iM_parentRest, M_parentRest);
461                                 
462                                 /* Get the new head and tail */
463                                 sub_v3_v3v3(newBone->head, eBone->head, eBone->parent->tail);
464                                 sub_v3_v3v3(newBone->tail, eBone->tail, eBone->parent->tail);
465                                 
466                                 mul_m3_v3(iM_parentRest, newBone->head);
467                                 mul_m3_v3(iM_parentRest, newBone->tail);
468                         }
469                 }
470                 /*      ...otherwise add this bone to the armature's bonebase */
471                 else {
472                         copy_v3_v3(newBone->head, eBone->head);
473                         copy_v3_v3(newBone->tail, eBone->tail);
474                         BLI_addtail(&arm->bonebase, newBone);
475                 }
476         }
477         
478         /* Make a pass through the new armature to fix rolling */
479         /* also builds restposition again (like BKE_armature_where_is) */
480         fix_bonelist_roll(&arm->bonebase, arm->edbo);
481         
482         /* so all users of this armature should get rebuilt */
483         for (obt = G.main->object.first; obt; obt = obt->id.next) {
484                 if (obt->data == arm)
485                         BKE_pose_rebuild(obt, arm);
486         }
487         
488         DAG_id_tag_update(&obedit->id, OB_RECALC_DATA);
489 }
490
491 void ED_armature_apply_transform(Object *ob, float mat[4][4])
492 {
493         EditBone *ebone;
494         bArmature *arm = ob->data;
495         float scale = mat4_to_scale(mat);   /* store the scale of the matrix here to use on envelopes */
496         float mat3[3][3];
497
498         copy_m3_m4(mat3, mat);
499         normalize_m3(mat3);
500
501         /* Put the armature into editmode */
502         ED_armature_to_edit(ob);
503
504         /* Do the rotations */
505         for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
506                 float delta[3], tmat[3][3];
507
508                 /* find the current bone's roll matrix */
509                 sub_v3_v3v3(delta, ebone->tail, ebone->head);
510                 vec_roll_to_mat3(delta, ebone->roll, tmat);
511
512                 /* transform the roll matrix */
513                 mul_m3_m3m3(tmat, mat3, tmat);
514
515                 /* transform the bone */
516                 mul_m4_v3(mat, ebone->head);
517                 mul_m4_v3(mat, ebone->tail);
518
519                 /* apply the transfiormed roll back */
520                 mat3_to_vec_roll(tmat, NULL, &ebone->roll);
521
522                 ebone->rad_head *= scale;
523                 ebone->rad_tail *= scale;
524                 ebone->dist     *= scale;
525
526                 /* we could be smarter and scale by the matrix along the x & z axis */
527                 ebone->xwidth   *= scale;
528                 ebone->zwidth   *= scale;
529         }
530         
531         /* Turn the list into an armature */
532         ED_armature_from_edit(ob);
533         ED_armature_edit_free(ob);
534 }
535
536 /* exported for use in editors/object/ */
537 /* 0 == do center, 1 == center new, 2 == center cursor */
538 void docenter_armature(Scene *scene, Object *ob, float cursor[3], int centermode, int around)
539 {
540         Object *obedit = scene->obedit; // XXX get from context
541         EditBone *ebone;
542         bArmature *arm = ob->data;
543         float cent[3];
544
545         /* Put the armature into editmode */
546         if (ob != obedit) {
547                 ED_armature_to_edit(ob);
548                 obedit = NULL; /* we cant use this so behave as if there is no obedit */
549         }
550
551         /* Find the centerpoint */
552         if (centermode == 2) {
553                 copy_v3_v3(cent, cursor);
554                 invert_m4_m4(ob->imat, ob->obmat);
555                 mul_m4_v3(ob->imat, cent);
556         }
557         else {
558                 if (around == V3D_CENTROID) {
559                         int total = 0;
560                         zero_v3(cent);
561                         for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
562                                 total += 2;
563                                 add_v3_v3(cent, ebone->head);
564                                 add_v3_v3(cent, ebone->tail);
565                         }
566                         mul_v3_fl(cent, 1.0f / (float)total);
567                 }
568                 else {
569                         float min[3], max[3];
570                         INIT_MINMAX(min, max);
571                         for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
572                                 minmax_v3v3_v3(min, max, ebone->head);
573                                 minmax_v3v3_v3(min, max, ebone->tail);
574                         }
575                         mid_v3_v3v3(cent, min, max);
576                 }
577         }
578         
579         /* Do the adjustments */
580         for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
581                 sub_v3_v3(ebone->head, cent);
582                 sub_v3_v3(ebone->tail, cent);
583         }
584         
585         /* Turn the list into an armature */
586         if (obedit == NULL) {
587                 ED_armature_from_edit(ob);
588                 ED_armature_edit_free(ob);
589         }
590
591         /* Adjust object location for new centerpoint */
592         if (centermode && obedit == NULL) {
593                 mul_mat3_m4_v3(ob->obmat, cent); /* ommit translation part */
594                 add_v3_v3(ob->loc, cent);
595         }
596 }
597
598 /* ---------------------- */
599
600 /* checks if an EditBone with a matching name already, returning the matching bone if it exists */
601 static EditBone *editbone_name_exists(ListBase *edbo, const char *name)
602 {
603         return BLI_findstring(edbo, name, offsetof(EditBone, name));
604 }
605
606 /* note: there's a unique_bone_name() too! */
607 static int editbone_unique_check(void *arg, const char *name)
608 {
609         struct {ListBase *lb; void *bone; } *data = arg;
610         EditBone *dupli = editbone_name_exists(data->lb, name);
611         return dupli && dupli != data->bone;
612 }
613
614 void unique_editbone_name(ListBase *edbo, char *name, EditBone *bone)
615 {
616         struct {ListBase *lb; void *bone; } data;
617         data.lb = edbo;
618         data.bone = bone;
619
620         BLI_uniquename_cb(editbone_unique_check, &data, "Bone", '.', name, sizeof(bone->name));
621 }
622
623 /* helper for apply_armature_pose2bones - fixes parenting of objects that are bone-parented to armature */
624 static void applyarmature_fix_boneparents(Scene *scene, Object *armob)
625 {
626         Object workob, *ob;
627         
628         /* go through all objects in database */
629         for (ob = G.main->object.first; ob; ob = ob->id.next) {
630                 /* if parent is bone in this armature, apply corrections */
631                 if ((ob->parent == armob) && (ob->partype == PARBONE)) {
632                         /* apply current transform from parent (not yet destroyed), 
633                          * then calculate new parent inverse matrix
634                          */
635                         BKE_object_apply_mat4(ob, ob->obmat, FALSE, FALSE);
636                         
637                         BKE_object_workob_calc_parent(scene, ob, &workob);
638                         invert_m4_m4(ob->parentinv, workob.obmat);
639                 }
640         }
641 }
642
643 /* set the current pose as the restpose */
644 static int apply_armature_pose2bones_exec(bContext *C, wmOperator *op)
645 {
646         Scene *scene = CTX_data_scene(C);
647         Object *ob = BKE_object_pose_armature_get(CTX_data_active_object(C)); // must be active object, not edit-object
648         bArmature *arm = BKE_armature_from_object(ob);
649         bPose *pose;
650         bPoseChannel *pchan;
651         EditBone *curbone;
652         
653         /* don't check if editmode (should be done by caller) */
654         if (ob->type != OB_ARMATURE)
655                 return OPERATOR_CANCELLED;
656         if (BKE_object_obdata_is_libdata(ob)) {
657                 BKE_report(op->reports, RPT_ERROR, "Cannot apply pose to lib-linked armature"); //error_libdata();
658                 return OPERATOR_CANCELLED;
659         }
660
661         /* helpful warnings... */
662         /* TODO: add warnings to be careful about actions, applying deforms first, etc. */
663         if (ob->adt && ob->adt->action)
664                 BKE_report(op->reports, RPT_WARNING, "Actions on this armature will be destroyed by this new rest pose as the transforms stored are relative to the old rest pose");
665
666         /* Get editbones of active armature to alter */
667         ED_armature_to_edit(ob);        
668         
669         /* get pose of active object and move it out of posemode */
670         pose = ob->pose;
671         
672         for (pchan = pose->chanbase.first; pchan; pchan = pchan->next) {
673                 curbone = editbone_name_exists(arm->edbo, pchan->name);
674                 
675                 /* simply copy the head/tail values from pchan over to curbone */
676                 copy_v3_v3(curbone->head, pchan->pose_head);
677                 copy_v3_v3(curbone->tail, pchan->pose_tail);
678                 
679                 /* fix roll:
680                  *      1. find auto-calculated roll value for this bone now
681                  *      2. remove this from the 'visual' y-rotation
682                  */
683                 {
684                         float premat[3][3], imat[3][3], pmat[3][3], tmat[3][3];
685                         float delta[3], eul[3];
686                         
687                         /* obtain new auto y-rotation */
688                         sub_v3_v3v3(delta, curbone->tail, curbone->head);
689                         vec_roll_to_mat3(delta, 0.0f, premat);
690                         invert_m3_m3(imat, premat);
691                         
692                         /* get pchan 'visual' matrix */
693                         copy_m3_m4(pmat, pchan->pose_mat);
694                         
695                         /* remove auto from visual and get euler rotation */
696                         mul_m3_m3m3(tmat, imat, pmat);
697                         mat3_to_eul(eul, tmat);
698                         
699                         /* just use this euler-y as new roll value */
700                         curbone->roll = eul[1];
701                 }
702                 
703                 /* clear transform values for pchan */
704                 zero_v3(pchan->loc);
705                 zero_v3(pchan->eul);
706                 unit_qt(pchan->quat);
707                 unit_axis_angle(pchan->rotAxis, &pchan->rotAngle);
708                 pchan->size[0] = pchan->size[1] = pchan->size[2] = 1.0f;
709                 
710                 /* set anim lock */
711                 curbone->flag |= BONE_UNKEYED;
712         }
713         
714         /* convert editbones back to bones, and then free the edit-data */
715         ED_armature_from_edit(ob);
716         ED_armature_edit_free(ob);
717         
718         /* flush positions of posebones */
719         BKE_pose_where_is(scene, ob);
720         
721         /* fix parenting of objects which are bone-parented */
722         applyarmature_fix_boneparents(scene, ob);
723         
724         /* note, notifier might evolve */
725         WM_event_add_notifier(C, NC_OBJECT | ND_POSE, ob);
726         
727         return OPERATOR_FINISHED;
728 }
729
730 void POSE_OT_armature_apply(wmOperatorType *ot)
731 {
732         /* identifiers */
733         ot->name = "Apply Pose as Rest Pose";
734         ot->idname = "POSE_OT_armature_apply";
735         ot->description = "Apply the current pose as the new rest pose";
736         
737         /* callbacks */
738         ot->exec = apply_armature_pose2bones_exec;
739         ot->poll = ED_operator_posemode;
740         
741         /* flags */
742         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
743 }
744
745
746 /* set the current pose as the restpose */
747 static int pose_visual_transform_apply_exec(bContext *C, wmOperator *UNUSED(op))
748 {
749         Object *ob = BKE_object_pose_armature_get(CTX_data_active_object(C)); // must be active object, not edit-object
750
751         /* don't check if editmode (should be done by caller) */
752         if (ob->type != OB_ARMATURE)
753                 return OPERATOR_CANCELLED;
754
755         /* loop over all selected pchans
756          *
757          * TODO, loop over children before parents if multiple bones
758          * at once are to be predictable*/
759         CTX_DATA_BEGIN(C, bPoseChannel *, pchan, selected_pose_bones)
760         {
761                 float delta_mat[4][4];
762                 
763                 /* chan_mat already contains the delta transform from rest pose to pose-mode pose
764                  * as that is baked into there so that B-Bones will work. Once we've set this as the
765                  * new raw-transform components, don't recalc the poses yet, otherwise IK result will 
766                  * change, thus changing the result we may be trying to record.
767                  */
768                 copy_m4_m4(delta_mat, pchan->chan_mat);
769                 BKE_pchan_apply_mat4(pchan, delta_mat, TRUE);
770         }
771         CTX_DATA_END;
772         
773         DAG_id_tag_update(&ob->id, OB_RECALC_DATA);
774
775         /* note, notifier might evolve */
776         WM_event_add_notifier(C, NC_OBJECT | ND_POSE, ob);
777
778         return OPERATOR_FINISHED;
779 }
780
781 void POSE_OT_visual_transform_apply(wmOperatorType *ot)
782 {
783         /* identifiers */
784         ot->name = "Apply Visual Transform to Pose";
785         ot->idname = "POSE_OT_visual_transform_apply";
786         ot->description = "Apply final constrained position of pose bones to their transform";
787         
788         /* callbacks */
789         ot->exec = pose_visual_transform_apply_exec;
790         ot->poll = ED_operator_posemode;
791         
792         /* flags */
793         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
794 }
795
796 /* ---------------------- */
797
798 /* Helper function for armature joining - link fixing */
799 static void joined_armature_fix_links(Object *tarArm, Object *srcArm, bPoseChannel *pchan, EditBone *curbone)
800 {
801         Object *ob;
802         bPose *pose;
803         bPoseChannel *pchant;
804         bConstraint *con;
805         
806         /* let's go through all objects in database */
807         for (ob = G.main->object.first; ob; ob = ob->id.next) {
808                 /* do some object-type specific things */
809                 if (ob->type == OB_ARMATURE) {
810                         pose = ob->pose;
811                         for (pchant = pose->chanbase.first; pchant; pchant = pchant->next) {
812                                 for (con = pchant->constraints.first; con; con = con->next) {
813                                         bConstraintTypeInfo *cti = constraint_get_typeinfo(con);
814                                         ListBase targets = {NULL, NULL};
815                                         bConstraintTarget *ct;
816                                         
817                                         /* constraint targets */
818                                         if (cti && cti->get_constraint_targets) {
819                                                 cti->get_constraint_targets(con, &targets);
820                                                 
821                                                 for (ct = targets.first; ct; ct = ct->next) {
822                                                         if (ct->tar == srcArm) {
823                                                                 if (ct->subtarget[0] == '\0') {
824                                                                         ct->tar = tarArm;
825                                                                 }
826                                                                 else if (strcmp(ct->subtarget, pchan->name) == 0) {
827                                                                         ct->tar = tarArm;
828                                                                         BLI_strncpy(ct->subtarget, curbone->name, sizeof(ct->subtarget));
829                                                                 }
830                                                         }
831                                                 }
832                                                 
833                                                 if (cti->flush_constraint_targets)
834                                                         cti->flush_constraint_targets(con, &targets, 0);
835                                         }
836                                         
837                                         /* action constraint? */
838                                         if (con->type == CONSTRAINT_TYPE_ACTION) {
839                                                 bActionConstraint *data = con->data; // XXX old animation system
840                                                 bAction *act;
841                                                 bActionChannel *achan;
842                                                 
843                                                 if (data->act) {
844                                                         act = data->act;
845                                                         
846                                                         for (achan = act->chanbase.first; achan; achan = achan->next) {
847                                                                 if (strcmp(achan->name, pchan->name) == 0)
848                                                                         BLI_strncpy(achan->name, curbone->name, sizeof(achan->name));
849                                                         }
850                                                 }
851                                         }
852                                         
853                                 }
854                         }
855                 }
856                         
857                 /* fix object-level constraints */
858                 if (ob != srcArm) {
859                         for (con = ob->constraints.first; con; con = con->next) {
860                                 bConstraintTypeInfo *cti = constraint_get_typeinfo(con);
861                                 ListBase targets = {NULL, NULL};
862                                 bConstraintTarget *ct;
863                                 
864                                 /* constraint targets */
865                                 if (cti && cti->get_constraint_targets) {
866                                         cti->get_constraint_targets(con, &targets);
867                                         
868                                         for (ct = targets.first; ct; ct = ct->next) {
869                                                 if (ct->tar == srcArm) {
870                                                         if (ct->subtarget[0] == '\0') {
871                                                                 ct->tar = tarArm;
872                                                         }
873                                                         else if (strcmp(ct->subtarget, pchan->name) == 0) {
874                                                                 ct->tar = tarArm;
875                                                                 BLI_strncpy(ct->subtarget, curbone->name, sizeof(ct->subtarget));
876                                                         }
877                                                 }
878                                         }
879                                         
880                                         if (cti->flush_constraint_targets)
881                                                 cti->flush_constraint_targets(con, &targets, 0);
882                                 }
883                         }
884                 }
885                 
886                 /* See if an object is parented to this armature */
887                 if (ob->parent && (ob->parent == srcArm)) {
888                         /* Is object parented to a bone of this src armature? */
889                         if (ob->partype == PARBONE) {
890                                 /* bone name in object */
891                                 if (!strcmp(ob->parsubstr, pchan->name))
892                                         BLI_strncpy(ob->parsubstr, curbone->name, sizeof(ob->parsubstr));
893                         }
894                         
895                         /* make tar armature be new parent */
896                         ob->parent = tarArm;
897                 }
898         }       
899 }
900
901 /* join armature exec is exported for use in object->join objects operator... */
902 int join_armature_exec(bContext *C, wmOperator *UNUSED(op))
903 {
904         Main *bmain = CTX_data_main(C);
905         Scene *scene = CTX_data_scene(C);
906         Object  *ob = CTX_data_active_object(C);
907         bArmature *arm = (ob) ? ob->data : NULL;
908         bPose *pose, *opose;
909         bPoseChannel *pchan, *pchann;
910         EditBone *curbone;
911         float mat[4][4], oimat[4][4];
912         
913         /*      Ensure we're not in editmode and that the active object is an armature*/
914         if (!ob || ob->type != OB_ARMATURE)
915                 return OPERATOR_CANCELLED;
916         if (!arm || arm->edbo)
917                 return OPERATOR_CANCELLED;
918         
919         /* Get editbones of active armature to add editbones to */
920         ED_armature_to_edit(ob);
921         
922         /* get pose of active object and move it out of posemode */
923         pose = ob->pose;
924         ob->mode &= ~OB_MODE_POSE;
925
926         CTX_DATA_BEGIN(C, Base *, base, selected_editable_bases)
927         {
928                 if ((base->object->type == OB_ARMATURE) && (base->object != ob)) {
929                         bArmature *curarm = base->object->data;
930                         
931                         /* Make a list of editbones in current armature */
932                         ED_armature_to_edit(base->object);
933                         
934                         /* Get Pose of current armature */
935                         opose = base->object->pose;
936                         base->object->mode &= ~OB_MODE_POSE;
937                         //BASACT->flag &= ~OB_MODE_POSE;
938                         
939                         /* Find the difference matrix */
940                         invert_m4_m4(oimat, ob->obmat);
941                         mult_m4_m4m4(mat, oimat, base->object->obmat);
942                         
943                         /* Copy bones and posechannels from the object to the edit armature */
944                         for (pchan = opose->chanbase.first; pchan; pchan = pchann) {
945                                 pchann = pchan->next;
946                                 curbone = editbone_name_exists(curarm->edbo, pchan->name);
947                                 
948                                 /* Get new name */
949                                 unique_editbone_name(arm->edbo, curbone->name, NULL);
950                                 
951                                 /* Transform the bone */
952                                 {
953                                         float premat[4][4];
954                                         float postmat[4][4];
955                                         float difmat[4][4];
956                                         float imat[4][4];
957                                         float temp[3][3];
958                                         float delta[3];
959                                         
960                                         /* Get the premat */
961                                         sub_v3_v3v3(delta, curbone->tail, curbone->head);
962                                         vec_roll_to_mat3(delta, curbone->roll, temp);
963                                         
964                                         unit_m4(premat); /* Mat4MulMat34 only sets 3x3 part */
965                                         mul_m4_m3m4(premat, temp, mat);
966                                         
967                                         mul_m4_v3(mat, curbone->head);
968                                         mul_m4_v3(mat, curbone->tail);
969                                         
970                                         /* Get the postmat */
971                                         sub_v3_v3v3(delta, curbone->tail, curbone->head);
972                                         vec_roll_to_mat3(delta, curbone->roll, temp);
973                                         copy_m4_m3(postmat, temp);
974                                         
975                                         /* Find the roll */
976                                         invert_m4_m4(imat, premat);
977                                         mult_m4_m4m4(difmat, imat, postmat);
978                                         
979                                         curbone->roll -= (float)atan2(difmat[2][0], difmat[2][2]);
980                                 }
981                                 
982                                 /* Fix Constraints and Other Links to this Bone and Armature */
983                                 joined_armature_fix_links(ob, base->object, pchan, curbone);
984                                 
985                                 /* Rename pchan */
986                                 BLI_strncpy(pchan->name, curbone->name, sizeof(pchan->name));
987                                 
988                                 /* Jump Ship! */
989                                 BLI_remlink(curarm->edbo, curbone);
990                                 BLI_addtail(arm->edbo, curbone);
991                                 
992                                 BLI_remlink(&opose->chanbase, pchan);
993                                 BLI_addtail(&pose->chanbase, pchan);
994                                 BKE_pose_channels_hash_free(opose);
995                                 BKE_pose_channels_hash_free(pose);
996                         }
997                         
998                         ED_base_object_free_and_unlink(bmain, scene, base);
999                 }
1000         }
1001         CTX_DATA_END;
1002         
1003         DAG_scene_sort(bmain, scene);  /* because we removed object(s) */
1004
1005         ED_armature_from_edit(ob);
1006         ED_armature_edit_free(ob);
1007
1008         WM_event_add_notifier(C, NC_SCENE | ND_OB_ACTIVE, scene);
1009         
1010         return OPERATOR_FINISHED;
1011 }
1012
1013 /* ---------------------- */
1014
1015 /* Helper function for armature separating - link fixing */
1016 static void separated_armature_fix_links(Object *origArm, Object *newArm)
1017 {
1018         Object *ob;
1019         bPoseChannel *pchan;
1020         bConstraint *con;
1021         ListBase *opchans, *npchans;
1022         
1023         /* get reference to list of bones in original and new armatures  */
1024         opchans = &origArm->pose->chanbase;
1025         npchans = &newArm->pose->chanbase;
1026         
1027         /* let's go through all objects in database */
1028         for (ob = G.main->object.first; ob; ob = ob->id.next) {
1029                 /* do some object-type specific things */
1030                 if (ob->type == OB_ARMATURE) {
1031                         for (pchan = ob->pose->chanbase.first; pchan; pchan = pchan->next) {
1032                                 for (con = pchan->constraints.first; con; con = con->next) {
1033                                         bConstraintTypeInfo *cti = constraint_get_typeinfo(con);
1034                                         ListBase targets = {NULL, NULL};
1035                                         bConstraintTarget *ct;
1036                                         
1037                                         /* constraint targets */
1038                                         if (cti && cti->get_constraint_targets) {
1039                                                 cti->get_constraint_targets(con, &targets);
1040                                                 
1041                                                 for (ct = targets.first; ct; ct = ct->next) {
1042                                                         /* any targets which point to original armature are redirected to the new one only if:
1043                                                          *      - the target isn't origArm/newArm itself
1044                                                          *      - the target is one that can be found in newArm/origArm
1045                                                          */
1046                                                         if (ct->subtarget[0] != 0) {
1047                                                                 if (ct->tar == origArm) {
1048                                                                         if (BLI_findstring(npchans, ct->subtarget, offsetof(bPoseChannel, name))) {
1049                                                                                 ct->tar = newArm;
1050                                                                         }
1051                                                                 }
1052                                                                 else if (ct->tar == newArm) {
1053                                                                         if (BLI_findstring(opchans, ct->subtarget, offsetof(bPoseChannel, name))) {
1054                                                                                 ct->tar = origArm;
1055                                                                         }
1056                                                                 }
1057                                                         }
1058                                                 }
1059
1060                                                 if (cti->flush_constraint_targets) {
1061                                                         cti->flush_constraint_targets(con, &targets, 0);
1062                                                 }
1063                                         }
1064                                 }
1065                         }
1066                 }
1067                         
1068                 /* fix object-level constraints */
1069                 if (ob != origArm) {
1070                         for (con = ob->constraints.first; con; con = con->next) {
1071                                 bConstraintTypeInfo *cti = constraint_get_typeinfo(con);
1072                                 ListBase targets = {NULL, NULL};
1073                                 bConstraintTarget *ct;
1074                                 
1075                                 /* constraint targets */
1076                                 if (cti && cti->get_constraint_targets) {
1077                                         cti->get_constraint_targets(con, &targets);
1078                                         
1079                                         for (ct = targets.first; ct; ct = ct->next) {
1080                                                 /* any targets which point to original armature are redirected to the new one only if:
1081                                                  *      - the target isn't origArm/newArm itself
1082                                                  *      - the target is one that can be found in newArm/origArm
1083                                                  */
1084                                                 if (ct->subtarget[0] != '\0') {
1085                                                         if (ct->tar == origArm) {
1086                                                                 if (BLI_findstring(npchans, ct->subtarget, offsetof(bPoseChannel, name))) {
1087                                                                         ct->tar = newArm;
1088                                                                 }
1089                                                         }
1090                                                         else if (ct->tar == newArm) {
1091                                                                 if (BLI_findstring(opchans, ct->subtarget, offsetof(bPoseChannel, name))) {
1092                                                                         ct->tar = origArm;
1093                                                                 }
1094                                                         }
1095                                                 }
1096                                         }
1097
1098                                         if (cti->flush_constraint_targets) {
1099                                                 cti->flush_constraint_targets(con, &targets, 0);
1100                                         }
1101                                 }
1102                         }
1103                 }
1104                 
1105                 /* See if an object is parented to this armature */
1106                 if (ob->parent && (ob->parent == origArm)) {
1107                         /* Is object parented to a bone of this src armature? */
1108                         if ((ob->partype == PARBONE) && (ob->parsubstr[0] != '\0')) {
1109                                 if (BLI_findstring(npchans, ob->parsubstr, offsetof(bPoseChannel, name))) {
1110                                         ob->parent = newArm;
1111                                 }
1112                         }
1113                 }
1114         }       
1115 }
1116
1117 /* Helper function for armature separating - remove certain bones from the given armature 
1118  *      sel: remove selected bones from the armature, otherwise the unselected bones are removed
1119  *  (ob is not in editmode)
1120  */
1121 static void separate_armature_bones(Object *ob, short sel) 
1122 {
1123         bArmature *arm = (bArmature *)ob->data;
1124         bPoseChannel *pchan, *pchann;
1125         EditBone *curbone;
1126         
1127         /* make local set of editbones to manipulate here */
1128         ED_armature_to_edit(ob);
1129         
1130         /* go through pose-channels, checking if a bone should be removed */
1131         for (pchan = ob->pose->chanbase.first; pchan; pchan = pchann) {
1132                 pchann = pchan->next;
1133                 curbone = editbone_name_exists(arm->edbo, pchan->name);
1134                 
1135                 /* check if bone needs to be removed */
1136                 if ( (sel && (curbone->flag & BONE_SELECTED)) ||
1137                      (!sel && !(curbone->flag & BONE_SELECTED)) )
1138                 {
1139                         EditBone *ebo;
1140                         bPoseChannel *pchn;
1141                         
1142                         /* clear the bone->parent var of any bone that had this as its parent  */
1143                         for (ebo = arm->edbo->first; ebo; ebo = ebo->next) {
1144                                 if (ebo->parent == curbone) {
1145                                         ebo->parent = NULL;
1146                                         ebo->temp = NULL; /* this is needed to prevent random crashes with in ED_armature_from_edit */
1147                                         ebo->flag &= ~BONE_CONNECTED;
1148                                 }
1149                         }
1150                         
1151                         /* clear the pchan->parent var of any pchan that had this as its parent */
1152                         for (pchn = ob->pose->chanbase.first; pchn; pchn = pchn->next) {
1153                                 if (pchn->parent == pchan)
1154                                         pchn->parent = NULL;
1155                         }
1156                         
1157                         /* free any of the extra-data this pchan might have */
1158                         BKE_pose_channel_free(pchan);
1159                         BKE_pose_channels_hash_free(ob->pose);
1160                         
1161                         /* get rid of unneeded bone */
1162                         bone_free(arm, curbone);
1163                         BLI_freelinkN(&ob->pose->chanbase, pchan);
1164                 }
1165         }
1166         
1167         /* exit editmode (recalculates pchans too) */
1168         ED_armature_from_edit(ob);
1169         ED_armature_edit_free(ob);
1170 }
1171
1172 /* separate selected bones into their armature */
1173 static int separate_armature_exec(bContext *C, wmOperator *UNUSED(op))
1174 {
1175         Main *bmain = CTX_data_main(C);
1176         Scene *scene = CTX_data_scene(C);
1177         Object *obedit = CTX_data_edit_object(C);
1178         Object *oldob, *newob;
1179         Base *oldbase, *newbase;
1180         
1181         /* sanity checks */
1182         if (obedit == NULL)
1183                 return OPERATOR_CANCELLED;
1184         
1185         /* set wait cursor in case this takes a while */
1186         WM_cursor_wait(1);
1187         
1188         /* we are going to do this as follows (unlike every other instance of separate):
1189          *      1. exit editmode +posemode for active armature/base. Take note of what this is.
1190          *      2. duplicate base - BASACT is the new one now
1191          *      3. for each of the two armatures, enter editmode -> remove appropriate bones -> exit editmode + recalc
1192          *      4. fix constraint links
1193          *      5. make original armature active and enter editmode
1194          */
1195
1196         /* 1) only edit-base selected */
1197         /* TODO: use context iterators for this? */
1198         CTX_DATA_BEGIN(C, Base *, base, visible_bases)
1199         {
1200                 if (base->object == obedit) base->flag |= 1;
1201                 else base->flag &= ~1;
1202         }
1203         CTX_DATA_END;
1204         
1205         /* 1) store starting settings and exit editmode */
1206         oldob = obedit;
1207         oldbase = BASACT;
1208         oldob->mode &= ~OB_MODE_POSE;
1209         //oldbase->flag &= ~OB_POSEMODE;
1210         
1211         ED_armature_from_edit(obedit);
1212         ED_armature_edit_free(obedit);
1213         
1214         /* 2) duplicate base */
1215         newbase = ED_object_add_duplicate(bmain, scene, oldbase, USER_DUP_ARM); /* only duplicate linked armature */
1216         DAG_scene_sort(bmain, scene);
1217
1218         newob = newbase->object;
1219         newbase->flag &= ~SELECT;
1220         
1221         
1222         /* 3) remove bones that shouldn't still be around on both armatures */
1223         separate_armature_bones(oldob, 1);
1224         separate_armature_bones(newob, 0);
1225         
1226         
1227         /* 4) fix links before depsgraph flushes */ // err... or after?
1228         separated_armature_fix_links(oldob, newob);
1229         
1230         DAG_id_tag_update(&oldob->id, OB_RECALC_DATA);  /* this is the original one */
1231         DAG_id_tag_update(&newob->id, OB_RECALC_DATA);  /* this is the separated one */
1232         
1233         
1234         /* 5) restore original conditions */
1235         obedit = oldob;
1236         
1237         ED_armature_to_edit(obedit);
1238         
1239         /* note, notifier might evolve */
1240         WM_event_add_notifier(C, NC_OBJECT | ND_POSE, obedit);
1241         
1242         /* recalc/redraw + cleanup */
1243         WM_cursor_wait(0);
1244         
1245         return OPERATOR_FINISHED;
1246 }
1247
1248 void ARMATURE_OT_separate(wmOperatorType *ot)
1249 {
1250         /* identifiers */
1251         ot->name = "Separate Bones";
1252         ot->idname = "ARMATURE_OT_separate";
1253         ot->description = "Isolate selected bones into a separate armature";
1254         
1255         /* callbacks */
1256         ot->invoke = WM_operator_confirm;
1257         ot->exec = separate_armature_exec;
1258         ot->poll = ED_operator_editarmature;
1259         
1260         /* flags */
1261         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
1262 }
1263
1264 /* **************** END tools on Editmode Armature **************** */
1265 /* **************** PoseMode & EditMode *************************** */
1266
1267 /* only for opengl selection indices */
1268 Bone *get_indexed_bone(Object *ob, int index)
1269 {
1270         bPoseChannel *pchan;
1271         if (ob->pose == NULL) return NULL;
1272         index >>= 16;     // bone selection codes use left 2 bytes
1273         
1274         pchan = BLI_findlink(&ob->pose->chanbase, index);
1275         return pchan ? pchan->bone : NULL;
1276 }
1277
1278 /* See if there are any selected bones in this buffer */
1279 /* only bones from base are checked on */
1280 static void *get_bone_from_selectbuffer(Scene *scene, Base *base, unsigned int *buffer, short hits, short findunsel)
1281 {
1282         Object *obedit = scene->obedit; // XXX get from context
1283         Bone *bone;
1284         EditBone *ebone;
1285         void *firstunSel = NULL, *firstSel = NULL, *data;
1286         unsigned int hitresult;
1287         short i, takeNext = 0, sel;
1288         
1289         for (i = 0; i < hits; i++) {
1290                 hitresult = buffer[3 + (i * 4)];
1291                 
1292                 if (!(hitresult & BONESEL_NOSEL)) { // -1
1293                         if (hitresult & BONESEL_ANY) {  // to avoid including objects in selection
1294                                 
1295                                 hitresult &= ~(BONESEL_ANY);
1296                                 /* Determine what the current bone is */
1297                                 if (obedit == NULL || base->object != obedit) {
1298                                         /* no singular posemode, so check for correct object */
1299                                         if (base->selcol == (hitresult & 0xFFFF)) {
1300                                                 bone = get_indexed_bone(base->object, hitresult);
1301                                                 
1302                                                 if (findunsel)
1303                                                         sel = (bone->flag & BONE_SELECTED);
1304                                                 else
1305                                                         sel = !(bone->flag & BONE_SELECTED);
1306                                                 
1307                                                 data = bone;
1308                                         }
1309                                         else {
1310                                                 data = NULL;
1311                                                 sel = 0;
1312                                         }
1313                                 }
1314                                 else {
1315                                         bArmature *arm = obedit->data;
1316                                         
1317                                         ebone = BLI_findlink(arm->edbo, hitresult);
1318                                         if (findunsel)
1319                                                 sel = (ebone->flag & BONE_SELECTED);
1320                                         else
1321                                                 sel = !(ebone->flag & BONE_SELECTED);
1322                                         
1323                                         data = ebone;
1324                                 }
1325                                 
1326                                 if (data) {
1327                                         if (sel) {
1328                                                 if (!firstSel) firstSel = data;
1329                                                 takeNext = 1;
1330                                         }
1331                                         else {
1332                                                 if (!firstunSel)
1333                                                         firstunSel = data;
1334                                                 if (takeNext)
1335                                                         return data;
1336                                         }
1337                                 }
1338                         }
1339                 }
1340         }
1341         
1342         if (firstunSel)
1343                 return firstunSel;
1344         else 
1345                 return firstSel;
1346 }
1347
1348
1349
1350 /* used by posemode as well editmode */
1351 /* only checks scene->basact! */
1352 /* x and y are mouse coords (area space) */
1353 static void *get_nearest_bone(bContext *C, short findunsel, int x, int y)
1354 {
1355         ViewContext vc;
1356         rcti rect;
1357         unsigned int buffer[MAXPICKBUF];
1358         short hits;
1359         
1360         view3d_set_viewcontext(C, &vc);
1361         
1362         // rect.xmin = ... mouseco!
1363         rect.xmin = rect.xmax = x;
1364         rect.ymin = rect.ymax = y;
1365         
1366         glInitNames();
1367         hits = view3d_opengl_select(&vc, buffer, MAXPICKBUF, &rect);
1368
1369         if (hits > 0)
1370                 return get_bone_from_selectbuffer(vc.scene, vc.scene->basact, buffer, hits, findunsel);
1371         
1372         return NULL;
1373 }
1374
1375 /* Get the first available child of an editbone */
1376 static EditBone *editbone_get_child(bArmature *arm, EditBone *pabone, short use_visibility)
1377 {
1378         EditBone *curbone, *chbone = NULL;
1379         
1380         for (curbone = arm->edbo->first; curbone; curbone = curbone->next) {
1381                 if (curbone->parent == pabone) {
1382                         if (use_visibility) {
1383                                 if ((arm->layer & curbone->layer) && !(pabone->flag & BONE_HIDDEN_A)) {
1384                                         chbone = curbone;
1385                                 }
1386                         }
1387                         else
1388                                 chbone = curbone;
1389                 }
1390         }
1391         
1392         return chbone;
1393 }
1394
1395 /* **************** END PoseMode & EditMode *************************** */
1396 /* **************** Posemode stuff ********************** */
1397
1398
1399 static void selectconnected_posebonechildren(Object *ob, Bone *bone, int extend)
1400 {
1401         Bone *curBone;
1402         
1403         /* stop when unconnected child is encontered, or when unselectable bone is encountered */
1404         if (!(bone->flag & BONE_CONNECTED) || (bone->flag & BONE_UNSELECTABLE))
1405                 return;
1406         
1407         /* XXX old cruft! use notifiers instead */
1408         //select_actionchannel_by_name (ob->action, bone->name, !(shift));
1409         
1410         if (extend)
1411                 bone->flag &= ~BONE_SELECTED;
1412         else
1413                 bone->flag |= BONE_SELECTED;
1414         
1415         for (curBone = bone->childbase.first; curBone; curBone = curBone->next)
1416                 selectconnected_posebonechildren(ob, curBone, extend);
1417 }
1418
1419 /* within active object context */
1420 /* previously known as "selectconnected_posearmature" */
1421 static int pose_select_connected_invoke(bContext *C, wmOperator *op, wmEvent *event)
1422 {
1423         Object *ob = BKE_object_pose_armature_get(CTX_data_active_object(C));
1424         bArmature *arm = (bArmature *)ob->data;
1425         Bone *bone, *curBone, *next = NULL;
1426         int extend = RNA_boolean_get(op->ptr, "extend");
1427
1428         view3d_operator_needs_opengl(C);
1429         
1430         if (extend)
1431                 bone = get_nearest_bone(C, 0, event->mval[0], event->mval[1]);
1432         else
1433                 bone = get_nearest_bone(C, 1, event->mval[0], event->mval[1]);
1434         
1435         if (!bone)
1436                 return OPERATOR_CANCELLED;
1437         
1438         /* Select parents */
1439         for (curBone = bone; curBone; curBone = next) {
1440                 /* ignore bone if cannot be selected */
1441                 if ((curBone->flag & BONE_UNSELECTABLE) == 0) { 
1442                         // XXX old cruft! use notifiers instead
1443                         //select_actionchannel_by_name (ob->action, curBone->name, !(shift));
1444                         
1445                         if (extend)
1446                                 curBone->flag &= ~BONE_SELECTED;
1447                         else
1448                                 curBone->flag |= BONE_SELECTED;
1449                         
1450                         if (curBone->flag & BONE_CONNECTED)
1451                                 next = curBone->parent;
1452                         else
1453                                 next = NULL;
1454                 }
1455                 else
1456                         next = NULL;
1457         }
1458         
1459         /* Select children */
1460         for (curBone = bone->childbase.first; curBone; curBone = next)
1461                 selectconnected_posebonechildren(ob, curBone, extend);
1462         
1463         /* updates */
1464         WM_event_add_notifier(C, NC_OBJECT | ND_BONE_SELECT, ob);
1465         
1466         if (arm->flag & ARM_HAS_VIZ_DEPS) {
1467                 /* mask modifier ('armature' mode), etc. */
1468                 DAG_id_tag_update(&ob->id, OB_RECALC_DATA);
1469         }
1470
1471         return OPERATOR_FINISHED;
1472 }
1473
1474 static int pose_select_linked_poll(bContext *C)
1475 {
1476         return (ED_operator_view3d_active(C) && ED_operator_posemode(C));
1477 }
1478
1479 void POSE_OT_select_linked(wmOperatorType *ot)
1480 {
1481         /* identifiers */
1482         ot->name = "Select Connected";
1483         ot->idname = "POSE_OT_select_linked";
1484         ot->description = "Select bones related to selected ones by parent/child relationships";
1485         
1486         /* api callbacks */
1487         ot->exec = NULL;
1488         ot->invoke = pose_select_connected_invoke;
1489         ot->poll = pose_select_linked_poll;
1490         
1491         /* flags */
1492         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
1493         
1494         /* props */     
1495         RNA_def_boolean(ot->srna, "extend", FALSE, "Extend", "Extend selection instead of deselecting everything first");
1496 }
1497
1498 /* **************** END Posemode stuff ********************** */
1499 /* **************** EditMode stuff ********************** */
1500
1501 /* called in space.c */
1502 /* previously "selectconnected_armature" */
1503 static int armature_select_linked_invoke(bContext *C, wmOperator *op, wmEvent *event)
1504 {
1505         bArmature *arm;
1506         EditBone *bone, *curBone, *next;
1507         int extend = RNA_boolean_get(op->ptr, "extend");
1508         Object *obedit = CTX_data_edit_object(C);
1509         arm = obedit->data;
1510
1511         view3d_operator_needs_opengl(C);
1512
1513         if (extend)
1514                 bone = get_nearest_bone(C, 0, event->mval[0], event->mval[1]);
1515         else
1516                 bone = get_nearest_bone(C, 1, event->mval[0], event->mval[1]);
1517
1518         if (!bone)
1519                 return OPERATOR_CANCELLED;
1520
1521         /* Select parents */
1522         for (curBone = bone; curBone; curBone = next) {
1523                 if ((curBone->flag & BONE_UNSELECTABLE) == 0) {
1524                         if (extend) {
1525                                 curBone->flag &= ~(BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
1526                         }
1527                         else {
1528                                 curBone->flag |= (BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
1529                         }
1530                 }
1531                 
1532                 if (curBone->flag & BONE_CONNECTED)
1533                         next = curBone->parent;
1534                 else
1535                         next = NULL;
1536         }
1537
1538         /* Select children */
1539         while (bone) {
1540                 for (curBone = arm->edbo->first; curBone; curBone = next) {
1541                         next = curBone->next;
1542                         if ((curBone->parent == bone) && (curBone->flag & BONE_UNSELECTABLE) == 0) {
1543                                 if (curBone->flag & BONE_CONNECTED) {
1544                                         if (extend)
1545                                                 curBone->flag &= ~(BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
1546                                         else
1547                                                 curBone->flag |= (BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
1548                                         bone = curBone;
1549                                         break;
1550                                 }
1551                                 else { 
1552                                         bone = NULL;
1553                                         break;
1554                                 }
1555                         }
1556                 }
1557                 if (!curBone)
1558                         bone = NULL;
1559         }
1560         
1561         ED_armature_sync_selection(arm->edbo);
1562         
1563         WM_event_add_notifier(C, NC_OBJECT | ND_BONE_SELECT, obedit);
1564         
1565         return OPERATOR_FINISHED;
1566 }
1567
1568 static int armature_select_linked_poll(bContext *C)
1569 {
1570         return (ED_operator_view3d_active(C) && ED_operator_editarmature(C) );
1571 }
1572
1573 void ARMATURE_OT_select_linked(wmOperatorType *ot)
1574 {
1575         /* identifiers */
1576         ot->name = "Select Connected";
1577         ot->idname = "ARMATURE_OT_select_linked";
1578         ot->description = "Select bones related to selected ones by parent/child relationships";
1579         
1580         /* api callbacks */
1581         ot->exec = NULL;
1582         ot->invoke = armature_select_linked_invoke;
1583         ot->poll = armature_select_linked_poll;
1584         
1585         /* flags */
1586         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
1587         
1588         /* properties */
1589         RNA_def_boolean(ot->srna, "extend", FALSE, "Extend", "Extend selection instead of deselecting everything first");
1590 }
1591
1592 /* does bones and points */
1593 /* note that BONE ROOT only gets drawn for root bones (or without IK) */
1594 static EditBone *get_nearest_editbonepoint(ViewContext *vc, const int mval[2], ListBase *edbo, int findunsel, int *selmask)
1595 {
1596         EditBone *ebone;
1597         rcti rect;
1598         unsigned int buffer[MAXPICKBUF];
1599         unsigned int hitresult, besthitresult = BONESEL_NOSEL;
1600         int i, mindep = 4;
1601         short hits;
1602
1603         glInitNames();
1604         
1605         rect.xmin = mval[0] - 5;
1606         rect.xmax = mval[0] + 5;
1607         rect.ymin = mval[1] - 5;
1608         rect.ymax = mval[1] + 5;
1609
1610         hits = view3d_opengl_select(vc, buffer, MAXPICKBUF, &rect);
1611         if (hits == 0) {
1612                 rect.xmin = mval[0] - 12;
1613                 rect.xmax = mval[0] + 12;
1614                 rect.ymin = mval[1] - 12;
1615                 rect.ymax = mval[1] + 12;
1616                 hits = view3d_opengl_select(vc, buffer, MAXPICKBUF, &rect);
1617         }
1618         /* See if there are any selected bones in this group */
1619         if (hits > 0) {
1620                 
1621                 if (hits == 1) {
1622                         if (!(buffer[3] & BONESEL_NOSEL)) 
1623                                 besthitresult = buffer[3];
1624                 }
1625                 else {
1626                         for (i = 0; i < hits; i++) {
1627                                 hitresult = buffer[3 + (i * 4)];
1628                                 if (!(hitresult & BONESEL_NOSEL)) {
1629                                         int dep;
1630                                         
1631                                         ebone = BLI_findlink(edbo, hitresult & ~BONESEL_ANY);
1632                                         
1633                                         /* clicks on bone points get advantage */
1634                                         if (hitresult & (BONESEL_ROOT | BONESEL_TIP)) {
1635                                                 /* but also the unselected one */
1636                                                 if (findunsel) {
1637                                                         if ( (hitresult & BONESEL_ROOT) && (ebone->flag & BONE_ROOTSEL) == 0)
1638                                                                 dep = 1;
1639                                                         else if ( (hitresult & BONESEL_TIP) && (ebone->flag & BONE_TIPSEL) == 0)
1640                                                                 dep = 1;
1641                                                         else 
1642                                                                 dep = 2;
1643                                                 }
1644                                                 else dep = 2;
1645                                         }
1646                                         else {
1647                                                 /* bone found */
1648                                                 if (findunsel) {
1649                                                         if ((ebone->flag & BONE_SELECTED) == 0)
1650                                                                 dep = 2;
1651                                                         else
1652                                                                 dep = 3;
1653                                                 }
1654                                                 else dep = 3;
1655                                         }
1656                                         if (dep < mindep) {
1657                                                 mindep = dep;
1658                                                 besthitresult = hitresult;
1659                                         }
1660                                 }
1661                         }
1662                 }
1663                 
1664                 if (!(besthitresult & BONESEL_NOSEL)) {
1665                         
1666                         ebone = BLI_findlink(edbo, besthitresult & ~BONESEL_ANY);
1667                         
1668                         *selmask = 0;
1669                         if (besthitresult & BONESEL_ROOT)
1670                                 *selmask |= BONE_ROOTSEL;
1671                         if (besthitresult & BONESEL_TIP)
1672                                 *selmask |= BONE_TIPSEL;
1673                         if (besthitresult & BONESEL_BONE)
1674                                 *selmask |= BONE_SELECTED;
1675                         return ebone;
1676                 }
1677         }
1678         *selmask = 0;
1679         return NULL;
1680 }
1681
1682 /* previously delete_armature */
1683 /* only editmode! */
1684 static int armature_delete_selected_exec(bContext *C, wmOperator *UNUSED(op))
1685 {
1686         bArmature *arm;
1687         EditBone *curBone, *ebone_next;
1688         bConstraint *con;
1689         Object *obedit = CTX_data_edit_object(C); // XXX get from context
1690         arm = obedit->data;
1691
1692         /* cancel if nothing selected */
1693         if (CTX_DATA_COUNT(C, selected_bones) == 0)
1694                 return OPERATOR_CANCELLED;
1695         
1696         armature_select_mirrored(arm);
1697         
1698         /*  First erase any associated pose channel */
1699         if (obedit->pose) {
1700                 bPoseChannel *pchan, *pchan_next;
1701                 for (pchan = obedit->pose->chanbase.first; pchan; pchan = pchan_next) {
1702                         pchan_next = pchan->next;
1703                         curBone = editbone_name_exists(arm->edbo, pchan->name);
1704                         
1705                         if (curBone && (curBone->flag & BONE_SELECTED) && (arm->layer & curBone->layer)) {
1706                                 BKE_pose_channel_free(pchan);
1707                                 BKE_pose_channels_hash_free(obedit->pose);
1708                                 BLI_freelinkN(&obedit->pose->chanbase, pchan);
1709                         }
1710                         else {
1711                                 for (con = pchan->constraints.first; con; con = con->next) {
1712                                         bConstraintTypeInfo *cti = constraint_get_typeinfo(con);
1713                                         ListBase targets = {NULL, NULL};
1714                                         bConstraintTarget *ct;
1715                                         
1716                                         if (cti && cti->get_constraint_targets) {
1717                                                 cti->get_constraint_targets(con, &targets);
1718                                                 
1719                                                 for (ct = targets.first; ct; ct = ct->next) {
1720                                                         if (ct->tar == obedit) {
1721                                                                 if (ct->subtarget[0]) {
1722                                                                         curBone = editbone_name_exists(arm->edbo, ct->subtarget);
1723                                                                         if (curBone && (curBone->flag & BONE_SELECTED) && (arm->layer & curBone->layer)) {
1724                                                                                 con->flag |= CONSTRAINT_DISABLE;
1725                                                                                 ct->subtarget[0] = 0;
1726                                                                         }
1727                                                                 }
1728                                                         }
1729                                                 }
1730                                                 
1731                                                 if (cti->flush_constraint_targets)
1732                                                         cti->flush_constraint_targets(con, &targets, 0);
1733                                         }
1734                                 }
1735                         }
1736                 }
1737         }
1738         
1739         
1740         for (curBone = arm->edbo->first; curBone; curBone = ebone_next) {
1741                 ebone_next = curBone->next;
1742                 if (arm->layer & curBone->layer) {
1743                         if (curBone->flag & BONE_SELECTED) {
1744                                 if (curBone == arm->act_edbone) arm->act_edbone = NULL;
1745                                 ED_armature_edit_bone_remove(arm, curBone);
1746                         }
1747                 }
1748         }
1749         
1750         
1751         ED_armature_sync_selection(arm->edbo);
1752
1753         WM_event_add_notifier(C, NC_OBJECT | ND_BONE_SELECT, obedit);
1754
1755         return OPERATOR_FINISHED;
1756 }
1757
1758 void ARMATURE_OT_delete(wmOperatorType *ot)
1759 {
1760         /* identifiers */
1761         ot->name = "Delete Selected Bone(s)";
1762         ot->idname = "ARMATURE_OT_delete";
1763         ot->description = "Remove selected bones from the armature";
1764         
1765         /* api callbacks */
1766         ot->invoke = WM_operator_confirm;
1767         ot->exec = armature_delete_selected_exec;
1768         ot->poll = ED_operator_editarmature;
1769         
1770         /* flags */
1771         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
1772 }
1773
1774 /* toggle==0: deselect
1775  * toggle==1: swap (based on test)
1776  * toggle==2: swap (no test), CURRENTLY UNUSED
1777  */
1778 void ED_armature_deselect_all(Object *obedit, int toggle)
1779 {
1780         bArmature *arm = obedit->data;
1781         EditBone    *eBone;
1782         int sel = 1;
1783         
1784         if (toggle == 1) {
1785                 /* Determine if there are any selected bones
1786                  * and therefore whether we are selecting or deselecting */
1787                 for (eBone = arm->edbo->first; eBone; eBone = eBone->next) {
1788                         //                      if (arm->layer & eBone->layer) {
1789                         if (eBone->flag & (BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL)) {
1790                                 sel = 0;
1791                                 break;
1792                         }
1793                         //                      }
1794                 }
1795         }
1796         else sel = toggle;
1797         
1798         /*      Set the flags */
1799         for (eBone = arm->edbo->first; eBone; eBone = eBone->next) {
1800                 if (sel == 2) {
1801                         /* invert selection of bone */
1802                         if (EBONE_VISIBLE(arm, eBone)) {
1803                                 eBone->flag ^= (BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
1804                                 if (arm->act_edbone == eBone)
1805                                         arm->act_edbone = NULL;
1806                         }
1807                 }
1808                 else if (sel == 1) {
1809                         /* select bone */
1810                         if (EBONE_VISIBLE(arm, eBone)) {
1811                                 eBone->flag |= (BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
1812                                 if (eBone->parent)
1813                                         eBone->parent->flag |= (BONE_TIPSEL);
1814                         }
1815                 }
1816                 else {
1817                         /* deselect bone */
1818                         eBone->flag &= ~(BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
1819                         if (arm->act_edbone == eBone)
1820                                 arm->act_edbone = NULL;
1821                 }
1822         }
1823         
1824         ED_armature_sync_selection(arm->edbo);
1825 }
1826
1827 void ED_armature_deselect_all_visible(Object *obedit)
1828 {
1829         bArmature *arm = obedit->data;
1830         EditBone    *ebone;
1831
1832         for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
1833                 /* first and foremost, bone must be visible and selected */
1834                 if (EBONE_VISIBLE(arm, ebone) && (ebone->flag & BONE_UNSELECTABLE) == 0) {
1835                         ebone->flag &= ~(BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
1836                 }
1837         }
1838
1839         ED_armature_sync_selection(arm->edbo);
1840 }
1841
1842 /* accounts for connected parents */
1843 static int ebone_select_flag(EditBone *ebone)
1844 {
1845         if (ebone->parent && (ebone->flag & BONE_CONNECTED)) {
1846                 return ((ebone->parent->flag & BONE_TIPSEL) ? BONE_ROOTSEL : 0) | (ebone->flag & (BONE_SELECTED | BONE_TIPSEL));
1847         }
1848         else {
1849                 return ebone->flag & (BONE_SELECTED | BONE_ROOTSEL | BONE_TIPSEL);
1850         }
1851 }
1852
1853 /* context: editmode armature in view3d */
1854 int mouse_armature(bContext *C, const int mval[2], int extend, int deselect, int toggle)
1855 {
1856         Object *obedit = CTX_data_edit_object(C);
1857         bArmature *arm = obedit->data;
1858         ViewContext vc;
1859         EditBone *nearBone = NULL;
1860         int selmask;
1861
1862         view3d_set_viewcontext(C, &vc);
1863         
1864         BIF_sk_selectStroke(C, mval, extend);
1865         
1866         nearBone = get_nearest_editbonepoint(&vc, mval, arm->edbo, 1, &selmask);
1867         if (nearBone) {
1868
1869                 if (!extend && !deselect && !toggle)
1870                         ED_armature_deselect_all(obedit, 0);
1871                 
1872                 /* by definition the non-root connected bones have no root point drawn,
1873                  * so a root selection needs to be delivered to the parent tip */
1874                 
1875                 if (selmask & BONE_SELECTED) {
1876                         if (nearBone->parent && (nearBone->flag & BONE_CONNECTED)) {
1877                                 /* click in a chain */
1878                                 if (extend) {
1879                                         /* select this bone */
1880                                         nearBone->flag |= BONE_TIPSEL;
1881                                         nearBone->parent->flag |= BONE_TIPSEL;
1882                                 }
1883                                 else if (deselect) {
1884                                         /* deselect this bone */
1885                                         nearBone->flag &= ~(BONE_TIPSEL | BONE_SELECTED);
1886                                         /* only deselect parent tip if it is not selected */
1887                                         if (!(nearBone->parent->flag & BONE_SELECTED))
1888                                                 nearBone->parent->flag &= ~BONE_TIPSEL;
1889                                 }
1890                                 else if (toggle) {
1891                                         /* hold shift inverts this bone's selection */
1892                                         if (nearBone->flag & BONE_SELECTED) {
1893                                                 /* deselect this bone */
1894                                                 nearBone->flag &= ~(BONE_TIPSEL | BONE_SELECTED);
1895                                                 /* only deselect parent tip if it is not selected */
1896                                                 if (!(nearBone->parent->flag & BONE_SELECTED))
1897                                                         nearBone->parent->flag &= ~BONE_TIPSEL;
1898                                         }
1899                                         else {
1900                                                 /* select this bone */
1901                                                 nearBone->flag |= BONE_TIPSEL;
1902                                                 nearBone->parent->flag |= BONE_TIPSEL;
1903                                         }
1904                                 }
1905                                 else {
1906                                         /* select this bone */
1907                                         nearBone->flag |= BONE_TIPSEL;
1908                                         nearBone->parent->flag |= BONE_TIPSEL;
1909                                 }
1910                         }
1911                         else {
1912                                 if (extend) {
1913                                         nearBone->flag |= (BONE_TIPSEL | BONE_ROOTSEL);
1914                                 }
1915                                 else if (deselect) {
1916                                         nearBone->flag &= ~(BONE_TIPSEL | BONE_ROOTSEL);
1917                                 }
1918                                 else if (toggle) {
1919                                         /* hold shift inverts this bone's selection */
1920                                         if (nearBone->flag & BONE_SELECTED)
1921                                                 nearBone->flag &= ~(BONE_TIPSEL | BONE_ROOTSEL);
1922                                         else
1923                                                 nearBone->flag |= (BONE_TIPSEL | BONE_ROOTSEL);
1924                                 }
1925                                 else
1926                                         nearBone->flag |= (BONE_TIPSEL | BONE_ROOTSEL);
1927                         }
1928                 }
1929                 else {
1930                         if (extend)
1931                                 nearBone->flag |= selmask;
1932                         else if (deselect)
1933                                 nearBone->flag &= ~selmask;
1934                         else if (toggle && (nearBone->flag & selmask))
1935                                 nearBone->flag &= ~selmask;
1936                         else
1937                                 nearBone->flag |= selmask;
1938                 }
1939                 
1940                 ED_armature_sync_selection(arm->edbo);
1941                 
1942                 if (nearBone) {
1943                         /* then now check for active status */
1944                         if (ebone_select_flag(nearBone)) {
1945                                 arm->act_edbone = nearBone;
1946                         }
1947                 }
1948                 
1949                 WM_event_add_notifier(C, NC_OBJECT | ND_BONE_SELECT, vc.obedit);
1950                 return 1;
1951         }
1952
1953         return 0;
1954 }
1955
1956 void ED_armature_edit_free(struct Object *ob)
1957 {
1958         bArmature *arm = ob->data;
1959         EditBone *eBone;
1960         
1961         /*      Clear the editbones list */
1962         if (arm->edbo) {
1963                 if (arm->edbo->first) {
1964                         for (eBone = arm->edbo->first; eBone; eBone = eBone->next) {
1965                                 if (eBone->prop) {
1966                                         IDP_FreeProperty(eBone->prop);
1967                                         MEM_freeN(eBone->prop);
1968                                 }
1969                         }
1970
1971                         BLI_freelistN(arm->edbo);
1972                 }
1973                 MEM_freeN(arm->edbo);
1974                 arm->edbo = NULL;
1975         }
1976 }
1977
1978 /* Put armature in EditMode */
1979 void ED_armature_to_edit(Object *ob)
1980 {
1981         bArmature *arm = ob->data;
1982         
1983         ED_armature_edit_free(ob);
1984         arm->edbo = MEM_callocN(sizeof(ListBase), "edbo armature");
1985         arm->act_edbone = make_boneList(arm->edbo, &arm->bonebase, NULL, arm->act_bone);
1986         arm->act_bone = NULL;
1987
1988 //      BIF_freeTemplates(); /* force template update when entering editmode */
1989 }
1990
1991
1992 /* adjust bone roll to align Z axis with vector
1993  * vec is in local space and is normalized
1994  */
1995
1996 float ED_rollBoneToVector(EditBone *bone, const float align_axis[3], const short axis_only)
1997 {
1998         float mat[3][3], nor[3];
1999
2000         sub_v3_v3v3(nor, bone->tail, bone->head);
2001         vec_roll_to_mat3(nor, 0.0f, mat);
2002
2003         /* check the bone isn't aligned with the axis */
2004         if (!is_zero_v3(align_axis) && angle_v3v3(align_axis, mat[2]) > FLT_EPSILON) {
2005                 float vec[3], align_axis_proj[3], roll;
2006
2007                 /* project the new_up_axis along the normal */
2008                 project_v3_v3v3(vec, align_axis, nor);
2009                 sub_v3_v3v3(align_axis_proj, align_axis, vec);
2010                 
2011                 if (axis_only) {
2012                         if (angle_v3v3(align_axis_proj, mat[2]) > (float)(M_PI / 2.0)) {
2013                                 negate_v3(align_axis_proj);
2014                         }
2015                 }
2016                 
2017                 roll = angle_v3v3(align_axis_proj, mat[2]);
2018                 
2019                 cross_v3_v3v3(vec, mat[2], align_axis_proj);
2020                 
2021                 if (dot_v3v3(vec, nor) < 0) {
2022                         roll = -roll;
2023                 }
2024
2025                 return roll;
2026         }
2027
2028         return 0.0f;
2029 }
2030
2031
2032 static EnumPropertyItem prop_calc_roll_types[] = {
2033         {0, "X", 0, "X Axis", ""},
2034         {1, "Y", 0, "Y Axis", ""},
2035         {2, "Z", 0, "Z Axis", ""},
2036         {5, "ACTIVE", 0, "Active Bone", ""},
2037         {6, "VIEW", 0, "View Axis", ""},
2038         {7, "CURSOR", 0, "Cursor", ""},
2039         {0, NULL, 0, NULL, NULL}
2040 };
2041
2042
2043 static int armature_calc_roll_exec(bContext *C, wmOperator *op) 
2044 {
2045         Object *ob = CTX_data_edit_object(C);
2046         const short type = RNA_enum_get(op->ptr, "type");
2047         const short axis_only = RNA_boolean_get(op->ptr, "axis_only");
2048         const short axis_flip = RNA_boolean_get(op->ptr, "axis_flip");
2049
2050         float imat[3][3];
2051
2052         bArmature *arm = ob->data;
2053         EditBone *ebone;
2054
2055         copy_m3_m4(imat, ob->obmat);
2056         invert_m3(imat);
2057
2058         if (type == 7) { /* Cursor */
2059                 Scene *scene = CTX_data_scene(C);
2060                 View3D *v3d = CTX_wm_view3d(C); /* can be NULL */
2061                 float cursor_local[3];
2062                 float   *cursor = give_cursor(scene, v3d);
2063         
2064
2065                 copy_v3_v3(cursor_local, cursor);
2066                 mul_m3_v3(imat, cursor_local);
2067
2068                 /* cursor */
2069                 for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
2070                         if (EBONE_VISIBLE(arm, ebone) && EBONE_EDITABLE(ebone)) {
2071                                 float cursor_rel[3];
2072                                 sub_v3_v3v3(cursor_rel, cursor_local, ebone->head);
2073                                 if (axis_flip) negate_v3(cursor_rel);
2074                                 ebone->roll = ED_rollBoneToVector(ebone, cursor_rel, axis_only);
2075                         }
2076                 }
2077         }
2078         else {
2079                 float vec[3] = {0.0f, 0.0f, 0.0f};
2080                 if (type == 6) { /* View */
2081                         RegionView3D *rv3d = CTX_wm_region_view3d(C);
2082                         if (rv3d == NULL) {
2083                                 BKE_report(op->reports, RPT_ERROR, "No region view3d available");
2084                                 return OPERATOR_CANCELLED;
2085                         }
2086
2087                         copy_v3_v3(vec, rv3d->viewinv[2]);
2088                         mul_m3_v3(imat, vec);
2089                 }
2090                 else if (type == 5) {
2091                         float mat[3][3], nor[3];
2092                         ebone = (EditBone *)arm->act_edbone;
2093                         if (ebone == NULL) {
2094                                 BKE_report(op->reports, RPT_ERROR, "No active bone set");
2095                                 return OPERATOR_CANCELLED;
2096                         }
2097
2098                         sub_v3_v3v3(nor, ebone->tail, ebone->head);
2099                         vec_roll_to_mat3(nor, ebone->roll, mat);                        
2100                         copy_v3_v3(vec, mat[2]);
2101                 }
2102                 else { /* Axis */
2103                         assert(type >= 0 && type <= 5);
2104                         if (type < 3) vec[type] = 1.0f;
2105                         else vec[type - 2] = -1.0f;
2106                         mul_m3_v3(imat, vec);
2107                 }
2108
2109                 if (axis_flip) negate_v3(vec);
2110
2111                 for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
2112                         if (EBONE_VISIBLE(arm, ebone) && EBONE_EDITABLE(ebone)) {
2113                                 /* roll func is a callback which assumes that all is well */
2114                                 ebone->roll = ED_rollBoneToVector(ebone, vec, axis_only);
2115                         }
2116                 }
2117         }
2118
2119         if (arm->flag & ARM_MIRROR_EDIT) {
2120                 for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
2121                         if ((EBONE_VISIBLE(arm, ebone) && EBONE_EDITABLE(ebone)) == 0) {
2122                                 EditBone *ebone_mirr = ED_armature_bone_get_mirrored(arm->edbo, ebone);
2123                                 if (ebone_mirr && (EBONE_VISIBLE(arm, ebone_mirr) && EBONE_EDITABLE(ebone_mirr))) {
2124                                         ebone->roll = -ebone_mirr->roll;
2125                                 }
2126                         }
2127                 }
2128         }
2129
2130         /* note, notifier might evolve */
2131         WM_event_add_notifier(C, NC_OBJECT | ND_POSE, ob);
2132         
2133         return OPERATOR_FINISHED;
2134 }
2135
2136 void ARMATURE_OT_calculate_roll(wmOperatorType *ot)
2137 {
2138         /* identifiers */
2139         ot->name = "Recalculate Roll";
2140         ot->idname = "ARMATURE_OT_calculate_roll";
2141         ot->description = "Automatically fix alignment of select bones' axes";
2142         
2143         /* api callbacks */
2144         ot->invoke = WM_menu_invoke;
2145         ot->exec = armature_calc_roll_exec;
2146         ot->poll = ED_operator_editarmature;
2147         
2148         /* flags */
2149         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
2150
2151         /* properties */
2152         ot->prop = RNA_def_enum(ot->srna, "type", prop_calc_roll_types, 0, "Type", "");
2153         RNA_def_boolean(ot->srna, "axis_flip", 0, "Flip Axis", "Negate the alignment axis");
2154         RNA_def_boolean(ot->srna, "axis_only", 0, "Shortest Rotation", "Ignore the axis direction, use the shortest rotation to align");
2155 }
2156
2157 /* **************** undo for armatures ************** */
2158
2159 typedef struct UndoArmature {
2160         EditBone *act_edbone;
2161         ListBase lb;
2162 } UndoArmature;
2163
2164 static void undoBones_to_editBones(void *uarmv, void *armv, void *UNUSED(data))
2165 {
2166         UndoArmature *uarm = uarmv;
2167         bArmature *arm = armv;
2168         EditBone *ebo, *newebo;
2169         
2170         BLI_freelistN(arm->edbo);
2171         
2172         /* copy  */
2173         for (ebo = uarm->lb.first; ebo; ebo = ebo->next) {
2174                 newebo = MEM_dupallocN(ebo);
2175                 ebo->temp = newebo;
2176                 BLI_addtail(arm->edbo, newebo);
2177         }
2178         
2179         /* active bone */
2180         if (uarm->act_edbone) {
2181                 ebo = uarm->act_edbone;
2182                 arm->act_edbone = ebo->temp;
2183         }
2184         else
2185                 arm->act_edbone = NULL;
2186
2187         /* set pointers */
2188         for (newebo = arm->edbo->first; newebo; newebo = newebo->next) {
2189                 if (newebo->parent) newebo->parent = newebo->parent->temp;
2190         }
2191         /* be sure they don't hang ever */
2192         for (newebo = arm->edbo->first; newebo; newebo = newebo->next) {
2193                 newebo->temp = NULL;
2194         }
2195 }
2196
2197 static void *editBones_to_undoBones(void *armv, void *UNUSED(obdata))
2198 {
2199         bArmature *arm = armv;
2200         UndoArmature *uarm;
2201         EditBone *ebo, *newebo;
2202         
2203         uarm = MEM_callocN(sizeof(UndoArmature), "listbase undo");
2204         
2205         /* copy */
2206         for (ebo = arm->edbo->first; ebo; ebo = ebo->next) {
2207                 newebo = MEM_dupallocN(ebo);
2208                 ebo->temp = newebo;
2209                 BLI_addtail(&uarm->lb, newebo);
2210         }
2211         
2212         /* active bone */
2213         if (arm->act_edbone) {
2214                 ebo = arm->act_edbone;
2215                 uarm->act_edbone = ebo->temp;
2216         }
2217
2218         /* set pointers */
2219         for (newebo = uarm->lb.first; newebo; newebo = newebo->next) {
2220                 if (newebo->parent) newebo->parent = newebo->parent->temp;
2221         }
2222         
2223         return uarm;
2224 }
2225
2226 static void free_undoBones(void *uarmv)
2227 {
2228         UndoArmature *uarm = uarmv;
2229         
2230         BLI_freelistN(&uarm->lb);
2231         MEM_freeN(uarm);
2232 }
2233
2234 static void *get_armature_edit(bContext *C)
2235 {
2236         Object *obedit = CTX_data_edit_object(C);
2237         if (obedit && obedit->type == OB_ARMATURE) {
2238                 return obedit->data;
2239         }
2240         return NULL;
2241 }
2242
2243 /* and this is all the undo system needs to know */
2244 void undo_push_armature(bContext *C, const char *name)
2245 {
2246         // XXX solve getdata()
2247         undo_editmode_push(C, name, get_armature_edit, free_undoBones, undoBones_to_editBones, editBones_to_undoBones, NULL);
2248 }
2249
2250
2251
2252 /* **************** END EditMode stuff ********************** */
2253 /* *************** Adding stuff in editmode *************** */
2254
2255 /* default bone add, returns it selected, but without tail set */
2256 EditBone *ED_armature_edit_bone_add(bArmature *arm, const char *name)
2257 {
2258         EditBone *bone = MEM_callocN(sizeof(EditBone), "eBone");
2259         
2260         BLI_strncpy(bone->name, name, sizeof(bone->name));
2261         unique_editbone_name(arm->edbo, bone->name, NULL);
2262         
2263         BLI_addtail(arm->edbo, bone);
2264         
2265         bone->flag |= BONE_TIPSEL;
2266         bone->weight = 1.0f;
2267         bone->dist = 0.25f;
2268         bone->xwidth = 0.1f;
2269         bone->zwidth = 0.1f;
2270         bone->ease1 = 1.0f;
2271         bone->ease2 = 1.0f;
2272         bone->rad_head = 0.10f;
2273         bone->rad_tail = 0.05f;
2274         bone->segments = 1;
2275         bone->layer = arm->layer;
2276         
2277         return bone;
2278 }
2279
2280 /* v3d and rv3d are allowed to be NULL */
2281 void add_primitive_bone(Scene *scene, View3D *v3d, RegionView3D *rv3d)
2282 {
2283         Object *obedit = scene->obedit; // XXX get from context
2284         bArmature *arm = obedit->data;
2285         float obmat[3][3], curs[3], viewmat[3][3], totmat[3][3], imat[3][3];
2286         EditBone    *bone;
2287
2288         /* Get inverse point for head and orientation for tail */
2289         invert_m4_m4(obedit->imat, obedit->obmat);
2290         mul_v3_m4v3(curs, obedit->imat, give_cursor(scene, v3d));
2291
2292         if (rv3d && (U.flag & USER_ADD_VIEWALIGNED))
2293                 copy_m3_m4(obmat, rv3d->viewmat);
2294         else unit_m3(obmat);
2295         
2296         copy_m3_m4(viewmat, obedit->obmat);
2297         mul_m3_m3m3(totmat, obmat, viewmat);
2298         invert_m3_m3(imat, totmat);
2299         
2300         ED_armature_deselect_all(obedit, 0);
2301         
2302         /* Create a bone */
2303         bone = ED_armature_edit_bone_add(arm, "Bone");
2304
2305         arm->act_edbone = bone;
2306
2307         copy_v3_v3(bone->head, curs);
2308         
2309         if (rv3d && (U.flag & USER_ADD_VIEWALIGNED))
2310                 add_v3_v3v3(bone->tail, bone->head, imat[1]);   // bone with unit length 1
2311         else
2312                 add_v3_v3v3(bone->tail, bone->head, imat[2]);   // bone with unit length 1, pointing up Z
2313 }
2314
2315
2316 /* previously addvert_armature */
2317 /* the ctrl-click method */
2318 static int armature_click_extrude_exec(bContext *C, wmOperator *UNUSED(op))
2319 {
2320         View3D *v3d;
2321         bArmature *arm;
2322         EditBone *ebone, *newbone, *flipbone;
2323         float *curs, mat[3][3], imat[3][3];
2324         int a, to_root = 0;
2325         Object *obedit;
2326         Scene *scene;
2327
2328         scene = CTX_data_scene(C);
2329         v3d = CTX_wm_view3d(C);
2330         obedit = CTX_data_edit_object(C);
2331         arm = obedit->data;
2332         
2333         /* find the active or selected bone */
2334         for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
2335                 if (EBONE_VISIBLE(arm, ebone)) {
2336                         if (ebone->flag & BONE_TIPSEL || arm->act_edbone == ebone)
2337                                 break;
2338                 }
2339         }
2340         
2341         if (ebone == NULL) {
2342                 for (ebone = arm->edbo->first; ebone; ebone = ebone->next) {
2343                         if (EBONE_VISIBLE(arm, ebone)) {
2344                                 if (ebone->flag & BONE_ROOTSEL || arm->act_edbone == ebone)
2345                                         break;
2346                         }
2347                 }
2348                 if (ebone == NULL) 
2349                         return OPERATOR_CANCELLED;
2350                 
2351                 to_root = 1;
2352         }
2353         
2354         ED_armature_deselect_all(obedit, 0);
2355         
2356         /* we re-use code for mirror editing... */
2357         flipbone = NULL;
2358         if (arm->flag & ARM_MIRROR_EDIT)
2359                 flipbone = ED_armature_bone_get_mirrored(arm->edbo, ebone);
2360
2361         for (a = 0; a < 2; a++) {
2362                 if (a == 1) {
2363                         if (flipbone == NULL)
2364                                 break;
2365                         else {
2366                                 SWAP(EditBone *, flipbone, ebone);
2367                         }
2368                 }
2369                 
2370                 newbone = ED_armature_edit_bone_add(arm, ebone->name);
2371                 arm->act_edbone = newbone;
2372                 
2373                 if (to_root) {
2374                         copy_v3_v3(newbone->head, ebone->head);
2375                         newbone->rad_head = ebone->rad_tail;
2376                         newbone->parent = ebone->parent;
2377                 }
2378                 else {
2379                         copy_v3_v3(newbone->head, ebone->tail);
2380                         newbone->rad_head = ebone->rad_tail;
2381                         newbone->parent = ebone;
2382                         newbone->flag |= BONE_CONNECTED;
2383                 }
2384                 
2385                 curs = give_cursor(scene, v3d);
2386                 copy_v3_v3(newbone->tail, curs);
2387                 sub_v3_v3v3(newbone->tail, newbone->tail, obedit->obmat[3]);
2388                 
2389                 if (a == 1)
2390                         newbone->tail[0] = -newbone->tail[0];
2391                 
2392                 copy_m3_m4(mat, obedit->obmat);
2393                 invert_m3_m3(imat, mat);
2394                 mul_m3_v3(imat, newbone->tail);
2395                 
2396                 newbone->length = len_v3v3(newbone->head, newbone->tail);
2397                 newbone->rad_tail = newbone->length * 0.05f;
2398                 newbone->dist = newbone->length * 0.25f;
2399                 
2400         }
2401         
2402         ED_armature_sync_selection(arm->edbo);
2403
2404         WM_event_add_notifier(C, NC_OBJECT | ND_BONE_SELECT, obedit);
2405         
2406         return OPERATOR_FINISHED;
2407 }
2408
2409 static int armature_click_extrude_invoke(bContext *C, wmOperator *op, wmEvent *event)
2410 {
2411         /* TODO most of this code is copied from set3dcursor_invoke,
2412          * it would be better to reuse code in set3dcursor_invoke */
2413
2414         /* temporarily change 3d cursor position */
2415         Scene *scene;
2416         ARegion *ar;
2417         View3D *v3d;
2418         float *fp = NULL, tvec[3], oldcurs[3], mval_f[2];
2419         int retv;
2420
2421         scene = CTX_data_scene(C);
2422         ar = CTX_wm_region(C);
2423         v3d = CTX_wm_view3d(C);
2424         
2425         fp = give_cursor(scene, v3d);
2426         
2427         copy_v3_v3(oldcurs, fp);
2428
2429         VECCOPY2D(mval_f, event->mval);
2430         ED_view3d_win_to_3d(ar, fp, mval_f, tvec);
2431         copy_v3_v3(fp, tvec);
2432
2433         /* extrude to the where new cursor is and store the operation result */
2434         retv = armature_click_extrude_exec(C, op);
2435
2436         /* restore previous 3d cursor position */
2437         copy_v3_v3(fp, oldcurs);
2438
2439         return retv;
2440 }
2441
2442 void ARMATURE_OT_click_extrude(wmOperatorType *ot)
2443 {
2444         /* identifiers */
2445         ot->name = "Click-Extrude";
2446         ot->idname = "ARMATURE_OT_click_extrude";
2447         ot->description = "Create a new bone going from the last selected joint to the mouse position";
2448         
2449         /* api callbacks */
2450         ot->invoke = armature_click_extrude_invoke;
2451         ot->exec = armature_click_extrude_exec;
2452         ot->poll = ED_operator_editarmature;
2453         
2454         /* flags */
2455         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
2456
2457         /* props */
2458 }
2459
2460 /* adds an EditBone between the nominated locations (should be in the right space) */
2461 static EditBone *add_points_bone(Object *obedit, float head[], float tail[])
2462 {
2463         EditBone *ebo;
2464         
2465         ebo = ED_armature_edit_bone_add(obedit->data, "Bone");
2466         
2467         copy_v3_v3(ebo->head, head);
2468         copy_v3_v3(ebo->tail, tail);
2469         
2470         return ebo;
2471 }
2472
2473
2474 static EditBone *get_named_editbone(ListBase *edbo, char *name)
2475 {
2476         EditBone  *eBone;
2477
2478         if (name) {
2479                 for (eBone = edbo->first; eBone; eBone = eBone->next) {
2480                         if (!strcmp(name, eBone->name))
2481                                 return eBone;
2482                 }
2483         }
2484
2485         return NULL;
2486 }
2487
2488 /* Call this before doing any duplications
2489  * */
2490 void preEditBoneDuplicate(ListBase *editbones)
2491 {
2492         EditBone *eBone;
2493         
2494         /* clear temp */
2495         for (eBone = editbones->first; eBone; eBone = eBone->next) {
2496                 eBone->temp = NULL;
2497         }
2498 }
2499
2500 /*
2501  * Note: When duplicating cross objects, editbones here is the list of bones
2502  * from the SOURCE object but ob is the DESTINATION object
2503  * */
2504 void updateDuplicateSubtargetObjects(EditBone *dupBone, ListBase *editbones, Object *src_ob, Object *dst_ob)
2505 {
2506         /* If an edit bone has been duplicated, lets
2507          * update it's constraints if the subtarget
2508          * they point to has also been duplicated
2509          */
2510         EditBone     *oldtarget, *newtarget;
2511         bPoseChannel *pchan;
2512         bConstraint  *curcon;
2513         ListBase     *conlist;
2514         
2515         if ( (pchan = BKE_pose_channel_verify(dst_ob->pose, dupBone->name)) ) {
2516                 if ( (conlist = &pchan->constraints) ) {
2517                         for (curcon = conlist->first; curcon; curcon = curcon->next) {
2518                                 /* does this constraint have a subtarget in
2519                                  * this armature?
2520                                  */
2521                                 bConstraintTypeInfo *cti = constraint_get_typeinfo(curcon);
2522                                 ListBase targets = {NULL, NULL};
2523                                 bConstraintTarget *ct;
2524                                 
2525                                 if (cti && cti->get_constraint_targets) {
2526                                         cti->get_constraint_targets(curcon, &targets);
2527                                         
2528                                         for (ct = targets.first; ct; ct = ct->next) {
2529                                                 if ((ct->tar == src_ob) && (ct->subtarget[0])) {
2530                                                         ct->tar = dst_ob; /* update target */ 
2531                                                         oldtarget = get_named_editbone(editbones, ct->subtarget);
2532                                                         if (oldtarget) {
2533                                                                 /* was the subtarget bone duplicated too? If
2534                                                                  * so, update the constraint to point at the 
2535                                                                  * duplicate of the old subtarget.
2536                                                                  */
2537                                                                 if (oldtarget->temp) {
2538                                                                         newtarget = (EditBone *) oldtarget->temp;
2539                                                                         BLI_strncpy(ct->subtarget, newtarget->name, sizeof(ct->subtarget));
2540                                                                 }
2541                                                         }
2542                                                 }
2543                                         }
2544                                         
2545                                         if (cti->flush_constraint_targets)
2546                                                 cti->flush_constraint_targets(curcon, &targets, 0);
2547                                 }
2548                         }
2549                 }
2550         }
2551 }
2552
2553 void updateDuplicateSubtarget(EditBone *dupBone, ListBase *editbones, Object *ob)
2554 {
2555         updateDuplicateSubtargetObjects(dupBone, editbones, ob, ob);
2556 }
2557
2558
2559 EditBone *duplicateEditBoneObjects(EditBone *curBone, const char *name, ListBase *editbones, Object *src_ob, Object *dst_ob)
2560 {
2561         EditBone *eBone = MEM_mallocN(sizeof(EditBone), "addup_editbone");
2562         
2563         /*      Copy data from old bone to new bone */
2564         memcpy(eBone, curBone, sizeof(EditBone));
2565         
2566         curBone->temp = eBone;
2567         eBone->temp = curBone;
2568         
2569         if (name != NULL) {
2570                 BLI_strncpy(eBone->name, name, sizeof(eBone->name));
2571         }
2572
2573         unique_editbone_name(editbones, eBone->name, NULL);
2574         BLI_addtail(editbones, eBone);
2575         
2576         /* copy the ID property */
2577         if (curBone->prop)
2578                 eBone->prop = IDP_CopyProperty(curBone->prop);
2579
2580         /* Lets duplicate the list of constraints that the
2581          * current bone has.
2582          */
2583         if (src_ob->pose) {
2584                 bPoseChannel *chanold, *channew;
2585                 
2586                 chanold = BKE_pose_channel_verify(src_ob->pose, curBone->name);
2587                 if (chanold) {
2588                         /* WARNING: this creates a new posechannel, but there will not be an attached bone
2589                          *              yet as the new bones created here are still 'EditBones' not 'Bones'.
2590                          */
2591                         channew = BKE_pose_channel_verify(dst_ob->pose, eBone->name);
2592
2593                         if (channew) {
2594                                 BKE_pose_channel_copy_data(channew, chanold);
2595                         }
2596                 }
2597         }
2598         
2599         return eBone;
2600 }
2601
2602 EditBone *duplicateEditBone(EditBone *curBone, const char *name, ListBase *editbones, Object *ob)
2603 {
2604         return duplicateEditBoneObjects(curBone, name, editbones, ob, ob);
2605 }
2606
2607 /* previously adduplicate_armature */
2608 static int armature_duplicate_selected_exec(bContext *C, wmOperator *UNUSED(op))
2609 {
2610         bArmature *arm;
2611         EditBone    *eBone = NULL;
2612         EditBone    *curBone;
2613         EditBone    *firstDup = NULL; /*        The beginning of the duplicated bones in the edbo list */
2614
2615         Object *obedit = CTX_data_edit_object(C);
2616         arm = obedit->data;
2617
2618         /* cancel if nothing selected */
2619         if (CTX_DATA_COUNT(C, selected_bones) == 0)
2620                 return OPERATOR_CANCELLED;
2621         
2622         ED_armature_sync_selection(arm->edbo); // XXX why is this needed?
2623
2624         preEditBoneDuplicate(arm->edbo);
2625
2626         /* Select mirrored bones */
2627         if (arm->flag & ARM_MIRROR_EDIT) {
2628                 for (curBone = arm->edbo->first; curBone; curBone = curBone->next) {
2629                         if (EBONE_VISIBLE(arm, curBone)) {
2630                                 if (curBone->flag & BONE_SELECTED) {
2631                                         eBone = ED_armature_bone_get_mirrored(arm->edbo, curBone);
2632                                         if (eBone)
2633                                                 eBone->flag |= BONE_SELECTED;
2634                                 }
2635                         }
2636                 }
2637         }
2638
2639         
2640         /*      Find the selected bones and duplicate them as needed */
2641         for (curBone = arm->edbo->first; curBone && curBone != firstDup; curBone = curBone->next) {
2642                 if (EBONE_VISIBLE(arm, curBone)) {
2643                         if (curBone->flag & BONE_SELECTED) {
2644                                 
2645                                 eBone = duplicateEditBone(curBone, curBone->name, arm->edbo, obedit);
2646                                 
2647                                 if (!firstDup)
2648                                         firstDup = eBone;
2649
2650                         }
2651                 }
2652         }
2653
2654         /*      Run though the list and fix the pointers */
2655         for (curBone = arm->edbo->first; curBone && curBone != firstDup; curBone = curBone->next) {
2656                 if (EBONE_VISIBLE(arm, curBone)) {
2657                         if (curBone->flag & BONE_SELECTED) {
2658                                 eBone = (EditBone *) curBone->temp;
2659                                 
2660                                 if (!curBone->parent) {
2661                                         /* If this bone has no parent,
2662                                          * Set the duplicate->parent to NULL
2663                                          */
2664                                         eBone->parent = NULL;
2665                                 }
2666                                 else if (curBone->parent->temp) {
2667                                         /* If this bone has a parent that was duplicated,
2668                                          * Set the duplicate->parent to the curBone->parent->temp
2669                                          */
2670                                         eBone->parent = (EditBone *)curBone->parent->temp;
2671                                 }
2672                                 else {
2673                                         /* If this bone has a parent that IS not selected,
2674                                          * Set the duplicate->parent to the curBone->parent
2675                                          */
2676                                         eBone->parent = (EditBone *) curBone->parent;
2677                                         eBone->flag &= ~BONE_CONNECTED;
2678                                 }
2679                                 
2680                                 /* Lets try to fix any constraint subtargets that might
2681                                  * have been duplicated 
2682                                  */
2683                                 updateDuplicateSubtarget(eBone, arm->edbo, obedit);
2684                         }
2685                 }
2686         } 
2687         
2688         /* correct the active bone */
2689         if (arm->act_edbone) {
2690                 eBone = arm->act_edbone;
2691                 if (eBone->temp)
2692                         arm->act_edbone = eBone->temp;
2693         }
2694
2695         /*      Deselect the old bones and select the new ones */
2696         for (curBone = arm->edbo->first; curBone && curBone != firstDup; curBone = curBone->next) {
2697                 if (EBONE_VISIBLE(arm, curBone))
2698                         curBone->flag &= ~(BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
2699         }
2700
2701         ED_armature_validate_active(arm);
2702
2703         WM_event_add_notifier(C, NC_OBJECT | ND_BONE_SELECT, obedit);
2704         
2705         return OPERATOR_FINISHED;
2706 }
2707
2708
2709 void ARMATURE_OT_duplicate(wmOperatorType *ot)
2710 {
2711         /* identifiers */
2712         ot->name = "Duplicate Selected Bone(s)";
2713         ot->idname = "ARMATURE_OT_duplicate";
2714         ot->description = "Make copies of the selected bones within the same armature";
2715         
2716         /* api callbacks */
2717         ot->exec = armature_duplicate_selected_exec;
2718         ot->poll = ED_operator_editarmature;
2719         
2720         /* flags */
2721         ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
2722 }
2723
2724
2725 /* *************** END Adding stuff in editmode *************** */
2726 /* ************** Add/Remove stuff in editmode **************** */
2727
2728 /* temporary data-structure for merge/fill bones */
2729 typedef struct EditBonePoint {
2730         struct EditBonePoint *next, *prev;
2731         
2732         EditBone *head_owner;       /* EditBone which uses this point as a 'head' point */
2733         EditBone *tail_owner;       /* EditBone which uses this point as a 'tail' point */
2734         
2735         float vec[3];               /* the actual location of the point in local/EditMode space */
2736 } EditBonePoint;
2737
2738 /* find chain-tips (i.e. bones without children) */
2739 static void chains_find_tips(ListBase *edbo, ListBase *list)
2740 {
2741         EditBone *curBone, *ebo;
2742         LinkData *ld;
2743         
2744         /* note: this is potentially very slow ... there's got to be a better way */
2745         for (curBone = edbo->first; curBone; curBone = curBone->next) {
2746                 short stop = 0;
2747                 
2748                 /* is this bone contained within any existing chain? (skip if so) */
2749                 for (ld = list->first; ld; ld = ld->next) {
2750                         for (ebo = ld->data; ebo; ebo = ebo->parent) {
2751                                 if (ebo == curBone) {
2752                                         stop = 1;
2753                                         break;
2754                                 }
2755                         }
2756                         
2757                         if (stop) break;
2758                 }
2759                 /* skip current bone if it is part of an existing chain */
2760                 if (stop) continue;
2761                 
2762                 /* is any existing chain part of the chain formed by this bone? */
2763                 stop = 0;
2764                 for (ebo = curBone->parent; ebo; ebo = ebo->parent) {
2765                         for (ld = list->first; ld; ld = ld->next) {
2766                                 if (ld->data == ebo) {
2767                                         ld->data = curBone;
2768                                         stop = 1;
2769                                         break;
2770                                 }
2771                         }
2772                         
2773                         if (stop) break;
2774                 }
2775                 /* current bone has already been added to a chain? */
2776                 if (stop) continue;
2777                 
2778                 /* add current bone to a new chain */
2779                 ld = MEM_callocN(sizeof(LinkData), "BoneChain");
2780                 ld->data = curBone;
2781                 BLI_addtail(list, ld);
2782         }
2783 }
2784
2785 /* --------------------- */
2786
2787 static void fill_add_joint(EditBone *ebo, short eb_tail, ListBase *points)
2788 {
2789         EditBonePoint *ebp;
2790         float vec[3];
2791         short found = 0;
2792         
2793         if (eb_tail) {
2794                 copy_v3_v3(vec, ebo->tail);
2795         }
2796         else {
2797                 copy_v3_v3(vec, ebo->head);
2798         }
2799         
2800         for (ebp = points->first; ebp; ebp = ebp->next) {
2801                 if (equals_v3v3(ebp->vec, vec)) {                       
2802                         if (eb_tail) {
2803                                 if ((ebp->head_owner) && (ebp->head_owner->parent == ebo)) {
2804                                         /* so this bone's tail owner is this bone */
2805                                         ebp->tail_owner = ebo;
2806                                         found = 1;
2807                                         break;
2808                                 }
2809                         }
2810                         else {
2811                                 if ((ebp->tail_owner) && (ebo->parent == ebp->tail_owner)) {
2812                                         /* so this bone's head owner is this bone */
2813                                         ebp->head_owner = ebo;
2814                                         found = 1;
2815                                         break;
2816                                 }
2817                         }
2818                 }
2819         }
2820         
2821         /* allocate a new point if no existing point was related */
2822         if (found == 0) {
2823                 ebp = MEM_callocN(sizeof(EditBonePoint), "EditBonePoint");
2824                 
2825                 if (eb_tail) {
2826                         copy_v3_v3(ebp->vec, ebo->tail);
2827                         ebp->tail_owner = ebo;
2828                 }
2829                 else {
2830                         copy_v3_v3(ebp->vec, ebo->head);
2831                         ebp->head_owner = ebo;
2832                 }
2833                 
2834                 BLI_addtail(points, ebp);
2835         }
2836 }
2837
2838 /* bone adding between selected joints */
2839 static int armature_fill_bones_exec(bContext *C, wmOperator *op)
2840 {
2841         Object *obedit = CTX_data_edit_object(C);
2842         bArmature *arm = (obedit) ? obedit->data : NULL;
2843         Scene *scene = CTX_data_scene(C);
2844         View3D *v3d = CTX_wm_view3d(C);
2845         ListBase points = {NULL, NULL};
2846         int count;
2847
2848         /* sanity checks */
2849         if (ELEM(NULL, obedit, arm))
2850                 return OPERATOR_CANCELLED;
2851
2852         /* loop over all bones, and only consider if visible */
2853         CTX_DATA_BEGIN(C, EditBone *, ebone, visible_bones)
2854         {
2855                 if (!(ebone->flag & BONE_CONNECTED) && (ebone->flag & BONE_ROOTSEL))
2856                         fill_add_joint(ebone, 0, &points);
2857                 if (ebone->flag & BONE_TIPSEL) 
2858                         fill_add_joint(ebone, 1, &points);
2859         }
2860         CTX_DATA_END;
2861         
2862         /* the number of joints determines how we fill:
2863          *  1) between joint and cursor (joint=head, cursor=tail)
2864          *  2) between the two joints (order is dependent on active-bone/hierachy)
2865          *  3+) error (a smarter method involving finding chains needs to be worked out
2866          */
2867         count = BLI_countlist(&points);
2868         
2869         if (count == 0) {
2870                 BKE_report(op->reports, RPT_ERROR, "No joints selected");
2871                 return OPERATOR_CANCELLED;
2872         }
2873         else if (count == 1) {
2874                 EditBonePoint *ebp;
2875                 float curs[3];
2876                 
2877                 /* Get Points - selected joint */
2878                 ebp = (EditBonePoint *)points.first;
2879                 
2880                 /* Get points - cursor (tail) */
2881                 invert_m4_m4(obedit->imat, obedit->obmat);
2882                 mul_v3_m4v3(curs, obedit->imat, give_cursor(scene, v3d));
2883                 
2884                 /* Create a bone */
2885                 /* newbone= */ add_points_bone(obedit, ebp->vec, curs);
2886         }
2887         else if (count == 2) {
2888                 EditBonePoint *ebp, *ebp2;
2889                 float head[3], tail[3];
2890                 short headtail = 0;
2891                 
2892                 /* check that the points don't belong to the same bone */
2893                 ebp = (EditBonePoint *)points.first;
2894                 ebp2 = ebp->next;
2895                 
2896                 if ((ebp->head_owner == ebp2->tail_owner) && (ebp->head_owner != NULL)) {
2897                         BKE_report(op->reports, RPT_ERROR, "Same bone selected...");
2898                         BLI_freelistN(&points);
2899                         return OPERATOR_CANCELLED;
2900                 }
2901                 if ((ebp->tail_owner == ebp2->head_owner) && (ebp->tail_owner != NULL)) {
2902                         BKE_report(op->reports, RPT_ERROR, "Same bone selected...");
2903                         BLI_freelistN(&points);
2904                         return OPERATOR_CANCELLED;
2905                 }
2906                 
2907                 /* find which one should be the 'head' */
2908                 if ((ebp->head_owner && ebp2->head_owner) || (ebp->tail_owner && ebp2->tail_owner)) {
2909                         /* rule: whichever one is closer to 3d-cursor */
2910                         float curs[3];
2911                         float vecA[3], vecB[3];
2912                         float distA, distB;
2913                         
2914                         /* get cursor location */
2915                         invert_m4_m4(obedit->imat, obedit->obmat);
2916                         mul_v3_m4v3(curs, obedit->imat, give_cursor(scene, v3d));
2917                         
2918                         /* get distances */
2919                         sub_v3_v3v3(vecA, ebp->vec, curs);
2920                         sub_v3_v3v3(vecB, ebp2->vec, curs);
2921                         distA = len_v3(vecA);
2922          &nbs