Cleanup: move clipping shader lib & define into struct

[blender.git] / source / blender / draw / modes / overlay_mode.c

diff --git a/source/blender/draw/modes/overlay_mode.c b/source/blender/draw/modes/overlay_mode.c
index a1befa679f009a0154adac11c4ddbd602c41cc27..407c22bf581744b73a834fe9dd8dd6d86e3ca9be 100644 (file)
--- a/source/blender/draw/modes/overlay_mode.c
+++ b/source/blender/draw/modes/overlay_mode.c
@@ -73,8 +73,6 @@ static struct {
        OVERLAY_Shaders sh_data[GPU_SHADER_CFG_LEN];
 } e_data = {NULL};
 
-extern char datatoc_gpu_shader_cfg_world_clip_lib_glsl[];
-
 /* Shaders */
 extern char datatoc_overlay_face_orientation_frag_glsl[];
 extern char datatoc_overlay_face_orientation_vert_glsl[];
@@ -92,9 +90,8 @@ static void overlay_engine_init(void *vedata)
 
        const DRWContextState *draw_ctx = DRW_context_state_get();
        OVERLAY_Shaders *sh_data = &e_data.sh_data[draw_ctx->sh_cfg];
-       const bool is_clip = (draw_ctx->rv3d->rflag & RV3D_CLIPPING) != 0;
 
-       if (is_clip) {
+       if (draw_ctx->sh_cfg == GPU_SHADER_CFG_CLIPPED) {
                DRW_state_clip_planes_set_from_rv3d(draw_ctx->rv3d);
        }
 
@@ -104,35 +101,34 @@ static void overlay_engine_init(void *vedata)
        }
        stl->g_data->ghost_stencil_test = false;
 
-       const char *world_clip_lib_or_empty = is_clip ? datatoc_gpu_shader_cfg_world_clip_lib_glsl : "";
-       const char *world_clip_def_or_empty = is_clip ? "#define USE_WORLD_CLIP_PLANES\n" : "";
+       const GPUShaderConfigData *sh_cfg_data = &GPU_shader_cfg_data[draw_ctx->sh_cfg];
 
        if (!sh_data->face_orientation) {
                /* Face orientation */
                sh_data->face_orientation = GPU_shader_create_from_arrays({
-                       .vert = (const char *[]){world_clip_lib_or_empty, datatoc_overlay_face_orientation_vert_glsl, NULL},
+                       .vert = (const char *[]){sh_cfg_data->lib, datatoc_overlay_face_orientation_vert_glsl, NULL},
                        .frag = (const char *[]){datatoc_overlay_face_orientation_frag_glsl, NULL},
-                       .defs = (const char *[]){world_clip_def_or_empty, NULL},
+                       .defs = (const char *[]){sh_cfg_data->def, NULL},
                });
        }
 
        if (!sh_data->face_wireframe) {
                sh_data->select_wireframe = GPU_shader_create_from_arrays({
-                       .vert = (const char *[]){world_clip_lib_or_empty, datatoc_overlay_face_wireframe_vert_glsl, NULL},
-                       .geom = (const char *[]){world_clip_lib_or_empty, datatoc_overlay_face_wireframe_geom_glsl, NULL},
+                       .vert = (const char *[]){sh_cfg_data->lib, datatoc_overlay_face_wireframe_vert_glsl, NULL},
+                       .geom = (const char *[]){sh_cfg_data->lib, datatoc_overlay_face_wireframe_geom_glsl, NULL},
                        .frag = (const char *[]){datatoc_gpu_shader_depth_only_frag_glsl, NULL},
-                       .defs = (const char *[]){world_clip_def_or_empty, "#define SELECT_EDGES\n", NULL},
+                       .defs = (const char *[]){sh_cfg_data->def, "#define SELECT_EDGES\n", NULL},
                });
                sh_data->face_wireframe = GPU_shader_create_from_arrays({
-                       .vert = (const char *[]){world_clip_lib_or_empty, datatoc_overlay_face_wireframe_vert_glsl, NULL},
+                       .vert = (const char *[]){sh_cfg_data->lib, datatoc_overlay_face_wireframe_vert_glsl, NULL},
                        .frag = (const char *[]){datatoc_overlay_face_wireframe_frag_glsl, NULL},
-                       .defs = (const char *[]){world_clip_def_or_empty, NULL},
+                       .defs = (const char *[]){sh_cfg_data->def, NULL},
                });
                sh_data->face_wireframe_sculpt = GPU_shader_create_from_arrays({
-                       .vert = (const char *[]){world_clip_lib_or_empty, datatoc_overlay_face_wireframe_vert_glsl, NULL},
-                       .geom = (const char *[]){world_clip_lib_or_empty, datatoc_overlay_face_wireframe_geom_glsl, NULL},
+                       .vert = (const char *[]){sh_cfg_data->lib, datatoc_overlay_face_wireframe_vert_glsl, NULL},
+                       .geom = (const char *[]){sh_cfg_data->lib, datatoc_overlay_face_wireframe_geom_glsl, NULL},
                        .frag = (const char *[]){datatoc_overlay_face_wireframe_frag_glsl, NULL},
-                       .defs = (const char *[]){world_clip_def_or_empty, "#define USE_SCULPT\n", NULL},
+                       .defs = (const char *[]){sh_cfg_data->def, "#define USE_SCULPT\n", NULL},
                });
        }
 }