doxygen: prevent GPL license block from being parsed as doxygen comment.
[blender.git] / source / blender / editors / space_view3d / view3d_buttons.c
index 4adb2b3..0e4e1ad 100644 (file)
@@ -1,5 +1,5 @@
-/**
- * $Id:
+/*
+ * $Id$
  *
  * ***** BEGIN GPL LICENSE BLOCK *****
  *
@@ -15,7 +15,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software Foundation,
- * Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  *
  * The Original Code is Copyright (C) 2009 Blender Foundation.
  * All rights reserved.
 #include <math.h>
 #include <float.h>
 
-#include "DNA_ID.h"
-#include "DNA_action_types.h"
 #include "DNA_armature_types.h"
 #include "DNA_curve_types.h"
-#include "DNA_camera_types.h"
-#include "DNA_gpencil_types.h"
-#include "DNA_lamp_types.h"
 #include "DNA_lattice_types.h"
 #include "DNA_meta_types.h"
-#include "DNA_mesh_types.h"
 #include "DNA_meshdata_types.h"
 #include "DNA_object_types.h"
-#include "DNA_space_types.h"
 #include "DNA_scene_types.h"
-#include "DNA_screen_types.h"
-#include "DNA_userdef_types.h"
-#include "DNA_view3d_types.h"
-#include "DNA_world_types.h"
 
 #include "MEM_guardedalloc.h"
 
 #include "BLI_blenlib.h"
 #include "BLI_editVert.h"
 #include "BLI_rand.h"
+#include "BLI_utildefines.h"
 
 #include "BKE_action.h"
-#include "BKE_brush.h"
 #include "BKE_context.h"
 #include "BKE_curve.h"
 #include "BKE_customdata.h"
 #include "BKE_depsgraph.h"
-#include "BKE_idprop.h"
+#include "BKE_main.h"
 #include "BKE_mesh.h"
-#include "BKE_object.h"
-#include "BKE_global.h"
-#include "BKE_scene.h"
 #include "BKE_screen.h"
-#include "BKE_utildefines.h"
 #include "BKE_deform.h"
 
-#include "BIF_gl.h"
-
 #include "WM_api.h"
 #include "WM_types.h"
 
 #include "RNA_access.h"
-#include "RNA_define.h"
 
 #include "ED_armature.h"
-#include "ED_curve.h"
-#include "ED_image.h"
 #include "ED_gpencil.h"
-#include "ED_keyframing.h"
 #include "ED_mesh.h"
-#include "ED_object.h"
-#include "ED_particle.h"
 #include "ED_screen.h"
 #include "ED_transform.h"
-#include "ED_types.h"
-#include "ED_util.h"
+#include "ED_curve.h"
 
 #include "UI_interface.h"
 #include "UI_resources.h"
-#include "UI_view2d.h"
 
 #include "view3d_intern.h"     // own include
 
@@ -146,24 +121,24 @@ typedef struct {
        float ob_scale[3]; // need temp space due to linked values
        float ob_dims[3];
        short link_scale;
-       float ve_median[5];
+       float ve_median[6];
        int curdef;
        float *defweightp;
 } TransformProperties;
 
 
 /* is used for both read and write... */
-static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d, Object *ob, float lim)
+static void v3d_editvertex_buts(uiLayout *layout, View3D *v3d, Object *ob, float lim)
 {
        uiBlock *block= (layout)? uiLayoutAbsoluteBlock(layout): NULL;
        MDeformVert *dvert=NULL;
        TransformProperties *tfp= v3d->properties_storage;
-       float median[5], ve_median[5];
-       int tot, totw, totweight, totedge;
+       float median[6], ve_median[6];
+       int tot, totw, totweight, totedge, totradius;
        char defstr[320];
        
-       median[0]= median[1]= median[2]= median[3]= median[4]= 0.0;
-       tot= totw= totweight= totedge= 0;
+       median[0]= median[1]= median[2]= median[3]= median[4]= median[5]= 0.0;
+       tot= totw= totweight= totedge= totradius= 0;
        defstr[0]= 0;
 
        if(ob->type==OB_MESH) {
@@ -177,7 +152,7 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                        if(eve->f & SELECT) {
                                evedef= eve;
                                tot++;
-                               add_v3_v3v3(median, median, eve->co);
+                               add_v3_v3(median, eve->co);
                        }
                        eve= eve->next;
                }
@@ -225,26 +200,29 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                BPoint *bp;
                BezTriple *bezt;
                int a;
-               
-               nu= cu->editnurb->first;
+               ListBase *nurbs= ED_curve_editnurbs(cu);
+
+               nu= nurbs->first;
                while(nu) {
                        if(nu->type == CU_BEZIER) {
                                bezt= nu->bezt;
                                a= nu->pntsu;
                                while(a--) {
                                        if(bezt->f2 & SELECT) {
-                                               add_v3_v3v3(median, median, bezt->vec[1]);
+                                               add_v3_v3(median, bezt->vec[1]);
                                                tot++;
                                                median[4]+= bezt->weight;
                                                totweight++;
+                                               median[5]+= bezt->radius;
+                                               totradius++;
                                        }
                                        else {
                                                if(bezt->f1 & SELECT) {
-                                                       add_v3_v3v3(median, median, bezt->vec[0]);
+                                                       add_v3_v3(median, bezt->vec[0]);
                                                        tot++;
                                                }
                                                if(bezt->f3 & SELECT) {
-                                                       add_v3_v3v3(median, median, bezt->vec[2]);
+                                                       add_v3_v3(median, bezt->vec[2]);
                                                        tot++;
                                                }
                                        }
@@ -256,12 +234,14 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                                a= nu->pntsu*nu->pntsv;
                                while(a--) {
                                        if(bp->f1 & SELECT) {
-                                               add_v3_v3v3(median, median, bp->vec);
+                                               add_v3_v3(median, bp->vec);
                                                median[3]+= bp->vec[3];
                                                totw++;
                                                tot++;
                                                median[4]+= bp->weight;
                                                totweight++;
+                                               median[5]+= bp->radius;
+                                               totradius++;
                                        }
                                        bp++;
                                }
@@ -274,11 +254,11 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                BPoint *bp;
                int a;
                
-               a= lt->editlatt->pntsu*lt->editlatt->pntsv*lt->editlatt->pntsw;
-               bp= lt->editlatt->def;
+               a= lt->editlatt->latt->pntsu*lt->editlatt->latt->pntsv*lt->editlatt->latt->pntsw;
+               bp= lt->editlatt->latt->def;
                while(a--) {
                        if(bp->f1 & SELECT) {
-                               add_v3_v3v3(median, median, bp->vec);
+                               add_v3_v3(median, bp->vec);
                                tot++;
                                median[4]+= bp->weight;
                                totweight++;
@@ -295,35 +275,38 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
        if(totedge) median[3] /= (float)totedge;
        else if(totw) median[3] /= (float)totw;
        if(totweight) median[4] /= (float)totweight;
+       if(totradius) median[5] /= (float)totradius;
        
        if(v3d->flag & V3D_GLOBAL_STATS)
                mul_m4_v3(ob->obmat, median);
        
        if(block) {     // buttons
-               int but_y;
-               if((ob->parent) && (ob->partype == PARBONE))    but_y = 135;
-               else                                                                                    but_y = 150;
-               
-               
-               
+               uiBut *but;
+
                memcpy(tfp->ve_median, median, sizeof(tfp->ve_median));
                
                uiBlockBeginAlign(block);
                if(tot==1) {
                        uiDefBut(block, LABEL, 0, "Vertex:",                                    0, 130, 200, 20, 0, 0, 0, 0, 0, "");
                        uiBlockBeginAlign(block);
-                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "X:",                0, 110, 200, 20, &(tfp->ve_median[0]), -lim, lim, 10, 3, "");
-                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Y:",                0, 90, 200, 20, &(tfp->ve_median[1]), -lim, lim, 10, 3, "");
-                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Z:",                0, 70, 200, 20, &(tfp->ve_median[2]), -lim, lim, 10, 3, "");
-                       
+
+                       but= uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "X:",           0, 110, 200, 20, &(tfp->ve_median[0]), -lim, lim, 10, 3, "");
+                       uiButSetUnitType(but, PROP_UNIT_LENGTH);
+                       but= uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Y:",           0, 90, 200, 20, &(tfp->ve_median[1]), -lim, lim, 10, 3, "");
+                       uiButSetUnitType(but, PROP_UNIT_LENGTH);
+                       but= uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Z:",           0, 70, 200, 20, &(tfp->ve_median[2]), -lim, lim, 10, 3, "");
+                       uiButSetUnitType(but, PROP_UNIT_LENGTH);
+
                        if(totw==1) {
-                               uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "W:",        0, 50, 200, 20, &(tfp->ve_median[3]), 0.01, 100.0, 10, 3, "");
+                               uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "W:",        0, 50, 200, 20, &(tfp->ve_median[3]), 0.01, 100.0, 1, 3, "");
                                uiBlockBeginAlign(block);
                                uiDefButBitS(block, TOG, V3D_GLOBAL_STATS, B_REDR, "Global",            0, 25, 100, 20, &v3d->flag, 0, 0, 0, 0, "Displays global values");
                                uiDefButBitS(block, TOGN, V3D_GLOBAL_STATS, B_REDR, "Local",            100, 25, 100, 20, &v3d->flag, 0, 0, 0, 0, "Displays local values");
                                uiBlockEndAlign(block);
                                if(totweight)
-                                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Weight:",   0, 0, 200, 20, &(tfp->ve_median[4]), 0.0, 1.0, 10, 3, "");
+                                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Weight:",   0, 0, 200, 20, &(tfp->ve_median[4]), 0.0, 1.0, 1, 3, "");
+                               if(totradius)
+                                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Radius:",   0, 0, 200, 20, &(tfp->ve_median[5]), 0.0, 100.0, 1, 3, "Radius of curve CPs");
                                }
                        else {
                                uiBlockBeginAlign(block);
@@ -332,16 +315,21 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                                uiBlockEndAlign(block);
                                if(totweight)
                                        uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Weight:",   0, 20, 200, 20, &(tfp->ve_median[4]), 0.0, 1.0, 10, 3, "");
+                               if(totradius)
+                                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Radius:",   0, 20, 200, 20, &(tfp->ve_median[5]), 0.0, 100.0, 10, 3, "Radius of curve CPs");
                        }
                }
                else {
                        uiDefBut(block, LABEL, 0, "Median:",                                    0, 130, 200, 20, 0, 0, 0, 0, 0, "");
                        uiBlockBeginAlign(block);
-                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "X:",                0, 110, 200, 20, &(tfp->ve_median[0]), -lim, lim, 10, 3, "");
-                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Y:",                0, 90, 200, 20, &(tfp->ve_median[1]), -lim, lim, 10, 3, "");
-                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Z:",                0, 70, 200, 20, &(tfp->ve_median[2]), -lim, lim, 10, 3, "");
+                       but= uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "X:",           0, 110, 200, 20, &(tfp->ve_median[0]), -lim, lim, 10, 3, "");
+                       uiButSetUnitType(but, PROP_UNIT_LENGTH);
+                       but= uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Y:",           0, 90, 200, 20, &(tfp->ve_median[1]), -lim, lim, 10, 3, "");
+                       uiButSetUnitType(but, PROP_UNIT_LENGTH);
+                       but= uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Z:",           0, 70, 200, 20, &(tfp->ve_median[2]), -lim, lim, 10, 3, "");
+                       uiButSetUnitType(but, PROP_UNIT_LENGTH);
                        if(totw==tot) {
-                               uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "W:",        0, 50, 200, 20, &(tfp->ve_median[3]), 0.01, 100.0, 10, 3, "");
+                               uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "W:",        0, 50, 200, 20, &(tfp->ve_median[3]), 0.01, 100.0, 1, 3, "");
                                uiBlockEndAlign(block);
                                uiBlockBeginAlign(block);
                                uiDefButBitS(block, TOG, V3D_GLOBAL_STATS, B_REDR, "Global",            0, 25, 100, 20, &v3d->flag, 0, 0, 0, 0, "Displays global values");
@@ -349,6 +337,8 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                                uiBlockEndAlign(block);
                                if(totweight)
                                        uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Weight:",   0, 0, 200, 20, &(tfp->ve_median[4]), 0.0, 1.0, 10, 3, "Weight is used for SoftBody Goal");
+                               if(totradius)
+                                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Radius:",   0, 0, 200, 20, &(tfp->ve_median[5]), 0.0, 100.0, 10, 3, "Radius of curve CPs");
                                uiBlockEndAlign(block);
                        }
                        else {
@@ -357,15 +347,17 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                                uiDefButBitS(block, TOGN, V3D_GLOBAL_STATS, B_REDR, "Local",            100, 45, 100, 20, &v3d->flag, 0, 0, 0, 0, "Displays local values");
                                uiBlockEndAlign(block);
                                if(totweight)
-                                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Weight:",   0, 20, 200, 20, &(tfp->ve_median[4]), 0.0, 1.0, 10, 3, "Weight is used for SoftBody Goal");
+                                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Weight:",   0, 20, 200, 20, &(tfp->ve_median[4]), 0.0, 1.0, 1, 3, "Weight is used for SoftBody Goal");
+                               if(totradius)
+                                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Radius:",   0, 0, 200, 20, &(tfp->ve_median[5]), 0.0, 100.0, 1, 3, "Radius of curve CPs");
                                uiBlockEndAlign(block);
                        }
                }
                                
                if(totedge==1)
-                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Crease:",   0, 20, 200, 20, &(tfp->ve_median[3]), 0.0, 1.0, 10, 3, "");
+                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Crease:",   0, 20, 200, 20, &(tfp->ve_median[3]), 0.0, 1.0, 1, 3, "");
                else if(totedge>1)
-                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Median Crease:",    0, 20, 200, 20, &(tfp->ve_median[3]), 0.0, 1.0, 10, 3, "");
+                       uiDefButF(block, NUM, B_OBJECTPANELMEDIAN, "Mean Crease:",      0, 20, 200, 20, &(tfp->ve_median[3]), 0.0, 1.0, 1, 3, "");
                
        }
        else {  // apply
@@ -379,34 +371,71 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                sub_v3_v3v3(median, ve_median, median);
                median[3]= ve_median[3]-median[3];
                median[4]= ve_median[4]-median[4];
+               median[5]= ve_median[5]-median[5];
                
                if(ob->type==OB_MESH) {
                        Mesh *me= ob->data;
                        EditMesh *em = BKE_mesh_get_editmesh(me);
-                       EditVert *eve;
-                       EditEdge *eed;
-                       
-                       eve= em->verts.first;
-                       while(eve) {
-                               if(eve->f & SELECT) {
-                                       add_v3_v3v3(eve->co, eve->co, median);
+
+                       /* allow for some rounding error becasue of matrix transform */
+                       if(len_v3(median) > 0.000001) {
+                               EditVert *eve;
+
+                               for(eve= em->verts.first; eve; eve= eve->next) {
+                                       if(eve->f & SELECT) {
+                                               add_v3_v3(eve->co, median);
+                                       }
                                }
-                               eve= eve->next;
+
+                               recalc_editnormals(em);
                        }
-                       
-                       for(eed= em->edges.first; eed; eed= eed->next) {
-                               if(eed->f & SELECT) {
-                                       /* ensure the median can be set to zero or one */
-                                       if(ve_median[3]==0.0f) eed->crease= 0.0f;
-                                       else if(ve_median[3]==1.0f) eed->crease= 1.0f;
+
+                       if(median[3] != 0.0f) {
+                               EditEdge *eed;
+                               const float fixed_crease= (ve_median[3] <= 0.0f ? 0.0 : (ve_median[3] >= 1.0f ? 1.0 : FLT_MAX));
+                               
+                               if(fixed_crease != FLT_MAX) {
+                                       /* simple case */
+
+                                       for(eed= em->edges.first; eed; eed= eed->next) {
+                                               if(eed->f & SELECT) {
+                                                       eed->crease= fixed_crease;
+                                               }
+                                       }
+                               }
+                               else {
+                                       /* scale crease to target median */
+                                       float median_new= ve_median[3];
+                                       float median_orig= ve_median[3] - median[3]; /* previous median value */
+
+                                       /* incase of floating point error */
+                                       CLAMP(median_orig, 0.0, 1.0);
+                                       CLAMP(median_new, 0.0, 1.0);
+
+                                       if(median_new < median_orig) {
+                                               /* scale down */
+                                               const float sca= median_new / median_orig;
+                                               
+                                               for(eed= em->edges.first; eed; eed= eed->next) {
+                                                       if(eed->f & SELECT) {
+                                                               eed->crease *= sca;
+                                                               CLAMP(eed->crease, 0.0, 1.0);
+                                                       }
+                                               }
+                                       }
                                        else {
-                                               eed->crease+= median[3];
-                                               CLAMP(eed->crease, 0.0, 1.0);
+                                               /* scale up */
+                                               const float sca= (1.0f - median_new) / (1.0f - median_orig);
+
+                                               for(eed= em->edges.first; eed; eed= eed->next) {
+                                                       if(eed->f & SELECT) {
+                                                               eed->crease = 1.0f - ((1.0f - eed->crease) * sca);
+                                                               CLAMP(eed->crease, 0.0, 1.0);
+                                                       }
+                                               }
                                        }
                                }
                        }
-                       
-                       recalc_editnormals(em);
 
                        BKE_mesh_end_editmesh(me, em);
                }
@@ -416,25 +445,27 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                        BPoint *bp;
                        BezTriple *bezt;
                        int a;
-                       
-                       nu= cu->editnurb->first;
+                       ListBase *nurbs= ED_curve_editnurbs(cu);
+
+                       nu= nurbs->first;
                        while(nu) {
                                if(nu->type == CU_BEZIER) {
                                        bezt= nu->bezt;
                                        a= nu->pntsu;
                                        while(a--) {
                                                if(bezt->f2 & SELECT) {
-                                                       add_v3_v3v3(bezt->vec[0], bezt->vec[0], median);
-                                                       add_v3_v3v3(bezt->vec[1], bezt->vec[1], median);
-                                                       add_v3_v3v3(bezt->vec[2], bezt->vec[2], median);
+                                                       add_v3_v3(bezt->vec[0], median);
+                                                       add_v3_v3(bezt->vec[1], median);
+                                                       add_v3_v3(bezt->vec[2], median);
                                                        bezt->weight+= median[4];
+                                                       bezt->radius+= median[5];
                                                }
                                                else {
                                                        if(bezt->f1 & SELECT) {
-                                                               add_v3_v3v3(bezt->vec[0], bezt->vec[0], median);
+                                                               add_v3_v3(bezt->vec[0], median);
                                                        }
                                                        if(bezt->f3 & SELECT) {
-                                                               add_v3_v3v3(bezt->vec[2], bezt->vec[2], median);
+                                                               add_v3_v3(bezt->vec[2], median);
                                                        }
                                                }
                                                bezt++;
@@ -445,9 +476,10 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                                        a= nu->pntsu*nu->pntsv;
                                        while(a--) {
                                                if(bp->f1 & SELECT) {
-                                                       add_v3_v3v3(bp->vec, bp->vec, median);
+                                                       add_v3_v3(bp->vec, median);
                                                        bp->vec[3]+= median[3];
                                                        bp->weight+= median[4];
+                                                       bp->radius+= median[5];
                                                }
                                                bp++;
                                        }
@@ -463,11 +495,11 @@ static void v3d_editvertex_buts(const bContext *C, uiLayout *layout, View3D *v3d
                        BPoint *bp;
                        int a;
                        
-                       a= lt->editlatt->pntsu*lt->editlatt->pntsv*lt->editlatt->pntsw;
-                       bp= lt->editlatt->def;
+                       a= lt->editlatt->latt->pntsu*lt->editlatt->latt->pntsv*lt->editlatt->latt->pntsw;
+                       bp= lt->editlatt->latt->def;
                        while(a--) {
                                if(bp->f1 & SELECT) {
-                                       add_v3_v3v3(bp->vec, bp->vec, median);
+                                       add_v3_v3(bp->vec, median);
                                        bp->weight+= median[4];
                                }
                                bp++;
@@ -502,13 +534,13 @@ static void act_vert_def(Object *ob, EditVert **eve, MDeformVert **dvert)
        *dvert= NULL;
 }
 
-static void editvert_mirror_update(Object *ob, EditVert *eve, int def_nr)
+static void editvert_mirror_update(Object *ob, EditVert *eve, int def_nr, int index)
 {
        Mesh *me= ob->data;
        EditMesh *em = BKE_mesh_get_editmesh(me);
        EditVert *eve_mirr;
 
-       eve_mirr= editmesh_get_x_mirror_vert(ob, em, eve->co);
+       eve_mirr= editmesh_get_x_mirror_vert(ob, em, eve, eve->co, index);
 
        if(eve_mirr && eve_mirr != eve) {
                MDeformVert *dvert_src= CustomData_em_get(&em->vdata, eve->data, CD_MDEFORMVERT);
@@ -541,7 +573,7 @@ static void vgroup_adjust_active(Object *ob, int def_nr)
 
        if(dvert_act) {
                if(((Mesh *)ob->data)->editflag & ME_EDIT_MIRROR_X)
-                       editvert_mirror_update(ob, eve_act, def_nr);
+                       editvert_mirror_update(ob, eve_act, def_nr, -1);
        }
 }
 
@@ -560,15 +592,16 @@ static void vgroup_copy_active_to_sel(Object *ob)
                EditMesh *em = BKE_mesh_get_editmesh(me);
                EditVert *eve;
                MDeformVert *dvert;
+               int index= 0;
 
-               for(eve= em->verts.first; eve; eve= eve->next) {
+               for(eve= em->verts.first; eve; eve= eve->next, index++) {
                        if(eve->f & SELECT && eve != eve_act) {
                                dvert= CustomData_em_get(&em->vdata, eve->data, CD_MDEFORMVERT);
                                if(dvert) {
                                        defvert_copy(dvert, dvert_act);
 
                                        if(me->editflag & ME_EDIT_MIRROR_X)
-                                               editvert_mirror_update(ob, eve, -1);
+                                               editvert_mirror_update(ob, eve, -1, index);
 
                                }
                        }
@@ -594,6 +627,7 @@ static void vgroup_copy_active_to_sel_single(Object *ob, int def_nr)
                MDeformWeight *dw;
                float act_weight = -1.0f;
                int i;
+               int index= 0;
 
                for(i=0, dw=dvert_act->dw; i < dvert_act->totweight; i++, dw++) {
                        if(def_nr == dw->def_nr) {
@@ -605,7 +639,7 @@ static void vgroup_copy_active_to_sel_single(Object *ob, int def_nr)
                if(act_weight < -0.5f)
                        return;
 
-               for(eve= em->verts.first; eve; eve= eve->next) {
+               for(eve= em->verts.first; eve; eve= eve->next, index++) {
                        if(eve->f & SELECT && eve != eve_act) {
                                dvert= CustomData_em_get(&em->vdata, eve->data, CD_MDEFORMVERT);
                                if(dvert) {
@@ -614,7 +648,7 @@ static void vgroup_copy_active_to_sel_single(Object *ob, int def_nr)
                                                        dw->weight= act_weight;
 
                                                        if(me->editflag & ME_EDIT_MIRROR_X)
-                                                               editvert_mirror_update(ob, eve, -1);
+                                                               editvert_mirror_update(ob, eve, -1, index);
 
                                                        break;
                                                }
@@ -624,7 +658,7 @@ static void vgroup_copy_active_to_sel_single(Object *ob, int def_nr)
                }
 
                if(me->editflag & ME_EDIT_MIRROR_X)
-                       editvert_mirror_update(ob, eve_act, -1);
+                       editvert_mirror_update(ob, eve_act, -1, -1);
 
        }
 }
@@ -642,13 +676,13 @@ static void vgroup_normalize_active(Object *ob)
        defvert_normalize(dvert_act);
 
        if(((Mesh *)ob->data)->editflag & ME_EDIT_MIRROR_X)
-               editvert_mirror_update(ob, eve_act, -1);
+               editvert_mirror_update(ob, eve_act, -1, -1);
 
 
 
 }
 
-static void do_view3d_vgroup_buttons(bContext *C, void *arg, int event)
+static void do_view3d_vgroup_buttons(bContext *C, void *UNUSED(arg), int event)
 {
        Scene *scene= CTX_data_scene(C);
        Object *ob= OBACT;
@@ -671,11 +705,11 @@ static void do_view3d_vgroup_buttons(bContext *C, void *arg, int event)
 //             ED_vgroup_mirror(ob, 1, 1, 0);
 
        /* default for now */
-       DAG_id_flush_update(&ob->id, OB_RECALC_DATA);
+       DAG_id_tag_update(&ob->id, OB_RECALC_DATA);
        WM_event_add_notifier(C, NC_GEOM|ND_DATA, ob->data);
 }
 
-int view3d_panel_vgroup_poll(const bContext *C, PanelType *pt)
+static int view3d_panel_vgroup_poll(const bContext *C, PanelType *UNUSED(pt))
 {
        Scene *scene= CTX_data_scene(C);
        Object *ob= OBACT;
@@ -745,61 +779,61 @@ static void v3d_transform_butsR(uiLayout *layout, PointerRNA *ptr)
                uiLayoutSetActive(split, !(bone->parent && bone->flag & BONE_CONNECTED));
        }
        colsub = uiLayoutColumn(split, 1);
-       uiItemR(colsub, "Location", 0, ptr, "location", 0);
+       uiItemR(colsub, ptr, "location", 0, "Location", ICON_NULL);
        colsub = uiLayoutColumn(split, 1);
-       uiItemL(colsub, "", 0);
-       uiItemR(colsub, "", ICON_LOCKED, ptr, "lock_location", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY);
+       uiItemL(colsub, "", ICON_NULL);
+       uiItemR(colsub, ptr, "lock_location", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY, "", ICON_NULL);
        
        split = uiLayoutSplit(layout, 0.8, 0);
        
        switch(RNA_enum_get(ptr, "rotation_mode")) {
                case ROT_MODE_QUAT: /* quaternion */
                        colsub = uiLayoutColumn(split, 1);
-                       uiItemR(colsub, "Rotation", 0, ptr, "rotation_quaternion", 0);
+                       uiItemR(colsub, ptr, "rotation_quaternion", 0, "Rotation", ICON_NULL);
                        colsub = uiLayoutColumn(split, 1);
-                       uiItemR(colsub, "4L", 0, ptr, "lock_rotations_4d", UI_ITEM_R_TOGGLE);
+                       uiItemR(colsub, ptr, "lock_rotations_4d", UI_ITEM_R_TOGGLE, "4L", ICON_NULL);
                        if (RNA_boolean_get(ptr, "lock_rotations_4d"))
-                               uiItemR(colsub, "", ICON_LOCKED, ptr, "lock_rotation_w", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY);
+                               uiItemR(colsub, ptr, "lock_rotation_w", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY, "", ICON_NULL);
                        else
-                               uiItemL(colsub, "", 0);
-                       uiItemR(colsub, "", ICON_LOCKED, ptr, "lock_rotation", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY);
+                               uiItemL(colsub, "", ICON_NULL);
+                       uiItemR(colsub, ptr, "lock_rotation", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY, "", ICON_NULL);
                        break;
                case ROT_MODE_AXISANGLE: /* axis angle */
                        colsub = uiLayoutColumn(split, 1);
-                       uiItemR(colsub, "Rotation", 0, ptr, "rotation_axis_angle", 0);
+                       uiItemR(colsub, ptr, "rotation_axis_angle", 0, "Rotation", ICON_NULL);
                        colsub = uiLayoutColumn(split, 1);
-                       uiItemR(colsub, "4L", 0, ptr, "lock_rotations_4d", UI_ITEM_R_TOGGLE);
+                       uiItemR(colsub, ptr, "lock_rotations_4d", UI_ITEM_R_TOGGLE, "4L", ICON_NULL);
                        if (RNA_boolean_get(ptr, "lock_rotations_4d"))
-                               uiItemR(colsub, "", ICON_LOCKED, ptr, "lock_rotation_w", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY);
+                               uiItemR(colsub, ptr, "lock_rotation_w", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY, "", ICON_NULL);
                        else
-                               uiItemL(colsub, "", 0);
-                       uiItemR(colsub, "", ICON_LOCKED, ptr, "lock_rotation", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY);
+                               uiItemL(colsub, "", ICON_NULL);
+                       uiItemR(colsub, ptr, "lock_rotation", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY, "", ICON_NULL);
                        break;
                default: /* euler rotations */
                        colsub = uiLayoutColumn(split, 1);
-                       uiItemR(colsub, "Rotation", 0, ptr, "rotation_euler", 0);
+                       uiItemR(colsub, ptr, "rotation_euler", 0, "Rotation", ICON_NULL);
                        colsub = uiLayoutColumn(split, 1);
-                       uiItemL(colsub, "", 0);
-                       uiItemR(colsub, "", ICON_LOCKED, ptr, "lock_rotation", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY);
+                       uiItemL(colsub, "", ICON_NULL);
+                       uiItemR(colsub, ptr, "lock_rotation", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY, "", ICON_NULL);
                        break;
        }
-       uiItemR(layout, "", 0, ptr, "rotation_mode", 0);
+       uiItemR(layout, ptr, "rotation_mode", 0, "", ICON_NULL);
        
        split = uiLayoutSplit(layout, 0.8, 0);
        colsub = uiLayoutColumn(split, 1);
-       uiItemR(colsub, "Scale", 0, ptr, "scale", 0);
+       uiItemR(colsub, ptr, "scale", 0, "Scale", ICON_NULL);
        colsub = uiLayoutColumn(split, 1);
-       uiItemL(colsub, "", 0);
-       uiItemR(colsub, "", ICON_LOCKED, ptr, "lock_scale", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY);
+       uiItemL(colsub, "", ICON_NULL);
+       uiItemR(colsub, ptr, "lock_scale", UI_ITEM_R_TOGGLE+UI_ITEM_R_ICON_ONLY, "", ICON_NULL);
        
        if (ptr->type == &RNA_Object) {
                Object *ob = ptr->data;
                if (ELEM5(ob->type, OB_MESH, OB_CURVE, OB_SURF, OB_FONT, OB_MBALL))
-                       uiItemR(layout, "Dimensions", 0, ptr, "dimensions", 0);
+                       uiItemR(layout, ptr, "dimensions", 0, "Dimensions", ICON_NULL);
        }
 }
 
-static void v3d_posearmature_buts(uiLayout *layout, View3D *v3d, Object *ob, float lim)
+static void v3d_posearmature_buts(uiLayout *layout, Object *ob)
 {
 //     uiBlock *block= uiLayoutGetBlock(layout);
 //     bArmature *arm;
@@ -808,13 +842,14 @@ static void v3d_posearmature_buts(uiLayout *layout, View3D *v3d, Object *ob, flo
        PointerRNA pchanptr;
        uiLayout *col;
 //     uiLayout *row;
+//     uiBut *but;
 
        pchan= get_active_posechannel(ob);
 
 //     row= uiLayoutRow(layout, 0);
        
        if (!pchan)     {
-               uiItemL(layout, "No Bone Active", 0);
+               uiItemL(layout, "No Bone Active", ICON_NULL);
                return; 
        }
 
@@ -846,9 +881,13 @@ static void v3d_posearmature_buts(uiLayout *layout, View3D *v3d, Object *ob, flo
        
        uiDefBut(block, LABEL, 0, "Location:",                  0, 240, 100, 20, 0, 0, 0, 0, 0, "");
        uiBlockBeginAlign(block);
-       uiDefButF(block, NUM, B_ARMATUREPANEL2, "X:",   0, 220, 120, 19, pchan->loc, -lim, lim, 100, 3, "");
-       uiDefButF(block, NUM, B_ARMATUREPANEL2, "Y:",   0, 200, 120, 19, pchan->loc+1, -lim, lim, 100, 3, "");
-       uiDefButF(block, NUM, B_ARMATUREPANEL2, "Z:",   0, 180, 120, 19, pchan->loc+2, -lim, lim, 100, 3, "");
+       
+       but= uiDefButF(block, NUM, B_ARMATUREPANEL2, "X:",      0, 220, 120, 19, pchan->loc, -lim, lim, 100, 3, "");
+       uiButSetUnitType(but, PROP_UNIT_LENGTH);
+       but= uiDefButF(block, NUM, B_ARMATUREPANEL2, "Y:",      0, 200, 120, 19, pchan->loc+1, -lim, lim, 100, 3, "");
+       uiButSetUnitType(but, PROP_UNIT_LENGTH);
+       but= uiDefButF(block, NUM, B_ARMATUREPANEL2, "Z:",      0, 180, 120, 19, pchan->loc+2, -lim, lim, 100, 3, "");
+       uiButSetUnitType(but, PROP_UNIT_LENGTH);
        uiBlockEndAlign(block);
        
        uiBlockBeginAlign(block);
@@ -886,22 +925,24 @@ static void v3d_posearmature_buts(uiLayout *layout, View3D *v3d, Object *ob, flo
 }
 
 /* assumes armature editmode */
-void validate_editbonebutton_cb(bContext *C, void *bonev, void *namev)
+#if 0
+static void validate_editbonebutton_cb(bContext *C, void *bonev, void *namev)
 {
        EditBone *eBone= bonev;
-       char oldname[32], newname[32];
-       
+       char oldname[sizeof(eBone->name)], newname[sizeof(eBone->name)];
+
        /* need to be on the stack */
-       BLI_strncpy(newname, eBone->name, 32);
-       BLI_strncpy(oldname, (char *)namev, 32);
+       BLI_strncpy(newname, eBone->name, sizeof(eBone->name));
+       BLI_strncpy(oldname, (char *)namev, sizeof(eBone->name));
        /* restore */
-       BLI_strncpy(eBone->name, oldname, 32);
-       
+       BLI_strncpy(eBone->name, oldname, sizeof(eBone->name));
+
        ED_armature_bone_rename(CTX_data_edit_object(C)->data, oldname, newname); // editarmature.c
        WM_event_add_notifier(C, NC_OBJECT|ND_BONE_SELECT, CTX_data_edit_object(C)); // XXX fix
 }
+#endif
 
-static void v3d_editarmature_buts(uiLayout *layout, View3D *v3d, Object *ob, float lim)
+static void v3d_editarmature_buts(uiLayout *layout, Object *ob)
 {
 //     uiBlock *block= uiLayoutGetBlock(layout);
        bArmature *arm= ob->data;
@@ -921,21 +962,21 @@ static void v3d_editarmature_buts(uiLayout *layout, View3D *v3d, Object *ob, flo
 
 
        col= uiLayoutColumn(layout, 0);
-       uiItemR(col, "Head", 0, &eboneptr, "head", 0);
+       uiItemR(col, &eboneptr, "head", 0, "Head", ICON_NULL);
        if (ebone->parent && ebone->flag & BONE_CONNECTED ) {
                PointerRNA parptr = RNA_pointer_get(&eboneptr, "parent");
-               uiItemR(col, "Radius", 0, &parptr, "tail_radius", 0);
+               uiItemR(col, &parptr, "tail_radius", 0, "Radius (Parent)", ICON_NULL);
        } else {
-               uiItemR(col, "Radius", 0, &eboneptr, "head_radius", 0);
+               uiItemR(col, &eboneptr, "head_radius", 0, "Radius", ICON_NULL);
        }
        
-       uiItemR(col, "Tail", 0, &eboneptr, "tail", 0);
-       uiItemR(col, "Radius", 0, &eboneptr, "tail_radius", 0);
+       uiItemR(col, &eboneptr, "tail", 0, "Tail", ICON_NULL);
+       uiItemR(col, &eboneptr, "tail_radius", 0, "Radius", ICON_NULL);
        
-       uiItemR(col, "Roll", 0, &eboneptr, "roll", 0);
+       uiItemR(col, &eboneptr, "roll", 0, "Roll", ICON_NULL);
 }
 
-static void v3d_editmetaball_buts(uiLayout *layout, Object *ob, float lim)
+static void v3d_editmetaball_buts(uiLayout *layout, Object *ob)
 {
        PointerRNA mbptr, ptr;
        MetaBall *mball= ob->data;
@@ -951,37 +992,37 @@ static void v3d_editmetaball_buts(uiLayout *layout, Object *ob, float lim)
        RNA_pointer_create(&mball->id, &RNA_MetaElement, mball->lastelem, &ptr);
        
        col= uiLayoutColumn(layout, 0);
-       uiItemR(col, "Location", 0, &ptr, "location", 0);
+       uiItemR(col, &ptr, "co", 0, "Location", ICON_NULL);
        
-       uiItemR(col, "Radius", 0, &ptr, "radius", 0);
-       uiItemR(col, "Stiffness", 0, &ptr, "stiffness", 0);
+       uiItemR(col, &ptr, "radius", 0, "Radius", ICON_NULL);
+       uiItemR(col, &ptr, "stiffness", 0, "Stiffness", ICON_NULL);
        
-       uiItemR(col, "Type", 0, &ptr, "type", 0);
+       uiItemR(col, &ptr, "type", 0, "Type", ICON_NULL);
        
        col= uiLayoutColumn(layout, 1);
        switch (RNA_enum_get(&ptr, "type")) {
                case MB_BALL:
                        break;
                case MB_CUBE:
-                       uiItemL(col, "Size:", 0);
-                       uiItemR(col, "X", 0, &ptr, "size_x", 0);
-                       uiItemR(col, "Y", 0, &ptr, "size_y", 0);
-                       uiItemR(col, "Z", 0, &ptr, "size_z", 0);
+                       uiItemL(col, "Size:", ICON_NULL);
+                       uiItemR(col, &ptr, "size_x", 0, "X", ICON_NULL);
+                       uiItemR(col, &ptr, "size_y", 0, "Y", ICON_NULL);
+                       uiItemR(col, &ptr, "size_z", 0, "Z", ICON_NULL);
                        break;
                case MB_TUBE:
-                       uiItemL(col, "Size:", 0);
-                       uiItemR(col, "X", 0, &ptr, "size_x", 0);
+                       uiItemL(col, "Size:", ICON_NULL);
+                       uiItemR(col, &ptr, "size_x", 0, "X", ICON_NULL);
                        break;
                case MB_PLANE:
-                       uiItemL(col, "Size:", 0);
-                       uiItemR(col, "X", 0, &ptr, "size_x", 0);
-                       uiItemR(col, "Y", 0, &ptr, "size_y", 0);
+                       uiItemL(col, "Size:", ICON_NULL);
+                       uiItemR(col, &ptr, "size_x", 0, "X", ICON_NULL);
+                       uiItemR(col, &ptr, "size_y", 0, "Y", ICON_NULL);
                        break;
                case MB_ELIPSOID:
-                       uiItemL(col, "Size:", 0);
-                       uiItemR(col, "X", 0, &ptr, "size_x", 0);
-                       uiItemR(col, "Y", 0, &ptr, "size_y", 0);
-                       uiItemR(col, "Z", 0, &ptr, "size_z", 0);
+                       uiItemL(col, "Size:", ICON_NULL);
+                       uiItemR(col, &ptr, "size_x", 0, "X", ICON_NULL);
+                       uiItemR(col, &ptr, "size_y", 0, "Y", ICON_NULL);
+                       uiItemR(col, &ptr, "size_z", 0, "Z", ICON_NULL);
                        break;             
        }       
 }
@@ -994,8 +1035,9 @@ static int test_parent_loop(Object *par, Object *ob)
        return test_parent_loop(par->parent, ob);
 }
 
-static void do_view3d_region_buttons(bContext *C, void *arg, int event)
+static void do_view3d_region_buttons(bContext *C, void *UNUSED(index), int event)
 {
+       Main *bmain= CTX_data_main(C);
        Scene *scene= CTX_data_scene(C);
 //     Object *obedit= CTX_data_edit_object(C);
        View3D *v3d= CTX_wm_view3d(C);
@@ -1010,14 +1052,14 @@ static void do_view3d_region_buttons(bContext *C, void *arg, int event)
                return; /* no notifier! */
                
        case B_OBJECTPANEL:
-               DAG_id_flush_update(&ob->id, OB_RECALC_OB);
+               DAG_id_tag_update(&ob->id, OB_RECALC_OB);
                break;
 
        
        case B_OBJECTPANELMEDIAN:
                if(ob) {
-                       v3d_editvertex_buts(C, NULL, v3d, ob, 1.0);
-                       DAG_id_flush_update(&ob->id, OB_RECALC_DATA);
+                       v3d_editvertex_buts(NULL, v3d, ob, 1.0);
+                       DAG_id_tag_update(&ob->id, OB_RECALC_DATA);
                }
                break;
                
@@ -1027,8 +1069,8 @@ static void do_view3d_region_buttons(bContext *C, void *arg, int event)
                        if(ob->id.lib || test_parent_loop(ob->parent, ob) ) 
                                ob->parent= NULL;
                        else {
-                               DAG_scene_sort(scene);
-                               DAG_id_flush_update(&ob->id, OB_RECALC_OB);
+                               DAG_scene_sort(bmain, scene);
+                               DAG_id_tag_update(&ob->id, OB_RECALC_OB);
                        }
                }
                break;
@@ -1062,12 +1104,15 @@ static void do_view3d_region_buttons(bContext *C, void *arg, int event)
        case B_ARMATUREPANEL2:
                {
                        ob->pose->flag |= (POSE_LOCKED|POSE_DO_UNLOCK);
-                       DAG_id_flush_update(&ob->id, OB_RECALC_DATA);
+                       DAG_id_tag_update(&ob->id, OB_RECALC_DATA);
                }
                break;
        case B_TRANSFORMSPACEADD:
-               BIF_createTransformOrientation(C, NULL, "", 1, 0);
+       {
+               char names[sizeof(((TransformOrientation *)NULL)->name)]= "";
+               BIF_createTransformOrientation(C, NULL, names, 1, 0);
                break;
+       }
        case B_TRANSFORMSPACECLEAR:
                BIF_clearTransformOrientation(C);
                break;
@@ -1115,7 +1160,7 @@ static void do_view3d_region_buttons(bContext *C, void *arg, int event)
                                int a;
                                for(a=0; a<me->totvert; a++)
                                        ED_vgroup_vert_remove (ob, defGroup, a);
-                               DAG_id_flush_update(&ob->id, OB_RECALC_DATA);
+                               DAG_id_tag_update(&ob->id, OB_RECALC_DATA);
                        }
                }
                break;
@@ -1156,16 +1201,6 @@ static void do_view3d_region_buttons(bContext *C, void *arg, int event)
        WM_event_add_notifier(C, NC_SPACE|ND_SPACE_VIEW3D, ob);
 }
 
-void removeTransformOrientation_func(bContext *C, void *target, void *unused)
-{
-       BIF_removeTransformOrientation(C, (TransformOrientation *) target);
-}
-
-void selectTransformOrientation_func(bContext *C, void *target, void *unused)
-{
-       BIF_selectTransformOrientation(C, (TransformOrientation *) target);
-}
-
 static void view3d_panel_object(const bContext *C, Panel *pa)
 {
        uiBlock *block;
@@ -1207,12 +1242,12 @@ static void view3d_panel_object(const bContext *C, Panel *pa)
        RNA_id_pointer_create(&ob->id, &obptr);
 
        if(ob==obedit) {
-               if(ob->type==OB_ARMATURE) v3d_editarmature_buts(col, v3d, ob, lim);
-               if(ob->type==OB_MBALL) v3d_editmetaball_buts(col, ob, lim);
-               else v3d_editvertex_buts(C, col, v3d, ob, lim);
+               if(ob->type==OB_ARMATURE) v3d_editarmature_buts(col, ob);
+               if(ob->type==OB_MBALL) v3d_editmetaball_buts(col, ob);
+               else v3d_editvertex_buts(col, v3d, ob, lim);
        }
        else if(ob->mode & OB_MODE_POSE) {
-               v3d_posearmature_buts(col, v3d, ob, lim);
+               v3d_posearmature_buts(col, ob);
        }
        else {
 
@@ -1380,53 +1415,6 @@ static void view3d_panel_bonesketch_spaces(const bContext *C, Panel *pa)
        uiBlockEndAlign(block);
 }
 
-/* op->invoke */
-static void redo_cb(bContext *C, void *arg_op, void *arg2)
-{
-       wmOperator *lastop= arg_op;
-       
-       if(lastop) {
-               int retval;
-               
-               if (G.f & G_DEBUG)
-                       printf("operator redo %s\n", lastop->type->name);
-               ED_undo_pop(C);
-               retval= WM_operator_repeat(C, lastop);
-               if((retval & OPERATOR_FINISHED)==0) {
-                       if (G.f & G_DEBUG)
-                               printf("operator redo failed %s\n", lastop->type->name);
-                       ED_undo_redo(C);
-               }
-       }
-}
-
-static void view3d_panel_operator_redo(const bContext *C, Panel *pa)
-{
-       wmWindowManager *wm= CTX_wm_manager(C);
-       wmOperator *op;
-       PointerRNA ptr;
-       uiBlock *block;
-       
-       block= uiLayoutGetBlock(pa->layout);
-
-       /* only for operators that are registered and did an undo push */
-       for(op= wm->operators.last; op; op= op->prev)
-               if((op->type->flag & OPTYPE_REGISTER) && (op->type->flag & OPTYPE_UNDO))
-                       break;
-       
-       if(op==NULL)
-               return;
-       
-       uiBlockSetFunc(block, redo_cb, op, NULL);
-       
-       if(!op->properties) {
-               IDPropertyTemplate val = {0};
-               op->properties= IDP_New(IDP_GROUP, val, "wmOperatorProperties");
-       }
-       
-       RNA_pointer_create(&wm->id, op->type->srna, op->properties, &ptr);
-       uiDefAutoButsRNA(C, pa->layout, &ptr, 2);
-}
 #endif // XXX not used
 
 void view3d_buttons_register(ARegionType *art)
@@ -1455,7 +1443,7 @@ void view3d_buttons_register(ARegionType *art)
        // XXX view3d_panel_preview(C, ar, 0);
 }
 
-static int view3d_properties(bContext *C, wmOperator *op)
+static int view3d_properties(bContext *C, wmOperator *UNUSED(op))
 {
        ScrArea *sa= CTX_wm_area(C);
        ARegion *ar= view3d_has_buttons_region(sa);
@@ -1469,7 +1457,7 @@ static int view3d_properties(bContext *C, wmOperator *op)
 void VIEW3D_OT_properties(wmOperatorType *ot)
 {
        ot->name= "Properties";
-       ot->description= "Toggles the properties panel display.";
+       ot->description= "Toggles the properties panel display";
        ot->idname= "VIEW3D_OT_properties";
        
        ot->exec= view3d_properties;