code cleanup: function naming, use BKE_*type* prefix.
[blender.git] / source / blender / collada / AnimationImporter.cpp
index ee04c270843fe0813d98effb6a3ff2f0e11b36ab..34f7efa9de0fc13e85d5d363f4cd5f8b12cb0719 100644 (file)
@@ -1,6 +1,4 @@
 /*
- * $Id$
- *
  * ***** BEGIN GPL LICENSE BLOCK *****
  *
  * This program is free software; you can redistribute it and/or
@@ -89,17 +87,11 @@ void AnimationImporter::animation_to_fcurves(COLLADAFW::AnimationCurve *curve)
 {
        COLLADAFW::FloatOrDoubleArray& input = curve->getInputValues();
        COLLADAFW::FloatOrDoubleArray& output = curve->getOutputValues();
-    
-       if( curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER ||
-               curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_STEP ) {
-       COLLADAFW::FloatOrDoubleArray& intan = curve->getInTangentValues();
-    COLLADAFW::FloatOrDoubleArray& outtan = curve->getOutTangentValues();
-       }
 
        float fps = (float)FPS;
        size_t dim = curve->getOutDimension();
        unsigned int i;
-       
+
        std::vector<FCurve*>& fcurves = curve_map[curve->getUniqueId()];
 
        switch (dim) {
@@ -110,50 +102,49 @@ void AnimationImporter::animation_to_fcurves(COLLADAFW::AnimationCurve *curve)
                {
                        for (i = 0; i < dim; i++ ) {
                                FCurve *fcu = (FCurve*)MEM_callocN(sizeof(FCurve), "FCurve");
-                       
+
                                fcu->flag = (FCURVE_VISIBLE|FCURVE_AUTO_HANDLES|FCURVE_SELECTED);
                                // fcu->rna_path = BLI_strdupn(path, strlen(path));
                                fcu->array_index = 0;
                                fcu->totvert = curve->getKeyCount();
-                       
+
                                // create beztriple for each key
                                for (unsigned int j = 0; j < curve->getKeyCount(); j++) {
                                        BezTriple bez;
                                        memset(&bez, 0, sizeof(BezTriple));
 
-                                       
+
                                        // input, output
                                        bez.vec[1][0] = bc_get_float_value(input, j) * fps; 
                                        bez.vec[1][1] = bc_get_float_value(output, j * dim + i);
 
 
-                                       if( curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER ||
+                                       if ( curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER ||
                                                curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_STEP) 
                                        {
                                                COLLADAFW::FloatOrDoubleArray& intan = curve->getInTangentValues();
-                        COLLADAFW::FloatOrDoubleArray& outtan = curve->getOutTangentValues();
+                                               COLLADAFW::FloatOrDoubleArray& outtan = curve->getOutTangentValues();
 
                                                // intangent
-                                                bez.vec[0][0] = bc_get_float_value(intan, (j * 2 * dim ) + (2 * i)) * fps;
-                                                bez.vec[0][1] = bc_get_float_value(intan, (j * 2 * dim )+ (2 * i) + 1);
+                                               bez.vec[0][0] = bc_get_float_value(intan, (j * 2 * dim ) + (2 * i)) * fps;
+                                               bez.vec[0][1] = bc_get_float_value(intan, (j * 2 * dim )+ (2 * i) + 1);
 
-                                                // outtangent
-                                                bez.vec[2][0] = bc_get_float_value(outtan, (j * 2 * dim ) + (2 * i)) * fps;
-                                                bez.vec[2][1] = bc_get_float_value(outtan, (j * 2 * dim )+ (2 * i) + 1);
-                                                if(curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER) 
+                                               // outtangent
+                                               bez.vec[2][0] = bc_get_float_value(outtan, (j * 2 * dim ) + (2 * i)) * fps;
+                                               bez.vec[2][1] = bc_get_float_value(outtan, (j * 2 * dim )+ (2 * i) + 1);
+                                               if (curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER) 
                                                        bez.ipo = BEZT_IPO_BEZ;
-                                                else 
-                                                        bez.ipo = BEZT_IPO_CONST;
-                                                //bez.h1 = bez.h2 = HD_AUTO;   
+                                               else 
+                                                       bez.ipo = BEZT_IPO_CONST;
+                                               //bez.h1 = bez.h2 = HD_AUTO;    
                                        }
-                                       else 
-                                       {
+                                       else {
                                                bez.h1 = bez.h2 = HD_AUTO; 
                                                bez.ipo = BEZT_IPO_LIN;
                                        }
                                        // bez.ipo = U.ipo_new; /* use default interpolation mode here... */
                                        bez.f1 = bez.f2 = bez.f3 = SELECT;
-                                       
+
                                        insert_bezt_fcurve(fcu, &bez, 0);
                                }
 
@@ -176,10 +167,9 @@ void AnimationImporter::fcurve_deg_to_rad(FCurve *cu)
 {
        for (unsigned int i = 0; i < cu->totvert; i++) {
                // TODO convert handles too
-               cu->bezt[i].vec[1][1] *= M_PI / 180.0f;
-               cu->bezt[i].vec[0][1] *= M_PI / 180.0f;
-               cu->bezt[i].vec[2][1] *= M_PI / 180.0f;
-               cu->bezt[i].vec[1][0];
+               cu->bezt[i].vec[1][1] *= DEG2RADF(1.0f);
+               cu->bezt[i].vec[0][1] *= DEG2RADF(1.0f);
+               cu->bezt[i].vec[2][1] *= DEG2RADF(1.0f);
        }
 }
 
@@ -270,7 +260,7 @@ bool AnimationImporter::write_animation(const COLLADAFW::Animation* anim)
                // XXX Don't know if it's necessary
                // Should we check outPhysicalDimension?
                if (curve->getInPhysicalDimension() != COLLADAFW::PHYSICAL_DIMENSION_TIME) {
-                       fprintf(stderr, "Inputs physical dimension is not time. \n");
+                       fprintf(stderr, "Inputs physical dimension is not time.\n");
                        return true;
                }
 
@@ -307,9 +297,9 @@ bool AnimationImporter::write_animation(const COLLADAFW::Animation* anim)
 bool AnimationImporter::write_animation_list(const COLLADAFW::AnimationList* animlist) 
 {
        const COLLADAFW::UniqueId& animlist_id = animlist->getUniqueId();
-    
+
        animlist_map[animlist_id] = animlist;
-    
+
 #if 0
 
        // should not happen
@@ -318,10 +308,10 @@ bool AnimationImporter::write_animation_list(const COLLADAFW::AnimationList* ani
        }
 
        // for bones rna_path is like: pose.bones["bone-name"].rotation
-       
+
 
 #endif
-       
+
        return true;
 }
 
@@ -334,7 +324,7 @@ void AnimationImporter::read_node_transform(COLLADAFW::Node *node, Object *ob)
        TransformReader::get_node_mat(mat, node, &uid_animated_map, ob);
        if (ob) {
                copy_m4_m4(ob->obmat, mat);
-               object_apply_mat4(ob, ob->obmat, 0, 0);
+               BKE_object_apply_mat4(ob, ob->obmat, 0, 0);
        }
 }
 
@@ -433,13 +423,13 @@ virtual void AnimationImporter::change_eul_to_quat(Object *ob, bAction *act)
 
 
 //sets the rna_path and array index to curve
-void AnimationImporter::modify_fcurve(std::vector<FCurve*>* curves , char* rna_path , int array_index )
-{   
+void AnimationImporter::modify_fcurve(std::vector<FCurve*>* curves, const char* rna_path, int array_index )
+{
        std::vector<FCurve*>::iterator it;
        int i;
        for (it = curves->begin(), i = 0; it != curves->end(); it++, i++) {
                FCurve *fcu = *it;
-               fcu->rna_path = BLI_strdupn(rna_path, strlen(rna_path));
+               fcu->rna_path = BLI_strdup(rna_path);
                
                if (array_index == -1) fcu->array_index = i;
                else fcu->array_index = array_index;
@@ -448,43 +438,53 @@ void AnimationImporter::modify_fcurve(std::vector<FCurve*>* curves , char* rna_p
        }
 }
 
-void AnimationImporter::find_frames( std::vector<float>* frames , std::vector<FCurve*>* curves)
+void AnimationImporter::unused_fcurve(std::vector<FCurve*>* curves)
+{
+       // when an error happens and we can't actually use curve remove it from unused_curves
+       std::vector<FCurve*>::iterator it;
+       for (it = curves->begin(); it != curves->end(); it++) {
+               FCurve *fcu = *it;
+               unused_curves.erase(std::remove(unused_curves.begin(), unused_curves.end(), fcu), unused_curves.end());
+       }
+}
+
+void AnimationImporter::find_frames( std::vector<float>* frames, std::vector<FCurve*>* curves)
 {
        std::vector<FCurve*>::iterator iter;
-               for (iter = curves->begin(); iter != curves->end(); iter++) {
-                       FCurve *fcu = *iter;
-        
-                       for (unsigned int k = 0; k < fcu->totvert; k++) {
-                               //get frame value from bezTriple
-                               float fra = fcu->bezt[k].vec[1][0];
-                               //if frame already not added add frame to frames
-                               if (std::find(frames->begin(), frames->end(), fra) == frames->end())
-                                       frames->push_back(fra);
-                                                               
-                       }
+       for (iter = curves->begin(); iter != curves->end(); iter++) {
+               FCurve *fcu = *iter;
+
+               for (unsigned int k = 0; k < fcu->totvert; k++) {
+                       //get frame value from bezTriple
+                       float fra = fcu->bezt[k].vec[1][0];
+                       //if frame already not added add frame to frames
+                       if (std::find(frames->begin(), frames->end(), fra) == frames->end())
+                               frames->push_back(fra);
+
                }
+       }
 }
 
 //creates the rna_paths and array indices of fcurves from animations using transformation and bound animation class of each animation.
-void AnimationImporter:: Assign_transform_animations(COLLADAFW::Transformation * transform , 
+void AnimationImporter:: Assign_transform_animations(COLLADAFW::Transformation * transform,
                                                                                                         const COLLADAFW::AnimationList::AnimationBinding * binding,
                                                                                                         std::vector<FCurve*>* curves, bool is_joint, char * joint_path)
 {
        COLLADAFW::Transformation::TransformationType tm_type = transform->getTransformationType();
        bool is_matrix = tm_type == COLLADAFW::Transformation::MATRIX;
        bool is_rotation = tm_type  == COLLADAFW::Transformation::ROTATE;
-       
+
        //to check if the no of curves are valid
        bool xyz = ((tm_type == COLLADAFW::Transformation::TRANSLATE ||tm_type  == COLLADAFW::Transformation::SCALE) && binding->animationClass == COLLADAFW::AnimationList::POSITION_XYZ);
-                        
-       
+
+
        if (!((!xyz && curves->size() == 1) || (xyz && curves->size() == 3) || is_matrix)) {
                fprintf(stderr, "expected %d curves, got %d\n", xyz ? 3 : 1, (int)curves->size());
                return;
        }
-       
+
        char rna_path[100];
-                                                       
+
        switch (tm_type) {
                case COLLADAFW::Transformation::TRANSLATE:
                case COLLADAFW::Transformation::SCALE:
@@ -496,96 +496,102 @@ void AnimationImporter:: Assign_transform_animations(COLLADAFW::Transformation *
                                        BLI_strncpy(rna_path, loc ? "location" : "scale", sizeof(rna_path));
 
                                switch (binding->animationClass) {
-                                       case COLLADAFW::AnimationList::POSITION_X:
-                                               modify_fcurve(curves, rna_path, 0 );
-                                               break;
-                                       case COLLADAFW::AnimationList::POSITION_Y:
-                                               modify_fcurve(curves, rna_path, 1 );
-                                               break;
-                                       case COLLADAFW::AnimationList::POSITION_Z:
-                                               modify_fcurve(curves, rna_path, 2 );
-                                               break;
-                                       case COLLADAFW::AnimationList::POSITION_XYZ:
-                                               modify_fcurve(curves, rna_path, -1 );
-                                               break;
-                                       default:
-                                               fprintf(stderr, "AnimationClass %d is not supported for %s.\n",
-                                                               binding->animationClass, loc ? "TRANSLATE" : "SCALE");
-                                       }
-               break;
+               case COLLADAFW::AnimationList::POSITION_X:
+                       modify_fcurve(curves, rna_path, 0 );
+                       break;
+               case COLLADAFW::AnimationList::POSITION_Y:
+                       modify_fcurve(curves, rna_path, 1 );
+                       break;
+               case COLLADAFW::AnimationList::POSITION_Z:
+                       modify_fcurve(curves, rna_path, 2 );
+                       break;
+               case COLLADAFW::AnimationList::POSITION_XYZ:
+                       modify_fcurve(curves, rna_path, -1 );
+                       break;
+               default:
+                       unused_fcurve(curves);
+                       fprintf(stderr, "AnimationClass %d is not supported for %s.\n",
+                               binding->animationClass, loc ? "TRANSLATE" : "SCALE");
+                               }
+                               break;
                        }
-               
-               
+
+
                case COLLADAFW::Transformation::ROTATE:
                        {
                                if (is_joint)
                                        BLI_snprintf(rna_path, sizeof(rna_path), "%s.rotation_euler", joint_path);
                                else
                                        BLI_strncpy(rna_path, "rotation_euler", sizeof(rna_path));
-                std::vector<FCurve*>::iterator iter;
+                               std::vector<FCurve*>::iterator iter;
                                for (iter = curves->begin(); iter != curves->end(); iter++) {
                                        FCurve* fcu = *iter;
-                                       
+
                                        //if transform is rotation the fcurves values must be turned in to radian.
                                        if (is_rotation)
                                                fcurve_deg_to_rad(fcu);          
                                }                                       
                                COLLADAFW::Rotate* rot = (COLLADAFW::Rotate*)transform;
                                COLLADABU::Math::Vector3& axis = rot->getRotationAxis();
-                       
+
                                switch (binding->animationClass) {
-                                       case COLLADAFW::AnimationList::ANGLE:
-                                               if (COLLADABU::Math::Vector3::UNIT_X == axis) {
-                                                       modify_fcurve(curves, rna_path, 0 );
-                                               }
-                                               else if (COLLADABU::Math::Vector3::UNIT_Y == axis) {
-                                                       modify_fcurve(curves, rna_path, 1 );
-                                               }
-                                               else if (COLLADABU::Math::Vector3::UNIT_Z == axis) {
-                                                       modify_fcurve(curves, rna_path, 2 );
-                                               }
-                                               break;
-                                       case COLLADAFW::AnimationList::AXISANGLE:
-                                               // TODO convert axis-angle to quat? or XYZ?
-                                       default:
-                                               fprintf(stderr, "AnimationClass %d is not supported for ROTATE transformation.\n",
-                                                               binding->animationClass);
-                                       }
+               case COLLADAFW::AnimationList::ANGLE:
+                       if (COLLADABU::Math::Vector3::UNIT_X == axis) {
+                               modify_fcurve(curves, rna_path, 0 );
+                       }
+                       else if (COLLADABU::Math::Vector3::UNIT_Y == axis) {
+                               modify_fcurve(curves, rna_path, 1 );
+                       }
+                       else if (COLLADABU::Math::Vector3::UNIT_Z == axis) {
+                               modify_fcurve(curves, rna_path, 2 );
+                       }
+                       else
+                               unused_fcurve(curves);
                        break;
+               case COLLADAFW::AnimationList::AXISANGLE:
+                       // TODO convert axis-angle to quat? or XYZ?
+               default:
+                       unused_fcurve(curves);
+                       fprintf(stderr, "AnimationClass %d is not supported for ROTATE transformation.\n",
+                               binding->animationClass);
+                               }
+                               break;
                        }
-                       
+
                case COLLADAFW::Transformation::MATRIX:
                        /*{
-                               COLLADAFW::Matrix* mat = (COLLADAFW::Matrix*)transform;
-                               COLLADABU::Math::Matrix4 mat4 = mat->getMatrix();
-                               switch (binding->animationClass) {
-                                       case COLLADAFW::AnimationList::TRANSFORM:
-                                       
-                               }
+                       COLLADAFW::Matrix* mat = (COLLADAFW::Matrix*)transform;
+                       COLLADABU::Math::Matrix4 mat4 = mat->getMatrix();
+                       switch (binding->animationClass) {
+                       case COLLADAFW::AnimationList::TRANSFORM:
+
+                       }
                        }*/
+                       unused_fcurve(curves);
                        break;
                case COLLADAFW::Transformation::SKEW:
                case COLLADAFW::Transformation::LOOKAT:
+                       unused_fcurve(curves);
                        fprintf(stderr, "Animation of SKEW and LOOKAT transformations is not supported yet.\n");
                        break;
-               }
-       
+       }
+
 }
 
 //creates the rna_paths and array indices of fcurves from animations using color and bound animation class of each animation.
-void AnimationImporter:: Assign_color_animations(const COLLADAFW::UniqueId& listid, ListBase *AnimCurves ,char * anim_type)
+void AnimationImporter:: Assign_color_animations(const COLLADAFW::UniqueId& listid, ListBase *AnimCurves, const char * anim_type)
 {
        char rna_path[100];
-       BLI_strncpy(rna_path,anim_type, sizeof(rna_path));
-    
+       BLI_strncpy(rna_path, anim_type, sizeof(rna_path));
+
        const COLLADAFW::AnimationList *animlist = animlist_map[listid];
        const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
-                               //all the curves belonging to the current binding
-       std::vector<FCurve*> animcurves;    
+       //all the curves belonging to the current binding
+       std::vector<FCurve*> animcurves;
        for (unsigned int j = 0; j < bindings.getCount(); j++) {
-                animcurves = curve_map[bindings[j].animation];
-               
-           switch (bindings[j].animationClass) {
+               animcurves = curve_map[bindings[j].animation];
+
+               switch (bindings[j].animationClass) {
                case COLLADAFW::AnimationList::COLOR_R:
                        modify_fcurve(&animcurves, rna_path, 0 );
                        break;
@@ -599,51 +605,53 @@ void AnimationImporter:: Assign_color_animations(const COLLADAFW::UniqueId& list
                case COLLADAFW::AnimationList::COLOR_RGBA: // to do-> set intensity
                        modify_fcurve(&animcurves, rna_path, -1 );
                        break;
-                       
+
                default:
+                       unused_fcurve(&animcurves);
                        fprintf(stderr, "AnimationClass %d is not supported for %s.\n",
-                                       bindings[j].animationClass, "COLOR" );
+                               bindings[j].animationClass, "COLOR" );
                }
 
-                std::vector<FCurve*>::iterator iter;
+               std::vector<FCurve*>::iterator iter;
                //Add the curves of the current animation to the object
                for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
                        FCurve * fcu = *iter;
                        BLI_addtail(AnimCurves, fcu);   
-               }                               
+               }
        }
 
-       
+
 }
 
-void AnimationImporter:: Assign_float_animations(const COLLADAFW::UniqueId& listid, ListBase *AnimCurves, char * anim_type)
+void AnimationImporter:: Assign_float_animations(const COLLADAFW::UniqueId& listid, ListBase *AnimCurves, const char * anim_type)
 {
        char rna_path[100];
-       if (animlist_map.find(listid) == animlist_map.end()) return ;
-       else 
-       {
+       if (animlist_map.find(listid) == animlist_map.end()) {
+               return;
+       }
+       else {
                //anim_type has animations
                const COLLADAFW::AnimationList *animlist = animlist_map[listid];
                const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
                //all the curves belonging to the current binding
-               std::vector<FCurve*> animcurves;    
+               std::vector<FCurve*> animcurves;
                for (unsigned int j = 0; j < bindings.getCount(); j++) {
-                        animcurves = curve_map[bindings[j].animation];
-               
-                        BLI_strncpy(rna_path, anim_type , sizeof(rna_path));
-                        modify_fcurve(&animcurves, rna_path, 0 );
-                        std::vector<FCurve*>::iterator iter;
-                               //Add the curves of the current animation to the object
-                               for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
-                                       FCurve * fcu = *iter;
-                                       BLI_addtail(AnimCurves, fcu);   
-                               }                               
+                       animcurves = curve_map[bindings[j].animation];
+
+                       BLI_strncpy(rna_path, anim_type, sizeof(rna_path));
+                       modify_fcurve(&animcurves, rna_path, 0 );
+                       std::vector<FCurve*>::iterator iter;
+                       //Add the curves of the current animation to the object
+                       for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
+                               FCurve * fcu = *iter;
+                               BLI_addtail(AnimCurves, fcu);
+                       }
                }
        }
        
 }
 
-void AnimationImporter::apply_matrix_curves( Object * ob, std::vector<FCurve*>& animcurves, COLLADAFW::Node* root ,COLLADAFW::Node* node, 
+void AnimationImporter::apply_matrix_curves( Object * ob, std::vector<FCurve*>& animcurves, COLLADAFW::Node* root, COLLADAFW::Node* node,
                                                                                                        COLLADAFW::Transformation * tm )
 {
        bool is_joint = node->getType() == COLLADAFW::Node::JOINT;
@@ -672,42 +680,42 @@ void AnimationImporter::apply_matrix_curves( Object * ob, std::vector<FCurve*>&
                copy_m4_m4(rest, bone->arm_mat);
                invert_m4_m4(irest, rest);
        }
-    // new curves to assign matrix transform animation
+       // new curves to assign matrix transform animation
        FCurve *newcu[10]; // if tm_type is matrix, then create 10 curves: 4 rot, 3 loc, 3 scale
-       unsigned int totcu = 10 ;
-    const char *tm_str = NULL;
+       unsigned int totcu = 10;
+       const char *tm_str = NULL;
        char rna_path[200];
        for (int i = 0; i < totcu; i++) {
 
                int axis = i;
 
-                       if (i < 4) {
-                               tm_str = "rotation_quaternion";
-                               axis = i;
-                       }
-                       else if (i < 7) {
-                               tm_str = "location";
-                               axis = i - 4;
-                       }
-                       else {
-                               tm_str = "scale";
-                               axis = i - 7;
-                       }
-               
+               if (i < 4) {
+                       tm_str = "rotation_quaternion";
+                       axis = i;
+               }
+               else if (i < 7) {
+                       tm_str = "location";
+                       axis = i - 4;
+               }
+               else {
+                       tm_str = "scale";
+                       axis = i - 7;
+               }
+
 
                if (is_joint)
                        BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, tm_str);
                else
-                       strcpy(rna_path, tm_str);
+                       BLI_strncpy(rna_path, tm_str, sizeof(rna_path));
                newcu[i] = create_fcurve(axis, rna_path);
                newcu[i]->totvert = frames.size();
        }
 
-    if (frames.size() == 0)
+       if (frames.size() == 0)
                return;
 
-std::sort(frames.begin(), frames.end());
-               
+       std::sort(frames.begin(), frames.end());
+
        std::vector<float>::iterator it;
 
        // sample values at each frame
@@ -718,7 +726,7 @@ std::sort(frames.begin(), frames.end());
                float matfra[4][4];
 
                unit_m4(matfra);
-        
+
                // calc object-space mat
                evaluate_transform_at_frame(matfra, node, fra);
 
@@ -732,9 +740,9 @@ std::sort(frames.begin(), frames.end());
 
                        // calc M
                        calc_joint_parent_mat_rest(par, NULL, root, node);
-                       mul_m4_m4m4(temp, matfra, par);
+                       mult_m4_m4m4(temp, par, matfra);
 
-                       // evaluate_joint_world_transform_at_frame(temp, NULL, node, fra);
+                       // evaluate_joint_world_transform_at_frame(temp, NULL, node, fra);
 
                        // calc special matrix
                        mul_serie_m4(mat, irest, temp, irest_dae, rest, NULL, NULL, NULL, NULL);
@@ -744,23 +752,23 @@ std::sort(frames.begin(), frames.end());
                }
 
                float  rot[4], loc[3], scale[3];
-        
-                       mat4_to_quat(rot, mat);
-                       /*for ( int i = 0 ; i < 4  ;  i ++ )
-                       {
-                               rot[i] = rot[i] * (180 / M_PI); 
-                       }*/
-                       copy_v3_v3(loc, mat[3]);
-                       mat4_to_size(scale, mat);
-               
+
+               mat4_to_quat(rot, mat);
+               /*for ( int i = 0 ; i < 4  ;  i ++ )
+               {
+               rot[i] = RAD2DEGF(rot[i]);
+               }*/
+               copy_v3_v3(loc, mat[3]);
+               mat4_to_size(scale, mat);
+
                // add keys
                for (int i = 0; i < totcu; i++) {
-                               if (i < 4)
-                                       add_bezt(newcu[i], fra, rot[i]);
-                               else if (i < 7)
-                                       add_bezt(newcu[i], fra, loc[i - 4]);
-                               else
-                                       add_bezt(newcu[i], fra, scale[i - 7]);
+                       if (i < 4)
+                               add_bezt(newcu[i], fra, rot[i]);
+                       else if (i < 7)
+                               add_bezt(newcu[i], fra, loc[i - 4]);
+                       else
+                               add_bezt(newcu[i], fra, scale[i - 7]);
                }
        }
        verify_adt_action((ID*)&ob->id, 1);
@@ -775,54 +783,51 @@ std::sort(frames.begin(), frames.end());
                        BLI_addtail(curves, newcu[i]);
        }
 
-               if (is_joint) {
-                       bPoseChannel *chan = get_pose_channel(ob->pose, bone_name);
-                       chan->rotmode = ROT_MODE_QUAT;
-               }
-               else {
-                       ob->rotmode = ROT_MODE_QUAT;
-               }
+       if (is_joint) {
+               bPoseChannel *chan = get_pose_channel(ob->pose, bone_name);
+               chan->rotmode = ROT_MODE_QUAT;
+       }
+       else {
+               ob->rotmode = ROT_MODE_QUAT;
+       }
 
        return;
 
 }
 
-void AnimationImporter::translate_Animations ( COLLADAFW::Node * node , 
-                                                                                                  std::map<COLLADAFW::UniqueId, COLLADAFW::Node*>& root_map,
-                                                                                                  std::map<COLLADAFW::UniqueId, Object*>& object_map,
-                                                                                                  std::map<COLLADAFW::UniqueId, const COLLADAFW::Object*> FW_object_map)
+void AnimationImporter::translate_Animations ( COLLADAFW::Node * node,
+                                                                                               std::map<COLLADAFW::UniqueId, COLLADAFW::Node*>& root_map,
+                                                                                               std::multimap<COLLADAFW::UniqueId, Object*>& object_map,
+                                                                                               std::map<COLLADAFW::UniqueId, const COLLADAFW::Object*> FW_object_map)
 {
        AnimationImporter::AnimMix* animType = get_animation_type(node, FW_object_map );
 
        bool is_joint = node->getType() == COLLADAFW::Node::JOINT;
        COLLADAFW::Node *root = root_map.find(node->getUniqueId()) == root_map.end() ? node : root_map[node->getUniqueId()];
-       Object *ob = is_joint ? armature_importer->get_armature_for_joint(root) : object_map[node->getUniqueId()];
-       if (!ob)
-       {
+    Object *ob = is_joint ? armature_importer->get_armature_for_joint(root) : object_map.find(node->getUniqueId())->second;
+       if (!ob) {
                fprintf(stderr, "cannot find Object for Node with id=\"%s\"\n", node->getOriginalId().c_str());
                return;
        }
 
        bAction * act;
-       bActionGroup *grp = NULL;
-    
-       if ( (animType->transform) != 0 )
-       {
-       const char *bone_name = is_joint ? bc_get_joint_name(node) : NULL;
-        char joint_path[200];
+
+       if ( (animType->transform) != 0 ) {
+               /* const char *bone_name = is_joint ? bc_get_joint_name(node) : NULL; */ /* UNUSED */
+               char joint_path[200];
 
                if ( is_joint ) 
-               armature_importer->get_rna_path_for_joint(node, joint_path, sizeof(joint_path));
-               
-       
+                       armature_importer->get_rna_path_for_joint(node, joint_path, sizeof(joint_path));
+
+
                if (!ob->adt || !ob->adt->action) act = verify_adt_action((ID*)&ob->id, 1);
                else act = ob->adt->action;
-               
-           //Get the list of animation curves of the object
-           ListBase *AnimCurves = &(act->curves);
+
+               //Get the list of animation curves of the object
+               ListBase *AnimCurves = &(act->curves);
 
                const COLLADAFW::TransformationPointerArray& nodeTransforms = node->getTransformations();
-       
+
                //for each transformation in node 
                for (unsigned int i = 0; i < nodeTransforms.getCount(); i++) {
                        COLLADAFW::Transformation *transform = nodeTransforms[i];
@@ -830,58 +835,57 @@ void AnimationImporter::translate_Animations ( COLLADAFW::Node * node ,
 
                        bool is_rotation = tm_type == COLLADAFW::Transformation::ROTATE;
                        bool is_matrix = tm_type == COLLADAFW::Transformation::MATRIX;
-                               
+
                        const COLLADAFW::UniqueId& listid = transform->getAnimationList();
-               
-                       //check if transformation has animations    
-                       if (animlist_map.find(listid) == animlist_map.end()) continue ; 
-                       else 
-                       {
+
+                       //check if transformation has animations
+                       if (animlist_map.find(listid) == animlist_map.end()) {
+                               continue;
+                       }
+                       else {
                                //transformation has animations
                                const COLLADAFW::AnimationList *animlist = animlist_map[listid];
                                const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
                                //all the curves belonging to the current binding
-                               std::vector<FCurve*> animcurves;    
+                               std::vector<FCurve*> animcurves;
                                for (unsigned int j = 0; j < bindings.getCount(); j++) {
-                                        animcurves = curve_map[bindings[j].animation];
-                                        if ( is_matrix )
-                                                apply_matrix_curves(ob, animcurves, root , node,  transform  );
-                                        else {                         
-                                               //calculate rnapaths and array index of fcurves according to transformation and animation class
-                                                Assign_transform_animations(transform, &bindings[j], &animcurves, is_joint, joint_path ); 
-                                               
-                                                std::vector<FCurve*>::iterator iter;
+                                       animcurves = curve_map[bindings[j].animation];
+                                       if ( is_matrix ) {
+                                               apply_matrix_curves(ob, animcurves, root, node,  transform  );
+                                       }
+                                       else {                          
+
+                                               if (is_joint) {
+
+                                                       add_bone_animation_sampled(ob, animcurves, root, node, transform);
+                                               }
+                                               else {
+                                                       //calculate rnapaths and array index of fcurves according to transformation and animation class
+                                                       Assign_transform_animations(transform, &bindings[j], &animcurves, is_joint, joint_path ); 
+
+                                                       std::vector<FCurve*>::iterator iter;
                                                        //Add the curves of the current animation to the object
                                                        for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
                                                                FCurve * fcu = *iter;
-                                                               if ((ob->type == OB_ARMATURE))
-                                                                       add_bone_fcurve( ob, node , fcu );
-                                                               else 
-                                                                       BLI_addtail(AnimCurves, fcu);   
+                                                       
+                                                               BLI_addtail(AnimCurves, fcu);
                                                        }
                                                }
+                                               
+                                       }
                                }
                        }
-                       if (is_rotation) {
-                               if (is_joint) 
-                               {
-                                       bPoseChannel *chan = get_pose_channel(ob->pose, bone_name);
-                                       chan->rotmode = ROT_MODE_EUL;
-                               }
-                               else 
-                               {
-                                       ob->rotmode = ROT_MODE_EUL;
-                               }
+                       if (is_rotation && !is_joint) {
+                               ob->rotmode = ROT_MODE_EUL;
                        }
                }
        }
 
-       if ((animType->light) != 0)
-       {
+       if ((animType->light) != 0) {
                Lamp * lamp  = (Lamp*) ob->data;
 
                if (!lamp->adt || !lamp->adt->action) act = verify_adt_action((ID*)&lamp->id, 1);
-                                       else act = lamp->adt->action;
+               else act = lamp->adt->action;
 
                ListBase *AnimCurves = &(act->curves);
                const COLLADAFW::InstanceLightPointerArray& nodeLights = node->getInstanceLights();
@@ -889,37 +893,33 @@ void AnimationImporter::translate_Animations ( COLLADAFW::Node * node ,
                for (unsigned int i = 0; i < nodeLights.getCount(); i++) {
                        const COLLADAFW::Light *light = (COLLADAFW::Light *) FW_object_map[nodeLights[i]->getInstanciatedObjectId()];
 
-                       if ((animType->light & LIGHT_COLOR) != 0)
-                       {
+                       if ((animType->light & LIGHT_COLOR) != 0) {
                                const COLLADAFW::Color *col =  &(light->getColor());
                                const COLLADAFW::UniqueId& listid = col->getAnimationList();
-                               
+
                                Assign_color_animations(listid, AnimCurves, "color"); 
                        }
-                       if ((animType->light & LIGHT_FOA) != 0 )
-                       {
+                       if ((animType->light & LIGHT_FOA) != 0 ) {
                                const COLLADAFW::AnimatableFloat *foa =  &(light->getFallOffAngle());
                                const COLLADAFW::UniqueId& listid = foa->getAnimationList();
-                               
-                               Assign_float_animations( listid ,AnimCurves, "spot_size"); 
+
+                               Assign_float_animations( listid, AnimCurves, "spot_size");
                        }
-                       if ( (animType->light & LIGHT_FOE) != 0 )
-                       {
+                       if ( (animType->light & LIGHT_FOE) != 0 ) {
                                const COLLADAFW::AnimatableFloat *foe =  &(light->getFallOffExponent());
                                const COLLADAFW::UniqueId& listid = foe->getAnimationList();
-                               
-                               Assign_float_animations( listid ,AnimCurves, "spot_blend"); 
-                       
+
+                               Assign_float_animations( listid, AnimCurves, "spot_blend");
+
                        }
                }
        }
 
-       if ( (animType->camera) != 0) 
-       {
+       if ( (animType->camera) != 0)  {
                Camera * camera  = (Camera*) ob->data;
 
                if (!camera->adt || !camera->adt->action) act = verify_adt_action((ID*)&camera->id, 1);
-                                       else act = camera->adt->action;
+               else act = camera->adt->action;
 
                ListBase *AnimCurves = &(act->curves);
                const COLLADAFW::InstanceCameraPointerArray& nodeCameras= node->getInstanceCameras();
@@ -927,97 +927,226 @@ void AnimationImporter::translate_Animations ( COLLADAFW::Node * node ,
                for (unsigned int i = 0; i < nodeCameras.getCount(); i++) {
                        const COLLADAFW::Camera *camera = (COLLADAFW::Camera *) FW_object_map[nodeCameras[i]->getInstanciatedObjectId()];
 
-                       if ((animType->camera & CAMERA_XFOV) != 0 )
-                       {
+                       if ((animType->camera & CAMERA_XFOV) != 0 ) {
                                const COLLADAFW::AnimatableFloat *xfov =  &(camera->getXFov());
                                const COLLADAFW::UniqueId& listid = xfov->getAnimationList();
-                               Assign_float_animations( listid ,AnimCurves, "lens"); 
+                               Assign_float_animations( listid, AnimCurves, "lens");
                        }
 
-                       else if ((animType->camera & CAMERA_XMAG) != 0 )
-                       {
+                       else if ((animType->camera & CAMERA_XMAG) != 0 ) {
                                const COLLADAFW::AnimatableFloat *xmag =  &(camera->getXMag());
                                const COLLADAFW::UniqueId& listid = xmag->getAnimationList();
-                               Assign_float_animations( listid ,AnimCurves, "ortho_scale"); 
+                               Assign_float_animations( listid, AnimCurves, "ortho_scale");
                        }
 
-                       if ((animType->camera & CAMERA_ZFAR) != 0 )
-                       {
+                       if ((animType->camera & CAMERA_ZFAR) != 0 ) {
                                const COLLADAFW::AnimatableFloat *zfar =  &(camera->getFarClippingPlane());
                                const COLLADAFW::UniqueId& listid = zfar->getAnimationList();
-                               Assign_float_animations( listid ,AnimCurves, "clip_end"); 
+                               Assign_float_animations( listid, AnimCurves, "clip_end");
                        }
 
-                       if ((animType->camera & CAMERA_ZNEAR) != 0 )
-                       {
+                       if ((animType->camera & CAMERA_ZNEAR) != 0 ) {
                                const COLLADAFW::AnimatableFloat *znear =  &(camera->getNearClippingPlane());
                                const COLLADAFW::UniqueId& listid = znear->getAnimationList();
-                               Assign_float_animations( listid ,AnimCurves, "clip_start"); 
+                               Assign_float_animations( listid, AnimCurves, "clip_start");
                        }
 
                }
        }
-       if ( animType->material != 0){
-                Material *ma = give_current_material(ob, 1);
-                if (!ma->adt || !ma->adt->action) act = verify_adt_action((ID*)&ma->id, 1);
-                               else act = ma->adt->action;
+       if ( animType->material != 0) {
+               Material *ma = give_current_material(ob, 1);
+               if (!ma->adt || !ma->adt->action) act = verify_adt_action((ID*)&ma->id, 1);
+               else act = ma->adt->action;
 
                ListBase *AnimCurves = &(act->curves);
-               
+
                const COLLADAFW::InstanceGeometryPointerArray& nodeGeoms = node->getInstanceGeometries();
                for (unsigned int i = 0; i < nodeGeoms.getCount(); i++) {
                        const COLLADAFW::MaterialBindingArray& matBinds = nodeGeoms[i]->getMaterialBindings();
                        for (unsigned int j = 0; j < matBinds.getCount(); j++) {
                                const COLLADAFW::UniqueId & matuid = matBinds[j].getReferencedMaterial();
                                const COLLADAFW::Effect *ef = (COLLADAFW::Effect *) (FW_object_map[matuid]);
-                               const COLLADAFW::CommonEffectPointerArray& commonEffects  =  ef->getCommonEffects();
-                               COLLADAFW::EffectCommon *efc = commonEffects[0];
-                               if((animType->material & MATERIAL_SHININESS) != 0){
-                                       const COLLADAFW::FloatOrParam *shin = &(efc->getShininess());
-                                       const COLLADAFW::UniqueId& listid =  shin->getAnimationList();
-                                       Assign_float_animations( listid, AnimCurves , "specular_hardness" );
-                               }
+                               if (ef != NULL) { /* can be NULL [#28909] */
+                                       const COLLADAFW::CommonEffectPointerArray& commonEffects  =  ef->getCommonEffects();
+                                       COLLADAFW::EffectCommon *efc = commonEffects[0];
+                                       if ((animType->material & MATERIAL_SHININESS) != 0) {
+                                               const COLLADAFW::FloatOrParam *shin = &(efc->getShininess());
+                                               const COLLADAFW::UniqueId& listid =  shin->getAnimationList();
+                                               Assign_float_animations( listid, AnimCurves, "specular_hardness" );
+                                       }
 
-                               if((animType->material & MATERIAL_IOR) != 0){
-                                       const COLLADAFW::FloatOrParam *ior = &(efc->getIndexOfRefraction());
-                                       const COLLADAFW::UniqueId& listid =  ior->getAnimationList();
-                                       Assign_float_animations( listid, AnimCurves , "raytrace_transparency.ior" );
-                               }
+                                       if ((animType->material & MATERIAL_IOR) != 0) {
+                                               const COLLADAFW::FloatOrParam *ior = &(efc->getIndexOfRefraction());
+                                               const COLLADAFW::UniqueId& listid =  ior->getAnimationList();
+                                               Assign_float_animations( listid, AnimCurves, "raytrace_transparency.ior" );
+                                       }
 
-                               if((animType->material & MATERIAL_SPEC_COLOR) != 0){
-                                       const COLLADAFW::ColorOrTexture *cot = &(efc->getSpecular());
-                                       const COLLADAFW::UniqueId& listid =  cot->getColor().getAnimationList();
-                                       Assign_color_animations( listid, AnimCurves , "specular_color" );
-                               }
-                               
-                               if((animType->material & MATERIAL_DIFF_COLOR) != 0){
-                                       const COLLADAFW::ColorOrTexture *cot = &(efc->getDiffuse());
-                                       const COLLADAFW::UniqueId& listid =  cot->getColor().getAnimationList();
-                                       Assign_color_animations( listid, AnimCurves , "diffuse_color" );
+                                       if ((animType->material & MATERIAL_SPEC_COLOR) != 0) {
+                                               const COLLADAFW::ColorOrTexture *cot = &(efc->getSpecular());
+                                               const COLLADAFW::UniqueId& listid =  cot->getColor().getAnimationList();
+                                               Assign_color_animations( listid, AnimCurves, "specular_color" );
+                                       }
+
+                                       if ((animType->material & MATERIAL_DIFF_COLOR) != 0) {
+                                               const COLLADAFW::ColorOrTexture *cot = &(efc->getDiffuse());
+                                               const COLLADAFW::UniqueId& listid =  cot->getColor().getAnimationList();
+                                               Assign_color_animations( listid, AnimCurves, "diffuse_color" );
+                                       }
                                }
                        }
                }       
        }
 }
 
+void AnimationImporter::add_bone_animation_sampled(Object * ob, std::vector<FCurve*>& animcurves, COLLADAFW::Node* root, COLLADAFW::Node* node, COLLADAFW::Transformation * tm)
+{
+       const char *bone_name = bc_get_joint_name(node);
+       char joint_path[200];
+       armature_importer->get_rna_path_for_joint(node, joint_path, sizeof(joint_path));
+
+       std::vector<float> frames;
+       find_frames(&frames, &animcurves);
+
+       // convert degrees to radians
+       if (tm->getTransformationType() == COLLADAFW::Transformation::ROTATE) {
+
+               std::vector<FCurve*>::iterator iter;
+               for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
+                       FCurve* fcu = *iter;
+
+                       fcurve_deg_to_rad(fcu);          
+               }                                       
+       }
+
+
+       float irest_dae[4][4];
+       float rest[4][4], irest[4][4];
+
+       get_joint_rest_mat(irest_dae, root, node);
+       invert_m4(irest_dae);
+
+       Bone *bone = get_named_bone((bArmature*)ob->data, bone_name);
+       if (!bone) {
+               fprintf(stderr, "cannot find bone \"%s\"\n", bone_name);
+               return;
+       }
+
+       unit_m4(rest);
+       copy_m4_m4(rest, bone->arm_mat);
+       invert_m4_m4(irest, rest);
+
+       // new curves to assign matrix transform animation
+       FCurve *newcu[10]; // if tm_type is matrix, then create 10 curves: 4 rot, 3 loc, 3 scale
+       unsigned int totcu = 10;
+       const char *tm_str = NULL;
+       char rna_path[200];
+       for (int i = 0; i < totcu; i++) {
+
+               int axis = i;
+
+               if (i < 4) {
+                       tm_str = "rotation_quaternion";
+                       axis = i;
+               }
+               else if (i < 7) {
+                       tm_str = "location";
+                       axis = i - 4;
+               }
+               else {
+                       tm_str = "scale";
+                       axis = i - 7;
+               }
+
+
+               BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, tm_str);
+
+               newcu[i] = create_fcurve(axis, rna_path);
+               newcu[i]->totvert = frames.size();
+       }
+
+       if (frames.size() == 0)
+               return;
+
+       std::sort(frames.begin(), frames.end());
+
+       std::vector<float>::iterator it;
+
+       // sample values at each frame
+       for (it = frames.begin(); it != frames.end(); it++) {
+               float fra = *it;
+
+               float mat[4][4];
+               float matfra[4][4];
+
+               unit_m4(matfra);
+
+               // calc object-space mat
+               evaluate_transform_at_frame(matfra, node, fra);
+
+
+               // for joints, we need a special matrix
+               // special matrix: iR * M * iR_dae * R
+               // where R, iR are bone rest and inverse rest mats in world space (Blender bones),
+               // iR_dae is joint inverse rest matrix (DAE) and M is an evaluated joint world-space matrix (DAE)
+               float temp[4][4], par[4][4];
+
+
+               // calc M
+               calc_joint_parent_mat_rest(par, NULL, root, node);
+               mult_m4_m4m4(temp, par, matfra);
+
+               // evaluate_joint_world_transform_at_frame(temp, NULL,, node, fra);
+
+               // calc special matrix
+               mul_serie_m4(mat, irest, temp, irest_dae, rest, NULL, NULL, NULL, NULL);
+
+               float  rot[4], loc[3], scale[3];
+
+               mat4_to_quat(rot, mat);
+               copy_v3_v3(loc, mat[3]);
+               mat4_to_size(scale, mat);
+
+               // add keys
+               for (int i = 0; i < totcu; i++) {
+                       if (i < 4)
+                               add_bezt(newcu[i], fra, rot[i]);
+                       else if (i < 7)
+                               add_bezt(newcu[i], fra, loc[i - 4]);
+                       else
+                               add_bezt(newcu[i], fra, scale[i - 7]);
+               }
+       }
+       verify_adt_action((ID*)&ob->id, 1);
+
+       // add curves
+       for (int i= 0; i < totcu; i++) {
+               add_bone_fcurve(ob, node, newcu[i]);
+       }
+
+       bPoseChannel *chan = get_pose_channel(ob->pose, bone_name);
+       chan->rotmode = ROT_MODE_QUAT;
+
+}
+
 
 //Check if object is animated by checking if animlist_map holds the animlist_id of node transforms
-AnimationImporter::AnimMix* AnimationImporter::get_animation_type ( const COLLADAFW::Node * node , 
+AnimationImporter::AnimMix* AnimationImporter::get_animation_type ( const COLLADAFW::Node * node,
                                                                                        std::map<COLLADAFW::UniqueId, const COLLADAFW::Object*> FW_object_map) 
 {
        AnimMix *types = new AnimMix();
-       
+
        const COLLADAFW::TransformationPointerArray& nodeTransforms = node->getTransformations();
-       
+
        //for each transformation in node 
        for (unsigned int i = 0; i < nodeTransforms.getCount(); i++) {
                COLLADAFW::Transformation *transform = nodeTransforms[i];
                const COLLADAFW::UniqueId& listid = transform->getAnimationList();
-               
-               //check if transformation has animations    
-               if (animlist_map.find(listid) == animlist_map.end()) continue ;
-               else 
-               {
+
+               //check if transformation has animations
+               if (animlist_map.find(listid) == animlist_map.end()) {
+                       continue;
+               }
+               else {
                        types->transform = types->transform|NODE_TRANSFORM;
                        break;
                }
@@ -1026,28 +1155,26 @@ AnimationImporter::AnimMix* AnimationImporter::get_animation_type ( const COLLAD
 
        for (unsigned int i = 0; i < nodeLights.getCount(); i++) {
                const COLLADAFW::Light *light = (COLLADAFW::Light *) FW_object_map[nodeLights[i]->getInstanciatedObjectId()];
-               types->light = setAnimType(&(light->getColor()),(types->light), LIGHT_COLOR);
-               types->light = setAnimType(&(light->getFallOffAngle()),(types->light), LIGHT_FOA);
-               types->light = setAnimType(&(light->getFallOffExponent()),(types->light), LIGHT_FOE);
-               
+               types->light = setAnimType(&(light->getColor()), (types->light), LIGHT_COLOR);
+               types->light = setAnimType(&(light->getFallOffAngle()), (types->light), LIGHT_FOA);
+               types->light = setAnimType(&(light->getFallOffExponent()), (types->light), LIGHT_FOE);
+
                if ( types->light != 0) break;
-               
+
        }
 
        const COLLADAFW::InstanceCameraPointerArray& nodeCameras = node->getInstanceCameras();
        for (unsigned int i = 0; i < nodeCameras.getCount(); i++) {
                const COLLADAFW::Camera *camera = (COLLADAFW::Camera *) FW_object_map[nodeCameras[i]->getInstanciatedObjectId()];
 
-               if ( camera->getCameraType() == COLLADAFW::Camera::PERSPECTIVE )
-               {
-                   types->camera = setAnimType(&(camera->getXMag()),(types->camera), CAMERA_XFOV);
+               if ( camera->getCameraType() == COLLADAFW::Camera::PERSPECTIVE ) {
+                       types->camera = setAnimType(&(camera->getXMag()), (types->camera), CAMERA_XFOV);
                }
-               else 
-               {
-                       types->camera = setAnimType(&(camera->getXMag()),(types->camera), CAMERA_XMAG);
+               else {
+                       types->camera = setAnimType(&(camera->getXMag()), (types->camera), CAMERA_XMAG);
                }
-               types->camera = setAnimType(&(camera->getFarClippingPlane()),(types->camera), CAMERA_ZFAR);
-               types->camera = setAnimType(&(camera->getNearClippingPlane()),(types->camera), CAMERA_ZNEAR);
+               types->camera = setAnimType(&(camera->getFarClippingPlane()), (types->camera), CAMERA_ZFAR);
+               types->camera = setAnimType(&(camera->getNearClippingPlane()), (types->camera), CAMERA_ZNEAR);
 
                if ( types->camera != 0) break;
 
@@ -1059,28 +1186,32 @@ AnimationImporter::AnimMix* AnimationImporter::get_animation_type ( const COLLAD
                for (unsigned int j = 0; j < matBinds.getCount(); j++) {
                        const COLLADAFW::UniqueId & matuid = matBinds[j].getReferencedMaterial();
                        const COLLADAFW::Effect *ef = (COLLADAFW::Effect *) (FW_object_map[matuid]);
-                       const COLLADAFW::CommonEffectPointerArray& commonEffects  =  ef->getCommonEffects();
-                       COLLADAFW::EffectCommon *efc = commonEffects[0];
-                       types->material =  setAnimType(&(efc->getShininess()),(types->material), MATERIAL_SHININESS);
-                       types->material =  setAnimType(&(efc->getSpecular().getColor()),(types->material), MATERIAL_SPEC_COLOR);
-                       types->material =  setAnimType(&(efc->getDiffuse().getColor()),(types->material), MATERIAL_DIFF_COLOR);
-                  // types->material =  setAnimType(&(efc->get()),(types->material), MATERIAL_TRANSPARENCY);
-                       types->material =  setAnimType(&(efc->getIndexOfRefraction()),(types->material), MATERIAL_IOR);
+                       if (ef != NULL) { /* can be NULL [#28909] */
+                               const COLLADAFW::CommonEffectPointerArray& commonEffects = ef->getCommonEffects();
+                               if (!commonEffects.empty()) {
+                                       COLLADAFW::EffectCommon *efc = commonEffects[0];
+                                       types->material =  setAnimType(&(efc->getShininess()), (types->material), MATERIAL_SHININESS);
+                                       types->material =  setAnimType(&(efc->getSpecular().getColor()), (types->material), MATERIAL_SPEC_COLOR);
+                                       types->material =  setAnimType(&(efc->getDiffuse().getColor()), (types->material), MATERIAL_DIFF_COLOR);
+                                       // types->material =  setAnimType(&(efc->get()), (types->material), MATERIAL_TRANSPARENCY);
+                                       types->material =  setAnimType(&(efc->getIndexOfRefraction()), (types->material), MATERIAL_IOR);
+                               }
+                       }
                }
        }
        return types;
 }
 
-int AnimationImporter::setAnimType ( const COLLADAFW::Animatable * prop , int types, int addition)
+int AnimationImporter::setAnimType ( const COLLADAFW::Animatable * prop, int types, int addition)
 {
-               const COLLADAFW::UniqueId& listid =  prop->getAnimationList();
-               if (animlist_map.find(listid) != animlist_map.end()) 
-                               return types|addition;
-               else return types;
+       const COLLADAFW::UniqueId& listid =  prop->getAnimationList();
+       if (animlist_map.find(listid) != animlist_map.end())
+               return types|addition;
+       else return types;
 }              
 
 // Is not used anymore.
-void AnimationImporter::find_frames_old(std::vector<float> * frames, COLLADAFW::Node * node , COLLADAFW::Transformation::TransformationType tm_type)
+void AnimationImporter::find_frames_old(std::vector<float> * frames, COLLADAFW::Node * node, COLLADAFW::Transformation::TransformationType tm_type)
 {
        bool is_matrix = tm_type == COLLADAFW::Transformation::MATRIX;
        bool is_rotation = tm_type == COLLADAFW::Transformation::ROTATE;
@@ -1102,7 +1233,7 @@ void AnimationImporter::find_frames_old(std::vector<float> * frames, COLLADAFW::
                                
                                const COLLADAFW::AnimationList *animlist = animlist_map[listid];
                                const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
-                
+
                                if (bindings.getCount()) {
                                        //for each AnimationBinding get the fcurves which animate the transform
                                        for (unsigned int j = 0; j < bindings.getCount(); j++) {
@@ -1114,7 +1245,7 @@ void AnimationImporter::find_frames_old(std::vector<float> * frames, COLLADAFW::
 
                                                        for (iter = curves.begin(); iter != curves.end(); iter++) {
                                                                FCurve *fcu = *iter;
-                                
+
                                                                //if transform is rotation the fcurves values must be turned in to radian.
                                                                if (is_rotation)
                                                                        fcurve_deg_to_rad(fcu);
@@ -1165,7 +1296,7 @@ Object *AnimationImporter::translate_animation_OLD(COLLADAFW::Node *node,
        // frames at which to sample
        std::vector<float> frames;
        
-       find_frames_old(&frames, node , tm_type);
+       find_frames_old(&frames, node, tm_type);
        
        unsigned int i;
        
@@ -1248,7 +1379,7 @@ Object *AnimationImporter::translate_animation_OLD(COLLADAFW::Node *node,
                if (is_joint)
                        BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, tm_str);
                else
-                       strcpy(rna_path, tm_str);
+                       BLI_strncpy(rna_path, tm_str, sizeof(rna_path));
                newcu[i] = create_fcurve(axis, rna_path);
 
 #ifdef ARMATURE_TEST
@@ -1280,9 +1411,9 @@ Object *AnimationImporter::translate_animation_OLD(COLLADAFW::Node *node,
 
                        // calc M
                        calc_joint_parent_mat_rest(par, NULL, root, node);
-                       mul_m4_m4m4(temp, matfra, par);
+                       mult_m4_m4m4(temp, par, matfra);
 
-                       // evaluate_joint_world_transform_at_frame(temp, NULL, , node, fra);
+                       // evaluate_joint_world_transform_at_frame(temp, NULL,, node, fra);
 
                        // calc special matrix
                        mul_serie_m4(mat, irest, temp, irest_dae, rest, NULL, NULL, NULL, NULL);
@@ -1410,12 +1541,10 @@ void AnimationImporter::evaluate_transform_at_frame(float mat[4][4], COLLADAFW::
                float m[4][4];
 
                unit_m4(m);
-               if ( type != COLLADAFW::Transformation::MATRIX )
-                       continue;
 
                std::string nodename = node->getName().size() ? node->getName() : node->getOriginalId();
                if (!evaluate_animation(tm, m, fra, nodename.c_str())) {
-                       /*switch (type) {
+                       switch (type) {
                        case COLLADAFW::Transformation::ROTATE:
                                dae_rotate_to_mat4(tm, m);
                                break;
@@ -1430,15 +1559,15 @@ void AnimationImporter::evaluate_transform_at_frame(float mat[4][4], COLLADAFW::
                                break;
                        default:
                                fprintf(stderr, "unsupported transformation type %d\n", type);
-                       }*/
-                       dae_matrix_to_mat4(tm, m);
+                       }
+                       // dae_matrix_to_mat4(tm, m);
                        
                }
 
                float temp[4][4];
                copy_m4_m4(temp, mat);
 
-               mul_m4_m4m4(mat, m, temp);
+               mult_m4_m4m4(mat, temp, m);
        }
 }
 
@@ -1449,9 +1578,9 @@ bool AnimationImporter::evaluate_animation(COLLADAFW::Transformation *tm, float
        COLLADAFW::Transformation::TransformationType type = tm->getTransformationType();
 
        if (type != COLLADAFW::Transformation::ROTATE &&
-           type != COLLADAFW::Transformation::SCALE &&
-           type != COLLADAFW::Transformation::TRANSLATE &&
-           type != COLLADAFW::Transformation::MATRIX) {
+               type != COLLADAFW::Transformation::SCALE &&
+               type != COLLADAFW::Transformation::TRANSLATE &&
+               type != COLLADAFW::Transformation::MATRIX) {
                fprintf(stderr, "animation of transformation %d is not supported yet\n", type);
                return false;
        }
@@ -1514,7 +1643,8 @@ bool AnimationImporter::evaluate_animation(COLLADAFW::Transformation *tm, float
                                }
 
                                COLLADABU::Math::Vector3& axis = ((COLLADAFW::Rotate*)tm)->getRotationAxis();
-                               float ax[3] = {axis[0], axis[1], axis[2]};
+
+                               float ax[3] = {(float)axis[0], (float)axis[1], (float)axis[2]};
                                float angle = evaluate_fcurve(curves[0], fra);
                                axis_angle_to_mat4(mat, ax, angle);
 
@@ -1573,7 +1703,7 @@ bool AnimationImporter::evaluate_animation(COLLADAFW::Transformation *tm, float
 
                                COLLADAFW::Matrix tm(matrix);
                                dae_matrix_to_mat4(&tm, mat);
-                
+
                                std::vector<FCurve*>::iterator it;
 
                                return true;
@@ -1601,7 +1731,7 @@ void AnimationImporter::get_joint_rest_mat(float mat[4][4], COLLADAFW::Node *roo
 
                calc_joint_parent_mat_rest(par, NULL, root, node);
                get_node_mat(m, node, NULL, NULL);
-               mul_m4_m4m4(mat, m, par);
+               mult_m4_m4m4(mat, par, m);
        }
 }
 
@@ -1620,7 +1750,7 @@ bool AnimationImporter::calc_joint_parent_mat_rest(float mat[4][4], float par[4]
                if (par) {
                        float temp[4][4];
                        get_node_mat(temp, node, NULL, NULL);
-                       mul_m4_m4m4(m, temp, par);
+                       mult_m4_m4m4(m, par, temp);
                }
                else {
                        get_node_mat(m, node, NULL, NULL);
@@ -1640,9 +1770,7 @@ bool AnimationImporter::calc_joint_parent_mat_rest(float mat[4][4], float par[4]
 Object *AnimationImporter::get_joint_object(COLLADAFW::Node *root, COLLADAFW::Node *node, Object *par_job)
 {
        if (joint_objects.find(node->getUniqueId()) == joint_objects.end()) {
-               Object *job = add_object(scene, OB_EMPTY);
-
-               rename_id((ID*)&job->id, (char*)get_joint_name(node));
+               Object *job = bc_add_object(scene, OB_EMPTY, (char*)get_joint_name(node));
 
                job->lay = object_in_scene(job, scene)->lay = 2;
 
@@ -1660,7 +1788,7 @@ Object *AnimationImporter::get_joint_object(COLLADAFW::Node *root, COLLADAFW::No
                        float temp[4][4], ipar[4][4];
                        invert_m4_m4(ipar, par_job->obmat);
                        copy_m4_m4(temp, mat);
-                       mul_m4_m4m4(mat, temp, ipar);
+                       mult_m4_m4m4(mat, ipar, temp);
                }
 
                TransformBase::decompose(mat, job->loc, NULL, job->quat, job->size);
@@ -1672,7 +1800,7 @@ Object *AnimationImporter::get_joint_object(COLLADAFW::Node *root, COLLADAFW::No
                        job->parsubstr[0] = 0;
                }
 
-               where_is_object(scene, job);
+               BKE_object_where_is_calc(scene, job);
 
                // after parenting and layer change
                DAG_scene_sort(CTX_data_main(C), scene);
@@ -1693,7 +1821,7 @@ bool AnimationImporter::evaluate_joint_world_transform_at_frame(float mat[4][4],
        if (par) {
                float temp[4][4];
                evaluate_transform_at_frame(temp, node, node == end ? fra : 0.0f);
-               mul_m4_m4m4(m, temp, par);
+               mult_m4_m4m4(m, par, temp);
        }
        else {
                evaluate_transform_at_frame(m, node, node == end ? fra : 0.0f);
@@ -1744,7 +1872,7 @@ void AnimationImporter::add_bezt(FCurve *fcu, float fra, float value)
        //float fps = (float)FPS;
        BezTriple bez;
        memset(&bez, 0, sizeof(BezTriple));
-       bez.vec[1][0] = fra ;
+       bez.vec[1][0] = fra;
        bez.vec[1][1] = value;
        bez.ipo = BEZT_IPO_LIN ;/* use default interpolation mode here... */
        bez.f1 = bez.f2 = bez.f3 = SELECT;