COLLADA: #29058 Fixed crash when illegal reference to non existing camera object...
[blender.git] / source / blender / collada / AnimationImporter.cpp
index 29bd0bd93b7b6b66a92758954c3cb9b828811112..af6d70ecca0858be51f369bd1a5fc6dd1576f89b 100644 (file)
@@ -1,6 +1,4 @@
 /*
- * $Id$
- *
  * ***** BEGIN GPL LICENSE BLOCK *****
  *
  * This program is free software; you can redistribute it and/or
@@ -64,8 +62,8 @@ static const char *bc_get_joint_name(T *node)
 
 FCurve *AnimationImporter::create_fcurve(int array_index, const char *rna_path)
 {
-       FCurve *fcu = (FCurve*)MEM_callocN(sizeof(FCurve), "FCurve");
-       fcu->flag = (FCURVE_VISIBLE|FCURVE_AUTO_HANDLES|FCURVE_SELECTED);
+       FCurve *fcu = (FCurve *)MEM_callocN(sizeof(FCurve), "FCurve");
+       fcu->flag = (FCURVE_VISIBLE | FCURVE_AUTO_HANDLES | FCURVE_SELECTED);
        fcu->rna_path = BLI_strdupn(rna_path, strlen(rna_path));
        fcu->array_index = array_index;
        return fcu;
@@ -89,71 +87,64 @@ void AnimationImporter::animation_to_fcurves(COLLADAFW::AnimationCurve *curve)
 {
        COLLADAFW::FloatOrDoubleArray& input = curve->getInputValues();
        COLLADAFW::FloatOrDoubleArray& output = curve->getOutputValues();
-    
-       if( curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER ||
-               curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_STEP ) {
-       COLLADAFW::FloatOrDoubleArray& intan = curve->getInTangentValues();
-    COLLADAFW::FloatOrDoubleArray& outtan = curve->getOutTangentValues();
-       }
 
        float fps = (float)FPS;
        size_t dim = curve->getOutDimension();
        unsigned int i;
-       
-       std::vector<FCurve*>& fcurves = curve_map[curve->getUniqueId()];
+
+       std::vector<FCurve *>& fcurves = curve_map[curve->getUniqueId()];
 
        switch (dim) {
-       case 1: // X, Y, Z or angle
-       case 3: // XYZ
-       case 4:
-       case 16: // matrix
+               case 1: // X, Y, Z or angle
+               case 3: // XYZ
+               case 4:
+               case 16: // matrix
                {
-                       for (i = 0; i < dim; i++ ) {
-                               FCurve *fcu = (FCurve*)MEM_callocN(sizeof(FCurve), "FCurve");
-                       
-                               fcu->flag = (FCURVE_VISIBLE|FCURVE_AUTO_HANDLES|FCURVE_SELECTED);
+                       for (i = 0; i < dim; i++) {
+                               FCurve *fcu = (FCurve *)MEM_callocN(sizeof(FCurve), "FCurve");
+
+                               fcu->flag = (FCURVE_VISIBLE | FCURVE_AUTO_HANDLES | FCURVE_SELECTED);
                                // fcu->rna_path = BLI_strdupn(path, strlen(path));
                                fcu->array_index = 0;
                                fcu->totvert = curve->getKeyCount();
-                       
+
                                // create beztriple for each key
                                for (unsigned int j = 0; j < curve->getKeyCount(); j++) {
                                        BezTriple bez;
                                        memset(&bez, 0, sizeof(BezTriple));
 
-                                       
+
                                        // input, output
                                        bez.vec[1][0] = bc_get_float_value(input, j) * fps; 
                                        bez.vec[1][1] = bc_get_float_value(output, j * dim + i);
 
 
-                                       ifcurve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER ||
-                                               curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_STEP) 
+                                       if (curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER ||
+                                           curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_STEP)
                                        {
                                                COLLADAFW::FloatOrDoubleArray& intan = curve->getInTangentValues();
-                        COLLADAFW::FloatOrDoubleArray& outtan = curve->getOutTangentValues();
+                                               COLLADAFW::FloatOrDoubleArray& outtan = curve->getOutTangentValues();
 
                                                // intangent
-                                                bez.vec[0][0] = bc_get_float_value(intan, (j * 2 * dim ) + (2 * i)) * fps;
-                                                bez.vec[0][1] = bc_get_float_value(intan, (j * 2 * dim )+ (2 * i) + 1);
+                                               bez.vec[0][0] = bc_get_float_value(intan, (j * 2 * dim) + (2 * i)) * fps;
+                                               bez.vec[0][1] = bc_get_float_value(intan, (j * 2 * dim) + (2 * i) + 1);
 
-                                                // outtangent
-                                                bez.vec[2][0] = bc_get_float_value(outtan, (j * 2 * dim ) + (2 * i)) * fps;
-                                                bez.vec[2][1] = bc_get_float_value(outtan, (j * 2 * dim )+ (2 * i) + 1);
-                                                if(curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER) 
+                                               // outtangent
+                                               bez.vec[2][0] = bc_get_float_value(outtan, (j * 2 * dim) + (2 * i)) * fps;
+                                               bez.vec[2][1] = bc_get_float_value(outtan, (j * 2 * dim) + (2 * i) + 1);
+                                               if (curve->getInterpolationType() == COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER) 
                                                        bez.ipo = BEZT_IPO_BEZ;
-                                                else 
-                                                        bez.ipo = BEZT_IPO_CONST;
-                                                //bez.h1 = bez.h2 = HD_AUTO;   
+                                               else 
+                                                       bez.ipo = BEZT_IPO_CONST;
+                                               //bez.h1 = bez.h2 = HD_AUTO;    
                                        }
-                                       else 
-                                       {
+                                       else {
                                                bez.h1 = bez.h2 = HD_AUTO; 
                                                bez.ipo = BEZT_IPO_LIN;
                                        }
                                        // bez.ipo = U.ipo_new; /* use default interpolation mode here... */
                                        bez.f1 = bez.f2 = bez.f3 = SELECT;
-                                       
+
                                        insert_bezt_fcurve(fcu, &bez, 0);
                                }
 
@@ -163,11 +154,11 @@ void AnimationImporter::animation_to_fcurves(COLLADAFW::AnimationCurve *curve)
                        }
                }
                break;
-       default:
-               fprintf(stderr, "Output dimension of %d is not yet supported (animation id = %s)\n", (int)dim, curve->getOriginalId().c_str());
+               default:
+                       fprintf(stderr, "Output dimension of %d is not yet supported (animation id = %s)\n", (int)dim, curve->getOriginalId().c_str());
        }
 
-       for (std::vector<FCurve*>::iterator it = fcurves.begin(); it != fcurves.end(); it++)
+       for (std::vector<FCurve *>::iterator it = fcurves.begin(); it != fcurves.end(); it++)
                unused_curves.push_back(*it);
 }
 
@@ -176,21 +167,21 @@ void AnimationImporter::fcurve_deg_to_rad(FCurve *cu)
 {
        for (unsigned int i = 0; i < cu->totvert; i++) {
                // TODO convert handles too
-               cu->bezt[i].vec[1][1] *= M_PI / 180.0f;
-               cu->bezt[i].vec[0][1] *= M_PI / 180.0f;
-               cu->bezt[i].vec[2][1] *= M_PI / 180.0f;
-               cu->bezt[i].vec[1][0];
+               cu->bezt[i].vec[1][1] *= DEG2RADF(1.0f);
+               cu->bezt[i].vec[0][1] *= DEG2RADF(1.0f);
+               cu->bezt[i].vec[2][1] *= DEG2RADF(1.0f);
        }
 }
 
-void AnimationImporter::add_fcurves_to_object(Object *ob, std::vector<FCurve*>& curves, char *rna_path, int array_index, Animation *animated)
+
+void AnimationImporter::add_fcurves_to_object(Object *ob, std::vector<FCurve *>& curves, char *rna_path, int array_index, Animation *animated)
 {
        bAction *act;
        
-       if (!ob->adt || !ob->adt->action) act = verify_adt_action((ID*)&ob->id, 1);
+       if (!ob->adt || !ob->adt->action) act = verify_adt_action((ID *)&ob->id, 1);
        else act = ob->adt->action;
        
-       std::vector<FCurve*>::iterator it;
+       std::vector<FCurve *>::iterator it;
        int i;
 
 #if 0
@@ -215,12 +206,12 @@ void AnimationImporter::add_fcurves_to_object(Object *ob, std::vector<FCurve*>&
                        
                        if (bone_name) {
                                /* try to find group */
-                               grp = action_groups_find_named(act, bone_name);
+                               grp = BKE_action_group_find_name(act, bone_name);
                                
                                /* no matching groups, so add one */
                                if (grp == NULL) {
                                        /* Add a new group, and make it active */
-                                       grp = (bActionGroup*)MEM_callocN(sizeof(bActionGroup), "bActionGroup");
+                                       grp = (bActionGroup *)MEM_callocN(sizeof(bActionGroup), "bActionGroup");
                                        
                                        grp->flag = AGRP_SELECTED;
                                        BLI_strncpy(grp->name, bone_name, sizeof(grp->name));
@@ -249,27 +240,28 @@ void AnimationImporter::add_fcurves_to_object(Object *ob, std::vector<FCurve*>&
 }
 
 AnimationImporter::AnimationImporter(UnitConverter *conv, ArmatureImporter *arm, Scene *scene) :
-               TransformReader(conv), armature_importer(arm), scene(scene) { }
+       TransformReader(conv), armature_importer(arm), scene(scene) {
+}
 
 AnimationImporter::~AnimationImporter()
 {
        // free unused FCurves
-       for (std::vector<FCurve*>::iterator it = unused_curves.begin(); it != unused_curves.end(); it++)
+       for (std::vector<FCurve *>::iterator it = unused_curves.begin(); it != unused_curves.end(); it++)
                free_fcurve(*it);
 
        if (unused_curves.size())
                fprintf(stderr, "removed %d unused curves\n", (int)unused_curves.size());
 }
 
-bool AnimationImporter::write_animation(const COLLADAFW::Animation* anim) 
+bool AnimationImporter::write_animation(const COLLADAFW::Animation *anim)
 {
        if (anim->getAnimationType() == COLLADAFW::Animation::ANIMATION_CURVE) {
-               COLLADAFW::AnimationCurve *curve = (COLLADAFW::AnimationCurve*)anim;
+               COLLADAFW::AnimationCurve *curve = (COLLADAFW::AnimationCurve *)anim;
                
                // XXX Don't know if it's necessary
                // Should we check outPhysicalDimension?
                if (curve->getInPhysicalDimension() != COLLADAFW::PHYSICAL_DIMENSION_TIME) {
-                       fprintf(stderr, "Inputs physical dimension is not time. \n");
+                       fprintf(stderr, "Inputs physical dimension is not time.\n");
                        return true;
                }
 
@@ -279,15 +271,15 @@ bool AnimationImporter::write_animation(const COLLADAFW::Animation* anim)
 
                if (interp != COLLADAFW::AnimationCurve::INTERPOLATION_MIXED) {
                        switch (interp) {
-                       case COLLADAFW::AnimationCurve::INTERPOLATION_LINEAR:
-                       case COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER:
-                       case COLLADAFW::AnimationCurve::INTERPOLATION_STEP:
-                               animation_to_fcurves(curve);
-                               break;
-                       default:
-                               // TODO there're also CARDINAL, HERMITE, BSPLINE and STEP types
-                               fprintf(stderr, "CARDINAL, HERMITE and BSPLINE anim interpolation types not supported yet.\n");
-                               break;
+                               case COLLADAFW::AnimationCurve::INTERPOLATION_LINEAR:
+                               case COLLADAFW::AnimationCurve::INTERPOLATION_BEZIER:
+                               case COLLADAFW::AnimationCurve::INTERPOLATION_STEP:
+                                       animation_to_fcurves(curve);
+                                       break;
+                               default:
+                                       // TODO there're also CARDINAL, HERMITE, BSPLINE and STEP types
+                                       fprintf(stderr, "CARDINAL, HERMITE and BSPLINE anim interpolation types not supported yet.\n");
+                                       break;
                        }
                }
                else {
@@ -303,12 +295,12 @@ bool AnimationImporter::write_animation(const COLLADAFW::Animation* anim)
 }
        
 // called on post-process stage after writeVisualScenes
-bool AnimationImporter::write_animation_list(const COLLADAFW::AnimationList* animlist) 
+bool AnimationImporter::write_animation_list(const COLLADAFW::AnimationList *animlist)
 {
        const COLLADAFW::UniqueId& animlist_id = animlist->getUniqueId();
-    
+
        animlist_map[animlist_id] = animlist;
-    
+
 #if 0
 
        // should not happen
@@ -317,123 +309,10 @@ bool AnimationImporter::write_animation_list(const COLLADAFW::AnimationList* ani
        }
 
        // for bones rna_path is like: pose.bones["bone-name"].rotation
-       
-       // what does this AnimationList animate?
-       Animation& animated = uid_animated_map[animlist_id];
-       Object *ob = animated.ob;
-    
-       char rna_path[100];
-       char joint_path[100];
-       bool is_joint = false;
-
-       // if ob is NULL, it should be a JOINT
-       if (!ob) {
-               
-               ob = armature_importer->get_armature_for_joint(animated.node);
-
-               if (!ob) {
-//                     fprintf(stderr, "Cannot find armature for node %s\n", get_joint_name(animated.node));
-                       return true;
-               }
-
-               armature_importer->get_rna_path_for_joint(animated.node, joint_path, sizeof(joint_path));
-
-               is_joint = true;
-       }
-       printf("object for animlist: %s found\n", animlist->getUniqueId().toAscii().c_str());
-       const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
-
-       switch (animated.tm->getTransformationType()) {
-       case COLLADAFW::Transformation::TRANSLATE:
-       case COLLADAFW::Transformation::SCALE:
-               {
-                       bool loc = animated.tm->getTransformationType() == COLLADAFW::Transformation::TRANSLATE;
-                       if (is_joint)
-                               BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, loc ? "location" : "scale");
-                       else
-                               BLI_strncpy(rna_path, loc ? "location" : "scale", sizeof(rna_path));
-
-                       for (int i = 0; i < bindings.getCount(); i++) {
-                               const COLLADAFW::AnimationList::AnimationBinding& binding = bindings[i];
-                               COLLADAFW::UniqueId anim_uid = binding.animation;
-
-                               if (curve_map.find(anim_uid) == curve_map.end()) {
-                                       fprintf(stderr, "Cannot find FCurve by animation UID.\n");
-                                       continue;
-                               }
-
-                               std::vector<FCurve*>& fcurves = curve_map[anim_uid];
-                               
-                               switch (binding.animationClass) {
-                               case COLLADAFW::AnimationList::POSITION_X:
-                                       add_fcurves_to_object(ob, fcurves, rna_path, 0, &animated);
-                                       break;
-                               case COLLADAFW::AnimationList::POSITION_Y:
-                                       add_fcurves_to_object(ob, fcurves, rna_path, 1, &animated);
-                                       break;
-                               case COLLADAFW::AnimationList::POSITION_Z:
-                                       add_fcurves_to_object(ob, fcurves, rna_path, 2, &animated);
-                                       break;
-                               case COLLADAFW::AnimationList::POSITION_XYZ:
-                                       add_fcurves_to_object(ob, fcurves, rna_path, -1, &animated);
-                                       break;
-                               default:
-                                       fprintf(stderr, "AnimationClass %d is not supported for %s.\n",
-                                                       binding.animationClass, loc ? "TRANSLATE" : "SCALE");
-                               }
-                       }
-               }
-               break;
-       case COLLADAFW::Transformation::ROTATE:
-               {
-                       if (is_joint)
-                               BLI_snprintf(rna_path, sizeof(rna_path), "%s.rotation_euler", joint_path);
-                       else
-                               BLI_strncpy(rna_path, "rotation_euler", sizeof(rna_path));
-
-                       COLLADAFW::Rotate* rot = (COLLADAFW::Rotate*)animated.tm;
-                       COLLADABU::Math::Vector3& axis = rot->getRotationAxis();
-                       
-                       for (int i = 0; i < bindings.getCount(); i++) {
-                               const COLLADAFW::AnimationList::AnimationBinding& binding = bindings[i];
-                               COLLADAFW::UniqueId anim_uid = binding.animation;
 
-                               if (curve_map.find(anim_uid) == curve_map.end()) {
-                                       fprintf(stderr, "Cannot find FCurve by animation UID.\n");
-                                       continue;
-                               }
-
-                               std::vector<FCurve*>& fcurves = curve_map[anim_uid];
 
-                               switch (binding.animationClass) {
-                               case COLLADAFW::AnimationList::ANGLE:
-                                       if (COLLADABU::Math::Vector3::UNIT_X == axis) {
-                                               add_fcurves_to_object(ob, fcurves, rna_path, 0, &animated);
-                                       }
-                                       else if (COLLADABU::Math::Vector3::UNIT_Y == axis) {
-                                               add_fcurves_to_object(ob, fcurves, rna_path, 1, &animated);
-                                       }
-                                       else if (COLLADABU::Math::Vector3::UNIT_Z == axis) {
-                                               add_fcurves_to_object(ob, fcurves, rna_path, 2, &animated);
-                                       }
-                                       break;
-                               case COLLADAFW::AnimationList::AXISANGLE:
-                                       // TODO convert axis-angle to quat? or XYZ?
-                               default:
-                                       fprintf(stderr, "AnimationClass %d is not supported for ROTATE transformation.\n",
-                                                       binding.animationClass);
-                               }
-                       }
-               }
-               break;
-       case COLLADAFW::Transformation::MATRIX:
-       case COLLADAFW::Transformation::SKEW:
-       case COLLADAFW::Transformation::LOOKAT:
-               fprintf(stderr, "Animation of MATRIX, SKEW and LOOKAT transformations is not supported yet.\n");
-               break;
-       }
 #endif
-       
+
        return true;
 }
 
@@ -446,7 +325,7 @@ void AnimationImporter::read_node_transform(COLLADAFW::Node *node, Object *ob)
        TransformReader::get_node_mat(mat, node, &uid_animated_map, ob);
        if (ob) {
                copy_m4_m4(ob->obmat, mat);
-               object_apply_mat4(ob, ob->obmat, 0, 0);
+               BKE_object_apply_mat4(ob, ob->obmat, 0, 0);
        }
 }
 
@@ -456,14 +335,14 @@ virtual void AnimationImporter::change_eul_to_quat(Object *ob, bAction *act)
        bActionGroup *grp;
        int i;
        
-       for (grp = (bActionGroup*)act->groups.first; grp; grp = grp->next) {
+       for (grp = (bActionGroup *)act->groups.first; grp; grp = grp->next) {
 
                FCurve *eulcu[3] = {NULL, NULL, NULL};
                
                if (fcurves_actionGroup_map.find(grp) == fcurves_actionGroup_map.end())
                        continue;
 
-               std::vector<FCurve*> &rot_fcurves = fcurves_actionGroup_map[grp];
+               std::vector<FCurve *> &rot_fcurves = fcurves_actionGroup_map[grp];
                
                if (rot_fcurves.size() > 3) continue;
 
@@ -483,7 +362,7 @@ virtual void AnimationImporter::change_eul_to_quat(Object *ob, bAction *act)
                        create_fcurve(3, rna_path)
                };
 
-               bPoseChannel *chan = get_pose_channel(ob->pose, grp->name);
+               bPoseChannel *chan = BKE_pose_channel_find_name(ob->pose, grp->name);
 
                float m4[4][4], irest[3][3];
                invert_m4_m4(m4, chan->bone->arm_mat);
@@ -509,10 +388,10 @@ virtual void AnimationImporter::change_eul_to_quat(Object *ob, bAction *act)
 
                                /*eul_to_mat3(rot, eul);
 
-                               mul_m3_m3m3(rel, irest, rot);
+                                  mul_m3_m3m3(rel, irest, rot);
 
-                               mat3_to_quat(quat, rel);
-                               */
+                                  mat3_to_quat(quat, rel);
+                                */
 
                                eul_to_quat(quat, eul);
 
@@ -537,7 +416,7 @@ virtual void AnimationImporter::change_eul_to_quat(Object *ob, bAction *act)
        }
 
        bPoseChannel *pchan;
-       for (pchan = (bPoseChannel*)ob->pose->chanbase.first; pchan; pchan = pchan->next) {
+       for (pchan = (bPoseChannel *)ob->pose->chanbase.first; pchan; pchan = pchan->next) {
                pchan->rotmode = ROT_MODE_QUAT;
        }
 }
@@ -545,13 +424,13 @@ virtual void AnimationImporter::change_eul_to_quat(Object *ob, bAction *act)
 
 
 //sets the rna_path and array index to curve
-void AnimationImporter::modify_fcurve(std::vector<FCurve*>* curves , char* rna_path , int array_index )
-{   
-       std::vector<FCurve*>::iterator it;
+void AnimationImporter::modify_fcurve(std::vector<FCurve *> *curves, const char *rna_path, int array_index)
+{
+       std::vector<FCurve *>::iterator it;
        int i;
        for (it = curves->begin(), i = 0; it != curves->end(); it++, i++) {
                FCurve *fcu = *it;
-               fcu->rna_path = BLI_strdupn(rna_path, strlen(rna_path));
+               fcu->rna_path = BLI_strdup(rna_path);
                
                if (array_index == -1) fcu->array_index = i;
                else fcu->array_index = array_index;
@@ -560,208 +439,226 @@ void AnimationImporter::modify_fcurve(std::vector<FCurve*>* curves , char* rna_p
        }
 }
 
-void AnimationImporter::find_frames( std::vector<float>* frames , std::vector<FCurve*>* curves)
+void AnimationImporter::unused_fcurve(std::vector<FCurve *> *curves)
 {
-       std::vector<FCurve*>::iterator iter;
-               for (iter = curves->begin(); iter != curves->end(); iter++) {
-                       FCurve *fcu = *iter;
-        
+       // when an error happens and we can't actually use curve remove it from unused_curves
+       std::vector<FCurve *>::iterator it;
+       for (it = curves->begin(); it != curves->end(); it++) {
+               FCurve *fcu = *it;
+               unused_curves.erase(std::remove(unused_curves.begin(), unused_curves.end(), fcu), unused_curves.end());
+       }
+}
+
+void AnimationImporter::find_frames(std::vector<float> *frames, std::vector<FCurve *> *curves)
+{
+       std::vector<FCurve *>::iterator iter;
+       for (iter = curves->begin(); iter != curves->end(); iter++) {
+               FCurve *fcu = *iter;
+
                for (unsigned int k = 0; k < fcu->totvert; k++) {
                        //get frame value from bezTriple
                        float fra = fcu->bezt[k].vec[1][0];
                        //if frame already not added add frame to frames
                        if (std::find(frames->begin(), frames->end(), fra) == frames->end())
                                frames->push_back(fra);
-                                                       
-               }
+
                }
+       }
 }
 
 //creates the rna_paths and array indices of fcurves from animations using transformation and bound animation class of each animation.
-void AnimationImporter:: Assign_transform_animations(COLLADAFW::Transformation * transform , 
-                                                                                                        const COLLADAFW::AnimationList::AnimationBinding * binding,
-                                                                                                        std::vector<FCurve*>* curves, bool is_joint, char * joint_path)
+void AnimationImporter:: Assign_transform_animations(COLLADAFW::Transformation *transform,
+                                                     const COLLADAFW::AnimationList::AnimationBinding *binding,
+                                                     std::vector<FCurve *> *curves, bool is_joint, char *joint_path)
 {
        COLLADAFW::Transformation::TransformationType tm_type = transform->getTransformationType();
        bool is_matrix = tm_type == COLLADAFW::Transformation::MATRIX;
-       bool is_rotation = tm_type  == COLLADAFW::Transformation::ROTATE;
-       
+       bool is_rotation = tm_type == COLLADAFW::Transformation::ROTATE;
+
        //to check if the no of curves are valid
-       bool xyz = ((tm_type == COLLADAFW::Transformation::TRANSLATE ||tm_type  == COLLADAFW::Transformation::SCALE) && binding->animationClass == COLLADAFW::AnimationList::POSITION_XYZ);
-                        
-       
+       bool xyz = ((tm_type == COLLADAFW::Transformation::TRANSLATE || tm_type == COLLADAFW::Transformation::SCALE) && binding->animationClass == COLLADAFW::AnimationList::POSITION_XYZ);
+
+
        if (!((!xyz && curves->size() == 1) || (xyz && curves->size() == 3) || is_matrix)) {
                fprintf(stderr, "expected %d curves, got %d\n", xyz ? 3 : 1, (int)curves->size());
                return;
        }
-       
+
        char rna_path[100];
-                                                       
+
        switch (tm_type) {
                case COLLADAFW::Transformation::TRANSLATE:
                case COLLADAFW::Transformation::SCALE:
-                       {
-                               bool loc = tm_type == COLLADAFW::Transformation::TRANSLATE;
-                               if (is_joint)
-                                       BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, loc ? "location" : "scale");
-                               else
-                                       BLI_strncpy(rna_path, loc ? "location" : "scale", sizeof(rna_path));
+               {
+                       bool loc = tm_type == COLLADAFW::Transformation::TRANSLATE;
+                       if (is_joint)
+                               BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, loc ? "location" : "scale");
+                       else
+                               BLI_strncpy(rna_path, loc ? "location" : "scale", sizeof(rna_path));
 
-                               switch (binding->animationClass) {
-                                       case COLLADAFW::AnimationList::POSITION_X:
-                                               modify_fcurve(curves, rna_path, 0 );
-                                               break;
-                                       case COLLADAFW::AnimationList::POSITION_Y:
-                                               modify_fcurve(curves, rna_path, 1 );
-                                               break;
-                                       case COLLADAFW::AnimationList::POSITION_Z:
-                                               modify_fcurve(curves, rna_path, 2 );
-                                               break;
-                                       case COLLADAFW::AnimationList::POSITION_XYZ:
-                                               modify_fcurve(curves, rna_path, -1 );
-                                               break;
-                                       default:
-                                               fprintf(stderr, "AnimationClass %d is not supported for %s.\n",
-                                                               binding->animationClass, loc ? "TRANSLATE" : "SCALE");
-                                       }
-               break;
+                       switch (binding->animationClass) {
+                               case COLLADAFW::AnimationList::POSITION_X:
+                                       modify_fcurve(curves, rna_path, 0);
+                                       break;
+                               case COLLADAFW::AnimationList::POSITION_Y:
+                                       modify_fcurve(curves, rna_path, 1);
+                                       break;
+                               case COLLADAFW::AnimationList::POSITION_Z:
+                                       modify_fcurve(curves, rna_path, 2);
+                                       break;
+                               case COLLADAFW::AnimationList::POSITION_XYZ:
+                                       modify_fcurve(curves, rna_path, -1);
+                                       break;
+                               default:
+                                       unused_fcurve(curves);
+                                       fprintf(stderr, "AnimationClass %d is not supported for %s.\n",
+                                               binding->animationClass, loc ? "TRANSLATE" : "SCALE");
                        }
-               
-               
+                       break;
+               }
+
+
                case COLLADAFW::Transformation::ROTATE:
-                       {
-                               if (is_joint)
-                                       BLI_snprintf(rna_path, sizeof(rna_path), "%s.rotation_euler", joint_path);
-                               else
-                                       BLI_strncpy(rna_path, "rotation_euler", sizeof(rna_path));
-                std::vector<FCurve*>::iterator iter;
-                               for (iter = curves->begin(); iter != curves->end(); iter++) {
-                                       FCurve* fcu = *iter;
-                                       
-                                       //if transform is rotation the fcurves values must be turned in to radian.
-                                       if (is_rotation)
-                                               fcurve_deg_to_rad(fcu);          
-                               }                                       
-                               COLLADAFW::Rotate* rot = (COLLADAFW::Rotate*)transform;
-                               COLLADABU::Math::Vector3& axis = rot->getRotationAxis();
-                       
-                               switch (binding->animationClass) {
-                                       case COLLADAFW::AnimationList::ANGLE:
-                                               if (COLLADABU::Math::Vector3::UNIT_X == axis) {
-                                                       modify_fcurve(curves, rna_path, 0 );
-                                               }
-                                               else if (COLLADABU::Math::Vector3::UNIT_Y == axis) {
-                                                       modify_fcurve(curves, rna_path, 1 );
-                                               }
-                                               else if (COLLADABU::Math::Vector3::UNIT_Z == axis) {
-                                                       modify_fcurve(curves, rna_path, 2 );
-                                               }
-                                               break;
-                                       case COLLADAFW::AnimationList::AXISANGLE:
-                                               // TODO convert axis-angle to quat? or XYZ?
-                                       default:
-                                               fprintf(stderr, "AnimationClass %d is not supported for ROTATE transformation.\n",
-                                                               binding->animationClass);
+               {
+                       if (is_joint)
+                               BLI_snprintf(rna_path, sizeof(rna_path), "%s.rotation_euler", joint_path);
+                       else
+                               BLI_strncpy(rna_path, "rotation_euler", sizeof(rna_path));
+                       std::vector<FCurve *>::iterator iter;
+                       for (iter = curves->begin(); iter != curves->end(); iter++) {
+                               FCurve *fcu = *iter;
+
+                               //if transform is rotation the fcurves values must be turned in to radian.
+                               if (is_rotation)
+                                       fcurve_deg_to_rad(fcu);
+                       }
+                       COLLADAFW::Rotate *rot = (COLLADAFW::Rotate *)transform;
+                       COLLADABU::Math::Vector3& axis = rot->getRotationAxis();
+
+                       switch (binding->animationClass) {
+                               case COLLADAFW::AnimationList::ANGLE:
+                                       if (COLLADABU::Math::Vector3::UNIT_X == axis) {
+                                               modify_fcurve(curves, rna_path, 0);
                                        }
-                       break;
+                                       else if (COLLADABU::Math::Vector3::UNIT_Y == axis) {
+                                               modify_fcurve(curves, rna_path, 1);
+                                       }
+                                       else if (COLLADABU::Math::Vector3::UNIT_Z == axis) {
+                                               modify_fcurve(curves, rna_path, 2);
+                                       }
+                                       else
+                                               unused_fcurve(curves);
+                                       break;
+                               case COLLADAFW::AnimationList::AXISANGLE:
+                               // TODO convert axis-angle to quat? or XYZ?
+                               default:
+                                       unused_fcurve(curves);
+                                       fprintf(stderr, "AnimationClass %d is not supported for ROTATE transformation.\n",
+                                               binding->animationClass);
                        }
-                       
+                       break;
+               }
+
                case COLLADAFW::Transformation::MATRIX:
                        /*{
-                               COLLADAFW::Matrix* mat = (COLLADAFW::Matrix*)transform;
-                               COLLADABU::Math::Matrix4 mat4 = mat->getMatrix();
-                               switch (binding->animationClass) {
-                                       case COLLADAFW::AnimationList::TRANSFORM:
-                                       
-                               }
-                       }*/
+                          COLLADAFW::Matrix* mat = (COLLADAFW::Matrix*)transform;
+                          COLLADABU::Math::Matrix4 mat4 = mat->getMatrix();
+                          switch (binding->animationClass) {
+                          case COLLADAFW::AnimationList::TRANSFORM:
+
+                          }
+                          }*/
+                       unused_fcurve(curves);
+                       break;
                case COLLADAFW::Transformation::SKEW:
                case COLLADAFW::Transformation::LOOKAT:
-                       fprintf(stderr, "Animation of MATRIX, SKEW and LOOKAT transformations is not supported yet.\n");
+                       unused_fcurve(curves);
+                       fprintf(stderr, "Animation of SKEW and LOOKAT transformations is not supported yet.\n");
                        break;
-               }
-       
+       }
+
 }
 
-void AnimationImporter:: Assign_color_animations(const COLLADAFW::UniqueId& listid, ListBase *AnimCurves ,char * anim_type)
+//creates the rna_paths and array indices of fcurves from animations using color and bound animation class of each animation.
+void AnimationImporter:: Assign_color_animations(const COLLADAFW::UniqueId& listid, ListBase *AnimCurves, const char *anim_type)
 {
        char rna_path[100];
-       BLI_strncpy(rna_path,anim_type, sizeof(rna_path));
-    
+       BLI_strncpy(rna_path, anim_type, sizeof(rna_path));
+
        const COLLADAFW::AnimationList *animlist = animlist_map[listid];
        const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
-                               //all the curves belonging to the current binding
-       std::vector<FCurve*> animcurves;    
+       //all the curves belonging to the current binding
+       std::vector<FCurve *> animcurves;
        for (unsigned int j = 0; j < bindings.getCount(); j++) {
-                animcurves = curve_map[bindings[j].animation];
-               //calculate rnapaths and array index of fcurves according to transformation and animation class
-                //Assign_color_animations( &bindings[j], &animcurves); 
-               
-           switch (bindings[j].animationClass) {
-               case COLLADAFW::AnimationList::COLOR_R:
-                       modify_fcurve(&animcurves, rna_path, 0 );
-                       break;
-               case COLLADAFW::AnimationList::COLOR_G:
-                       modify_fcurve(&animcurves, rna_path, 1 );
-                       break;
-               case COLLADAFW::AnimationList::COLOR_B:
-                       modify_fcurve(&animcurves, rna_path, 2 );
-                       break;
-               case COLLADAFW::AnimationList::COLOR_RGB:
-               case COLLADAFW::AnimationList::COLOR_RGBA:
-                       modify_fcurve(&animcurves, rna_path, -1 );
-                       break;
-                       
-               default:
-                       fprintf(stderr, "AnimationClass %d is not supported for %s.\n",
-                                       bindings[j].animationClass, "COLOR" );
+               animcurves = curve_map[bindings[j].animation];
+
+               switch (bindings[j].animationClass) {
+                       case COLLADAFW::AnimationList::COLOR_R:
+                               modify_fcurve(&animcurves, rna_path, 0);
+                               break;
+                       case COLLADAFW::AnimationList::COLOR_G:
+                               modify_fcurve(&animcurves, rna_path, 1);
+                               break;
+                       case COLLADAFW::AnimationList::COLOR_B:
+                               modify_fcurve(&animcurves, rna_path, 2);
+                               break;
+                       case COLLADAFW::AnimationList::COLOR_RGB:
+                       case COLLADAFW::AnimationList::COLOR_RGBA: // to do-> set intensity
+                               modify_fcurve(&animcurves, rna_path, -1);
+                               break;
+
+                       default:
+                               unused_fcurve(&animcurves);
+                               fprintf(stderr, "AnimationClass %d is not supported for %s.\n",
+                                       bindings[j].animationClass, "COLOR");
                }
 
-                std::vector<FCurve*>::iterator iter;
+               std::vector<FCurve *>::iterator iter;
                //Add the curves of the current animation to the object
                for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
-                       FCurve * fcu = *iter;
+                       FCurve *fcu = *iter;
                        BLI_addtail(AnimCurves, fcu);   
-               }                               
+               }
        }
 
-       
+
 }
 
-void AnimationImporter:: Assign_float_animations(const COLLADAFW::UniqueId& listid, ListBase *AnimCurves, char * anim_type)
+void AnimationImporter:: Assign_float_animations(const COLLADAFW::UniqueId& listid, ListBase *AnimCurves, const char *anim_type)
 {
        char rna_path[100];
-       if (animlist_map.find(listid) == animlist_map.end()) return ;
-       else 
-       {
-               //transformation has animations
+       if (animlist_map.find(listid) == animlist_map.end()) {
+               return;
+       }
+       else {
+               //anim_type has animations
                const COLLADAFW::AnimationList *animlist = animlist_map[listid];
                const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
                //all the curves belonging to the current binding
-               std::vector<FCurve*> animcurves;    
+               std::vector<FCurve *> animcurves;
                for (unsigned int j = 0; j < bindings.getCount(); j++) {
-                        animcurves = curve_map[bindings[j].animation];
-                       //calculate rnapaths and array index of fcurves according to transformation and animation class
-                        BLI_strncpy(rna_path, anim_type , sizeof(rna_path));
-                        modify_fcurve(&animcurves, rna_path, 0 );
-                        std::vector<FCurve*>::iterator iter;
-                               //Add the curves of the current animation to the object
-                               for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
-                                       FCurve * fcu = *iter;
-                                       BLI_addtail(AnimCurves, fcu);   
-                               }                               
+                       animcurves = curve_map[bindings[j].animation];
+
+                       BLI_strncpy(rna_path, anim_type, sizeof(rna_path));
+                       modify_fcurve(&animcurves, rna_path, 0);
+                       std::vector<FCurve *>::iterator iter;
+                       //Add the curves of the current animation to the object
+                       for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
+                               FCurve *fcu = *iter;
+                               BLI_addtail(AnimCurves, fcu);
+                       }
                }
        }
        
 }
 
-void AnimationImporter::apply_matrix_curves( Object * ob, std::vector<FCurve*>& animcurves, COLLADAFW::Node* root ,COLLADAFW::Node* node, 
-                                                                                                       COLLADAFW::Transformation * tm )
+void AnimationImporter::apply_matrix_curves(Object *ob, std::vector<FCurve *>& animcurves, COLLADAFW::Node *root, COLLADAFW::Node *node,
+                                            COLLADAFW::Transformation *tm)
 {
        bool is_joint = node->getType() == COLLADAFW::Node::JOINT;
        const char *bone_name = is_joint ? bc_get_joint_name(node) : NULL;
        char joint_path[200];
-       if ( is_joint ) 
+       if (is_joint)
                armature_importer->get_rna_path_for_joint(node, joint_path, sizeof(joint_path));
 
        std::vector<float> frames;
@@ -774,7 +671,7 @@ void AnimationImporter::apply_matrix_curves( Object * ob, std::vector<FCurve*>&
                get_joint_rest_mat(irest_dae, root, node);
                invert_m4(irest_dae);
 
-               Bone *bone = get_named_bone((bArmature*)ob->data, bone_name);
+               Bone *bone = BKE_armature_find_bone_name((bArmature *)ob->data, bone_name);
                if (!bone) {
                        fprintf(stderr, "cannot find bone \"%s\"\n", bone_name);
                        return;
@@ -784,47 +681,42 @@ void AnimationImporter::apply_matrix_curves( Object * ob, std::vector<FCurve*>&
                copy_m4_m4(rest, bone->arm_mat);
                invert_m4_m4(irest, rest);
        }
-    // new curves to assign matrix transform animation
+       // new curves to assign matrix transform animation
        FCurve *newcu[10]; // if tm_type is matrix, then create 10 curves: 4 rot, 3 loc, 3 scale
-       unsigned int totcu = 10 ;
-    const char *tm_str = NULL;
+       unsigned int totcu = 10;
+       const char *tm_str = NULL;
        char rna_path[200];
        for (int i = 0; i < totcu; i++) {
 
                int axis = i;
 
-                       if (i < 4) {
-                               tm_str = "rotation_quaternion";
-                               axis = i;
-                       }
-                       else if (i < 7) {
-                               tm_str = "location";
-                               axis = i - 4;
-                       }
-                       else {
-                               tm_str = "scale";
-                               axis = i - 7;
-                       }
-               
+               if (i < 4) {
+                       tm_str = "rotation_quaternion";
+                       axis = i;
+               }
+               else if (i < 7) {
+                       tm_str = "location";
+                       axis = i - 4;
+               }
+               else {
+                       tm_str = "scale";
+                       axis = i - 7;
+               }
+
 
                if (is_joint)
                        BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, tm_str);
                else
-                       strcpy(rna_path, tm_str);
+                       BLI_strncpy(rna_path, tm_str, sizeof(rna_path));
                newcu[i] = create_fcurve(axis, rna_path);
                newcu[i]->totvert = frames.size();
        }
 
-//     Object *job = NULL;
-
        if (frames.size() == 0)
                return;
 
-std::sort(frames.begin(), frames.end());
-       //if (is_joint)
-       //      armature_importer->get_rna_path_for_joint(node, joint_path, sizeof(joint_path));
+       std::sort(frames.begin(), frames.end());
 
-       
        std::vector<float>::iterator it;
 
        // sample values at each frame
@@ -835,7 +727,7 @@ std::sort(frames.begin(), frames.end());
                float matfra[4][4];
 
                unit_m4(matfra);
-        
+
                // calc object-space mat
                evaluate_transform_at_frame(matfra, node, fra);
 
@@ -849,9 +741,9 @@ std::sort(frames.begin(), frames.end());
 
                        // calc M
                        calc_joint_parent_mat_rest(par, NULL, root, node);
-                       mul_m4_m4m4(temp, matfra, par);
+                       mult_m4_m4m4(temp, par, matfra);
 
-                       // evaluate_joint_world_transform_at_frame(temp, NULL, node, fra);
+                       // evaluate_joint_world_transform_at_frame(temp, NULL, node, fra);
 
                        // calc special matrix
                        mul_serie_m4(mat, irest, temp, irest_dae, rest, NULL, NULL, NULL, NULL);
@@ -860,87 +752,90 @@ std::sort(frames.begin(), frames.end());
                        copy_m4_m4(mat, matfra);
                }
 
-               float  rot[4], loc[3], scale[3];
-        
-                       mat4_to_quat(rot, mat);
-                       for ( int i = 0 ; i < 4  ;  i ++ )
-                       {
-                               rot[i] = rot[i] * (180 / M_PI); 
-                       }
-                       copy_v3_v3(loc, mat[3]);
-                       mat4_to_size(scale, mat);
-               
+               float rot[4], loc[3], scale[3];
+
+               mat4_to_quat(rot, mat);
+               /*for ( int i = 0 ; i < 4  ;  i ++ )
+                  {
+                  rot[i] = RAD2DEGF(rot[i]);
+                  }*/
+               copy_v3_v3(loc, mat[3]);
+               mat4_to_size(scale, mat);
+
                // add keys
                for (int i = 0; i < totcu; i++) {
-                               if (i < 4)
-                                       add_bezt(newcu[i], fra, rot[i]);
-                               else if (i < 7)
-                                       add_bezt(newcu[i], fra, loc[i - 4]);
-                               else
-                                       add_bezt(newcu[i], fra, scale[i - 7]);
+                       if (i < 4)
+                               add_bezt(newcu[i], fra, rot[i]);
+                       else if (i < 7)
+                               add_bezt(newcu[i], fra, loc[i - 4]);
+                       else
+                               add_bezt(newcu[i], fra, scale[i - 7]);
                }
        }
-       verify_adt_action((ID*)&ob->id, 1);
+       verify_adt_action((ID *)&ob->id, 1);
 
        ListBase *curves = &ob->adt->action->curves;
 
        // add curves
-       for (int i= 0; i < totcu; i++) {
+       for (int i = 0; i < totcu; i++) {
                if (is_joint)
                        add_bone_fcurve(ob, node, newcu[i]);
                else
                        BLI_addtail(curves, newcu[i]);
        }
 
-               if (is_joint) {
-                       bPoseChannel *chan = get_pose_channel(ob->pose, bone_name);
-                       chan->rotmode = ROT_MODE_QUAT;
-               }
-               else {
-                       ob->rotmode = ROT_MODE_QUAT;
-               }
+       if (is_joint) {
+               bPoseChannel *chan = BKE_pose_channel_find_name(ob->pose, bone_name);
+               chan->rotmode = ROT_MODE_QUAT;
+       }
+       else {
+               ob->rotmode = ROT_MODE_QUAT;
+       }
 
        return;
 
 }
 
-void AnimationImporter::translate_Animations_NEW ( COLLADAFW::Node * node , 
-                                                                                                  std::map<COLLADAFW::UniqueId, COLLADAFW::Node*>& root_map,
-                                                                                                  std::map<COLLADAFW::UniqueId, Object*>& object_map,
-                                                                                                  std::map<COLLADAFW::UniqueId, const COLLADAFW::Object*> FW_object_map)
+void AnimationImporter::translate_Animations(COLLADAFW::Node *node,
+                                             std::map<COLLADAFW::UniqueId, COLLADAFW::Node *>& root_map,
+                                             std::multimap<COLLADAFW::UniqueId, Object *>& object_map,
+                                             std::map<COLLADAFW::UniqueId, const COLLADAFW::Object *> FW_object_map)
 {
-       AnimationImporter::AnimMix* animType = get_animation_type(node, FW_object_map );
+       AnimationImporter::AnimMix *animType = get_animation_type(node, FW_object_map);
 
        bool is_joint = node->getType() == COLLADAFW::Node::JOINT;
-       COLLADAFW::Node *root = root_map.find(node->getUniqueId()) == root_map.end() ? node : root_map[node->getUniqueId()];
-       Object *ob = is_joint ? armature_importer->get_armature_for_joint(root) : object_map[node->getUniqueId()];
-       if (!ob)
-       {
+       COLLADAFW::UniqueId uid = node->getUniqueId();
+       COLLADAFW::Node *root = root_map.find(uid) == root_map.end() ? node : root_map[uid];
+
+       Object *ob;
+       if(is_joint)
+               ob = armature_importer->get_armature_for_joint(root);
+       else
+               ob = object_map.find(uid) == object_map.end() ? NULL : object_map.find(uid)->second;
+
+       if (!ob) {
                fprintf(stderr, "cannot find Object for Node with id=\"%s\"\n", node->getOriginalId().c_str());
                return;
        }
 
-       bAction * act;
-       bActionGroup *grp = NULL;
-    
-       //if ( (animType & NODE_TRANSFORM) != 0 )
-       if ( (animType->transform) != 0 )
-       {
-       const char *bone_name = is_joint ? bc_get_joint_name(node) : NULL;
-        char joint_path[200];
+       bAction *act;
 
-               if ( is_joint ) 
-               armature_importer->get_rna_path_for_joint(node, joint_path, sizeof(joint_path));
-               
-       
-               if (!ob->adt || !ob->adt->action) act = verify_adt_action((ID*)&ob->id, 1);
-                                       else act = ob->adt->action;
-                                       //Get the list of animation curves of the object
-           
+       if ( (animType->transform) != 0) {
+               /* const char *bone_name = is_joint ? bc_get_joint_name(node) : NULL; */ /* UNUSED */
+               char joint_path[200];
+
+               if (is_joint)
+                       armature_importer->get_rna_path_for_joint(node, joint_path, sizeof(joint_path));
+
+
+               if (!ob->adt || !ob->adt->action) act = verify_adt_action((ID *)&ob->id, 1);
+               else act = ob->adt->action;
+
+               //Get the list of animation curves of the object
                ListBase *AnimCurves = &(act->curves);
 
                const COLLADAFW::TransformationPointerArray& nodeTransforms = node->getTransformations();
-       
+
                //for each transformation in node 
                for (unsigned int i = 0; i < nodeTransforms.getCount(); i++) {
                        COLLADAFW::Transformation *transform = nodeTransforms[i];
@@ -948,58 +843,57 @@ void AnimationImporter::translate_Animations_NEW ( COLLADAFW::Node * node ,
 
                        bool is_rotation = tm_type == COLLADAFW::Transformation::ROTATE;
                        bool is_matrix = tm_type == COLLADAFW::Transformation::MATRIX;
-                               
+
                        const COLLADAFW::UniqueId& listid = transform->getAnimationList();
-               
-                       //check if transformation has animations    
-                       if (animlist_map.find(listid) == animlist_map.end()) continue ; 
-                       else 
-                       {
+
+                       //check if transformation has animations
+                       if (animlist_map.find(listid) == animlist_map.end()) {
+                               continue;
+                       }
+                       else {
                                //transformation has animations
                                const COLLADAFW::AnimationList *animlist = animlist_map[listid];
                                const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
                                //all the curves belonging to the current binding
-                               std::vector<FCurve*> animcurves;    
+                               std::vector<FCurve *> animcurves;
                                for (unsigned int j = 0; j < bindings.getCount(); j++) {
-                                        animcurves = curve_map[bindings[j].animation];
-                                        if ( is_matrix )
-                                                apply_matrix_curves(ob, animcurves, root , node,  transform  );
-                                        else {                         
-                                               //calculate rnapaths and array index of fcurves according to transformation and animation class
-                                                Assign_transform_animations(transform, &bindings[j], &animcurves, is_joint, joint_path ); 
-                                               
-                                                std::vector<FCurve*>::iterator iter;
+                                       animcurves = curve_map[bindings[j].animation];
+                                       if (is_matrix) {
+                                               apply_matrix_curves(ob, animcurves, root, node,  transform);
+                                       }
+                                       else {                          
+
+                                               if (is_joint) {
+
+                                                       add_bone_animation_sampled(ob, animcurves, root, node, transform);
+                                               }
+                                               else {
+                                                       //calculate rnapaths and array index of fcurves according to transformation and animation class
+                                                       Assign_transform_animations(transform, &bindings[j], &animcurves, is_joint, joint_path);
+
+                                                       std::vector<FCurve *>::iterator iter;
                                                        //Add the curves of the current animation to the object
                                                        for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
-                                                               FCurve * fcu = *iter;
-                                                               if ((ob->type == OB_ARMATURE))
-                                                                       add_bone_fcurve( ob, node , fcu );
-                                                               else 
-                                                                       BLI_addtail(AnimCurves, fcu);   
+                                                               FCurve *fcu = *iter;
+                                                       
+                                                               BLI_addtail(AnimCurves, fcu);
                                                        }
                                                }
+                                               
+                                       }
                                }
                        }
-                       if (is_rotation) {
-                               if (is_joint) 
-                               {
-                                       bPoseChannel *chan = get_pose_channel(ob->pose, bone_name);
-                                       chan->rotmode = ROT_MODE_EUL;
-                               }
-                               else 
-                               {
-                                       ob->rotmode = ROT_MODE_EUL;
-                               }
+                       if (is_rotation && !is_joint) {
+                               ob->rotmode = ROT_MODE_EUL;
                        }
                }
        }
 
-       if ((animType->light) != 0)
-       {
-               Lamp * lamp  = (Lamp*) ob->data;
+       if ((animType->light) != 0) {
+               Lamp *lamp  = (Lamp *) ob->data;
 
-               if (!lamp->adt || !lamp->adt->action) act = verify_adt_action((ID*)&lamp->id, 1);
-                                       else act = lamp->adt->action;
+               if (!lamp->adt || !lamp->adt->action) act = verify_adt_action((ID *)&lamp->id, 1);
+               else act = lamp->adt->action;
 
                ListBase *AnimCurves = &(act->curves);
                const COLLADAFW::InstanceLightPointerArray& nodeLights = node->getInstanceLights();
@@ -1007,136 +901,273 @@ void AnimationImporter::translate_Animations_NEW ( COLLADAFW::Node * node ,
                for (unsigned int i = 0; i < nodeLights.getCount(); i++) {
                        const COLLADAFW::Light *light = (COLLADAFW::Light *) FW_object_map[nodeLights[i]->getInstanciatedObjectId()];
 
-                       if ((animType->light & LIGHT_COLOR) != 0)
-                       {
+                       if ((animType->light & LIGHT_COLOR) != 0) {
                                const COLLADAFW::Color *col =  &(light->getColor());
                                const COLLADAFW::UniqueId& listid = col->getAnimationList();
-                               
+
                                Assign_color_animations(listid, AnimCurves, "color"); 
                        }
-                       if ((animType->light & LIGHT_FOA) != 0 )
-                       {
+                       if ((animType->light & LIGHT_FOA) != 0) {
                                const COLLADAFW::AnimatableFloat *foa =  &(light->getFallOffAngle());
                                const COLLADAFW::UniqueId& listid = foa->getAnimationList();
-                               
-                               Assign_float_animations( listid ,AnimCurves, "spot_size"); 
+
+                               Assign_float_animations(listid, AnimCurves, "spot_size");
                        }
-                       if ( (animType->light & LIGHT_FOE) != 0 )
-                       {
+                       if ( (animType->light & LIGHT_FOE) != 0) {
                                const COLLADAFW::AnimatableFloat *foe =  &(light->getFallOffExponent());
                                const COLLADAFW::UniqueId& listid = foe->getAnimationList();
-                               
-                               Assign_float_animations( listid ,AnimCurves, "spot_blend"); 
-                       
+
+                               Assign_float_animations(listid, AnimCurves, "spot_blend");
+
                        }
                }
        }
 
-       if ( (animType->camera) != 0) 
-       {
-               Camera * camera  = (Camera*) ob->data;
+       if (animType->camera != 0) {
+               Camera *camera  = (Camera *) ob->data;
 
-               if (!camera->adt || !camera->adt->action) act = verify_adt_action((ID*)&camera->id, 1);
-                                       else act = camera->adt->action;
+               if (!camera->adt || !camera->adt->action) act = verify_adt_action((ID *)&camera->id, 1);
+               else act = camera->adt->action;
 
                ListBase *AnimCurves = &(act->curves);
-               const COLLADAFW::InstanceCameraPointerArray& nodeCameras= node->getInstanceCameras();
+               const COLLADAFW::InstanceCameraPointerArray& nodeCameras = node->getInstanceCameras();
 
                for (unsigned int i = 0; i < nodeCameras.getCount(); i++) {
                        const COLLADAFW::Camera *camera = (COLLADAFW::Camera *) FW_object_map[nodeCameras[i]->getInstanciatedObjectId()];
 
-                       if ((animType->camera & CAMERA_XFOV) != 0 )
-                       {
+                       if ((animType->camera & CAMERA_XFOV) != 0) {
                                const COLLADAFW::AnimatableFloat *xfov =  &(camera->getXFov());
                                const COLLADAFW::UniqueId& listid = xfov->getAnimationList();
-                               Assign_float_animations( listid ,AnimCurves, "lens"); 
+                               Assign_float_animations(listid, AnimCurves, "lens");
                        }
 
-                       else if ((animType->camera & CAMERA_XMAG) != 0 )
-                       {
+                       else if ((animType->camera & CAMERA_YFOV) != 0) {
+                               const COLLADAFW::AnimatableFloat *yfov =  &(camera->getYFov());
+                               const COLLADAFW::UniqueId& listid = yfov->getAnimationList();
+                               Assign_float_animations(listid, AnimCurves, "lens");
+                       }
+
+                       else if ((animType->camera & CAMERA_XMAG) != 0) {
                                const COLLADAFW::AnimatableFloat *xmag =  &(camera->getXMag());
                                const COLLADAFW::UniqueId& listid = xmag->getAnimationList();
-                               Assign_float_animations( listid ,AnimCurves, "ortho_scale"); 
+                               Assign_float_animations(listid, AnimCurves, "ortho_scale");
+                       }
+
+                       else if ((animType->camera & CAMERA_YMAG) != 0) {
+                               const COLLADAFW::AnimatableFloat *ymag =  &(camera->getYMag());
+                               const COLLADAFW::UniqueId& listid = ymag->getAnimationList();
+                               Assign_float_animations(listid, AnimCurves, "ortho_scale");
                        }
 
-                       if ((animType->camera & CAMERA_ZFAR) != 0 )
-                       {
+                       if ((animType->camera & CAMERA_ZFAR) != 0) {
                                const COLLADAFW::AnimatableFloat *zfar =  &(camera->getFarClippingPlane());
                                const COLLADAFW::UniqueId& listid = zfar->getAnimationList();
-                               Assign_float_animations( listid ,AnimCurves, "clip_end"); 
+                               Assign_float_animations(listid, AnimCurves, "clip_end");
                        }
 
-                       if ((animType->camera & CAMERA_ZNEAR) != 0 )
-                       {
+                       if ((animType->camera & CAMERA_ZNEAR) != 0) {
                                const COLLADAFW::AnimatableFloat *znear =  &(camera->getNearClippingPlane());
                                const COLLADAFW::UniqueId& listid = znear->getAnimationList();
-                               Assign_float_animations( listid ,AnimCurves, "clip_start"); 
+                               Assign_float_animations(listid, AnimCurves, "clip_start");
                        }
 
                }
        }
-       if ( animType->material != 0){
-                Material *ma = give_current_material(ob, 1);
-                if (!ma->adt || !ma->adt->action) act = verify_adt_action((ID*)&ma->id, 1);
-                               else act = ma->adt->action;
+       if (animType->material != 0) {
+               Material *ma = give_current_material(ob, 1);
+               if (!ma->adt || !ma->adt->action) act = verify_adt_action((ID *)&ma->id, 1);
+               else act = ma->adt->action;
 
                ListBase *AnimCurves = &(act->curves);
-               
+
                const COLLADAFW::InstanceGeometryPointerArray& nodeGeoms = node->getInstanceGeometries();
                for (unsigned int i = 0; i < nodeGeoms.getCount(); i++) {
                        const COLLADAFW::MaterialBindingArray& matBinds = nodeGeoms[i]->getMaterialBindings();
                        for (unsigned int j = 0; j < matBinds.getCount(); j++) {
                                const COLLADAFW::UniqueId & matuid = matBinds[j].getReferencedMaterial();
                                const COLLADAFW::Effect *ef = (COLLADAFW::Effect *) (FW_object_map[matuid]);
-                               const COLLADAFW::CommonEffectPointerArray& commonEffects  =  ef->getCommonEffects();
-                               COLLADAFW::EffectCommon *efc = commonEffects[0];
-                               if((animType->material & MATERIAL_SHININESS) != 0){
-                                       const COLLADAFW::FloatOrParam *shin = &(efc->getShininess());
-                                       const COLLADAFW::UniqueId& listid =  shin->getAnimationList();
-                                       Assign_float_animations( listid, AnimCurves , "specular_hardness" );
-                               }
+                               if (ef != NULL) { /* can be NULL [#28909] */
+                                       const COLLADAFW::CommonEffectPointerArray& commonEffects  =  ef->getCommonEffects();
+                                       COLLADAFW::EffectCommon *efc = commonEffects[0];
+                                       if ((animType->material & MATERIAL_SHININESS) != 0) {
+                                               const COLLADAFW::FloatOrParam *shin = &(efc->getShininess());
+                                               const COLLADAFW::UniqueId& listid =  shin->getAnimationList();
+                                               Assign_float_animations(listid, AnimCurves, "specular_hardness");
+                                       }
 
-                               if((animType->material & MATERIAL_IOR) != 0){
-                                       const COLLADAFW::FloatOrParam *ior = &(efc->getIndexOfRefraction());
-                                       const COLLADAFW::UniqueId& listid =  ior->getAnimationList();
-                                       Assign_float_animations( listid, AnimCurves , "raytrace_transparency.ior" );
-                               }
+                                       if ((animType->material & MATERIAL_IOR) != 0) {
+                                               const COLLADAFW::FloatOrParam *ior = &(efc->getIndexOfRefraction());
+                                               const COLLADAFW::UniqueId& listid =  ior->getAnimationList();
+                                               Assign_float_animations(listid, AnimCurves, "raytrace_transparency.ior");
+                                       }
 
-                               if((animType->material & MATERIAL_SPEC_COLOR) != 0){
-                                       const COLLADAFW::ColorOrTexture *cot = &(efc->getSpecular());
-                                       const COLLADAFW::UniqueId& listid =  cot->getColor().getAnimationList();
-                                       Assign_color_animations( listid, AnimCurves , "specular_color" );
-                               }
-                               
-                               if((animType->material & MATERIAL_DIFF_COLOR) != 0){
-                                       const COLLADAFW::ColorOrTexture *cot = &(efc->getDiffuse());
-                                       const COLLADAFW::UniqueId& listid =  cot->getColor().getAnimationList();
-                                       Assign_color_animations( listid, AnimCurves , "diffuse_color" );
+                                       if ((animType->material & MATERIAL_SPEC_COLOR) != 0) {
+                                               const COLLADAFW::ColorOrTexture *cot = &(efc->getSpecular());
+                                               const COLLADAFW::UniqueId& listid =  cot->getColor().getAnimationList();
+                                               Assign_color_animations(listid, AnimCurves, "specular_color");
+                                       }
+
+                                       if ((animType->material & MATERIAL_DIFF_COLOR) != 0) {
+                                               const COLLADAFW::ColorOrTexture *cot = &(efc->getDiffuse());
+                                               const COLLADAFW::UniqueId& listid =  cot->getColor().getAnimationList();
+                                               Assign_color_animations(listid, AnimCurves, "diffuse_color");
+                                       }
                                }
                        }
                }       
        }
 }
 
+void AnimationImporter::add_bone_animation_sampled(Object *ob, std::vector<FCurve *>& animcurves, COLLADAFW::Node *root, COLLADAFW::Node *node, COLLADAFW::Transformation *tm)
+{
+       const char *bone_name = bc_get_joint_name(node);
+       char joint_path[200];
+       armature_importer->get_rna_path_for_joint(node, joint_path, sizeof(joint_path));
+
+       std::vector<float> frames;
+       find_frames(&frames, &animcurves);
+
+       // convert degrees to radians
+       if (tm->getTransformationType() == COLLADAFW::Transformation::ROTATE) {
+
+               std::vector<FCurve *>::iterator iter;
+               for (iter = animcurves.begin(); iter != animcurves.end(); iter++) {
+                       FCurve *fcu = *iter;
+
+                       fcurve_deg_to_rad(fcu);          
+               }                                       
+       }
+
+
+       float irest_dae[4][4];
+       float rest[4][4], irest[4][4];
+
+       get_joint_rest_mat(irest_dae, root, node);
+       invert_m4(irest_dae);
+
+       Bone *bone = BKE_armature_find_bone_name((bArmature *)ob->data, bone_name);
+       if (!bone) {
+               fprintf(stderr, "cannot find bone \"%s\"\n", bone_name);
+               return;
+       }
+
+       unit_m4(rest);
+       copy_m4_m4(rest, bone->arm_mat);
+       invert_m4_m4(irest, rest);
+
+       // new curves to assign matrix transform animation
+       FCurve *newcu[10]; // if tm_type is matrix, then create 10 curves: 4 rot, 3 loc, 3 scale
+       unsigned int totcu = 10;
+       const char *tm_str = NULL;
+       char rna_path[200];
+       for (int i = 0; i < totcu; i++) {
+
+               int axis = i;
+
+               if (i < 4) {
+                       tm_str = "rotation_quaternion";
+                       axis = i;
+               }
+               else if (i < 7) {
+                       tm_str = "location";
+                       axis = i - 4;
+               }
+               else {
+                       tm_str = "scale";
+                       axis = i - 7;
+               }
+
+
+               BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, tm_str);
+
+               newcu[i] = create_fcurve(axis, rna_path);
+               newcu[i]->totvert = frames.size();
+       }
+
+       if (frames.size() == 0)
+               return;
+
+       std::sort(frames.begin(), frames.end());
+
+       std::vector<float>::iterator it;
+
+       // sample values at each frame
+       for (it = frames.begin(); it != frames.end(); it++) {
+               float fra = *it;
+
+               float mat[4][4];
+               float matfra[4][4];
+
+               unit_m4(matfra);
+
+               // calc object-space mat
+               evaluate_transform_at_frame(matfra, node, fra);
+
+
+               // for joints, we need a special matrix
+               // special matrix: iR * M * iR_dae * R
+               // where R, iR are bone rest and inverse rest mats in world space (Blender bones),
+               // iR_dae is joint inverse rest matrix (DAE) and M is an evaluated joint world-space matrix (DAE)
+               float temp[4][4], par[4][4];
+
+
+               // calc M
+               calc_joint_parent_mat_rest(par, NULL, root, node);
+               mult_m4_m4m4(temp, par, matfra);
+
+               // evaluate_joint_world_transform_at_frame(temp, NULL,, node, fra);
+
+               // calc special matrix
+               mul_serie_m4(mat, irest, temp, irest_dae, rest, NULL, NULL, NULL, NULL);
+
+               float rot[4], loc[3], scale[3];
+
+               mat4_to_quat(rot, mat);
+               copy_v3_v3(loc, mat[3]);
+               mat4_to_size(scale, mat);
+
+               // add keys
+               for (int i = 0; i < totcu; i++) {
+                       if (i < 4)
+                               add_bezt(newcu[i], fra, rot[i]);
+                       else if (i < 7)
+                               add_bezt(newcu[i], fra, loc[i - 4]);
+                       else
+                               add_bezt(newcu[i], fra, scale[i - 7]);
+               }
+       }
+       verify_adt_action((ID *)&ob->id, 1);
+
+       // add curves
+       for (int i = 0; i < totcu; i++) {
+               add_bone_fcurve(ob, node, newcu[i]);
+       }
+
+       bPoseChannel *chan = BKE_pose_channel_find_name(ob->pose, bone_name);
+       chan->rotmode = ROT_MODE_QUAT;
+
+}
+
 
 //Check if object is animated by checking if animlist_map holds the animlist_id of node transforms
-AnimationImporter::AnimMix* AnimationImporter::get_animation_type ( const COLLADAFW::Node * node , 
-                                                                                       std::map<COLLADAFW::UniqueId, const COLLADAFW::Object*> FW_object_map) 
+AnimationImporter::AnimMix *AnimationImporter::get_animation_type(const COLLADAFW::Node *node,
+                                                                  std::map<COLLADAFW::UniqueId, const COLLADAFW::Object *> FW_object_map)
 {
        AnimMix *types = new AnimMix();
-       
+
        const COLLADAFW::TransformationPointerArray& nodeTransforms = node->getTransformations();
-       
+
        //for each transformation in node 
        for (unsigned int i = 0; i < nodeTransforms.getCount(); i++) {
                COLLADAFW::Transformation *transform = nodeTransforms[i];
                const COLLADAFW::UniqueId& listid = transform->getAnimationList();
-               
-               //check if transformation has animations    
-               if (animlist_map.find(listid) == animlist_map.end()) continue ;
-               else 
-               {
-                       types->transform = types->transform|NODE_TRANSFORM;
+
+               //check if transformation has animations
+               if (animlist_map.find(listid) == animlist_map.end()) {
+                       continue;
+               }
+               else {
+                       types->transform = types->transform | NODE_TRANSFORM;
                        break;
                }
        }
@@ -1144,30 +1175,41 @@ AnimationImporter::AnimMix* AnimationImporter::get_animation_type ( const COLLAD
 
        for (unsigned int i = 0; i < nodeLights.getCount(); i++) {
                const COLLADAFW::Light *light = (COLLADAFW::Light *) FW_object_map[nodeLights[i]->getInstanciatedObjectId()];
-               types->light = setAnimType(&(light->getColor()),(types->light), LIGHT_COLOR);
-               types->light = setAnimType(&(light->getFallOffAngle()),(types->light), LIGHT_FOA);
-               types->light = setAnimType(&(light->getFallOffExponent()),(types->light), LIGHT_FOE);
-               
-               if ( types->light != 0) break;
-               
+               types->light = setAnimType(&(light->getColor()), (types->light), LIGHT_COLOR);
+               types->light = setAnimType(&(light->getFallOffAngle()), (types->light), LIGHT_FOA);
+               types->light = setAnimType(&(light->getFallOffExponent()), (types->light), LIGHT_FOE);
+
+               if (types->light != 0) break;
+
        }
 
        const COLLADAFW::InstanceCameraPointerArray& nodeCameras = node->getInstanceCameras();
        for (unsigned int i = 0; i < nodeCameras.getCount(); i++) {
-               const COLLADAFW::Camera *camera = (COLLADAFW::Camera *) FW_object_map[nodeCameras[i]->getInstanciatedObjectId()];
+               const COLLADAFW::Camera *camera  = (COLLADAFW::Camera *) FW_object_map[nodeCameras[i]->getInstanciatedObjectId()];
+               if ( camera == NULL ) {
+                       // Can happen if the node refers to an unknown camera.
+                       continue;
+               }
 
-               if ( camera->getCameraType() == COLLADAFW::Camera::PERSPECTIVE )
-               {
-                   types->camera = setAnimType(&(camera->getXMag()),(types->camera), CAMERA_XFOV);
+               const bool is_perspective_type   = camera->getCameraType() == COLLADAFW::Camera::PERSPECTIVE;
+
+               int addition;
+               const COLLADAFW::Animatable *mag;
+               const COLLADAFW::UniqueId listid = camera->getYMag().getAnimationList();
+               if (animlist_map.find(listid) != animlist_map.end()) {
+                       mag = &(camera->getYMag());
+                       addition = (is_perspective_type) ? CAMERA_YFOV: CAMERA_YMAG;
                }
-               else 
-               {
-                       types->camera = setAnimType(&(camera->getXMag()),(types->camera), CAMERA_XMAG);
+               else {
+                       mag = &(camera->getXMag());
+                       addition = (is_perspective_type) ? CAMERA_XFOV: CAMERA_XMAG;
                }
-               types->camera = setAnimType(&(camera->getFarClippingPlane()),(types->camera), CAMERA_ZFAR);
-               types->camera = setAnimType(&(camera->getNearClippingPlane()),(types->camera), CAMERA_ZNEAR);
+               types->camera = setAnimType(mag, (types->camera), addition);
+
+               types->camera = setAnimType(&(camera->getFarClippingPlane()), (types->camera), CAMERA_ZFAR);
+               types->camera = setAnimType(&(camera->getNearClippingPlane()), (types->camera), CAMERA_ZNEAR);
 
-               if ( types->camera != 0) break;
+               if (types->camera != 0) break;
 
        }
 
@@ -1177,28 +1219,36 @@ AnimationImporter::AnimMix* AnimationImporter::get_animation_type ( const COLLAD
                for (unsigned int j = 0; j < matBinds.getCount(); j++) {
                        const COLLADAFW::UniqueId & matuid = matBinds[j].getReferencedMaterial();
                        const COLLADAFW::Effect *ef = (COLLADAFW::Effect *) (FW_object_map[matuid]);
-                       const COLLADAFW::CommonEffectPointerArray& commonEffects  =  ef->getCommonEffects();
-                       COLLADAFW::EffectCommon *efc = commonEffects[0];
-                       types->material =  setAnimType(&(efc->getShininess()),(types->material), MATERIAL_SHININESS);
-                       types->material =  setAnimType(&(efc->getSpecular().getColor()),(types->material), MATERIAL_SPEC_COLOR);
-                       types->material =  setAnimType(&(efc->getDiffuse().getColor()),(types->material), MATERIAL_DIFF_COLOR);
-                  // types->material =  setAnimType(&(efc->get()),(types->material), MATERIAL_TRANSPARENCY);
-                       types->material =  setAnimType(&(efc->getIndexOfRefraction()),(types->material), MATERIAL_IOR);
+                       if (ef != NULL) { /* can be NULL [#28909] */
+                               const COLLADAFW::CommonEffectPointerArray& commonEffects = ef->getCommonEffects();
+                               if (!commonEffects.empty()) {
+                                       COLLADAFW::EffectCommon *efc = commonEffects[0];
+                                       types->material =  setAnimType(&(efc->getShininess()), (types->material), MATERIAL_SHININESS);
+                                       types->material =  setAnimType(&(efc->getSpecular().getColor()), (types->material), MATERIAL_SPEC_COLOR);
+                                       types->material =  setAnimType(&(efc->getDiffuse().getColor()), (types->material), MATERIAL_DIFF_COLOR);
+                                       // types->material =  setAnimType(&(efc->get()), (types->material), MATERIAL_TRANSPARENCY);
+                                       types->material =  setAnimType(&(efc->getIndexOfRefraction()), (types->material), MATERIAL_IOR);
+                               }
+                       }
                }
        }
        return types;
 }
 
-int AnimationImporter::setAnimType ( const COLLADAFW::Animatable * prop , int types, int addition)
+int AnimationImporter::setAnimType(const COLLADAFW::Animatable *prop, int types, int addition)
 {
-               const COLLADAFW::UniqueId& listid =  prop->getAnimationList();
-               if (animlist_map.find(listid) != animlist_map.end()) 
-                               return types|addition;
-               else return types;
+       int anim_type;
+       const COLLADAFW::UniqueId& listid       = prop->getAnimationList();
+       if (animlist_map.find(listid) != animlist_map.end())
+               anim_type =  types | addition;
+       else
+               anim_type = types;
+
+       return anim_type;
 }              
 
-//XXX Is not used anymore.
-void AnimationImporter::find_frames_old(std::vector<float> * frames, COLLADAFW::Node * node , COLLADAFW::Transformation::TransformationType tm_type)
+// Is not used anymore.
+void AnimationImporter::find_frames_old(std::vector<float> *frames, COLLADAFW::Node *node, COLLADAFW::Transformation::TransformationType tm_type)
 {
        bool is_matrix = tm_type == COLLADAFW::Transformation::MATRIX;
        bool is_rotation = tm_type == COLLADAFW::Transformation::ROTATE;
@@ -1220,19 +1270,19 @@ void AnimationImporter::find_frames_old(std::vector<float> * frames, COLLADAFW::
                                
                                const COLLADAFW::AnimationList *animlist = animlist_map[listid];
                                const COLLADAFW::AnimationList::AnimationBindings& bindings = animlist->getAnimationBindings();
-                
+
                                if (bindings.getCount()) {
                                        //for each AnimationBinding get the fcurves which animate the transform
                                        for (unsigned int j = 0; j < bindings.getCount(); j++) {
-                                               std::vector<FCurve*>& curves = curve_map[bindings[j].animation];
+                                               std::vector<FCurve *>& curves = curve_map[bindings[j].animation];
                                                bool xyz = ((nodeTmType == COLLADAFW::Transformation::TRANSLATE || nodeTmType == COLLADAFW::Transformation::SCALE) && bindings[j].animationClass == COLLADAFW::AnimationList::POSITION_XYZ);
 
                                                if ((!xyz && curves.size() == 1) || (xyz && curves.size() == 3) || is_matrix) {
-                                                       std::vector<FCurve*>::iterator iter;
+                                                       std::vector<FCurve *>::iterator iter;
 
                                                        for (iter = curves.begin(); iter != curves.end(); iter++) {
                                                                FCurve *fcu = *iter;
-                                
+
                                                                //if transform is rotation the fcurves values must be turned in to radian.
                                                                if (is_rotation)
                                                                        fcurve_deg_to_rad(fcu);
@@ -1257,14 +1307,15 @@ void AnimationImporter::find_frames_old(std::vector<float> * frames, COLLADAFW::
 }
 
 
+
 // prerequisites:
 // animlist_map - map animlist id -> animlist
 // curve_map - map anim id -> curve(s)
-Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
-                                                       std::map<COLLADAFW::UniqueId, Object*>& object_map,
-                                                       std::map<COLLADAFW::UniqueId, COLLADAFW::Node*>& root_map,
-                                                       COLLADAFW::Transformation::TransformationType tm_type,
-                                                       Object *par_job)
+Object *AnimationImporter::translate_animation_OLD(COLLADAFW::Node *node,
+                                                   std::map<COLLADAFW::UniqueId, Object *>& object_map,
+                                                   std::map<COLLADAFW::UniqueId, COLLADAFW::Node *>& root_map,
+                                                   COLLADAFW::Transformation::TransformationType tm_type,
+                                                   Object *par_job)
 {
        
        bool is_rotation = tm_type == COLLADAFW::Transformation::ROTATE;
@@ -1282,7 +1333,7 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
        // frames at which to sample
        std::vector<float> frames;
        
-       find_frames_old(&frames, node , tm_type);
+       find_frames_old(&frames, node, tm_type);
        
        unsigned int i;
        
@@ -1293,7 +1344,7 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
                get_joint_rest_mat(irest_dae, root, node);
                invert_m4(irest_dae);
 
-               Bone *bone = get_named_bone((bArmature*)ob->data, bone_name);
+               Bone *bone = BKE_armature_find_bone_name((bArmature *)ob->data, bone_name);
                if (!bone) {
                        fprintf(stderr, "cannot find bone \"%s\"\n", bone_name);
                        return NULL;
@@ -1318,19 +1369,19 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
 
        const char *tm_str = NULL;
        switch (tm_type) {
-       case COLLADAFW::Transformation::ROTATE:
-               tm_str = "rotation_quaternion";
-               break;
-       case COLLADAFW::Transformation::SCALE:
-               tm_str = "scale";
-               break;
-       case COLLADAFW::Transformation::TRANSLATE:
-               tm_str = "location";
-               break;
-       case COLLADAFW::Transformation::MATRIX:
-               break;
-       default:
-               return job;
+               case COLLADAFW::Transformation::ROTATE:
+                       tm_str = "rotation_quaternion";
+                       break;
+               case COLLADAFW::Transformation::SCALE:
+                       tm_str = "scale";
+                       break;
+               case COLLADAFW::Transformation::TRANSLATE:
+                       tm_str = "location";
+                       break;
+               case COLLADAFW::Transformation::MATRIX:
+                       break;
+               default:
+                       return job;
        }
 
        char rna_path[200];
@@ -1365,7 +1416,7 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
                if (is_joint)
                        BLI_snprintf(rna_path, sizeof(rna_path), "%s.%s", joint_path, tm_str);
                else
-                       strcpy(rna_path, tm_str);
+                       BLI_strncpy(rna_path, tm_str, sizeof(rna_path));
                newcu[i] = create_fcurve(axis, rna_path);
 
 #ifdef ARMATURE_TEST
@@ -1397,9 +1448,9 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
 
                        // calc M
                        calc_joint_parent_mat_rest(par, NULL, root, node);
-                       mul_m4_m4m4(temp, matfra, par);
+                       mult_m4_m4m4(temp, par, matfra);
 
-                       // evaluate_joint_world_transform_at_frame(temp, NULL, , node, fra);
+                       // evaluate_joint_world_transform_at_frame(temp, NULL,, node, fra);
 
                        // calc special matrix
                        mul_serie_m4(mat, irest, temp, irest_dae, rest, NULL, NULL, NULL, NULL);
@@ -1411,22 +1462,22 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
                float val[4], rot[4], loc[3], scale[3];
 
                switch (tm_type) {
-               case COLLADAFW::Transformation::ROTATE:
-                       mat4_to_quat(val, mat);
-                       break;
-               case COLLADAFW::Transformation::SCALE:
-                       mat4_to_size(val, mat);
-                       break;
-               case COLLADAFW::Transformation::TRANSLATE:
-                       copy_v3_v3(val, mat[3]);
-                       break;
-               case COLLADAFW::Transformation::MATRIX:
-                       mat4_to_quat(rot, mat);
-                       copy_v3_v3(loc, mat[3]);
-                       mat4_to_size(scale, mat);
-                       break;
-               default:
-                       break;
+                       case COLLADAFW::Transformation::ROTATE:
+                               mat4_to_quat(val, mat);
+                               break;
+                       case COLLADAFW::Transformation::SCALE:
+                               mat4_to_size(val, mat);
+                               break;
+                       case COLLADAFW::Transformation::TRANSLATE:
+                               copy_v3_v3(val, mat[3]);
+                               break;
+                       case COLLADAFW::Transformation::MATRIX:
+                               mat4_to_quat(rot, mat);
+                               copy_v3_v3(loc, mat[3]);
+                               mat4_to_size(scale, mat);
+                               break;
+                       default:
+                               break;
                }
 
                // add keys
@@ -1447,22 +1498,22 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
 #ifdef ARMATURE_TEST
                if (is_joint) {
                        switch (tm_type) {
-                       case COLLADAFW::Transformation::ROTATE:
-                               mat4_to_quat(val, matfra);
-                               break;
-                       case COLLADAFW::Transformation::SCALE:
-                               mat4_to_size(val, matfra);
-                               break;
-                       case COLLADAFW::Transformation::TRANSLATE:
-                               copy_v3_v3(val, matfra[3]);
-                               break;
-                       case MATRIX:
-                               mat4_to_quat(rot, matfra);
-                               copy_v3_v3(loc, matfra[3]);
-                               mat4_to_size(scale, matfra);
-                               break;
-                       default:
-                               break;
+                               case COLLADAFW::Transformation::ROTATE:
+                                       mat4_to_quat(val, matfra);
+                                       break;
+                               case COLLADAFW::Transformation::SCALE:
+                                       mat4_to_size(val, matfra);
+                                       break;
+                               case COLLADAFW::Transformation::TRANSLATE:
+                                       copy_v3_v3(val, matfra[3]);
+                                       break;
+                               case MATRIX:
+                                       mat4_to_quat(rot, matfra);
+                                       copy_v3_v3(loc, matfra[3]);
+                                       mat4_to_size(scale, matfra);
+                                       break;
+                               default:
+                                       break;
                        }
 
                        for (i = 0; i < totcu; i++) {
@@ -1482,7 +1533,7 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
 #endif
        }
 
-       verify_adt_action((ID*)&ob->id, 1);
+       verify_adt_action((ID *)&ob->id, 1);
 
        ListBase *curves = &ob->adt->action->curves;
 
@@ -1501,7 +1552,7 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
 
        if (is_rotation || is_matrix) {
                if (is_joint) {
-                       bPoseChannel *chan = get_pose_channel(ob->pose, bone_name);
+                       bPoseChannel *chan = BKE_pose_channel_find_name(ob->pose, bone_name);
                        chan->rotmode = ROT_MODE_QUAT;
                }
                else {
@@ -1513,7 +1564,7 @@ Object *AnimationImporter::translate_animation(COLLADAFW::Node *node,
 }
 
 // internal, better make it private
-// warning: evaluates only rotation
+// warning: evaluates only rotation and only assigns matrix transforms now
 // prerequisites: animlist_map, curve_map
 void AnimationImporter::evaluate_transform_at_frame(float mat[4][4], COLLADAFW::Node *node, float fra)
 {
@@ -1527,35 +1578,33 @@ void AnimationImporter::evaluate_transform_at_frame(float mat[4][4], COLLADAFW::
                float m[4][4];
 
                unit_m4(m);
-               if ( type != COLLADAFW::Transformation::MATRIX )
-                       continue;
 
                std::string nodename = node->getName().size() ? node->getName() : node->getOriginalId();
                if (!evaluate_animation(tm, m, fra, nodename.c_str())) {
-                       /*switch (type) {
-                       case COLLADAFW::Transformation::ROTATE:
-                               dae_rotate_to_mat4(tm, m);
-                               break;
-                       case COLLADAFW::Transformation::TRANSLATE:
-                               dae_translate_to_mat4(tm, m);
-                               break;
-                       case COLLADAFW::Transformation::SCALE:
-                               dae_scale_to_mat4(tm, m);
-                               break;
-                       case COLLADAFW::Transformation::MATRIX:
-                               dae_matrix_to_mat4(tm, m);
-                               break;
-                       default:
-                               fprintf(stderr, "unsupported transformation type %d\n", type);
-                       }*/
-                       dae_matrix_to_mat4(tm, m);
+                       switch (type) {
+                               case COLLADAFW::Transformation::ROTATE:
+                                       dae_rotate_to_mat4(tm, m);
+                                       break;
+                               case COLLADAFW::Transformation::TRANSLATE:
+                                       dae_translate_to_mat4(tm, m);
+                                       break;
+                               case COLLADAFW::Transformation::SCALE:
+                                       dae_scale_to_mat4(tm, m);
+                                       break;
+                               case COLLADAFW::Transformation::MATRIX:
+                                       dae_matrix_to_mat4(tm, m);
+                                       break;
+                               default:
+                                       fprintf(stderr, "unsupported transformation type %d\n", type);
+                       }
+                       // dae_matrix_to_mat4(tm, m);
                        
                }
 
                float temp[4][4];
                copy_m4_m4(temp, mat);
 
-               mul_m4_m4m4(mat, m, temp);
+               mult_m4_m4m4(mat, temp, m);
        }
 }
 
@@ -1592,25 +1641,25 @@ bool AnimationImporter::evaluate_animation(COLLADAFW::Transformation *tm, float
 
                for (unsigned int j = 0; j < bindings.getCount(); j++) {
                        const COLLADAFW::AnimationList::AnimationBinding& binding = bindings[j];
-                       std::vector<FCurve*>& curves = curve_map[binding.animation];
+                       std::vector<FCurve *>& curves = curve_map[binding.animation];
                        COLLADAFW::AnimationList::AnimationClass animclass = binding.animationClass;
                        char path[100];
 
                        switch (type) {
-                       case COLLADAFW::Transformation::ROTATE:
-                               BLI_snprintf(path, sizeof(path), "%s.rotate (binding %u)", node_id, j);
-                               break;
-                       case COLLADAFW::Transformation::SCALE:
-                               BLI_snprintf(path, sizeof(path), "%s.scale (binding %u)", node_id, j);
-                               break;
-                       case COLLADAFW::Transformation::TRANSLATE:
-                               BLI_snprintf(path, sizeof(path), "%s.translate (binding %u)", node_id, j);
-                               break;
-                       case COLLADAFW::Transformation::MATRIX:
-                               BLI_snprintf(path, sizeof(path), "%s.matrix (binding %u)", node_id, j);
-                               break;
-                       default:
-                               break;
+                               case COLLADAFW::Transformation::ROTATE:
+                                       BLI_snprintf(path, sizeof(path), "%s.rotate (binding %u)", node_id, j);
+                                       break;
+                               case COLLADAFW::Transformation::SCALE:
+                                       BLI_snprintf(path, sizeof(path), "%s.scale (binding %u)", node_id, j);
+                                       break;
+                               case COLLADAFW::Transformation::TRANSLATE:
+                                       BLI_snprintf(path, sizeof(path), "%s.translate (binding %u)", node_id, j);
+                                       break;
+                               case COLLADAFW::Transformation::MATRIX:
+                                       BLI_snprintf(path, sizeof(path), "%s.matrix (binding %u)", node_id, j);
+                                       break;
+                               default:
+                                       break;
                        }
 
                        if (animclass == COLLADAFW::AnimationList::UNKNOWN_CLASS) {
@@ -1630,8 +1679,9 @@ bool AnimationImporter::evaluate_animation(COLLADAFW::Transformation *tm, float
                                        return false;
                                }
 
-                               COLLADABU::Math::Vector3& axis = ((COLLADAFW::Rotate*)tm)->getRotationAxis();
-                               float ax[3] = {axis[0], axis[1], axis[2]};
+                               COLLADABU::Math::Vector3& axis = ((COLLADAFW::Rotate *)tm)->getRotationAxis();
+
+                               float ax[3] = {(float)axis[0], (float)axis[1], (float)axis[2]};
                                float angle = evaluate_fcurve(curves[0], fra);
                                axis_angle_to_mat4(mat, ax, angle);
 
@@ -1649,23 +1699,23 @@ bool AnimationImporter::evaluate_animation(COLLADAFW::Transformation *tm, float
                                }
                                
                                switch (animclass) {
-                               case COLLADAFW::AnimationList::POSITION_X:
-                                       vec[0] = evaluate_fcurve(curves[0], fra);
-                                       break;
-                               case COLLADAFW::AnimationList::POSITION_Y:
-                                       vec[1] = evaluate_fcurve(curves[0], fra);
-                                       break;
-                               case COLLADAFW::AnimationList::POSITION_Z:
-                                       vec[2] = evaluate_fcurve(curves[0], fra);
-                                       break;
-                               case COLLADAFW::AnimationList::POSITION_XYZ:
-                                       vec[0] = evaluate_fcurve(curves[0], fra);
-                                       vec[1] = evaluate_fcurve(curves[1], fra);
-                                       vec[2] = evaluate_fcurve(curves[2], fra);
-                                       break;
-                               default:
-                                       fprintf(stderr, "%s: animation class %d is not supported yet\n", path, animclass);
-                                       break;
+                                       case COLLADAFW::AnimationList::POSITION_X:
+                                               vec[0] = evaluate_fcurve(curves[0], fra);
+                                               break;
+                                       case COLLADAFW::AnimationList::POSITION_Y:
+                                               vec[1] = evaluate_fcurve(curves[0], fra);
+                                               break;
+                                       case COLLADAFW::AnimationList::POSITION_Z:
+                                               vec[2] = evaluate_fcurve(curves[0], fra);
+                                               break;
+                                       case COLLADAFW::AnimationList::POSITION_XYZ:
+                                               vec[0] = evaluate_fcurve(curves[0], fra);
+                                               vec[1] = evaluate_fcurve(curves[1], fra);
+                                               vec[2] = evaluate_fcurve(curves[2], fra);
+                                               break;
+                                       default:
+                                               fprintf(stderr, "%s: animation class %d is not supported yet\n", path, animclass);
+                                               break;
                                }
                        }
                        else if (type == COLLADAFW::Transformation::MATRIX) {
@@ -1678,18 +1728,21 @@ bool AnimationImporter::evaluate_animation(COLLADAFW::Transformation *tm, float
                                COLLADABU::Math::Matrix4 matrix;
                                int i = 0, j = 0;
 
-                               for (std::vector<FCurve*>::iterator it = curves.begin(); it != curves.end(); it++) {
+                               for (std::vector<FCurve *>::iterator it = curves.begin(); it != curves.end(); it++) {
                                        matrix.setElement(i, j, evaluate_fcurve(*it, fra));
                                        j++;
                                        if (j == 4) {
                                                i++;
                                                j = 0;
                                        }
+                                       unused_curves.erase(std::remove(unused_curves.begin(), unused_curves.end(), *it), unused_curves.end());
                                }
 
                                COLLADAFW::Matrix tm(matrix);
                                dae_matrix_to_mat4(&tm, mat);
 
+                               std::vector<FCurve *>::iterator it;
+
                                return true;
                        }
                }
@@ -1715,7 +1768,7 @@ void AnimationImporter::get_joint_rest_mat(float mat[4][4], COLLADAFW::Node *roo
 
                calc_joint_parent_mat_rest(par, NULL, root, node);
                get_node_mat(m, node, NULL, NULL);
-               mul_m4_m4m4(mat, m, par);
+               mult_m4_m4m4(mat, par, m);
        }
 }
 
@@ -1734,7 +1787,7 @@ bool AnimationImporter::calc_joint_parent_mat_rest(float mat[4][4], float par[4]
                if (par) {
                        float temp[4][4];
                        get_node_mat(temp, node, NULL, NULL);
-                       mul_m4_m4m4(m, temp, par);
+                       mult_m4_m4m4(m, par, temp);
                }
                else {
                        get_node_mat(m, node, NULL, NULL);
@@ -1754,16 +1807,14 @@ bool AnimationImporter::calc_joint_parent_mat_rest(float mat[4][4], float par[4]
 Object *AnimationImporter::get_joint_object(COLLADAFW::Node *root, COLLADAFW::Node *node, Object *par_job)
 {
        if (joint_objects.find(node->getUniqueId()) == joint_objects.end()) {
-               Object *job = add_object(scene, OB_EMPTY);
+               Object *job = bc_add_object(scene, OB_EMPTY, (char *)get_joint_name(node));
 
-               rename_id((ID*)&job->id, (char*)get_joint_name(node));
-
-               job->lay = object_in_scene(job, scene)->lay = 2;
+               job->lay = BKE_scene_base_find(scene, job)->lay = 2;
 
                mul_v3_fl(job->size, 0.5f);
                job->recalc |= OB_RECALC_OB;
 
-               verify_adt_action((ID*)&job->id, 1);
+               verify_adt_action((ID *)&job->id, 1);
 
                job->rotmode = ROT_MODE_QUAT;
 
@@ -1774,7 +1825,7 @@ Object *AnimationImporter::get_joint_object(COLLADAFW::Node *root, COLLADAFW::No
                        float temp[4][4], ipar[4][4];
                        invert_m4_m4(ipar, par_job->obmat);
                        copy_m4_m4(temp, mat);
-                       mul_m4_m4m4(mat, temp, ipar);
+                       mult_m4_m4m4(mat, ipar, temp);
                }
 
                TransformBase::decompose(mat, job->loc, NULL, job->quat, job->size);
@@ -1786,7 +1837,7 @@ Object *AnimationImporter::get_joint_object(COLLADAFW::Node *root, COLLADAFW::No
                        job->parsubstr[0] = 0;
                }
 
-               where_is_object(scene, job);
+               BKE_object_where_is_calc(scene, job);
 
                // after parenting and layer change
                DAG_scene_sort(CTX_data_main(C), scene);
@@ -1807,7 +1858,7 @@ bool AnimationImporter::evaluate_joint_world_transform_at_frame(float mat[4][4],
        if (par) {
                float temp[4][4];
                evaluate_transform_at_frame(temp, node, node == end ? fra : 0.0f);
-               mul_m4_m4m4(m, temp, par);
+               mult_m4_m4m4(m, par, temp);
        }
        else {
                evaluate_transform_at_frame(m, node, node == end ? fra : 0.0f);
@@ -1835,12 +1886,12 @@ void AnimationImporter::add_bone_fcurve(Object *ob, COLLADAFW::Node *node, FCurv
        bAction *act = ob->adt->action;
                        
        /* try to find group */
-       bActionGroup *grp = action_groups_find_named(act, bone_name);
+       bActionGroup *grp = BKE_action_group_find_name(act, bone_name);
 
        /* no matching groups, so add one */
        if (grp == NULL) {
                /* Add a new group, and make it active */
-               grp = (bActionGroup*)MEM_callocN(sizeof(bActionGroup), "bActionGroup");
+               grp = (bActionGroup *)MEM_callocN(sizeof(bActionGroup), "bActionGroup");
                                        
                grp->flag = AGRP_SELECTED;
                BLI_strncpy(grp->name, bone_name, sizeof(grp->name));
@@ -1858,16 +1909,12 @@ void AnimationImporter::add_bezt(FCurve *fcu, float fra, float value)
        //float fps = (float)FPS;
        BezTriple bez;
        memset(&bez, 0, sizeof(BezTriple));
-       bez.vec[1][0] = fra ;
+       bez.vec[1][0] = fra;
        bez.vec[1][1] = value;
-       bez.ipo = BEZT_IPO_LIN ;/* use default interpolation mode here... */
+       bez.ipo = BEZT_IPO_LIN/* use default interpolation mode here... */
        bez.f1 = bez.f2 = bez.f3 = SELECT;
        bez.h1 = bez.h2 = HD_AUTO;
        insert_bezt_fcurve(fcu, &bez, 0);
        calchandles_fcurve(fcu);
 }
 
-void AnimationImporter::extra_data_importer(std::string elementName )
-{
-
-}