Fix T39799: Backdrop (compositor) ignores alpha.
authorLukas Tönne <lukas.toenne@gmail.com>
Fri, 25 Apr 2014 10:00:35 +0000 (12:00 +0200)
committerLukas Tönne <lukas.toenne@gmail.com>
Fri, 25 Apr 2014 10:05:23 +0000 (12:05 +0200)
commit005dabbd9ad51b75aef260168c81d5a826d4eb4f
treecf65862b2f2f685cc587c80b7311bd87f87d6962
parent1eb13519768f5735c9931fec0da07d92155796f1
Fix T39799: Backdrop (compositor) ignores alpha.

This issue is because of a somewhat "special" behavior in old code, which got lost during rB09874df:

There was a variant of the `relinkConnections` function which would leave the socket completely unconnected. This is not a valid state really (given that each unconnected input must otherwise connected to a constant `Set` type node), but was used as a way to distinguish connected alpha/depth sockets in composite and viewer output nodes.
https://developer.blender.org/diffusion/B/browse/master/source/blender/compositor/intern/COM_InputSocket.cpp;28a829893c702918afc5ac1945a06eaefa611594$69

After the large cleanup patch ({D309}) every socket is now automatically connected to a constant, such that `getInputSocketReader` will never return a NULL pointer. This breaks the previous test method, which needs to be replaced by more explicit flags. Luckily this was done only for very few output nodes (Composite, Viewer, Output-File). These now use the regular SetValueOperation default in case "use alpha" is disabled, but set this to an explicit 1.0 value instead of mapping to the node socket.
12 files changed:
source/blender/compositor/intern/COM_NodeConverter.cpp
source/blender/compositor/intern/COM_NodeConverter.h
source/blender/compositor/intern/COM_NodeOperationBuilder.cpp
source/blender/compositor/nodes/COM_CompositorNode.cpp
source/blender/compositor/nodes/COM_OutputFileNode.cpp
source/blender/compositor/nodes/COM_ViewerNode.cpp
source/blender/compositor/operations/COM_CompositorOperation.cpp
source/blender/compositor/operations/COM_CompositorOperation.h
source/blender/compositor/operations/COM_OutputFileOperation.cpp
source/blender/compositor/operations/COM_OutputFileOperation.h
source/blender/compositor/operations/COM_ViewerOperation.cpp
source/blender/compositor/operations/COM_ViewerOperation.h