Cleanup/refactor binding code for MeshDeform modifier.
authorBastien Montagne <montagne29@wanadoo.fr>
Fri, 7 Dec 2018 10:17:25 +0000 (11:17 +0100)
committerBastien Montagne <montagne29@wanadoo.fr>
Fri, 7 Dec 2018 10:22:31 +0000 (11:22 +0100)
commit989fbff16f49204ca31a67f56f87c2221e0246f4
treeee4109fb816cd7d23a3dd8900d6482166b485b81
parent41e4059f3c41234016dfabf6b3ae9e40c735483e
Cleanup/refactor binding code for MeshDeform modifier.

We had two different ways of doing it, SurfaceDeform and LaplacianDeform
would do it through a special modifier stack evaluation triggered from
binding operator, while MeshDeform would do it through a regular
depsgraph update/eval (also triggered from its binding op).

This enforces the later to search back for orig modifier data inside
modifier code (to apply binding on that one, and not on useless CoW
one).

Besides the question of safety about modifying orig data from threaded
despgraph (that was *probably* OK, but think it's bad idea in general),
it's much better to have a common way of doing that kind of things.

For now it remains rather dodgy, but at least it's reasonably consistent
and safe now.

This commit also fixes a potential memleak from binding process of
MeshDeform, and does some general cleanup a bit.
source/blender/editors/armature/meshlaplacian.c
source/blender/editors/include/ED_armature.h
source/blender/editors/object/object_modifier.c
source/blender/makesdna/DNA_modifier_types.h
source/blender/modifiers/intern/MOD_meshdeform.c
source/blender/modifiers/intern/MOD_surfacedeform.c