Fix lock release deadlock when acquiring pass with no data ready yet
authorSergey Sharybin <sergey.vfx@gmail.com>
Sun, 24 Jan 2016 20:25:52 +0000 (01:25 +0500)
committerSergey Sharybin <sergey.vfx@gmail.com>
Sun, 24 Jan 2016 20:25:52 +0000 (01:25 +0500)
commitd631252109bea2e69dae67686b1b8611b52a670d
tree1a6db70fe925bc4e5dcc9f4fc78f712fd613b440
parenta224ee00f5593bb4cce4beb3803eddfc05e82a6a
Fix lock release deadlock when acquiring pass with no data ready yet

There is no reason to do separate image buffer release when there's
found buffer but with empty rects because of the following reasons:

- All the acquire() calls are followed with corresponding release()
  calls, regardless of whether image buffer was empty, missing or
  whatever.

- It was done wrong -- since lock was passed as NULL, it'll only
  de-reference the image buffer itself, this causes following:

  * Wrong user counter since there'll subsequent release() call with
    the proper lock passed to it.
  * Global locks are to be released prior to the spin locks,
    and such an extra release violated this rule.
source/blender/editors/space_image/image_edit.c