Cleanup: fix compiler warnings.
authorBrecht Van Lommel <brechtvanlommel@gmail.com>
Thu, 18 Oct 2018 10:19:06 +0000 (12:19 +0200)
committerBrecht Van Lommel <brechtvanlommel@gmail.com>
Thu, 18 Oct 2018 10:19:06 +0000 (12:19 +0200)
source/blender/editors/gizmo_library/gizmo_types/dial3d_gizmo.c
source/blender/editors/transform/transform_gizmo_3d.c
source/blender/gpu/intern/gpu_draw.c

index 51a789fee66dab9622aae56f07b73975eb7dabec..c9404721b765e91819c18173560cef7e06efd08c 100644 (file)
@@ -334,7 +334,7 @@ static void dial_ghostarc_draw_with_helplines(
 }
 
 static void dial_draw_intern(
-        const bContext *C, wmGizmo *gz,
+        wmGizmo *gz,
         const bool select, const bool highlight, float clip_plane[4])
 {
        float matrix_final[4][4];
@@ -403,7 +403,7 @@ static void gizmo_dial_draw_select(const bContext *C, wmGizmo *gz, int select_id
        }
 
        GPU_select_load_id(select_id);
-       dial_draw_intern(C, gz, true, false, clip_plane);
+       dial_draw_intern(gz, true, false, clip_plane);
 
        if (clip_plane) {
                glDisable(GL_CLIP_DISTANCE0);
@@ -428,7 +428,7 @@ static void gizmo_dial_draw(const bContext *C, wmGizmo *gz)
        }
 
        GPU_blend(true);
-       dial_draw_intern(C, gz, false, is_highlight, clip_plane);
+       dial_draw_intern(gz, false, is_highlight, clip_plane);
        GPU_blend(false);
 }
 
index 480fe3429e04b25bfb1692af891260e7568dec6b..b2efdcf51cd8029fd552ae6c89ab8e72c61aa8d6 100644 (file)
@@ -1262,11 +1262,11 @@ void drawDial3d(const TransInfo *t)
                                axis_idx = MAN_AXIS_ROT_Y;
                                negate_v3_v3(mat_basis[2], tc->mtx[1]);
                        }
-                       else if (tc->mode &  CON_AXIS2) {
+                       else {
+                               BLI_assert((tc->mode & CON_AXIS2) != 0);
                                axis_idx = MAN_AXIS_ROT_Z;
                                negate_v3_v3(mat_basis[2], tc->mtx[2]);
                        }
-                       else BLI_assert(0);
                }
                else {
                        axis_idx = MAN_AXIS_ROT_C;
index 685b929ac934f6bf6e5675a76f47cf6f3566957d..417800330119275b6469e4c494c00bf5fe052dc7 100644 (file)
@@ -1028,7 +1028,7 @@ static GPUTexture *create_density_texture(SmokeDomainSettings *sds, int highres)
 
        GPUTexture *tex = GPU_texture_create_nD(
                       dim[0], dim[1], dim[2], 3,
-                      (data) ? data : source,
+                      (has_color) ? data : source,
                       format, GPU_DATA_FLOAT, 0, true, NULL);
        if (data) {
                MEM_freeN(data);