Cleanup: remove unused text.selection_set select option
authorCampbell Barton <ideasman42@gmail.com>
Sun, 24 Nov 2019 11:04:50 +0000 (22:04 +1100)
committerCampbell Barton <ideasman42@gmail.com>
Sun, 24 Nov 2019 11:05:59 +0000 (22:05 +1100)
This was meant to set the selection end instead of the cursor
however it hasn't been working for years and seems quite obscure.

release/scripts/presets/keyconfig/keymap_data/blender_default.py
release/scripts/presets/keyconfig/keymap_data/industry_compatible_data.py
source/blender/editors/space_text/text_ops.c

index cc4e3e269ed7a8c3e31e60d09acd045c806cd8ee..3a7a142e310edc225cdeee4ad19a73cde6c7e00a 100644 (file)
@@ -2293,8 +2293,6 @@ def km_text(params):
         ("text.scroll", {"type": 'TRACKPADPAN', "value": 'ANY'}, None),
         ("text.selection_set", {"type": 'EVT_TWEAK_L', "value": 'ANY'}, None),
         ("text.cursor_set", {"type": 'LEFTMOUSE', "value": 'PRESS'}, None),
-        ("text.selection_set", {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True},
-         {"properties": [("select", True)]}),
         ("text.scroll", {"type": 'WHEELUPMOUSE', "value": 'PRESS'},
          {"properties": [("lines", -1)]}),
         ("text.scroll", {"type": 'WHEELDOWNMOUSE', "value": 'PRESS'},
index 7d8ada2d117cc196da0129abbe5542901867e800..dc62b6bba686f7afffa98b6f9a54acc39ec1e03a 100644 (file)
@@ -1655,8 +1655,6 @@ def km_text(params):
         ("text.scroll", {"type": 'TRACKPADPAN', "value": 'ANY'}, None),
         ("text.selection_set", {"type": 'EVT_TWEAK_L', "value": 'ANY'}, None),
         ("text.cursor_set", {"type": 'LEFTMOUSE', "value": 'PRESS'}, None),
-        ("text.selection_set", {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True},
-         {"properties": [("select", True)]}),
         ("text.scroll", {"type": 'WHEELUPMOUSE', "value": 'PRESS'},
          {"properties": [("lines", -1)]}),
         ("text.scroll", {"type": 'WHEELDOWNMOUSE', "value": 'PRESS'},
index 8a57b57850011ec4cfea62e782c88d7147b5311d..842570459bec8d7f90428306fc09f8036f42df5d 100644 (file)
@@ -3234,7 +3234,6 @@ static int text_selection_set_invoke(bContext *C, wmOperator *op, const wmEvent
 
   op->customdata = MEM_callocN(sizeof(SetSelection), "SetCursor");
   ssel = op->customdata;
-  ssel->selecting = RNA_boolean_get(op->ptr, "select");
 
   ssel->mval_prev[0] = event->mval[0];
   ssel->mval_prev[1] = event->mval[1];
@@ -3283,9 +3282,6 @@ void TEXT_OT_selection_set(wmOperatorType *ot)
   ot->modal = text_selection_set_modal;
   ot->cancel = text_selection_set_cancel;
   ot->poll = text_region_edit_poll;
-
-  /* properties */
-  RNA_def_boolean(ot->srna, "select", 0, "Select", "Set selection end rather than cursor");
 }
 
 /** \} */