8 years agopatch [#34103] use booleans for extensions testing.
Campbell Barton [Mon, 4 Mar 2013 18:36:37 +0000 (18:36 +0000)]
patch [#34103] use booleans for extensions testing.
bli_testextensie.patch - from Lawrence D'Oliveiro (ldo)

8 years agoFix for incorrect subpixel precision of marker when using track offset
Sergey Sharybin [Mon, 4 Mar 2013 18:30:48 +0000 (18:30 +0000)]
Fix for incorrect subpixel precision of marker when using track offset

Issue was caused by the way how pattern sampling happens in case of
anchored display: track offset is applying on search buffer which
means offset is rounding to an integer. Fractional pat of offset was
completely ignoring which lead to jumps in pattern buffer.

This was only a visualization issue in track preview widget.

8 years agoBugfix
Ton Roosendaal [Mon, 4 Mar 2013 17:06:16 +0000 (17:06 +0000)]

For 2.66a

Allow trackpad and magic mouse swipes to control brush size for circle select.
(Similar to mousewheel).

8 years agoFix for texture preview render with show alpha enabled, now it shows no
Brecht Van Lommel [Mon, 4 Mar 2013 16:37:05 +0000 (16:37 +0000)]
Fix for texture preview render with show alpha enabled, now it shows no
transparency when use alpha and calculate alpha are disabled.

It's a bit arbitrary as it's not possible to fully visualize the output
of a texture, that depends on how it's used in the texture stack, but this
is a bit more in line with what you might expect.

8 years agoAvoid clearing the depth buffer when using full screen quads for
Antony Riakiotakis [Mon, 4 Mar 2013 16:34:37 +0000 (16:34 +0000)]
Avoid clearing the depth buffer when using full screen quads for

8 years agoChange default margin for bake to 16 pixels
Antony Riakiotakis [Mon, 4 Mar 2013 15:58:40 +0000 (15:58 +0000)]
Change default margin for bake to 16 pixels

8 years agopatch [#34525] Scons ' color
Campbell Barton [Mon, 4 Mar 2013 13:59:54 +0000 (13:59 +0000)]
patch [#34525] Scons ' color
by Andrey Izrantsev (bdancer)

8 years agoFix for image transparency backwards compatibility. Now the texture datablock has
Brecht Van Lommel [Mon, 4 Mar 2013 13:18:14 +0000 (13:18 +0000)]
Fix for image transparency backwards compatibility. Now the texture datablock has
a Use Alpha option again. This makes the case where you enabled Premultiply on the
image and disabled Use Alpha on the texture work again.

That's mostly useful when you have a straight alpha image file which has no useful
RGB colors in zero alpha regions (e.g. renders). Then sometimes you don't want to
use the alpha for the texture stack mixing, but you still want to multiply it into
the RGB channels to avoid a blocky transition into zero alpha regions.

This also removes the version patch that copied image datablocks because it's not
reliable and might be causing bug #34434. This does mean we are no longer backwards
compatible for cases where two different texture datablocks with Use Alpha enabled
and disabled where using the same image.

8 years agoFix #34475: Weird noise bug with Texture nodes
Sergey Sharybin [Mon, 4 Mar 2013 13:14:21 +0000 (13:14 +0000)]
Fix #34475: Weird noise bug with Texture nodes

Made Texture compositor input node single-threaded since
texture trees are not thread-safe.

Also fixed texture being flipped horizontally and vertically.
Why nobody noticed this for 3 releases already??

8 years agoCollada: Added ngon support to Vertex Color exporter
Gaia Clary [Mon, 4 Mar 2013 13:12:56 +0000 (13:12 +0000)]
Collada: Added ngon support to Vertex Color exporter

8 years agoFix #34501: Painting on image editor with texture brush causes memory leaks in render...
Sergey Sharybin [Mon, 4 Mar 2013 12:40:24 +0000 (12:40 +0000)]
Fix #34501: Painting on image editor with texture brush causes memory leaks in render module

Issue was caused by svn rev54721 where donequeue wasn't fully handled
in cases rendering was canceled, which lead to some render results

8 years agoOSX/locale: a further cleanup
Jens Verwiebe [Mon, 4 Mar 2013 10:31:01 +0000 (10:31 +0000)]
OSX/locale: a further cleanup

8 years agoBugfix #34493
Ton Roosendaal [Mon, 4 Mar 2013 09:55:43 +0000 (09:55 +0000)]
Bugfix #34493

Should go to 2.66a

Image Sequence texture now allows to animate "Offset" again with fcurves.
This was disabled for 2.65, it only works for fcurve key inserting (not
for drivers), but too many people have been using to animate character
textures already...

8 years agobge bugfix: [#34517] 2D Filter causes mouselook script drifting effect (patch by...
Dalai Felinto [Mon, 4 Mar 2013 08:45:42 +0000 (08:45 +0000)]
bge bugfix: [#34517] 2D Filter causes mouselook script drifting effect (patch by Daniel Stokes - Kupoman)
Fix for 2.66a

""We can't pass the results of canvas->GetViewPort() directly because canvas->SetViewPort() does some extra math""
Bug introduced during 2.65 series in the refactor to use canvas->SetViewPort instead of direct opengl calls for viewport
(53305, 53392, 53393)

8 years agoBGE bug-fix[#34523] 2dfilter produces render error (objects disappear) - likely an...
Dalai Felinto [Mon, 4 Mar 2013 08:22:20 +0000 (08:22 +0000)]
BGE bug-fix[#34523] 2dfilter produces render error (objects disappear) - likely an alpha problem
Fix for 2.66a

With help from Daniel Stokes and Mitchell Stokes.

This bug always existed in OSX, but started showing up in Windows and Linux on review (54745 + 54747)
[the patch to enable alpha buffer for all OSs]

A better fix would be to use RAS_IRasterizer::SetAlphaBlend(GPU_BLEND_SOLID);
but I think gpu_verify_alpha_blend() is not switching to SOLID because
GTS.alphablend is GPU_BLEND_SOLID (even though GL_ALPHA_TEST is enabled).

Anyways, this is not something worth tackling now, since in terms of functionality it shouldn't matter.

8 years agocode cleanup: view3d_clipping_test was making a vector copy for no reason.
Campbell Barton [Mon, 4 Mar 2013 07:15:09 +0000 (07:15 +0000)]
code cleanup: view3d_clipping_test was making a vector copy for no reason.

8 years agofix [#34416] Sculpt with ALT-B affects unseen mesh parts
Campbell Barton [Mon, 4 Mar 2013 07:11:42 +0000 (07:11 +0000)]
fix [#34416] Sculpt with ALT-B affects unseen mesh parts

8 years agofix [#34473] Blender Crashes on toggling modes, dynatopo sculpt/object mode.
Campbell Barton [Mon, 4 Mar 2013 05:25:16 +0000 (05:25 +0000)]
fix [#34473] Blender Crashes on toggling modes, dynatopo sculpt/object mode.

8 years agofix [#34490] Copy and paste floating point number fields losses precision
Campbell Barton [Mon, 4 Mar 2013 04:21:51 +0000 (04:21 +0000)]
fix [#34490] Copy and paste floating point number fields losses precision
- copy now gets up to 6 decimal places
- copy and UI float button editing now strip zeros: 1.000 -> 1.0

8 years agofix [#34369] applying screw modifier turns object to black
Campbell Barton [Mon, 4 Mar 2013 01:57:29 +0000 (01:57 +0000)]
fix [#34369] applying screw modifier turns object to black

8 years agocode cleanup: unused vars in collada, preprocessor formatting & warning in mingw.
Campbell Barton [Mon, 4 Mar 2013 00:53:57 +0000 (00:53 +0000)]
code cleanup: unused vars in collada, preprocessor formatting & warning in mingw.
also compiling without bullet needed a stub added.

8 years agoCollada: Fix: do not export controllers when shape_key exporting is disabled
Gaia Clary [Mon, 4 Mar 2013 00:28:25 +0000 (00:28 +0000)]
Collada: Fix: do not export controllers when shape_key exporting is disabled

8 years agoCollada: Fix export of Normals where shading is set to smooth
Gaia Clary [Mon, 4 Mar 2013 00:17:20 +0000 (00:17 +0000)]
Collada: Fix export of Normals where shading is set to smooth

8 years agoOSX/locale: fix compile on older xcode by not using toll-free-bridging, which needs ARC
Jens Verwiebe [Sun, 3 Mar 2013 20:32:27 +0000 (20:32 +0000)]
OSX/locale: fix compile on older xcode by not using toll-free-bridging, which needs ARC

8 years agoFix for [#34509] minor theme panel color issue
Thomas Dinges [Sun, 3 Mar 2013 17:30:23 +0000 (17:30 +0000)]
Fix for [#34509] minor theme panel color issue
* panelcolors.back and panelcolors.header were missing in resources.c for the 3D View.

8 years agoCleanup, move uv sculpt specific code to sculpt_uv.c. Also rename
Antony Riakiotakis [Sun, 3 Mar 2013 16:33:39 +0000 (16:33 +0000)]
Cleanup, move uv sculpt specific code to sculpt_uv.c. Also rename
brush_drawcursor to a more indicative of its users name until paint
cursor unification is done.

8 years agoFix #34508: particle emitter show/hide option did not work correct after
Brecht Van Lommel [Sun, 3 Mar 2013 15:07:18 +0000 (15:07 +0000)]
Fix #34508: particle emitter show/hide option did not work correct after
recent bugfix.

8 years agoCollada: exported normals now based on MPoly instead of MFace
Gaia Clary [Sun, 3 Mar 2013 13:53:32 +0000 (13:53 +0000)]
Collada: exported normals now based on MPoly instead of MFace

8 years agorigidbody: Revert to running simulation on frame update
Sergej Reich [Sun, 3 Mar 2013 06:09:48 +0000 (06:09 +0000)]
rigidbody: Revert to running simulation on frame update

Instead of flagging the rigid body world for frame update just call
BKE_rigidbody_do_simulation() recursively for all scenes.

This avoids having to constantly check if the simulation needs to be

8 years agorigidbody: Fix inconsistency with world rebuilding
Sergej Reich [Sun, 3 Mar 2013 06:09:45 +0000 (06:09 +0000)]
rigidbody: Fix inconsistency with world rebuilding

The rigid body world could be rebuilt on start frame and one frame after
start frame. The latter was necessary sice animation playback usually
doesn't start at start frame.
This lead to different simulations depending on which frame the
simulaton was rebuilt when animation was involved.

Now we only rebuild the world on start frame.
This is actually tricky to do since, as mentioned above, animation
playback starts on second frame. To work around this we rebuild the
world before the actual update.
The alternative would be to rebuld the world on every simulation change
(like the other simulations do it) but this is an expensive operation
and would be too slow.

8 years agocode cleanup: de-duplicate cast modifier logic, had 'optimization' which was only...
Campbell Barton [Sun, 3 Mar 2013 05:43:47 +0000 (05:43 +0000)]
code cleanup: de-duplicate cast modifier logic, had 'optimization' which was only saving a NULL check per loop, causing most of the logic to be copied, ~130 lines.

8 years agocode cleanup: ~400 duplicate lines for AO form factor math.
Campbell Barton [Sun, 3 Mar 2013 05:07:58 +0000 (05:07 +0000)]
code cleanup: ~400 duplicate lines for AO form factor math.

8 years agocode cleanup: de-duplicate ~75 lines copied twice - tsk tsk.
Campbell Barton [Sun, 3 Mar 2013 04:54:33 +0000 (04:54 +0000)]
code cleanup: de-duplicate ~75 lines copied twice - tsk tsk.

8 years agomove toggle drag into a UI handler (was modal operator)
Campbell Barton [Sun, 3 Mar 2013 03:29:57 +0000 (03:29 +0000)]
move toggle drag into a UI handler (was modal operator)

8 years agoenable triangulation with collada, disable BLI_STATIC_ASSERT for C++.
Campbell Barton [Sun, 3 Mar 2013 01:24:09 +0000 (01:24 +0000)]
enable triangulation with collada, disable BLI_STATIC_ASSERT for C++.

8 years agopartial revert of collada triangulation code due to problems on linux
Gaia Clary [Sat, 2 Mar 2013 23:42:03 +0000 (23:42 +0000)]
partial revert of collada triangulation code due to problems on linux

8 years agoOSX: Get the current locale in objC-style
Jens Verwiebe [Sat, 2 Mar 2013 22:50:46 +0000 (22:50 +0000)]
OSX: Get the current locale in objC-style

8 years agoFix Collada build error in scons
Gaia Clary [Sat, 2 Mar 2013 20:46:37 +0000 (20:46 +0000)]
Fix Collada build error in scons

8 years agoBGE: Fix for bugs #34428, #20856, #20281. These were all multi-uv bugs caused by...
Mitchell Stokes [Sat, 2 Mar 2013 18:05:52 +0000 (18:05 +0000)]
BGE: Fix for bugs #34428, #20856, #20281. These were all multi-uv bugs caused by the BGE keeping too much uv information. When setting up shaders the BGE assumes each UV layer is unique, but the converter would store duplicates.

8 years agofix [#34431] Crash with 2.66 when dyntopo enabled and using view plane mode
Campbell Barton [Sat, 2 Mar 2013 16:13:01 +0000 (16:13 +0000)]
fix [#34431] Crash with 2.66 when dyntopo enabled and using view plane mode

8 years agoCollada: Added support for ngon export/import and added triangulate option to export
Gaia Clary [Sat, 2 Mar 2013 15:58:13 +0000 (15:58 +0000)]
Collada: Added support for ngon export/import and added triangulate option to export

8 years agofix [#34486] Selection of bones in armature edit mode only toggles between two bones
Campbell Barton [Sat, 2 Mar 2013 15:34:47 +0000 (15:34 +0000)]
fix [#34486] Selection of bones in armature edit mode only toggles between two bones

8 years agoAdded typecasts to keep c++ from reporting errors
Gaia Clary [Sat, 2 Mar 2013 12:16:23 +0000 (12:16 +0000)]
Added typecasts to keep c++ from reporting errors

8 years agonow dragging an image onto an empty can be done without holding Ctrl.
Campbell Barton [Sat, 2 Mar 2013 12:05:25 +0000 (12:05 +0000)]
now dragging an image onto an empty can be done without holding Ctrl.
Make it set the empty draw type for existing empty object.
change from yakca on IRC

also some whitespace cleanup.

8 years agocode cleanup: clarify comment about virtial-modifiers, also add comments to DNA heade...
Campbell Barton [Sat, 2 Mar 2013 07:27:19 +0000 (07:27 +0000)]
code cleanup: clarify comment about virtial-modifiers, also add comments to DNA headers when its not so obvious what their purpose is.

8 years agoFix #34483: game engine multi UV glsl materials not working correct after changes
Brecht Van Lommel [Fri, 1 Mar 2013 20:45:42 +0000 (20:45 +0000)]
Fix #34483: game engine multi UV glsl materials not working correct after changes
to support more than 2 UV maps. This code indirectly depended on the order of
OpenGL attribute ID's assigned by the OpenGL driver being the same as the
attributes being declared in the GLSL shader code, which is not always the case.

8 years agoUI / World Units:
Thomas Dinges [Fri, 1 Mar 2013 19:15:32 +0000 (19:15 +0000)]
UI / World Units:
* Consistency tweak: for properties based on an enum, we hide the buttons and do not grey out.
Greying out is for properties based on a boolean.

8 years agoUI / Properties Editor:
Thomas Dinges [Fri, 1 Mar 2013 19:07:28 +0000 (19:07 +0000)]
UI / Properties Editor:
* Some alignment fixes for Fluid Buttons in the "Fluid" panel.
* Tweaked Fluid Particle buttons a bit, no need to have redundant "Particle" name inside the "Fluid Particles" panel.

8 years ago3D View properties region / Mesh Displays panel:
Thomas Dinges [Fri, 1 Mar 2013 18:45:41 +0000 (18:45 +0000)]
3D View properties region / Mesh Displays panel:
* Made overlays use 2 columns, rather than 1 as suggested by Sebastian K├Ânig in IRC.
* Small tweak to the Normal size button, grey out if unused.

8 years agoBug fix #34418
Ton Roosendaal [Fri, 1 Mar 2013 17:17:57 +0000 (17:17 +0000)]
Bug fix #34418

Fix for 2.66a

Screencast could be started twice in a row, but it then also added two handlers
for drawing an overlay circle around mouse cursor. After ending the screencast,
this circle then kept being drawn.

8 years agoFix #34461: Inconsistent behavior of "Color Mix Node" and "Alpha Over Node"
Sergey Sharybin [Fri, 1 Mar 2013 15:37:15 +0000 (15:37 +0000)]
Fix #34461: Inconsistent behavior of "Color Mix Node" and "Alpha Over Node"

Added compatibility option "Straight Alpha Output" to image input node

When this option is enabled, image input node will convert float buffer
to straight alpha.

This is not what you'll usually want with new alpha pipeline, nit this
is needed to preserve compatibility with older files saved in 2.65.
In that version byte image are resulting with straight alpha passing
to the compositor and alpha-overing required extra premultiplication
of inputs.

So, that's why Straight Alpha Output is needed -- it's set in versioning
code for byte node images so they'll still output straight alpha.

This option is currently only available in N-panel.

Additional change: added Alpha Mode for image input node to N-panel.

8 years agoFix #34480: cycles hair render in dupligroup did hide the emitter properly in some...
Brecht Van Lommel [Fri, 1 Mar 2013 14:55:30 +0000 (14:55 +0000)]
Fix #34480: cycles hair render in dupligroup did hide the emitter properly in some cases.

8 years agostyle cleanup: braces with multi-line statements, also add some comments.
Campbell Barton [Fri, 1 Mar 2013 14:47:06 +0000 (14:47 +0000)]
style cleanup: braces with multi-line statements, also add some comments.

8 years agoMore tweaks (gaining about ten seconds for each po in update branches process!).
Bastien Montagne [Fri, 1 Mar 2013 14:28:38 +0000 (14:28 +0000)]
More tweaks (gaining about ten seconds for each po in update branches process!).

8 years agoFix related to #34481: show units for camera aperature radius.
Brecht Van Lommel [Fri, 1 Mar 2013 14:06:20 +0000 (14:06 +0000)]
Fix related to #34481: show units for camera aperature radius.

8 years agoUpdates to libmv's to make sure libmv upstream
Sergey Sharybin [Fri, 1 Mar 2013 11:52:38 +0000 (11:52 +0000)]
Updates to libmv's to make sure libmv upstream
is copying properly to our sources.

8 years agoBug fix #34334
Ton Roosendaal [Fri, 1 Mar 2013 11:42:07 +0000 (11:42 +0000)]
Bug fix #34334

For 2.66a

Soft shadow was drawing a complete rect, but it should skip the top edge.
That allows transparent menus to still have a shadow too.

8 years agoHrm, gcc became broken after recent commit.
Sergey Sharybin [Fri, 1 Mar 2013 08:56:04 +0000 (08:56 +0000)]
Hrm, gcc became broken after recent commit.
Hope now gcc and 32bit msvc would both work.

8 years agoPass data to modal reprojection cost functor by reference
Sergey Sharybin [Fri, 1 Mar 2013 08:20:13 +0000 (08:20 +0000)]
Pass data to modal reprojection cost functor by reference

Seems it solves alignment error reported by 32bit MSVC.

8 years agokeymap filter by keybindings in the userpreferences.
Campbell Barton [Fri, 1 Mar 2013 06:17:59 +0000 (06:17 +0000)]
keymap filter by keybindings in the userpreferences.
- optional, select between name/keybinding.
- when key input can't be parsed, alert red to give the user some feedback.
- key shortcut parsing could be improved or swapped out for button which grabs shortcut.

8 years agofix for drag-toggle, bit-buttons weren't handled which made drag toggle fail for...
Campbell Barton [Fri, 1 Mar 2013 00:35:01 +0000 (00:35 +0000)]
fix for drag-toggle, bit-buttons weren't handled which made drag toggle fail for buttons in the graph editor for eg.

8 years agocode cleanup: minor refactor of button pressed state checking, needed for drag toggle...
Campbell Barton [Fri, 1 Mar 2013 00:19:32 +0000 (00:19 +0000)]
code cleanup: minor refactor of button pressed state checking, needed for drag toggle fix.

8 years agoFix / Workaround for [#34474] "Record Composite" image op segfaults in compositor...
Thomas Dinges [Thu, 28 Feb 2013 22:50:24 +0000 (22:50 +0000)]
Fix / Workaround for [#34474] "Record Composite" image op segfaults in compositor code
* These operators have never been ported to 2.5x and therefore should not come up inside the UI. (as they are not working).

8 years agoFix/workaround for newer FFmpeg 1.1.3 and MP3 decoder
Sergey Sharybin [Thu, 28 Feb 2013 18:28:08 +0000 (18:28 +0000)]
Fix/workaround for newer FFmpeg 1.1.3 and MP3 decoder

FFmpeg is now using S16P sampler for MP3 which is not actually
supported by audaspace, so request for S16 sampler instead.

8 years agoFix own regression in commit from today -- missing NULL check
Sergey Sharybin [Thu, 28 Feb 2013 17:23:44 +0000 (17:23 +0000)]
Fix own regression in commit from today -- missing NULL check

Crash happened when sequence image failed to load.

8 years agoUI/DPI: user preferences window size now takes into account DPI, otherwise the
Brecht Van Lommel [Thu, 28 Feb 2013 16:37:19 +0000 (16:37 +0000)]
UI/DPI: user preferences window size now takes into account DPI, otherwise the
buttons don't fit properly.

8 years agoFix #34366: mesh.select_mode operator could not be configure the use_extend
Brecht Van Lommel [Thu, 28 Feb 2013 16:37:18 +0000 (16:37 +0000)]
Fix #34366: mesh.select_mode operator could not be configure the use_extend
and use_expand properly. These are hardcoded to shift and ctrl to make them
work when clicking buttons or menus. Now it checks if the properties are set,
which is still not ideal but makes it possible to override them from the
key configuration.

8 years agoFix #34372: mesh.verts.foreach_set not working with normals, regression due to my
Brecht Van Lommel [Thu, 28 Feb 2013 16:37:15 +0000 (16:37 +0000)]
Fix #34372: mesh.verts.foreach_set not working with normals, regression due to my
bugfix for multidimensional arrays.

8 years agoFix #34390: quicktime video codec menu showing blank. It's a small miracle
Brecht Van Lommel [Thu, 28 Feb 2013 15:33:29 +0000 (15:33 +0000)]
Fix #34390: quicktime video codec menu showing blank. It's a small miracle
that this code worked at all at some point.

8 years agoFix #34414: python error with frame_change callback and Cycles motion blur.
Brecht Van Lommel [Thu, 28 Feb 2013 15:33:26 +0000 (15:33 +0000)]
Fix #34414: python error with frame_change callback and Cycles motion blur.
Now the RenderEngine.render callback allows writing blender data again, it
should not be allowed but in practice the API and render threading code is
too limited to make this work at the moment.

8 years agoMore UI messages fixes...
Bastien Montagne [Thu, 28 Feb 2013 15:31:20 +0000 (15:31 +0000)]
More UI messages fixes...

8 years agoHeader cleanup in libmv c-api
Sergey Sharybin [Thu, 28 Feb 2013 14:25:40 +0000 (14:25 +0000)]
Header cleanup in libmv c-api

8 years agoThis lines are also not so much useful for now.
Sergey Sharybin [Thu, 28 Feb 2013 14:25:33 +0000 (14:25 +0000)]
This lines are also not so much useful for now.

8 years agoChanged a way how RGB images are saving from RGBA
Sergey Sharybin [Thu, 28 Feb 2013 14:25:26 +0000 (14:25 +0000)]
Changed a way how RGB images are saving from RGBA

Before alpha channel was simply ignored causing bad looking
straight colors which is pretty much useless.

Now saving RGB would alpha-over image on top of black color,
which makes final image look really nice. It's also very
such the same what other graphics software does this.

In the future we could easily support configurable backdrop
color, which would be really the same as other SW does it.

Also, it'll probably worth adding the same mode to RGB
display of image editor.

8 years agoDraw a checker board as a background for animation player
Sergey Sharybin [Thu, 28 Feb 2013 14:25:18 +0000 (14:25 +0000)]
Draw a checker board as a background for animation player

This makes it easier and useful to investigate alpha channels,
without this straight colors are displayed on the screen which
are completely useless in case of player.

8 years agoFix sequencer crash when pasteing strips after creating new file
Sergey Sharybin [Thu, 28 Feb 2013 14:25:09 +0000 (14:25 +0000)]
Fix sequencer crash when pasteing strips after creating new file

Issue happened for scene. movie clip and mask strips, which contains
pointers to datablocks which are freeing on loading new file.

Also, scene strip would crash when pasted from clipboard after scene
was unlinked from file.

8 years agoFix memory leak when loading multilayer EXR as movie clip
Sergey Sharybin [Thu, 28 Feb 2013 14:25:00 +0000 (14:25 +0000)]
Fix memory leak when loading multilayer EXR as movie clip

Such kind of image sequences wouldn't be displayed still
and supporting them would take some additional time, but
for now it'll be no memory leak on attempt opening such

8 years agoRemove unused rigid registration code
Sergey Sharybin [Thu, 28 Feb 2013 14:24:52 +0000 (14:24 +0000)]
Remove unused rigid registration code

There're some features planned which would
require rigid registration, but this code
would need to be re-done anyway to use new
minimizer and solving some issues with ICP
algorithm there.

8 years agoModal (aka tripod) solver rework
Sergey Sharybin [Thu, 28 Feb 2013 14:24:42 +0000 (14:24 +0000)]
Modal (aka tripod) solver rework

Several major things are done in this commit:

- First of all, logic of modal solver was changed.
  We do not rely on only minimizer to take care of
  guessing rotation for frame, but we're using
  analytical rotation computation for point clouds
  to obtain initial rotation.

  Then this rotation is being refined using Ceres
  minimizer and now instead of minimizing average
  distance between points of point of two clouds,
  minimization of reprojection error of point
  cloud onto frame happens.

  This gives quite a bit of precision improvement.

- Second bigger improvement here is using bundle
  adjustment for a result of first step when we're
  only estimating rotation between neighbor images
  and reprojecting markers.

  This averages error across the image sequence
  avoiding error accumulation. Also, this will
  tweak bundles themselves a bit for better match.

- And last bigger improvement here is support of
  camera intrinsics refirenment.

  This allowed to significantly improve solution
  for real-life footage and results after such
  refining are much more usable than it were before.

Thanks to Keir for the help and code review.

8 years agoIncrease verbosity level for reprojected markers info
Sergey Sharybin [Thu, 28 Feb 2013 14:24:25 +0000 (14:24 +0000)]
Increase verbosity level for reprojected markers info

This information is useful, but in cases when you, say,
working on a bundler it's annoying to scroll all the
information up.

Now behavior would be:
- running `./blender --debug-libmv` will print all the
  debug messages
- running `./blender --debug-libmv --verbose 0` will
  print only debug messages from solvers, recosntruction
  and so, but will bypass final reprojection bunch of
- running `./blender --debug-lib,v --verbose 1` will
  include final reprojection messages.

8 years agoMove radial distortion code to own templated function
Sergey Sharybin [Thu, 28 Feb 2013 14:24:17 +0000 (14:24 +0000)]
Move radial distortion code to own templated function

This shall not lead to any functional changes, just
avoids radial distortion code duplicated in camera
intrinsics and bundling code.

For fancier bundle adjustment supprting different
distortion models this is not actually enough and
would need to make some bigger changes, but this
changes makes code a bit easier to maintain already.

8 years agofix [#33466] alt + mouse wheel
Campbell Barton [Thu, 28 Feb 2013 11:39:13 +0000 (11:39 +0000)]
fix [#33466] alt + mouse wheel

Alt+Mouse Wheel events depended on the button under the mouse being active, else it would change the current frame.
Button re-activation wasn't 100% reliable since it depends on fake mousemove events.

Now keep button active when its executed if the mouse stays over it.

8 years agofix for harmless glitch rotating the camera in camera mode, having the center point...
Campbell Barton [Thu, 28 Feb 2013 11:29:27 +0000 (11:29 +0000)]
fix for harmless glitch rotating the camera in camera mode, having the center point so close to the viewpoint caused the helper line to erratically move about because of float precision.

8 years agoLocDiff Driver Vars: Red-Alert is not needed on the space-selectors
Joshua Leung [Thu, 28 Feb 2013 11:00:06 +0000 (11:00 +0000)]
LocDiff Driver Vars: Red-Alert is not needed on the space-selectors

8 years agoBugfix: Invalid target tagging for "Distance" driver variable type only
Joshua Leung [Thu, 28 Feb 2013 10:50:13 +0000 (10:50 +0000)]
Bugfix: Invalid target tagging for "Distance" driver variable type only
highlighted the first target if/when both targets were empty.

8 years agoBugfix: Types mismatch (flags and targetFlags were ints, but dtar->flag is a
Joshua Leung [Thu, 28 Feb 2013 10:27:04 +0000 (10:27 +0000)]
Bugfix: Types mismatch (flags and targetFlags were ints, but dtar->flag is a

8 years agoInvalid Driver Targets are now indicated appropriately (using Red Backgrounds)
Joshua Leung [Thu, 28 Feb 2013 07:13:33 +0000 (07:13 +0000)]
Invalid Driver Targets are now indicated appropriately (using Red Backgrounds)
in the UI

This is the second part of the fixes for [#32492], making it easier to identify
which part of a driver (i.e. which of its targets) is causing problems

A number of additional/related changes needed to be made:
* Red-alert status for layouts is now propagated down to child layouts when they
are created. This is needed as otherwise some of the templates used in the Graph
Editor driver settings won't actually get the red-alert status flushed down to
them. Also, note that this status needs to be set before any widgets are added
to the layout, or else the settings aren't applied when the relevant widgets get

* "Single Property" RNA-Paths resulting in out of bounds array access will now
trigger an error status and appropriate warnings

* The error tagging doesn't get applied immediately after variables are created,
or their types changed
* There was also some other weirdness involved when a higher-value flag (1<<10)
was used for this setting, which needs further attention

8 years agofix [#34426] Manipulator handles drawn incorrectly by depth
Campbell Barton [Thu, 28 Feb 2013 06:12:06 +0000 (06:12 +0000)]
fix [#34426] Manipulator handles drawn incorrectly by depth
original patch by Philipp Oeser (lichtwerk) with own changes.

8 years agorst doc update: adding a link to Joystick class from bge.logic.joysticks
Dalai Felinto [Thu, 28 Feb 2013 05:18:47 +0000 (05:18 +0000)]
rst doc update: adding a link to Joystick class from bge.logic.joysticks
(so one can find more about the joystick class without having to search joystick)
code untested by the way. Sorry but I can no longer build sphinx docs here. I will try to fix that later.

8 years agofix for bmesh regression similar to last revision r54920. only effected loading old...
Campbell Barton [Thu, 28 Feb 2013 04:18:01 +0000 (04:18 +0000)]
fix for bmesh regression similar to last revision r54920. only effected loading old blend files without edge data.

8 years agofix for regression since BMesh merge, selecting linked faces in face-mask mode was...
Campbell Barton [Thu, 28 Feb 2013 03:39:41 +0000 (03:39 +0000)]
fix for regression since BMesh merge, selecting linked faces in face-mask mode was using an incorrect lookup on loops which made select-linked fail

8 years agocode cleanup: includes
Campbell Barton [Thu, 28 Feb 2013 01:28:46 +0000 (01:28 +0000)]
code cleanup: includes

8 years agofix for linking with recent armature refactor, was also missing file from CMakeLists...
Campbell Barton [Thu, 28 Feb 2013 00:45:07 +0000 (00:45 +0000)]
fix for linking with recent armature refactor, was also missing file from CMakeLists.txt.

8 years agopatch [#34465] Fix text editor bug: Crash when overwriting ascii character with multi...
Campbell Barton [Thu, 28 Feb 2013 00:08:47 +0000 (00:08 +0000)]
patch [#34465] Fix text editor bug: Crash when overwriting ascii character with multibyte character
from Shinsuke Irie (irie)

8 years agoRenaming the remaining PoseMode files for consistency (camelCase to
Joshua Leung [Thu, 28 Feb 2013 00:01:20 +0000 (00:01 +0000)]
Renaming the remaining PoseMode files for consistency (camelCase to

8 years agoProperly prefixing name of exproted armature API
Joshua Leung [Wed, 27 Feb 2013 23:56:51 +0000 (23:56 +0000)]
Properly prefixing name of exproted armature API

8 years agoCode cleanups
Joshua Leung [Wed, 27 Feb 2013 23:50:44 +0000 (23:50 +0000)]
Code cleanups
* Replace magic numbers with enum-defines
* Remove superfluous return; statements (used as last statements in a few
"static void" methods)
* Remove some old unused/commented out stuff

8 years agoCode Maintenance - Splitting up Armature/Pose Editing Files
Joshua Leung [Wed, 27 Feb 2013 23:34:29 +0000 (23:34 +0000)]
Code Maintenance - Splitting up Armature/Pose Editing Files

This commit splits editarmature.c and poseobject.c into several files, such that
certain types of functionality are (mostly) self-contained within particular
files (instead of being mixed in with other functionality in a large file).

In particular, this was done so that:
1) Armature EditMode tools are now in the armature_*.c files only, and Pose Mode
tools in pose_*.c files only.
     - In one or two cases, this hasn't been possible as the two modes rely on
much of the same shared infrastructure.
2) The "clear loc/rot/scale" operators and pose show/hide are no longer housed
in editarmature.c
3) Selection operators, Transform operators, structural (add/delete) operators,
and supporting utilities for the modes (enter/exit/roll-calculations) are not
all interleaved in an ad-hoc manner

* I've tried to ensure that the history of the new files has been maintained by
   svn copy {editarmature.c/poseobject.c} {armature_*.c/pose_*.c}
   Unfortunately, this means that the diffs are a bit messy.
* There should be no functional/logic changes here. Just code moving around and
cosmetic comment tweaks where needed.
* #includes have largely been untouched for now, but could be cleaned up later
* CMake changes untested, but should work in theory.

8 years agofix for [#34440] motion blur (2d filter) not working in osx
Dalai Felinto [Wed, 27 Feb 2013 22:48:34 +0000 (22:48 +0000)]
fix for [#34440] motion blur (2d filter) not working in osx
thanks Jens Verwiebe for the tests and review.

8 years agoAdded preset values for Collada exporter.
Gaia Clary [Wed, 27 Feb 2013 17:48:07 +0000 (17:48 +0000)]
Added preset values for Collada exporter.