blender.git
3 months agoFix T65301: Convert to mesh with Keep Original loses adjust operator panel.
Bastien Montagne [Sun, 9 Jun 2019 21:43:33 +0000 (23:43 +0200)]
Fix T65301: Convert to mesh with Keep Original loses adjust operator panel.

That was a dummy typo in `duplibase_for_convert()` in fact...

3 months agoRevert "Fix T65301: Convert to mesh with Keep Original loses adjust operator panel."
Bastien Montagne [Sun, 9 Jun 2019 21:39:55 +0000 (23:39 +0200)]
Revert "Fix T65301: Convert to mesh with Keep Original loses adjust operator panel."

This reverts commit rB78bbf374f475 (and part of rB702d85d7cddbf81).

Fix for this is actually simpler, done in next commit.

3 months agoFix (unreported) several issues when converting MBall to Mesh.
Bastien Montagne [Sun, 9 Jun 2019 20:56:37 +0000 (22:56 +0200)]
Fix (unreported) several issues when converting MBall to Mesh.

Redo panel would be hidden (when 'keep original' was not set), due to
same kind of (un)selected issue as in T65301 (see previous commit).

Further more, not all MBall objects of the family were properly removed.

3 months agoFix T65301: Convert to mesh with Keep Original loses adjust operator panel.
Bastien Montagne [Sun, 9 Jun 2019 20:53:48 +0000 (22:53 +0200)]
Fix T65301: Convert to mesh with Keep Original loses adjust operator panel.

We need to properly select new objects (and deselect 'source' ones) when
converting to another type while keeping original ones. Otherwise poll
check of the operator fails, and redo panel cannot be shown.

Note that this is actually a design flaw in redo system currently, since
*new* state has to still allow last operator to be ran, when it should
actually be previous step in history that matters here...

3 months agoFix T65657: crash in float texture painting, after recent changes
Brecht Van Lommel [Sun, 9 Jun 2019 20:03:01 +0000 (22:03 +0200)]
Fix T65657: crash in float texture painting, after recent changes

3 months agoFix T65638: memory leak - modifiers on curves.
Bastien Montagne [Sun, 9 Jun 2019 19:11:37 +0000 (21:11 +0200)]
Fix T65638: memory leak - modifiers on curves.

We need to tag the `mesh_eval` of curve as owned, when we generate one,
otherwise freeing code would not free it.

3 months agoFix: Build error with clang on windows.
Ray Molenkamp [Sun, 9 Jun 2019 00:10:48 +0000 (18:10 -0600)]
Fix: Build error with clang on windows.

clang does not seem support the static_assert with
message overload.

3 months agoIndustry Compat keymap: Fix nodes interaction
William Reynish [Sat, 8 Jun 2019 13:24:47 +0000 (15:24 +0200)]
Industry Compat keymap: Fix nodes interaction

  - Dragging to move, scale and setting links now works normally and correctly

3 months agoCleanup: use doxygen sections for 2D view operators
Campbell Barton [Fri, 7 Jun 2019 23:23:11 +0000 (09:23 +1000)]
Cleanup: use doxygen sections for 2D view operators

3 months agoFix T65420: Crash in file saved with edit mesh
Dalai Felinto [Fri, 7 Jun 2019 20:15:52 +0000 (17:15 -0300)]
Fix T65420: Crash in file saved with edit mesh

Reviewers: brecht, sergey

Differential Revision: https://developer.blender.org/D5041

3 months agoCollections: Never change the collection views visibility when unhiding it
Dalai Felinto [Fri, 7 Jun 2019 21:41:37 +0000 (18:41 -0300)]
Collections: Never change the collection views visibility when unhiding it

How to reproduce: use 1-10 to change the visible collection. If the
collection was globally invisible, it would be set to globally visible.

This was a left over from the previous collection visibility design.

Now that we have a more clear separation between temporary visibility
(i.e., layer collection visibiilty) and a global visibility setting
(i.e., collection visibility) we should keep them separated.

3 months agoFix T65613: Memory leak in Audaspace with 3D sound
Jörg Müller [Fri, 7 Jun 2019 20:29:52 +0000 (22:29 +0200)]
Fix T65613: Memory leak in Audaspace with 3D sound

3 months agoFix T62121: Cycles crash with viewport render and smoke/pointclouds
Brecht Van Lommel [Fri, 7 Jun 2019 19:02:57 +0000 (21:02 +0200)]
Fix T62121: Cycles crash with viewport render and smoke/pointclouds

3 months agoCleanup: fix compiler warning
Brecht Van Lommel [Fri, 7 Jun 2019 18:40:06 +0000 (20:40 +0200)]
Cleanup: fix compiler warning

3 months agoFix T64625: Eevee image textures with alpha have dark edges
Brecht Van Lommel [Fri, 7 Jun 2019 15:49:58 +0000 (17:49 +0200)]
Fix T64625: Eevee image textures with alpha have dark edges

Now texture storage of images is defined by the alpha mode of the image. The
downside of this is that there can be artifacts near alpha edges where pixels
with zero alpha bleed in. It also adds more code complexity since image textures
are no longer all stored the same way.

This changes allows us to keep using sRGB texture formats, which have edge
darkening when stored with premultiplied alpha. Game engines seems to generally
do the same thing, and we want to be compatible with them.

3 months agoFix T65612: Ungroup in Node Editor Crashes
Sergey Sharybin [Fri, 7 Jun 2019 15:45:31 +0000 (17:45 +0200)]
Fix T65612: Ungroup in Node Editor Crashes

3 months agoCleanup: Reformat GPencil multiedit frame selection
Antonio Vazquez [Fri, 7 Jun 2019 14:07:32 +0000 (16:07 +0200)]
Cleanup: Reformat GPencil multiedit frame selection

3 months agoSound: Fix 3D sound coming from scene strips
Sergey Sharybin [Fri, 7 Jun 2019 13:54:22 +0000 (15:54 +0200)]
Sound: Fix 3D sound coming from scene strips

Need to pull in speakers from scene strips and make sure they
are properly updated.

3 months agoSet lower minimum drag thresholds
William Reynish [Fri, 7 Jun 2019 12:29:34 +0000 (14:29 +0200)]
Set lower minimum drag thresholds

Was 3px, but even lower values work too, so setting minimum now to 1px.

3 months agoGNUMakeFile: Fix bad command line to generate QTCreator project.
Dmitriy Efimov [Fri, 7 Jun 2019 12:19:56 +0000 (14:19 +0200)]
GNUMakeFile: Fix bad command line to generate QTCreator project.

Report with fix in D5035 by Dmitriy Efimov (@DarkDemiurg), thanks.

3 months agoEevee: Try to fix NaN caused by normal maps + bentnormals
Clément Foucault [Fri, 7 Jun 2019 11:53:30 +0000 (13:53 +0200)]
Eevee: Try to fix NaN caused by normal maps + bentnormals

Should help with T65118.

3 months agoGPencil: Remove unused Cursor function after add new Paint cursor.
Antonio Vazquez [Fri, 7 Jun 2019 11:25:59 +0000 (13:25 +0200)]
GPencil: Remove unused Cursor function after add new Paint cursor.

3 months agoGPencil: Create new CURSOR for paint modes
Antonio Vazquez [Fri, 7 Jun 2019 10:59:47 +0000 (12:59 +0200)]
GPencil: Create new CURSOR for paint modes

This new cursor is used instead of the ARROW because it was too disruptive while you are drawing.

The change affects all paint modes that are used Brushes.

See D5036 for details.

Reviewers: @brecht @billreynish @mendio
Cursor designed by:  @billreynish

3 months agoCleanup: Rename to avoid shadow variable
Antonio Vazquez [Fri, 7 Jun 2019 10:49:33 +0000 (12:49 +0200)]
Cleanup: Rename to avoid shadow variable

3 months agoDrawManager: OpenGL State Image Rendering
Jeroen Bakker [Fri, 7 Jun 2019 08:23:16 +0000 (10:23 +0200)]
DrawManager: OpenGL State Image Rendering

The OpenGL state was not set to blender defaults when using
`DRW_render_to_image` path. This is only used when doing F12-rendering.
Cause of changes with the `RESTART_INDEX` hair rendering was rendering
the restart_index as an actual vertex index.

Reviewed By: fclem

Differential Revision: https://developer.blender.org/D5039

3 months agoSequencer: Fix missing sound from nested scene strips
Sergey Sharybin [Fri, 7 Jun 2019 09:27:34 +0000 (11:27 +0200)]
Sequencer: Fix missing sound from nested scene strips

3 months agoSound: Use dependency graph instead of bmain
Sergey Sharybin [Fri, 7 Jun 2019 08:58:51 +0000 (10:58 +0200)]
Sound: Use dependency graph instead of bmain

Allows to move scene sound update to dependency graph evaluation.

3 months agoCleanup: Remove unused variable and move definition
Antonio Vazquez [Fri, 7 Jun 2019 09:51:10 +0000 (11:51 +0200)]
Cleanup: Remove unused variable and move definition

3 months agoGPencil: Cleanup multiframe code
Antonio Vazquez [Fri, 7 Jun 2019 09:46:11 +0000 (11:46 +0200)]
GPencil: Cleanup multiframe code

3 months agoFix T65591: GPencil Arrange Strokes operator does not work in multiframe
Antonio Vazquez [Fri, 7 Jun 2019 09:41:11 +0000 (11:41 +0200)]
Fix T65591: GPencil Arrange Strokes operator does not work in multiframe

3 months agoRemove Deform Delay armature option
Sergey Sharybin [Fri, 7 Jun 2019 08:44:18 +0000 (10:44 +0200)]
Remove Deform Delay armature option

This option can not be supported by a new granular dependency graph,
and, especially, copy-on-write.

It was always doing full update ever since initial commit of new dependency
graph which we are using here in the studio for the past years and lack of
this option was never brought up.

Fixes T65557: Delay refresh option in armatures is broken

3 months agoSculpt toolbar: Group new Mask Lasso tool with the Mask Border tool
William Reynish [Fri, 7 Jun 2019 08:35:07 +0000 (10:35 +0200)]
Sculpt toolbar: Group new Mask Lasso tool with the Mask Border tool

Also flip Simplify and Mask, so that all the mask-related tools are next to each other.

3 months agoForgot this file in last commit
William Reynish [Fri, 7 Jun 2019 08:33:01 +0000 (10:33 +0200)]
Forgot this file in last commit

3 months agoAdd Lasso Mask icon for Sculpt Mode toolbar
William Reynish [Fri, 7 Jun 2019 08:24:19 +0000 (10:24 +0200)]
Add Lasso Mask icon for Sculpt Mode toolbar

3 months agoCleanup: keymaps
Campbell Barton [Fri, 7 Jun 2019 08:14:34 +0000 (18:14 +1000)]
Cleanup: keymaps

3 months agoIndustry Compat keymap: Fix alt-key navigation over gizmos
William Reynish [Fri, 7 Jun 2019 07:59:29 +0000 (09:59 +0200)]
Industry Compat keymap: Fix alt-key navigation over gizmos

This broke recently after recent gizmo keymap changes

3 months agoFix missing autosmooth update when animated
Sergey Sharybin [Thu, 6 Jun 2019 10:27:28 +0000 (12:27 +0200)]
Fix missing autosmooth update when animated

Consists of few simple steps.

Don't tag object data's bounding box as dirty before re-evaluaiton

Most of the time this actually tags evaluated mesh which will be tossed
away few lines below anyway. And this causes issues if the evaluated
mesh is actually owned by the mesh datablock.

The bounding box now has clear separation between original object data
and object data after modifiers, so this should not be causing any
issues.

Free evaluated mesh when owner mesh changes

Ensures that evaluated mesh shares the same settings as its owner when
updates related on animation system happens.

Depsgraph: Update mesh when its geometry settings changes

Allows to have options like autosmooth animated.

Reviewers: brecht, mont29

Differential Revision: https://developer.blender.org/D5030

3 months agoFree evaluated mesh when owner mesh changes
Sergey Sharybin [Thu, 6 Jun 2019 10:26:40 +0000 (12:26 +0200)]
Free evaluated mesh when owner mesh changes

Ensures that evaluated mesh shares the same settings as its owner when
updates related on animation system happens.

3 months agoDon't tag object data's bounding box as dirty before re-evaluaiton
Sergey Sharybin [Thu, 6 Jun 2019 10:24:40 +0000 (12:24 +0200)]
Don't tag object data's bounding box as dirty before re-evaluaiton

Most of the time this actually tags evaluated mesh which will be tossed
away few lines below anyway. And this causes issues if the evaluated
mesh is actually owned by the mesh datablock.

The bounding box now has clear separation between original object data
and object data after modifiers, so this should not be causing any
issues.

3 months agoFix T65558: Crash on adding linked scene to Video Sequence Editor
Sergey Sharybin [Thu, 6 Jun 2019 13:05:20 +0000 (15:05 +0200)]
Fix T65558: Crash on adding linked scene to Video Sequence Editor

This commit fixes crash but the possible 3D sound is still missing.
Also, sound from sequencer coming from a scene strip is also missing.

This is partially a regression, at least for F12 case. The editing
was already behaving wrong: it was needed to have scene strip to be
actually rendered in preview.

3 months agoSequencer: Typo
Jeroen Bakker [Fri, 7 Jun 2019 06:39:43 +0000 (08:39 +0200)]
Sequencer: Typo

3 months agoTool System: add sculpt mask lasso tool
Campbell Barton [Fri, 7 Jun 2019 06:04:12 +0000 (16:04 +1000)]
Tool System: add sculpt mask lasso tool

3 months agoFix T65229: Crash adjusting last operator after using undo history
Campbell Barton [Fri, 7 Jun 2019 05:30:49 +0000 (15:30 +1000)]
Fix T65229: Crash adjusting last operator after using undo history

Undo history also missed updating the tool system and
calling undo pre/post handlers.

3 months agoFix T64669: Redo transform fails with constrained axis
Campbell Barton [Fri, 7 Jun 2019 04:11:54 +0000 (14:11 +1000)]
Fix T64669: Redo transform fails with constrained axis

3 months agoFly mode: Enable fancy icons instead of text for shortcuts
Campbell Barton [Fri, 7 Jun 2019 03:01:37 +0000 (13:01 +1000)]
Fly mode: Enable fancy icons instead of text for shortcuts

3 months agoFix T63744: Overlapping axis gizmo for 3D view translate & scale
Campbell Barton [Fri, 7 Jun 2019 02:48:45 +0000 (12:48 +1000)]
Fix T63744: Overlapping axis gizmo for 3D view translate & scale

3 months agoMissed removing unused property from last commit
Campbell Barton [Fri, 7 Jun 2019 02:22:30 +0000 (12:22 +1000)]
Missed removing unused property from last commit

3 months agoKeymap: expose gizmo press/drag as a preference
Campbell Barton [Fri, 7 Jun 2019 02:04:59 +0000 (12:04 +1000)]
Keymap: expose gizmo press/drag as a preference

- Right click select always activates on press
  since this was added as a workaround to left click select conflict.
- Left click has the option to set this to drag or press.

Make this change based on feedback on 8778dd0c8b461.

3 months agoKeymap: gizmos now use a map that optionally activates on press
Campbell Barton [Fri, 7 Jun 2019 01:45:50 +0000 (11:45 +1000)]
Keymap: gizmos now use a map that optionally activates on press

The legacy keymap now activates on press.

3 months agoFix T65479: Gizmo drag unusable with tools that activate on press
Campbell Barton [Fri, 7 Jun 2019 00:54:17 +0000 (10:54 +1000)]
Fix T65479: Gizmo drag unusable with tools that activate on press

3 months agoCleanup: unused var warning
Campbell Barton [Fri, 7 Jun 2019 01:05:56 +0000 (11:05 +1000)]
Cleanup: unused var warning

3 months agoFIX: `use_proxy` strip property state has no effect.
Richard Antalik [Thu, 6 Jun 2019 22:23:53 +0000 (15:23 -0700)]
FIX: `use_proxy` strip property state has no effect.

Author: Olly Funkster, Richard Antalík

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D2504

3 months agoVSE: Cache invalidation
Richard Antalik [Thu, 6 Jun 2019 21:44:12 +0000 (14:44 -0700)]
VSE: Cache invalidation

Add invalidation to strip add functions
Add invalidation for scene and movieclip strips
Skip invalidation for sound strips

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D4989

3 months agoFix T65333: VSE: Playback speed regression
Richard Antalik [Thu, 6 Jun 2019 19:42:41 +0000 (12:42 -0700)]
Fix T65333: VSE: Playback speed regression

3D engine settings were used to select image scaling method.
Use higher quality scaling only for rendering.

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D4995

3 months agoFix T63729 Eevee: Bump does not follow normal direction
Clément Foucault [Thu, 6 Jun 2019 17:32:43 +0000 (19:32 +0200)]
Fix T63729 Eevee: Bump does not follow normal direction

3 months agoFix T65505: crash applying modifiers in paint and sculpt modes
Brecht Van Lommel [Thu, 6 Jun 2019 16:44:03 +0000 (18:44 +0200)]
Fix T65505: crash applying modifiers in paint and sculpt modes

We need to find a better solution for mixing normal refreshes in some corner
cases. We actually had similar issues in 2.79 anyway, not crashing is more
important.

3 months agoFix T63701 Eevee: High Volumetric end distance darkens the image
Clément Foucault [Thu, 6 Jun 2019 16:46:35 +0000 (18:46 +0200)]
Fix T63701 Eevee: High Volumetric end distance darkens the image

3 months agoFix T60441, T60619: incorrect values for color values > 1.0
Bruno Boaventura Scholl [Thu, 6 Jun 2019 16:00:56 +0000 (18:00 +0200)]
Fix T60441, T60619: incorrect values for color values > 1.0

Modulo makes no sense here at all, is from an old bugfix to prevent a crash
that is no longer an issue.

Differential Revision: https://developer.blender.org/D4727

3 months agoFix T65383 UI graphics glitches on macOS with Intel HD 4000
Clément Foucault [Thu, 6 Jun 2019 15:21:12 +0000 (17:21 +0200)]
Fix T65383 UI graphics glitches on macOS with Intel HD 4000

glDrawArrays is not supposed to be affected by primitive restart
but osx drivers never cease to surprise me.

3 months agoSequencer: Viewport Rendering Annotation
Jeroen Bakker [Thu, 6 Jun 2019 12:41:54 +0000 (14:41 +0200)]
Sequencer: Viewport Rendering Annotation

When rendering the Sequencer using viewport rendering the annotations
were not scaled to respect the scene render size. This was because the
matrices were calculated based on the output size and not the actual
rendersize.

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D5032

3 months agoPython API Docs: fix some examples
Jacques Lucke [Thu, 6 Jun 2019 15:12:49 +0000 (17:12 +0200)]
Python API Docs: fix some examples

3 months agoFix T64742 Eevee: SSRefract broken with planar reflections
Clément Foucault [Thu, 6 Jun 2019 14:51:17 +0000 (16:51 +0200)]
Fix T64742 Eevee: SSRefract broken with planar reflections

3 months agocmake/msvc: Add ninja support for precompiled headers
Ray Molenkamp [Thu, 6 Jun 2019 14:26:15 +0000 (08:26 -0600)]
cmake/msvc: Add ninja support for precompiled headers

Ninja was unable to see the dependency between the cpp
that generated the pch and the compile units that used
it. Explicitly managing this now makes precompiled headers
work with both msvc and clang, with both msbuild and ninja
based generators.

3 months agoParticles: remove unused particle settings from UI
Jacques Lucke [Thu, 6 Jun 2019 13:54:46 +0000 (15:54 +0200)]
Particles: remove unused particle settings from UI

Didn't touch rna to make sure that the Python API does not break.
Maybe I missed some, but these don't seem to be used anywere internally.

Reviewers: brecht

Differential Revision: https://developer.blender.org/D5034

3 months agoFix T64533: Using "X-Axis Mirror" while posing with auto keyframe on does not keyfram...
Sebastian Parborg [Thu, 6 Jun 2019 13:52:52 +0000 (15:52 +0200)]
Fix T64533: Using "X-Axis Mirror" while posing with auto keyframe on does not keyframe the mirrored bone

Use an additional pose bone flag so we can keep track of mirrored bones that should be autokeyframed.

Reviewed By: Brecht

Differential Revision: https://developer.blender.org/D5033

3 months agoFix T58920: Dyntopo sculpt and snake hook brush artifacts.
mano-wii [Thu, 6 Jun 2019 13:46:47 +0000 (10:46 -0300)]
Fix T58920: Dyntopo sculpt and snake hook brush artifacts.

This is a mix of solutions rBe60b18d51d58 and rB52af5fa31fbc.
What happened was that when a node of the BVH gets 0 vertices, the batch is untouched and therefore still drawn.

3 months agoFix: Build error with ninja on windows
Ray Molenkamp [Thu, 6 Jun 2019 13:19:58 +0000 (07:19 -0600)]
Fix: Build error with ninja on windows

Ninja has issues detecting the implicit dependency on the
precompiled header output for freestyle. Disabled ninja
support for now until a proper solution can be found.

3 months agoPython API: allow external render engines to use Eevee for LookDev shading
Brecht Van Lommel [Thu, 6 Jun 2019 12:36:40 +0000 (14:36 +0200)]
Python API: allow external render engines to use Eevee for LookDev shading

This is enabled with bl_use_eevee_viewport = True. It allows external engines
to generate an Cycles/Eevee shader node setup to emulate their materials in
the realtime viewport, or to leave it to users to do manually.

Removed bl_use_exclude_layers and bl_use_shading_nodes that did nothing
anymore. This should not break API compatibility, any scripts setting those
should continue to work the same as before.

Also adds descriptions for some RenderEngine settings.

3 months agoPython Templates: fix operator_mesh_uv template
Jacques Lucke [Thu, 6 Jun 2019 12:36:08 +0000 (14:36 +0200)]
Python Templates: fix operator_mesh_uv template

3 months agoDepsgraph: Add relations for spline animation
Sergey Sharybin [Thu, 6 Jun 2019 12:21:39 +0000 (14:21 +0200)]
Depsgraph: Add relations for spline animation

Currently only obvious setting which can be animated is Smooth.

The rest requires more proper support from animation update on
the Curve datablock.

But at least with this change it's not a "dependency graph fault"

3 months agoFix T59176: Missing Animation Update for Surface Resolution U & V
Sergey Sharybin [Thu, 6 Jun 2019 12:15:07 +0000 (14:15 +0200)]
Fix T59176: Missing Animation Update for Surface Resolution U & V

While fix in dependency graph for those is trivial, adopting underlying
code to become aware of animated settings is quite a rabbit hole: there
are non-obvious hidden inter-dependencies between settings, which are
especially tricky for NURBS.

For until we have more dedicated time for this disabling animation.

3 months agoFix T65490: linked property in object duplicate should not persist
Brecht Van Lommel [Thu, 6 Jun 2019 04:37:35 +0000 (06:37 +0200)]
Fix T65490: linked property in object duplicate should not persist

These things are somewhat arbitrary, but since there are separate shortcuts
and menu entries this seems the more expected behavior.

3 months agoFix typo in tooltip (reported in T65555).
Bastien Montagne [Thu, 6 Jun 2019 09:58:14 +0000 (11:58 +0200)]
Fix typo in tooltip (reported in T65555).

3 months agoFix T64788: Double keymap entry in preferences
Campbell Barton [Thu, 6 Jun 2019 09:05:05 +0000 (19:05 +1000)]
Fix T64788: Double keymap entry in preferences

A display issue for tools which share keymaps.

3 months agoRemove mutex lock from node localization
Sergey Sharybin [Thu, 6 Jun 2019 08:39:44 +0000 (10:39 +0200)]
Remove mutex lock from node localization

There is no obvious threading-unsafe code in the localization.
The main source of issues were the new_node/new_socket pointers
which are no longer used during node tree duplication.

3 months agoFix T63035: Undoing in pose mode destroys the entire pose
Sergey Sharybin [Wed, 5 Jun 2019 16:31:04 +0000 (18:31 +0200)]
Fix T63035: Undoing in pose mode destroys the entire pose

Respect do_time flag in on_visible_update, matching behavior of old
dependency graph and avoids unwanted animation updates.

Reviewers: brecht

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D5026

3 months agoIndustry Compat Keymap: Update tweak/select for animation editors to follow latest...
William Reynish [Thu, 6 Jun 2019 07:32:47 +0000 (09:32 +0200)]
Industry Compat Keymap: Update tweak/select for animation editors to follow latest changes

  - Proper support for dragging in empty areas using tweak events to either move or box select
  - Avoids transforming immediately on press, same as the built-in keymap

3 months agoPython: GPU Offscreen Rendering
Jeroen Bakker [Thu, 6 Jun 2019 06:37:43 +0000 (08:37 +0200)]
Python: GPU Offscreen Rendering

When using python offscreen rendering the background was not drawn in
EEVEE. Users would expect that when calling the `draw_view3d` method
that it shows the same as in the 3d viewport.

Seems to be a difference between the meaning of draw_background in b279
and b280. In B279 the world background would be drawn. In B280 the
transparency is changed.

Reviewed By: campbellbarton, fclem

Maniphest Tasks: T61768

Differential Revision: https://developer.blender.org/D5022

3 months agoQuiet warning creating sculpt brush tooltips
Campbell Barton [Thu, 6 Jun 2019 05:59:27 +0000 (15:59 +1000)]
Quiet warning creating sculpt brush tooltips

3 months agoFix T65108: GPencil Sculpt mode select tools don't work
Campbell Barton [Thu, 6 Jun 2019 05:53:11 +0000 (15:53 +1000)]
Fix T65108: GPencil Sculpt mode select tools don't work

Move the sculpt keymap from the mode to the tool.

3 months agoCleanup: indentation
Campbell Barton [Thu, 6 Jun 2019 04:48:37 +0000 (14:48 +1000)]
Cleanup: indentation

Also add comment to `FRS_precomp.h`.

3 months agoFix use of removed Image.use_alpha property
Campbell Barton [Thu, 6 Jun 2019 04:42:51 +0000 (14:42 +1000)]
Fix use of removed Image.use_alpha property

Change missing from 7aaa7aa9dd79b8c6

3 months agoCmake/Windows: Fix numpy being unpacked every build.
Ray Molenkamp [Thu, 6 Jun 2019 02:51:00 +0000 (20:51 -0600)]
Cmake/Windows: Fix numpy being unpacked every build.

Every time you build cmake it unpacks numpy. It is seemingly
very unhappy with OUTPUTS being directories rather than files.

The creating of the directory is not needed, so that step was easy
to resolve, next problem: was there was not a target that outputs
the tarball so it too was deemed out of date. Losing that dependency
as well, fixes the issue, while this is not great if we ever update
the libs in svn, we are planning to drastically change the way we
package python for windows so this is ok for now, but needs to be
addressed with the next python update, T65547 is the tracking ticket
for this.

Tested with VS2015/2017/2019 with both msbuild and ninja generators

3 months agoFreestyle: Use precompiled headers with MSVC.
Ray Molenkamp [Thu, 6 Jun 2019 01:05:16 +0000 (19:05 -0600)]
Freestyle: Use precompiled headers with MSVC.

This brings down the build time for freestyle with MSVC from a
minute to 10-20 seconds.

vs2019 bf_freestyle debug   before: 60464 ms  after: 11028 ms
vs2019 bf_freestyle release before: 56984 ms  after: 20526 ms

Differential Revision: https://developer.blender.org/D2606

Reviewed By: brecht , sergey

3 months agoCleanup: quiet missing variable declaration warning
Campbell Barton [Thu, 6 Jun 2019 00:26:32 +0000 (10:26 +1000)]
Cleanup: quiet missing variable declaration warning

3 months agoCleanup: extra-semi-stmt warning
Campbell Barton [Thu, 6 Jun 2019 00:16:18 +0000 (10:16 +1000)]
Cleanup: extra-semi-stmt warning

3 months agoCMake: pass link deps to library targets with INTERFACE
Campbell Barton [Thu, 6 Jun 2019 00:16:06 +0000 (10:16 +1000)]
CMake: pass link deps to library targets with INTERFACE

Introduced since removing BLENDER_SORTED_LIBS.

This caused building a library to build all it's dependencies.

3 months agoFix missing header for gpu_state.c
Campbell Barton [Thu, 6 Jun 2019 00:06:54 +0000 (10:06 +1000)]
Fix missing header for gpu_state.c

Failed to build without WITH_LEGACY_OPENGL.

3 months agoCleanup: argument sign mismatch warning
Campbell Barton [Wed, 5 Jun 2019 23:55:53 +0000 (09:55 +1000)]
Cleanup: argument sign mismatch warning

3 months agoFix T65118 Eevee: NaN when using bent normals
Clément Foucault [Wed, 5 Jun 2019 19:31:19 +0000 (21:31 +0200)]
Fix T65118 Eevee: NaN when using bent normals

3 months agofix T65480: Collada exporter did not export image texture for Base Color
Gaia Clary [Wed, 5 Jun 2019 19:15:16 +0000 (21:15 +0200)]
fix T65480: Collada exporter did not export image texture for Base Color

3 months agoFix crash when editing shaders on Intel HD 4000.
mano-wii [Wed, 5 Jun 2019 16:06:11 +0000 (13:06 -0300)]
Fix crash when editing shaders on Intel HD 4000.

In the Intel HD 4000 driver a shader has to be deleted in the same context in which it is created.
However, because you can't use a rendering context on different threads, to maintain the multithreaded compilation, the solution was to use the `GL_ARB_get_program_binary` and copy the binary generated for the shader and generate a shader on the main context using that binary.
This solution is limited only to Intel HD 4000 and windows.

Reviewers: fclem

Reviewed By: fclem

Differential Revision: https://developer.blender.org/D5019

3 months agoTooltip: Fix use_preview_range tooltip (OpenGL > View)
Dalai Felinto [Wed, 5 Jun 2019 14:41:29 +0000 (14:41 +0000)]
Tooltip: Fix use_preview_range tooltip (OpenGL > View)

In 2.80 the old OpenGL render is called View render.
Also made the tooltip shorter (it was too repetitive).

3 months agoFix T65437: sculpt dyntopo undo not showing correct mesh
Brecht Van Lommel [Wed, 5 Jun 2019 14:29:19 +0000 (16:29 +0200)]
Fix T65437: sculpt dyntopo undo not showing correct mesh

3 months agoGPencil: Fix mirror modifier rotation around object
Antonioya [Wed, 5 Jun 2019 13:54:22 +0000 (15:54 +0200)]
GPencil: Fix mirror modifier rotation around object

Still pending when the original object is rotated or scaled.

3 months agoFix T64336: Switching to a Camera which is hidden, does not evaluate the animation...
Sergey Sharybin [Wed, 5 Jun 2019 13:51:50 +0000 (15:51 +0200)]
Fix T64336: Switching to a Camera which is hidden, does not evaluate the animation data

Changing camera might require more objects pulled into the dependency graph,
so need tag relations for update.

3 months agoDopesheet: drag to box select in dopesheet
Jacques Lucke [Wed, 5 Jun 2019 13:48:30 +0000 (15:48 +0200)]
Dopesheet: drag to box select in dopesheet

This includes refactoring of the `mouse_action_keys` to
make it easier to just detect if there is a key under
the mouse. The refactoring mostly consists of extracting
methods and reducing vertical scope of variables.

Reviewers: billreynish, brecht

Differential Revision: https://developer.blender.org/D5024

3 months agomake.bat: Support optional paths for `make format`
Ray Molenkamp [Wed, 5 Jun 2019 13:30:45 +0000 (07:30 -0600)]
make.bat: Support optional paths for `make format`

make.bat now supports optional parameters to restrict
the formatting to a specific folder. Multiple paths
may be given

example:
make.bat format source/blender/blenkernel source/blender/gpu

3 months agoFix T63384: Vertices are moving in different directions
Sergey Sharybin [Wed, 5 Jun 2019 13:17:53 +0000 (15:17 +0200)]
Fix T63384: Vertices are moving in different directions

3 months agoCleanup: Remove unused argument
Sergey Sharybin [Wed, 5 Jun 2019 13:14:48 +0000 (15:14 +0200)]
Cleanup: Remove unused argument