2 years agoCleanup: style
Campbell Barton [Fri, 29 Mar 2019 20:13:55 +0000 (07:13 +1100)]
Cleanup: style

2 years agoEevee: Material: Decouple transparent shadows from blend mode
Clément Foucault [Fri, 29 Mar 2019 18:18:08 +0000 (19:18 +0100)]
Eevee: Material: Decouple transparent shadows from blend mode

This makes it easier to exclude a surface from casting shadows and can be
used to manipulate the shadows even for opaque surfaces.

Versionning ensure that old behavior is transfered to new rendering logic.

2 years agoFix T61129 Eevee: alpha texture shadow bug
Clément Foucault [Fri, 29 Mar 2019 17:59:11 +0000 (18:59 +0100)]
Fix T61129 Eevee: alpha texture shadow bug

This was due to some shading resources not being bound for the shadow
shader. This commit completely remove the shading part when in a shadow
shader. Thus making it a bit more lightweight and removing the needed

2 years agoFix cramped display of tool setting enums in workspace tab.
Brecht Van Lommel [Fri, 29 Mar 2019 16:53:56 +0000 (17:53 +0100)]
Fix cramped display of tool setting enums in workspace tab.

2 years agoFix part of T63102: wrong Python API Reference link in Help menu.
Brecht Van Lommel [Fri, 29 Mar 2019 16:34:16 +0000 (17:34 +0100)]
Fix part of T63102: wrong Python API Reference link in Help menu.

2 years agoFix header text for muted collapsed nodes not being greyed out.
Brecht Van Lommel [Fri, 29 Mar 2019 14:51:36 +0000 (15:51 +0100)]
Fix header text for muted collapsed nodes not being greyed out.

2 years agoEevee: Implement Texture coordinate from object
Clément Foucault [Fri, 29 Mar 2019 16:40:50 +0000 (17:40 +0100)]
Eevee: Implement Texture coordinate from object

First try to implement T57489. But unfortunately, there is a missing
dependency in the depsgraph that does not trigger the shader update.

2 years agoCleanup: Line wrapping
Sergey Sharybin [Fri, 29 Mar 2019 14:40:59 +0000 (15:40 +0100)]
Cleanup: Line wrapping

2 years agoGPencil: Improve soft eraser for last stroke points
Antonioya [Fri, 29 Mar 2019 14:39:29 +0000 (15:39 +0100)]
GPencil: Improve soft eraser for last stroke points

Now, the last point is managed separately in order to get smoother transition.

2 years agoCleanup: Spelling in comment
Sergey Sharybin [Fri, 29 Mar 2019 14:33:44 +0000 (15:33 +0100)]
Cleanup: Spelling in comment

2 years agoFix T63042: Grease pencil and armature will sometimes copy successfully because of...
Bastien Montagne [Fri, 29 Mar 2019 13:54:50 +0000 (14:54 +0100)]
Fix T63042: Grease pencil and armature will sometimes copy successfully because of the put in Collection order, sometimes fail.

Remove remapping to new IDs from `BKE_object_duplicate()` itself, doing
it here will break later remapping done after all desired objects have
been duplicated, preventing complete remap of ID pointers used in obdata
and other sub-data of duplicated objects.

Checked, the only two usages of this function were already doing
separated later step for this anyway.

2 years agoCleanup: BKE_object_duplicate.
Bastien Montagne [Fri, 29 Mar 2019 13:53:45 +0000 (14:53 +0100)]
Cleanup: BKE_object_duplicate.

Comments, code consistency, remove disabled code...

2 years agoCleanup: Fix comment.
Bastien Montagne [Thu, 28 Mar 2019 14:20:58 +0000 (15:20 +0100)]
Cleanup: Fix comment.

2 years agoFix T63075: edit mode crash with deforming modifiers, after recent changes.
Brecht Van Lommel [Fri, 29 Mar 2019 13:53:56 +0000 (14:53 +0100)]
Fix T63075: edit mode crash with deforming modifiers, after recent changes.

2 years agoGPencil: Cleanup code
Antonioya [Fri, 29 Mar 2019 11:51:46 +0000 (12:51 +0100)]
GPencil: Cleanup code

Reduce double function calling.

2 years agoFix T63082: Outliner allows assign grease pencil materials to mesh
Antonioya [Fri, 29 Mar 2019 10:58:28 +0000 (11:58 +0100)]
Fix T63082: Outliner allows assign grease pencil materials to mesh

The grease pencil materials only can be assigned to objects of grease pencil type.

2 years agoFix T62938: Rigid body crash with surface effector
Sergey Sharybin [Fri, 29 Mar 2019 09:27:57 +0000 (10:27 +0100)]
Fix T62938: Rigid body crash with surface effector

Missing dependency graph relation from geometry to simulation,
which made simulation to use evaluated mesh while it is being

2 years agoCleanup: Make it obvious which relations are used
Sergey Sharybin [Fri, 29 Mar 2019 09:21:36 +0000 (10:21 +0100)]
Cleanup: Make it obvious which relations are used

Relation in dependency graph is something else. So make it clear
that those are the effector ones.

2 years agoFix T62908: Missing update when inserting keyframe from dopesheet
Sergey Sharybin [Fri, 29 Mar 2019 09:01:55 +0000 (10:01 +0100)]
Fix T62908: Missing update when inserting keyframe from dopesheet

2 years agoFix T63063: solidify modifier crash after recent changes.
Brecht Van Lommel [Fri, 29 Mar 2019 00:27:58 +0000 (01:27 +0100)]
Fix T63063: solidify modifier crash after recent changes.

It should not assume there to be an origindex layer. Checked other modifiers
and they all seem to explicitly create it or verify if it's NULl.

2 years agoCycles: reduce number of synchronizing object prints.
Brecht Van Lommel [Fri, 29 Mar 2019 00:29:42 +0000 (01:29 +0100)]
Cycles: reduce number of synchronizing object prints.

Do it only for meshes/curves since those are potentially slow and need user
feedback to see things are not stuck. For object instances and lights assume
it's fast enough.

Printing too much can have a performance impact on slow Windows command
prompt or when logging complex scene renders.

2 years agoEevee: Render: Reduce debug print amount to not decrease perf
Clément Foucault [Thu, 28 Mar 2019 22:24:25 +0000 (23:24 +0100)]
Eevee: Render: Reduce debug print amount to not decrease perf

This is to fix the slowdown issue experienced on windows when rendering
from command line.

Fix T59649 Eevee in command-line batch mode is slow with particles/duplis

2 years agoGPU: Fix color difference when rendering to gpu_py_offscreen
Clément Foucault [Thu, 28 Mar 2019 21:38:55 +0000 (22:38 +0100)]
GPU: Fix color difference when rendering to gpu_py_offscreen

Now we do the color management inside the Draw manager and output CM byte

2 years agoFix T62178 Eevee: Texture Box mapping not matching Cycles if object is scaled
Clément Foucault [Thu, 28 Mar 2019 21:08:39 +0000 (22:08 +0100)]
Fix T62178 Eevee: Texture Box mapping not matching Cycles if object is scaled

The wrong transformation was used. Add a new matrix specially for this case.

This also fix the Node texture coordinate that was suffering the same issue.

2 years agoFix T58387 Voronoi(Cells) does not work on eevee (amd + windows)
Clément Foucault [Thu, 28 Mar 2019 17:14:04 +0000 (18:14 +0100)]
Fix T58387 Voronoi(Cells) does not work on eevee (amd + windows)

Thanks to Gabor Fekete for helping finding the issue.

Was caused by uninitialized variable. Also took the oportunity to use comp
swizzling instead of multiple assignment.

2 years agoDRW: Fix Memory leak introduced by previous commit
Clément Foucault [Thu, 28 Mar 2019 17:09:10 +0000 (18:09 +0100)]
DRW: Fix Memory leak introduced by previous commit

2 years agoDRW/Eevee: Add correct support for Orco
Clément Foucault [Thu, 28 Mar 2019 15:36:45 +0000 (16:36 +0100)]
DRW/Eevee: Add correct support for Orco

Until now, Orcos were computed by the gpu (GLSL) and were not taking into
account the modifier stack (breaking orco for deformed mesh).

Now Orco is now computed on CPU but only if a modifier stack is present.

Tagging that an ORCO layer is present is done via a 4th component, which is
a waste of memory/bandwidth. Best would be to do the same as auto attrib
color space and save a bool uniform somewhere but for now it's too

2 years agoUI: tweak display of report messages in the status bar.
Nathan Craddock [Thu, 28 Mar 2019 16:54:35 +0000 (17:54 +0100)]
UI: tweak display of report messages in the status bar.

Remove fading away the color, share theme colors with info editor.

Differential Revision:

2 years agoFix T60719: muted nodes are not clearly visible.
Robert Guetzkow [Thu, 28 Mar 2019 16:39:54 +0000 (17:39 +0100)]
Fix T60719: muted nodes are not clearly visible.

Now the entire node gets greyed out, instead of using a red header that is
hard to distinguish from other nodes with similar header colors.

Differential Revision:

2 years agoFix part of T60735: invalid CD_ORIGINDEX data in some modifier stack evaluations.
Brecht Van Lommel [Thu, 28 Mar 2019 14:05:04 +0000 (15:05 +0100)]
Fix part of T60735: invalid CD_ORIGINDEX data in some modifier stack evaluations.

BKE_mesh_new_nomain automatically added a CD_ORIGINDEX layer initialized to 0,
which was never filled in correctly. In 2.7 the equivalent function used to
modify the source derivedmesh and add valid original indices to it, but this
is no longer possible in the new design and was quite unpredictable anyway.

Now instead rely on mesh_calc_modifiers and the depsgraph to determine when
CD_ORIGINDEX should be added.

2 years agoFix T60735: Cycles render hangs with vertex instancing.
Brecht Van Lommel [Thu, 28 Mar 2019 13:44:12 +0000 (14:44 +0100)]
Fix T60735: Cycles render hangs with vertex instancing.

This should not use the original index as a unique instance index, with for
example an array modifier the same original index may be used multiple times.

2 years agoCleanup: better naming, comments, variable scoping in mesh_calc_modifiers.
Brecht Van Lommel [Thu, 28 Mar 2019 10:42:53 +0000 (11:42 +0100)]
Cleanup: better naming, comments, variable scoping in mesh_calc_modifiers.

2 years agoCleanup: remove unused derivedmesh code.
Brecht Van Lommel [Wed, 27 Mar 2019 18:07:16 +0000 (19:07 +0100)]
Cleanup: remove unused derivedmesh code.

2 years agoFix build errors
mano-wii [Thu, 28 Mar 2019 18:59:51 +0000 (15:59 -0300)]
Fix build errors

From rBd5cb425b8745

2 years agoUI: Theme: Make selected text stand out
William Reynish [Thu, 28 Mar 2019 18:59:46 +0000 (19:59 +0100)]
UI: Theme: Make selected text stand out

Previous selected text color was almost invisible against the dark background.
Use same selected/highlight color as in other places in the default theme.

Issue reported on Devtalk by user Symstract

2 years agoPossible fix for T62999: Crash when select in edit mode.
mano-wii [Thu, 28 Mar 2019 17:17:00 +0000 (14:17 -0300)]
Possible fix for T62999: Crash when select in edit mode.

Apparently some drivers don't allow `glReadPixel` read out pixels of texture boundaries.
Intersect `rect` to avoid such cases.

2 years agoGPencil: Fix error in previous commit
Antonioya [Thu, 28 Mar 2019 16:17:04 +0000 (17:17 +0100)]
GPencil: Fix error in previous commit

2 years agoFix T63054: Crash on "Grease Pencil Unlink"
Antonioya [Thu, 28 Mar 2019 16:07:49 +0000 (17:07 +0100)]
Fix T63054: Crash on "Grease Pencil Unlink"

This operator was used only by annotations and it was part of the old legacy code.

Now, the operator is limited to annotations and cannot be used with grease pencil objects.

Also changed the tooltip to clarify it's only for annotations.

2 years agoFix T63052: Crash on "Grease Pencil Fill" without Grease Pencil Object
Antonioya [Thu, 28 Mar 2019 15:48:32 +0000 (16:48 +0100)]
Fix T63052: Crash on "Grease Pencil Fill" without Grease Pencil Object

Changed poll function to verify if the context is valid.

Also cleanup return values.

2 years agoFix T62717: Switching Shading Modes During Sculpting
Jeroen Bakker [Thu, 28 Mar 2019 15:10:15 +0000 (16:10 +0100)]
Fix T62717: Switching Shading Modes During Sculpting

Switching shader modes to material or render during a sculpting session
showed the model when the sculptsession was started. The user needed
to click that forced an update of the sculptsession.

In `sculpt_flush_update` the eevee drawing mesh is not updated when
workbench engine is used.

2 years agoFix T63032: Increase camera properties precision in UI
Jacques Lucke [Thu, 28 Mar 2019 14:56:53 +0000 (15:56 +0100)]
Fix T63032: Increase camera properties precision in UI

Reviewers: brecht

Differential Revision:

2 years agoFix T63015: Crash when using circle select tool in lattice edit mode
Jacques Lucke [Thu, 28 Mar 2019 14:03:27 +0000 (15:03 +0100)]
Fix T63015: Crash when using circle select tool in lattice edit mode

Reviewers: brecht

Differential Revision:

2 years agoFix T62874: Crash Texture shading+Transparency
Jeroen Bakker [Thu, 28 Mar 2019 13:58:37 +0000 (14:58 +0100)]
Fix T62874: Crash Texture shading+Transparency

When texure shading is enabled, the transparency accum shaders were not set/updated.
This resulted into a crash when transparent objects were rendered when shading mode
was set to texture.

This patch will add the V3D_SHADING_TEXTURE_COLOR to the modes for OIT so the
shaders are set.

Reviewed By: fclem

Maniphest Tasks: T62874

Differential Revision:

2 years agoFix T63040: Resizing node has offset
Jacques Lucke [Thu, 28 Mar 2019 13:56:55 +0000 (14:56 +0100)]
Fix T63040: Resizing node has offset

This broke in rB6500b31728d870506207d9d70837b171cbef32ea.

Reviewers: brecht

Differential Revision:

2 years agoDrawManager: Add Edge Detection To DisplayLists
Jeroen Bakker [Thu, 28 Mar 2019 13:51:29 +0000 (14:51 +0100)]
DrawManager: Add Edge Detection To DisplayLists

Objects that internally uses DispList do not cast shadow in the workbench.
Their outline is also not visible in object mode. The reason for this is
that edge detection was not implemented for Display Lists. This patch will
implement the edge detection.

Reviewed By: fclem

Maniphest Tasks: T62479

Differential Revision:

2 years agoFix T60421: Bone heads are hidden when non-connected parent is hidden
Sebastian Parborg [Thu, 28 Mar 2019 12:09:16 +0000 (13:09 +0100)]
Fix T60421: Bone heads are hidden when non-connected parent is hidden

The root point of a bone is now always drawn unless it is connected to an other bone.

Reviewed By: Clément Foucault

Differential Revision:

2 years agoFix T53997: island_margin in bpy.ops.uv.smart_project seems to have no effect
Sebastian Parborg [Thu, 28 Mar 2019 11:53:36 +0000 (12:53 +0100)]
Fix T53997: island_margin in bpy.ops.uv.smart_project seems to have no effect

Now island margin acts as a percentage instead of being the actual distance.
So the margin distance will always be the same regardless of the actual size of the geometry.

Reviewed By: Brecht

Differential Revision:

2 years agoFix T62944: Memory leak in animation playback
Sergey Sharybin [Thu, 28 Mar 2019 11:07:58 +0000 (12:07 +0100)]
Fix T62944: Memory leak in animation playback

Missing memory free in the early output of particles distribute

Seems it was always there.

2 years agoFix T63030: Edge crease is not applied for boundary edges
Sergey Sharybin [Thu, 28 Mar 2019 10:48:22 +0000 (11:48 +0100)]
Fix T63030: Edge crease is not applied for boundary edges

Caused by missing vertex sharpness comparison in the topology

2 years agoFix T63031: Keyframing Annotations doesn't work
Antonioya [Thu, 28 Mar 2019 10:43:17 +0000 (11:43 +0100)]
Fix T63031: Keyframing Annotations doesn't work

By design the annotation parameters must not be animatable.

Annotations are designed to take notes, not to create animations, so any animatable parameters have been flagged as non-animatable.

Note: As some properties are shared with grease pencil, I had to duplicate one property (adviced by @mont29) to keep grease pencil animatable but annotations don't.

2 years agoDepsgraph: Fix dependency cycle when adding rigid body
Sergey Sharybin [Thu, 28 Mar 2019 10:04:00 +0000 (11:04 +0100)]
Depsgraph: Fix dependency cycle when adding rigid body

Was a mistake in the recent change.

The idea here is: manual should invalidate point cache, but
rigid body simulation should only happen after point cache
was ensured to be in the correct state.

2 years agoFix T63037: Accelerator keys fail when another key is highlighted
Campbell Barton [Thu, 28 Mar 2019 05:44:27 +0000 (16:44 +1100)]
Fix T63037: Accelerator keys fail when another key is highlighted

2 years agoCleanup: add doxy sections to view3d_draw,header
Campbell Barton [Thu, 28 Mar 2019 04:00:27 +0000 (15:00 +1100)]
Cleanup: add doxy sections to view3d_draw,header

2 years agoFix bpy.msgbus.subscribe_rna argument parsing
Campbell Barton [Thu, 28 Mar 2019 00:19:48 +0000 (11:19 +1100)]
Fix bpy.msgbus.subscribe_rna argument parsing

Also enforce all arguments are keywords and update docstring.

2 years agoEdit Mesh Selection: Clear buffer before using in glReadPixel.
mano-wii [Wed, 27 Mar 2019 23:33:25 +0000 (20:33 -0300)]
Edit Mesh Selection: Clear buffer before using in glReadPixel.

Areas out of bound are not written.

2 years agoCleanup: style, use braces for makesdna, datatoc
Campbell Barton [Wed, 27 Mar 2019 22:49:10 +0000 (09:49 +1100)]
Cleanup: style, use braces for makesdna, datatoc

2 years agoDRW manager: Always assume that the GL_DITHER and GL_SCISSOR_TEST should be disabled...
mano-wii [Wed, 27 Mar 2019 22:36:12 +0000 (19:36 -0300)]
DRW manager: Always assume that the GL_DITHER and GL_SCISSOR_TEST should be disabled if not used.

This may fix a glitch detected when you perform edited mesh selection.
See comment in rB00bdb5cdf08f

2 years agoFix T63023: wrong Eevee window coordinates for background.
Brecht Van Lommel [Wed, 27 Mar 2019 21:32:13 +0000 (22:32 +0100)]
Fix T63023: wrong Eevee window coordinates for background.

2 years agoFix part of T63023: wrong Cycles window coordinates for background.
Brecht Van Lommel [Wed, 27 Mar 2019 20:18:18 +0000 (21:18 +0100)]
Fix part of T63023: wrong Cycles window coordinates for background.

2 years agoEevee: Fix reflection plane weird behavior when comming from lookdev mode
Clément Foucault [Wed, 27 Mar 2019 21:02:13 +0000 (22:02 +0100)]
Eevee: Fix reflection plane weird behavior when comming from lookdev mode

The reflection was set to use the 1x1px texture as rendering target and was
considered valid reflection texture.

2 years agoFix T63017: selection via lasso does not work properly in X-ray.
mano-wii [Wed, 27 Mar 2019 19:48:12 +0000 (16:48 -0300)]
Fix T63017: selection via lasso does not work properly in X-ray.

Probably missed in rB40f8ddf8297a.

2 years agoFix T55956: Transfer Weights: Source Layers can't be set to Active Layer.
Bastien Montagne [Wed, 27 Mar 2019 19:44:14 +0000 (20:44 +0100)]
Fix T55956: Transfer Weights: Source Layers can't be set to Active Layer.

Behavior of source/destination options was rather flaky in reversed

Note that even though this mode is a bit annoying and cumbersome, the
only alternative (defining a specific transfer weight operator) would be
much more verbose, so think that for now we'd rather keep what we have

2 years agoCleanup: minor comments fixes.
Bastien Montagne [Wed, 27 Mar 2019 08:45:59 +0000 (09:45 +0100)]
Cleanup: minor comments fixes.

2 years agoFix T62566 Eevee: Cubemap doesn't bake from current frame of animation
Clément Foucault [Wed, 27 Mar 2019 19:47:15 +0000 (20:47 +0100)]
Fix T62566 Eevee: Cubemap doesn't bake from current frame of animation

This was technically a feature request but it was quite simple to implement
so I did it quickly. Also it is much more consistent now.

2 years agoFix T62680 Mirrored objects have flipped binormal vectors in LookDev
Clément Foucault [Wed, 27 Mar 2019 19:21:10 +0000 (20:21 +0100)]
Fix T62680 Mirrored objects have flipped binormal vectors in LookDev

Pass binormal sign via object info.

2 years agoEevee: Modify tooltip about transparent shadow
Clément Foucault [Wed, 27 Mar 2019 18:41:35 +0000 (19:41 +0100)]
Eevee: Modify tooltip about transparent shadow

Mention that this option is only for shadow mapping and not contact shadow.

2 years agoFix T62997 Eevee: visual artifacts during irradiance volume baking
Clément Foucault [Wed, 27 Mar 2019 18:15:23 +0000 (19:15 +0100)]
Fix T62997 Eevee: visual artifacts during irradiance volume baking

Seems to be a problem with Nvidia drivers. glFlush does not work but
glFinish does ensure correct multithreading.

2 years agoFix T62862 Eevee: Glitchy reflections in ortographic view
Clément Foucault [Wed, 27 Mar 2019 14:18:33 +0000 (15:18 +0100)]
Fix T62862 Eevee: Glitchy reflections in ortographic view

This was caused by sign(cubevec.xy) returning 0.0 when one component was 0.
Thus making the resulting component component 0.0 instead of 0.0.

2 years agoUI: Add missing separator in object context menu
William Reynish [Wed, 27 Mar 2019 16:04:47 +0000 (17:04 +0100)]
UI: Add missing separator in object context menu

2 years agoPython API: tweak RenderEngine example to be a bit more efficient.
Brecht Van Lommel [Wed, 27 Mar 2019 15:25:19 +0000 (16:25 +0100)]
Python API: tweak RenderEngine example to be a bit more efficient.

Suggested by Germano Cavalcante.

2 years agoFix T61559: show object constraints also when in pose mode, remove warning.
Brecht Van Lommel [Wed, 27 Mar 2019 14:38:29 +0000 (15:38 +0100)]
Fix T61559: show object constraints also when in pose mode, remove warning.

This was originally added in 6feddb8b61df, but the warning is quite clumsy
and we also don't limit editing object transforms that way. The add constraint
button at the top now also indicates if it's for objects or bones, which was
not the case before and probably was part of the confusion.

If it does still cause issues we can always change back or hide the tab.

2 years agoEdit Mesh Selection: make sure that `GL_SCISSOR_TEST` is disabled.
mano-wii [Wed, 27 Mar 2019 14:34:38 +0000 (11:34 -0300)]
Edit Mesh Selection: make sure that `GL_SCISSOR_TEST` is disabled.

Possible solution for T62999.

2 years agoFix T63004: Make Links operator would still allow collection instancing
Philipp Oeser [Wed, 27 Mar 2019 13:57:13 +0000 (14:57 +0100)]
Fix T63004: Make Links operator would still allow collection instancing
for objects other than Empties

In 2.8 support for dupli-group instancing for non-empty objects was
removed (rB2eca054e14b1), so better prevent operators from setting

Reviewers: brecht

Maniphest Tasks: T63004

Differential Revision:

2 years agoCleanup: style, use braces for draw
Campbell Barton [Wed, 27 Mar 2019 14:11:28 +0000 (01:11 +1100)]
Cleanup: style, use braces for draw

2 years agoFix T62901: Bad handling of missing addon category
Jacques Lucke [Wed, 27 Mar 2019 14:12:25 +0000 (15:12 +0100)]
Fix T62901: Bad handling of missing addon category

2 years agoFix debug error on recent commit.
mano-wii [Wed, 27 Mar 2019 14:05:48 +0000 (11:05 -0300)]
Fix debug error on recent commit.

2 years agoUI: minor change to active-default logic
Campbell Barton [Wed, 27 Mar 2019 13:57:46 +0000 (00:57 +1100)]
UI: minor change to active-default logic

Don't attempt to activate default button if it's already active.

Also expand on the flags comment.

2 years agoUI: use active-default button flag for operator confirmation
Campbell Barton [Wed, 27 Mar 2019 13:54:13 +0000 (00:54 +1100)]
UI: use active-default button flag for operator confirmation

2 years agoGPencil: Remove legacy `ED_gpencil_draw_view3d` code.
mano-wii [Wed, 27 Mar 2019 13:52:13 +0000 (10:52 -0300)]
GPencil: Remove legacy `ED_gpencil_draw_view3d` code.

Differential Revision:

2 years agoFix T62935: Missing tag when copying constraints
Jacques Lucke [Wed, 27 Mar 2019 13:48:48 +0000 (14:48 +0100)]
Fix T62935: Missing tag when copying constraints

2 years agoUI: use active-default button flag for the file selector
Campbell Barton [Wed, 27 Mar 2019 13:46:13 +0000 (00:46 +1100)]
UI: use active-default button flag for the file selector

2 years agoUI: support an 'active default' button for pop-ups
Campbell Barton [Wed, 27 Mar 2019 10:39:44 +0000 (21:39 +1100)]
UI: support an 'active default' button for pop-ups

Use this for the save confirmation dialog so it has a default action
when pressing enter which draws with a highlight so it's clear what the
default action is (the dialog was just closing before).

Resolves T57686

2 years agoCleanup: remove unused menu bl_spacetype
Campbell Barton [Wed, 27 Mar 2019 13:24:51 +0000 (00:24 +1100)]
Cleanup: remove unused menu bl_spacetype

2 years agoFix T62978: grease pencil 3D view header layout broken after recent changes.
Brecht Van Lommel [Wed, 27 Mar 2019 12:59:18 +0000 (13:59 +0100)]
Fix T62978: grease pencil 3D view header layout broken after recent changes.

2 years agoRevert "RNA: error on register when classes use invalid identifiers"
Campbell Barton [Wed, 27 Mar 2019 12:29:42 +0000 (23:29 +1100)]
Revert "RNA: error on register when classes use invalid identifiers"

This reverts commit b24a255ca67841ff2d6121327791e933ce8e3602.

The warning wasn't being printed, so many add-ons weren't yet updated.

Re-enable now warnings are printed to allow addon developers to update.

2 years agoFix T62926: allow using shift click drag to extend selection in file browser.
Brecht Van Lommel [Wed, 27 Mar 2019 12:13:05 +0000 (13:13 +0100)]
Fix T62926: allow using shift click drag to extend selection in file browser.

Standard behavior on most operating systems.

2 years agoCleanup: style, use braces for bmesh
Campbell Barton [Wed, 27 Mar 2019 06:14:36 +0000 (17:14 +1100)]
Cleanup: style, use braces for bmesh

2 years agoFix popovers from enums failing on drag-release
Campbell Barton [Wed, 27 Mar 2019 04:35:49 +0000 (15:35 +1100)]
Fix popovers from enums failing on drag-release

2 years agoFix class registration ignoring info/warnings
Campbell Barton [Wed, 27 Mar 2019 03:03:16 +0000 (14:03 +1100)]
Fix class registration ignoring info/warnings

Only errors were displayed in the console.

2 years agoPyAPI: utility function to print reports
Campbell Barton [Wed, 27 Mar 2019 03:01:25 +0000 (14:01 +1100)]
PyAPI: utility function to print reports

2 years agoCleanup: unused variables
Campbell Barton [Wed, 27 Mar 2019 02:19:02 +0000 (13:19 +1100)]
Cleanup: unused variables

2 years agoCleanup: style, use braces for blenlib
Campbell Barton [Wed, 27 Mar 2019 02:16:10 +0000 (13:16 +1100)]
Cleanup: style, use braces for blenlib

2 years agoPython API: add more detailed example for RenderEngine.
Brecht Van Lommel [Tue, 26 Mar 2019 18:48:16 +0000 (19:48 +0100)]
Python API: add more detailed example for RenderEngine.

2 years agoPython API: allow passing None to some BGL functions instead of bgl.Buffer
Brecht Van Lommel [Tue, 26 Mar 2019 18:48:44 +0000 (19:48 +0100)]
Python API: allow passing None to some BGL functions instead of bgl.Buffer

Many OpenGL functions take NULL pointers, passing those was quite complicated
with some addons even using ctypes to manipulate internal bgl.Buffer pointers.

2 years agoFix vertex array leak in Cycles viewport drawing.
Brecht Van Lommel [Tue, 26 Mar 2019 16:26:57 +0000 (17:26 +0100)]
Fix vertex array leak in Cycles viewport drawing.

2 years agoDRW manager: Use existing viewport instead of creating a viewport in DRW_draw_depth_loop.
mano-wii [Tue, 26 Mar 2019 15:19:00 +0000 (12:19 -0300)]
DRW manager: Use existing viewport instead of creating a viewport in DRW_draw_depth_loop.

2 years agoFix T62952: remove lamp as camera using the lamp clip start/end.
Brecht Van Lommel [Tue, 26 Mar 2019 15:07:42 +0000 (16:07 +0100)]
Fix T62952: remove lamp as camera using the lamp clip start/end.

Eevee and Cycles don't use these clipping distances the same as Blender
Internal did, or at all in most cases. Just remove this since it makes no
sense anymore.

2 years agoFix T62958: Improve exponential easing formula
Jacques Lucke [Tue, 26 Mar 2019 14:43:51 +0000 (15:43 +0100)]
Fix T62958: Improve exponential easing formula

Reviewers: brecht

Differential Revision:

2 years agoFix T62955: Missing panels in workbench engine
Jacques Lucke [Tue, 26 Mar 2019 14:41:56 +0000 (15:41 +0100)]
Fix T62955: Missing panels in workbench engine

Afaik all the panels in the scene settings are render
engine independent. So it does not make sense to have
this extra complexity in every panel class.

Reviewers: brecht, billreynish

Differential Revision:

2 years agoFix T62626: Python errors when pinning particle settings.
Brecht Van Lommel [Tue, 26 Mar 2019 14:41:43 +0000 (15:41 +0100)]
Fix T62626: Python errors when pinning particle settings.