Brecht Van Lommel [Fri, 8 Mar 2019 01:15:24 +0000 (02:15 +0100)]
Cleanup: remove unused test break code for handling cancels.
Antonioya [Fri, 8 Mar 2019 07:49:25 +0000 (08:49 +0100)]
GPencil: Fix field type error in initialization
Campbell Barton [Fri, 8 Mar 2019 06:48:49 +0000 (17:48 +1100)]
Cleanup: spelling
Campbell Barton [Fri, 8 Mar 2019 06:16:30 +0000 (17:16 +1100)]
Cleanup: style
Campbell Barton [Fri, 8 Mar 2019 05:59:48 +0000 (16:59 +1100)]
Cleanup: use doxy sections for node select API
Campbell Barton [Fri, 8 Mar 2019 05:22:38 +0000 (16:22 +1100)]
Cleanup: use doxy sections for mask select API
Campbell Barton [Fri, 8 Mar 2019 04:56:55 +0000 (15:56 +1100)]
Cleanup: use doxy sections for object select API
Campbell Barton [Fri, 8 Mar 2019 03:16:32 +0000 (14:16 +1100)]
Cleanup: make modal event double click handling more straightforward
Campbell Barton [Fri, 8 Mar 2019 02:35:48 +0000 (13:35 +1100)]
WM: fix double click handling in modal keymaps
Model keymaps wasn't matching double-click events with press
as is done in regular keymap handling.
Campbell Barton [Fri, 8 Mar 2019 01:37:22 +0000 (12:37 +1100)]
Fix T62095: OpenGL render camera image alignment
Campbell Barton [Fri, 8 Mar 2019 00:55:52 +0000 (11:55 +1100)]
Fix: Info window select all toggle broken
D4477 by @Poulpator
Campbell Barton [Fri, 8 Mar 2019 00:40:37 +0000 (11:40 +1100)]
Cleanup: use macro for listbase collection begin functions
Campbell Barton [Thu, 7 Mar 2019 22:55:40 +0000 (09:55 +1100)]
RNA: rename bpy.data.grease_pencil to grease_pencils
All other sequences are plural here.
Campbell Barton [Thu, 7 Mar 2019 22:29:17 +0000 (09:29 +1100)]
Cleanup: use plural names for Main lists
Convention was not to but after discussion on
918941483f7e we agree its
best to change the convention.
Names now mostly follow RNA.
Some exceptions:
- Use 'nodetrees' instead of 'nodegroups'
since the struct is called NodeTree.
- Use 'gpencils' instead of 'grease_pencil'
since 'gpencil' is a common abbreviation in the C code.
Other exceptions:
- Leave 'wm' as it's a list of one.
- Leave 'ipo' as is for versioning.
Gaia Clary [Thu, 7 Mar 2019 22:26:10 +0000 (23:26 +0100)]
fix D4476 collada exporter: in Blender 2.80 we no longer have a specular color.
Specularity is not a color but a factor.
I have replaced the original export code with
a correct export of the Specularity factor.
Dalai Felinto [Thu, 7 Mar 2019 14:55:03 +0000 (14:55 +0000)]
Properties Editor: Grease Pencil and pinning fixes
The UI was trying to use screen_context.c for its poll and draw
functions. So the active object and active object data and active layer
was used in the UI, instead of the context one.
Besides, for the material, the wrong context path was used altogether
when the active object was a greasepencil.
This would lead to all sort of pinning problems:
* A Mesh panel is pinned, but the active object is a grease pencil, the
grease pencil panels would show.
* If a Grease Pencil (data) panel is pinned, but the active object is not
the one pinned, nothing would show.
* Material panels and pinning were totally broken, showing the material
context for pinned mesh data panels even.
I also sanitized the name of the panels, their inheritance and poll
functions.
Reviewers: antoniov, brecht
Subscribers: billrey
Differential Revision: https://developer.blender.org/D4470
Antonioya [Thu, 7 Mar 2019 19:04:00 +0000 (20:04 +0100)]
GPencil: Update stroke when UV factor is changed
The stroke was updated only after doing a refresh operation.
Jacques Lucke [Thu, 7 Mar 2019 18:56:13 +0000 (19:56 +0100)]
Fix T62319: changing keyframe properties does not trigger update
Reviewers: brecht
Differential Revision: https://developer.blender.org/D4473
Brecht Van Lommel [Thu, 7 Mar 2019 18:39:50 +0000 (19:39 +0100)]
Fix T62328, T62209: revert recent fix for texture slots updates (T60366).
This causes other issues, revert for now until a better fix is found.
Reverts commit
da1323d1c95095feff98e8aa054d73fd323c363d.
Brecht Van Lommel [Thu, 7 Mar 2019 11:35:37 +0000 (12:35 +0100)]
Cleanup: remove unused parameter.
Brecht Van Lommel [Thu, 7 Mar 2019 11:47:42 +0000 (12:47 +0100)]
Cleanup: fix compiler warnings.
Jacques Lucke [Thu, 7 Mar 2019 17:03:20 +0000 (18:03 +0100)]
Fix T62305: Unconnected group vector inputs are mapped incorrectly
The issue was that `bNodeSocketValueVector` and `bNodeSocketValueRGBA`
don't store the value at the same location in the struct.
I kept the cases for `SOCK_VECTOR` and `SOCK_RGBA` completely separate
for now, because they only share code by coincidence and not because
they are actually the same. Eventually there could be a "Vector Input"
node similar to the "RGB" node.
Reviewers: fclem
Differential Revision: https://developer.blender.org/D4472
Antonioya [Thu, 7 Mar 2019 16:51:59 +0000 (17:51 +0100)]
Fix T62316: Grease Pencil objects display in front of the grid lines
The fix was move the grease pencil engine before overlays
This also fix the origin not visible bug T62100
There is a limitation of this fix, but we cannot fix both problems. If you have object behind a transparent graese pencil objects, this objects will not be visible.
Thanks @fclem for his advices to fix this bug.
Campbell Barton [Thu, 7 Mar 2019 15:47:00 +0000 (02:47 +1100)]
Cleanup: remove redundant check
Campbell Barton [Thu, 7 Mar 2019 15:43:33 +0000 (02:43 +1100)]
Cleanp: use static sets
Campbell Barton [Thu, 7 Mar 2019 15:06:22 +0000 (02:06 +1100)]
Fix gizmos not responding to theme color updates
Re-create gizmos when changing theme colors, since
theme colors don't change often this allows gizmos to setup their
colors on initialization.
Bastien Montagne [Thu, 7 Mar 2019 15:23:58 +0000 (16:23 +0100)]
Modifiers Evaluation: generate loop normals when requested.
This also fixes T62228.
However, datatransfer code is still doing bad things with its source,
still working on proper changes here.
Sergey Sharybin [Thu, 7 Mar 2019 15:07:34 +0000 (16:07 +0100)]
Multires: Fix crash on exit when sculpting with modifiers
The SubdivCCG structure was re-allocated, but the cached one in
the sculpt session was still pointing to an original one.
This is rather a workaround, but is least evil from what i can
currently think. Remember something similar was also required in
2.7 as well.
Definitely need to revision this change.
Sergey Sharybin [Thu, 7 Mar 2019 14:40:04 +0000 (15:40 +0100)]
Sculpt; Fix memory leak on redraw normals update
Sergey Sharybin [Thu, 7 Mar 2019 14:27:31 +0000 (15:27 +0100)]
Fix T62271: Particles with multires crash on sculpt
In fact, any modifier on top of multires would lead to crash.
Was missing pointer update.
Basically, bring the control flow closer to 2.7.
Jacques Lucke [Thu, 7 Mar 2019 14:55:11 +0000 (15:55 +0100)]
Fix T61671: Too strong too dark text shadow in Blender Light theme
Reviewers: pablovazquez
Differential Revision: https://developer.blender.org/D4468
Jacques Lucke [Thu, 7 Mar 2019 14:54:08 +0000 (15:54 +0100)]
Fix T61761: Randomize Transform is an object mode operator
Reviewers: brecht, billreynish
Differential Revision: https://developer.blender.org/D4467
William Reynish [Thu, 7 Mar 2019 14:07:16 +0000 (15:07 +0100)]
UI: Change UI name of Draw Labels to Include Labels
For compliance with recent naming conventions.
William Reynish [Thu, 7 Mar 2019 13:56:31 +0000 (14:56 +0100)]
UI: Use sub-panels inside Grease Pencil Onion Skinning panel
Reviewers: Antonio Vazquez (antoniov)
Differential Revision: D4465
Campbell Barton [Thu, 7 Mar 2019 13:36:48 +0000 (00:36 +1100)]
Image: use sample size instead of radius
It wasn't possible to sample a 2x2 region.
Campbell Barton [Thu, 7 Mar 2019 13:17:52 +0000 (00:17 +1100)]
Cleanup: redundant select flush
Campbell Barton [Thu, 7 Mar 2019 12:41:32 +0000 (23:41 +1100)]
Tool System: use set/add/subtract for all lasso select operators
Brecht Van Lommel [Thu, 7 Mar 2019 11:22:38 +0000 (12:22 +0100)]
Fix T62289: crash with texture paint slots and missing node group datablock.
Sergey Sharybin [Thu, 7 Mar 2019 11:16:25 +0000 (12:16 +0100)]
Multires: Fiux memory leak
The work data for materials flags was never freed.
Jacques Lucke [Thu, 7 Mar 2019 11:01:32 +0000 (12:01 +0100)]
Refactor building the draw string for floats and ints
Differential Revision: https://developer.blender.org/D4466
Brecht Van Lommel [Thu, 7 Mar 2019 10:40:02 +0000 (11:40 +0100)]
Fix T62280: driver functions added in load_post broken after recent changes.
Evaluate the dependency graph a bit later still. This kind of worked before
because it was using the drive namespace from the previously loaded .blend
file but that's of course wrong.
Bastien Montagne [Thu, 7 Mar 2019 10:45:48 +0000 (11:45 +0100)]
I18n: Enable Thai language.
Bastien Montagne [Thu, 7 Mar 2019 10:13:40 +0000 (11:13 +0100)]
Refactor CDData masks, to have one mask per mesh elem type.
We already have different storages for cddata of verts, edges etc.,
'simply' do the same for the mask flags we use all around Blender code
to request some data, or limit some operation to some layers, etc.
Reason we need this is that some cddata types (like Normals) are
actually shared between verts/polys/loops, and we don’t want to generate
clnors everytime we request vnors!
As a side note, this also does final fix to T59338, which was the
trigger for this patch (need to request computed loop normals for
another mesh than evaluated one).
Reviewers: brecht, campbellbarton, sergey
Differential Revision: https://developer.blender.org/D4407
William Reynish [Thu, 7 Mar 2019 10:12:30 +0000 (11:12 +0100)]
Tools: Add Radius tool to Grease Pencil toolbar
Icon pending.
Campbell Barton [Thu, 7 Mar 2019 09:53:53 +0000 (20:53 +1100)]
Cleanup: de-duplicate selection keymap templates
Campbell Barton [Thu, 7 Mar 2019 09:33:57 +0000 (20:33 +1100)]
Tool System: use set/add/subtract for all box select operators
William Reynish [Thu, 7 Mar 2019 08:58:56 +0000 (09:58 +0100)]
UI: Re-order toolbar in Curve Edit mode
Makes it more consistent with Mesh Edit mode, and uses same logic for grouping.
Campbell Barton [Thu, 7 Mar 2019 07:02:52 +0000 (18:02 +1100)]
Tool System: add radius option to the image sample tool
Campbell Barton [Thu, 7 Mar 2019 03:18:13 +0000 (14:18 +1100)]
Cleanup: use macros to avoid repetition
Campbell Barton [Thu, 7 Mar 2019 03:03:59 +0000 (14:03 +1100)]
Tool System: add annotation tool to image editor
Also add place-holder measure tool.
Campbell Barton [Thu, 7 Mar 2019 02:48:29 +0000 (13:48 +1100)]
Fix crash transforming image cursor outside of edit-mode
Clément Foucault [Thu, 7 Mar 2019 02:51:00 +0000 (03:51 +0100)]
Fix T62066: Seg Fault Baking Light Cache with "--background" Flag
Clément Foucault [Thu, 7 Mar 2019 02:33:24 +0000 (03:33 +0100)]
Fix T59877: EEVEE: Object Info node random value does not work with Duplis
Clément Foucault [Thu, 7 Mar 2019 02:22:43 +0000 (03:22 +0100)]
DRW: Fix hair OSX workaround having a cap limit
This is still is a dirty workaround.
Note that we are drawing the whole sets of point multiple times. While this
is ineficient, the main bottleneck is CPU transformation.
Campbell Barton [Thu, 7 Mar 2019 01:58:11 +0000 (12:58 +1100)]
Cleanup: use API to reset cursor rotation
Campbell Barton [Thu, 7 Mar 2019 01:53:45 +0000 (12:53 +1100)]
Cleanup: class name
Campbell Barton [Thu, 7 Mar 2019 01:46:17 +0000 (12:46 +1100)]
UI: rename "Camera Lock" to "View Lock"
Only 1 of the options in this panel apply to cameras.
Campbell Barton [Thu, 7 Mar 2019 01:37:47 +0000 (12:37 +1100)]
3D View: view selected/all use empty object center
Empty object skipping now only skips the bounds, since you can select
the empty by it's center point and want to navigate to it.
Also share object skipping check between view all/selected.
Campbell Barton [Thu, 7 Mar 2019 01:31:36 +0000 (12:31 +1100)]
Fix "View All" potential min/max use when all objects were skipped
Campbell Barton [Thu, 7 Mar 2019 01:22:56 +0000 (12:22 +1100)]
Fix 3D "View Selected" skip camera option
Campbell Barton [Thu, 7 Mar 2019 00:39:16 +0000 (11:39 +1100)]
3D View: skip hidden image empties when viewing all
D4463 by @pablodp606
Campbell Barton [Thu, 7 Mar 2019 00:26:28 +0000 (11:26 +1100)]
DRW: show image empty frame when the 'side' is hidden
This behavior matches back-face culled mesh objects,
where the wire outline doesn't depend on the viewing angle.
Applying this before empty visibility check for view framing,
since it's strange if viewing all gives different results
depending on back-face culling.
Clément Foucault [Wed, 6 Mar 2019 22:53:35 +0000 (23:53 +0100)]
Fix T62259: RGB Curves behave differently in Cycles and Eevee
This was due to curve being not extrapolated correctly. Also curvemap range
was not taken into account.
Campbell Barton [Wed, 6 Mar 2019 23:12:13 +0000 (10:12 +1100)]
UI: correct label
Campbell Barton [Wed, 6 Mar 2019 14:35:58 +0000 (01:35 +1100)]
Cleanup: pylint warnings
William Reynish [Wed, 6 Mar 2019 22:19:48 +0000 (23:19 +0100)]
Units: Fix unreported. Audio volume is not a percentage
Antonioya [Wed, 6 Mar 2019 18:31:01 +0000 (19:31 +0100)]
GPencil: Fix unreported segment fault drawing with dots
Antonioya [Wed, 6 Mar 2019 16:56:55 +0000 (17:56 +0100)]
GPencil: Improve quality to stroke encaps for textured materials
Before, the caps were not generated for texture materials, now, the endcaps are generated and adapt the texture.
Dalai Felinto [Wed, 6 Mar 2019 16:54:51 +0000 (13:54 -0300)]
Minor UI fix: Disable stereo volume alpha when stereo volume is disabled
Dalai Felinto [Wed, 6 Mar 2019 16:51:27 +0000 (13:51 -0300)]
Fix build for Linux systems
Error introduced on rBff8a2df829fcce8780d26a18f3070ab8e850b2e6.
The folders with binary icons were deleted.
Dalai Felinto [Wed, 6 Mar 2019 15:39:07 +0000 (12:39 -0300)]
Fix stereoscopy convergence plane placement
Note this was broken even in 2.7x.
We had a different logic for the plane wire, as for the plane itself.
And they were both wrong when changing the camera shift or the stereo
pivot.
Both of their logic is now unified and correct.
Also I had to create a new gpu batch for the quad wires, since there is
no state that allows me to filter out the geometry, and the square gpu
batch is quite different than the quad one (2d x 3d and orientation).
Dalai Felinto [Wed, 6 Mar 2019 15:53:58 +0000 (12:53 -0300)]
Fix stereo plane pass and state
This was introduced on the MSAA fix for transparent passes (
61039bf71376).
Brecht Van Lommel [Wed, 6 Mar 2019 15:32:15 +0000 (16:32 +0100)]
Linux/X11: update icon in taskbar to match new icons.
Adds a few different resolutions for better quality when scaling up/down.
Jakub Steiner [Fri, 1 Mar 2019 13:42:12 +0000 (14:42 +0100)]
Linux/freedesktop: update Blender app icon based on new guidelines.
* Use only scalable SVG icon.
* Add symbolic variant for accessibility.
* Remove shadow, this is added automatically.
For more information see:
https://gitlab.gnome.org/GNOME/Initiatives/issues/2
https://developer.gnome.org/hig/stable/icon-design.html.en
William Reynish [Wed, 6 Mar 2019 15:43:37 +0000 (16:43 +0100)]
UI: Name changes
In accordance with T56648.
- Render Border -> Render Region
- Clipping Border -> Clipping Region
- Instancing 'Scale' -> 'Scale to Face Size'
- Instancing 'Rotation' -> 'Align to Vertex Normal'
Python API is left as-is, for now.
DIfferential revision: D4435
Clément Foucault [Wed, 6 Mar 2019 15:15:26 +0000 (16:15 +0100)]
Fix T62220: Solid shading mode - Shadow glitch
The degenerate triangle threshold was too big. Making it an equal test can
introduce problems in other cases but I could not make it fail.
Clément Foucault [Wed, 6 Mar 2019 14:48:15 +0000 (15:48 +0100)]
Fix T62262: Light "Show Cone" & stereoscopy volumes broken by MSAA
Volume itself was working, but buggy. The issue was that transparent shapes
does not write to depth buffer. But the custom MSAA resolve shader discard
pixels that did not write to depth making them transparent.
Transparent passes should not be inside the MSAA passes, this is also
a matter of performance.
Bastien Montagne [Wed, 6 Mar 2019 14:09:16 +0000 (15:09 +0100)]
Collection duplication from Outliner: add a 'duplicate hierarchy' operation.
Point is, you may want to duplicate your set of collections, but not
duplicate all their objects.
Some notes:
* Am rather skeptical about the practice of using operator name to
define behavior of some common exec code. Imho, that should be a single
operator with an enum to refine its behavior (@cambpellbarton may also
have an opinion here?). Left it as-is for now, because this seems to be
used by other operators too in that code. :/
* @dfelinto, @pablovazquez, @billreynish am not so happy with current
names, but cannot find really good short ones either... Also, shouldn't
we move those into a dedicated `Duplicate` sub-menu?
Bastien Montagne [Wed, 6 Mar 2019 13:49:27 +0000 (14:49 +0100)]
Fix (unreported) broken usercount of collections after duplication.
Was missing proper flag in library_query code, collections are also
id-users of their children collections.
Bastien Montagne [Wed, 6 Mar 2019 10:42:19 +0000 (11:42 +0100)]
Cleanup: remove no-op BKE_collection_copy_full().
That one was an empty place-holder, BKE_collection_duplicate() is now
doing that. And its call from full scene copying is not needed
currently, 'deep copy' in that case is handled in editor's
`ED_scene_add()`.
Note that at some point, we might want to move that logic into BKE, but
for now let's keep thing as they are - working.
Bastien Montagne [Wed, 6 Mar 2019 10:38:06 +0000 (11:38 +0100)]
Fix T62613: In duplicated collections objects loses patrenting.
We need to remap duplicated IDs' ID pointers to new ones if they exist.
Bastien Montagne [Wed, 6 Mar 2019 10:20:23 +0000 (11:20 +0100)]
Cleanup: remove useless extra-processing after BKE_id_new_name_validate() call.
This function already handles sorting of ID in its listbase.
Bastien Montagne [Wed, 6 Mar 2019 10:16:48 +0000 (11:16 +0100)]
Cleanup: use default ID type's name instead of generic 'Untitled' for new IDs.
Bastien Montagne [Wed, 6 Mar 2019 10:10:45 +0000 (11:10 +0100)]
Cleanup: rename BKE_library's `new_id()` to `BKE_id_new_name_validate()`.
The former was probably one of the worst function names in our whole
code base, totally misleading, and quiet often used as a variable name too.
Howard Trickey [Wed, 6 Mar 2019 14:04:31 +0000 (09:04 -0500)]
Fix T61773 Bevel and Inset mouse sensitivity, and bevel tool units.
The mouse movement scale needed adjusting according to object scale,
since the amount is on the unscaled model but the viewport shows the
scaled one.
Also fixed proper units for amounts in bevel tool, as was already
done for modifier. Percent should be comfortably adjustable by mouse.
Dalai Felinto [Wed, 6 Mar 2019 13:07:51 +0000 (10:07 -0300)]
Viewport: Fix stereoscopy volume "wires" not showing
This is unreported. When using volume opacity 0.0, the wires were not visible
(nor were they in other cases, but this was the most obvious one).
The volume itself is still glitchy, and slightly worse than 2.79. I
still don't know how to fix this though. It seems a common problem
(see T62262).
Dalai Felinto [Wed, 6 Mar 2019 12:08:38 +0000 (09:08 -0300)]
Fix T62118: Stereo drawing options visible from camera view
Note 1: Volume drawing still draws differently than 2.7x.
Note 2: Camera lens widget still ignores stereo.
William Reynish [Wed, 6 Mar 2019 13:59:09 +0000 (14:59 +0100)]
Fix: Proportional editing menu disappears after deleting object
Differential Revision: D4460
Campbell Barton [Wed, 6 Mar 2019 13:35:53 +0000 (00:35 +1100)]
Fix grease pencil sculpt circle keymap
Missed when updating circle select operators.
Campbell Barton [Wed, 6 Mar 2019 13:17:54 +0000 (00:17 +1100)]
Missed last commit
Campbell Barton [Wed, 6 Mar 2019 13:07:23 +0000 (00:07 +1100)]
DNA: remove none particle brush & deprecated flags
The none brush doesn't make sense to have anymore with the tool system.
Also remove deprecated flags & types for object, armature & text.
Brecht Van Lommel [Wed, 6 Mar 2019 12:45:21 +0000 (13:45 +0100)]
Merge branch 'blender2.7'
Brecht Van Lommel [Wed, 6 Mar 2019 12:27:29 +0000 (13:27 +0100)]
Fix Cycles build error on non-x86 processors.
Campbell Barton [Wed, 6 Mar 2019 10:48:22 +0000 (21:48 +1100)]
Fix T62223: Particle brushes disable select tools
Campbell Barton [Wed, 6 Mar 2019 10:28:41 +0000 (21:28 +1100)]
Fix T62223: Particle select tools also show brush settings
Antonioya [Wed, 6 Mar 2019 09:54:38 +0000 (10:54 +0100)]
Fix T62230: Annotations corrupts GPencil brushes
Use annotations inside grease pencil drawing mode is something incompatible by design. Actually, the annotations are disabled in overlay panel for 2D template and the tool icon is not in the toolbar.
The unique way to get annotations was using D key, but this is wrong.
If you are inside drawing mode, all the events are captured by paint operator and to capture annotations, the operator must be canceled and the mode changed, but this change breaks several things.
It's not logic add annotation inside darwing mode, because you can simply add a new layer and write the text you want.
This change checks the mode and cancel the annotations if the mode is not thje right one.
Campbell Barton [Wed, 6 Mar 2019 07:08:27 +0000 (18:08 +1100)]
Fix T62241: Repeat last translate, wrong direction
Only use orientation value when the operator uses orientation axis.
Own error in
03da3b6593a24
Campbell Barton [Wed, 6 Mar 2019 05:47:02 +0000 (16:47 +1100)]
Fix T62236: Crash texture painting
Caused by
10d9a2494fc5e which removed 5x length clamping.
Campbell Barton [Wed, 6 Mar 2019 05:20:36 +0000 (16:20 +1100)]
Cleanup: unused function warning
Campbell Barton [Wed, 6 Mar 2019 03:46:58 +0000 (14:46 +1100)]
Fix T62210: endless loop in kd tree lookup
Reset nodes after the first balance call.