blender.git
5 years agoFreestyle: Fix for viewport render not updating with changes of Freestyle settings.
Tamito Kajiyama [Thu, 5 Jun 2014 15:56:04 +0000 (00:56 +0900)]
Freestyle: Fix for viewport render not updating with changes of Freestyle settings.

5 years agoFreestyle: Fix for operator error messages with no active line set and associated...
Tamito Kajiyama [Thu, 5 Jun 2014 13:58:51 +0000 (22:58 +0900)]
Freestyle: Fix for operator error messages with no active line set and associated line style.

This commit amends a de-duplication of error messages in the commit rB6067fa682b0c.

5 years agoUI: higher precision for IK poll angle
Campbell Barton [Thu, 5 Jun 2014 23:50:38 +0000 (09:50 +1000)]
UI: higher precision for IK poll angle

5 years agoCode cleanup: style
Campbell Barton [Thu, 5 Jun 2014 21:54:05 +0000 (07:54 +1000)]
Code cleanup: style

5 years agoOSX: replace deprecated (10.8 ) Gestalt function with utsname, no functional change
Jens Verwiebe [Thu, 5 Jun 2014 20:14:14 +0000 (22:14 +0200)]
OSX: replace deprecated (10.8 ) Gestalt function with utsname, no functional change

5 years agoFix T40228: cycles CUDA multi GPU + world MIS giving error.
Brecht Van Lommel [Thu, 5 Jun 2014 16:10:06 +0000 (18:10 +0200)]
Fix T40228: cycles CUDA multi GPU + world MIS giving error.

5 years agoFix T40429: cycles CUDA + use persistent images problem.
Brecht Van Lommel [Thu, 5 Jun 2014 15:39:16 +0000 (17:39 +0200)]
Fix T40429: cycles CUDA + use persistent images problem.

5 years agoFix subpixel precision in transform node
Sergey Sharybin [Thu, 5 Jun 2014 16:05:05 +0000 (22:05 +0600)]
Fix subpixel precision in transform node

The node was using sampler from the callee node and passed
it to the input nodes. Since the fact that compositor output
node uses NEAREST interpolation (why it uses nearest is the
whole separate story) it's not possible to have subpixel
precision in such cases:

  <image> -> <translate> -> <output>

For now solving by hard-coding translate node to use BILINEAR
interpolation. It can't become worse in this node anyway and
the sampling pipeline is to be re-visited from scratch.

5 years agoTweak to previous commit
Sergey Sharybin [Thu, 5 Jun 2014 13:37:12 +0000 (19:37 +0600)]
Tweak to previous commit

5 years agoFix T40382: 2D stabilization uses disabled markers
Sergey Sharybin [Thu, 5 Jun 2014 13:25:21 +0000 (19:25 +0600)]
Fix T40382: 2D stabilization uses disabled markers

This lead to unpredictable results in some cases.

5 years agoAvoid openmp sections in BM_mesh_elem_index_ensure
Campbell Barton [Thu, 5 Jun 2014 08:50:10 +0000 (18:50 +1000)]
Avoid openmp sections in BM_mesh_elem_index_ensure

5 years agoCode cleanup: mixup hflag/htype
Campbell Barton [Thu, 5 Jun 2014 08:37:53 +0000 (18:37 +1000)]
Code cleanup: mixup hflag/htype

5 years agoFix T40436: No preview in Brush with Cycles
Sergey Sharybin [Thu, 5 Jun 2014 07:15:01 +0000 (13:15 +0600)]
Fix T40436: No preview in Brush with Cycles

More like a feature request, but after i've implemented preview for
icons it was rather simple to support nodes previews.

5 years agoBlender Internal: Fix for lamp option "Specular" not working when "Only Shadow" is...
IRIE Shinsuke [Fri, 30 May 2014 13:11:06 +0000 (22:11 +0900)]
Blender Internal: Fix for lamp option "Specular" not working when "Only Shadow" is enabled.

This is followup to rB8008d9bdfd57. Blender Render and GLSL preview
now produce the same results.

5 years agoCorrect hard-coded height for UV-Vertex buttons
Campbell Barton [Thu, 5 Jun 2014 05:00:26 +0000 (15:00 +1000)]
Correct hard-coded height for UV-Vertex buttons

5 years agoFreestyle: Fix for Interface0DIterator.object docstring with additional notes.
Tamito Kajiyama [Thu, 5 Jun 2014 05:06:25 +0000 (14:06 +0900)]
Freestyle: Fix for Interface0DIterator.object docstring with additional notes.

5 years agoFix T40423: UV Editing 'Draw Other Objects' fails with Cycles
Campbell Barton [Thu, 5 Jun 2014 03:55:50 +0000 (13:55 +1000)]
Fix T40423: UV Editing 'Draw Other Objects' fails with Cycles

5 years agoFreestyle: Fix for a wrong formula used for RGB to grayscale conversion.
Tamito Kajiyama [Thu, 5 Jun 2014 03:55:22 +0000 (12:55 +0900)]
Freestyle: Fix for a wrong formula used for RGB to grayscale conversion.

This bug fix is likely to affect the visual results of existing Freestyle setups using the
Material color/alpha/thickness modifiers with the 'material_attribute' parameter set to
either 'Diffuse' (default) or 'Specular', and also the Ramp option enabled in the case
of the Material color modifier.

5 years agoBMesh: avoid using OpenMP when nothing to do
Campbell Barton [Wed, 4 Jun 2014 22:10:26 +0000 (08:10 +1000)]
BMesh: avoid using OpenMP when nothing to do

Gave slowdown drawing on high poly meshes

5 years agoFix T40482: Cycles matlib file crashes
Sergey Sharybin [Wed, 4 Jun 2014 20:29:48 +0000 (02:29 +0600)]
Fix T40482: Cycles matlib file crashes

it's possible that runtime optimizer would call get_attribute
with NULL renderstate. As per documentation, it's valid to
return false in that cases and in worst case we'll just miss
some possible optimization.

Supporting such cases would require some bigger changes to
Cycles since attributes are only set to up for the kernel
after shader compilation.

Thanks Brecht for review!

5 years agoFix T40478: wrong cycles fresnel with GLSL materials in the viewport.
Brecht Van Lommel [Wed, 4 Jun 2014 17:35:56 +0000 (19:35 +0200)]
Fix T40478: wrong cycles fresnel with GLSL materials in the viewport.

5 years agoFix issues when ungrouping meta changes the final sequencer render
Sergey Sharybin [Wed, 4 Jun 2014 16:05:33 +0000 (22:05 +0600)]
Fix issues when ungrouping meta changes the final sequencer render

Seems to be caused by the way how the most bottom strip in the stack
used to apply effect. Just rendering strip in this cases will not give
proper results.

Made it so effect is applying between empty imbuf and actual strip.
Seems to work by tests, but more intense testing is required.

5 years agoFix T40456: cycles bug with branched path + sss + no sample all direct lights.
Brecht Van Lommel [Wed, 4 Jun 2014 15:54:10 +0000 (17:54 +0200)]
Fix T40456: cycles bug with branched path + sss + no sample all direct lights.

5 years agoOptimize editmode drawing edgees
Campbell Barton [Wed, 4 Jun 2014 10:40:42 +0000 (20:40 +1000)]
Optimize editmode drawing edgees

Was interpolating and setting the color twice per edge.
Now only set the color when needed (can be once per draw),
~2x speedup for edge drawing.

5 years agoOSX 10.10: fix for Blender crashing on fsmenu due icloud in the favorite list but...
Jens Verwiebe [Wed, 4 Jun 2014 08:54:21 +0000 (10:54 +0200)]
OSX 10.10: fix for Blender crashing on fsmenu due icloud in the favorite list but pointer is NULL when not activated
This does not break other OSX versions, just add a check for pathString

5 years agoFreestyle: Fix for a potential infinite loop in stroke resampling by vertex count.
Tamito Kajiyama [Wed, 4 Jun 2014 05:51:39 +0000 (14:51 +0900)]
Freestyle: Fix for a potential infinite loop in stroke resampling by vertex count.

Changes were made in Stroke::Resample(int) in C++ to prevent a potential infinite loop
caused by an inconsistency between Stroke::_Length and the stroke length computed
based on stroke vertices.  Such a stroke length inconsistency is usually caused by missing
calls of Stroke::UpdateLength() (i.e., API implementation bugs), but also may occur due
to scripting errors in user-defined style modules.  This commit is meant to help script
writters to identify the latter error cases.  Now Stroke.resample(int) may raise a runtime
error to signal an error condition.

5 years agoFix for dupli's ignoring color in set-scenes
Campbell Barton [Wed, 4 Jun 2014 04:22:29 +0000 (14:22 +1000)]
Fix for dupli's ignoring color in set-scenes

also skip setting wire color drawing depth

5 years agoFix T40489: Curve drawing skipped loose-wire when mixed with solid faces
Campbell Barton [Tue, 3 Jun 2014 22:36:22 +0000 (08:36 +1000)]
Fix T40489: Curve drawing skipped loose-wire when mixed with solid faces

5 years agoTweaks to bevel and crease transform
Sergey Sharybin [Tue, 3 Jun 2014 16:02:02 +0000 (22:02 +0600)]
Tweaks to bevel and crease transform

They were using INPUT_SPRING in a way which didn't allow
it to easily redo the operator because INPUT_SPRING internally
is stored as a ration between old value and new one and crease
and bevel were converting this to value delta.

Now made it special input type INPUT_SPRING_DELTA which is
storing delta of the spring, meaning now values in the redo
panel kind of makes sense -- they mean how much to add/remove
to the crease/bevel weight.

Expect to be no functional changes from interactive transform
POV, just a bit more convenient to use redo panel.

5 years agoChange to key modifier should trigger re-evaluation of drag-and-drop
Campbell Barton [Tue, 3 Jun 2014 13:00:39 +0000 (23:00 +1000)]
Change to key modifier should trigger re-evaluation of drag-and-drop

This change is part of a fix for T40435, but will postpone for now.

Original patch by Sergey Sharybin

5 years agoCode cleanup: replace macro with function to reduce binary size
Campbell Barton [Tue, 3 Jun 2014 09:25:07 +0000 (19:25 +1000)]
Code cleanup: replace macro with function to reduce binary size

5 years agoBake-API small cleanup
Dalai Felinto [Tue, 3 Jun 2014 05:14:28 +0000 (02:14 -0300)]
Bake-API small cleanup

5 years agoFix T40476 - Baking multiple selected objects in Cycles final result
Dalai Felinto [Tue, 3 Jun 2014 05:14:12 +0000 (02:14 -0300)]
Fix T40476 - Baking multiple selected objects in Cycles final result
depends on last selected object

Reviewers: campbellbarton

Differential Revision: https://developer.blender.org/D577

5 years agoBake-API prevent baking for engines that dont support the baking API
Dalai Felinto [Tue, 3 Jun 2014 03:34:20 +0000 (00:34 -0300)]
Bake-API prevent baking for engines that dont support the baking API

In the future we can fallback to the Blender Internal baking.

Review/Suggestions by Campbell Barton

5 years agoView3d Toolbar: project-paint tools were in options, move into own panel
Campbell Barton [Tue, 3 Jun 2014 02:05:47 +0000 (12:05 +1000)]
View3d Toolbar: project-paint tools were in options, move into own panel

5 years agoFix T39053: Replace mesh actuator does not replace material (only mesh)
Mitchell Stokes [Tue, 3 Jun 2014 01:52:13 +0000 (18:52 -0700)]
Fix T39053: Replace mesh actuator does not replace material (only mesh)

The replace mesh actuator was reconverting the mesh data which causes
conflicts with the LoD code. Instead, we just look for an already
converted mesh, which should already be in the scene.

5 years agoCorrect last commit: workaround for BGE
Campbell Barton [Tue, 3 Jun 2014 01:32:45 +0000 (11:32 +1000)]
Correct last commit: workaround for BGE

5 years agoCode cleanup: use typedefs for ui handler functions
Campbell Barton [Mon, 2 Jun 2014 22:58:16 +0000 (08:58 +1000)]
Code cleanup: use typedefs for ui handler functions

5 years agoFix T40448: Blurring bug in the compositor
Sergey Sharybin [Mon, 2 Jun 2014 12:33:19 +0000 (18:33 +0600)]
Fix T40448: Blurring bug in the compositor

This commit pretty much reverts all the changes related on tile-ability
of the fast gaussian blur. It's not tilable by definition and would almost
always give you seams on the tile boundaries.

Atmind already met the issue and tried to solve it by increasing some
magic constant, which is pretty much likely simply made it so compositor
switched to full-frame calculation in that particular .blend file.

Fast gaussian is really not a production thing and need to be avoided.
We're to improve speed of normal gaussian blur instead.

5 years agoDisable key-modifier detection when activating windows
Campbell Barton [Mon, 2 Jun 2014 12:31:32 +0000 (22:31 +1000)]
Disable key-modifier detection when activating windows

Causes issues on X11 for some users

5 years agoOSX: Set Blender.app and Blenderplayer.app creation and modification date to compilet...
Jens Verwiebe [Mon, 2 Jun 2014 12:19:56 +0000 (14:19 +0200)]
OSX: Set Blender.app and Blenderplayer.app creation and modification date to compiletime, else we would always have the time from checkout here

5 years agoFix compilation on unofficial 64bit archs
Matteo F. Vescovi [Mon, 24 Mar 2014 07:48:07 +0000 (08:48 +0100)]
Fix compilation on unofficial 64bit archs

5 years agoFix compilation error non non-linux architectures
Matteo F. Vescovi [Mon, 26 May 2014 07:37:54 +0000 (09:37 +0200)]
Fix compilation error non non-linux architectures

5 years agoFix T40457: Subsurf modifier with Freestyle edges
Sergey Sharybin [Mon, 2 Jun 2014 08:24:25 +0000 (14:24 +0600)]
Fix T40457: Subsurf modifier with Freestyle edges

You can't use ORIG index as an index to copy CD from source DM.

5 years agoImprove behavior of Setup Tracking Scene when default nodes exists in the tree
Sergey Sharybin [Mon, 2 Jun 2014 07:12:01 +0000 (13:12 +0600)]
Improve behavior of Setup Tracking Scene when default nodes exists in the tree

5 years agoFix possible issues when blender is compiled without Cycles
Sergey Sharybin [Mon, 2 Jun 2014 06:55:05 +0000 (12:55 +0600)]
Fix possible issues when blender is compiled without Cycles

5 years agoKeep active layer when setting up tracking scene
Sergey Sharybin [Mon, 2 Jun 2014 06:46:55 +0000 (12:46 +0600)]
Keep active layer when setting up tracking scene

When you hit "setup tracking scene" in MCE, the active layer usually switches
to the layer where the ground has been created, thus he shadow layer.

New objects are created or appended on that layer which means they will be
default be rendered as shadows only. This behaviour requires muscle memory
and is confusing for new users. This patch is changing the behaviour in a
way that the active layer is remembered from before setting up the scene.

Patch by gottfried, thanks!

Reviewers: sebastian_k, sergey

Differential Revision: https://developer.blender.org/D574

5 years agoFreestyle: Minor fixes.
Tamito Kajiyama [Mon, 2 Jun 2014 06:31:31 +0000 (15:31 +0900)]
Freestyle: Minor fixes.

- Fixed a typo in docstring.
- Replaced int with boolean constants.
- Updated lists of base classes for used-defined unary 0D/1D functions.

5 years agoFix T40342 smooth shading flag in dyntopo does not work under MSVC.
Antony Riakiotakis [Sun, 1 Jun 2014 17:44:12 +0000 (20:44 +0300)]
Fix T40342 smooth shading flag in dyntopo does not work under MSVC.

Classic case of integer flag AND-ing result passed to boolean and
failing.

5 years agoFix T40459: Gauss table can be NULL when ending the blur node operation,
Lukas Tönne [Sun, 1 Jun 2014 14:30:58 +0000 (16:30 +0200)]
Fix T40459: Gauss table can be NULL when ending the blur node operation,
which must not be passed to MEM_freeN.

5 years agoFix T40447: Creating Rigid Bodies is rejected for meshes without polys.
Lukas Tönne [Sun, 1 Jun 2014 13:54:58 +0000 (15:54 +0200)]
Fix T40447: Creating Rigid Bodies is rejected for meshes without polys.

This check prevents using empty (no faces) meshes as rigid bodies.
While the idea makes sense, it also prevents using modifier-constructed
meshes, where faces are added only by the modifiers.

Further the check is very easy to circumvent, by removing faces after
making the rigid body, or by assigning a different mesh datablock
afterward.

Suggested by Fabian Emmes (@der_fab).

5 years agoSync changes with buildbot server
Sergey Sharybin [Sun, 1 Jun 2014 12:31:25 +0000 (18:31 +0600)]
Sync changes with buildbot server

5 years agoFix T40315: Boolean modifier with Freestyle edges.
Tamito Kajiyama [Thu, 29 May 2014 08:24:25 +0000 (17:24 +0900)]
Fix T40315: Boolean modifier with Freestyle edges.

The helper function `make_freestyle_edge_mark_hash()` was referring to the
original mesh to determine Freestyle edge marks for individual derived mesh edges.
This is no longer necessary now that derived meshes deliver CD_FREESTYLE_EDGE
and CD_FREESTYLE_FACE layers of their own.  The reference of the original mesh
was also inappropriate since the edges coming from one of the operands of a boolean
modifier don't have proper CD_ORIGINDEX values but ORIGINDEX_NONE's.

Many thanks to Sergey Sharybin for patch contributions and discussions.

5 years agoFix a typo in a comment.
Tamito Kajiyama [Wed, 28 May 2014 03:18:53 +0000 (12:18 +0900)]
Fix a typo in a comment.

5 years agoCode cleanup, unused variables and comments.
Thomas Dinges [Sun, 1 Jun 2014 05:13:52 +0000 (07:13 +0200)]
Code cleanup, unused variables and comments.

5 years agoCycles: Small optimization for scenes without Transparent Shaders, helps a few percent.
Thomas Dinges [Sun, 1 Jun 2014 05:11:13 +0000 (07:11 +0200)]
Cycles: Small optimization for scenes without Transparent Shaders, helps a few percent.

Differential Revision: https://developer.blender.org/D570

5 years agoAdd debug define for timing polyfill
Campbell Barton [Sat, 31 May 2014 11:37:51 +0000 (21:37 +1000)]
Add debug define for timing polyfill

5 years agoFix uninitialized var in recent change to cursor drawing
Campbell Barton [Sat, 31 May 2014 07:30:04 +0000 (17:30 +1000)]
Fix uninitialized var in recent change to cursor drawing

5 years agoFix incorrect flag checks for project-paint face winding
Campbell Barton [Sat, 31 May 2014 07:29:02 +0000 (17:29 +1000)]
Fix incorrect flag checks for project-paint face winding

5 years agoFix EdgeSlide behavior with boundry edges
Campbell Barton [Sat, 31 May 2014 03:56:54 +0000 (13:56 +1000)]
Fix EdgeSlide behavior with boundry edges

- would flip in opposite directions sometimes on the same loop
- some vertices would get directions from adjacent vertices

5 years agoFix T37618 Bevel mismatched offsets and bad profile plane.
Howard Trickey [Fri, 30 May 2014 20:07:45 +0000 (16:07 -0400)]
Fix T37618 Bevel mismatched offsets and bad profile plane.

Used a different technique to resolve "impossible" offset cases
that makes more consistency. Also changed the plane in which
the profile lies for the case with only one beveled edge and
more than 3 other edges.

5 years agoFix T40445: Disabled modifiers prevent cage edit mode.
Bastien Montagne [Fri, 30 May 2014 18:22:23 +0000 (20:22 +0200)]
Fix T40445: Disabled modifiers prevent cage edit mode.

No valid reason to make non-mapping modifiers break edit cage,
when they are disabled in 3DView/edit mode!

5 years agoCleanup: Remove unused total power Emission code in Cycles, that was never exposed...
Thomas Dinges [Fri, 30 May 2014 12:32:32 +0000 (14:32 +0200)]
Cleanup: Remove unused total power Emission code in Cycles, that was never exposed in the UI.

Differential Revision: https://developer.blender.org/D562

5 years agoFix T40438: Name of texture is not synchronize
Sergey Sharybin [Fri, 30 May 2014 10:26:29 +0000 (16:26 +0600)]
Fix T40438: Name of texture is not synchronize

5 years agoFix T40078: GLSL Lamp with OnlyShadow makes weird colors in object.
IRIE Shinsuke [Fri, 30 May 2014 07:57:15 +0000 (16:57 +0900)]
Fix T40078: GLSL Lamp with OnlyShadow makes weird colors in object.

To prevent only shadow lamps from producing negative colors, shr->diff
and shr->spec should've been clamped to positive values after lamp loop.

5 years agoBake-API: replacing some MEM_callocN by MEM_mallocN
Dalai Felinto [Fri, 30 May 2014 02:18:21 +0000 (23:18 -0300)]
Bake-API: replacing some MEM_callocN by MEM_mallocN

As suggested and reviewed by Campbell Barton. This is the most trivial of the cases. I will look if I can do it elsewhere in the bake code

5 years agoBake-API: Support for batch baking
Dalai Felinto [Fri, 30 May 2014 01:54:57 +0000 (22:54 -0300)]
Bake-API: Support for batch baking

When "Selected to Active" is not on, we bake all the selected objects.
This is the same behaviour we have for Blender Internal.

Dev note: I moved most of the validation tests to outside the bake()
routine so the function can be called in loop.

Reviewers: campbellbarton

Differential Revision: https://developer.blender.org/D560

5 years agoUI: fix for drawing textselect outside of button
Campbell Barton [Fri, 30 May 2014 00:20:58 +0000 (10:20 +1000)]
UI: fix for drawing textselect outside of button

also draw cursor even when there is a selection.

5 years agoFollowup to rB1973b17fce65, partially bring back GLSL lamp's previous behavior.
IRIE Shinsuke [Thu, 29 May 2014 05:53:33 +0000 (14:53 +0900)]
Followup to rB1973b17fce65, partially bring back GLSL lamp's previous behavior.

Using layer visibility in active render layer makes more accurate
preview but can cause problems in some cases:

https://developer.blender.org/rB1973b17fce65a4dfececb45b19abec37898c1ab5#comment-1

GLSL lamps now ignore layer visibility if lock_camera_and_layers is
OFF or game engine is running. The material lamp group still works
unconditionally though.

5 years agoFix T40422: EdgeSlide works incorrectly with boundry edges
Campbell Barton [Thu, 29 May 2014 15:49:36 +0000 (01:49 +1000)]
Fix T40422: EdgeSlide works incorrectly with boundry edges

5 years agoProper fix T40156 Cycles Baking and applyRotation issues
Dalai Felinto [Thu, 29 May 2014 15:20:29 +0000 (12:20 -0300)]
Proper fix T40156 Cycles Baking and applyRotation issues

This should be the final fix for the applyrotation issue. It baffles me
that the fix involves discarding the scale transformations for the
normals but it works so I'm happy with it.

Reviewers: campbellbarton

Differential Revision: https://developer.blender.org/D554

5 years agoMath lib: add negate_m3, negate_m4
Campbell Barton [Thu, 29 May 2014 14:26:05 +0000 (00:26 +1000)]
Math lib: add negate_m3, negate_m4

5 years agoFix T39804: cycles smoke domain visible in rendering.
Brecht Van Lommel [Thu, 29 May 2014 12:12:12 +0000 (14:12 +0200)]
Fix T39804: cycles smoke domain visible in rendering.

Transparent objects could become subtly visible by the different sampling
patterns for pixels covered and not covered by the object. It still converged
to the right solution but that can take a while. Now we try to use the same
sampling pattern here.

5 years agoFix T40408: world MIS + equiangular sampling giving unnecessary noise.
Brecht Van Lommel [Thu, 29 May 2014 11:20:42 +0000 (13:20 +0200)]
Fix T40408: world MIS + equiangular sampling giving unnecessary noise.

It's actually not possible to do equiangular sampling for distant lights, now
it reverts to distance sampling in this case.

5 years agoComments: Note direction in doxy args
Campbell Barton [Thu, 29 May 2014 12:05:07 +0000 (22:05 +1000)]
Comments: Note direction in doxy args

5 years agoFix T39174 Bevel didn't maintain edge attributes.
Howard Trickey [Thu, 29 May 2014 11:32:16 +0000 (07:32 -0400)]
Fix T39174 Bevel didn't maintain edge attributes.

When rebuilding the polygons that touch bevel-involved vertices,
need to copy the edge attributes from corresponding original edges.
Special treatment of corner segments, to maintain continuity of
smooth and seam attributes.
Another fix: if have four meeting edges, two opposite ones beveled
and the other two not, propgate the non-beveled-edges attributes
across the line that joins them (perpendicular to the bevel).

5 years agoCleanup: Use doxy for more structured comments
Campbell Barton [Thu, 29 May 2014 11:16:04 +0000 (21:16 +1000)]
Cleanup: Use doxy for more structured comments

5 years agoSequencer: use escaping for sequence names
Campbell Barton [Thu, 29 May 2014 10:26:19 +0000 (20:26 +1000)]
Sequencer: use escaping for sequence names

5 years agoBLI_dynstr: add assert to check curlen is correct
Campbell Barton [Thu, 29 May 2014 10:25:03 +0000 (20:25 +1000)]
BLI_dynstr: add assert to check curlen is correct

5 years agoFix OpenCL compilation error in Cycles, when building without hair support.
Thomas Dinges [Thu, 29 May 2014 10:38:03 +0000 (12:38 +0200)]
Fix OpenCL compilation error in Cycles, when building without hair support.

5 years agoFix T39686: nused omp firstprivate variable sphdata in particles
Sergey Sharybin [Thu, 29 May 2014 09:19:40 +0000 (15:19 +0600)]
Fix T39686: nused omp firstprivate variable sphdata in particles

5 years agoOSX: fix T40413, automatic threads for compile throw wrong output
Jens Verwiebe [Thu, 29 May 2014 09:15:32 +0000 (11:15 +0200)]
OSX: fix T40413, automatic threads for compile throw wrong output

5 years agoFix T40414: Multiple input nodes in a group not working.
Lukas Tönne [Thu, 29 May 2014 08:00:21 +0000 (10:00 +0200)]
Fix T40414: Multiple input nodes in a group not working.

A node group can have multiple input nodes. In the compositor that means
each of the input sockets has to be connected to the linked outputs,
which is represented by a single link on the outside of the group.

5 years agoFix T40411: UI incorrectly permits changing materal_slots on linked obdata
Campbell Barton [Thu, 29 May 2014 06:16:31 +0000 (16:16 +1000)]
Fix T40411: UI incorrectly permits changing materal_slots on linked obdata

5 years agoUI: make it clear edge functions handle multiple loops/rings
Campbell Barton [Thu, 29 May 2014 05:28:09 +0000 (15:28 +1000)]
UI: make it clear edge functions handle multiple loops/rings

5 years agoRevert "fix T40375 Glossy shader bakes different than render"
Dalai Felinto [Thu, 29 May 2014 04:16:45 +0000 (01:16 -0300)]
Revert "fix T40375 Glossy shader bakes different than render"

This reverts commit 12abe94de827d9ae9c0dd6cc49bc6c3e377842ad.

After a long discussion in the bug tracker we decided baking should use
the faces normals for glossy (and combined). This is what Blender
Internal is doing, and one of the more predictable way of yielding
predictable results.

That also means the result will not match the render perfectly, but this
is preferrable over the alternatives at hand.

Conflicts:
intern/cycles/kernel/kernel_bake.h

5 years agoFix T40381 and revert previous commit.
Antony Riakiotakis [Thu, 29 May 2014 02:22:44 +0000 (05:22 +0300)]
Fix T40381 and revert previous commit.

Looks like the normal update flag is used internally in the modifier
itself. So as a workaround just pass normal update to the nodes when
flood filling

5 years agoRelated to T40381,
Antony Riakiotakis [Thu, 29 May 2014 02:04:39 +0000 (05:04 +0300)]
Related to T40381,

Cleanup the normal flag or else the smooth tool will work on more and
more nodes as we sculpt.

5 years agoAdd notifiers and reuse update calls for flood fill operators
Antony Riakiotakis [Thu, 29 May 2014 01:47:42 +0000 (04:47 +0300)]
Add notifiers and reuse update calls for flood fill operators

5 years agoFix T40412: Moving mask layers does not invalidate mask drawing in the movie clip...
Thomas Beck [Wed, 28 May 2014 17:57:53 +0000 (19:57 +0200)]
Fix T40412: Moving mask layers does not invalidate mask drawing in the movie clip editor

Issue was caused by a missing WM_event_add_notifier(..) in the mask_layer_move_exec() function...

5 years agoFix T40157: Loading movies larger than 4GB in size fails
Sergey Sharybin [Wed, 28 May 2014 16:50:40 +0000 (22:50 +0600)]
Fix T40157: Loading movies larger than 4GB in size fails

Issue was caused by _wstat returning EOVERFLOW error because
of file size didn't fit into stat structure which was using
long datatype.

The idea of this patch is to use _wstat64 and _stat64 structure
which is capable storing 64bit file sizes.

Made it a typedef for stat structure used by BLI_stat function
in order to make code easier to follow and avoid ifdefs all
over the place.

Additionally solved issue with BLI_exists which was wrongly
returning False in cases destination file is larger then 4GB.

5 years agoFix T40405: Blender crashes on FBX export instantly.
Bastien Montagne [Wed, 28 May 2014 16:37:30 +0000 (18:37 +0200)]
Fix T40405: Blender crashes on FBX export instantly.
Better fix than rBbef5cb3aa2e5a: consider edges between faces with opposed normals as sharp.

In fact, previous code was broken more deeply in this case (inconsistent normals across
a 'smooth fan') - some loop normals would even never be computed!

Fixing this is possible (even wrote it, actually), but this adds more complexity
to a piece of code that is already awfully complicated, *and* normals in that kind
of smooth fan do not make much sense anyway. So simpler and nicer results with
assuming sharp edges between such 'opposed' faces!

Note that there is some face (loop) ordering black magic at work here, added more comments
to try to explain how and why all this works.

As a bonus, we do not need to check for already computed loop normals anymore, since we
know each 'smooth fan' will be walked once, and only once.

5 years agoFound another bmesh func that invalidates loop indices...
Bastien Montagne [Wed, 28 May 2014 16:34:26 +0000 (18:34 +0200)]
Found another bmesh func that invalidates loop indices...

5 years agoFix T40386: cycles anisotropic BSDF difference between SVM and OSL.
Brecht Van Lommel [Wed, 28 May 2014 14:20:12 +0000 (16:20 +0200)]
Fix T40386: cycles anisotropic BSDF difference between SVM and OSL.

5 years agoFix T40338: Vertex transform origin ignores Normalize option in graph editor
Sergey Sharybin [Wed, 28 May 2014 13:45:06 +0000 (19:45 +0600)]
Fix T40338: Vertex transform origin ignores Normalize option in graph editor

Simply apply unit scale on curve transdata and un-apply on flush.

Needs some more intense testing tho.

5 years agoFix mask transform when display aspect is not 1:1
Sergey Sharybin [Wed, 28 May 2014 12:44:15 +0000 (18:44 +0600)]
Fix mask transform when display aspect is not 1:1

Requires some more intense testing.

5 years agoFix T40405: Blender crashes on FBX export instantly.
Bastien Montagne [Wed, 28 May 2014 11:47:37 +0000 (13:47 +0200)]
Fix T40405: Blender crashes on FBX export instantly.

This crash can only happen in case faces in same 'smooth fan' have reversed normals.
To support this, we have to always keep a way to get real values in loop_to_poly,
even when loop itself is tagged as done, it might be needed in computation of one of
its neighbor's split normal later.

5 years agoAdd asserts to BKE_mesh_normals_loop_split
Campbell Barton [Wed, 28 May 2014 10:49:34 +0000 (20:49 +1000)]
Add asserts to BKE_mesh_normals_loop_split

5 years agoFix T40272: Error setting option flags2 to value fastpskip
Sergey Sharybin [Wed, 28 May 2014 10:11:59 +0000 (16:11 +0600)]
Fix T40272: Error setting option flags2 to value fastpskip

5 years agoStyle cleanup
Sergey Sharybin [Wed, 28 May 2014 09:56:54 +0000 (15:56 +0600)]
Style cleanup