5 months agoMerge branch 'master' into soc-2018-npr Fix errors
Yiming Wu [Sat, 20 Apr 2019 06:10:24 +0000 (14:10 +0800)]
Merge branch 'master' into soc-2018-npr Fix errors

# Conflicts:
# intern/opensubdiv/internal/
# intern/opensubdiv/internal/
# release/scripts/startup/bl_ui/
# source/blender/CMakeLists.txt
# source/blender/blenkernel/intern/scene.c
# source/blender/blenloader/intern/readfile.c
# source/blender/blenloader/intern/versioning_280.c
# source/blender/blenloader/intern/writefile.c
# source/blender/bmesh/intern/bmesh_polygon.c
# source/blender/draw/CMakeLists.txt
# source/blender/draw/intern/draw_manager.c
# source/blender/draw/modes/object_mode.c
# source/blender/editors/mesh/editmesh_tools.c
# source/blender/editors/mesh/mesh_ops.c
# source/blender/editors/render/render_intern.h
# source/blender/editors/render/render_ops.c
# source/blender/editors/space_outliner/outliner_draw.c
# source/blender/editors/space_view3d/space_view3d.c
# source/blender/makesdna/DNA_light_types.h
# source/blender/makesdna/DNA_modifier_types.h
# source/blender/makesdna/DNA_scene_types.h
# source/blender/makesdna/intern/makesdna.c
# source/blender/makesrna/intern/CMakeLists.txt
# source/blender/makesrna/intern/makesrna.c
# source/blender/makesrna/intern/rna_modifier.c
# source/blender/makesrna/intern/rna_scene.c
# source/blender/modifiers/CMakeLists.txt
# source/blender/modifiers/intern/MOD_util.c

5 months agoOutliner: Simplify logic for parent nesting
Dalai Felinto [Fri, 19 Apr 2019 22:02:05 +0000 (19:02 -0300)]
Outliner: Simplify logic for parent nesting

5 months agoEdit Mode: Make edit edges black by default
Clément Foucault [Fri, 19 Apr 2019 17:39:44 +0000 (19:39 +0200)]
Edit Mode: Make edit edges black by default

This is in order to have better contrast now that
the edges are half transparent if not
in edge selection.

5 months agoDRW: Expose VBO garbage collection timings
Clément Foucault [Fri, 19 Apr 2019 16:52:38 +0000 (18:52 +0200)]
DRW: Expose VBO garbage collection timings

This adds user side options to tweak the behavior
of the vbo garbage collection.

5 months agoT63644: Editing while parented is not rotating correctly
Antonioya [Fri, 19 Apr 2019 15:07:45 +0000 (17:07 +0200)]
T63644:  Editing while parented is not rotating correctly

This commit tries to fix the rotation problem when the parent is at layer level.

The problem was the object location was not used, so all object not in origin got weird transformations.

5 months agoFix T63669: Particle editing bypassing occlusion.
mano-wii [Fri, 19 Apr 2019 14:49:17 +0000 (11:49 -0300)]
Fix T63669: Particle editing bypassing occlusion.

The problem occurs because status changes between BackBuffer and Offscreen.

Reviewers: fclem

Differential Revision:

5 months agoFix T63648: Missing update when changing particle force fields
Sergey Sharybin [Fri, 19 Apr 2019 13:38:45 +0000 (15:38 +0200)]
Fix T63648: Missing update when changing particle force fields

Force fields requires relations update in the dependency graph.

5 months agoCleanup: Remove dead code
Sergey Sharybin [Fri, 19 Apr 2019 13:36:18 +0000 (15:36 +0200)]
Cleanup: Remove dead code

There is no more sorting happening, so the comment is out of date
by manu reasons. If something extra is needed there it would need
to be done differently anyway.

5 months agoEdit Mode: Reduce Selected face alpha
Clément Foucault [Fri, 19 Apr 2019 13:18:45 +0000 (15:18 +0200)]
Edit Mode: Reduce Selected face alpha

This is to be less intrusive when doing UV mapping. They remain enough visible
in every select mode

5 months agoEdit Mode: Change face mode edges display
Clément Foucault [Fri, 19 Apr 2019 13:08:46 +0000 (15:08 +0200)]
Edit Mode: Change face mode edges display

This improve visibility in edit face select mode by using the face select color
instead of the edge select color (which is in default theme a bit more red). Also
makes the selected edges in this mode a bit more opaque (0.75 instead of  0.4).
Full opacity is still reserved for edge select mode.

5 months agoDRW: Add batch garbage collection
Clément Foucault [Fri, 19 Apr 2019 00:22:22 +0000 (02:22 +0200)]
DRW: Add batch garbage collection

This is only working for shading batches for the moment and only if some Custom data layer are not needed anymore.

The collection rate is hardcoded at 60 sec but could be exposed to the user.

This system can be extended and discard most unused batches in the future.

This commit is in prevision of removing BKE_MESH_BATCH_DIRTY_SHADING when changing shader parameters.

5 months agoDRW: Make shaded batch validation more correct
Clément Foucault [Thu, 18 Apr 2019 15:25:04 +0000 (17:25 +0200)]
DRW: Make shaded batch validation more correct

This is in order to support garbage collection of unused Custom data layer uploaded to the GPU.

Actual Garbage Collection is not added by this commit.

5 months agoCleanup: Remove image preview code
Sergey Sharybin [Fri, 19 Apr 2019 10:05:51 +0000 (12:05 +0200)]
Cleanup: Remove image preview code

Was commented out for literally 10 years.

5 months agoCleanup: Remove unneeded compositor update function
Sergey Sharybin [Fri, 19 Apr 2019 09:53:00 +0000 (11:53 +0200)]
Cleanup: Remove unneeded compositor update function

Similar to previous commit.

Compositing with animation on socket values and image sequences
still works fine.

5 months agoCleanup: Remove unneeded texture nodes update function
Sergey Sharybin [Fri, 19 Apr 2019 09:11:27 +0000 (11:11 +0200)]
Cleanup: Remove unneeded texture nodes update function

The function was calling update() on the time curve, but there
is no update callback on that node. So, effectively the function
was doing nothing.

5 months agoFix error in recently added STR_ELEM macro
Campbell Barton [Fri, 19 Apr 2019 12:49:57 +0000 (14:49 +0200)]
Fix error in recently added STR_ELEM macro

Very bad oversight, using pointer comparison instead of strcmp
for all but the first item.

5 months agoCMake: fix Cycles linking with OpenCL
Campbell Barton [Fri, 19 Apr 2019 12:00:16 +0000 (14:00 +0200)]
CMake: fix Cycles linking with OpenCL

5 months agoCMake: fix building without smoke enabled
Campbell Barton [Fri, 19 Apr 2019 11:54:43 +0000 (13:54 +0200)]
CMake: fix building without smoke enabled

Was removed when removing sorted libs however it's needed for stubs.

5 months agoFix/workaround crash using ED_area_do_msg_notify_tag_redraw
Campbell Barton [Fri, 19 Apr 2019 10:42:09 +0000 (12:42 +0200)]
Fix/workaround crash using ED_area_do_msg_notify_tag_redraw

Temporary workaround for crash when refreshing the active tool.

Currently ED_region_tag_redraw fails, use notifiers until
this is resolved.

5 months agoUI: minor layout tweaks to 3D viewport gizmo menu
Brecht Van Lommel [Fri, 19 Apr 2019 10:26:11 +0000 (12:26 +0200)]
UI: minor layout tweaks to 3D viewport gizmo menu

5 months agoUI: tweak header context menu, gray out items when they have no effect
Brecht Van Lommel [Fri, 19 Apr 2019 09:53:06 +0000 (11:53 +0200)]
UI: tweak header context menu, gray out items when they have no effect

5 months agoKeymap: add 'Adjust Last Operation' as F9
Campbell Barton [Fri, 19 Apr 2019 07:49:36 +0000 (09:49 +0200)]
Keymap: add 'Adjust Last Operation' as F9

Adding this back was a frequent request.

Now the panel can be hidden - some users may prefer only to access this
via a shortcut.

Unfortunately this uses an F-Key we'd intended to keep free for users.

This still keeps the middle block of F-Keys (5..8) free.

5 months agoKeymap: add set start/end shortcuts to graph editor
Campbell Barton [Fri, 19 Apr 2019 07:36:44 +0000 (09:36 +0200)]
Keymap: add set start/end shortcuts to graph editor

5 months agoKeymap: restore Ctrl-Tab in the dopesheet (removed by accident)
Campbell Barton [Fri, 19 Apr 2019 07:35:53 +0000 (09:35 +0200)]
Keymap: restore Ctrl-Tab in the dopesheet (removed by accident)

Mistake in 6aef124e7d2869a6

5 months agoCorrect cleanup marking keyword args unused
Campbell Barton [Fri, 19 Apr 2019 06:26:18 +0000 (08:26 +0200)]
Correct cleanup marking keyword args unused

5 months agoCleanup: remove redundant poll functions
Campbell Barton [Fri, 19 Apr 2019 06:13:56 +0000 (08:13 +0200)]
Cleanup: remove redundant poll functions

5 months agoCleanup: logical checks in UI scripts
Campbell Barton [Fri, 19 Apr 2019 06:10:39 +0000 (08:10 +0200)]
Cleanup: logical checks in UI scripts

5 months agoCleanup: trailing commas
Campbell Barton [Fri, 19 Apr 2019 06:07:46 +0000 (08:07 +0200)]
Cleanup: trailing commas

5 months agoCleanup: unused vars
Campbell Barton [Fri, 19 Apr 2019 05:52:53 +0000 (07:52 +0200)]
Cleanup: unused vars

5 months agoCleanup: use staticmethod where appropriate
Campbell Barton [Fri, 19 Apr 2019 05:51:14 +0000 (07:51 +0200)]
Cleanup: use staticmethod where appropriate

5 months agoMissing from last commit
Campbell Barton [Fri, 19 Apr 2019 05:49:49 +0000 (07:49 +0200)]
Missing from last commit

5 months agoCleanup: correct misleading classmethod arg
Campbell Barton [Fri, 19 Apr 2019 05:36:07 +0000 (07:36 +0200)]
Cleanup: correct misleading classmethod arg

5 months agoCleanup: mark unused arguments in UI scripts
Campbell Barton [Fri, 19 Apr 2019 05:32:24 +0000 (07:32 +0200)]
Cleanup: mark unused arguments in UI scripts

Quiet's pylint W0613 warning, also remove some unused args.

5 months agoUI: move top-bar into the spaces header
Campbell Barton [Thu, 18 Apr 2019 19:13:22 +0000 (21:13 +0200)]
UI: move top-bar into the spaces header

Currently this is only in the 3D viewport however all spaces
that use the tool-system will have this region added.

D4680 by @brecht with own updates.

5 months agoArmature: remove remains of the object-level deformation data cache.
Alexander Gavrilov [Thu, 18 Apr 2019 20:17:04 +0000 (23:17 +0300)]
Armature: remove remains of the object-level deformation data cache.

Now that B-Bone shape data is kept in bPoseChannel_Runtime, the
armature level cache only holds one quaternion value per bone.
It can also be moved to runtime, and the structure removed.

This has an additional effect that, as far as I can tell, now
the Armature modifier can run as soon as all of the bones it
actually needs are done, thus making T59848 a purely depsgraph
level problem.

5 months agoUI: Revert fix T37463: Y-clamp for header-only spaces
Campbell Barton [Thu, 18 Apr 2019 19:19:49 +0000 (21:19 +0200)]
UI: Revert fix T37463: Y-clamp for header-only spaces

This reverts 91d8519c4782 since I can't redo the reported error
which was in the old header-only info space.

5 months agoPyTests: do not load addons in load_py_modules test.
Bastien Montagne [Thu, 18 Apr 2019 19:11:40 +0000 (21:11 +0200)]
PyTests: do not load addons in load_py_modules test.

It makes no sense to load add-ons here, we already do that (in a more
complete way) in load_addons test, this is only adding overhead and
doubling code to maintain).

Also do not try to load-as-modules add-ons that are not 2.8-ready, and
some other misc fix.

load_py_modules test should be passing again now.

Thanks to @sergey who did part of the work here as well.

5 months agoFix T63332: backup and restore bPoseChannel_Runtime data during COW.
Alexander Gavrilov [Thu, 18 Apr 2019 18:19:57 +0000 (21:19 +0300)]
Fix T63332: backup and restore bPoseChannel_Runtime data during COW.

5 months agoImages: support packing edited images as OpenEXR or PNG.
Brecht Van Lommel [Sat, 20 Feb 2016 13:52:36 +0000 (14:52 +0100)]
Images: support packing edited images as OpenEXR or PNG.

This way float and multilayer images can now be packed without data loss. This
removes the as_png option and always uses the appropriate file format depending
on the image contents.

5 months agoCleanup: unused region init functions
Campbell Barton [Thu, 18 Apr 2019 18:02:09 +0000 (20:02 +0200)]
Cleanup: unused region init functions

5 months agoUI: collapse 3D view collections visibility panel by default.
Brecht Van Lommel [Thu, 18 Apr 2019 17:14:19 +0000 (19:14 +0200)]
UI: collapse 3D view collections visibility panel by default.

5 months agoOpenEXR: add support for writing EXR files to memory.
Brecht Van Lommel [Sat, 20 Feb 2016 13:52:36 +0000 (14:52 +0100)]
OpenEXR: add support for writing EXR files to memory.

5 months agoCleanup: deduplicate single/multiview image packing code.
Brecht Van Lommel [Sat, 3 Mar 2018 15:55:08 +0000 (16:55 +0100)]
Cleanup: deduplicate single/multiview image packing code.

5 months agoCleanup: move image saving code to blenkernel.
Brecht Van Lommel [Sun, 14 Apr 2019 22:24:00 +0000 (00:24 +0200)]
Cleanup: move image saving code to blenkernel.

5 months agoCleanup: make image saving code reusable outside operator.
Brecht Van Lommel [Sat, 20 Feb 2016 21:39:20 +0000 (22:39 +0100)]
Cleanup: make image saving code reusable outside operator.

5 months agoCleanup: deduplicate image user initialization, make consistent.
Brecht Van Lommel [Sat, 20 Feb 2016 21:36:02 +0000 (22:36 +0100)]
Cleanup: deduplicate image user initialization, make consistent.

5 months agoGPencil: Add option to mix color with texture
Antonioya [Thu, 18 Apr 2019 12:19:00 +0000 (14:19 +0200)]
GPencil: Add option to mix color with texture

This was already supported in Fill, but not in Strokes. This adds more artistic options when use textured strokes.

5 months agoCleanup: add trailing commas to avoid right shift
Campbell Barton [Thu, 18 Apr 2019 15:17:32 +0000 (17:17 +0200)]
Cleanup: add trailing commas to avoid right shift

5 months agoPyTests: do not try to load non-2.8-ready add-ons.
Bastien Montagne [Thu, 18 Apr 2019 15:14:17 +0000 (17:14 +0200)]
PyTests: do not try to load non-2.8-ready add-ons.

5 months agoGPencil: Fix Drawing Path follow error while drawing
Antonioya [Thu, 18 Apr 2019 14:59:01 +0000 (16:59 +0200)]
GPencil: Fix Drawing Path follow error while drawing

The strokes was aligned to drawing path only when the stroke was completed. Now, the stroke is aligned while drawing too.

5 months agoGPencil: Initialize variable to remove console warning
Antonioya [Thu, 18 Apr 2019 14:57:41 +0000 (16:57 +0200)]
GPencil: Initialize variable to remove console warning

5 months agoMissing 2.7x keymap update from last commit
Campbell Barton [Thu, 18 Apr 2019 14:41:38 +0000 (16:41 +0200)]
Missing 2.7x keymap update from last commit

5 months agoUI: replace toggle header with a property
Campbell Barton [Thu, 18 Apr 2019 14:35:11 +0000 (16:35 +0200)]
UI: replace toggle header with a property

5 months agoAlembic: catch weird exceptions from library instead of aborting Blender.
Bastien Montagne [Thu, 18 Apr 2019 14:19:17 +0000 (16:19 +0200)]
Alembic: catch weird exceptions from library instead of aborting Blender.

Similar to what is done e.g. in AbcMeshReader::read_mesh()...

5 months agoAMD glitch: missing changes in f41ab375f38b
mano-wii [Thu, 18 Apr 2019 13:53:00 +0000 (10:53 -0300)]
AMD glitch: missing changes in f41ab375f38b

It was committed an earlier version of the patch which missed these changes.

Differential Revision:

5 months agoCleanup: add 'if 0' comment why code is repeated
Campbell Barton [Thu, 18 Apr 2019 13:16:36 +0000 (15:16 +0200)]
Cleanup: add 'if 0' comment why code is repeated

Avoid potentially adding back the problem in the future.

5 months agoFix T62792: AMD glitch when clipping region in edit mode.
mano-wii [Thu, 18 Apr 2019 12:37:07 +0000 (09:37 -0300)]
Fix T62792: AMD glitch when clipping region in edit mode.

The `AMD Radeon HD 7600M` compiler is usually buggy for Geometry Shaders.
In this case, indexing was causing problems in `gl_in[i].gl_ClipDistance[0]`.

Reviewers: fclem

Differential Revision:

5 months agoPyAPI: remove support for importing text blocks as modules
Campbell Barton [Thu, 18 Apr 2019 12:45:23 +0000 (14:45 +0200)]
PyAPI: remove support for importing text blocks as modules

Allowing direct import of text blocks isn't especially useful,
instead add `text.as_module()` script authors can do this
explicitly if it's needed.

Now the text "Register" option executes
instead of loading as a module.

This removes the need to keep track of the current Main,
and C code to override Python's import & reload.

5 months agoFix T63590: Blender crashes when deleting particle hair keys
Sergey Sharybin [Thu, 18 Apr 2019 12:43:25 +0000 (14:43 +0200)]
Fix T63590: Blender crashes when deleting particle hair keys

5 months agoPython API: allow passing integer to some BGL functions instead of bgl.Buffer
Brecht Van Lommel [Thu, 18 Apr 2019 09:24:39 +0000 (11:24 +0200)]
Python API: allow passing integer to some BGL functions instead of bgl.Buffer

These parameters can be both pointers and offsets into a bound buffer, so we
need to support both even if it's possible to cause crashes this way.

5 months agoFix Embree link error after recent cmake changes
Maruf Sarker [Thu, 18 Apr 2019 12:22:52 +0000 (14:22 +0200)]
Fix Embree link error after recent cmake changes

Differential Revision:

5 months agoUI: option to toggle 'Adjust Last Operation'
Campbell Barton [Thu, 18 Apr 2019 11:49:21 +0000 (13:49 +0200)]
UI: option to toggle 'Adjust Last Operation'

5 months agoCleanup: comments, wrapping
Campbell Barton [Thu, 18 Apr 2019 11:59:59 +0000 (13:59 +0200)]
Cleanup: comments, wrapping

5 months agoUI: Expand Enum Items Over Multiple Rows
Jeroen Bakker [Wed, 17 Apr 2019 13:02:30 +0000 (15:02 +0200)]
UI: Expand Enum Items Over Multiple Rows

Expanding enum items in a small area would render the names with
dots, what is a bad solution. When you use expand directly on a
`grid_flow` or `column_flow`, it will render the items on multiple
lines, giving more control to the developer.

Reviewers: campbellbarton, brecht, mont29

Differential Revision:

5 months agoCleanup: correct comment
Campbell Barton [Thu, 18 Apr 2019 10:52:50 +0000 (12:52 +0200)]
Cleanup: correct comment

5 months agoUI: move region toggling to properties
Campbell Barton [Thu, 18 Apr 2019 10:16:03 +0000 (12:16 +0200)]
UI: move region toggling to properties

Each space had separate operators, duplicating logic.

Use RNA properties instead so adding the ability to toggle other
region types (floating redo region for eg) doesn't need to have an
extra operator per space type.

It's also nicer to show a check-box for something which can be toggled.

5 months agoCMake: correct bad change to ceres linking
Campbell Barton [Thu, 18 Apr 2019 10:30:44 +0000 (12:30 +0200)]
CMake: correct bad change to ceres linking

Revert part of 45055199a2e51

5 months agoFix T63513: Gpencil - Circle guide activation with shortcut "C" is not working properly
Charlie Jolly [Thu, 18 Apr 2019 10:39:13 +0000 (11:39 +0100)]
Fix T63513: Gpencil - Circle guide activation with shortcut "C" is not working properly

Only add missing events after first point is added.

5 months agoDisable clang-format for Libmv
Sergey Sharybin [Thu, 18 Apr 2019 10:33:04 +0000 (12:33 +0200)]
Disable clang-format for Libmv

This is an odd-ball: it's a library which has own style and
guidelines, and just happened to be developed by Blender developers
and also happened to rely on some functionality of intern/ for its

Might consider using Google's clang-format in the future (this is
what the style is supposed to be in this library).

5 months agoFix compilation error when using SDL dynamic loading
Sergey Sharybin [Thu, 18 Apr 2019 10:10:08 +0000 (12:10 +0200)]
Fix compilation error when using SDL dynamic loading

5 months agoMerge branch 'blender2.7'
Sergey Sharybin [Thu, 18 Apr 2019 09:57:44 +0000 (11:57 +0200)]
Merge branch 'blender2.7'

5 months agoBuildbot: Attempt to fix wrong branch in buildinfo
Sergey Sharybin [Wed, 10 Apr 2019 13:46:47 +0000 (15:46 +0200)]
Buildbot: Attempt to fix wrong branch in buildinfo

For some reason the buildinfo header was not re-generated. The root
reason is not really clear to me, so simply remove the header similar
to the CMake cache.

5 months agoFix T63663: Object mode proportional editing affects objects which are disabled for...
Sebastian Parborg [Thu, 18 Apr 2019 09:50:00 +0000 (11:50 +0200)]
Fix T63663: Object mode proportional editing affects objects which are disabled for selection

Objects which are not selectable are no longer affected by
proportional transformations.

5 months agoCleanup: remove last bits of WITH_LEGACY_DEPSGRAPH CMake option.
Bastien Montagne [Thu, 18 Apr 2019 09:34:53 +0000 (11:34 +0200)]
Cleanup: remove last bits of WITH_LEGACY_DEPSGRAPH CMake option.

Legacy depsgraph has been removed from Blender since several months

5 months agoOverlay Engine: Option to Disable AA Ortho Grid
Jeroen Bakker [Wed, 17 Apr 2019 09:35:20 +0000 (11:35 +0200)]
Overlay Engine: Option to Disable AA Ortho Grid

When in Axis alligned orthographic view a grid was always displayed.
With this change the user can enable/disable this grid.

The Grid is always visible and editable, but only rendered active when user is in quad view, or axis aligned ortho view.

Reviewers: brecht, fclem

Maniphest Tasks: T63517

Differential Revision:

5 months agoFix mistake in recent commit.
Jeroen Bakker [Thu, 18 Apr 2019 06:10:38 +0000 (08:10 +0200)]
Fix mistake in recent commit.

Needed to remove footers and not headers

5 months agoclang-format: add statement macro
Campbell Barton [Thu, 18 Apr 2019 06:04:03 +0000 (08:04 +0200)]
clang-format: add statement macro

Disabled for now but corrects syntax when we switch to v8.

5 months agoCleanup: indentation from braces in '#if 0'
Campbell Barton [Thu, 18 Apr 2019 05:52:45 +0000 (07:52 +0200)]
Cleanup: indentation from braces in '#if 0'

5 months agoCleanup: comment blocks
Campbell Barton [Thu, 18 Apr 2019 05:21:26 +0000 (07:21 +0200)]
Cleanup: comment blocks

5 months agoUI: don't expand selection tool option enum
Brecht Van Lommel [Thu, 18 Apr 2019 04:46:51 +0000 (06:46 +0200)]
UI: don't expand selection tool option enum

This was taking too much space.

5 months agoCleanup: move region manipulation to utility functions
Brecht Van Lommel [Thu, 18 Apr 2019 04:48:34 +0000 (06:48 +0200)]
Cleanup: move region manipulation to utility functions

5 months agoCleanup: warnings
Campbell Barton [Thu, 18 Apr 2019 04:51:44 +0000 (06:51 +0200)]
Cleanup: warnings

5 months agocmake: Fix python linker issues on windows.
Ray Molenkamp [Wed, 17 Apr 2019 19:26:02 +0000 (13:26 -0600)]
cmake: Fix python linker issues on windows.

Recent cmake work made the debug build link both python37.dll and python37_d.dll

5 months agoEdit Mode: Rework display to differentiate selection modes
Clément Foucault [Wed, 17 Apr 2019 00:52:15 +0000 (02:52 +0200)]
Edit Mode: Rework display to differentiate selection modes

This removes the large edges and instead use colors to hint in which
selection mode the user is.

The component in each individual selection mode is more prominent to add
more emphasis. The other components are less prominent and dimmed.

A minor default theme changes needed to be made to keep clarity in all

Forcing old behavior (no selection mode hit) could be done quite easily
by just making the 2 booleans true (selectFaces and selectEdges).

Reviewers: campbellbarton, billreynish

Reviewed By: campbellbarton, billreynish

Subscribers: ThinkingPolygons

Maniphest Tasks: T1234

Differential Revision:

5 months agoClangFormat: disable for generated theme
Campbell Barton [Wed, 17 Apr 2019 17:24:38 +0000 (19:24 +0200)]
ClangFormat: disable for generated theme

5 months agoCleanup: line wrapping caused by comments
Campbell Barton [Wed, 17 Apr 2019 16:50:53 +0000 (18:50 +0200)]
Cleanup: line wrapping caused by comments

5 months agoAnimation: Refactor storage usage during fcurve modifier evaluation
Jacques Lucke [Wed, 17 Apr 2019 16:09:33 +0000 (18:09 +0200)]
Animation: Refactor storage usage during fcurve modifier evaluation

Previously, when a fcurve modifier used storage,
many heap allocations were done.
This caused major slowdowns as described in T63656.

Furthermore, the storage usage was a special case only
used by the Cycles modifier. This refactor makes
storage usage the "normal" case.
That reduces the overall complexity.

The storage is stack allocated now.

The framerate on the provided test scene went up from ~5 fps to ~16 fps.

Reviewers: angavrilov

Differential Revision:

5 months agoTests: Fix Alembic regression test
Sergey Sharybin [Wed, 17 Apr 2019 15:39:17 +0000 (17:39 +0200)]
Tests: Fix Alembic regression test

5 months agoTests: Fix ID properties test
Sergey Sharybin [Wed, 17 Apr 2019 10:39:42 +0000 (12:39 +0200)]
Tests: Fix ID properties test

Simply adjust to Python API changes done in 2.8.

5 months agoAvoid autosave name collisions
Jacques Lucke [Wed, 17 Apr 2019 14:54:28 +0000 (16:54 +0200)]
Avoid autosave name collisions

When the same .blend file was open in two instances of Blender,
the autosaved files would overwrite each other.

The solution is to put the pid into the filename.

The exact pattern is the result of a discussion with @pablovazquez.

5 months agoFix T63678 Link error of tests with MSVC.
Ray Molenkamp [Wed, 17 Apr 2019 13:58:48 +0000 (07:58 -0600)]
Fix T63678 Link error of tests with MSVC.

Ideally OCIO removes their log2 implementation from the global namespace
but for now this linker tweak will have to do.

5 months agoGPUBuffers: Remove wrong assert
Clément Foucault [Tue, 16 Apr 2019 23:38:15 +0000 (01:38 +0200)]
GPUBuffers: Remove wrong assert

The assert was not true if the pbvh node had no triangle.

Also update the comment to reflect that.

5 months agoFix T63673: Wrong api documentation for
Jacques Lucke [Wed, 17 Apr 2019 11:48:41 +0000 (13:48 +0200)]
Fix T63673: Wrong api documentation for

5 months agoFix T60982: don't allow editing group properties in linked actions.
Alexander Gavrilov [Wed, 17 Apr 2019 11:43:02 +0000 (14:43 +0300)]
Fix T60982: don't allow editing group properties in linked actions.

5 months agoFix T63674: Incorrect poll methods in node category classes
nBurn [Wed, 17 Apr 2019 11:36:20 +0000 (13:36 +0200)]
Fix T63674: Incorrect poll methods in node category classes

Differential Revision:

5 months agoeditorconfig: correct indent size
Campbell Barton [Wed, 17 Apr 2019 11:34:26 +0000 (13:34 +0200)]
editorconfig: correct indent size

5 months agoFix T63247: edbm_rip_invoke__edge rips unselected verts on mesh borders
Sebastian Parborg [Wed, 17 Apr 2019 10:30:00 +0000 (12:30 +0200)]
Fix T63247: edbm_rip_invoke__edge rips unselected verts on mesh borders

Ripping edges would in some cases rip verts on unselected edges. This is now fixed so that we only rip verts from the actually selected edges.

Reviewed By: Brecht

Differential Revision:

5 months agoFix Change when re-running clang-format 7.
Bastien Montagne [Wed, 17 Apr 2019 09:32:21 +0000 (11:32 +0200)]
Fix Change when re-running clang-format 7.

This was the only broken case for me, hopefully we have nailed all of
those down now.

5 months agoDisable clang-format for objective-C bits in GHOST.
Bastien Montagne [Wed, 17 Apr 2019 08:56:11 +0000 (10:56 +0200)]
Disable clang-format for objective-C bits in GHOST.

Pre-8 versions of clang-format do not handle objective-C very well,
leading to unwanted changes when re-running the edits.

5 months agoCleanup: Silence compiler warning with release builds
Sergey Sharybin [Wed, 17 Apr 2019 08:54:56 +0000 (10:54 +0200)]
Cleanup: Silence compiler warning with release builds