3 years agoGPU: Make changes to GPUIndexBuf and GPUVertBuf to allow multithreading
Clément Foucault [Sat, 8 Dec 2018 17:15:57 +0000 (18:15 +0100)]
GPU: Make changes to GPUIndexBuf and GPUVertBuf to allow multithreading

This is a small change. We delay all gl calls at the first use of the
GPUIndexBuf / GPUVertBuf in order to be able to create multiple buffers
from different threads without having many gl contexts.

3 years agoGPU: Cleanup: Rename vbo to ibo for index buffers
Clément Foucault [Sat, 8 Dec 2018 14:53:23 +0000 (15:53 +0100)]
GPU: Cleanup: Rename vbo to ibo for index buffers

3 years agoFix T58932: Impossible to influence the particle system
Sergey Sharybin [Mon, 10 Dec 2018 16:37:30 +0000 (17:37 +0100)]
Fix T58932: Impossible to influence the particle system

3 years agoFix T58928: New Action causes crash when duplicating bone
Sergey Sharybin [Mon, 10 Dec 2018 14:59:15 +0000 (15:59 +0100)]
Fix T58928: New Action causes crash when duplicating bone

Basically, armature update is not supposed to be run in edit mode.
This worked in master and new dependency graph because nobody was
tagging armature for an update.

But with all those copy-on-write and other things we can't ensure
tag doesn't happen (and we shouldn't). So now we ensure unwanted
code is not run from the code itself.

P.S. Deeper reason of this goes to the optimization of not updating
pose channels when in edit mode. Since pose doesn't define anything
there we don't want to be bothered with a pose update after every
operation which changes it.

3 years agoCycles: Restore properties in the interface
Sergey Sharybin [Mon, 10 Dec 2018 14:54:15 +0000 (15:54 +0100)]
Cycles: Restore properties in the interface

They got lost in one of the merges it seems.

3 years agoCleanup: Variable naming
Sergey Sharybin [Mon, 10 Dec 2018 14:42:18 +0000 (15:42 +0100)]
Cleanup: Variable naming

3 years agoTweak UI message of Ruler tool.
Bastien Montagne [Mon, 10 Dec 2018 14:52:42 +0000 (15:52 +0100)]
Tweak UI message of Ruler tool.

It's much simpler to just click on one end, than dragging it outside of
view. ;)

Related to T59084.

3 years agoFix T57633: Particle texture update problem
Sergey Sharybin [Mon, 10 Dec 2018 14:09:46 +0000 (15:09 +0100)]
Fix T57633: Particle texture update problem

Textures are now hooked up to the RESET operation of particle
settings, which ensures particles being re-distributed when
texture is changed.

This is limited to a direct user modifications, which matches
old behavior in 2.79.

3 years agoCleanup: Someone forgot again to do the versioning_280 handling when bumping subversion.
Bastien Montagne [Mon, 10 Dec 2018 14:06:46 +0000 (15:06 +0100)]
Cleanup: Someone forgot again to do the versioning_280 handling when bumping subversion.

Seriously... There is no point in having those subversions if one does
not take advantage of them to reduce doversion work on file load! Now we
have to raise subversion again just for that. :(

3 years agoProper fix for rigidbody collections's objects missing rb data.
Bastien Montagne [Mon, 10 Dec 2018 14:01:32 +0000 (15:01 +0100)]
Proper fix for rigidbody collections's objects missing rb data.

We cannot let those data be generated on-the-fly in RBW evaluation
anymore, since those would be added to CoW eval object and never ported
back to orig objects.

We *could* get orig objects in eval code, of course, but as in
constratints, this is not really threadsafe and future proof, depsgraph
evaluation should really write back to orig data as little as possible.

So instead, add code to ensure required data is generated to objects
when their collection is added to rigidbody world.

Note that we *may* want to clean that up once collection is no more used
by RB? On the other hand, people might want to keep those data around to
be able to switch between different setups easily... So think it's OK to
keep them at least for now.

3 years agoFix T58993: Duplicating after setting a rigid body world crashes Blender.
Bastien Montagne [Mon, 10 Dec 2018 13:10:12 +0000 (14:10 +0100)]
Fix T58993: Duplicating after setting a rigid body world crashes Blender.

There is no guarantee that object in rigidbody collection already have a
valid rgigidbody data when rebuilding deg relations, that is often
generated on-the-fly by actual rigid body simulation.

Note that this can be an issue when generating deg relations I guess...
But at least it won't crash anymore.

3 years agoFix part of T58964: Changing driver path/array index crashes
Sergey Sharybin [Mon, 10 Dec 2018 13:50:05 +0000 (14:50 +0100)]
Fix part of T58964: Changing driver path/array index crashes

The issue here is that in the new dependency graph drivers are
individual nodes which depends on what they are driving. This
means that changes to RNA path or property index should ensure
those nodes are updated. Easiest way to do so is to tag relations
for update.

3 years agoFix T59087: Empty meshes have large bound-box
Campbell Barton [Mon, 10 Dec 2018 08:27:49 +0000 (19:27 +1100)]
Fix T59087: Empty meshes have large bound-box

Initialize to default values for meshes w/o vertices,
note that zeroing for BKE_object_boundbox_calc_from_mesh
matches old derived mesh code.

3 years agoFix T59107: F3 does not work in Python console
Campbell Barton [Mon, 10 Dec 2018 06:33:36 +0000 (17:33 +1100)]
Fix T59107: F3 does not work in Python console

3 years agoFix T57086: Offset Even option is unclickable
Campbell Barton [Mon, 10 Dec 2018 05:51:53 +0000 (16:51 +1100)]
Fix T57086: Offset Even option is unclickable

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Mon, 10 Dec 2018 01:45:38 +0000 (12:45 +1100)]
Merge branch 'master' into blender2.8

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Mon, 10 Dec 2018 01:44:24 +0000 (12:44 +1100)]
Merge branch 'master' into blender2.8

3 years agoFix T53544: Undo in pose mode selects all fcurves
Campbell Barton [Mon, 10 Dec 2018 01:30:41 +0000 (12:30 +1100)]
Fix T53544: Undo in pose mode selects all fcurves

3 years agoDNA: add runtime struct to for graph & action editor
Campbell Barton [Mon, 10 Dec 2018 00:46:36 +0000 (11:46 +1100)]
DNA: add runtime struct to for graph & action editor

Move struct members, no functional change

3 years agoMerge branch 'master' into blender2.8
Bastien Montagne [Sun, 9 Dec 2018 20:51:23 +0000 (21:51 +0100)]
Merge branch 'master' into blender2.8


3 years agoFix T59059: Blender crashing after adding particle system and dynamic paint (Brush).
Bastien Montagne [Sun, 9 Dec 2018 20:48:37 +0000 (21:48 +0100)]
Fix T59059: Blender crashing after adding particle system and dynamic paint (Brush).

Looks like this bug has been there since ages (at least present before
2.79 official release...).

3 years agoSimplified #ifdef to not silently fail on certain platforms
Sybren A. Stüvel [Sun, 9 Dec 2018 18:24:12 +0000 (19:24 +0100)]
Simplified #ifdef to not silently fail on certain platforms

3 years agoUser Interface: Add button color for indicating that the value differs from the inter...
Lukas Stockner [Fri, 7 Dec 2018 02:26:20 +0000 (03:26 +0100)]
User Interface: Add button color for indicating that the value differs from the interpolated one

One issue that especially newer users often run into is that they accidentally reset changes to the scene by switching frame without creating a keyframe first.

Therefore, this commit adds a new color that is used to draw properties if their current value differs from the one that would be set when switching to this frame.
This works both for existing keyframes as well as for currently interpolated frames.

Unfortunately the flags in but->flag are full, so I had to move the new flag to but->drawflag and pass that to all relevant functions.

I went with orange for the color since afaics it fits with the green and yellow that are currently used for keyframe states and since it's somewhat reddish to signify that there might be something to look out for here.

Reviewers: campbellbarton, #user_interface, brecht

Reviewed By: campbellbarton

Subscribers: brecht, predoe

Differential Revision:

3 years agoFix T51057 Modifiers lose bevel weight and crease
Howard Trickey [Sat, 8 Dec 2018 12:39:46 +0000 (06:39 -0600)]
Fix T51057 Modifiers lose bevel weight and crease

This is for 2.80 (though bug I mistakenly merged into was for 2.78.
Duplicate bugs T58127, T58411, T58440, and T58789 all fixed.
Bevel weights and crease are not real Mesh layers so get lost
on coversion of mesh to bmesh unelss the mesh's cd_flag member
tells the converter to create layers for them.
Most code the copies or partially copies meshes uses
mesh_new_nomain_from_template_ex, so copied the flag there.

3 years agoFix T58950: wireframe/orthographic/front/side/topview crash 2.8
Clément Foucault [Sat, 8 Dec 2018 10:32:45 +0000 (11:32 +0100)]
Fix T58950: wireframe/orthographic/front/side/topview crash 2.8

3 years agoShrinkwrap: use polygon normals for flat faces in Align To Normal.
Alexander Gavrilov [Wed, 5 Dec 2018 17:24:05 +0000 (20:24 +0300)]
Shrinkwrap: use polygon normals for flat faces in Align To Normal.

Hit normal originates from tesselated triangles and isn't the
actual normal used for shading of flat faces. Thus, it is better
to use the actual polygon normals when available.

3 years agoCleanup: style
Campbell Barton [Sat, 8 Dec 2018 04:01:47 +0000 (15:01 +1100)]
Cleanup: style

3 years agoFix T58949: Transform feedback shaders not having fragment shader
Clément Foucault [Fri, 7 Dec 2018 20:19:02 +0000 (21:19 +0100)]
Fix T58949: Transform feedback shaders not having fragment shader

3 years agoUI: Fix typo in hostname stamp tooltip
Pablo Vazquez [Fri, 7 Dec 2018 19:40:24 +0000 (20:40 +0100)]
UI: Fix typo in hostname stamp tooltip

Also change the part "running Blender" for "that rendered the frame".

3 years agoFix T58360 "Use object as pivot" in GP "Shadow effect" crashes Blender
Antonioya [Fri, 7 Dec 2018 19:01:01 +0000 (20:01 +0100)]
Fix T58360 "Use object as pivot" in GP "Shadow effect" crashes Blender

3 years agoMove static `get_hostname()` to `BLI_hostname()` in `system.c`
Sybren A. Stüvel [Fri, 7 Dec 2018 16:36:40 +0000 (17:36 +0100)]
Move static `get_hostname()` to `BLI_hostname()` in `system.c`

This makes the `#include <Windows.h>` use more localised and out of the
`image.c` file.

Reviewers: LazyDodo

Reviewed by: LazyDodo

Differential revision:

3 years agoFix modifiers evaluation outside of depsgraph/CoW context.
Bastien Montagne [Fri, 7 Dec 2018 14:45:53 +0000 (15:45 +0100)]
Fix modifiers evaluation outside of depsgraph/CoW context.

Fix T58237: Exporters: Curve Modifier not applied when "apply modifiers" are selected.
Fix T58856: Python: "to_mesh" broken in 2.8.

...And many other cases... ;)

Thing is, we need target IDs to always be evaluated ones (at least I
cannot see any case where having orig ones is desired effect here).
Depsgraph/Cow system ensures us that when modifiers are evaluated by it,
but they can also be called outside of this context, e.g. when doing
binding, or object conversion...

So we need to ensure in modifiers code that we actually are always
working with eval data for those targets.

Note that I did not touch to physics modifiers, those are a bit touchy
and rather not 'fix' something there until proven broken!

3 years agoRemove unused particle system recalc flag
Sergey Sharybin [Fri, 7 Dec 2018 17:04:13 +0000 (18:04 +0100)]
Remove unused particle system recalc flag

3 years agoRemove obscure debug-only print
Sergey Sharybin [Fri, 7 Dec 2018 17:02:14 +0000 (18:02 +0100)]
Remove obscure debug-only print

The message is not clear for users, and is set for modifier already.

3 years agoFix selected to active Cycles Baking
Dalai Felinto [Fri, 7 Dec 2018 14:15:01 +0000 (12:15 -0200)]
Fix selected to active Cycles Baking

Since we started using looptris we no longer need a triangulation
modifier in the highpoly object. In fact having was causing a bug
where baking would be utterly broken.

This fix normal baking. Combined pass still needs a fix to hide the
objects during baking.

3 years agoCleanup, typo in naming
Sergey Sharybin [Fri, 7 Dec 2018 16:30:19 +0000 (17:30 +0100)]
Cleanup, typo in naming

\Something went wrong in the rename script..

3 years agoMetadata: add hostname to the available metadata options
Sybren A. Stüvel [Fri, 7 Dec 2018 16:28:38 +0000 (17:28 +0100)]
Metadata: add hostname to the available metadata options

Having the hostname allows us to identify which machine rendered which
frame in our render farm.

This simply uses the host's name, and doesn't do any DNS lookup of any
IP address of the machine. As such, it's only usable for identification
purposes, and not for reachability over a network.

Reviewers: sergey, brecht

Reviewed By: sergey

Differential Revision:

3 years agoMerge branch 'master' into blender2.8
Philipp Oeser [Fri, 7 Dec 2018 15:42:36 +0000 (16:42 +0100)]
Merge branch 'master' into blender2.8

3 years agoFix T57994: Particle Instance modifiers 'Index Layer' off by one
Philipp Oeser [Thu, 22 Nov 2018 10:52:38 +0000 (11:52 +0100)]
Fix T57994: Particle Instance modifiers 'Index Layer' off by one

better have this vertex color layer cover the whole 0-1 range

thx @sergey for checking

Maniphest Tasks: T57994

Differential Revision:

3 years agoadd 'Control Points' and 'Segments' editmode menus for Surfaces
Philipp Oeser [Fri, 7 Dec 2018 13:57:54 +0000 (14:57 +0100)]
add 'Control Points' and 'Segments' editmode menus for Surfaces

Fixes T58922

Reviewers: brecht, billreynish

Maniphest Tasks: T58922

Differential Revision:

3 years agoMerge branch 'master' into blender2.8
Sergey Sharybin [Fri, 7 Dec 2018 14:00:48 +0000 (15:00 +0100)]
Merge branch 'master' into blender2.8

3 years agoUpdate BVHTree.FromObject API, remove render argument
Dalai Felinto [Fri, 7 Dec 2018 13:54:24 +0000 (11:54 -0200)]
Update BVHTree.FromObject API, remove render argument

This information should come from the depsgraph.

3 years agoCycles: Do more user-friendly indication that GPU devices are not found
Sergey Sharybin [Fri, 7 Dec 2018 13:47:35 +0000 (14:47 +0100)]
Cycles: Do more user-friendly indication that GPU devices are not found

3 years agoCycles: Disable OpenCL on macOS
Sergey Sharybin [Fri, 7 Dec 2018 13:37:47 +0000 (14:37 +0100)]
Cycles: Disable OpenCL on macOS

This is unfortunate, but the number of bugs in this configuration
keeps growing, and almost all of them are caused by bug in OpenCL

The compiler is not likely to be fixed, since Apple declared OpenCL

This evil commit is aimed to keep officially supported features
of Blender in a good working and stable state.

3 years agoFix T58902: error getting tools for Image Editor (modes Paint and Mask)
Philipp Oeser [Fri, 7 Dec 2018 10:24:09 +0000 (11:24 +0100)]
Fix T58902: error getting tools for Image Editor (modes Paint and Mask)

Maniphest Tasks: T58902

Differential Revision:

3 years agoFix T57640: UV unwrap packing not working without sync selection.
Brecht Van Lommel [Fri, 7 Dec 2018 12:52:14 +0000 (13:52 +0100)]
Fix T57640: UV unwrap packing not working without sync selection.

3 years agoPartial fix to T58917 - No valid cage
Dalai Felinto [Fri, 7 Dec 2018 12:41:57 +0000 (10:41 -0200)]
Partial fix to T58917 - No valid cage

The fix itself simply is to store the cage object as a pointer instead
of a string/name.

That said baking with or without cage is yielding very different results
than in 2.7.

3 years agoGP: Refactor coordinates to float
Charlie Jolly [Wed, 5 Dec 2018 18:48:27 +0000 (18:48 +0000)]
GP: Refactor coordinates to float

See: D4030

Differential Revision:

3 years agoFix/workaround crash opening almost any Spring file
Sergey Sharybin [Fri, 7 Dec 2018 11:41:46 +0000 (12:41 +0100)]
Fix/workaround crash opening almost any Spring file

The issue was caused mpoly array urequired by the cache filling,
but the pointer was never set when preparing render data.

Seems this change is safe enough, in terms it shouldn't be
causing slowdown, since the assignment of mpoly is cheap, but
hard to tell if there is anything else affected by thing underneath.

3 years agoDepsgraph: Make data allocation dependency more robust
Sergey Sharybin [Fri, 7 Dec 2018 10:17:34 +0000 (11:17 +0100)]
Depsgraph: Make data allocation dependency more robust

This fix aims to fix crash/assert failure related on wrong
evaluation order which happens when there is a cyclic
dependency involved.

The rationality of this change is that we can allow use
of uninitialized scalar value, but memory is better be

This might not be ideal still, but worth a try.

3 years agoDepsgraph: Use shorter relation name
Sergey Sharybin [Fri, 7 Dec 2018 10:10:08 +0000 (11:10 +0100)]
Depsgraph: Use shorter relation name

It is clear enough already that it goes From to To.

3 years agoDepsgraph: Cleanup, line length
Sergey Sharybin [Fri, 7 Dec 2018 10:06:09 +0000 (11:06 +0100)]
Depsgraph: Cleanup, line length

3 years agoDepsgraph: Remove duplicated sets of recalc/update flags
Sergey Sharybin [Thu, 6 Dec 2018 16:52:37 +0000 (17:52 +0100)]
Depsgraph: Remove duplicated sets of recalc/update flags

There were at least three copies of those:

- OB_RECALC* family of flags, which are rudiment of an old
  dependency graph system.
- PSYS_RECALC* which were used by old dependency graph system
  as a separate set since the graph itself did not handle
  particle systems.
- DEG_TAG_* which was used to tag IDs.

Now there is a single set, which defines what can be tagged
and queried for an update. It also has some aggregate flags
to make queries simpler.

Lets once and for all solve the madness of those flags, stick
to a single set, which will not overlap with anything or require
any extra conversion.

Technically, shouldn't be measurable user difference, but some
of the agregate flags for few dependency graph components did

Fixes T58632: Particle don't update rotation settings

3 years agoCleanup/refactor binding code for MeshDeform modifier.
Bastien Montagne [Fri, 7 Dec 2018 10:17:25 +0000 (11:17 +0100)]
Cleanup/refactor binding code for MeshDeform modifier.

We had two different ways of doing it, SurfaceDeform and LaplacianDeform
would do it through a special modifier stack evaluation triggered from
binding operator, while MeshDeform would do it through a regular
depsgraph update/eval (also triggered from its binding op).

This enforces the later to search back for orig modifier data inside
modifier code (to apply binding on that one, and not on useless CoW

Besides the question of safety about modifying orig data from threaded
despgraph (that was *probably* OK, but think it's bad idea in general),
it's much better to have a common way of doing that kind of things.

For now it remains rather dodgy, but at least it's reasonably consistent
and safe now.

This commit also fixes a potential memleak from binding process of
MeshDeform, and does some general cleanup a bit.

3 years agoFix T58046: Crash when changing Particle type, when Hair has dynamics
Philipp Oeser [Fri, 7 Dec 2018 08:49:28 +0000 (09:49 +0100)]
Fix T58046: Crash when changing Particle type, when Hair has dynamics

thx @sergey for checking

3 years agoCleanup: split mixed_bones_object_selectbuffer
Campbell Barton [Fri, 7 Dec 2018 09:49:11 +0000 (20:49 +1100)]
Cleanup: split mixed_bones_object_selectbuffer

Split basic object picking logic out into it's own function.

3 years agoCleanup: style
Campbell Barton [Fri, 7 Dec 2018 09:48:49 +0000 (20:48 +1100)]
Cleanup: style

3 years agoFix T58913 Won't focus on Grease Pencil
Antonioya [Fri, 7 Dec 2018 09:42:14 +0000 (10:42 +0100)]
Fix T58913 Won't focus on Grease Pencil

When the datablock was empty, the center was not calculated. Now it uses the object location.

3 years agoFix T58911: Picking objects fails in pose mode
Campbell Barton [Fri, 7 Dec 2018 08:10:08 +0000 (19:10 +1100)]
Fix T58911: Picking objects fails in pose mode

3 years agoFix T58811: Scale bezier handle uses tip as origin
Campbell Barton [Fri, 7 Dec 2018 06:26:25 +0000 (17:26 +1100)]
Fix T58811: Scale bezier handle uses tip as origin

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Fri, 7 Dec 2018 06:11:28 +0000 (17:11 +1100)]
Merge branch 'master' into blender2.8

3 years agoCleanup: redundant counter
Campbell Barton [Fri, 7 Dec 2018 06:06:21 +0000 (17:06 +1100)]
Cleanup: redundant counter

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Fri, 7 Dec 2018 04:54:17 +0000 (15:54 +1100)]
Merge branch 'master' into blender2.8

3 years agoFix error in Main cleanup
Campbell Barton [Fri, 7 Dec 2018 04:40:38 +0000 (15:40 +1100)]
Fix error in Main cleanup

See 481cdb08ed6f3

3 years agoDRW: Remove the use of GPUTexture buffers for edit wire rendering
Clément Foucault [Fri, 7 Dec 2018 04:32:59 +0000 (05:32 +0100)]
DRW: Remove the use of GPUTexture buffers for edit wire rendering

See previous commit for detail as why.

3 years agoDRW: Rework wireframe overlay implementation
Clément Foucault [Fri, 7 Dec 2018 04:03:01 +0000 (05:03 +0100)]
DRW: Rework wireframe overlay implementation

The shader is way simpler and run way faster on lower end hardware
(2x faster on intel HD5000) but did not notice any improvement on AMD Vega.

This also adds a few changes to the way the wireframes are drawn:
- the slider is more linearly progressive.
- optimize display shows all wires and progressively decrease "inner" wires
  intensity. This is subject to change in the future.
- text/surface/metaballs support is pretty rough. More work needs to be done.

This remove the optimization introduced in f1975a46390a5bf85bb7012375f9bc1e761fc516.
This also removes the GPU side "sharpness" calculation which means that
animated meshes with wireframe display will update slower.
The CPU sharpness calculation has still room for optimization. Also
it is not excluded that GPU calculation can be added back as a
separate preprocessing pass (saving the computation result [compute or

The goal here was to have more speed for static objects and remove
the dependency of having buffer textures with triangle count. This is
preparation work for multithreading the whole DRW manager.

3 years agoGPU: Remove EXT and add assert
Clément Foucault [Fri, 7 Dec 2018 03:07:56 +0000 (04:07 +0100)]
GPU: Remove EXT and add assert

Some drivers accept shaders with only vertex stage, but some just silently

3 years agoGPU: Add GPU_vertformat_triple_load to load next vertices attrib
Clément Foucault [Thu, 6 Dec 2018 23:58:17 +0000 (00:58 +0100)]
GPU: Add GPU_vertformat_triple_load to load next vertices attrib

Right now does not add padding at the end of the buffer.

This seems not necessary but may cause problem on some platform. If needed
we will add this padding (only 2 more vertices).

3 years agoDRW: Add Provoking vertex state.
Clément Foucault [Thu, 6 Dec 2018 22:18:18 +0000 (23:18 +0100)]
DRW: Add Provoking vertex state.

3 years agoFix crash recovering last session
Campbell Barton [Fri, 7 Dec 2018 04:04:57 +0000 (15:04 +1100)]
Fix crash recovering last session

3 years agoAdd license headers for app-templates
Campbell Barton [Fri, 7 Dec 2018 03:29:03 +0000 (14:29 +1100)]
Add license headers for app-templates

3 years agoFix T58897: Show folders in video editing template
Campbell Barton [Fri, 7 Dec 2018 03:27:22 +0000 (14:27 +1100)]
Fix T58897: Show folders in video editing template

Show folders and start in the users home.

3 years agoWM: alternate fix for T58904
Campbell Barton [Fri, 7 Dec 2018 03:07:05 +0000 (14:07 +1100)]
WM: alternate fix for T58904

Use messages instead of notifiers.

3 years agoRevert "Fix T58904: Side tabs disappear when creating new View Layer"
Campbell Barton [Fri, 7 Dec 2018 02:49:00 +0000 (13:49 +1100)]
Revert "Fix T58904: Side tabs disappear when creating new View Layer"

This reverts commit 892a104d2cc322cb042a687050dcce2403a971f3.

3 years agoFix T58905: Knife project redo fails
Campbell Barton [Fri, 7 Dec 2018 02:33:58 +0000 (13:33 +1100)]
Fix T58905: Knife project redo fails

3 years agoFix adding objects in local view
Campbell Barton [Fri, 7 Dec 2018 01:59:04 +0000 (12:59 +1100)]
Fix adding objects in local view

3 years agoFix T58871: New Scene Collection Does Not Create A New Collection
Dalai Felinto [Fri, 7 Dec 2018 01:54:42 +0000 (23:54 -0200)]
Fix T58871: New Scene Collection Does Not Create A New Collection

3 years agoFix T58904: Side tabs disappear when creating new View Layer
Dalai Felinto [Fri, 7 Dec 2018 01:35:17 +0000 (23:35 -0200)]
Fix T58904: Side tabs disappear when creating new View Layer

Using listener here, although I suspect we should be using message
subscriber only. That said, this mimics the behaviour of the buttons
main region.

As for the original bug report what was happening was that when
switching between viewlayers (or when creating one) we may not get the
same active object. So the context breadcrumbs are different.

And the bug itself was that we were missing a redraw on view layer

3 years agoFix T58750: missing fallof power tooltip.
Sebastian Parborg [Fri, 7 Dec 2018 00:13:59 +0000 (01:13 +0100)]
Fix T58750: missing fallof power tooltip.

Differential Revision:

3 years agoFix T58325: Local view Bug
Dalai Felinto [Fri, 7 Dec 2018 00:04:12 +0000 (22:04 -0200)]
Fix T58325: Local view Bug

Aka all the thousand of reports duplicated here.
I should have seen this coming, since I had to add a hack in the first
place because things were "not working".

I should have figured out earlier that COW handles base in a really
special way, with its own special object_runtime_backup hack.

3 years agoUI: add material settings in shader editor sidebar.
Lucas Boutrot [Thu, 6 Dec 2018 23:43:07 +0000 (00:43 +0100)]
UI: add material settings in shader editor sidebar.

Differential Revision:

3 years agoFix Alembic indexed UVs being merged for different vertices.
Brecht Van Lommel [Thu, 6 Dec 2018 23:02:56 +0000 (00:02 +0100)]
Fix Alembic indexed UVs being merged for different vertices.

Other software uses this to define UV islands, so we can't just merge
any UVs with the same coordinate. They have to share a vertex too.

Contributed by Maxime Robinot, with changes by me.

Differential Revision:

3 years agoFix T58898: Python error clicking in empty space in text edit mode.
Brecht Van Lommel [Thu, 6 Dec 2018 22:41:49 +0000 (23:41 +0100)]
Fix T58898: Python error clicking in empty space in text edit mode.

3 years ago3D View: hide pose bones w/o overlays
Campbell Barton [Thu, 6 Dec 2018 22:26:22 +0000 (09:26 +1100)]
3D View: hide pose bones w/o overlays

Part of T58690

3 years agoDocs: hint to why we have option to toggle bones
Campbell Barton [Thu, 6 Dec 2018 21:49:01 +0000 (08:49 +1100)]
Docs: hint to why we have option to toggle bones

Without this, it might seem redundant since there is an option
to toggle armature object display.

3 years agoFix T57963: Cycles crash using AO for displacement.
Brecht Van Lommel [Thu, 6 Dec 2018 18:50:05 +0000 (19:50 +0100)]
Fix T57963: Cycles crash using AO for displacement.

Note this is not supported, there exists no geometry at this point, but
it should not crash at least.

3 years agoFix T58223: curve tilt not working correct with left click select.
Brecht Van Lommel [Thu, 6 Dec 2018 18:26:39 +0000 (19:26 +0100)]
Fix T58223: curve tilt not working correct with left click select.

3 years agoFix T58863: 'Smooth/Flat Shading' to 'Shader Smoot/Flat' in context menu
Jacques Lucke [Thu, 6 Dec 2018 15:19:29 +0000 (16:19 +0100)]
Fix T58863: 'Smooth/Flat Shading' to 'Shader Smoot/Flat' in context menu

3 years agoSpeedup: optimize DNA_elem_array_size to speedup file loading
Jacques Lucke [Thu, 6 Dec 2018 14:50:01 +0000 (15:50 +0100)]
Speedup: optimize DNA_elem_array_size to speedup file loading

Reviewers: brecht

Differential Revision:

3 years agoGPU Framebuffer: simplify gpu_framebuffer_update_attachments_and_fill_empty_slots...
mano-wii [Thu, 6 Dec 2018 13:47:37 +0000 (11:47 -0200)]
GPU Framebuffer: simplify gpu_framebuffer_update_attachments_and_fill_empty_slots func

3 years agoFix T58310: Crash when removing multires modifier from sculpt object
Sergey Sharybin [Thu, 6 Dec 2018 14:20:16 +0000 (15:20 +0100)]
Fix T58310: Crash when removing multires modifier from sculpt object

3 years agoDRW: Mesh: Make uvs use the final mesh display
Clément Foucault [Thu, 6 Dec 2018 13:41:19 +0000 (14:41 +0100)]
DRW: Mesh: Make uvs use the final mesh display

3 years agoDRW: Fix Uvs not working in solid mode + edit mesh
Clément Foucault [Thu, 6 Dec 2018 13:34:29 +0000 (14:34 +0100)]
DRW: Fix Uvs not working in solid mode + edit mesh

3 years agoGPU Extensions: unused_fb_slot_workaround: Compare only the driver.
mano-wii [Thu, 6 Dec 2018 12:05:42 +0000 (10:05 -0200)]
GPU Extensions: unused_fb_slot_workaround: Compare only the driver.

Dozens of renderes are included.

3 years agoFix T58663: UV Align Auto does nothing
Philipp Oeser [Thu, 6 Dec 2018 12:17:04 +0000 (13:17 +0100)]
Fix T58663: UV Align Auto does nothing

one case was missing in cleanup commit rB8fc6609cc008

3 years agoFix T58659: absolute grid snapping wrong with custom grid scale.
Sebastian Parborg [Thu, 6 Dec 2018 12:04:34 +0000 (13:04 +0100)]
Fix T58659: absolute grid snapping wrong with custom grid scale.

Differential Revision:

3 years agoFix T58840: SHIFT+K in vertex paint doesn't update
Sergey Sharybin [Thu, 6 Dec 2018 12:00:31 +0000 (13:00 +0100)]
Fix T58840: SHIFT+K in vertex paint doesn't update

3 years agoDraw manager: Use render view transform as default
Sergey Sharybin [Thu, 6 Dec 2018 11:30:35 +0000 (12:30 +0100)]
Draw manager: Use render view transform as default

3 years agoColor management: Use default view with no extra transform when not specified
Sergey Sharybin [Thu, 6 Dec 2018 11:21:37 +0000 (12:21 +0100)]
Color management: Use default view with no extra transform when not specified

3 years agoColor management: Cleanup, make function name more clear
Sergey Sharybin [Thu, 6 Dec 2018 10:56:23 +0000 (11:56 +0100)]
Color management: Cleanup, make function name more clear

The idea is to reflect that the view settings are the best
for cases when one wants to see things as if they are a
render result.