blender.git
16 months agoMerge branch 'blender-v2.83-release'
Campbell Barton [Wed, 20 May 2020 12:16:42 +0000 (22:16 +1000)]
Merge branch 'blender-v2.83-release'

16 months agoMerge branch 'blender-v2.83-release'
Campbell Barton [Wed, 20 May 2020 12:16:34 +0000 (22:16 +1000)]
Merge branch 'blender-v2.83-release'

16 months agoFix T76794: Number button cursor overrides eyedropper cursor
Campbell Barton [Wed, 20 May 2020 12:04:59 +0000 (22:04 +1000)]
Fix T76794: Number button cursor overrides eyedropper cursor

Pressing 'E' over a number button to pick a distance was keeping
left-right arrows instead of using the eye-dropper cursor.

Workaround this by clearing the active button before setting the cursor.

16 months agoFix color picker being used for non-color buttons such as rotation
Campbell Barton [Wed, 20 May 2020 12:04:51 +0000 (22:04 +1000)]
Fix color picker being used for non-color buttons such as rotation

Issue raised in T76794

16 months agoMerge branch 'blender-v2.83-release'
Bastien Montagne [Wed, 20 May 2020 08:43:02 +0000 (10:43 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T76883: Zero users scenes after undo.
Bastien Montagne [Wed, 20 May 2020 08:39:50 +0000 (10:39 +0200)]
Fix T76883: Zero users scenes after undo.

Some tags need to be preserved when we reuse existing ID entirely.
AFAICT, currently this is only the EXTRAUSER one.

16 months agoFix T74298: Incorrect cursor position in Python console
Campbell Barton [Wed, 20 May 2020 08:05:09 +0000 (18:05 +1000)]
Fix T74298: Incorrect cursor position in Python console

16 months agoMerge branch 'blender-v2.83-release'
Campbell Barton [Wed, 20 May 2020 05:00:57 +0000 (15:00 +1000)]
Merge branch 'blender-v2.83-release'

16 months agoFix the current pixelsize impacting thumbnails
Campbell Barton [Wed, 20 May 2020 04:58:57 +0000 (14:58 +1000)]
Fix the current pixelsize impacting thumbnails

16 months agoMerge branch 'blender-v2.83-release'
Campbell Barton [Wed, 20 May 2020 03:53:26 +0000 (13:53 +1000)]
Merge branch 'blender-v2.83-release'

16 months agoCorrect invalid limits in last commit
Campbell Barton [Wed, 20 May 2020 03:48:25 +0000 (13:48 +1000)]
Correct invalid limits in last commit

16 months agoUI: add text to icon-only menu items when displayed in search
Campbell Barton [Wed, 20 May 2020 02:32:59 +0000 (12:32 +1000)]
UI: add text to icon-only menu items when displayed in search

Without this icon-only buttons in popovers don't have any text.

16 months agoMerge branch 'blender-v2.83-release'
Pablo Dobarro [Wed, 20 May 2020 01:34:31 +0000 (03:34 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T75977: Lower the merge limit in the bisect/mirror operation in symmetrize
Pablo Dobarro [Mon, 18 May 2020 22:12:05 +0000 (00:12 +0200)]
Fix T75977: Lower the merge limit in the bisect/mirror operation in symmetrize

This operation is using the code of the mirror modifier, so no default
is guaranteed to work in all cases. This value matches the defaults of
the mirror modifier.

Reviewed By: jbakker

Maniphest Tasks: T75977

Differential Revision: https://developer.blender.org/D7495

16 months agoCleanup: compiler warning
Brecht Van Lommel [Tue, 19 May 2020 23:15:08 +0000 (01:15 +0200)]
Cleanup: compiler warning

16 months agoFix Cycles viewport render fully restarting after undo
Brecht Van Lommel [Tue, 19 May 2020 23:11:42 +0000 (01:11 +0200)]
Fix Cycles viewport render fully restarting after undo

With the optimized undo datablock pointers remain the same, so Cycles can now
update just the parts that changed.

16 months agoFix T76858: non-thread safe sculpt memory allocation when using --debug-memory
Brecht Van Lommel [Tue, 19 May 2020 22:31:21 +0000 (00:31 +0200)]
Fix T76858: non-thread safe sculpt memory allocation when using --debug-memory

By default the guarded memory allocator is not thread safe, that needs to be
initialized.

16 months agoFix Windows build after recent guardedalloc changes
Brecht Van Lommel [Wed, 20 May 2020 00:14:49 +0000 (02:14 +0200)]
Fix Windows build after recent guardedalloc changes

16 months agoMerge branch 'blender-v2.83-release'
Brecht Van Lommel [Tue, 19 May 2020 23:22:54 +0000 (01:22 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoCleanup: make guarded memory allocation always thread safe
Brecht Van Lommel [Tue, 19 May 2020 22:59:41 +0000 (00:59 +0200)]
Cleanup: make guarded memory allocation always thread safe

Previously this would be enabled when threads were used, but threads are now
basically always in use so there is no point. Further, this is only needed for
guarded allocation with --debug-memory which is not performance critical.

16 months agoCleanup: remove legacy mmap memory allocation for 32 bit
Brecht Van Lommel [Tue, 19 May 2020 22:24:26 +0000 (00:24 +0200)]
Cleanup: remove legacy mmap memory allocation for 32 bit

This helped to go beyond the 4GB limit, but is no longer relevant for 64 bit.

16 months agoMerge branch 'blender-v2.83-release'
Brecht Van Lommel [Tue, 19 May 2020 22:46:15 +0000 (00:46 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T73148: Incorrect Repeat Last for transforms with Individual Origins and Normal...
Germano Cavalcante [Tue, 19 May 2020 21:54:46 +0000 (18:54 -0300)]
Fix T73148: Incorrect Repeat Last for transforms with Individual Origins and Normal orientation

`pvec` was confusing and was adding steps that are apparently unnecessary.
So the code has been redone so as not to use this pvec.

16 months agoFix flag conflict in transform operators
Germano Cavalcante [Tue, 19 May 2020 20:35:27 +0000 (17:35 -0300)]
Fix flag conflict in transform operators

This added some redundant properties

16 months agoMerge branch 'blender-v2.83-release'
Brecht Van Lommel [Tue, 19 May 2020 21:42:32 +0000 (23:42 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix PBVH parallel range not initializing user data correctly in some cases
Brecht Van Lommel [Tue, 19 May 2020 20:44:51 +0000 (22:44 +0200)]
Fix PBVH parallel range not initializing user data correctly in some cases

This was already changed for the TBB-based BLI_task_parallel_range in master.
This task local storage should always be initialized from the template, not
copied from another task which may be executing at the time the copy happens.

This may not fix any actual bug, we only use this user data for parallel reduce
and it's not clear that TBB ever calls the copy constructor for that case.

Ref T76858

16 months agoFix unnecessary buffer reallocation in sculpt mode, causing an assert
Brecht Van Lommel [Tue, 19 May 2020 19:27:10 +0000 (21:27 +0200)]
Fix unnecessary buffer reallocation in sculpt mode, causing an assert

Probably did not cause an actual, the assert is a performance warning.

Ref T76858

16 months agoFix T75383:Bevel weird behaviour when using bevel weights
Hans Goudey [Tue, 19 May 2020 20:40:40 +0000 (16:40 -0400)]
Fix T75383:Bevel weird behaviour when using bevel weights

Don't use the cube corner special case when the offsets are different
for the three edges involved. The generic VMesh for this situation isn't
perfect, but it's much better than a failed cube corner VMesh.

Tests pass.

16 months agoUI: Make timeline vertical bars thickness work on OSX
Clément Foucault [Tue, 19 May 2020 20:41:04 +0000 (22:41 +0200)]
UI: Make timeline vertical bars thickness work on OSX

Make use of Polyline shader.

16 months agoMerge branch 'blender-v2.83-release'
Hans Goudey [Tue, 19 May 2020 20:40:53 +0000 (16:40 -0400)]
Merge branch 'blender-v2.83-release'

16 months agoFix T75383:Bevel weird behaviour when using bevel weights
Hans Goudey [Tue, 19 May 2020 20:40:40 +0000 (16:40 -0400)]
Fix T75383:Bevel weird behaviour when using bevel weights

Don't use the cube corner special case when the offsets are different
for the three edges involved. The generic VMesh for this situation isn't
perfect, but it's much better than a failed cube corner VMesh.

Tests pass.

16 months agoGPU: Attempt to fix Crash on startup with Intel HD Graphics 620/630
Clément Foucault [Tue, 19 May 2020 20:24:03 +0000 (22:24 +0200)]
GPU: Attempt to fix Crash on startup with Intel HD Graphics 620/630

This only enables the workarounds that we know have effects on intels.
We could add the other workarounds if needed.

Related task T72098

16 months agoFix T76080 Workbench: Background Glitches caused by Screen Cavity effect
Clément Foucault [Tue, 19 May 2020 19:37:33 +0000 (21:37 +0200)]
Fix T76080 Workbench: Background Glitches caused by Screen Cavity effect

16 months agoOpenSubdiv: Remove old GPU code
Sebastián Barschkis [Tue, 19 May 2020 19:35:29 +0000 (21:35 +0200)]
OpenSubdiv: Remove old GPU code

This code was accidentally reintroduced in e73d7d27dc66.

16 months agoMerge branch 'blender-v2.83-release'
Germano Cavalcante [Tue, 19 May 2020 19:32:43 +0000 (16:32 -0300)]
Merge branch 'blender-v2.83-release'

16 months agoFix T73594: Scale Cage sometimes has incorrect center in edit mode
Germano Cavalcante [Tue, 19 May 2020 19:29:31 +0000 (16:29 -0300)]
Fix T73594: Scale Cage sometimes has incorrect center in edit mode

Differential Revision: https://developer.blender.org/D6803

16 months agoFix T66916 UI: Wrong information in Status bar after cancelling a render
Clément Foucault [Tue, 19 May 2020 19:15:41 +0000 (21:15 +0200)]
Fix T66916 UI: Wrong information in Status bar after cancelling a render

Fixed thanks to @manowii

16 months agoMerge branch 'blender-v2.83-release'
Sebastián Barschkis [Tue, 19 May 2020 19:23:54 +0000 (21:23 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T76812: [Mantaflow] Inflow particles not continuous
Sebastián Barschkis [Tue, 19 May 2020 19:12:22 +0000 (21:12 +0200)]
Fix T76812: [Mantaflow] Inflow particles not continuous

Makes use of the new particle skipping option introduced in f25a882955cb.

16 months agoFluid: Updated Mantaflow source files
Sebastián Barschkis [Tue, 19 May 2020 19:09:43 +0000 (21:09 +0200)]
Fluid: Updated Mantaflow source files

Includes changes for particle skipping during advection.

16 months agoFix T76564 Curve: Missing orco cause mesh to not render
Clément Foucault [Tue, 19 May 2020 19:00:55 +0000 (21:00 +0200)]
Fix T76564 Curve: Missing orco cause mesh to not render

16 months agoFix T73847 Overlay: Camera orthographic scale moves background image
Clément Foucault [Tue, 19 May 2020 14:29:13 +0000 (16:29 +0200)]
Fix T73847 Overlay: Camera orthographic scale moves background image

16 months agoProperly fix: T71040 / T58983 Ocean Modifier crashes at high resolutions
Ray Molenkamp [Tue, 19 May 2020 18:28:19 +0000 (12:28 -0600)]
Properly fix: T71040 / T58983 Ocean Modifier crashes at high resolutions

For a more detailed description of the issue see the commit
message for rB497cd3d7dd6e497be484eb78a8ddb23f53b20343

This change moves fftw to a shared library and reverts the bandaid
we did for 2.83.

16 months agowin/deps: generate sndfiles import library with ms lib tool
Ray Molenkamp [Tue, 19 May 2020 18:22:36 +0000 (12:22 -0600)]
win/deps: generate sndfiles import library with ms lib tool

Unsure what it is that upsets it so much, but when linking
both sndfile and fftw dynamically, the linker gets confused
and thinks that fftw is importing sf_close from the blender
binary (which makes *NO* sense) leading to a start-up error.

Generating the import library from the .def file using the
ms lib tool creates an import library that works fine.

16 months agoClarify autokeyframe tootip
Philipp Oeser [Tue, 19 May 2020 11:48:17 +0000 (13:48 +0200)]
Clarify autokeyframe tootip

This applies to masks as well.

Spotted while looking into T76872.

Differential Revision: https://developer.blender.org/D7788

16 months agoFix: build error due to missing definitions
Jacques Lucke [Tue, 19 May 2020 15:36:40 +0000 (17:36 +0200)]
Fix: build error due to missing definitions

Reviewers: sergey, brecht

Differential Revision: https://developer.blender.org/D7787

16 months agoMerge branch 'blender-v2.83-release'
Sebastian Parborg [Tue, 19 May 2020 15:10:44 +0000 (17:10 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T74577: world_to_camera_view broken for off-axis projection
Sebastian Parborg [Tue, 19 May 2020 14:23:44 +0000 (16:23 +0200)]
Fix T74577: world_to_camera_view broken for off-axis projection

The issue was that the projection would be inverted.
So if you shifted 0.1 along the y axis, world_to_camera_view would act
as if you had shited it -0.1 along the y axis.

16 months agoUI: Small Changes to Graph Editor Active Vertex Panel
Hans Goudey [Tue, 19 May 2020 14:27:07 +0000 (10:27 -0400)]
UI: Small Changes to Graph Editor Active Vertex Panel

  - X / Y value orders are all consistent, between handles and the keyframe.
  - Values are labeled consistently, with just "Frame" and "Value"
  - The more important type property that can affect the others comes first.
  - The "type" property provides nice visual separation between the
    handle properties.

Reviewed By: sybren, billreynish

Differential Revision: https://developer.blender.org/D7738

16 months agoMerge branch 'blender-v2.83-release'
Sebastián Barschkis [Tue, 19 May 2020 14:03:24 +0000 (16:03 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T76697: [Mantaflow] mesh generation does not account for some particles
Sebastián Barschkis [Tue, 19 May 2020 14:02:38 +0000 (16:02 +0200)]
Fix T76697: [Mantaflow] mesh generation does not account for some particles

Adapted mesh generation to account for domains with disabled fractionstoo.

16 months agoFix T72889: Cycles camera motion blur not usng more than 2 steps
Josh Belanich [Tue, 19 May 2020 00:51:27 +0000 (02:51 +0200)]
Fix T72889: Cycles camera motion blur not usng more than 2 steps

Differential Revision: https://developer.blender.org/D7782

16 months agoFix UV shadow drawing not respecting 'UV Opacity' setting
Philipp Oeser [Tue, 19 May 2020 13:33:21 +0000 (15:33 +0200)]
Fix UV shadow drawing not respecting 'UV Opacity' setting

reapply changes from 30cbbccc6002 / D7764 that were only meant for
master. Sorry for the noise!

16 months agoMerge remote-tracking branch 'origin/blender-v2.83-release'
Sybren A. Stüvel [Tue, 19 May 2020 13:24:45 +0000 (15:24 +0200)]
Merge remote-tracking branch 'origin/blender-v2.83-release'

16 months agoAnimation: Make dopesheet filter labels consistent
Sybren A. Stüvel [Tue, 19 May 2020 12:58:24 +0000 (14:58 +0200)]
Animation: Make dopesheet filter labels consistent

There are three different label styles for the three Dopesheet filter
labels:

- "Display Hidden", which uses "Display" rather than "Show" as the other
  two options.
- "Show Errors", which does not use the word "only" to indicate it will
  hide all the non-error channels.
- "Only Selected", so no "show" or "display" in the label at all.

This commit changes:
- Always use the word "Show", not "Display".
- Always use the word "Only" when enabling the filter hides everything
  else.

Reviewed By: billreynish

Differential Revision: https://developer.blender.org/D7742

16 months agoFix T76375: UDIM Rectangular Tiled Image EEVEE freezes Blender
Jeroen Bakker [Tue, 19 May 2020 13:20:09 +0000 (15:20 +0200)]
Fix T76375: UDIM Rectangular Tiled Image EEVEE freezes Blender

When packing the image the height of the tile was checked to the width
of the packing area. This resulted that the tile was ignored.

Reviewed By: Clément Foucault

Differential Revision: https://developer.blender.org/D7784

16 months agoMerge branch 'blender-v2.83-release'
Philipp Oeser [Tue, 19 May 2020 13:18:39 +0000 (15:18 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T76881: Changing "Use Speed Vectors" deletes all existing cache
Jacques Lucke [Tue, 19 May 2020 13:17:54 +0000 (15:17 +0200)]
Fix T76881: Changing "Use Speed Vectors" deletes all existing cache

Reviewers: sebbas

16 months agoFix build error after 30cbbccc6002
Philipp Oeser [Tue, 19 May 2020 13:14:05 +0000 (15:14 +0200)]
Fix build error after 30cbbccc6002

That part only applies to master, sorry for the noise

16 months agoFix T76694: Fluid cache is deleted when changing Upres Factor
Jacques Lucke [Tue, 19 May 2020 13:12:07 +0000 (15:12 +0200)]
Fix T76694: Fluid cache is deleted when changing Upres Factor

Reviewers: sebbas

16 months agoMerge branch 'blender-v2.83-release'
Philipp Oeser [Tue, 19 May 2020 12:45:07 +0000 (14:45 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix (unreported) UV shadow not drawing smooth
Philipp Oeser [Mon, 18 May 2020 08:41:02 +0000 (10:41 +0200)]
Fix (unreported) UV shadow not drawing smooth

When showing UV edges after modifiers [draw_uvs_shadow], these were never
drawn anti-aliased [in contrast to the 'main' UVs].

Also: they did not respect the new 'UV Opacity' setting.

Differential Revision: https://developer.blender.org/D7764

16 months agoMerge branch 'blender-v2.83-release'
Philipp Oeser [Tue, 19 May 2020 12:17:40 +0000 (14:17 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T75694: Compositor Backdrop boundbox missing updates
Philipp Oeser [Mon, 18 May 2020 14:37:00 +0000 (16:37 +0200)]
Fix T75694: Compositor Backdrop boundbox missing updates

This adds notifiers for backimage_move & backimage_fit.

Maniphest Tasks: T75694

Differential Revision: https://developer.blender.org/D7778

16 months agoMerge branch 'blender-v2.83-release'
Philipp Oeser [Tue, 19 May 2020 11:59:39 +0000 (13:59 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFluid: Cleanup unused variables
Sebastián Barschkis [Tue, 19 May 2020 10:33:17 +0000 (12:33 +0200)]
Fluid: Cleanup unused variables

16 months agoGPencil: Make is_nofill_stroke property editable
Antonio Vazquez [Tue, 19 May 2020 10:24:42 +0000 (12:24 +0200)]
GPencil: Make is_nofill_stroke property editable

This can be used by some add-ons.

16 months agoFix T76541: OpenGl Depth Picking not selecting frontmost object
Sebastian Parborg [Thu, 14 May 2020 11:43:09 +0000 (13:43 +0200)]
Fix T76541: OpenGl Depth Picking not selecting frontmost object

The issue was that we used GL_ALWAYS for depth checking here which would
lead to the depth information from objects being messed up.

It would not represent which object was closest to the camera.

Reviewed By: Clément Foucault, Jeroen Bakker, Campbell Barton

Differential Revision: http://developer.blender.org/D7710

16 months agoFix T76717: Set Rotation Mode Incorrectly Recalculates Bone Rotation In Pose Mode
Sebastian Parborg [Wed, 13 May 2020 14:27:05 +0000 (16:27 +0200)]
Fix T76717: Set Rotation Mode Incorrectly Recalculates Bone Rotation In Pose Mode

The issue was that we didn't convert the current rotational values.
We simply just switched mode without doing any data conversions.

16 months agoFix Frame Dropping not dropping the correct amount of frames
Sebastian Parborg [Tue, 12 May 2020 11:19:20 +0000 (13:19 +0200)]
Fix Frame Dropping not dropping the correct amount of frames

Previously the playback mode "Frame Dropping" would not drop the correct
number of frames which would lead to slow playback.

For example, the playback target is 60fps.  However we can only muster
around 32 fps.

The delta frames from the last step is in this case ~1.98 or so.

With the previous code, we would floor this.  That would lead us to step
forward one frame each time, effectively playing back the animation at
half the speed as we will try to render every frame.

To fix this we simply save the remaining fraction from the previous
frame and use it to compute the current frame step.

Reviewed By: Sybren

Differential Revision: http://developer.blender.org/D7694

16 months agoMade pose push/relax to breakdown behave smooth on rotations
Sebastian Parborg [Thu, 23 Apr 2020 12:11:15 +0000 (14:11 +0200)]
Made pose push/relax to breakdown behave smooth on rotations

A follow up to T67212. I missed that the rotation interpolation had its
own code path.

The previous rotation push code was actually wrong (but smooth).

Now all of the actions behave correctly and is smoothly interpolated.

16 months agoFix T72729: Mask Modifier Loose Edges Not Shown
Jeroen Bakker [Mon, 18 May 2020 09:11:13 +0000 (11:11 +0200)]
Fix T72729: Mask Modifier Loose Edges Not Shown

When using the mask modifier loose edges could be added to the mesh.
These edges weren't marked as loose edges and wasn't picked up by other
areas of blender.

This fix recalculates the loose edges so they have the correct flag
`ME_LOOSE_EDGE`.

Reviewed By: Sybren Stüvel

Differential Revision: https://developer.blender.org/D7766

16 months agoFix T76865: Vertex paint draws hidden but cannot be painted onto
Campbell Barton [Tue, 19 May 2020 07:53:26 +0000 (17:53 +1000)]
Fix T76865: Vertex paint draws hidden but cannot be painted onto

16 months agoCMake: Enable WITH_USD by default
Sybren A. Stüvel [Tue, 19 May 2020 07:39:03 +0000 (09:39 +0200)]
CMake: Enable WITH_USD by default

Having USD disabled by default was an oversight, and could have been
corrected earlier. It's already enabled by default in the
`blender_release.cmake` and `blender_full.cmake`.

16 months agoFix T76689: Armature layers not indicating the existence of bones
Sybren A. Stüvel [Tue, 12 May 2020 16:22:14 +0000 (18:22 +0200)]
Fix T76689: Armature layers not indicating the existence of bones

From what I can see, there are two issues at play in {T76689} and its merged-in report {T76590}:

- In Blender ≤ 2.79 the bone layer dots were updated in the draw code. This ensured the info was up to date before drawing. This is no longer possible, as the drawing code uses evaluated objects, and those should not be written to. This has been addressed in rB709f126e8143 by calling the update function explicitly in various places in the code. The problem is that this wasn't added to all necessary spots.
- When in edit mode, changes are made to the edit bones but not to the 'actual' bones (this is synced when exiting edit mode). This causes undo to mess up the layer indicators.

I think both issues can be addressed by having the dependency graph update the used layer info as part of the armature evaluation. This will make the undo system work properly, and allows the removal of some `BKE_armature_refresh_layer_used()` from various places.

There is still the issue that there are two functions (`BKE_armature_refresh_layer_used()` and `ED_armature_edit_refresh_layer_used()`) that are both responsible for updating `bArmature::layer_used`. This is a trickier thing to solve, though, as the definition of the `EditBone` struct resides in the armature editor module. This means that blenkernel can't iterate over edit bones, but on the other hand the dependency graph shouldn't call any editor functions either. This is why I left the `ED_armature_edit_refresh_layer_used()` calls untouched.

The downside of recalculating `layer_used` from the dependency graph (at least in the way that I did it now) is that it is called every time a user moves a bone in pose mode. This frequency of updates is not necessary.

Differential Revision: https://developer.blender.org/D7709

16 months agoFix T76780: Freestyle pass for one scene not accessible in compositor in other scenes
Jeroen Bakker [Mon, 18 May 2020 13:06:03 +0000 (15:06 +0200)]
Fix T76780: Freestyle pass for one scene not accessible in compositor in other scenes

Current implementation would update the nodetree of the freestyle scene not the composite scene.

Reviewed By: Dalai Felinto

Differential Revision: https://developer.blender.org/D7770

16 months agoFix T73169: Side by Side Stereo Rendering Glitches
Jeroen Bakker [Mon, 18 May 2020 14:23:33 +0000 (16:23 +0200)]
Fix T73169: Side by Side Stereo Rendering Glitches

Side by side and top down views were rendered using an unset matrix.
This fix will reset the matrix just before copying the views to the
screen.

Reviewed By: Clément Foucault, Dalai Felinto

Differential Revision: https://developer.blender.org/D7777

16 months agoCleanup: Creator Args Spelling
Aaron Carlisle [Tue, 19 May 2020 04:54:37 +0000 (00:54 -0400)]
Cleanup: Creator Args Spelling

Differential Revision: https://developer.blender.org/D7735

16 months agoFix T76821: Generalize Use Flow Tooltip
Aaron Carlisle [Tue, 19 May 2020 04:53:59 +0000 (00:53 -0400)]
Fix T76821: Generalize Use Flow Tooltip

16 months agoMerge branch 'blender-v2.83-release'
Campbell Barton [Tue, 19 May 2020 03:31:48 +0000 (13:31 +1000)]
Merge branch 'blender-v2.83-release'

16 months agoMerge branch 'blender-v2.83-release'
Campbell Barton [Tue, 19 May 2020 03:31:44 +0000 (13:31 +1000)]
Merge branch 'blender-v2.83-release'

16 months agoFix switching to particle edit-mode from editmode
Campbell Barton [Tue, 19 May 2020 03:26:21 +0000 (13:26 +1000)]
Fix switching to particle edit-mode from editmode

Similar to T76859

16 months agoFix T76859: Cannot switch from editmode to texturepaint mode
Philipp Oeser [Tue, 19 May 2020 03:17:26 +0000 (13:17 +1000)]
Fix T76859: Cannot switch from editmode to texturepaint mode

Caused by 5159b8e1eadb.

16 months agoMerge branch 'blender-v2.83-release'
Pablo Dobarro [Mon, 18 May 2020 23:33:08 +0000 (01:33 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix sculpt mask interpolation in subdivisions
Pablo Dobarro [Mon, 18 May 2020 23:31:26 +0000 (01:31 +0200)]
Fix sculpt mask interpolation in subdivisions

The interpolation function of the datalayer was misssing so the sculpt
mask data was corrupted every time a subdivision surface modifier was
applied.

Reviewed By: jbakker

Differential Revision: https://developer.blender.org/D7640

16 months agoMerge branch 'blender-v2.83-release'
Pablo Dobarro [Mon, 18 May 2020 23:08:23 +0000 (01:08 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix T76397: Missing value property on Clear Mask pie menu
Pablo Dobarro [Tue, 12 May 2020 01:39:10 +0000 (03:39 +0200)]
Fix T76397: Missing value property on Clear Mask pie menu

Without this value defined it was reusing the same 1.0 value after using
fill mask, so it was not working.

Reviewed By: jbakker

Maniphest Tasks: T76397

Differential Revision: https://developer.blender.org/D7699

16 months agoMerge remote-tracking branch 'origin/blender-v2.83-release'
Ray Molenkamp [Mon, 18 May 2020 22:37:57 +0000 (16:37 -0600)]
Merge remote-tracking branch 'origin/blender-v2.83-release'

16 months agoFix: T71040 / T58983 Ocean Modifier crashes at high resolutions
Ray Molenkamp [Mon, 18 May 2020 22:35:53 +0000 (16:35 -0600)]
Fix: T71040 / T58983 Ocean Modifier crashes at high resolutions

This is not as much a fix as a work around, but given the real
involves replacing how we build fftw, it is not eligible for 2.83
which is in BCON3 already.

The root of the issue lies with (how we build) fftw3

The first issue is: fftw does not build with MSVC, there are other
dependencies that are not compatible with MSVC and for those we
build the libraries required with mingw64, same for fftw

The second issue is: for reasons unknown we really really really
liked all deps to link statically so wherever possible we did so.

Now during the building of the fftw it linked a few symbols from
libgcc (which we do not ship) like __chkstk_ms, for which we passed
some flags to stop generating calls to it. Problem solved! There
is no way this could possibly turn around and bite us in the rear.

fast forward to today mystery crashes that look like a race condition.

What is happening is, we tell the linker that each thread will require
a 2-megabyte stack, now if every thread immediately allocated 2 megs,
that be 'rough' on the memory usage. So, what happens is (for all apps
not just blender), 2 megs are reserved but not backed by any real memory
and the first page is allocated for use by the stack, now as the stack
grows, it will eventually grow out of that first page, and end up in
an area that has not been allocated yet, to deal with that the allocated
page is followed by a guard page, someone touches the guard page it's
time to grow the stack!

Meanwhile in FFTW is it's doing substantial allocation using alloca
(up to 64 kb) on the stack, jumping over the guard page, and ending
up in reserved but not yet committed memory, causing an access violation.

Now if you think, that doesn't sound right! something should have
protected us from that! You are correct! That thing was __chkstk_ms
which we disabled.

Given we do not want a dependency on libgcc while building with MSVC
the proper solution is to build fftw as a shared library which will
statically link any bits and pieces it needs, however that change
is a little bit too big to be doing in BCON3.

So as a work around, we change the size the stack grows from 8k to
68k which gives fftw a little bit more wiggle room to keep it out
of trouble most of the time.

Note this only sidesteps the issue, this may come up again if the
conditions are just right, and a proper solution will need to be
implemented for 2.90.

16 months agoFix invalid bit shift when GPU shader attribute is not found
Brecht Van Lommel [Mon, 18 May 2020 19:22:02 +0000 (21:22 +0200)]
Fix invalid bit shift when GPU shader attribute is not found

16 months agoFix NULL pointer access reported by ASAN (harmless in practice but still weak)
Brecht Van Lommel [Mon, 18 May 2020 19:18:33 +0000 (21:18 +0200)]
Fix NULL pointer access reported by ASAN (harmless in practice but still weak)

16 months agoFix potential crash due to dyntopo GPU buffer invalid memory access
Brecht Van Lommel [Mon, 18 May 2020 16:07:09 +0000 (18:07 +0200)]
Fix potential crash due to dyntopo GPU buffer invalid memory access

When the number of triangles in a node became zero, the wireframe batch was
not freed along with the triangles batch and could still reference a freed
vertex buffer.

Ref T76858

16 months agoFix T76813: Snap to Edge Center returning a different normal from snap to Edge
Germano Cavalcante [Mon, 18 May 2020 18:19:13 +0000 (15:19 -0300)]
Fix T76813: Snap to Edge Center returning a different normal from snap to Edge

This difference was intentional, but using the edge direction as normal is more useful.

16 months agoRefactor: Move workspace foreach_id to new IDTypeInfo structure.
Bastien Montagne [Mon, 18 May 2020 17:01:20 +0000 (19:01 +0200)]
Refactor: Move workspace foreach_id to new IDTypeInfo structure.

16 months agoRefactor: Move WindowManager and Screen foreach_id to new IDTypeInfo structure.
Bastien Montagne [Mon, 18 May 2020 16:51:06 +0000 (18:51 +0200)]
Refactor: Move WindowManager and Screen foreach_id to new IDTypeInfo structure.

That one was a bit more complicated, and is still only partial refactor
(ultimately we want to have a foreach_id callback in SpaceType itself I
think...).

16 months agoRefactor: Move action foreach_id to new IDTypeInfo structure.
Bastien Montagne [Mon, 18 May 2020 16:43:11 +0000 (18:43 +0200)]
Refactor: Move action foreach_id to new IDTypeInfo structure.

16 months agoMerge branch 'blender-v2.83-release'
Bastien Montagne [Mon, 18 May 2020 15:56:57 +0000 (17:56 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoOutliner: Fix (unreported) more data-changing operators missing undo.
Bastien Montagne [Mon, 18 May 2020 15:12:53 +0000 (17:12 +0200)]
Outliner: Fix (unreported) more data-changing operators missing undo.

16 months agoMerge branch 'blender-v2.83-release'
Sebastián Barschkis [Mon, 18 May 2020 15:35:30 +0000 (17:35 +0200)]
Merge branch 'blender-v2.83-release'

16 months agoFix part of T76544: dyntopo sculpt undo stack memory leak
Brecht Van Lommel [Mon, 18 May 2020 15:22:55 +0000 (17:22 +0200)]
Fix part of T76544: dyntopo sculpt undo stack memory leak