6 years agoUps, forgot to remove something i just placed temporary …
Jens Verwiebe [Wed, 19 Mar 2014 10:26:41 +0000 (11:26 +0100)]
Ups, forgot to remove something i just placed temporary …

6 years agoOSX/bullet/scons: a better workaround for clang 3.4 issues with actual bullet, accord...
Jens Verwiebe [Wed, 19 Mar 2014 10:21:24 +0000 (11:21 +0100)]
OSX/bullet/scons: a better workaround for clang 3.4 issues with actual bullet, according cmake ( less speed penalty )

6 years agoFix T39247
Martijn Berger [Wed, 19 Mar 2014 06:36:34 +0000 (07:36 +0100)]
Fix T39247

Changes to interpolation break texture allocation on sm35 and greater.

6 years agoCode cleanup: unreachable break/return
Campbell Barton [Wed, 19 Mar 2014 01:46:33 +0000 (12:46 +1100)]
Code cleanup: unreachable break/return

6 years agoUI: Add splash link to gooseberry (remove user community link)
Campbell Barton [Tue, 18 Mar 2014 20:14:56 +0000 (07:14 +1100)]
UI: Add splash link to gooseberry (remove user community link)

6 years agoCode cleanup: double/float
Campbell Barton [Tue, 18 Mar 2014 20:07:59 +0000 (07:07 +1100)]
Code cleanup: double/float

6 years agoFix T39252: Regression: Auto perspective fails when switching from {front, side,...
Bastien Montagne [Tue, 18 Mar 2014 18:50:20 +0000 (19:50 +0100)]
Fix T39252: Regression: Auto perspective fails when switching from {front, side, top} to camera view, and then to user persp.

When leaving cam view, if autopersp is ON, and previous view was an axis one, we have to force new view in perspective mode - else, we reuse previous stored mode (persp or ortho).

6 years agoCleanup: factorize RNA accessor code of modifiers (saves over 160 lines of dummy...
Bastien Montagne [Tue, 18 Mar 2014 16:17:51 +0000 (17:17 +0100)]
Cleanup: factorize RNA accessor code of modifiers (saves over 160 lines of dummy code!)

Reviewers: campbellbarton

Reviewed By: campbellbarton

Differential Revision:

6 years agoFix T38566: "Separate images" in VSE is not working any longer
Sergey Sharybin [Tue, 18 Mar 2014 16:45:33 +0000 (22:45 +0600)]
Fix T38566: "Separate images" in VSE is not working any longer

6 years agoCorrection to particle system commit: wrong struct name was used
Sergey Sharybin [Tue, 18 Mar 2014 16:25:29 +0000 (22:25 +0600)]
Correction to particle system commit: wrong struct name was used

6 years agoFix T39203: Boid particle naming UI semi-freeze
Bastien Montagne [Tue, 18 Mar 2014 14:24:34 +0000 (15:24 +0100)]
Fix T39203: Boid particle naming UI semi-freeze

uiList was not handling correctly UI_BUT_DISABLED TEX name buttons!

6 years agoFix T39180: Particle with fluid physics unstable.
Lukas Tönne [Tue, 18 Mar 2014 12:36:24 +0000 (13:36 +0100)]
Fix T39180: Particle with fluid physics unstable.

Fluid sims have a very nasty feature for interaction, in which a psys
can directly update the bvhtree for //another object's psys//. This
breaks with threaded depsgraph evaluation and is generally a no-go.

To avoid crashes for now, use a global mutex to avoid concurrent writes
to an object psys' bvhtree.

6 years agoFix T39136: DupliFaces: Inconsistent handling of group member types
Sergey Sharybin [Tue, 18 Mar 2014 12:05:59 +0000 (18:05 +0600)]
Fix T39136: DupliFaces: Inconsistent handling of group member types

The issue was caused by assumption object matricies can be modified
by DupliObject->obmat outside of the duplilist iteration cycle.

This isn't really true. The thing is, old code used to modify object
matrix based on the duplicated matrix to make it so modifier evaluation
kind of works (it'll use proper matrix in most cases, but think there
might be some cases when this assumption also breaks).

Even when matrix is copied from dupliobject to object in advance
(to mimic old behavior or dupli system) you're still to use matrix
from dupliobject inside a cycle body. This is because the same object
might be modified multiple times by different dupliobject. For example,
in case of duplifaces loads of faces will modify object's matrix and
before this change matrix from the last face would have been used.

The fix is simple one-liner which makes it so render instance will
use proper matrix from dupliobject.

All the rest bits here (pre-loading matrices and restoring them in
the reverse order) totally matches old behavior of duplilist.

This is a regression and to be ported to 2.70 tag!

6 years agoOSX/cmake/bullet: fix ambigoius compiler ID and make deoptimize fix a bit stricter...
Jens Verwiebe [Tue, 18 Mar 2014 11:16:53 +0000 (12:16 +0100)]
OSX/cmake/bullet: fix ambigoius compiler ID and make deoptimize fix a bit stricter to reduce speed penalty

6 years agoUI: bypass text clipping on buttons with no text
Campbell Barton [Tue, 18 Mar 2014 00:07:10 +0000 (11:07 +1100)]
UI: bypass text clipping on buttons with no text

6 years agoCode cleanup: jitter, use 2d float array
Campbell Barton [Mon, 17 Mar 2014 23:50:24 +0000 (10:50 +1100)]
Code cleanup: jitter, use 2d float array

6 years agoFollow up to previous commit:
Antony Riakiotakis [Mon, 17 Mar 2014 23:33:28 +0000 (01:33 +0200)]
Follow up to previous commit:

Make HSL wheel useful in compositing.

In HSL, 0.5 lightness corresponds to most vibrant colors so make that
default for locked wheels (previous value of 1.0 just made it white).
Also, unlock the wheel for both very bright and very dark colors.

6 years agoFix T39228 Gamma/lift/gain are burned out in the circular color pickers
Antony Riakiotakis [Mon, 17 Mar 2014 23:08:24 +0000 (01:08 +0200)]
Fix T39228 Gamma/lift/gain are burned out in the circular color pickers
and value/lightness slider stops midway.

Issue here is manyfold:

Color wheel does not support properties with different soft min/max
values than 1.0 (which after experimenting a little I left as is), and
also color management is completely destroying the mapping between the
value slider and the RNA property value range. To solve this I have
disabled color management by setting the property to gamma corrected
(only in RNA, Sequence editor coders please check!), otherwise it will
just become a big mess of tracking where color comes from and what kind
of color transforms it needs in different color pickers (if property has
non normalized range etc). HSL is not really meant to represent colors
outside a normalized space so I have disabled setting lightness above
1.0 in this model.

This will work, however it is hacking a color picker to do something
other than what it is supposed to do: pick a color from the screen
accurately. Which means normalized values always. The non normalized
colors picked for lift/gain/gamma through the pickers do not correspond
to any accurate colors; they are rather a user friendly way to 'sort of'
choose a color and a gamma with an indication of maximum value.

I think that lift/gamma/gain nodes need a dedicated widget for this
(besides it is quite clear that some options are written for that use
case) -or- a separate gamma multiplier for the picked color (which
should itself be in a normalized space)

6 years agoKDTree: deprecate 'normal' argument
Campbell Barton [Mon, 17 Mar 2014 22:05:07 +0000 (09:05 +1100)]
KDTree: deprecate 'normal' argument

Normals for each kdtree node were allocated but never used,
and search args only use in particles/boids code.

6 years agoUI: Add theme color for viewport overlay
Campbell Barton [Mon, 17 Mar 2014 18:34:43 +0000 (05:34 +1100)]
UI: Add theme color for viewport overlay

Was using wire or black in many places, this color is used for cursor,
camera guides, transform helper lines. So its possible to have a dark
background with light overlay color.

Patch D331 by Brita, with some edits.

6 years agoCode cleanup: comments and typos
Campbell Barton [Mon, 17 Mar 2014 15:40:39 +0000 (02:40 +1100)]
Code cleanup: comments and typos

6 years agoFix own bug reported on irc by Venomgfx, missing value slider in color
Antony Riakiotakis [Mon, 17 Mar 2014 18:01:33 +0000 (20:01 +0200)]
Fix own bug reported on irc by Venomgfx, missing value slider in color

6 years agoFix T31598: smart UV failed for small faces
Campbell Barton [Mon, 17 Mar 2014 14:34:14 +0000 (01:34 +1100)]
Fix T31598: smart UV failed for small faces

previous fixes only tweaked epsilon, but logic for skipping zero area
boxes was still wrong.

6 years agoPython API: add Vector.orthogonal() method
Campbell Barton [Mon, 17 Mar 2014 13:37:43 +0000 (00:37 +1100)]
Python API: add Vector.orthogonal() method

6 years agoCode cleanup: style
Campbell Barton [Mon, 17 Mar 2014 10:48:13 +0000 (21:48 +1100)]
Code cleanup: style

6 years agoFix T39208: Adding scene to another scene's VSE causes audio and video to be unsynchr...
Bastien Montagne [Sun, 16 Mar 2014 19:11:24 +0000 (20:11 +0100)]
Fix T39208: Adding scene to another scene's VSE causes audio and video to be unsynchronized

Audio of 'linked' scene has to be offset by the startframe of that scene, else it behaves as if 'linked' scene always started at frame 1...

6 years agoFix T39215: Shortest path error
Campbell Barton [Sun, 16 Mar 2014 16:41:09 +0000 (03:41 +1100)]
Fix T39215: Shortest path error

6 years agoFix T39210: Grid Fill is generating mesh that's inconsistent with selected edge loops
Bastien Montagne [Sun, 16 Mar 2014 15:31:19 +0000 (16:31 +0100)]
Fix T39210: Grid Fill is generating mesh that's inconsistent with selected edge loops

Issue was in BLI's rotation_between_vecs_to_quat(), which did not handled correctly cases where both vectors are colinear.

Patch by Campbell Barton and me.

Issue originaly tracked down by Yan Shi, many thanks!

6 years agoEditMesh: Support contracting the selection as well as extending
Campbell Barton [Sun, 16 Mar 2014 13:23:05 +0000 (00:23 +1100)]
EditMesh: Support contracting the selection as well as extending

This allows for holding ctrl while switching from face->edge modes to
select an edge-ring.

6 years agoCode cleanup: naming conventions
Campbell Barton [Sun, 16 Mar 2014 11:11:14 +0000 (22:11 +1100)]
Code cleanup: naming conventions

6 years agoCode cleanup: modifier_skin_customdata_ensure was a bad level call
Campbell Barton [Sun, 16 Mar 2014 10:55:30 +0000 (21:55 +1100)]
Code cleanup: modifier_skin_customdata_ensure was a bad level call

6 years agoCycles: Direct multi light sampling in the Branched Path Integrator is optional now.
Thomas Dinges [Sat, 15 Mar 2014 16:36:44 +0000 (17:36 +0100)]
Cycles: Direct multi light sampling in the Branched Path Integrator is optional now.
Disabling this can improve performance, when we need a lot of AA Samples anyway, to clear up the render.

Simple example .blend:

Differential Revision:

6 years agoUI: Improved layout for Cycles Volume Sampling panel.
Thomas Dinges [Sat, 15 Mar 2014 15:52:42 +0000 (16:52 +0100)]
UI: Improved layout for Cycles Volume Sampling panel.

6 years agoUI: Move OpenGL Settings (AA and Alpha) into the Info Editor render menu.
Thomas Dinges [Sat, 15 Mar 2014 15:47:03 +0000 (16:47 +0100)]
UI: Move OpenGL Settings (AA and Alpha) into the Info Editor render menu.

6 years agoCode cleanup: use r_ prefix for return args
Campbell Barton [Sat, 15 Mar 2014 16:24:05 +0000 (03:24 +1100)]
Code cleanup: use r_ prefix for return args

6 years agoCode cleanup: Don't assign time 2x, we only need it for Object Motion here.
Thomas Dinges [Sat, 15 Mar 2014 13:22:41 +0000 (14:22 +0100)]
Code cleanup: Don't assign time 2x, we only need it for Object Motion here.

6 years agoCode cleanup: spelling & style
Campbell Barton [Sat, 15 Mar 2014 09:08:29 +0000 (20:08 +1100)]
Code cleanup: spelling & style

6 years agoFix T39189: Node editor Map Uv requires an scale node to work.
Lukas Tönne [Sat, 15 Mar 2014 09:24:07 +0000 (10:24 +0100)]
Fix T39189: Node editor Map Uv requires an scale node to work.

This is a regression caused by rB67134a7bf689279785e2e40b29cd24243813998b
The UV coordinates read from the UV input must be scaled by the Image
input size instead of the UV input size.

Also now this node uses the UV input resolution instead of the Image
resolution, since this is what determines the available resolution. The
image is EWA-sampled anyway, it's resolution does not have a direct

6 years agoPatch T36209: Use binary search function for evaluating F-Curves
Joshua Leung [Fri, 14 Mar 2014 22:45:14 +0000 (11:45 +1300)]
Patch T36209: Use binary search function for evaluating F-Curves

This provides a speedup to evaluating long F-Curves in fcurve_eval_keyframes()
by using the pre-existing binarysearch_bezt_index() function (used for keyframe
insertion) to find the relevant BezTriple on the FCurve at the current evaltime.
The current code loops over all BezTriples (sometimes not even breaking from the
loop after cvalue has been evaluated).

Reviewer Notes:
- Unlike in the original patch, we use the old/existing logic instead of
  checking that (exact == true). See comments in code and also on the tracker
  entry for this patch for more details.

Patch By: Josh Wedlake

6 years agoUI Tweak: Add a convenience button for switching to Bone Constraints Tab
Joshua Leung [Mon, 10 Mar 2014 03:56:31 +0000 (16:56 +1300)]
UI Tweak: Add a convenience button for switching to Bone Constraints Tab

To reduce user confusion, we were already presenting users with an error message
when they tried to edit constraints for bones from the Object Constraints tab.
This commit just makes things more convenient by adding a button which takes
users to the right tab when clicked.

6 years agoSpelling fix
Joshua Leung [Sun, 9 Mar 2014 06:30:52 +0000 (19:30 +1300)]
Spelling fix

6 years agoFix T39166: Disappearing text objects
Sergey Sharybin [Fri, 14 Mar 2014 11:49:23 +0000 (17:49 +0600)]
Fix T39166: Disappearing text objects

This is a failure of viewport direct displist creation
caused by existing curve_cache pointer which empty content.

Made it so if the curve isn't evaluated it's curve_cache is NULL.

This is just-another-regression to be ported to the release.

6 years agoFix T38897: Problems moving animation channels up and down in dope sheet/action editor.
Bastien Montagne [Fri, 14 Mar 2014 11:45:22 +0000 (12:45 +0100)]
Fix T38897: Problems moving animation channels up and down in dope sheet/action editor.

Basic idea is to check whether an element is visible or not, and ignore those that are hidden, during move up/down.

Reviewers: aligorith

Reviewed By: aligorith

Differential Revision:

6 years agoFix T39180: Particle with fluid physics unstable.
Lukas Tönne [Fri, 14 Mar 2014 10:03:04 +0000 (11:03 +0100)]
Fix T39180: Particle with fluid physics unstable.

Fluid particles use the particle system's bvhtree structure, which is a
runtime BVH tree. This was not reset properly on copying objects/psys,
which lead to concurrent access in threaded depsgraph updates and memory

6 years agoFix T39164: Mask tansform doesn't respect parent for center
Sergey Sharybin [Fri, 14 Mar 2014 06:57:42 +0000 (12:57 +0600)]
Fix T39164: Mask tansform doesn't respect parent for center

A regressions since 2.69, eeeh.

6 years agoCMake: fix for standalone player and remove recast modifier reference
Campbell Barton [Fri, 14 Mar 2014 04:56:35 +0000 (15:56 +1100)]
CMake: fix for standalone player and remove recast modifier reference

6 years agoFix Circle picker not liking linear color properties much. Again, visual
Antony Riakiotakis [Fri, 14 Mar 2014 00:30:27 +0000 (02:30 +0200)]
Fix Circle picker not liking linear color properties much. Again, visual
result for picked color was different from what was displayed on color
wheel under the cursor.

6 years agoDisable color picker template cubic parameter by default.
Antony Riakiotakis [Fri, 14 Mar 2014 00:11:34 +0000 (02:11 +0200)]
Disable color picker template cubic parameter by default.

This is mostly useful for precision in lift/gamma/gain nodes. Display of
those values is done with linear interpolation while saturation is
interpolated cubically. This will lead to color inconsistency between
selected and displayed color on color pickers for instance, which should
be avoided on those use cases.

6 years agoBetter fix for T37545.
Antony Riakiotakis [Thu, 13 Mar 2014 23:37:32 +0000 (01:37 +0200)]
Better fix for T37545.

This was supposed to fix inaccuracies between S-H wheel but it makes the
colors selected through the SV-H color cube wrong (see http://
%28SV-H%29-Inaccurate). Instead of deactivating color management for SV
and H widgets just reenable correction for the Hue wheel. This is wrong
because HSV always refers to display space and we -have- to account for
that when using linear color RNA properties.

6 years agoSome corrections to previous commit. Undo stack could return 0 or return
Antony Riakiotakis [Thu, 13 Mar 2014 21:54:18 +0000 (23:54 +0200)]
Some corrections to previous commit. Undo stack could return 0 or return
global undo even if not set in preferences.

6 years agoFix T39156 part 2: Add support for image paint operations in undo
Antony Riakiotakis [Thu, 13 Mar 2014 20:35:26 +0000 (22:35 +0200)]
Fix T39156 part 2: Add support for image paint operations in undo
history operator (Ctrl + Alt + Z).

This will only show paint operations now while in an image paint mode.
The caveat is that user can delete previous paint operations too (even
on images not on the canvas currently) so it needs some care. This is
consistent with regular undo behaviour though.

Sculpting also suffers from lack of Undo history support, this will be
added in a separate commit.

6 years agoFix cycles texture interpolation mode closest constant offset on some devices
Martijn Berger [Thu, 13 Mar 2014 19:08:10 +0000 (20:08 +0100)]
Fix cycles texture interpolation mode closest constant offset on some devices

6 years agoFix bug 1 of T39156: Deadlock while undoing paint operations on image
Antony Riakiotakis [Thu, 13 Mar 2014 17:55:19 +0000 (19:55 +0200)]
Fix bug 1 of T39156: Deadlock while undoing paint operations on image

This commit should be included in 2.70 release

6 years agoTypos in last commit, sorry
Jens Verwiebe [Thu, 13 Mar 2014 17:04:58 +0000 (18:04 +0100)]
Typos in last commit, sorry

6 years agoGHOST: cover now both win and osx case for T39153
Jens Verwiebe [Thu, 13 Mar 2014 17:02:50 +0000 (18:02 +0100)]
GHOST: cover now both win and osx case for T39153

6 years agoFix own bug after HSL picker commit. HSV Cube based pickers missed HSV
Antony Riakiotakis [Thu, 13 Mar 2014 16:43:04 +0000 (18:43 +0200)]
Fix own bug after HSL picker commit. HSV Cube based pickers missed HSV

6 years agoFix T39158: Help > Operator Cheat Sheet causes a python recursive loop.
Bastien Montagne [Thu, 13 Mar 2014 16:37:19 +0000 (17:37 +0100)]
Fix T39158: Help > Operator Cheat Sheet causes a python recursive loop.

Core issue exists since ages - the thing you get from bpy.types.YOUR_OT_operator is fuzzy, and may change,
due to the fact that both Operator and OperatorProperties share the same name...
Would be cool to get rid of this issue one day, but for now it's safer to use rna acessor...

This commit is to be backported to 2.70.

6 years agoOSX/GHOST: fix T39153, pls check on win minimized window load
Jens Verwiebe [Thu, 13 Mar 2014 16:08:15 +0000 (17:08 +0100)]
OSX/GHOST: fix T39153, pls check on win minimized window load

6 years agoUI: Show edge draw options for duplis, it applied to their instances
Campbell Barton [Thu, 13 Mar 2014 15:13:31 +0000 (02:13 +1100)]
UI: Show edge draw options for duplis, it applied to their instances

6 years agoFix T39146: recent cycles CUDA regression in fix for T39114.
Brecht Van Lommel [Thu, 13 Mar 2014 13:16:42 +0000 (14:16 +0100)]
Fix T39146: recent cycles CUDA regression in fix for T39114.

This commit is to be backported to the 2.70 release.

6 years agoCode cleanup: cmake
Campbell Barton [Thu, 13 Mar 2014 12:31:06 +0000 (23:31 +1100)]
Code cleanup: cmake

6 years agoFreestyle: Fix for a potential implementation error in the Python wrapper of the...
Tamito Kajiyama [Thu, 13 Mar 2014 12:00:59 +0000 (21:00 +0900)]
Freestyle: Fix for a potential implementation error in the Python wrapper of the Nature class.

6 years agoFix T39152: Blender crash when duplicate mesh with hooks and laplacian deform.
Bastien Montagne [Thu, 13 Mar 2014 11:51:20 +0000 (12:51 +0100)]
Fix T39152: Blender crash when duplicate mesh with hooks and laplacian deform.

We can't simply dupalloc cache_system (LaplacianSystem), it has quite a few allocated data we'd need to dupalloc as well,
not to mention (nl) context... Much safer to just set it to NULL in new copy imho!

This commit is to be backported to 2.70 release!

6 years agoCmake: fix compile problem after own commit
Jens Verwiebe [Thu, 13 Mar 2014 10:06:43 +0000 (11:06 +0100)]
Cmake: fix compile problem after own commit

6 years agoFix T39151: Boolean modifier freeze
Sergey Sharybin [Thu, 13 Mar 2014 09:40:55 +0000 (15:40 +0600)]
Fix T39151: Boolean modifier freeze

This re-applied patch from 25cbd13 which was lost at some point
since missing patchset in series.

This revision is to be back-ported to the final release.

6 years agoFix for compilation error since previous fix for XCode
Sergey Sharybin [Thu, 13 Mar 2014 09:28:45 +0000 (15:28 +0600)]
Fix for compilation error since previous fix for XCode

6 years agoBMesh: minor changes for BM_face_split use
Campbell Barton [Thu, 13 Mar 2014 07:40:16 +0000 (18:40 +1100)]
BMesh: minor changes for BM_face_split use

6 years agoFix for possible (unlikely) uninitialized var use in BM_face_split
Campbell Barton [Thu, 13 Mar 2014 07:35:41 +0000 (18:35 +1100)]
Fix for possible (unlikely) uninitialized var use in BM_face_split

6 years agoFix T39148: Image does not show while rendering
Sergey Sharybin [Thu, 13 Mar 2014 07:25:07 +0000 (13:25 +0600)]
Fix T39148: Image does not show while rendering

Own regression since partial buffer update refactor,
display buffer for exr tiles should happen in image
update callback.

This revision is to be merged to the final release.

6 years agoCode cleanup: quiet warning, 'else' would always crash (& never occurred)
Campbell Barton [Thu, 13 Mar 2014 00:59:11 +0000 (11:59 +1100)]
Code cleanup: quiet warning, 'else' would always crash (& never occurred)

also quiet waning clamping

6 years agoFreestyle: avoid checking PyErr_Occurred and quiet warning
Campbell Barton [Thu, 13 Mar 2014 00:54:59 +0000 (11:54 +1100)]
Freestyle: avoid checking PyErr_Occurred and quiet warning

6 years agoOSX/cmake: set DEBUG_INFORMATION_LEVEL to "line-tables-only" for cycles, clang 3...
Jens Verwiebe [Wed, 12 Mar 2014 21:41:35 +0000 (22:41 +0100)]
OSX/cmake: set DEBUG_INFORMATION_LEVEL to "line-tables-only" for cycles, clang 3.4 (xcode 5.1) would not link with RNA in debug else

6 years agoCode cleanup: de-duplicate switch statement, style edits
Campbell Barton [Wed, 12 Mar 2014 19:18:25 +0000 (06:18 +1100)]
Code cleanup: de-duplicate switch statement, style edits

6 years agoAnticipate future color picker types and don't crash (uiBut could be
Antony Riakiotakis [Wed, 12 Mar 2014 19:06:57 +0000 (21:06 +0200)]
Anticipate future color picker types and don't crash (uiBut could be
NULL in some cases)

6 years agoFollowup for fix T38318: Add back previous fix and fix a glitch.
IRIE Shinsuke [Wed, 12 Mar 2014 17:50:01 +0000 (02:50 +0900)]
Followup for fix T38318: Add back previous fix and fix a glitch.

The previous fix 162d6c73e3d0 has been cancelled because it caused a
problem that mesh deform cages and so on mess up the preview. To avoid
the problem, viewport doesn't show mesh object if its draw type is
bounding box or wireframe.

Reviewers: brecht

Reviewed By: brecht

Differential Revision:

6 years agoFix T39114: cycles lamp ray visibility not working.
Brecht Van Lommel [Wed, 12 Mar 2014 17:20:42 +0000 (18:20 +0100)]
Fix T39114: cycles lamp ray visibility not working.

Thanks to Thomas for finding the cause.

6 years agoFix possible (unlikely) use of uninitialized pointer in RNA resolving
Campbell Barton [Wed, 12 Mar 2014 17:17:07 +0000 (04:17 +1100)]
Fix possible (unlikely) use of uninitialized pointer in RNA resolving

6 years agoCode cleanup (tm): Some code deduplication for HSL
Antony Riakiotakis [Wed, 12 Mar 2014 17:12:39 +0000 (19:12 +0200)]
Code cleanup (tm): Some code deduplication for HSL

6 years agoFix T39111: Boolean assert failure on widows
Sergey Sharybin [Wed, 12 Mar 2014 17:10:24 +0000 (23:10 +0600)]
Fix T39111: Boolean assert failure on widows

In fact we had this change a while ago, not sue what happened.

6 years agoHSL color wheel implementation.
Antony Riakiotakis [Wed, 12 Mar 2014 16:58:50 +0000 (18:58 +0200)]
HSL color wheel implementation.

This is a standard Hue - Saturation - Lightness model
(see for instance entry on wikipedia here:
Note though the difference between HSV and HSL saturation, which are not the same.

The advantage of having this color selection scheme is that artists can select
shades and tints of a color easily by using the lightness slider. Also colors
are arranged on (approximated) perceived lightness on the color wheel.

Beware, Old files opened with this preference saved will crash!

Reviewers: sergey, brecht, campbellbarton

Differential Revision:

6 years agoMesh API: rename 'octree' to 'spatial' since internally its using kdtree
Campbell Barton [Wed, 12 Mar 2014 14:46:21 +0000 (01:46 +1100)]
Mesh API: rename 'octree' to 'spatial' since internally its using kdtree

6 years agoMesh API: replace octree mirror with kdtree
Campbell Barton [Wed, 12 Mar 2014 14:36:24 +0000 (01:36 +1100)]
Mesh API: replace octree mirror with kdtree

6 years agoOSX/bullet: i have to use -O0 again, else weird bullet behaviour comes back.
Jens Verwiebe [Wed, 12 Mar 2014 12:04:21 +0000 (13:04 +0100)]
OSX/bullet: i have to use -O0 again, else weird bullet behaviour comes back.
I overlooked in cmake my fix same time changed the optimization level to 0,
so not use optimization is the real fix ( postponed for after 2.70 ).
I appears we should investigate scons anyway: compileflags does not apply to c and c++ same time as expected.

6 years agoUI: allow passing "" for icon only enum buttons and still get an icon
Campbell Barton [Wed, 12 Mar 2014 08:24:47 +0000 (19:24 +1100)]
UI: allow passing "" for icon only enum buttons and still get an icon

Enum icon-only buttons were getting their strings set,
then truncated with blenders string shortening methods, then not drawn
because there was no room (since buttons are icon width).

Modify UI code so icon-only buttons don't get names and passing "" to a
button won't have its text set later on.

6 years agoCode cleanup: UI - de-duplicate menu/row/listrow enum logic
Campbell Barton [Wed, 12 Mar 2014 08:11:09 +0000 (19:11 +1100)]
Code cleanup: UI - de-duplicate menu/row/listrow enum logic

6 years agoFix for particle edit mode using wrong pixel distances.
Lukas Tönne [Wed, 12 Mar 2014 10:52:43 +0000 (11:52 +0100)]
Fix for particle edit mode using wrong pixel distances.

rB57dba739176153e052d77611ff0e554f05984686 unified pixel distance values
but omitted a factor 100 for particle edit.

6 years agoFix T39109: Vertices affected by Hook Modifiers change after "switch Direction" on...
Sergey Sharybin [Wed, 12 Mar 2014 09:46:24 +0000 (15:46 +0600)]
Fix T39109: Vertices affected by Hook Modifiers change after "switch Direction" on Curves

Remapping hooks and vertex parent wasn't implemented for curves.

6 years agoFix T39104: 2 clothes on a collision object cause crash
Sergey Sharybin [Wed, 12 Mar 2014 08:48:47 +0000 (14:48 +0600)]
Fix T39104: 2 clothes on a collision object cause crash

This was caused by static variables used in plNearestPoints().

For now solved by making the solvers allocated in the stack,
seems no noticeable affect on the simulation speed so far.

6 years agoFix T39123: Border select without "extend" does nor clear selection of bezier nodes...
Sergey Sharybin [Wed, 12 Mar 2014 08:07:26 +0000 (14:07 +0600)]
Fix T39123: Border select without "extend" does nor clear selection of bezier nodes in 3D view

This is a regression introduced in fbc7ab30f and caused by the wrong object
being passed to the function.

Not sure passing editnurb as an argument is a good thing to do..

6 years agoFix T39126: Convert To: Mesh from Curve/Meta/Surface does not respect "Keep Original"
Sergey Sharybin [Wed, 12 Mar 2014 07:59:45 +0000 (13:59 +0600)]
Fix T39126: Convert To: Mesh from Curve/Meta/Surface does not respect "Keep Original"

Own regression, didn't consider operator redo would leave scene in a non-evaluated state.

6 years agoBMesh: minor optimization, step over own loop in BM_face_exists
Campbell Barton [Wed, 12 Mar 2014 07:21:27 +0000 (18:21 +1100)]
BMesh: minor optimization, step over own loop in BM_face_exists

6 years agoTransform: minor optimization, use BLI_bitmap for island tagging
Campbell Barton [Wed, 12 Mar 2014 06:59:46 +0000 (17:59 +1100)]
Transform: minor optimization, use BLI_bitmap for island tagging

6 years agoTransform: internal change, simplify view angle checks
Campbell Barton [Wed, 12 Mar 2014 06:52:07 +0000 (17:52 +1100)]
Transform: internal change, simplify view angle checks

6 years agoCode cleanup: redundant normalize in bmbvh ray cast
Campbell Barton [Wed, 12 Mar 2014 04:50:18 +0000 (15:50 +1100)]
Code cleanup: redundant normalize in bmbvh ray cast

6 years agoCycles: Disable Branched Path on sm_30 for now, recent Indirect Multi Light addition...
Thomas Dinges [Tue, 11 Mar 2014 22:04:40 +0000 (23:04 +0100)]
Cycles: Disable Branched Path on sm_30 for now, recent Indirect Multi Light addition makes nvcc fail.

6 years agofix compile error on MinGW32
Antony Riakiotakis [Tue, 11 Mar 2014 19:46:12 +0000 (21:46 +0200)]
fix compile error on MinGW32

6 years agoFix T39060: "Choose by numbers" do not work with Enum-menus, but work with operators...
Bastien Montagne [Tue, 11 Mar 2014 20:06:03 +0000 (21:06 +0100)]
Fix T39060: "Choose by numbers" do not work with Enum-menus, but work with operators-menus

The "layer" exception in handling numbers for menus was a bit too much greedy, eating numbers for all RNA props instead of just for layers ones...

6 years agoFix T39033: Regression, duplicating proxy loses proxy
Campbell Barton [Tue, 11 Mar 2014 18:54:12 +0000 (05:54 +1100)]
Fix T39033: Regression, duplicating proxy loses proxy

fix for bug making duplicates real effected copying scenes and linked duplis.

6 years agoOSX/bullet: add -O2 to bt_cxx_flags, in cmake thats default, in scons CXXFLAGS start...
Jens Verwiebe [Tue, 11 Mar 2014 17:32:22 +0000 (18:32 +0100)]
OSX/bullet: add -O2 to bt_cxx_flags, in cmake thats default, in scons CXXFLAGS start empty also in “Release”

6 years agoCMake: add fastmath for gcc release flags (OSX had already)
Campbell Barton [Tue, 11 Mar 2014 16:33:57 +0000 (03:33 +1100)]
CMake: add fastmath for gcc release flags (OSX had already)