4 years ago[Windows/make.bat] Clean only after all parameters have been processed so the full...
lazydodo [Sat, 17 Sep 2016 15:19:54 +0000 (09:19 -0600)]
[Windows/make.bat] Clean only after all parameters have been processed so the full path is known, and require a convenience target to be set. Also added a helpful error message if any of the required data is not available.

4 years agoFix T49383: Color pickers are available if the color is locked
Antonioya [Sat, 17 Sep 2016 07:01:09 +0000 (09:01 +0200)]
Fix T49383: Color pickers are available if the color is locked

If the color is locked, the row is disabled, but the picker is still

This error was present in older versions for layer color.

4 years agoOpenGL render: Bugfix (unreported) after rB6f92604e539b2114763150fb1ace60d28e59a889
Thomas Beck [Fri, 16 Sep 2016 22:21:34 +0000 (00:21 +0200)]
OpenGL render: Bugfix (unreported) after rB6f92604e539b2114763150fb1ace60d28e59a889

Crashes occured immediately when clicking on "OpenGL render image" because there was only a task pool created previously when it was an animation. Solved it by introducing a variable is_animation to the openglrender and omitting the task_pool call when it's no animation.

@sergey: Please check my changes, moved the pool_ok and the lock into the is_animation clause.

4 years agoPose Library pose list: Default to 5 rows to match the new up/down buttons
Sybren A. Stüvel [Fri, 16 Sep 2016 16:21:20 +0000 (18:21 +0200)]
Pose Library pose list: Default to 5 rows to match the new up/down buttons

The buttons now nicely align with the pose list itself.

4 years agoBuildbot: Disable QuickTime for the time being
Sergey Sharybin [Fri, 16 Sep 2016 15:49:56 +0000 (17:49 +0200)]
Buildbot: Disable QuickTime for the time being

Buildbot machine was updated to the new SDK which seems to have
QTKit removed.

For until we've installed older SDK or ported our code to a new
AVFramework disabling QuickTime.

4 years agoPose library sorting: return OPERATOR_CANCELLED when no-op
Sybren A. Stüvel [Fri, 16 Sep 2016 15:32:46 +0000 (17:32 +0200)]
Pose library sorting: return OPERATOR_CANCELLED when no-op

A no-op happens when trying to move the top pose further up, or the
bottom pose further down.

4 years agoImprove description of move operator direction properties
Julian Eisel [Fri, 16 Sep 2016 15:03:44 +0000 (17:03 +0200)]
Improve description of move operator direction properties

These may be exposed in UI (keymap editor & redo panel), so better avoid using identifiers like "UP" "DOWN". They are redundant anyway (already displayed).

4 years agoFix jumping view when expanding graph editor channel over view bounds
Julian Eisel [Fri, 16 Sep 2016 14:38:57 +0000 (16:38 +0200)]
Fix jumping view when expanding graph editor channel over view bounds

Didn't change versioning_250.c entries, flags will be overridden anyway.

4 years agoFix vertical scrollbar adding to region width in graph editor
Julian Eisel [Fri, 16 Sep 2016 14:20:28 +0000 (16:20 +0200)]
Fix vertical scrollbar adding to region width in graph editor

Had to calculate draw region width based on region size excluding scrollbars.

4 years agoRemove debug only code
Sergey Sharybin [Fri, 16 Sep 2016 14:11:38 +0000 (16:11 +0200)]
Remove debug only code

Thanks Severin for spotting it!

4 years agoTweak for pinned/always visible curves in Graph Editor
Sergey Sharybin [Fri, 16 Sep 2016 13:56:09 +0000 (15:56 +0200)]
Tweak for pinned/always visible curves in Graph Editor

Allow such kind of pin for armature bones.

4 years agoAdded buttons to move a pose in a pose library up/down.
Sybren A. Stüvel [Fri, 16 Sep 2016 13:07:23 +0000 (15:07 +0200)]
Added buttons to move a pose in a pose library up/down.

This will break the pose library preview add-on, since that add-on uses
file indices rather than pose names.

4 years agoPicky correction to previous commit
Julian Eisel [Fri, 16 Sep 2016 13:09:21 +0000 (15:09 +0200)]
Picky correction to previous commit

A bit nicer to do empty-string check for operator poll message as well.

4 years agoUI: Allow showing why button is disabled in tooltip
Julian Eisel [Fri, 16 Sep 2016 12:50:47 +0000 (14:50 +0200)]
UI: Allow showing why button is disabled in tooltip

Uses red alert color. Operators that failed poll check already did this.

4 years agoOpenSubdiv: Remove redundant section define from shader compilation
Sergey Sharybin [Fri, 16 Sep 2016 10:28:06 +0000 (12:28 +0200)]
OpenSubdiv: Remove redundant section define from shader compilation

4 years agoOpenSubdiv: Split shader source files
Sergey Sharybin [Fri, 16 Sep 2016 10:25:40 +0000 (12:25 +0200)]
OpenSubdiv: Split shader source files

Was a bit annoying to do tweaks in a file which contained all
vertex, geometry and fragment shaders.

4 years agoGPencil: Remove toggle option for pop-up specials menu
Antonioya [Fri, 16 Sep 2016 09:57:48 +0000 (11:57 +0200)]
GPencil: Remove toggle option for pop-up specials menu

According UI rules, no toggle options in pop-ups menus, so remove it.

4 years agoFix T49349: Baking action doesnt bake multiple objects.
Bastien Montagne [Fri, 16 Sep 2016 09:49:42 +0000 (11:49 +0200)]
Fix T49349: Baking action doesnt bake multiple objects.

Tooltip was wrong here, it can only bake a single (active) object, 'only selected' option
is for pose bones only...

4 years agoGPencil: Add a new special menu for editing and replace subdivision shortcut
Antonioya [Fri, 16 Sep 2016 09:48:41 +0000 (11:48 +0200)]
GPencil: Add a new special menu for editing and replace subdivision shortcut

Replace the W shortcut for subdivision by a new menu for edit specials
in order to keep consistency in UI.

Subdivision is not used all the time, so it's better assign this
shortcut to menu.

4 years agoFix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL output
Sergey Sharybin [Fri, 16 Sep 2016 09:48:42 +0000 (11:48 +0200)]
Fix T49372: Fresnel node: difference between 2.76 and 2.78 GLSL output

4 years agoGPencil: New subdivide stroke operator
Antonioya [Thu, 15 Sep 2016 11:29:26 +0000 (13:29 +0200)]
GPencil: New subdivide stroke operator

In some situations the artist needs to subdivide a stroke created with
few points before, specially for sculpting.

The subdivision is done for any pair of continuous selected points in
the same stroke.

The operator can be activated in edit mode with W key and has a
parameter for number of cuts.

4 years agoOpenGL render: Move file writing to a separate thread
Sergey Sharybin [Fri, 16 Sep 2016 08:28:41 +0000 (10:28 +0200)]
OpenGL render: Move file writing to a separate thread

The idea is to have a dedicated thread which is responsive for all the
file writing to a separate thread, so slow disk will not slow down
OpenGL itself.

Gives really nice speedup around 1.5x when exporting barber shop layout
file to h264 video.

4 years agoFix T49369: Blender crashes/closes down application at alembic export of
Kévin Dietrich [Fri, 16 Sep 2016 07:27:44 +0000 (09:27 +0200)]
Fix T49369: Blender crashes/closes down application at alembic export of
any object

There were a couple of crashes caused by stupid typos in
rB631af9f930d2fd2c76751204ff22239aa95f761d and
rB78ea06fea4a74181c25254ed72d50d8a743b6954, as well as a shamefull lack
of 'testing before committing' which only affect exporting.

One crash was due to using RNA_boolean_get instead of RNA_enum_get, the
other one was a tricky case of order of deletion happening in the
destructors of AbcExporter and ArchiveWriter.

Should not affect RC or release.

4 years agoCleanup: Redundant forward declaration
Sergey Sharybin [Thu, 15 Sep 2016 14:46:19 +0000 (16:46 +0200)]
Cleanup: Redundant forward declaration

4 years agoFix mistake in previous commit
Sergey Sharybin [Thu, 15 Sep 2016 14:34:10 +0000 (16:34 +0200)]
Fix mistake in previous commit

Was copying things in other way around and was not performing
proper color space conversion.

4 years agoOpenGL render: Avoid byte-float-byte roundtrip
Sergey Sharybin [Thu, 15 Sep 2016 13:34:37 +0000 (15:34 +0200)]
OpenGL render: Avoid byte-float-byte roundtrip

It was annoyingly slow to do roundtrip from byte OpenGL render to
float render result and back to byte image format (which is used
in 99% of cases for the OpenGL previews),

Now we use render result's rect32 to store render result which is
already supposed to be in the display space.

Gives about 30% speed improvement for OpenGL previews here.

4 years agoOpenCOlorIO: Add explicit linearSRGB -> sRGB lookup table
Sergey Sharybin [Thu, 15 Sep 2016 13:08:20 +0000 (15:08 +0200)]
OpenCOlorIO: Add explicit linearSRGB -> sRGB lookup table

Previously converting from linear space to SRGB was doing rather
slow inverted 1D lookup. Adding explicit inverse LUT gives 20%
speedup of OpenGL render.

Next question is: why do we even bother with sRGB conversion here,
OpenGL is already in the proper space so in theory we can avoid
quite some color space conversions. In any case, having this case
optimized in nice anyway.

4 years agoOpenGL render: Add developer option to easily enable time information
Sergey Sharybin [Thu, 15 Sep 2016 13:04:19 +0000 (15:04 +0200)]
OpenGL render: Add developer option to easily enable time information

4 years agoBring blender_release.cmake uptodate with the changes from D2227
lazydodo [Thu, 15 Sep 2016 12:34:57 +0000 (06:34 -0600)]
Bring blender_release.cmake uptodate with the changes from D2227

4 years ago[windows] add some helpers to make.bat to facilitate making release builds.
lazydodo [Wed, 14 Sep 2016 23:50:16 +0000 (17:50 -0600)]
[windows] add some helpers to make.bat to facilitate making release builds.

New features:
1) Release target that checks for both cuda 7.5 and 8 with WITH_CYCLES_CUDA_BINARIES=ON and CYCLES_CUDA_BINARIES_ARCH=sm_20;sm_21;sm_30;sm_35;sm_37;sm_50;sm_52;sm_60;sm_61 options set.
2) Option to switch between x86 and x64 builds, the default remains (auto detect the architecture) but can be overridden.
3) Option to switch between vs12(2013) and vs14(2015) default is 2013.

Reviewers: juicyfruit, sergey

Reviewed By: sergey

Tags: #platform:_windows

Differential Revision:

4 years agoDepsgraph: Avoid some false-positive time dependencies of scripted drivers
Sergey Sharybin [Thu, 15 Sep 2016 10:12:59 +0000 (12:12 +0200)]
Depsgraph: Avoid some false-positive time dependencies of scripted drivers

This was quite weak to consider all scripted expression to be time-dependent.
Current solution is somewhat better but still crappy. Not sure how can we make
it really nice.

4 years agoFix filebrowser not getting back to valid dir in Release builds.
Bastien Montagne [Thu, 15 Sep 2016 10:12:19 +0000 (12:12 +0200)]
Fix filebrowser not getting back to valid dir in Release builds.

Stupid mistake wrapping path validation code inside a BLI_assert, which means it was
only called in Debug builds...

Found by Sergey, thanks.

Should be backported to 2.78.

4 years agoFix crash in some cases when deleting particle systems.
Bastien Montagne [Thu, 15 Sep 2016 09:50:56 +0000 (11:50 +0200)]
Fix crash in some cases when deleting particle systems.

Those 'never null' ID pointers are really a PITA to handle... luckily we don't have much of those around!

Found by Sybren, thanks.

Should be backported to 2.78.

4 years agoFix Py's IDs user mapping: do not consider ShapeKeys' from here.
Bastien Montagne [Thu, 15 Sep 2016 09:12:31 +0000 (11:12 +0200)]
Fix Py's IDs user mapping: do not consider ShapeKeys' from here.

This is internal pointer helper for scene evaluation and tools, though exposed to bpy API,
it can give false 'dependency cycles' in results.

That's followup to rBe007552442634 really, both should be backported to 2.78

4 years agoOpenGL render: Skip GP passes if viewport has GP visibility disabled
Sergey Sharybin [Thu, 15 Sep 2016 09:23:11 +0000 (11:23 +0200)]
OpenGL render: Skip GP passes if viewport has GP visibility disabled

4 years agoFix Py's IDs user mapping: do not consider proxy_from here.
Bastien Montagne [Thu, 15 Sep 2016 08:11:47 +0000 (10:11 +0200)]
Fix Py's IDs user mapping: do not consider proxy_from here.

This is internal pointer helper for scene evaluation and tools, it's not exposed to bpy API anyway,
and can give false 'dependency cycles' in results.

Found by sybren in his Splode work.

4 years agoUse temp .blend file copybuffer for pose copy-paste
Sergey Sharybin [Wed, 14 Sep 2016 15:50:11 +0000 (17:50 +0200)]
Use temp .blend file copybuffer for pose copy-paste

Uses similar way of storing temp data as object copy paste, just
uses different read entrypoint which does not modify current bmain.

This gives ability to easily copy-paste poses from one blender to
another one.

Hopefully doesn't introduce user-measurable differences.

Request from Peer here in the studio.

Reviewers: mont29

Reviewed By: mont29

Subscribers: hjalti, fsiddi

Differential Revision:

4 years agoRevert "Cycles: Tweak empty boundbox children"
Sergey Sharybin [Thu, 15 Sep 2016 07:39:33 +0000 (09:39 +0200)]
Revert "Cycles: Tweak empty boundbox children"

This reverts commit ecbfa31caaadb03c53c0fe1459718b99613c8804.

Original commit broke logic in nodes re-fitting. That area can
access non-existing children momentarely. Not sure what would
be best solution here, for now simply reverting the change/

4 years agoFix T49179: Parts of mesh disappear with adaptive subdivision
Mai Lavelle [Wed, 14 Sep 2016 23:34:43 +0000 (19:34 -0400)]
Fix T49179: Parts of mesh disappear with adaptive subdivision

Problem was zero length normal caused by a precision issue in patch evaluation.
This is somewhat of a quick fix, but is better than allowing possible NaNs to
occur and cause problems elsewhere.

4 years agoCycles: Deduplicate light pass code
Lukas Stockner [Wed, 14 Sep 2016 18:09:37 +0000 (20:09 +0200)]
Cycles: Deduplicate light pass code

4 years agoCycles: Stop lamp sampling if the lamp isn't visible
Lukas Stockner [Fri, 9 Sep 2016 13:51:40 +0000 (15:51 +0200)]
Cycles: Stop lamp sampling if the lamp isn't visible

Both spot and area light have large areas where they're not visible.
Therefore, this patch stops the light sampling code when one of these cases (outside of the spotlight cone or behind the area light) occurs, before the lamp shader is evaluated.
In the case of the area light, the solid angle sampling can also be skipped.

In a test scene with Sample All Lights and 18 Area lamps and 9 Spot lamps that all point away from the area that the camera sees, render time drops from 12sec to 5sec.

Reviewers: brecht, sergey, dingto, juicyfruit

Differential Revision:

4 years agoCycles: Also support the constant emission speedup for mesh lights
Lukas Stockner [Wed, 14 Sep 2016 16:53:35 +0000 (18:53 +0200)]
Cycles: Also support the constant emission speedup for mesh lights

Reviewers: brecht, sergey, dingto, juicyfruit

Differential Revision:

4 years agoFix T49352: Blender's file browser do not display previews.
Bastien Montagne [Wed, 14 Sep 2016 15:26:42 +0000 (17:26 +0200)]
Fix T49352: Blender's file browser do not display previews.

Own stupid 'logical inversion' mistake in rBa2677100fef06af.

4 years agofix Mac build with Xcode 8
Mike Erwin [Wed, 14 Sep 2016 14:23:48 +0000 (16:23 +0200)]
fix Mac build with Xcode 8

Small issues in GHOST
- use NSApplicationDelegate protocol for our app delegate
- make sure NSApp is initialized before using
(cherry picked from commit df7be04ca6d4b6dccc998445386228699d72d072)

4 years agoCleanup: Fix epic indent failure in previous commit :/
Bastien Montagne [Wed, 14 Sep 2016 14:18:36 +0000 (16:18 +0200)]
Cleanup: Fix epic indent failure in previous commit :/

4 years agoFix missing PaintCurves list in
Bastien Montagne [Wed, 14 Sep 2016 14:13:21 +0000 (16:13 +0200)]
Fix missing PaintCurves list in

Minimal list features for now, no add/remove stuff, that we can add later...

Reported by sybren.

Should be safe for 2.78.

4 years agoFix memory leak in copy pose operator
Sergey Sharybin [Wed, 14 Sep 2016 13:56:23 +0000 (15:56 +0200)]
Fix memory leak in copy pose operator

4 years agoFix T49342: TypeError when autocompleting
Bastien Montagne [Wed, 14 Sep 2016 13:40:35 +0000 (15:40 +0200)]
Fix T49342: TypeError when autocompleting

Regression from rB036c006cefe471. We can't use self here, self is, not pydescriptor of python path getsetter...

So for now, do not try to replace getsetter by actual value in's dict,
just return static var generated on first run.

Should be safe for 2.78.

4 years agoFix T49341: Bad motion blur behavior in Cycles when using Speed effect in Sequencer
Sergey Sharybin [Wed, 14 Sep 2016 12:58:55 +0000 (14:58 +0200)]
Fix T49341: Bad motion blur behavior in Cycles when using Speed effect in Sequencer

Cycles was thinking it always rendering integer frame, which is not correct.

4 years agoAttempt to fix broken path remapping in own rB443b3ca9b9cb.
Bastien Montagne [Wed, 14 Sep 2016 10:58:01 +0000 (12:58 +0200)]
Attempt to fix broken path remapping in own rB443b3ca9b9cb.

4 years agoCMake: decouple WITH_CYCLES_OPENSUBDIV from WITH_OPENSUBDIV, and enable on OS X.
Brecht Van Lommel [Tue, 13 Sep 2016 20:55:18 +0000 (22:55 +0200)]
CMake: decouple WITH_CYCLES_OPENSUBDIV from WITH_OPENSUBDIV, and enable on OS X.

Reviewed By: sergey

Differential Revision:

4 years agoFix two issues related to 'partial' .blend files:
Bastien Montagne [Wed, 14 Sep 2016 09:35:16 +0000 (11:35 +0200)]
Fix two issues related to 'partial' .blend files:

I) Filename was not put in temp Main generated to save selected data only,
this was breaking readcode when trying to open partial file, leading to missing
filename in final loaded Main data.

II) Read code would confuse partial .blend files with Undo ones, when they had no screen in them
(which happens to 99.999% of partial .blend files I guess).

Reported by @sybren, thanks.

Should be safe enough for 2.78 release.

4 years agoFileBrowser: Always do full cache refresh while we are still listing...
Bastien Montagne [Tue, 13 Sep 2016 17:02:27 +0000 (19:02 +0200)]
FileBrowser: Always do full cache refresh while we are still listing...

Does not seem to be a problem with embeded filelisting code, but was breaking with some experimental asset engines.

4 years agoCycles: Implement threaded SVM nodes compilation
Sergey Sharybin [Fri, 9 Sep 2016 10:27:51 +0000 (12:27 +0200)]
Cycles: Implement threaded SVM nodes compilation

The title says it all actually. From tests with barber shop scene here
gives 2-3x speedup for shader compilation on my oldie i7 machine. The
gain is mainly due to textures metadata query from jpeg files (which
seems to requite de-compression before metadata can be read). But in
theory could give nice improvements for scenes with huge node trees
as well (i'm talking about node trees of complexity of fractal which
we had reports about in the past).

Reviewers: juicyfruit, dingto, lukasstockner97, brecht

Reviewed By: brecht

Subscribers: monio, Blendify

Differential Revision:

4 years agoFix ignoring unused datablocks.
Bastien Montagne [Tue, 13 Sep 2016 11:22:03 +0000 (13:22 +0200)]
Fix ignoring unused datablocks.

Should be backported to 2.78.
Found by Sybren here in studio, thanks!

4 years agoOutliner: Report linked datablock edit failure when trying to rename linked data...
Philipp Oeser [Tue, 13 Sep 2016 11:12:44 +0000 (13:12 +0200)]
Outliner: Report linked datablock edit failure when trying to rename linked data in outliner

4 years agoFix T49323: Ineffective bone roll calculation with low rig scale
Sergey Sharybin [Tue, 13 Sep 2016 10:38:47 +0000 (12:38 +0200)]
Fix T49323: Ineffective bone roll calculation with low rig scale

The code was expecting vector to be normalized, however after
applying inverted object matrix it was possible to have scale
applied to it.

4 years agoFix T49336: Outliner allows to edit restrict flags for linked objects
Sergey Sharybin [Tue, 13 Sep 2016 09:33:55 +0000 (11:33 +0200)]
Fix T49336: Outliner allows to edit restrict flags for linked objects

4 years agoCycles: Tweak empty boundbox children
Sergey Sharybin [Tue, 13 Sep 2016 09:05:11 +0000 (11:05 +0200)]
Cycles: Tweak empty boundbox children

The idea here is to make assert failure to fail sooner on an incorrect
node address rather than later with stack overflow.

4 years agoFix T49290: Specific .blend with hair crashes in MacOS 2.78 RC1 on render
Sergey Sharybin [Tue, 13 Sep 2016 08:59:48 +0000 (10:59 +0200)]
Fix T49290: Specific .blend with hair crashes in MacOS 2.78 RC1 on render

The issue was caused by some false-positive empty non-AABB intersection.
Tried to tweak it a bit so it does not record intersection anymore.

Hopefully will work for all platforms. Tested here on iMac and Debian.

4 years agoAPI doc update script: Fix generated zipfile name, was broken in 'release' case...
Bastien Montagne [Tue, 13 Sep 2016 06:38:10 +0000 (08:38 +0200)]
API doc update script: Fix generated zipfile name, was broken in 'release' case...

4 years agoFix error in --debug-handlers printing
Julian Eisel [Mon, 12 Sep 2016 16:39:25 +0000 (18:39 +0200)]
Fix error in --debug-handlers printing

Was missing else block (and also missing newline character). Caused by e672e7a070e698.

4 years agoFix code which was commented by accident
Sergey Sharybin [Mon, 12 Sep 2016 14:29:54 +0000 (16:29 +0200)]
Fix code which was commented by accident

Well, more like some last-minute checks which i did not see before commit.

Let's increase commit ratio!

4 years agoFix T49327: Cycles OSL Mode: RGB Curves node only outputs gray scale images
Sergey Sharybin [Mon, 12 Sep 2016 14:14:40 +0000 (16:14 +0200)]
Fix T49327: Cycles OSL Mode: RGB Curves node only outputs gray scale images

To be backported to 2.78 release.

4 years agoCycles: Fix compilation error after recent commits
Sergey Sharybin [Mon, 12 Sep 2016 14:06:50 +0000 (16:06 +0200)]
Cycles: Fix compilation error after recent commits

4 years agoGraph editor: Add channel option to make it persistent on display
Sergey Sharybin [Mon, 12 Sep 2016 13:31:28 +0000 (15:31 +0200)]
Graph editor: Add channel option to make it persistent on display

The idea is to allow certain animation channels to be always visible in
animation editors. So, for example, one can pin Camera animation to the
editor so it is always possible to refine/tweak camera animation when
animating something else in the scene.

There is probably some more polishing required, and some current
limitations could be solved in the future but should be a good starting
point already.

Currently only works for object without recursing into deeper datablock
(so for example, it's not possible to pin object material animation).

Studio request by Colin Levy.

4 years agoFix T49296, assert failure in Bevel code.
Howard Trickey [Mon, 12 Sep 2016 11:27:29 +0000 (07:27 -0400)]
Fix T49296, assert failure in Bevel code.

The mesh interpolation function failed to fill a fractions-of-the-way
array properly when the distances are very small but nonzero.

4 years agoCycles: Fix wrong SSS in combination with hair on AVX2 platform
Sergey Sharybin [Mon, 12 Sep 2016 10:48:35 +0000 (12:48 +0200)]
Cycles: Fix wrong SSS in combination with hair on AVX2 platform

Not sure why exactly that happened, need a closer look.

4 years agoCycles: Use XDG's .cache folder for cached kernels
Sergey Sharybin [Mon, 5 Sep 2016 14:41:08 +0000 (16:41 +0200)]
Cycles: Use XDG's .cache folder for cached kernels

Basically just moves cached kernels from ~/.config/blender/BLENDER_VERSION to
~/.cache/cycles/kernels. This has following benefits:

- Follows XDG specification more closely,
  not as if it's totally crucial or measurable by users, but still nice.

- Prevents unexpected sizes of config folder, makes disk space used in more
  predictable for users way.

- Allows to share kernels across multiple Blender versions,
  which makes it easier debugging at the times close to release.

- "Copy Previous Settings" operator will no longer be copying possibly
  gigabytes of cached kernels, which used to lead to really nast disk usage
  and annoying delays of copying settings.

- In the future we can have some smart logic to clear old unused cached

Currently only done for Linux and OSX. Windows still follows old "cache"
folder logic, but it's not really important for now because we don't
support kernel compilation on this platform yet.

Reviewers: dingto, juicyfruit, brecht

Reviewed By: brecht

Differential Revision:

4 years agoCycles: Fix shading and crashes resulting from constant folding on displacement
Mai Lavelle [Sun, 11 Sep 2016 17:39:12 +0000 (13:39 -0400)]
Cycles: Fix shading and crashes resulting from constant folding on displacement

Constant folding was removing all nodes connected to the displacement output
if they evaluated to a constant, causing there to be no valid graph for
displacement even when there was displacement to be applied, and sometimes
caused crashes.

4 years agoCycles: Replace object index hack with actual checks for SD_TRANSFORM_APPLIED
Mai Lavelle [Sat, 3 Sep 2016 01:37:17 +0000 (21:37 -0400)]
Cycles: Replace object index hack with actual checks for SD_TRANSFORM_APPLIED

Using ones complement for detecting if transform has been applied was confusing
and led to several bugs. With this proper checks are made.

Also added a few transforms where they were missing, mostly affecting baking
and displacement when `P` is used in the shader (previously `P` was in the
wrong space for these shaders)

Also removed `TIME_INVALID` as this may have resulted in incorrect
transforms in some cases.

Reviewed By: brecht

Differential Revision:

4 years agoCycles: Fix bump mapping to use object space when used with true displacement
Mai Lavelle [Fri, 2 Sep 2016 04:41:04 +0000 (00:41 -0400)]
Cycles: Fix bump mapping to use object space when used with true displacement

Bump mapping was happening in world space while displacement happens in object
space, causing shading errors when displacement type was used with bump mapping.

To fix this the proper transforms are added to bump nodes. This is only done
for automatic bump mapping however, to avoid visual changes from other uses of
bump mapping. It would be nice to do this for all bump mapping to be consistent
but that will have to wait till we can break compatibility.

Reviewed By: brecht

Differential Revision:

4 years agoRevert "GPencil: Add IFACE_ macro to some strings"
Antonioya [Sun, 11 Sep 2016 11:05:29 +0000 (13:05 +0200)]
Revert "GPencil: Add IFACE_ macro to some strings"

This reverts commit b50a5b92c15e0f110ca978352c2ba59bc3e97dd3 because BKE_report functions are already automatically handled by translation system.

4 years agoGPencil: Add IFACE_ macro to some strings
Antonioya [Sun, 11 Sep 2016 10:27:39 +0000 (12:27 +0200)]
GPencil: Add IFACE_ macro to some strings

4 years agoGPencil: Change interpolate stroke factor
Antonioya [Sun, 11 Sep 2016 10:22:30 +0000 (12:22 +0200)]
GPencil: Change interpolate stroke factor

Now the factor works similar to other Blender areas to make the factor
more consistent for artists. The value 0% means equal to original
stroke, 100% equal to final stroke (50% means half way). Any value below
0% or greater than 100% create an overshoot of the stroke.

4 years ago[CMAKE/Platform/Windows] Only perform version check if the actual compiler is MSVC
lazydodo [Sat, 10 Sep 2016 23:58:56 +0000 (17:58 -0600)]
[CMAKE/Platform/Windows] Only perform version check if the actual compiler is MSVC

4 years agoNDOF: allow view movement for modal border and circle select operators.
Kai Mach [Sat, 10 Sep 2016 21:33:26 +0000 (23:33 +0200)]
NDOF: allow view movement for modal border and circle select operators.

Reviewed By: brecht

Differential Revision:

4 years agoFix undefined variable on errors in Cycles ctests.
Dmitry Dygalo [Sat, 10 Sep 2016 20:55:28 +0000 (22:55 +0200)]
Fix undefined variable on errors in Cycles ctests.

Reviewed By: brecht

Differential Revision:

4 years agoFix OpenSubdiv related buffer overrun with multiple FVar channels.
Alexander Gavrilov [Sat, 10 Sep 2016 18:15:52 +0000 (21:15 +0300)]
Fix OpenSubdiv related buffer overrun with multiple FVar channels.

The existing code uses the input value count of the first channel
for all of them. If the first channel is the largest, it leads to
a crash-causing buffer overrun in memcpy below. Likely this was
left since the time when only one channel was supported.

As a crash fix, probably should go into 2.78

4 years agoFix T49303: Fix T49314: More issues with new handling of X11 shortcuts.
Bastien Montagne [Sat, 10 Sep 2016 10:38:12 +0000 (12:38 +0200)]
Fix T49303: Fix T49314: More issues with new handling of X11 shortcuts.

This commits changes two things:
* It adds more keysyms preferably taken from XLookupKeysym than XLookupString (namely, all numpad ones).
* It falls back to keysyms from XLookupKeysym in other cases, when XLookupString does not produce anything we know of.

Finding the correct balance here is far from easy, but think we are comming rather close to it now...

4 years agoCleanup: Indentation
Sergey Sharybin [Fri, 9 Sep 2016 11:08:21 +0000 (13:08 +0200)]
Cleanup: Indentation

4 years agoCycles: Add overall timing log to SVNShaderManager
Sergey Sharybin [Fri, 9 Sep 2016 09:39:27 +0000 (11:39 +0200)]
Cycles: Add overall timing log to SVNShaderManager

4 years agoFix missing 'prop_required' flags in some ID RNA funcs.
Bastien Montagne [Fri, 9 Sep 2016 09:58:18 +0000 (11:58 +0200)]
Fix missing 'prop_required' flags in some ID RNA funcs.

Not critical, but would rather have this in 2.78 (for API doc reasons mostly).

4 years agoCycles: Deduplicate QBVH node packing across BVH build and refit
Sergey Sharybin [Fri, 9 Sep 2016 09:32:05 +0000 (11:32 +0200)]
Cycles: Deduplicate QBVH node packing across BVH build and refit

4 years agoFix/Workaround T49297: Crash related to custom data draw (Blender with ASAN)
Sergey Sharybin [Fri, 9 Sep 2016 08:55:22 +0000 (10:55 +0200)]
Fix/Workaround T49297: Crash related to custom data draw (Blender with ASAN)

Root of the issue is that active render index became wrong. This is the actual
thing to be fixed, but as usual this is quite tricky to reproduce. Since such
bad situation might have happened more and fix isn't really difficult or
intruisive let's avoid crash for now.

Can be revisited once we figure out root of the issue.

Nice for 2.78 release.

4 years agoFix T49299: Removing offset object in modifiers doesn't update mesh.
Bastien Montagne [Fri, 9 Sep 2016 08:44:49 +0000 (10:44 +0200)]
Fix T49299: Removing offset object in modifiers doesn't update mesh.

Own fault in new ID management work, thought rebuild the DAG itself was
enough to actually update whole scene, but we actually need to tag datablocks
for update as well, when we change (or remove) one of their ID pointers...

4 years agoSmoke viewport: remove dead code.
Kévin Dietrich [Fri, 9 Sep 2016 04:05:58 +0000 (06:05 +0200)]
Smoke viewport: remove dead code.

OCD commit, but cleans the code a bit:
- the first `if 0` block was supposed to draw collision objects but is
vastly outdated as most of the SmokeCollisionSettings member variables
were removed a few years ago and collision objects are drawn like other
objects anyway. Also it was committed already commented out back in
- the second `if 0` block was doing pretty much the same thing as the
few lines above it.

4 years agoAlembic streaming: initial support to interpolate data between frames.
Kévin Dietrich [Fri, 9 Sep 2016 03:59:20 +0000 (05:59 +0200)]
Alembic streaming: initial support to interpolate data between frames.

Pretty self-explanatory, allows to get some slow motion type of playback
and animations.

4 years agoAlembic: add option to triangulate meshes upon export.
Kévin Dietrich [Fri, 9 Sep 2016 03:30:43 +0000 (05:30 +0200)]
Alembic: add option to triangulate meshes upon export.

4 years agoAlembic, cleanup: split archive opening code in their own classes and
Kévin Dietrich [Fri, 9 Sep 2016 03:06:06 +0000 (05:06 +0200)]
Alembic, cleanup: split archive opening code in their own classes and

Also helps keeping platform specific code in separate from the rest of
the code.

4 years agoCycles: Don't run full shader evaluation for constant emission lamps
Lukas Stockner [Sat, 3 Sep 2016 20:40:07 +0000 (22:40 +0200)]
Cycles: Don't run full shader evaluation for constant emission lamps

Most of the time, Lamps in Cycles are just a constant emission closure, no texturing etc. Therefore, running a full shader evaluation is wasteful.
To avoid that, Cycles now detects these constant emission shaders and stores their value in the lamp data along with a flag in the shader.
Then, at runtime, if this flag is set, the lamp code just uses this value and only runs the full shader evaluation if it is neccessary.

In scenes with a lot of lamps and with "Sample all direct/indirect" enabled, this saves up to 20% of rendering time in my tests.

Reviewers: #cycles

Differential Revision:

4 years agoCycles: Fix regular BVH nodes refit
Sergey Sharybin [Thu, 8 Sep 2016 13:08:35 +0000 (15:08 +0200)]
Cycles: Fix regular BVH nodes refit

For proper indexing to work we need to use unaligned node with
identity transform instead of aligned nodes when doing refit.

To be backported to 2.78 release.

4 years agoCycles: Add asserts to BVH node packing
Sergey Sharybin [Thu, 8 Sep 2016 12:32:05 +0000 (14:32 +0200)]
Cycles: Add asserts to BVH node packing

4 years agoCycles: Cleanup: line wrapping
Sergey Sharybin [Thu, 8 Sep 2016 12:26:10 +0000 (14:26 +0200)]
Cycles: Cleanup: line wrapping

4 years agoFix T49283: Crash in BKE_ptcache_make_particle_key.
Bastien Montagne [Thu, 8 Sep 2016 08:24:56 +0000 (10:24 +0200)]
Fix T49283: Crash in BKE_ptcache_make_particle_key.

This is really hack-fix actually, not sure why `get_pointcache_keys_for_time()` seems to assume
it will always find key for given part index at least for current frame, and whether this assumption
is wrong or whether bug happens elsewhere...

Anyway, this is to be wiped out in 2.8, so no point loosing too much time on it, for now merely
returning unchanged (i.e. zero'ed) ParticleKeys in case index2 is invalid. Won't hurt anyway,
even if this did not crash in release builds, would be returning giberish values.

4 years agoFix compilation error: Shadowing of variable
Sergey Sharybin [Thu, 8 Sep 2016 07:40:25 +0000 (09:40 +0200)]
Fix compilation error: Shadowing of variable

4 years agoFix strict compiler warnings
Sergey Sharybin [Thu, 8 Sep 2016 07:39:18 +0000 (09:39 +0200)]
Fix strict compiler warnings

4 years agoFix compilation error: missing forward declaration
Sergey Sharybin [Thu, 8 Sep 2016 07:38:24 +0000 (09:38 +0200)]
Fix compilation error: missing forward declaration

4 years agoFix T49286: Compilation error with XCode 7.0
Sergey Sharybin [Thu, 8 Sep 2016 07:27:51 +0000 (09:27 +0200)]
Fix T49286: Compilation error with XCode 7.0

Weirdly enough, this version of XCode seems to have static_assert()
even when NOT using C++11. This is totally weird and counter intuitive
since static_assert() is supposed to be C++11 onlky feature.

Can XCode stop using future, please? :)

4 years agoCycles: Fix OpenCL speed regression introduced with the improved bump mapping
Lukas Stockner [Wed, 7 Sep 2016 23:33:41 +0000 (01:33 +0200)]
Cycles: Fix OpenCL speed regression introduced with the improved bump mapping

The two SVM nodes added with e7ea1ae78c caused a slowdown on AMD cards when rendering with OpenCL, whether displacement was used or not.
In the Barcelona Pavillon scene on a RX480, this would cause a 12% slowdown.

Therefore, this commit adds a additional flag for feature-adaptive compilation so that the new SVM nodes are only enabled when they are needed (Node tree connected to the Displacement output and Displacement type set to Both).

Also, the nodes were also added to shaders when the Displacement Type was set to Bump (the default), which was unneccessary and is fixed now.

Thanks to linda2 on IRC for reporting and testing and to maiself for help with the displacement shader code.

This fix might be relevant for 2.78, but it should be tested further before including it.