21 months agoFix T61536: can't snap vertex to another vertex in edit mode using curves
Sebastian Parborg [Thu, 14 Feb 2019 13:49:47 +0000 (14:49 +0100)]
Fix T61536: can't snap vertex to another vertex in edit mode using curves

Previously, the curve self snapping would only snap to points that were
earlier in the curve structure. This was because of a simple coding
snafu of using break when meaning to use continue.

21 months agoFix T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading...
Philipp Oeser [Thu, 14 Feb 2019 09:48:56 +0000 (10:48 +0100)]
Fix T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend

Reviewers: brecht

Maniphest Tasks: T61520

Differential Revision:

21 months agoFix T56665: Assert when selecting object
Campbell Barton [Thu, 14 Feb 2019 12:32:53 +0000 (23:32 +1100)]
Fix T56665: Assert when selecting object

Selecting object w/ a different mode missed refreshing the screen
areas current tool.

21 months agoUI: add symmetrize to armature menu
Campbell Barton [Thu, 14 Feb 2019 07:32:04 +0000 (18:32 +1100)]
UI: add symmetrize to armature menu

Was lost on menu reorganization,
minor tweaks to make it match the context menu.

21 months agoFix T61472: Hide Unselected fails w/ no selection
Campbell Barton [Thu, 14 Feb 2019 06:50:41 +0000 (17:50 +1100)]
Fix T61472: Hide Unselected fails w/ no selection

Also skip mesh recalculation when no hide/reveal is performed.

21 months agoFix T61353: Crash converting a curve to a mesh
Campbell Barton [Thu, 14 Feb 2019 06:21:55 +0000 (17:21 +1100)]
Fix T61353: Crash converting a curve to a mesh

This was caused by curves pointing to each other
creating a cyclic dependency.

While the dependency graph detects this, generating a mesh for render
recursively generates data which cashes in this case.

Add in a check to detect cyclic links.

Note, this bug exists in 2.7x too - but only crashes on render
since 2.7x didn't use 'for_render' when converting data.

21 months agoDRW: de-duplicate vertex & weight paint engines
Campbell Barton [Thu, 14 Feb 2019 02:59:30 +0000 (13:59 +1100)]
DRW: de-duplicate vertex & weight paint engines

These were almost exact duplicates, use one engine for drawing both
kinds of vertex color.

21 months agoDRW: use light wire for weight paint mode
Campbell Barton [Thu, 14 Feb 2019 02:39:18 +0000 (13:39 +1100)]
DRW: use light wire for weight paint mode

Black wire can be hard to see against dark blue,
especially when shading is enabled.

Use light grey, matches 2.7x.

21 months agoDRW: Increase weight paint wire depth bias
Campbell Barton [Thu, 14 Feb 2019 02:50:15 +0000 (13:50 +1100)]
DRW: Increase weight paint wire depth bias

By default wire would z-fight against the surface.
Increase the bias, also don't adjust the 'w' component
since it causes bias that depends on the view direction.

21 months agoCleanup: vertex painting variable use
Campbell Barton [Thu, 14 Feb 2019 02:06:03 +0000 (13:06 +1100)]
Cleanup: vertex painting variable use

Assign to local variables when setting up passes,
avoids mix-up between similarly named struct members.

21 months agoFix vertex/weight paint showing edge selection
Campbell Barton [Thu, 14 Feb 2019 01:40:21 +0000 (12:40 +1100)]
Fix vertex/weight paint showing edge selection

When vertex/face selection are disabled - show all wire
ignoring selection & hidden state.

21 months agoFix T61360: Weight paint tools ignore face select
Campbell Barton [Thu, 14 Feb 2019 00:47:23 +0000 (11:47 +1100)]
Fix T61360: Weight paint tools ignore face select

Face selection was added in weight paint mode since 2.7x,
however tools hadn't been updated.

21 months agoFix T61497: Old keymap causes error on startup
Campbell Barton [Thu, 14 Feb 2019 00:11:53 +0000 (11:11 +1100)]
Fix T61497: Old keymap causes error on startup

When a keymap has an error loading, don't make it active
since it will be partially loaded and not usable.

21 months agoDNA: add in-place stripping utility
Campbell Barton [Wed, 13 Feb 2019 22:59:46 +0000 (09:59 +1100)]
DNA: add in-place stripping utility

Minor change from D4342

21 months agoKeymap: preference for alternate tap action for some pie menus
Campbell Barton [Wed, 13 Feb 2019 22:38:05 +0000 (09:38 +1100)]
Keymap: preference for alternate tap action for some pie menus

This allows secondary keys on tap.
Currently Z-key to toggle wireframe and tilde for navigation.

This is currently experimental, if users like this the preference
can be kept and used where appropriate.

21 months agoKeymap: Alt-N to flip normals
Campbell Barton [Wed, 13 Feb 2019 21:33:32 +0000 (08:33 +1100)]
Keymap: Alt-N to flip normals

Add shortcut since this has been removed from the context menu,
now it's in the mesh normals menu which isn't so convenient to access.

Shift-N is already used to recalculate normals,
this fits the convention of Alt removing/reversing.

21 months agoCleanup: indentation
Campbell Barton [Wed, 13 Feb 2019 21:43:44 +0000 (08:43 +1100)]
Cleanup: indentation

21 months agofix build on xcode with openmp
Arto Kitula [Wed, 13 Feb 2019 20:34:40 +0000 (22:34 +0200)]
fix build on xcode with openmp

21 months agoFix T61477: freestyle not updating in animation render (again).
Brecht Van Lommel [Wed, 13 Feb 2019 19:04:25 +0000 (20:04 +0100)]
Fix T61477: freestyle not updating in animation render (again).

Must use the right function to get animation updates now.

21 months agoMerge branch 'blender2.7'
Brecht Van Lommel [Wed, 13 Feb 2019 18:02:43 +0000 (19:02 +0100)]
Merge branch 'blender2.7'

21 months agoFix T61505, T61280, bugs in button drag toggle after recent changes.
Brecht Van Lommel [Wed, 13 Feb 2019 17:56:46 +0000 (18:56 +0100)]
Fix T61505, T61280, bugs in button drag toggle after recent changes.

21 months agoFix T59062: Keyframed node properties stay linked after shading network duplication.
Bastien Montagne [Wed, 13 Feb 2019 16:19:18 +0000 (17:19 +0100)]
Fix T59062: Keyframed node properties stay linked after shading network duplication.

There is no reason not to duplicate Actions too here, especially when
Materials' Actions are pretty much impossible to edit from current UI
(afaik, DopeSheet editor does not has any way to change them?).

21 months agoFix T61470: inconsistent HSV node results with saturation > 1.0.
Brecht Van Lommel [Wed, 13 Feb 2019 15:58:54 +0000 (16:58 +0100)]
Fix T61470: inconsistent HSV node results with saturation > 1.0.

Values outside the 0..1 range produce negative colors, so now clamp to that
range everywhere. Also fixes improper handling of hue > 2.0 in some places.

21 months agoGP: Cleanup Paint Poll method
Antonioya [Wed, 13 Feb 2019 15:48:16 +0000 (16:48 +0100)]
GP: Cleanup Paint Poll method

The poll was checking things related to all annotations, but now the check must be only for grease pencil objects and 3D view.

21 months agoFix T61446: (second part) Some items in editor and mode selectors are not translatable.
Bastien Montagne [Wed, 13 Feb 2019 15:32:58 +0000 (16:32 +0100)]
Fix T61446: (second part) Some items in editor and mode selectors are not translatable.

That one is utterly ugly fix really, but unfortunately a proper one
would require some changes to our RNA (or more precisely, pyrna) code,
so that when we subscript a dynamically generated RNA collection, the
item is somehow duplicated (and probably 'assigned' to its py object?),
before the temp RNA array memory is freed...

21 months agoFix NodeTree types UI messages not being properly tagged for translation.
Bastien Montagne [Wed, 13 Feb 2019 15:18:19 +0000 (16:18 +0100)]
Fix NodeTree types UI messages not being properly tagged for translation.

Probably fix first part of T61446.

21 months agoFix T61515: Crash when unloading a scene with pynodes and idprop of type id.
Bastien Montagne [Wed, 13 Feb 2019 15:10:46 +0000 (16:10 +0100)]
Fix T61515: Crash when unloading a scene with pynodes and idprop of type id.

Usual legacy/history crap in NodeTree code... Datablocks's specific
freeing code should never, ever do refcounting management, this is
handled by higher-level code from BKE_library area.

21 months agoFix T61502: Cycles wrong other object texture coordinates in OSL.
Brecht Van Lommel [Wed, 13 Feb 2019 14:01:54 +0000 (15:01 +0100)]
Fix T61502: Cycles wrong other object texture coordinates in OSL.

The row/column major matrix conversion was done twice.

21 months agoFix T61506: Wrong user counting with ID properties in pynodes.
Bastien Montagne [Wed, 13 Feb 2019 13:58:38 +0000 (14:58 +0100)]
Fix T61506: Wrong user counting with ID properties in pynodes.

Nuke away old nodeCopyNode(), much better to use new BKE_node_copy_ex(),
which behaves as expected for the various optional flags that can be passed.

This also removes the need to handle ID refcounting in calling code
(ugly!) and allows us to remove an even uglier name from our codebase! :D

Note that this fixes three related issues actually, that bug was also
affecting copy/paste of nodes, and 'Separate with copy' operator (the
latter being actually fully wrong, since it was not refcounting
anything, not even node->id pointer...).

21 months agoMerge branch 'blender2.7'
Brecht Van Lommel [Wed, 13 Feb 2019 13:34:26 +0000 (14:34 +0100)]
Merge branch 'blender2.7'

21 months agoFix missing Cycles cryptomatte metadata in renders.
Brecht Van Lommel [Wed, 13 Feb 2019 13:33:29 +0000 (14:33 +0100)]
Fix missing Cycles cryptomatte metadata in renders.

21 months agoCleanup: do not cleanup runtime data twice during ID copying...
Bastien Montagne [Wed, 13 Feb 2019 13:29:27 +0000 (14:29 +0100)]
Cleanup: do not cleanup runtime data twice during ID copying...

More or less same code was being executed twice during ID copying.

Makes no sense to add yet another switch-by-ID-type to handle
specificaly runtime data during ID copying, we already have
BKE_xxx_copy_data() functions for that.

21 months agoFix T61457, T61489, T61482: build errors and memory warning in Cycles.
Brecht Van Lommel [Tue, 12 Feb 2019 16:10:31 +0000 (17:10 +0100)]
Fix T61457, T61489, T61482: build errors and memory warning in Cycles.

For OIIO 2.x we must use unique_ptr. This also required updating the
guarded allocator for std::move to work. Since C++11 construct/destroy
have a default implementation that also works this case, so we just
leave it out.

21 months agoFix T61499: Missing Camera settings in props except Depth of Field
Philipp Oeser [Wed, 13 Feb 2019 09:15:40 +0000 (10:15 +0100)]
Fix T61499: Missing Camera settings in props except Depth of Field

rB55c281415b67 removed 'BLENDER_RENDER' as a COMPAT_ENGINE but the
cycles addon checks for this in its get_panels() function.

Adding this back for now.

Reviewers: brecht, billreynish

Maniphest Tasks: T61499

Differential Revision:

21 months agoFix T61487: quick favorites crash outside of open preferences window
Philipp Oeser [Wed, 13 Feb 2019 10:02:47 +0000 (11:02 +0100)]
Fix T61487: quick favorites crash outside of open preferences window

21 months agoFix crash removing drivers
Sergey Sharybin [Wed, 13 Feb 2019 09:41:36 +0000 (10:41 +0100)]
Fix crash removing drivers

Was a use-after-free during relations update.

Now we do similar dependency graph tags, but without any
extra animation update logic, which was accessing various

Was found when looking into a file from T56635.

21 months agoGP: Remove debug print
Antonioya [Wed, 13 Feb 2019 09:00:02 +0000 (10:00 +0100)]
GP: Remove debug print

21 months agoCleanup: unused DNA struct members
Campbell Barton [Wed, 13 Feb 2019 08:12:43 +0000 (19:12 +1100)]
Cleanup: unused DNA struct members

- Timeline theme.
- 3D view runtime variables.
- Exclude EditLatt from SDNA.

21 months agoFix T61411: Camera clip overlay enabled by expanding UI
Philipp Oeser [Wed, 13 Feb 2019 05:39:03 +0000 (16:39 +1100)]
Fix T61411: Camera clip overlay enabled by expanding UI

21 months agoCleanup: rename variable name for DNA utils
Campbell Barton [Wed, 13 Feb 2019 00:09:07 +0000 (11:09 +1100)]
Cleanup: rename variable name for DNA utils

Rename 'elem_dna' to 'elem_full' to signify it has array/pointer chars.

21 months agoCleanup: unused variable
Campbell Barton [Wed, 13 Feb 2019 00:08:38 +0000 (11:08 +1100)]
Cleanup: unused variable

21 months agoCleanup: style, duplicate includes
Campbell Barton [Wed, 13 Feb 2019 00:00:07 +0000 (11:00 +1100)]
Cleanup: style, duplicate includes

21 months agoI18N Messages: fix confusion with Light meanings.
Bastien Montagne [Tue, 12 Feb 2019 21:13:42 +0000 (22:13 +0100)]
I18N Messages: fix confusion with Light meanings.

Using ID_LIGHT or ID_ID for "Lamp" meaning, "Light" without context
being for 'not heavy'.

That rename of data-block was not really nice on that side of things :/

Related to T43295.

21 months agoCleanup: rename `BLT_I18NCONTEXT_ID_LAMP` -> `BLT_I18NCONTEXT_ID_LIGHT`.
Bastien Montagne [Tue, 12 Feb 2019 20:51:51 +0000 (21:51 +0100)]

21 months agoFix T51771: UI Messages: Reserve 'Normal' to its geometric meaning.
Bastien Montagne [Tue, 12 Feb 2019 20:28:04 +0000 (21:28 +0100)]
Fix T51771: UI Messages: Reserve 'Normal' to its geometric meaning.

Using 'Regular' instead for the common meaning, this avoids having to
add some i18n context disambiguation...

21 months agoFix T61469: wrong object statistics when using instances.
Brecht Van Lommel [Tue, 12 Feb 2019 18:17:14 +0000 (19:17 +0100)]
Fix T61469: wrong object statistics when using instances.

The new code already loops over all instances, don't need to be counted again.

21 months agoFix T61453: crash rendering after selecting particle settings datablock.
Brecht Van Lommel [Tue, 12 Feb 2019 17:59:45 +0000 (18:59 +0100)]
Fix T61453: crash rendering after selecting particle settings datablock.

21 months agoGP: Move to new layer did not work with autolock
Antonioya [Tue, 12 Feb 2019 17:14:36 +0000 (18:14 +0100)]
GP: Move to new layer did not work with autolock

When the autolock layer option was enabled, the move to new layer operator was not working as expected.

21 months agoEdit Mode: Fix element selection on some old AMD GPUs
mano-wii [Tue, 12 Feb 2019 16:12:31 +0000 (14:12 -0200)]
Edit Mode: Fix element selection on some old AMD GPUs

Tested on an `AMD Radeon HD 7570M`.
It seems that a VBO containing only `unsigned bytes` or `unsigned shorts` can't be read correctly in a shader.
Strange that if the index buffer repeats the drawing of the vertices (as was done before rBa04dd15193e6) the problem disappears.
The disadvantage of this solution is that the memory size for a selection VBO increases by about 4 times.
But the loss in optimization is negligible.

Thanks to @fclem for pointing out the possible source of the problem and reviewing the fix.

21 months agoFix "typo" in show_object_viewport* RNA_def_property_update
Dalai Felinto [Tue, 12 Feb 2019 16:27:30 +0000 (14:27 -0200)]
Fix "typo" in show_object_viewport* RNA_def_property_update

21 months agoFix T60999: Duplifaced objects are not drawn in edit mode
Sergey Sharybin [Tue, 12 Feb 2019 16:04:59 +0000 (17:04 +0100)]
Fix T60999: Duplifaced objects are not drawn in edit mode

Seems to be rather trivial change to use proper cage mesh nowadays.

21 months agoFix T61462: Missing update when toggling GP layer visibility in the Outliner
Antonioya [Tue, 12 Feb 2019 16:01:09 +0000 (17:01 +0100)]
Fix T61462: Missing update when toggling GP layer visibility in the Outliner

21 months agoUse direct access to evaluated mesh from instancing
Sergey Sharybin [Tue, 12 Feb 2019 15:00:46 +0000 (16:00 +0100)]
Use direct access to evaluated mesh from instancing

It is supposed to be already evaluated. If for some reason it's not
doing such direct evaluation will not be reliable anyway (indirect
dependencies for example).

This fixes an assert part of T61431.

21 months agoDepsgraph: Special relation for instances and metaballs
Sergey Sharybin [Tue, 12 Feb 2019 14:58:45 +0000 (15:58 +0100)]
Depsgraph: Special relation for instances and metaballs

Ensures that object which is set for instance-vert or instance-face
is evaluated prior to metaball. This is because metaball will request
list of instances during evaluation.

This should fix issue reported T61431 in release build. The assert is
still there and is to be addressed separately.

21 months agoCleanup: Make parent relations a bit cleaner
Sergey Sharybin [Tue, 12 Feb 2019 14:37:57 +0000 (15:37 +0100)]
Cleanup: Make parent relations a bit cleaner

Mainly getting rid of old and somewhat misleading and unclear

21 months agoFix T61458: GP Ctrl + F doesn't do anything
Antonioya [Tue, 12 Feb 2019 15:38:02 +0000 (16:38 +0100)]
Fix T61458: GP Ctrl + F doesn't do anything

This keymap was used in the old grease pencil and now must be removed.

The keymaps for brush are:

F: Change Radius
Shift + F: Change strength

Ctrl+F -> Removed.

21 months agoFix T61428: Node editor's 'Interface' panel shows in all tabs
Philipp Oeser [Tue, 12 Feb 2019 14:35:13 +0000 (15:35 +0100)]
Fix T61428: Node editor's 'Interface' panel shows in all tabs

Reviewers: brecht

Maniphest Tasks: T61428

Differential Revision:

21 months agoModifiers: Make Difference default operation for boolean modifier.
Bastien Montagne [Tue, 12 Feb 2019 12:51:33 +0000 (13:51 +0100)]
Modifiers: Make Difference default operation for boolean modifier.

Make Difference a default value for boolean modifier operation property.

Currently operation property of the boolean modifier is set to Intersect, which is the least frequently used boolean operation of the three available. It is also goes out of sync with Intersect (Boolean) tool, where Difference is a default operation.

Reviewers: mont29, brecht, sergey

Reviewed By: mont29, brecht, sergey

Subscribers: mont29, brecht, campbellbarton, sergey, billreynish

Tags: #modifiers

Differential Revision:

21 months agoFix T61455: Import any add-on broken
Philipp Oeser [Tue, 12 Feb 2019 12:32:39 +0000 (13:32 +0100)]
Fix T61455: Import any add-on broken

recent split out of (rB9ec944bbab7a) forgot to move
'module_filesystem_remove' there as well...

21 months agoFix T61430: invoke_popup() does not respect ui scale
Jacques Lucke [Tue, 12 Feb 2019 12:30:24 +0000 (13:30 +0100)]
Fix T61430: invoke_popup() does not respect ui scale

Reviewers: brecht

Differential Revision:

21 months agoDepsgraph: Run rigid body after modifiers are ready
Sergey Sharybin [Tue, 12 Feb 2019 11:32:03 +0000 (12:32 +0100)]
Depsgraph: Run rigid body after modifiers are ready

This makes it so modifiers are using object transform prior
to the rigid body simulation, and then result of modifier
stack is fed to the solver.

Solves dependency cycle which was happening when object's
modifier was dependent on the modifier transform.

While now it is not possible to change simulation, things
are somewhat more clear and reliable in other ways.
For example previously, solver was using derives mesh from
a previous step in time, which causes unfixable simulation
issues (with intersections and such)

Fixex T57589: 2.79 Rigid Body Sim. Does Not Behave The Same In 2.8
Fixex T61256: Compositing scenes causes crash, but rendering separately does not
Fixes T61262: Armature and rigid body crash
Fixes T61346: Rigid body with modifiers incorrect work

21 months agoWeight modifiers: Remove weird looking dependency
Sergey Sharybin [Tue, 12 Feb 2019 11:04:48 +0000 (12:04 +0100)]
Weight modifiers: Remove weird looking dependency

Modifiers are part of geometry component, no way they can
be dependent on the geometry component of the same object.

21 months agoDepsgraph: Add utility function for transform dependency
Sergey Sharybin [Tue, 12 Feb 2019 11:01:17 +0000 (12:01 +0100)]
Depsgraph: Add utility function for transform  dependency

This is what modifiers are to use to indicate that they depend
on a transformation of the object itself.

Currently should be no functional changes, but in the future
this will allow to easily change transform operation depending
on whether there is a simulation associated with the object.

21 months agoFix fur on Spring characters
Sergey Sharybin [Tue, 12 Feb 2019 09:55:15 +0000 (10:55 +0100)]
Fix fur on Spring characters

There is an issue of hair being completely messed up when
switching to a simulation view layer for Autumn.

Restoring back the code which was re-setting particles on
file load. This will re-set unbacked particles on file load
but this appears to be happening in 2.7 as well.

Can not reproduce bugs which were fixed in this area recently,
so maybe it's finally tackled (fingers crossed!).

21 months agoCleanup: move utility functions into dna_utils
Campbell Barton [Tue, 12 Feb 2019 06:56:35 +0000 (17:56 +1100)]
Cleanup: move utility functions into dna_utils

Rename old/new to src/dst since renaming happens in both directions
when versioning.

21 months agomakesdna: add shared utility module
Campbell Barton [Tue, 12 Feb 2019 06:03:16 +0000 (17:03 +1100)]
makesdna: add shared utility module

Currently only a single function was duplicated which isn't so bad,
this change is to allow DNA versioning code to be shared between
dna_genfile.c and makesdna.c.

21 months agomakesdna: use memarena for string allocations
Campbell Barton [Tue, 12 Feb 2019 05:47:39 +0000 (16:47 +1100)]
makesdna: use memarena for string allocations

Include it since versioning code will need to perform
small string allocations too, which doesn't fit will into
the currently used fixed size buffers.

21 months agoBLI_memarena: remove use of BLI_linklist
Campbell Barton [Tue, 12 Feb 2019 05:21:27 +0000 (16:21 +1100)]
BLI_memarena: remove use of BLI_linklist

Preprare for using memarena w/ makesdna, BLI_linklist depends on
BLI_mempool. Since linked list use in here is simple, do it inline.

21 months agoCleanup: use printf define in makesdna
Campbell Barton [Mon, 11 Feb 2019 23:10:04 +0000 (10:10 +1100)]
Cleanup: use printf define in makesdna

21 months agoDNA: support versioning structs & struct members
Campbell Barton [Mon, 11 Feb 2019 22:29:18 +0000 (09:29 +1100)]
DNA: support versioning structs & struct members

This is only to be used rarely because it's not forwards compatible.

Replace version patching of old 2.80 DNA with a more generic API.

21 months agoWM: default to opening maximized
Campbell Barton [Mon, 11 Feb 2019 22:08:09 +0000 (09:08 +1100)]
WM: default to opening maximized

Blender is typically used maximized or fullscreen,
load maximized instead of attempting to fill the screen bounds.

To load un-maximized use '--window-border' argument.

See D4332

21 months agoFix T61391: MeshDeform Modifier does not work on a solidified planar mesh.
Bastien Montagne [Mon, 11 Feb 2019 19:20:12 +0000 (20:20 +0100)]
Fix T61391: MeshDeform Modifier does not work on a solidified planar mesh.

`BKE_modifier_get_evaluated_mesh_from_evaluated_object()` used by
modifiers needing access to other objects' geometry probably skipped out
of the radar when cage and final evaluated meshes were added to
BMEditMesh? In any case, we do not need to duplicate (and then free!) a
temp mesh from editdata anymore, and we can even add instead a parameter
to get cage instead of final. Also makes modifiers code a bit simpler.

21 months agoMerge branch 'blender2.7'
Brecht Van Lommel [Mon, 11 Feb 2019 17:39:31 +0000 (18:39 +0100)]
Merge branch 'blender2.7'

21 months agoCycles: add animation denoising test, fix operator to work with single frames.
Brecht Van Lommel [Mon, 11 Feb 2019 17:26:47 +0000 (18:26 +0100)]
Cycles: add animation denoising test, fix operator to work with single frames.

21 months agoCycles: backport samples metadata format changes to 2.7.
Sergey Sharybin [Wed, 6 Feb 2019 10:49:41 +0000 (11:49 +0100)]
Cycles: backport samples metadata format changes to 2.7.

The render layer name is now always included. Best to keep these consistent,
so that animation denoising and sample merging works the same for both and
tests can be the same. Ref D4311.

21 months agoFix T61376 Group Node Node Editor theme property is missing alpha channel
Sebastian Parborg [Mon, 11 Feb 2019 15:56:20 +0000 (16:56 +0100)]
Fix T61376 Group Node Node Editor theme property is missing alpha channel

It is now possible to adjust the group node background alpha.
The defaults are the same as before, but you can now adjust the alpha
level via the theme preferences (and the alpha value is no longer hard

21 months agoGP: Avoid crash when bruhs setting are invalid
Antonioya [Mon, 11 Feb 2019 14:57:45 +0000 (15:57 +0100)]
GP: Avoid crash when bruhs setting are invalid

This change avoids crashes for wrong settings, but we need find why the settings were wrong.

Related to T61413

21 months agoCleanup: comments
Campbell Barton [Mon, 11 Feb 2019 14:21:09 +0000 (01:21 +1100)]
Cleanup: comments

21 months agoUI: Use icon in Dopesheet 'Toggle Graph Editor' menu item.
Pablo Vazquez [Mon, 11 Feb 2019 14:46:00 +0000 (15:46 +0100)]
UI: Use icon in Dopesheet 'Toggle Graph Editor' menu item.

21 months agoUI: More descriptive labels for Metaball panel.
Pablo Vazquez [Mon, 11 Feb 2019 14:45:18 +0000 (15:45 +0100)]
UI: More descriptive labels for Metaball panel.

Also remove redundant "Resolution" label.

21 months agoMerge branch 'blender2.7'
Brecht Van Lommel [Mon, 11 Feb 2019 14:25:46 +0000 (15:25 +0100)]
Merge branch 'blender2.7'

21 months agoFix T61362: Hair particles does not appear when rendering
Sergey Sharybin [Mon, 11 Feb 2019 14:18:12 +0000 (15:18 +0100)]
Fix T61362: Hair particles does not appear when rendering
Fix T61406: Particles don't render

Consider initial dependency graph evaluation as a file load.

Is still resetting too much, but that we can solve later.

21 months agoDepsgraph: Use proper tag source for special case
Sergey Sharybin [Mon, 11 Feb 2019 14:16:38 +0000 (15:16 +0100)]
Depsgraph: Use proper tag source for special case

Special case of handling update tag of 0 was using wrong update
source, causing unwanted point cache resets on file load.

21 months agoFix build error on macOS after recent changes.
Brecht Van Lommel [Mon, 11 Feb 2019 14:03:28 +0000 (15:03 +0100)]
Fix build error on macOS after recent changes.

21 months agoFix: Eevee SSS not rendering as expected
Clément Foucault [Mon, 11 Feb 2019 13:50:25 +0000 (14:50 +0100)]
Fix: Eevee SSS not rendering as expected

Remove forcing separate albedo when rendering. It was creating confusion.

21 months agoFix T61374 : vertex not visible/selectable if it is at objects origin
Clément Foucault [Mon, 11 Feb 2019 13:37:19 +0000 (14:37 +0100)]
Fix T61374 : vertex not visible/selectable if it is at objects origin

It was caused by Null normal if the vertex is at origin. Just add a small
bias to avoid this case.

21 months agoCleanup: avoid string copy for comparing int id's
Campbell Barton [Mon, 11 Feb 2019 12:48:40 +0000 (23:48 +1100)]
Cleanup: avoid string copy for comparing int id's

More direct and readable.

21 months agoCycles: add animation denoising Python operator.
Lukas Stockner [Wed, 6 Feb 2019 11:57:10 +0000 (12:57 +0100)]
Cycles: add animation denoising Python operator.

This adds a cycles.denoise_animation operator, which denoises an animation
sequence or individual file. Renders must be saved as multilayer EXR files
with denoising data passes.

By default file path and frame range come from the current scene, and EXR
files are denoised in-place. Alternatively, a different input and/or output
file path can be provided.

Denoising settings come from the current view layer. Renders can be denoised
again with different settings, as the original noisy image is preserved along
with other passes and metadata.

There is no user interface yet for this feature, that comes later.

Code by Lukas with modifications by Brecht. This feature was originally
developed for Tangent Animation, thanks for the support!

Differential Revision:

21 months agoMerge branch 'blender2.7'
Brecht Van Lommel [Mon, 11 Feb 2019 12:37:45 +0000 (13:37 +0100)]
Merge branch 'blender2.7'

21 months agoCycles: add animation denoising Python operator.
Lukas Stockner [Wed, 6 Feb 2019 11:57:10 +0000 (12:57 +0100)]
Cycles: add animation denoising Python operator.

This adds a cycles.denoise_animation operator, which denoises an animation
sequence or individual file. Renders must be saved as multilayer EXR files
with denoising data passes.

By default file path and frame range come from the current scene, and EXR
files are denoised in-place. Alternatively, a different input and/or output
file path can be provided.

Denoising settings come from the current view layer. Renders can be denoised
again with different settings, as the original noisy image is preserved along
with other passes and metadata.

There is no user interface yet for this feature, that comes later.

Code by Lukas with modifications by Brecht. This feature was originally
developed for Tangent Animation, thanks for the support!

21 months agoCleanup: split user preferences out of
Campbell Barton [Mon, 11 Feb 2019 12:17:05 +0000 (23:17 +1100)]
Cleanup: split user preferences out of

These operations are for handling preference related tasks so move into
into a preferences file.

Operators still need to be renamed.

21 months agoCycles: refactor Blender device settings handling into own file.
Brecht Van Lommel [Wed, 6 Feb 2019 15:15:45 +0000 (16:15 +0100)]
Cycles: refactor Blender device settings handling into own file.

21 months agoUI: show camera DOF UI for workbench engine
William Reynish [Mon, 11 Feb 2019 11:45:36 +0000 (22:45 +1100)]
UI: show camera DOF UI for workbench engine

21 months agoFix T61185: Missing modifiers update on changes to texture
Philipp Oeser [Tue, 5 Feb 2019 09:04:09 +0000 (10:04 +0100)]
Fix T61185: Missing modifiers update on changes to texture

Also update relations when modifier texture changes.

Basically same as rB6e00415a85a9, rBca2680aaeb1 but this time for
VertexWeight modifiers

Reviewers: sergey

Maniphest Tasks: T61185

Differential Revision:

21 months agoreadfile: skip negative sized thumbnails
Campbell Barton [Mon, 11 Feb 2019 08:09:27 +0000 (19:09 +1100)]
readfile: skip negative sized thumbnails

We may want to use 'TEST' BCode in the future for including data
besides thumbnails. This allows negative values to be used w/o
attempting to load a thumbnail.

21 months agoCleanup: unused speaker flag
Campbell Barton [Mon, 11 Feb 2019 06:55:15 +0000 (17:55 +1100)]
Cleanup: unused speaker flag

21 months agoCleanup: RNA boolean names (use prefix conventions)
Campbell Barton [Mon, 11 Feb 2019 06:49:35 +0000 (17:49 +1100)]
Cleanup: RNA boolean names (use prefix conventions)

21 months agoCleanup: move runtime vars into Camera_Runtime
Campbell Barton [Mon, 11 Feb 2019 05:54:23 +0000 (16:54 +1100)]
Cleanup: move runtime vars into Camera_Runtime

21 months agoCleanup: use "_Runtime" suffix for DNA
Campbell Barton [Mon, 11 Feb 2019 05:48:42 +0000 (16:48 +1100)]
Cleanup: use "_Runtime" suffix for DNA

Was done everywhere except bPoseChannel.

21 months agoPreferences: remove tweak/drag threshold distinction
Campbell Barton [Mon, 11 Feb 2019 04:34:19 +0000 (15:34 +1100)]
Preferences: remove tweak/drag threshold distinction

Currently the preferences have both tweak and drag threshold,
this is confusing because most actions users would consider
dragging use the 'tweak' setting.

Now one drag threshold is used for both, with a maximum limit of half
the button unit-size in case of dragging UI elements.