17 months agoRevert "Fix T55568: second click event ignored"
Campbell Barton [Thu, 21 Jun 2018 17:24:50 +0000 (19:24 +0200)]
Revert "Fix T55568: second click event ignored"

This reverts commit 52aa963f0ef1b6f4abba6653e9a441dee234127a.

Fixed for keyboards, broke mouse buttons.

17 months agoUI: don't show empty button context menu
Campbell Barton [Thu, 21 Jun 2018 14:33:27 +0000 (16:33 +0200)]
UI: don't show empty button context menu

17 months agoFix Cycles incorrect versioning for automatic sample world resolution.
Brecht Van Lommel [Thu, 21 Jun 2018 13:25:29 +0000 (15:25 +0200)]
Fix Cycles incorrect versioning for automatic sample world resolution.

17 months agoUI: preference for developer extras
Campbell Barton [Thu, 21 Jun 2018 12:54:21 +0000 (14:54 +0200)]
UI: preference for developer extras

Currently only used for "Edit Source" feature.

17 months agoFix T55568: second click event ignored
Campbell Barton [Thu, 21 Jun 2018 08:58:03 +0000 (10:58 +0200)]
Fix T55568: second click event ignored

Double-click handling caused the second click to be ignored
for keymaps that only handle click.

17 months agoFix Cycles CUDA render errors with CUDA 9.2.
Brecht Van Lommel [Thu, 21 Jun 2018 09:29:09 +0000 (11:29 +0200)]
Fix Cycles CUDA render errors with CUDA 9.2.

Work around what might be a compiler bug.

17 months agoFix T55564: Cycles OpenCL build error on some scenes.
Brecht Van Lommel [Thu, 21 Jun 2018 09:18:51 +0000 (11:18 +0200)]
Fix T55564: Cycles OpenCL build error on some scenes.

17 months agoFix T55491: Double click fail in menu popups
Campbell Barton [Thu, 21 Jun 2018 07:50:24 +0000 (09:50 +0200)]
Fix T55491: Double click fail in menu popups

17 months agoWM: don't make LMB a special case for double click
Campbell Barton [Thu, 21 Jun 2018 07:49:30 +0000 (09:49 +0200)]
WM: don't make LMB a special case for double click

17 months agoCleanup: naming (make it clear vars are squared)
Campbell Barton [Wed, 20 Jun 2018 13:58:46 +0000 (15:58 +0200)]
Cleanup: naming (make it clear vars are squared)

17 months agoScreen: split ED_area_actionzone_find_xy
Campbell Barton [Wed, 20 Jun 2018 13:32:46 +0000 (15:32 +0200)]
Screen: split ED_area_actionzone_find_xy

Add ED_area_actionzone_refresh_xy which can tag redraw
find no longer changes changes to the action zone.

17 months agoCleanup: rename is_in_area_actionzone
Campbell Barton [Wed, 20 Jun 2018 11:52:56 +0000 (13:52 +0200)]
Cleanup: rename is_in_area_actionzone

17 months agoCleanup: quiet warning
Campbell Barton [Wed, 20 Jun 2018 11:55:16 +0000 (13:55 +0200)]
Cleanup: quiet warning

17 months agoCleanup: remove some G.main from BKE's node.c
Bastien Montagne [Wed, 20 Jun 2018 10:16:16 +0000 (12:16 +0200)]
Cleanup: remove some G.main from BKE's node.c

Validate some cases using G_MAIN instead (I don't think we want to work
on any other Main than G.main one when registering/unregistering nodes

And when freeing, all ID not in Main shall now be tagged accordingly, so
we *should* not need to do that stupi search over all ntrees in G.main
to check wether we have to free it ourself or not!

17 months agoUI: only show "Edit Translations" when addon used
Campbell Barton [Wed, 20 Jun 2018 08:45:03 +0000 (10:45 +0200)]
UI: only show "Edit Translations" when addon used

17 months agoFinal cleanup of G.mains in render area.
Bastien Montagne [Tue, 19 Jun 2018 17:25:06 +0000 (19:25 +0200)]
Final cleanup of G.mains in render area.

17 months agoCycles: Fixed crash when the camera was inside 16 volumes or more. It still won't...
Stefan Werner [Tue, 19 Jun 2018 14:34:15 +0000 (16:34 +0200)]
Cycles: Fixed crash when the camera was inside 16 volumes or more. It still won't render those volumes correctly, but at least the crash is addressed.

17 months agoFix (unreported) passing CDLayer 'ID' instead of bitflag to a cdlayer mask!
Bastien Montagne [Tue, 19 Jun 2018 14:25:24 +0000 (16:25 +0200)]
Fix (unreported) passing CDLayer 'ID' instead of bitflag to a cdlayer mask!

Probably harmless, since I bet CD_ORIGINDEX is nearly always generated,
but still...

17 months agoFix T55528: Cycles AO node should default to 1 if radius is 0.
Brecht Van Lommel [Tue, 19 Jun 2018 09:44:23 +0000 (11:44 +0200)]
Fix T55528: Cycles AO node should default to 1 if radius is 0.

17 months agoCleanup DM generation code for ProjPaint.
Bastien Montagne [Tue, 19 Jun 2018 08:48:37 +0000 (10:48 +0200)]
Cleanup DM generation code for ProjPaint.

Two branches were actually doing essentially the same thing here, no
need to artificially complicate things. ;)

17 months agoFix (unreported) unauthorized relesing of derived_final DM in paint projection code.
Bastien Montagne [Tue, 19 Jun 2018 08:43:54 +0000 (10:43 +0200)]
Fix (unreported) unauthorized relesing of derived_final DM in paint projection code.

NEVER free yourself DM returned by mesh_get_derived_final(), it's always
to one assigned to ob->derived_final!

17 months agoVertex Paint: set sculpt object mode immediately
Campbell Barton [Tue, 19 Jun 2018 06:35:41 +0000 (08:35 +0200)]
Vertex Paint: set sculpt object mode immediately

SculptSession.mode_type wasn't initialized until painting,
making it unreliable for checks in other parts of the code.

Also remove unnecessary initialization,
matching sculpt mode more closely.

17 months agoeditorconfig: correct C/C++ using space
Campbell Barton [Tue, 19 Jun 2018 05:48:12 +0000 (07:48 +0200)]
editorconfig: correct C/C++ using space

17 months agomake.bat: Fix msvc-2017 detection.
Ray Molenkamp [Mon, 18 Jun 2018 19:39:12 +0000 (13:39 -0600)]
make.bat: Fix msvc-2017 detection.

D3485 by @manung

Differential Revision:

17 months agoeditorconfig: add rst
Campbell Barton [Mon, 18 Jun 2018 16:53:49 +0000 (18:53 +0200)]
editorconfig: add rst

17 months agoeditorconfig: add line length, glsl
Campbell Barton [Mon, 18 Jun 2018 16:21:35 +0000 (18:21 +0200)]
editorconfig: add line length, glsl

17 months agoAdd .editorconfig file
Campbell Barton [Mon, 18 Jun 2018 16:09:45 +0000 (18:09 +0200)]
Add .editorconfig file

This is a fairly well supported file-type configuration
for indentation and trailing space stripping.

See for details.

17 months agoFix T55503: File browser filter not working correctly.
Bastien Montagne [Mon, 18 Jun 2018 10:26:47 +0000 (12:26 +0200)]
Fix T55503: File browser filter not working correctly.

There were two issues here, introduced by rB66aa4af836:
* Forgot to change length of some filter_glob var deep in filebrowser code.
* Truncating filter_glob in general can be dangerous, generating
unexpected patterns.

Last point was the root of the issue here, truncating to 63 chars string
left last group as 'match everything' `*` pattern.

To fix that to some extent, added a new BLI_path_extension_glob_validate
helper to BLI_path_util, which ensures we do not have last
wildcards-only group in our pattern, when there are more than one group.

17 months agoRNA: disable animation for file output options
Campbell Barton [Mon, 18 Jun 2018 05:31:21 +0000 (07:31 +0200)]
RNA: disable animation for file output options

17 months agoCleanup: trailing space cmake, make.bat
Campbell Barton [Sun, 17 Jun 2018 18:18:09 +0000 (20:18 +0200)]
Cleanup: trailing space cmake, make.bat

17 months agoCleanup: trailing space in CMake files
Campbell Barton [Sun, 17 Jun 2018 18:15:24 +0000 (20:15 +0200)]
Cleanup: trailing space in CMake files

17 months agoPython: Allow untrusted py-drivers to run limited expressions
Campbell Barton [Sun, 17 Jun 2018 17:51:05 +0000 (19:51 +0200)]
Python: Allow untrusted py-drivers to run limited expressions

Limit to a restricted set of built-ins, as well as the math module.
Also restrict of op-codes, disallowing imports and attribute access.

This allows most math expressions to run
without any performance cost once the initial check is done.

See: D1862 for details.

17 months agoCleanup: trailing space for remaining source/
Campbell Barton [Sun, 17 Jun 2018 15:06:28 +0000 (17:06 +0200)]
Cleanup: trailing space for remaining source/

17 months agoCleanup: trailing space for blenloader
Campbell Barton [Sun, 17 Jun 2018 15:06:07 +0000 (17:06 +0200)]
Cleanup: trailing space for blenloader

17 months agoCleanup: trailing space for blenkernel
Campbell Barton [Sun, 17 Jun 2018 15:05:51 +0000 (17:05 +0200)]
Cleanup: trailing space for blenkernel

17 months agoCleanup: trailing space for compositor
Campbell Barton [Sun, 17 Jun 2018 15:05:29 +0000 (17:05 +0200)]
Cleanup: trailing space for compositor

17 months agoCleanup: trailing space for freestyle
Campbell Barton [Sun, 17 Jun 2018 15:05:14 +0000 (17:05 +0200)]
Cleanup: trailing space for freestyle

17 months agoCleanup: trailing space for imbuf module
Campbell Barton [Sun, 17 Jun 2018 15:04:54 +0000 (17:04 +0200)]
Cleanup: trailing space for imbuf module

17 months agoCleanup: trailing space for modifiers
Campbell Barton [Sun, 17 Jun 2018 15:04:27 +0000 (17:04 +0200)]
Cleanup: trailing space for modifiers

17 months agoCleanup: trailing space for DNA headers
Campbell Barton [Sun, 17 Jun 2018 15:04:09 +0000 (17:04 +0200)]
Cleanup: trailing space for DNA headers

17 months agoCleanup: trailing space in source/gameengine/
Campbell Barton [Sun, 17 Jun 2018 15:01:43 +0000 (17:01 +0200)]
Cleanup: trailing space in source/gameengine/

17 months agoCleanup: trailing space for BLI
Campbell Barton [Sun, 17 Jun 2018 14:32:54 +0000 (16:32 +0200)]
Cleanup: trailing space for BLI

17 months agoCleanup: remove unused BLI_rebase_path
Campbell Barton [Sun, 17 Jun 2018 14:26:47 +0000 (16:26 +0200)]
Cleanup: remove unused BLI_rebase_path

17 months agoCleanup: BLI path extension API
Campbell Barton [Sun, 17 Jun 2018 14:13:24 +0000 (16:13 +0200)]
Cleanup: BLI path extension API

Use BLI_path_extension_* prefix.

17 months agoBLI_path: add string size debug define
Campbell Barton [Sun, 17 Jun 2018 13:35:00 +0000 (15:35 +0200)]
BLI_path: add string size debug define

Off by default, only for debugging.

17 months agoCMake: add missing headers
Campbell Barton [Sun, 17 Jun 2018 09:56:20 +0000 (11:56 +0200)]
CMake: add missing headers

17 months agoCleanup: use clamp_* from BLI_math (replace macro)
Campbell Barton [Sun, 17 Jun 2018 09:50:56 +0000 (11:50 +0200)]
Cleanup: use clamp_* from BLI_math (replace macro)

17 months agomake.bat: Fix `make showhashes` not working.
Ray Molenkamp [Sat, 16 Jun 2018 18:29:38 +0000 (12:29 -0600)]
make.bat: Fix `make showhashes` not working.

broke in recent refactor.

17 months agoFix T55427: Removing Vertex Group used by Data Transfer Modifier results in crash.
Bastien Montagne [Sat, 16 Jun 2018 14:19:53 +0000 (16:19 +0200)]
Fix T55427: Removing Vertex Group used by Data Transfer Modifier results in crash.

Only fixing crash, proper handling (a.k.a remapping) of all
possible cases here, for all possible data layers, is rather involved...

17 months agoUI: refactor drag-toggle for other button types
Campbell Barton [Sat, 16 Jun 2018 14:04:26 +0000 (16:04 +0200)]
UI: refactor drag-toggle for other button types

17 months agoUI: minor changes from 2.8
Campbell Barton [Sat, 16 Jun 2018 13:44:13 +0000 (15:44 +0200)]
UI: minor changes from 2.8

- Option to skip multi-data edits.
- Open hold buttons on drag.
- Utility function to set default value.

17 months agoCycles Cleanup: Remove unneccessary color management call
Lukas Stockner [Sat, 16 Jun 2018 11:47:49 +0000 (13:47 +0200)]
Cycles Cleanup: Remove unneccessary color management call

17 months agoCycles: change Ambient Occlusion shader to output colors.
Lukas Stockner [Fri, 15 Jun 2018 09:03:29 +0000 (11:03 +0200)]
Cycles: change Ambient Occlusion shader to output colors.

This means the shader can now be used for procedural texturing. New
settings on the node are Samples, Inside, Local Only and Distance.

Original patch by Lukas with further changes by Brecht.

Differential Revision:

17 months agoWM: suppress drag events if motion is handled
Campbell Barton [Fri, 15 Jun 2018 17:09:43 +0000 (19:09 +0200)]
WM: suppress drag events if motion is handled

17 months agoCleanup: some more G.main removal.
Bastien Montagne [Fri, 15 Jun 2018 15:42:17 +0000 (17:42 +0200)]
Cleanup: some more G.main removal.

We are really starting to scratch the last bits here...

17 months agoCleanup: validate G.main's in creator code.
Bastien Montagne [Fri, 15 Jun 2018 15:36:44 +0000 (17:36 +0200)]
Cleanup: validate G.main's in creator code.

Using G_MAIN here is valid!

17 months agoCleanup: some more G.main removal/validation...
Bastien Montagne [Fri, 15 Jun 2018 15:21:07 +0000 (17:21 +0200)]
Cleanup: some more G.main removal/validation...

17 months agoFix more Cycles CUDA errors after recent changes.
Brecht Van Lommel [Fri, 15 Jun 2018 13:58:48 +0000 (15:58 +0200)]
Fix more Cycles CUDA errors after recent changes.

17 months agoFix T55490, intersect two triangles fails.
Howard Trickey [Fri, 15 Jun 2018 12:48:45 +0000 (08:48 -0400)]
Fix T55490, intersect two triangles fails.

Need to use the 'use_partial_connect' option in island connect,
so changed signatures of various functions to pass that into and
then down from BM_mesh_intersect (making true for intersect, false
for boolean).
Then fix bm_face_split_edgenet_partial_connect to work when
input edges are not necessarily wire, but at least not in the
face they are being connected in. That caused generalization
of core BM_vert_separate_hflag_wire (which is only used in
this one place in all Blender).

17 months agoFix (unreported) Text Editor: scrollbar exiting early
Philipp Oeser [Fri, 15 Jun 2018 08:25:18 +0000 (10:25 +0200)]
Fix (unreported) Text Editor: scrollbar exiting early

caused by recent clickdrag changes

17 months agoFix Cycles CUDA error after recent changes.
Brecht Van Lommel [Fri, 15 Jun 2018 08:06:32 +0000 (10:06 +0200)]
Fix Cycles CUDA error after recent changes.

17 months agoWM: 2.8 screen compatibility
Campbell Barton [Fri, 15 Jun 2018 08:23:03 +0000 (10:23 +0200)]
WM: 2.8 screen compatibility

Without these minor changes loading files from 2.8 will crash.

Manually applied edits from 26786a2b87a08

17 months agoCycles: Query XYZ to/from Scene Linear conversion from OCIO instead of assuming sRGB
Lukas Stockner [Thu, 14 Jun 2018 15:48:19 +0000 (17:48 +0200)]
Cycles: Query XYZ to/from Scene Linear conversion from OCIO instead of assuming sRGB

I've limited it to just the RGB<->XYZ stuff for now, correct image handling is the next step.

Reviewers: brecht, sergey

Differential Revision:

17 months agoCycles: Connect value inputs to Strength instead of Color when inserting an Emission...
Lukas Stockner [Thu, 14 Jun 2018 20:16:42 +0000 (22:16 +0200)]
Cycles: Connect value inputs to Strength instead of Color when inserting an Emission node

Same result, but saves an additional ConvertNode.

17 months agoCycles: Automatically detect HDRI resolution by default and use non-square sampling map
Lukas Stockner [Thu, 14 Jun 2018 14:18:34 +0000 (16:18 +0200)]
Cycles: Automatically detect HDRI resolution by default and use non-square sampling map

The automatic mode checks all Enviroment Texture nodes and picks the largest image's resolution.
If there are no Enviroment Textures, it just uses the old default.

Also, the sampling map now isn't limited to square shapes. The automatic detection uses the exact image size,
the manual UI option now halves the value to get the height.

A default aspect ratio of 2:1 makes sense since this is what most HDRIs use.

Reviewers: brecht, sergey

Differential Revision:

17 months agoCleanup: remove last G.main's from Collada code.
Bastien Montagne [Thu, 14 Jun 2018 13:15:51 +0000 (15:15 +0200)]
Cleanup: remove last G.main's from Collada code.

17 months agoCleanup: Remove last G.main's from WM code.
Bastien Montagne [Thu, 14 Jun 2018 10:34:13 +0000 (12:34 +0200)]
Cleanup: Remove last G.main's from WM code.

Was mostly validating valid usages of G.main -> G_MAIN actually.

17 months agoFix T55470: Add option to not fix polygons' winding to Edit Normals modifier.
Bastien Montagne [Thu, 14 Jun 2018 09:41:12 +0000 (11:41 +0200)]
Fix T55470: Add option to not fix polygons' winding to Edit Normals modifier.

this is actually adding option to add buggy behavior, but.. NPR often
expects buggy behaviors, and its one of the main targets for normal editing.
So think it's reasonable to add that option (disabled by default of

Note that am not really happy with UI, but:
* Not sure where to put it, it's kind of own self-contained area option.
* Don't to make it too much visible, using this should be the exception!

17 months agoFix undo group to use human readable name, since this shows in the UI.
Brecht Van Lommel [Wed, 13 Jun 2018 16:38:38 +0000 (18:38 +0200)]
Fix undo group to use human readable name, since this shows in the UI.

17 months agoFix undo of transform after frame change undoing too much.
Brecht Van Lommel [Wed, 13 Jun 2018 16:22:17 +0000 (18:22 +0200)]
Fix undo of transform after frame change undoing too much.

For grouped undo we should not skip the undo push, rather replace the
previous undo push. This way undo goes back to the state after the last
operation in the group.

17 months agoCycles: auto insert emission node when linking color to closure.
Brecht Van Lommel [Wed, 13 Jun 2018 14:29:06 +0000 (16:29 +0200)]
Cycles: auto insert emission node when linking color to closure.

This is convenient for previewing the output of a node, and we agreed
to support this behavior in both Eevee and Cycles.

17 months agoWM: check release event for particle edit mode
Campbell Barton [Wed, 13 Jun 2018 16:23:09 +0000 (18:23 +0200)]
WM: check release event for particle edit mode

Caused by drag event.

17 months agoCleanup: get rid of last G.main in BMesh code.
Bastien Montagne [Wed, 13 Jun 2018 14:29:12 +0000 (16:29 +0200)]
Cleanup: get rid of last G.main in BMesh code.

17 months agoCleanup: moar ugly G.main removal...
Bastien Montagne [Wed, 13 Jun 2018 12:26:26 +0000 (14:26 +0200)]
Cleanup: moar ugly G.main removal...

Note that due to RNA get/setters issue, that one may actually add some
G.main usages to the total... But at least it's not hidden anymore in a
very low-level, dark corner of BKE pointcache code!

17 months agoFix T55467: nodes cant be resized after recent clickdrag change
Philipp Oeser [Wed, 13 Jun 2018 12:03:46 +0000 (14:03 +0200)]
Fix T55467: nodes cant be resized after recent clickdrag change

17 months agoCleanup: swapped X/Y UI_UNIT
Campbell Barton [Wed, 13 Jun 2018 09:10:32 +0000 (11:10 +0200)]
Cleanup: swapped X/Y UI_UNIT

17 months agoCleanup: remove more G.main from BKE area.
Bastien Montagne [Wed, 13 Jun 2018 08:57:10 +0000 (10:57 +0200)]
Cleanup: remove more G.main from BKE area.

17 months agoCleanup: moar G.main removal from BKE area.
Bastien Montagne [Tue, 12 Jun 2018 15:57:24 +0000 (17:57 +0200)]
Cleanup: moar G.main removal from BKE area.

17 months agoCleanup: BKE_scene_free should not have to worry about cleaning its usages.
Bastien Montagne [Tue, 12 Jun 2018 15:46:16 +0000 (17:46 +0200)]
Cleanup: BKE_scene_free should not have to worry about cleaning its usages.

This is supposed to be handled by calling code! Henceforce, no need to
call BKE_sequencer_clear_scene_in_allseqs() here, and... no need for
that ugly G.main case. ;)

17 months agoWM: remove sloppy region type access
Campbell Barton [Tue, 12 Jun 2018 15:34:44 +0000 (17:34 +0200)]
WM: remove sloppy region type access

Avoid accidentally operating on the wrong region type.

17 months agoWM: rename BKE_regiontype_from_id
Campbell Barton [Tue, 12 Jun 2018 15:26:38 +0000 (17:26 +0200)]
WM: rename BKE_regiontype_from_id

This returns the first as a fallback, causing confusing usage.
Renamed and added a version of the function that doesn't.

17 months agoFix T55452: Crash on saving with visible particle system.
Bastien Montagne [Tue, 12 Jun 2018 14:17:05 +0000 (16:17 +0200)]
Fix T55452: Crash on saving with visible particle system.

Missing Main pointer in recent refactor/cleanup of G.main usages...

17 months agoCleanup: moar removal of G.main in BKE area...
Bastien Montagne [Tue, 12 Jun 2018 13:16:45 +0000 (15:16 +0200)]
Cleanup: moar removal of G.main in BKE area...

17 months agoCleanup/simplify G.main usages.
Bastien Montagne [Tue, 12 Jun 2018 13:03:51 +0000 (15:03 +0200)]
Cleanup/simplify G.main usages.

Using G.main only to get main bled filepath, or built-in fonts, is OK.
So now using the 'valid' G_MAIN macro here instead.

17 months agoCleanup: remove moar G.main from BKE area.
Bastien Montagne [Tue, 12 Jun 2018 10:53:27 +0000 (12:53 +0200)]
Cleanup: remove moar G.main from BKE area.

17 months agoCleanup: remove some G.main from ED's animsys.
Bastien Montagne [Tue, 12 Jun 2018 10:28:14 +0000 (12:28 +0200)]
Cleanup: remove some G.main from ED's animsys.

The easy ones - there some much, much trickier to tackle there...

17 months agoCleanup: remove some G.main from BKE area.
Bastien Montagne [Tue, 12 Jun 2018 09:21:54 +0000 (11:21 +0200)]
Cleanup: remove some G.main from BKE area.

17 months agoFix T55448: Typo in Cycles CUDA debug output
Lukas Stockner [Tue, 12 Jun 2018 08:37:51 +0000 (10:37 +0200)]
Fix T55448: Typo in Cycles CUDA debug output

Reviewers: sergey, lukasstockner97

Reviewed By: lukasstockner97

Tags: #cycles, #bf_blender

Differential Revision:

17 months agoCleanup: remove moar ugly G.main usages...
Bastien Montagne [Mon, 11 Jun 2018 13:40:37 +0000 (15:40 +0200)]
Cleanup: remove moar ugly G.main usages...

BKE_image was an ugly nest, could fix all but the ones from compositor,
so moved ugly G.main there, at least we know where the Evil is that way ;)

17 months agoCycles: Cleanup, silence strict compiler warning
Sergey Sharybin [Mon, 11 Jun 2018 10:54:17 +0000 (12:54 +0200)]
Cycles: Cleanup, silence strict compiler warning

There is one legit place in the code where memcpy was used as an
optimization trick. Was needed for older version of GCC, but now
it should be re-evaluated and checked if it still helps to have
that trick.

In other places it's somewhat lazy programming to zero out all
object members. That is absolutely unsafe, at the moment when
less trivial class is used as a member in that object things
will break.

Other cases were using memcpy into an object which comes from
an external library. We don't control that object, and we can
not guarantee it will always be safe for such memory tricks
and debugging bugs caused by such low level access is far fun.

Ideally we need to use more proper C++, but needs to be done with
big care, including benchmarks of each change, For now do
annoying but simple cast to void*.

17 months agoLibmv: Cleanup, make strict compiler more happy
Sergey Sharybin [Mon, 11 Jun 2018 10:53:11 +0000 (12:53 +0200)]
Libmv: Cleanup, make strict compiler more happy

In C++ it is not really safe to memcpy objects, and newer GCC will warn
about this. However, we don't use our vector for unsafe-to-memcpy objects,
so just explicitly silence that warning.

17 months agoCleanup: Moar G.main removal of Hell.
Bastien Montagne [Mon, 11 Jun 2018 10:14:18 +0000 (12:14 +0200)]
Cleanup: Moar G.main  removal of Hell.

This commit actually adds some G.main... but at much, much higher level
than the ones it removes, so should still be better ;)

17 months agoCleanup: remove some G.main usages...
Bastien Montagne [Mon, 11 Jun 2018 09:05:37 +0000 (11:05 +0200)]
Cleanup: remove some G.main usages...

17 months agoFix bad level stubs
Sergey Sharybin [Mon, 11 Jun 2018 09:36:22 +0000 (11:36 +0200)]
Fix bad level stubs

17 months agoCleanup: Use BLI_strncpy
Sergey Sharybin [Mon, 11 Jun 2018 09:05:24 +0000 (11:05 +0200)]
Cleanup: Use BLI_strncpy

It has behavior which we expect, and silences strict compiler warning.

17 months agoFix T55278: Lightmap Pack > New Image broken when active object is None
Philipp Oeser [Mon, 11 Jun 2018 09:00:19 +0000 (11:00 +0200)]
Fix T55278: Lightmap Pack > New Image broken when active object is None

thanx bblanimation (Christopher Gearhart) for spotting the issue and
providing the fix!

Reviewed By: brecht

Differential Revision:

17 months agopath_util: avoid overflow w/ strtoll use
Campbell Barton [Mon, 11 Jun 2018 08:43:34 +0000 (10:43 +0200)]
path_util: avoid overflow w/ strtoll use

Also style cleanup.

17 months agoFix PyConsole: Drag events finished early in modal text selection
Philipp Oeser [Mon, 11 Jun 2018 08:18:51 +0000 (10:18 +0200)]
Fix PyConsole: Drag events finished early in modal text selection

17 months agoFix T55140: opened image doesn't show up in movie clip editor
Philipp Oeser [Fri, 1 Jun 2018 09:58:50 +0000 (11:58 +0200)]
Fix T55140: opened image doesn't show up in movie clip editor

atoi usage in BLI_stringdec could overflow, use strtoll instead and
valid range with INT_MIN and INT_MAX

Reviewed By: campbellbarton

Differential Revision:

17 months agoFix T55349: crash adding paint slot when object is on hidden layer
Philipp Oeser [Mon, 11 Jun 2018 07:12:29 +0000 (09:12 +0200)]
Fix T55349: crash adding paint slot when object is on hidden layer

use better poll and get ob with 'ED_object_active_context' (instead of

Reviewed By: campbellbarton

Differential Revision: