2 months agoUI: Icons - Adding ICON_OUTLINER_DATA_GP_LAYER Icon
Harley Acheson [Fri, 14 Jun 2019 21:48:07 +0000 (14:48 -0700)]

This adds the icon intended for Grease Pencil layer data, in SVG but currently marked as blank

Differential Revision:

2 months agoCleanup: Rename: Static Override -> Library Override.
Bastien Montagne [Fri, 14 Jun 2019 21:16:04 +0000 (23:16 +0200)]
Cleanup: Rename: Static Override -> Library Override.

Better to make internal code naming match official/UI naming to some
extent, this will reduce confusion in the future.

This is 'breaking' scripts and files that would use that feature, but
since it is not yet officially supported nor exposed in 2.80, as far
as that release is concerned, it is effectively
a 'no functional changes' commit.

2 months agoFix T65814: Copy pasting audio strip from video crash Blender
Sergey Sharybin [Fri, 14 Jun 2019 20:47:34 +0000 (22:47 +0200)]
Fix T65814: Copy pasting audio strip from video crash Blender

2 months agoFix T64913 Eevee: shader compilation does not reset TAA
Clément Foucault [Fri, 14 Jun 2019 17:12:39 +0000 (19:12 +0200)]
Fix T64913 Eevee: shader compilation does not reset TAA

This tracks the number of compiling shaders and just reset the TAA
if previous number mismatch.

2 months agoCleanup: DRW: Remove one useless matrix multiplication
Clément Foucault [Fri, 14 Jun 2019 16:21:34 +0000 (18:21 +0200)]
Cleanup: DRW: Remove one useless matrix multiplication

2 months agoFix T65569 Eevee: Volumetrics on alphablend surf. not working in renders
Clément Foucault [Fri, 14 Jun 2019 16:19:45 +0000 (18:19 +0200)]
Fix T65569 Eevee: Volumetrics on alphablend surf. not working in renders

The wrong volume buffer was used one frame out of two.

2 months agoUI: Outliner - GP Icon Changes
Harley Acheson [Fri, 14 Jun 2019 16:55:07 +0000 (09:55 -0700)]
UI: Outliner - GP Icon Changes

Changes all GP layer icons to Pencil and highlights selected layer with background color.

Differential Revision:

Reviewed by Dalai Felinto

2 months agoOutliner - Notify on GP Layer Change
Harley Acheson [Fri, 14 Jun 2019 16:48:42 +0000 (09:48 -0700)]
Outliner - Notify on GP Layer Change

This adds NA_SELECTED to notifier when selecting Grease Pencil layers so Properties Editor will update

Differential Revision:

Reviewed by Dalai Felinto

2 months agoFix T65641: Move to collection - arrow keys work in the opposite direction
Dalai Felinto [Fri, 14 Jun 2019 15:56:21 +0000 (12:56 -0300)]
Fix T65641: Move to collection - arrow keys work in the opposite direction

Patch my Germano Cavalcante (mano-wii).

2 months agoFix T65630: Paste pose doesn't work with motion paths enabled
Sergey Sharybin [Fri, 14 Jun 2019 15:12:47 +0000 (17:12 +0200)]
Fix T65630: Paste pose doesn't work with motion paths enabled

2 months agoFix pose copy storing action/animation in copybuffer
Sergey Sharybin [Fri, 14 Jun 2019 15:01:59 +0000 (17:01 +0200)]
Fix pose copy storing action/animation in copybuffer

2 months agoFix T65632: Connected Proportional Editing is affected by Curve Object's Local Scale
Sebastian Parborg [Fri, 14 Jun 2019 15:17:15 +0000 (17:17 +0200)]
Fix T65632: Connected Proportional Editing is affected by Curve Object's Local Scale

Make curve vertex distance take into account the object scale.

2 months agoEevee: Fix Contact shadows with Translucent BSDF
Clément Foucault [Fri, 14 Jun 2019 13:19:28 +0000 (15:19 +0200)]
Eevee: Fix Contact shadows with Translucent BSDF

2 months agoFix T65647 EEVEE: Contact shadows "Softness" settings darkens objects
Clément Foucault [Fri, 14 Jun 2019 13:18:35 +0000 (15:18 +0200)]
Fix T65647 EEVEE: Contact shadows "Softness" settings darkens objects

This was commited by mistake.

2 months agoFix T65803: MPEG4 unsupported timebase denominator
Sybren A. Stüvel [Fri, 14 Jun 2019 11:36:05 +0000 (13:36 +0200)]
Fix T65803: MPEG4 unsupported timebase denominator

- MPEG4/DivX has a maximum value of 65535 for the timebase denominator.
- MPEG1 and 2 have a list of supported frame rate ratios. These use
  ratios like 24000/1001 and need those exact numbers.

This fixes an issue introduced in c5b1e7cd4e86f9aff010fa84192d783b895ce6c7
where the correct ratio was passed to FFmpeg, but not with the identical
numbers FFmpeg has in a lookup table.

2 months agoFix T65763: Reset GPU when exporting annotations
Jeroen Bakker [Fri, 14 Jun 2019 08:49:05 +0000 (10:49 +0200)]
Fix T65763: Reset GPU when exporting annotations

When exporting annotations using `bpy.ops.render.opengl` the annotations
where only correct in the first frame. In the second frame the
annotations was shifted by half the resolution.

This change will reset the GPU matrices when the annotations are

2 months agoPartial revert of "Theme: Blender Light update"
Campbell Barton [Fri, 14 Jun 2019 05:15:07 +0000 (15:15 +1000)]
Partial revert of "Theme: Blender Light update"

Partially reverts commit 3b58bf3c7ebc1c6aaea98678ea4d462d9191007a

Green highlights aren't as bright as yellow/orange & were
reverted for the default theme, do the same for the light theme.

2 months agoTheme: Update Blender Light
Campbell Barton [Fri, 14 Jun 2019 04:49:49 +0000 (14:49 +1000)]
Theme: Update Blender Light

2 months agoCleanup: remove developer panel
Campbell Barton [Fri, 14 Jun 2019 03:55:27 +0000 (13:55 +1000)]
Cleanup: remove developer panel

Defined whole panel for a single checkbox which is hidden by default.

2 months agoMesh Selection: Move Selection ID Context Utilities to ED_view3d.
mano-wii [Fri, 14 Jun 2019 02:40:49 +0000 (23:40 -0300)]
Mesh Selection: Move Selection ID Context Utilities to ED_view3d.

This patch does not bring functional changes, but it is a good change if we want to use these utilities in areas other than those using BMesh (eg painting editors).

This is also a step to replace `ED_view3d_select_id_validate`. That function erroneously checks `V3D_INVALID_BACKBUF` which causes it to update unnecessarily.

Reviewers: campbellbarton

Differential Revision:

2 months agoDocs: minor improvements to --app-template help text
Campbell Barton [Fri, 14 Jun 2019 02:59:14 +0000 (12:59 +1000)]
Docs: minor improvements to --app-template help text

2 months agoCleanup: sort structs
Campbell Barton [Fri, 14 Jun 2019 00:12:10 +0000 (10:12 +1000)]
Cleanup: sort structs

2 months agoCleanup: minor adjustments to --help text formatting
Campbell Barton [Thu, 13 Jun 2019 23:50:13 +0000 (09:50 +1000)]
Cleanup: minor adjustments to --help text formatting

- Single quote args so they show with string literals in the manual.
- Improve the description of animation playback mode.

2 months agoFix T61768 Eevee Offscreen rendering
Clément Foucault [Thu, 13 Jun 2019 19:31:46 +0000 (21:31 +0200)]
Fix T61768 Eevee Offscreen rendering

The issue was caused by a bad usage of GPUOffscreen.

The Framebuffer was created using a window framebuffer and used
in a viewport callback when another GPUContext was bound.

This change allows up to 3 framebuffers per GPUOffscreen.

Most common case will be using 2 framebuffers (one for init and
one for drawing) but in the case of more (bad usage) it will just
degrade performance a bit.

2 months agoFix T65783: Gpencil Edit mode doesn't round data icon
Antonioya [Thu, 13 Jun 2019 18:38:31 +0000 (20:38 +0200)]
Fix T65783: Gpencil Edit mode doesn't round data icon

See D5071 for more details

Thanks to @brecht for his help

2 months agoFix T59275: generated texture coordinates don't stick to mesh for shape keys
Brecht Van Lommel [Thu, 13 Jun 2019 18:22:10 +0000 (20:22 +0200)]
Fix T59275: generated texture coordinates don't stick to mesh for shape keys

No need for this optimization in Eevee anymore, instead the modifier stack will
only compute CD_ORCO when needed.

2 months agoFix part of T63595: generated texture coordinates don't stick to deforming mesh
Brecht Van Lommel [Thu, 13 Jun 2019 17:56:25 +0000 (19:56 +0200)]
Fix part of T63595: generated texture coordinates don't stick to deforming mesh

Always compute CD_ORCO undeformed coordinates now for rendering, same as before.
There is still a refresh issue to be fixed, when switching from solid to textured
mode in the viewport.

Computing such undeformed coordinates can be expensive and is not actually needed
if the mesh is only using e.g. UV maps. This was the same in 2.79, at least now we
are skipping the computation when there are no deforming mdifiers on the mesh.

2 months agoMesh: don't compute CD_ORCO layer when there are no deforming modifiers
Brecht Van Lommel [Mon, 10 Jun 2019 13:42:15 +0000 (15:42 +0200)]
Mesh: don't compute CD_ORCO layer when there are no deforming modifiers

This saves memory and evaluation time for simple static meshes with e.g. a
subdivision surface modifier. If no CD_ORCO layer exists then we assume the
actual vertex coordinates are equal to the original undeformed coordinates.

2 months agoT65783: UI Inconsistency with Grease Pencil icons in Properties and Outliner
Antonioya [Thu, 13 Jun 2019 17:19:57 +0000 (19:19 +0200)]
T65783: UI Inconsistency with Grease Pencil icons in Properties and Outliner

Fixed Properties and tab icons

2 months agoFix T65669 Bones in Envelope Display break apart after selecting bone
Clément Foucault [Tue, 11 Jun 2019 21:35:35 +0000 (23:35 +0200)]
Fix T65669 Bones in Envelope Display break apart after selecting bone

This was because the VAOs were not updated if an instance batch was
reusing a VBO containing instances attributes which was reinitialized.

Now we ensure the Batch will reconfigure the VAOs if the VBO is 0.

2 months agoFix T65109: Object deleted when removed from the RigidBodyWorld collection.
Bastien Montagne [Thu, 13 Jun 2019 15:57:55 +0000 (17:57 +0200)]
Fix T65109: Object deleted when removed from the RigidBodyWorld collection.

While user should never do that, it appears many end up using a 'view
layer' instancing collection as RBW collection, and even worse, have
objects in that unique collection.

Therefore, when removing RB simulation from an object, which among other
things has to remove it from the RBW collection, it would fully delete
the object from the blend file.

This fix merely checks the usercount of RB-removed object, and if it is
at 1 (which means object was in a single collection), it adds it to the
scene's master collection first.

2 months agoFix T65445: wrong defaults when appending workspaces from builtin templates
Brecht Van Lommel [Thu, 13 Jun 2019 14:33:01 +0000 (16:33 +0200)]
Fix T65445: wrong defaults when appending workspaces from builtin templates

2 months agoDefaults: refactor startup.blend code, more consistely apply to templates
Brecht Van Lommel [Thu, 13 Jun 2019 15:40:04 +0000 (17:40 +0200)]
Defaults: refactor startup.blend code, more consistely apply to templates

There were various changes only applied to specific builtin templates even
though they should apply to all, since it's possible to do e.g. use grease
pencil objects in the general template or use mesh sculpting in the grease
pencil template.

Also, nearly all changes now apply to builtin templates only. This was
already the case for most, and the distinction seems to have been more by
accident than intent.

2 months agoIndustry Compat keymap: Fix broken Tab key in the Text Editor
William Reynish [Thu, 13 Jun 2019 14:45:37 +0000 (16:45 +0200)]
Industry Compat keymap: Fix broken Tab key in the Text Editor

Was being used for operator search here, which doesn't make any sense

2 months agoFix: Sequencer timecodes was using wrong properties
William Reynish [Thu, 13 Jun 2019 13:54:45 +0000 (15:54 +0200)]
Fix: Sequencer timecodes was using wrong properties

  - The Start value and the Playhead value both used 'frame_start', which only tells you where the strip was originally inserted. Instead 'frame_final_start' is now used, which results in the correct timeline values.
  - When scaling the sidebar some of the the labels weren't scaling correctly, this has been fixed
  - Use Hold Cut/Cut instead of Hard/Soft Cut, for consistency

Patch by Peter Fog

Differential revision:

2 months agoFix "Fix Deform" not working in Blender 2.8
Sergey Sharybin [Thu, 13 Jun 2019 13:21:16 +0000 (15:21 +0200)]
Fix "Fix Deform" not working in Blender 2.8

Need to copy changes to the evaluated mesh before requesting
new deformed mesh.

Tested on a file from T32406.

2 months agoFix "Fix Deform" access evaluated data form original objects
Sergey Sharybin [Thu, 13 Jun 2019 13:08:45 +0000 (15:08 +0200)]
Fix "Fix Deform" access evaluated data form original objects

This is part of T60517.

2 months agoSet Node Editor to use Box Select tool by default
William Reynish [Thu, 13 Jun 2019 12:41:21 +0000 (14:41 +0200)]
Set Node Editor to use Box Select tool by default

This makes Shift and Ctrl work properly to extend and subtract selections.
This also moves Cut Links to Ctrl-RMB, which doesn't conflict with the selection tool.

2 months agoCleanup: clang-format
Antonioya [Thu, 13 Jun 2019 11:43:07 +0000 (13:43 +0200)]
Cleanup: clang-format

2 months agoGPencil: Reorganize blend shader
Antonioya [Thu, 13 Jun 2019 11:35:12 +0000 (13:35 +0200)]
GPencil: Reorganize blend shader

Reorganize code and change some functions to mimic other softwares blend modes. Still need more work.

2 months agoGPencil: Remove blend_opacity from shader
Antonioya [Wed, 12 Jun 2019 15:15:50 +0000 (17:15 +0200)]
GPencil: Remove blend_opacity from shader

The opacity was already used and using it in the shader only duplicate the blend.

2 months agoParticle system: Move runtime data to runtime field
Sergey Sharybin [Wed, 5 Jun 2019 10:39:40 +0000 (12:39 +0200)]
Particle system: Move runtime data to runtime field

Allows it to be preserved during copy-on-write update when on-geometry
related update is needed.

This is a required part for T63537, where we need to preserve the entire
evaluation data when object is tagged for only RECALC_COPY_ON_WRITE.

Reviewers: brecht

Reviewed By: brecht

Differential Revision:

2 months agoClear Datablocks Preview: add some more generic options.
Bastien Montagne [Thu, 13 Jun 2019 09:10:17 +0000 (11:10 +0200)]
Clear Datablocks Preview: add some more generic options.

Sometimes one may want to nuke all previews altogether, running the
operator for all eight individual ID types would be tedious then...

2 months agoFix T65034: Viewing material calls frame update handler
Sergey Sharybin [Wed, 12 Jun 2019 15:50:58 +0000 (17:50 +0200)]
Fix T65034: Viewing material calls frame update handler

Use lower level dependency graph evaluation which doesn't run any handlers,
doesn't touch sound system, doesn't inform image editors about changes.

Should probably move such evaluation steps to a helper function in DEG module,
but that is more like a cleanup.

Reviewers: brecht

Reviewed By: brecht

Differential Revision:

2 months agoCleanup: correct wireframe xray flag name
Campbell Barton [Thu, 13 Jun 2019 07:33:51 +0000 (17:33 +1000)]
Cleanup: correct wireframe xray flag name

Revert part of d56c0a0a6affcdfd7335c

2 months agoCleanup: clang-format
Campbell Barton [Thu, 13 Jun 2019 02:37:01 +0000 (12:37 +1000)]
Cleanup: clang-format

2 months agoCleanup: tweak logic for skipping modules
Campbell Barton [Thu, 13 Jun 2019 00:03:06 +0000 (10:03 +1000)]
Cleanup: tweak logic for skipping modules

Startup is the special case, so match against this instead of 'modules'.

2 months agoHide from UI overridable option for custom properties.
Bastien Montagne [Wed, 12 Jun 2019 17:59:29 +0000 (19:59 +0200)]
Hide from UI overridable option for custom properties.

2 months agoFix T57489: Texture coordinate object reference not updating in Eevee
Sergey Sharybin [Wed, 12 Jun 2019 14:57:56 +0000 (16:57 +0200)]
Fix T57489: Texture coordinate object reference not updating in Eevee

2 months agoGPencil: Fix clamp alpha problems when using Regular blend
Antonioya [Wed, 12 Jun 2019 14:55:24 +0000 (16:55 +0200)]
GPencil: Fix clamp alpha problems when using Regular blend

The problem was the alpha was not premult and the opacity factor was applied two times.

2 months agoTypos in description
Jeroen Bakker [Wed, 12 Jun 2019 14:26:58 +0000 (16:26 +0200)]
Typos in description

2 months agoCompositor: fix linear feather falloff in dilate/erode node
Jacques Lucke [Wed, 12 Jun 2019 13:52:09 +0000 (15:52 +0200)]
Compositor: fix linear feather falloff in dilate/erode node

The bug only affected debug builds.

2 months agoFix T65741: Removing a GPencil Object's Material Slot deletes the strokes assigned...
Antonioya [Wed, 12 Jun 2019 13:51:51 +0000 (15:51 +0200)]
Fix T65741: Removing a GPencil Object's Material Slot deletes the strokes assigned to it

This was a design decision, but now we have decided to change it using the active material for the strokes using deleted material.

If the material slot is empty a new material is created to keep the strokes visible.

2 months agoFix T64930: FFmpeg Output- no color mode by default
Sebastian Parborg [Wed, 12 Jun 2019 13:16:30 +0000 (15:16 +0200)]
Fix T64930: FFmpeg Output- no color mode by default

The issue was that the valid color modes was checked on the old image
format, not the new one. So if you switched formats it would not
correctly check if the settings were valid.

2 months agoTransform Snap: When snapping to curve's vertices, consider only the original elements.
mano-wii [Wed, 12 Jun 2019 12:48:15 +0000 (09:48 -0300)]
Transform Snap: When snapping to curve's vertices, consider only the original elements.

When they are occluded or when the snap is done for the generated meshes vertices, it was inconvenient.
An ideal solution needs to be discussed, but for now, for vertices, keep the behavior similar to the pre 2.8 versions.

2 months agoFix T65751: Mask Parenting does not work
Sergey Sharybin [Wed, 12 Jun 2019 12:02:57 +0000 (14:02 +0200)]
Fix T65751: Mask Parenting does not work

2 months agoFix T65750: Masking crash with Add Feather Vertex and Slide
Sergey Sharybin [Wed, 12 Jun 2019 10:47:01 +0000 (12:47 +0200)]
Fix T65750: Masking crash with Add Feather Vertex and Slide

2 months agoFix T64710: Rigid body stops simulating when an object is selected
Sergey Sharybin [Wed, 12 Jun 2019 10:11:49 +0000 (12:11 +0200)]
Fix T64710: Rigid body stops simulating when an object is selected

Need to preserve last evaluated time through copy-on-write process.

2 months agoWM: re-enable auto-save after loading the users preferences
Campbell Barton [Wed, 12 Jun 2019 07:53:18 +0000 (17:53 +1000)]
WM: re-enable auto-save after loading the users preferences

Minor change, only apples when loading factory settings,
then reverting to saved.

2 months agoCleanup: --help doc string formatting
Campbell Barton [Wed, 12 Jun 2019 06:59:03 +0000 (16:59 +1000)]
Cleanup: --help doc string formatting

STRINGIFY macro was being split across lines
causing problems extracting the strings for the references manual.

2 months agoUnit System: remove 'm' as an alternate name for mile
Campbell Barton [Wed, 12 Jun 2019 04:20:59 +0000 (14:20 +1000)]
Unit System: remove 'm' as an alternate name for mile

Now when using imperial dimensions,
using 'm' suffix is treated as meters instead of miles
(use 'mi' or 'mile' instead).

Resolves T65731

2 months agoRevert "Keymap: Add additional scrubbing affordance (Alt-LMB)"
Campbell Barton [Wed, 12 Jun 2019 03:46:30 +0000 (13:46 +1000)]
Revert "Keymap: Add additional scrubbing affordance (Alt-LMB)"

This reverts commits

It wasn't possible to set the cursor without accidentally selecting a
column of keys & (vice-versa).
This conflicts with Alt->LMB to select column of keys.

Shift-RMB is already bound to scrubbing.

2 months agoFix T65727: Broken button tool-tips in 3D view
Campbell Barton [Wed, 12 Jun 2019 02:57:20 +0000 (12:57 +1000)]
Fix T65727: Broken button tool-tips in 3D view

Own error in 686820289982.

2 months agoUI: alternate fix for T65702, handling of auto-saving userprefs
Campbell Barton [Wed, 12 Jun 2019 02:21:21 +0000 (12:21 +1000)]
UI: alternate fix for T65702, handling of auto-saving userprefs

The behavior for loading factory settings wasn't clear for users.

This commit changes the behavior:

- Loading factory settings always disables auto-save
  for the current session.
- The internal setting to skip saving on exit is now exposed
  in the preferences (when enabled).
- The menu item "Load Factory Settings (Temporary)" has been removed
  since it's always temporary.

This way users can always reset factory settings without
having to consider the combination of options that might cause their
preferences to be overwritten at exit.

If they want to enable auto-save for the current session
this can be done from the preferences.

2 months agoWM: optionally override the context with a module for wm.context_toggle
Campbell Barton [Wed, 12 Jun 2019 02:17:50 +0000 (12:17 +1000)]
WM: optionally override the context with a module for wm.context_toggle

This may be used with other wm.context_* operators in the future.

2 months agoCleanup: expand left/right select keymap items
Campbell Barton [Wed, 12 Jun 2019 01:11:39 +0000 (11:11 +1000)]
Cleanup: expand left/right select keymap items

This was meant to simplify the keymap but ended up
not having a significant advantage.

2 months agoKeymap: Add Ctrl-SelectMouse in to box-deselect
Campbell Barton [Wed, 12 Jun 2019 00:42:57 +0000 (10:42 +1000)]
Keymap: Add Ctrl-SelectMouse in to box-deselect

2 months agoCleanup: spelling in comments
Campbell Barton [Tue, 11 Jun 2019 23:04:10 +0000 (09:04 +1000)]
Cleanup: spelling in comments

2 months agoCleanup: clang-format
Campbell Barton [Tue, 11 Jun 2019 22:17:40 +0000 (08:17 +1000)]
Cleanup: clang-format

2 months agoCleanup: unused vars
Campbell Barton [Tue, 11 Jun 2019 22:16:58 +0000 (08:16 +1000)]
Cleanup: unused vars

2 months agoView3D Snap: Don't mix original/evaluated in the same function parameters.
mano-wii [Tue, 11 Jun 2019 21:45:46 +0000 (18:45 -0300)]
View3D Snap: Don't mix original/evaluated in the same function parameters.

2 months agoFix T64478: Wrong location Snap Selection to Cursor after set camera Follow the path.
mano-wii [Tue, 11 Jun 2019 21:12:14 +0000 (18:12 -0300)]
Fix T64478: Wrong location Snap Selection to Cursor after set camera Follow the path.

In this case it is necessary to use the `object->parent` evaluated to obtain the correct `parentmat`.

2 months agoFix/Cleanup: I18N: Bad usage of IFACE_ instead of TIP_.
Bastien Montagne [Tue, 11 Jun 2019 20:25:01 +0000 (22:25 +0200)]
Fix/Cleanup: I18N: Bad usage of IFACE_ instead of TIP_.

Cheap tip: anything that is not "Camel Case" and/or that is more than
a few words long should use `TIP_` translation, not `IFACE_` one.

Also added several missing strings (including the one reported in D5056
by Jean First (@robbott), thanks).

2 months agoCleanup: remove unused var.
Bastien Montagne [Tue, 11 Jun 2019 19:16:36 +0000 (21:16 +0200)]
Cleanup: remove unused var.

2 months agoFix T64430: Removing objects from sub-collection doesn't update instances of parent...
Bastien Montagne [Tue, 11 Jun 2019 19:13:37 +0000 (21:13 +0200)]
Fix T64430: Removing objects from sub-collection doesn't update instances of parent collection.

Collections are a tad annoying with all their caching of objects... When
we modify content of a children collection, we need to tag DeG for CoW
update of all of the ancestors.

For now keeping that recursive tagging helper private, but would not be
surprised if we found more similar cases and needed to expose it to more

2 months agoFix (unreported) message wrongly using IFACE_ for its translation.
Bastien Montagne [Tue, 11 Jun 2019 18:54:43 +0000 (20:54 +0200)]
Fix (unreported) message wrongly using IFACE_ for its translation.

`IFACE_` is for short strings always shown in UI (like labels of buttons,
menu entries...). Every thing else, especially when more than a couple
of words, must use `TIP_`.

2 months agoFix T64608: DOF Focus object, not linked to new copy, Scen "full_copy".
Bastien Montagne [Tue, 11 Jun 2019 18:48:52 +0000 (20:48 +0200)]
Fix T64608: DOF Focus object, not linked to new copy, Scen "full_copy".

Note that there are probably many other similar cases... This code is
really legacy, should use library_query helpers and other modern
BKE_library code instead of doing its own dirty cooking...

2 months agoEdit Mode: Fix face alpha being too strong in xray mode
Clément Foucault [Tue, 11 Jun 2019 15:48:06 +0000 (17:48 +0200)]
Edit Mode: Fix face alpha being too strong in xray mode

This make the xray & wireframe follows the same style as the solid

2 months agoFix T65406 Edit Mode: Edge selection is below wireframe overlay
Clément Foucault [Tue, 11 Jun 2019 15:29:31 +0000 (17:29 +0200)]
Fix T65406 Edit Mode: Edge selection is below wireframe overlay

This was due to a double offset of the wireframe. We also reduce
the wireframe offset. The look of the wireframe overlay changes
a little with on distant wires.

2 months agoFFmpeg: Fix integer overflow when writing custom FPS with high denominator
Sybren A. Stüvel [Tue, 11 Jun 2019 13:51:39 +0000 (15:51 +0200)]
FFmpeg: Fix integer overflow when writing custom FPS with high denominator

FFmpeg uses a fraction of integers to indicate the frame rate, whereas
Blender uses `int / float`. When a custom frame rate is used with
non-integer base, the FPS and Base settings were multiplied with 100000
before passing to FFmpeg as `int`. This could overflow when a high
enough FPS setting was used, which is the case when importing a video of
almost-but-not-quite-integer frame rate into the VSE. The overflow
caused FFmpeg to return an error "The encoder timebase is not set",
which is rather cryptic for users.

The new solution is to take the max int and divide that by the frame
rate, and use that ratio to pass to FFmpeg. This won't overflow, and
thus allows exporting arbitrary frame rates.

2 months agoOpenGL Render: Fix crash when using audio
Sergey Sharybin [Tue, 11 Jun 2019 13:40:03 +0000 (15:40 +0200)]
OpenGL Render: Fix crash when using audio

Was very easy to reproduce by rendering sequencer with sound strip.

Need to use evaluated scene to open movie handle, since that is the only
scene which has proper sound handle with everything else attached to it.

2 months agoSound: Fix missing sound sequences length update on FPS change
Sergey Sharybin [Tue, 11 Jun 2019 13:19:32 +0000 (15:19 +0200)]
Sound: Fix missing sound sequences length update on FPS change

2 months agoSound: Fix queries of sound info
Sergey Sharybin [Tue, 11 Jun 2019 08:55:13 +0000 (10:55 +0200)]
Sound: Fix queries of sound info

A lot of areas were querying sound information directly using audio handle
which does not exist on an original sound IDs.

This change basically makes it so it's possible to query information about
given sound ID, without worrying about whether it's loaded or not: if it is
needed to load it first it happens automatically (no automatically-opened
handles are left behind though).

While this seems a bit extreme to open files on such queries it is still
better than the old situation when all sound handles were opened on file
load, no matter if it's needed or not. Besides, none of the changed code
paths are performance critical, just handful of tools.

Fixes T65696: Sequencer fails to create a new sound sequence strip via Python
Fixes T65656: Audio strip - SHIFT K crashes Blender

Reviewers: brecht

Reviewed By: brecht

Subscribers: ISS

Maniphest Tasks: T65696, T65656

Differential Revision:

2 months agoFix T65671: Armature X-Mirror inconsistencies
mano-wii [Tue, 11 Jun 2019 12:41:18 +0000 (09:41 -0300)]
Fix T65671: Armature X-Mirror inconsistencies

Apparently the `rna_Armature_editbone_transform_update` function was incomplete because it didn't copy all mirrored transform values.

I also noticed that the same logic seen in `rna_Armature_editbone_transform_update` is also seen in `ED_armature_edit_transform_mirror_update`.
So the solution is expose and use that logic that updates a mirrored bone. Thus deduplicating and fixing T65671.

Reviewers: brecht, zeddb

Differential Revision:

2 months agoDocumentation: Update description with documentation
Jeroen Bakker [Tue, 11 Jun 2019 12:27:18 +0000 (14:27 +0200)]
Documentation: Update description with documentation

2 months agofix T65576 collada exporter duplicates node tree when exported material already uses...
Gaia Clary [Tue, 11 Jun 2019 11:56:31 +0000 (13:56 +0200)]
fix T65576 collada exporter duplicates node tree when exported material already uses nodes

2 months agoFix T65702: Load factory erases setting without confirmation
Campbell Barton [Tue, 11 Jun 2019 11:49:05 +0000 (21:49 +1000)]
Fix T65702: Load factory erases setting without confirmation

It could be argued this was correct behavior, since auto-save
defaults to 'on' nevertheless, auto-saving settings once
the user has disabled auto-save can lead to accidents.

Don't reset the preferences flag when resetting preferences.

2 months agoFix T65715: Instant crash when grouping strips in VSE
Sergey Sharybin [Tue, 11 Jun 2019 11:22:59 +0000 (13:22 +0200)]
Fix T65715: Instant crash when grouping strips in VSE

2 months agoFix T65626: Use Nodes checkbox locks after being checked with "insert keyframe"
Sergey Sharybin [Tue, 11 Jun 2019 09:56:30 +0000 (11:56 +0200)]
Fix T65626: Use Nodes checkbox locks after being checked with "insert keyframe"

Not sure if this is something what is supported by render pipeline, but this report
discovered some actual error in logic.

2 months agoSequencer: Fix missing relations and recalc tags in RNA
Sergey Sharybin [Tue, 11 Jun 2019 09:18:47 +0000 (11:18 +0200)]
Sequencer: Fix missing relations and recalc tags in RNA

2 months agoFix T65677: Creating a scene sequencer strip with python crash blender
Sergey Sharybin [Tue, 11 Jun 2019 09:15:52 +0000 (11:15 +0200)]
Fix T65677: Creating a scene sequencer strip with python crash blender

2 months agoFix extend being ignored for left/right sequencer selection
Campbell Barton [Tue, 11 Jun 2019 08:11:35 +0000 (18:11 +1000)]
Fix extend being ignored for left/right sequencer selection

2 months agoKeymap: fix conflict introduced by recent Alt-LMB for scrubbing
Campbell Barton [Tue, 11 Jun 2019 07:44:30 +0000 (17:44 +1000)]
Keymap: fix conflict introduced by recent Alt-LMB for scrubbing

Use Ctrl-Alt modifier for select-left/right.

2 months agoFix T65393: Error live editing UI scripts
Campbell Barton [Tue, 11 Jun 2019 06:08:32 +0000 (16:08 +1000)]
Fix T65393: Error live editing UI scripts

Disable relative imports for UI scripts.

2 months agoFix panel-type re-registration with parents
Campbell Barton [Tue, 11 Jun 2019 06:01:19 +0000 (16:01 +1000)]
Fix panel-type re-registration with parents

The order of panel types changes when re-registering existing types.
Fixes an error exposed by T65393.

2 months agoFix T65470: Scale set to zero after extrude
Campbell Barton [Tue, 11 Jun 2019 03:27:10 +0000 (13:27 +1000)]
Fix T65470: Scale set to zero after extrude

2 months agoFix gpencil weight paint mode having no active tool
Campbell Barton [Tue, 11 Jun 2019 02:28:40 +0000 (12:28 +1000)]
Fix gpencil weight paint mode having no active tool

2 months agoFix T62875: Tooltips behave erratically with view gizmos
Campbell Barton [Tue, 11 Jun 2019 01:43:48 +0000 (11:43 +1000)]
Fix T62875: Tooltips behave erratically with view gizmos

Improvements to behavior for gizmo tool-tips.

- 2D gizmos no longer cancel tool-tips on cursor motion
  (matching the behavior of UI widgets).

- 3D gizmos still close on motion since 3D gizmos may have a large
  on-screen area which would cause them to stay visible even after the
  cursor has been moved a large distance. The motion threshold is used
  so they don't close on unintended cursor motion.

- Changing highlighted gizmo now cancels the tool-tip & resets the timer.

2 months agoFix T65699: gpencil weight paint unresponsive
Campbell Barton [Mon, 10 Jun 2019 23:20:33 +0000 (09:20 +1000)]
Fix T65699: gpencil weight paint unresponsive

2 months agoFix T65295: Convert curve to mesh fails with Keep Original.
Bastien Montagne [Mon, 10 Jun 2019 09:06:16 +0000 (11:06 +0200)]
Fix T65295: Convert curve to mesh fails with Keep Original.

This code now expects to wrok from fully evaluated data, however when we
keep original, we are actually working from data just copied from orig

Ideally, we'd do a single depsgraph update/eval *after* we have created
all new required data, but that is tricky to do properly in that code
without risking breaking one thing or another.

So for now, just going for the simple, if not optimal solution, and just
repeatedly re-evaluating whole deg every time we duplicate an object to
be converted. Yep, dummy, but simple and... safe. ;)