2 years agoFix T55462: Ungroup in Node editor crash Blender
Sergey Sharybin [Fri, 25 Jan 2019 15:49:40 +0000 (16:49 +0100)]
Fix T55462: Ungroup in Node editor crash Blender

If ID doesn't want to do user counting it shouldn't be in main.

2 years agoFix T60775: Stereo drawing in image editor broken (shows only right eye)
Dalai Felinto [Fri, 25 Jan 2019 14:58:31 +0000 (12:58 -0200)]
Fix T60775: Stereo drawing in image editor broken (shows only right eye)

2 years agoUI: Particles
Pablo Vazquez [Fri, 25 Jan 2019 14:30:04 +0000 (15:30 +0100)]
UI: Particles

Dupli Collection -> Instance Collection

2 years agoUI: Particles. Open render type panels by default
Pablo Vazquez [Fri, 25 Jan 2019 14:29:22 +0000 (15:29 +0100)]
UI: Particles. Open render type panels by default

Render-type panels are only shown when the relevant type is active anyway.
Saves a click especially when using object or collection as render, since
you _have_ to set an object or collection to use it.

2 years agoUI: Particle. Remove unnecessary label for grid distribution
Pablo Vazquez [Fri, 25 Jan 2019 14:18:03 +0000 (15:18 +0100)]
UI: Particle. Remove unnecessary label for grid distribution

None of the other distribution modes have labels, and it's pretty clear
anyway since the fields below have the Grid word in them.

2 years agoUI: Particles
Pablo Vazquez [Fri, 25 Jan 2019 14:16:49 +0000 (15:16 +0100)]
UI: Particles

Remove duplicate "Use Modifier Stack"

2 years agoFix T60204: Crash when opening a File
Sergey Sharybin [Fri, 25 Jan 2019 14:18:32 +0000 (15:18 +0100)]
Fix T60204: Crash when opening a File

Missing code from 3d083f37. Need to ensure that ID properties
are properly allocated and restored on read.

2 years agoWorkbench: Depth Of Field: Optimisation
Clément Foucault [Thu, 24 Jan 2019 21:01:03 +0000 (22:01 +0100)]
Workbench: Depth Of Field: Optimisation

- Compute samples positions on CPU.
- Use 3x3 Box blur instead of 2x2.
- Implement bokeh parameters.

With this commit, dof performance is almost negligeable.
The quality is a bit lower than before but can be improve. Also now big
Circle of confusion are supported (up to 200px).
Cost is ~1.25ms on AMD Vega with a 2560p viewport than full HD and
pretty shallow depth of field.

Coc downsampling and dilation is not used anymore for now (commented).

2 years agoWorkbench: Depth Of Field: Initial Commit
Clément Foucault [Thu, 24 Jan 2019 16:28:51 +0000 (17:28 +0100)]
Workbench: Depth Of Field: Initial Commit

The algorithm used is borrowed from :

This makes it possible to have a decent blur for foreground over defocused
background in one pass only.

The algorithm is using a gather approach that is much faster
than the scatter approach used in Eevee. This makes it possible to have
custom bokeh shapes (not implemented yet) which would be impossible with
a separable gaussian technique.

The blur is done in 2 steps. The first one define the shape of the bokeh
and the second that fill the undersampling.

A downsample max-CoC tile texture speed up the gathering process.

2 years agoT60745: GPU texture alloc failed when opening Preference Windows
Clément Foucault [Tue, 22 Jan 2019 15:30:17 +0000 (16:30 +0100)]
T60745: GPU texture alloc failed when opening Preference Windows

Was generating INVALID_FRAMEBUFFER here instead of failled texture alloc.

Add safety asserts in gpu_texture.c and clamp minimum size to 1 inside

2 years agoGP: Use Fill color when drawing strokes for no stroke materials
Antonioya [Fri, 25 Jan 2019 13:34:56 +0000 (14:34 +0100)]
GP: Use Fill color when drawing strokes for no stroke materials

Artists requested to show the stroke while drawing a new stroke using a material with fill color only, because it's very difficult to see the stroke.

Now the stroke shows always but using the fill color, not the stroke color because maybe is not set.

2 years agoFix crash happening with hair step
Sergey Sharybin [Fri, 25 Jan 2019 12:58:42 +0000 (13:58 +0100)]
Fix crash happening with hair step

The issue was caused by the hair step checking whether
particle system needs to have path cache. This was done
in a way which was traversing an entire scene and was
checking every object for particle instance modifier.

Ideally, path cache should be an own operation in the
dependency graph. Or at least, this flag should be set
by dependency graph builder, similar to curve's path.

Since the code was broken already (it was only checking
first particle instance modifier), it is easier to
remove the buggy code, solve the crash and move on for

If this causes an issue, simply set particle system to
be rendered as path.

Fixes crash with playback of Spring scenes.

2 years agoFix texture paint accessing freed memory
Campbell Barton [Fri, 25 Jan 2019 12:49:21 +0000 (23:49 +1100)]
Fix texture paint accessing freed memory

Part of T60660

2 years agoCorrect last commit, wire xray is supported
Campbell Barton [Fri, 25 Jan 2019 12:36:31 +0000 (23:36 +1100)]
Correct last commit, wire xray is supported

2 years agoDRW: disable clipping background drawing w/ xray mode
Campbell Barton [Fri, 25 Jan 2019 12:24:34 +0000 (23:24 +1100)]
DRW: disable clipping background drawing w/ xray mode

This interfered with drawing the mesh.

2 years agoDepsgraph: use specific tag to update shading
Campbell Barton [Fri, 25 Jan 2019 12:11:58 +0000 (23:11 +1100)]
Depsgraph: use specific tag to update shading

2 years agoFix T59958: Blender 2.80 - Removing second Particle System cache causes crash.
Bastien Montagne [Fri, 25 Jan 2019 11:31:24 +0000 (12:31 +0100)]
Fix T59958: Blender 2.80 - Removing second Particle System cache causes crash.

Usual DEG tag missing.

Also do not tag/send notifiers when we do not change anything!

2 years agoFix T60839: Deleting bevel object for curve will not update
Sergey Sharybin [Fri, 25 Jan 2019 10:22:22 +0000 (11:22 +0100)]
Fix T60839: Deleting bevel object for curve will not update

Was missing conversion of ID_RECALC_GEOEMTRY to curve's operation.

2 years agoT60748 Second try to fix start extreme in Noise modifier
Antonioya [Fri, 25 Jan 2019 09:44:46 +0000 (10:44 +0100)]
T60748 Second try to fix start extreme in Noise modifier

The first point was moving inverted because first vector was inverted. Now, the vector is changed for the first point to get the same direction.

2 years agoFix texture paint showing pink texture on load
Campbell Barton [Fri, 25 Jan 2019 06:09:12 +0000 (17:09 +1100)]
Fix texture paint showing pink texture on load

2 years agoFix UI extension removal
Campbell Barton [Fri, 25 Jan 2019 02:45:56 +0000 (13:45 +1100)]
Fix UI extension removal

App-templates & keymap names had their extensions removed twice.

Confusing for filenames containing dots.

2 years agoFix T60777: Grid fill fails when run via Repeat Last
Campbell Barton [Fri, 25 Jan 2019 00:37:37 +0000 (11:37 +1100)]
Fix T60777: Grid fill fails when run via Repeat Last

2 years agoWM: don't set repeat flag w/ interactive repeat
Campbell Barton [Fri, 25 Jan 2019 00:29:41 +0000 (11:29 +1100)]
WM: don't set repeat flag w/ interactive repeat

This allows operators to distinguish between redo and executing
repeat last operator, needed for T60777 fix.

2 years agoRevert "WM: Repeat Last no longer reuses skip-save properties"
Campbell Barton [Fri, 25 Jan 2019 00:10:55 +0000 (11:10 +1100)]
Revert "WM: Repeat Last no longer reuses skip-save properties"

This reverts commit 1d908bffddb4c9815a986305ad4588032b81deee.

Enough uses of repeat last expect skip-save properties to be set,
transform being the most obvious example T60777#605681.

I wanted to avoid operators having account for two kinds of 'skip-save'
but this may be unavoidable.

2 years agoMissed last commit
Campbell Barton [Fri, 25 Jan 2019 00:04:00 +0000 (11:04 +1100)]
Missed last commit

2 years agoCleanup: replace VSE /w Sequencer
Campbell Barton [Thu, 24 Jan 2019 22:42:03 +0000 (09:42 +1100)]
Cleanup: replace VSE /w Sequencer

This abbreviation isn't used anywhere else in Blender's UI.

2 years agomake.bat: remove stray quote in msvc2017 detection.
Ray Molenkamp [Thu, 24 Jan 2019 22:21:31 +0000 (15:21 -0700)]
make.bat: remove stray quote in msvc2017 detection.

Shouldn't cause issues, but better safe than sorry.

2 years agoMerge branch 'blender2.7'
Campbell Barton [Thu, 24 Jan 2019 21:54:20 +0000 (08:54 +1100)]
Merge branch 'blender2.7'

2 years agoCleanup: sort cmake file lists
Campbell Barton [Thu, 24 Jan 2019 21:30:33 +0000 (08:30 +1100)]
Cleanup: sort cmake file lists

2 years agoCleanup: sort cmake file lists
Campbell Barton [Thu, 24 Jan 2019 21:30:33 +0000 (08:30 +1100)]
Cleanup: sort cmake file lists

2 years agoCleanup: remove duplicated shaders that only added clipping checks
Campbell Barton [Thu, 24 Jan 2019 21:01:07 +0000 (08:01 +1100)]
Cleanup: remove duplicated shaders that only added clipping checks

Originally I wanted to avoid adding draw manager specific ifdef's all
over generic shaders however this isn't needed in so many places.

Also there are shaders that are only used by the draw manager so
duplicating them only to have the original unused doesn't make sense.

2 years agoDRW: support clipping for camera objects
Campbell Barton [Thu, 24 Jan 2019 20:13:02 +0000 (07:13 +1100)]
DRW: support clipping for camera objects

2 years agoCleanup: add missing braces to draw manager
Campbell Barton [Thu, 24 Jan 2019 20:10:13 +0000 (07:10 +1100)]
Cleanup: add missing braces to draw manager

2 years agoCleanup: use macro to set flags
Campbell Barton [Thu, 24 Jan 2019 13:34:36 +0000 (00:34 +1100)]
Cleanup: use macro to set flags

2 years agoFix smoke clipping being ignored by Cycles and not being editable after baking.
Brecht Van Lommel [Thu, 24 Jan 2019 18:44:43 +0000 (19:44 +0100)]
Fix smoke clipping being ignored by Cycles and not being editable after baking.

The value worked in 2.7, but not with copy-on-write in 2.8.

2 years agoFix T59650: adding texture paint slot image shows wrong color.
Brecht Van Lommel [Thu, 24 Jan 2019 18:05:45 +0000 (19:05 +0100)]
Fix T59650: adding texture paint slot image shows wrong color.

2 years agoMerge branch 'blender2.7'
Brecht Van Lommel [Thu, 24 Jan 2019 18:02:10 +0000 (19:02 +0100)]
Merge branch 'blender2.7'

2 years agoFix T60597, T60806: Cycles crash rendering principled BSDF + volume interior.
Brecht Van Lommel [Thu, 24 Jan 2019 14:15:57 +0000 (15:15 +0100)]
Fix T60597, T60806: Cycles crash rendering principled BSDF + volume interior.

The integrator maximum number of closures was not set properly for the CPU/mega
kernels to match the actual available memory. Before relatively recent code
refactoring we did not use this value in those kernels so it worked fine.

2 years agoFix T60350: Removed objects that are still in the outliner will crash Blender.
Bastien Montagne [Thu, 24 Jan 2019 16:44:13 +0000 (17:44 +0100)]
Fix T60350: Removed objects that are still in the outliner will crash Blender.

We need to force UI to fully redraw, BKE_id_delete & co won't do that
for us.

2 years agoCleanup: remove unused "guide_origin" property
Jacques Lucke [Thu, 24 Jan 2019 16:39:14 +0000 (17:39 +0100)]
Cleanup: remove unused "guide_origin" property

2 years agoFix T60816: Specify subtype for some properties of mesh operators
Jacques Lucke [Thu, 24 Jan 2019 16:38:05 +0000 (17:38 +0100)]
Fix T60816: Specify subtype for some properties of mesh operators

Reviewers: brecht

Differential Revision:

2 years agobring back possibility to override camera per view
Philipp Oeser [Thu, 24 Jan 2019 16:20:04 +0000 (17:20 +0100)]
bring back possibility to override camera per view

this can now be found in the sidebar View panel

- uses existing 'lock_camera_and_layers' but renames the property to
- uses RNA_def_property_boolean_negative_sdna to flip the value
- remove the local view code in
- update Python code
- update Addons code will be separate commit

Fixes T60756

Reviewers: billreynish, brecht

Maniphest Tasks: T60756

Differential Revision:

2 years agoFix T60095: freestyle not rendering animated camera correctly.
Brecht Van Lommel [Thu, 24 Jan 2019 15:34:26 +0000 (16:34 +0100)]
Fix T60095: freestyle not rendering animated camera correctly.

Replace legacy view matrix access with same one used by Eevee.

2 years agoFix freestyle renders not including some types of animation.
Brecht Van Lommel [Thu, 24 Jan 2019 06:08:19 +0000 (07:08 +0100)]
Fix freestyle renders not including some types of animation.

Freestyle Python scripts need to get the evaluated view layer and scene,
not the original one.

2 years agoFix T60625: freestyle colletion include / exclude not working.
Brecht Van Lommel [Thu, 24 Jan 2019 15:08:03 +0000 (16:08 +0100)]
Fix T60625: freestyle colletion include / exclude not working.

2 years agoFix T60669: freestyle rendering holdout / indirect only collections.
Brecht Van Lommel [Thu, 24 Jan 2019 06:14:28 +0000 (07:14 +0100)]
Fix T60669: freestyle rendering holdout / indirect only collections.

To match Cycles we can hide freestyle lines for these.

2 years agoFix T59175: Compress file isn't working when Load UI is disabled.
Bastien Montagne [Thu, 24 Jan 2019 15:11:53 +0000 (16:11 +0100)]
Fix T59175: Compress file isn't working when Load UI is disabled.

Do not see why flags from loaded file should be skipped when we do not
load UI, this is not related to UI...

Think we can keep flags from file in both cases, should this raise some
other issue we'll just have to fine tune masked flags in each case

2 years agoFix GPU linking Error.
mano-wii [Thu, 24 Jan 2019 14:41:07 +0000 (12:41 -0200)]
Fix GPU linking Error.

"The geometry shader uses varying _I;gl_PerVertex;gl_ClipDistance, but previous shader does not write to it."

2 years agoMerge branch 'blender2.7'
Bastien Montagne [Thu, 24 Jan 2019 15:16:05 +0000 (16:16 +0100)]
Merge branch 'blender2.7'

2 years agoFix T59175: Compress file isn't working when Load UI is disabled.
Bastien Montagne [Thu, 24 Jan 2019 15:11:53 +0000 (16:11 +0100)]
Fix T59175: Compress file isn't working when Load UI is disabled.

Do not see why flags from loaded file should be skipped when we do not
load UI, this is not related to UI...

Think we can keep flags from file in both cases, should this raise some
other issue we'll just have to fine tune masked flags in each case

2 years agoMerge branch 'blender2.7'
Brecht Van Lommel [Thu, 24 Jan 2019 14:44:06 +0000 (15:44 +0100)]
Merge branch 'blender2.7'

2 years agoCycles: change default displacement method to bump mapping again.
Brecht Van Lommel [Thu, 24 Jan 2019 14:15:57 +0000 (15:15 +0100)]
Cycles: change default displacement method to bump mapping again.

Even though it makes sense logically to have displacement actually displace
the mesh, this is causing a lot of confusion for existing users that are used
to the previous behavior. Further, since Eevee does not support displacement
yet and the discrepancy between the viewport and final render is problematic.

2 years agoFix T60133: texture paint external editing not working
Philipp Oeser [Wed, 23 Jan 2019 14:00:58 +0000 (15:00 +0100)]
Fix T60133: texture paint external editing not working

Operator relys on 3DView and was failing from Topbar and Properties
Editor. Now tries to find the biggest 3DView and uses that.

Reviewers: brecht

Maniphest Tasks: T60133

Differential Revision:

2 years agoAnimation player: tweaks for zooming in and out
Sergey Sharybin [Thu, 24 Jan 2019 14:07:53 +0000 (15:07 +0100)]
Animation player: tweaks for zooming in and out

Use zoom steps lower than 1. This allows to zoom out a high-res
image. For example, before it was not possible to maker 4K image
to fit on FullHD monitor.

Also, don't force zoom to be above 1. Not sure why that was done,
but this disallows zooming out.

It is still not possible to zoom in higher than the window size
allows. In order to support this the player needs to be refactored
in a way that allows to decouple zoom from window size.

Fixes T59177: Animplayer extreme zooms in when playing rendered animation

2 years agoFix T59972: UV live unwrap does not pack islands.
Brecht Van Lommel [Thu, 24 Jan 2019 11:14:24 +0000 (12:14 +0100)]
Fix T59972: UV live unwrap does not pack islands.

Packing was not being called after multi-object editing changes. Includes code
refactoring to make function parameters more clear.

2 years agoFix T59933: timeline keyframe display not updating when selecting objects.
Brecht Van Lommel [Thu, 24 Jan 2019 13:48:45 +0000 (14:48 +0100)]
Fix T59933: timeline keyframe display not updating when selecting objects.

2 years agoFix T58502: scopes don't work in the image editor
Jacques Lucke [Thu, 24 Jan 2019 13:36:52 +0000 (14:36 +0100)]
Fix T58502: scopes don't work in the image editor

There were two problems:
1. The scopes were only updated when the "Scopes" category is active,
   but this category has been removed in Blender 2.8.
2. The scopes moved from the TOOLS to the UI region.
   However the update-code still searched for the "Scopes" category
   in the TOOLS region.

Both problems are fixed with this commit:
1. Scopes have there own category again.
2. The update code is in the correct draw function now.

Reviewers: brecht

Differential Revision:

2 years agoFix T60810: crash editing mesh with subdivision modifier
Philipp Oeser [Thu, 24 Jan 2019 09:24:19 +0000 (10:24 +0100)]
Fix T60810: crash editing mesh with subdivision modifier

typo in rBdc7e49298940

Reviewers: fclem

Maniphest Tasks: T60810

Differential Revision:

2 years agoFix T60795: Crash when joining objects with shape keys.
Bastien Montagne [Thu, 24 Jan 2019 13:31:47 +0000 (14:31 +0100)]
Fix T60795: Crash when joining objects with shape keys.

Stupid mistake really, cannot use NO_MAIN here, temp shapekey is in
Main. Using/fully supporting out-of-main temp IDs is still a bit WIP...

2 years agoMultires reshape: correct grids level allocation
Sergey Sharybin [Thu, 24 Jan 2019 13:23:14 +0000 (14:23 +0100)]
Multires reshape: correct grids level allocation

Similar to masking grids, need to also check existing grid level.

This is because edit mode might leave allocated grid with 0 levels.

2 years agoFix T59423: Mesh deform modifier bind bug causing spiky deformations.
mano-wii [Thu, 24 Jan 2019 12:32:28 +0000 (10:32 -0200)]
Fix T59423: Mesh deform modifier bind bug causing spiky deformations.

Same as rBac316a6526c7.
(I should have commited in 2.7 first and then merged in 2.8).

2 years agoFix T59423: Mesh deform modifier bind bug causing spiky deformations.
mano-wii [Thu, 24 Jan 2019 12:20:25 +0000 (10:20 -0200)]
Fix T59423: Mesh deform modifier bind bug causing spiky deformations.

The intersection was being tested between ray and tri, the correct one is segment and tri.

2 years agoFix T59145: don't clamp color value in Hue Saturation Value node in eevee
Jacques Lucke [Thu, 24 Jan 2019 12:58:59 +0000 (13:58 +0100)]
Fix T59145: don't clamp color value in Hue Saturation Value node in eevee

2 years agoFix T60807: Can't select when active pose object is hidden
Campbell Barton [Thu, 24 Jan 2019 12:06:29 +0000 (23:06 +1100)]
Fix T60807: Can't select when active pose object is hidden

Object mode locking wasn't accounting for the 3D view context
which doesn't have an active object once its hidden.

2 years agoCleanup: use braces for single line if statements
Campbell Barton [Thu, 24 Jan 2019 11:59:55 +0000 (22:59 +1100)]
Cleanup: use braces for single line if statements

2 years agoCleanup: Replace BASACT use w/ a variable
Campbell Barton [Thu, 24 Jan 2019 11:56:55 +0000 (22:56 +1100)]
Cleanup: Replace BASACT use w/ a variable

2 years agoCleanup: remove make wrapper
Campbell Barton [Thu, 24 Jan 2019 12:24:25 +0000 (23:24 +1100)]
Cleanup: remove make wrapper

Intended for silent build output,
ninja build system can do this now.

2 years agoCleanup: removed unused 3D view header template.
Brecht Van Lommel [Thu, 24 Jan 2019 12:19:23 +0000 (13:19 +0100)]
Cleanup: removed unused 3D view header template.

2 years agoFix T58216: backdrop drawing in sequencer broken.
Brecht Van Lommel [Thu, 24 Jan 2019 11:38:40 +0000 (12:38 +0100)]
Fix T58216: backdrop drawing in sequencer broken.

2 years agoSubdiv: Fix wrong orig_index for vertices of a loose edge
Sergey Sharybin [Thu, 24 Jan 2019 11:13:15 +0000 (12:13 +0100)]
Subdiv: Fix wrong orig_index for vertices of a loose edge

2 years agoFix T60408: Loose edge distort vertex on a surface
Sergey Sharybin [Thu, 24 Jan 2019 11:05:32 +0000 (12:05 +0100)]
Fix T60408: Loose edge distort vertex on a surface

Treat those vertices as infinitely sharp. This matches the way
how OpenSubdiv's topology is being created.

2 years agoFix T60805: Grease Pencil Rim Effect Problem
Antonioya [Thu, 24 Jan 2019 10:33:14 +0000 (11:33 +0100)]
Fix T60805: Grease Pencil Rim Effect Problem

The problem was related to cache data that was removed from memory before the FX  finished. This could affect to any FX.

Now all the information is saved in the FX itself in runtime struct to keep memory safe when cache memory is released.

2 years agoGP: Use matrix location instead of loc
Antonioya [Thu, 24 Jan 2019 09:46:10 +0000 (10:46 +0100)]
GP: Use matrix location instead of loc

2 years agoFix T54581: Clip editor doesn't synchronize frame on layout change
Sergey Sharybin [Thu, 24 Jan 2019 09:36:42 +0000 (10:36 +0100)]
Fix T54581: Clip editor doesn't synchronize frame on layout change

2 years agoDRW: support clipping for object outlines (unselected)
Campbell Barton [Thu, 24 Jan 2019 08:13:38 +0000 (19:13 +1100)]
DRW: support clipping for object outlines (unselected)

2 years agoDRW: support clipping for object outlines
Campbell Barton [Thu, 24 Jan 2019 07:27:26 +0000 (18:27 +1100)]
DRW: support clipping for object outlines

2 years agoFix T60790, T60636, T60631: MMB emulation issues after recent changes.
Brecht Van Lommel [Thu, 24 Jan 2019 06:06:49 +0000 (07:06 +0100)]
Fix T60790, T60636, T60631: MMB emulation issues after recent changes.

The statusbar keymap display should not affect actual event handling.

2 years agoCleanup: fix compiler warnings.
Brecht Van Lommel [Thu, 24 Jan 2019 06:30:24 +0000 (07:30 +0100)]
Cleanup: fix compiler warnings.

2 years agoDRW: use clipping for depth buffer
Campbell Barton [Thu, 24 Jan 2019 06:12:06 +0000 (17:12 +1100)]
DRW: use clipping for depth buffer

Object selection now supports clipping.

2 years agoCleanup: trailing space guardedalloc & memutil
Campbell Barton [Thu, 24 Jan 2019 05:20:16 +0000 (16:20 +1100)]
Cleanup: trailing space guardedalloc & memutil

2 years agoCorrect doxy file
Campbell Barton [Thu, 24 Jan 2019 05:19:45 +0000 (16:19 +1100)]
Correct doxy file

2 years agoDRW: API for own versions of builtin GPU shaders
Campbell Barton [Thu, 24 Jan 2019 04:02:40 +0000 (15:02 +1100)]
DRW: API for own versions of builtin GPU shaders

DRW_shader_get_builtin_shader can replace GPU_shader_get_builtin_shader
when we need to support clipping.

Use this for loose point & wire drawing in object mode,
clips edges in lattice edit mode.

2 years agoWM: Repeat Last no longer reuses skip-save properties
Campbell Barton [Thu, 24 Jan 2019 01:06:47 +0000 (12:06 +1100)]
WM: Repeat Last no longer reuses skip-save properties

PROP_SKIP_SAVE is often used as a way to detect the difference between
adjusting options from the redo panel and initial execution.

Repeat last operator was executing with skip-save properties set,
preventing operators from initializing them based on the context.

Fixes 60777.

2 years agoFix theme color use for clipping region
Campbell Barton [Wed, 23 Jan 2019 23:35:34 +0000 (10:35 +1100)]
Fix theme color use for clipping region

Color needed to be converted to linear in the engine,
not the theme.

2 years agoCleanup: style
Campbell Barton [Wed, 23 Jan 2019 22:27:14 +0000 (09:27 +1100)]
Cleanup: style

2 years agoFix T60417: Hair not instantly updating when editing curve guide
Philipp Oeser [Fri, 11 Jan 2019 12:13:55 +0000 (13:13 +0100)]
Fix T60417: Hair not instantly updating when editing curve guide

Reviewers: sergey, brecht

Maniphest Tasks: T60417

Differential Revision:

2 years agoFix T58438: wrong display of brush angle rotation preview.
Pablo Dobarro [Wed, 23 Jan 2019 19:25:37 +0000 (20:25 +0100)]
Fix T58438: wrong display of brush angle rotation preview.

Differential Revision:

2 years agoSculpt: add Topology Rake, to align edges along brush while painting.
Jean Da Costa [Wed, 23 Jan 2019 17:38:40 +0000 (18:38 +0100)]
Sculpt: add Topology Rake, to align edges along brush while painting.

This helps to generate cleaner topology and define sharp features for dynamic
topology. Best used on relatively low-poly meshes, it is not needed as much
for high detail areas and has a performance impact.

Differential Revision:

2 years agoFix wrong f-curve modifier mute checkbox icon / tooltip.
Anton Stötzer [Wed, 23 Jan 2019 17:23:01 +0000 (18:23 +0100)]
Fix wrong f-curve modifier mute checkbox icon / tooltip.

Differential Revision:

2 years agoFix T54834: VSE can't import OGG Theora video
Sergey Sharybin [Wed, 23 Jan 2019 16:15:56 +0000 (17:15 +0100)]
Fix T54834: VSE can't import OGG Theora video

2 years agoCleanup: More clear function name
Sergey Sharybin [Wed, 23 Jan 2019 15:58:37 +0000 (16:58 +0100)]
Cleanup: More clear function name

Otherwise it was read as it does select sequences rather
than counts them.

2 years agoSequencer: Fix python error on Add menu on default workspace
Sergey Sharybin [Wed, 23 Jan 2019 15:56:23 +0000 (16:56 +0100)]
Sequencer: Fix python error on Add menu on default workspace

It is possible that context does have selected_sequences but
it will be set to None. In this case getattr() will return
None, breaking the intended logic.

2 years agoUI: Particles UIList
Pablo Vazquez [Wed, 23 Jan 2019 16:05:12 +0000 (17:05 +0100)]
UI: Particles UIList

Swap show_render and show_viewport to match outliner (first viewport then render)

Also make list item into an aligned row so it uses less space and looks closer to the outliner.


2 years agoGP: Remove unneeded armature code
Antonioya [Wed, 23 Jan 2019 15:52:07 +0000 (16:52 +0100)]
GP: Remove unneeded armature code

This line looks a mistake and it's not needed.

2 years agoFix T59152: dynamic topology constant detail should be in world space.
Brecht Van Lommel [Wed, 23 Jan 2019 15:48:02 +0000 (16:48 +0100)]
Fix T59152: dynamic topology constant detail should be in world space.

It seems more predictable, and makes more sense for future multi-object modes.

2 years agoUI: fix horizontal scrollbar overlapping last row of files
gsr b3d [Wed, 23 Jan 2019 14:31:47 +0000 (15:31 +0100)]
UI: fix horizontal scrollbar overlapping last row of files

Depending on area size, the scrollbar covered the bottom of the text,
with the extra it will only cover the padding at worst.

Differential Revision:

2 years agoUI: make editor corner splitting / joining more reliable.
Harley Acheson [Wed, 23 Jan 2019 13:44:40 +0000 (14:44 +0100)]
UI: make editor corner splitting / joining more reliable.

* Add threshold for minimum amount of mouse movement for dragging to
  get activated.
* Limit angles at which dragging is considered an action, do nothing if
  mouse does not clearly move up/down/left/right.
* Increase action zone size vertically.

Differential Revision:

2 years agoFix T60791: Don't show automatic weights option when not supported
Jacques Lucke [Wed, 23 Jan 2019 14:20:35 +0000 (15:20 +0100)]
Fix T60791: Don't show automatic weights option when not supported

There are probably many more cases in which the menu looks a little different.
However, I don't know them all and it's too easy to break something accidentally here.
Maybe a user could try the different combinations of object types and check if there are entries that should not be there.

Reviewers: brecht

Differential Revision:

2 years agoFix T59939: Masks not Animating in Render
Philipp Oeser [Sat, 29 Dec 2018 16:15:28 +0000 (17:15 +0100)]
Fix T59939: Masks not Animating in Render

For now this is not part of copy-on-write, and needs extra animation

Reviewers: sergey, brecht

Maniphest Tasks: T59939

Differential Revision:

2 years agoCleanup: comments above struct members, shader group assignments
Campbell Barton [Wed, 23 Jan 2019 12:59:40 +0000 (23:59 +1100)]
Cleanup: comments above struct members, shader group assignments

Avoid using pointer to pointer when building shader groups.