3 years agoMerge branch 'master' into blender2.8
Germano [Thu, 1 Feb 2018 00:36:16 +0000 (22:36 -0200)]
Merge branch 'master' into blender2.8

3 years agoRevert "tmp"
Germano [Thu, 1 Feb 2018 00:35:46 +0000 (22:35 -0200)]
Revert "tmp"

This reverts commit ea31f0ac3b877eb0df4c47d0c908d11d1bff33e4.

3 years agoMerge branch 'master' into blender2.8
Germano [Thu, 1 Feb 2018 00:34:29 +0000 (22:34 -0200)]
Merge branch 'master' into blender2.8

3 years agogpu_shader_material: Correct incorrect glsl texture of Voronoi, Noise, and Musgrave...
Germano [Thu, 1 Feb 2018 00:31:08 +0000 (22:31 -0200)]
gpu_shader_material: Correct incorrect glsl texture of Voronoi, Noise, and Musgrave on some Intel GPUs

3 years agotmp
Germano [Thu, 1 Feb 2018 00:11:01 +0000 (22:11 -0200)]

3 years agoMerge branch 'master' into blender2.8
Gaia Clary [Wed, 31 Jan 2018 23:43:01 +0000 (00:43 +0100)]
Merge branch 'master' into blender2.8
Apply Fix T50198 also in blender2.8

3 years agofix T50198: The OpenCollada error handler must return true after detecting uncritical...
Gaia Clary [Wed, 31 Jan 2018 23:41:04 +0000 (00:41 +0100)]
fix T50198: The OpenCollada error handler must return true after detecting uncritical errors.

3 years agoMerge branch 'master' into blender2.8
Bastien Montagne [Wed, 31 Jan 2018 16:17:43 +0000 (17:17 +0100)]
Merge branch 'master' into blender2.8

3 years agoI18n disambiguation: IRIS is both a file format and a VSE wipe effect...
Bastien Montagne [Wed, 31 Jan 2018 15:43:04 +0000 (16:43 +0100)]
I18n disambiguation: IRIS is both a file format and a VSE wipe effect...

At some point, we could probably think about removing IRIS file format
support, don't think there are much of those around anymore. But for
now, let's add a translation context to wipe effect. :)

Reported in T43295 by @blend-it, thanks.

3 years agoDRW: Finish 85d3de94c62fab1394c11fe50614c897f7f68ee3
Clément Foucault [Wed, 31 Jan 2018 14:00:39 +0000 (15:00 +0100)]
DRW: Finish 85d3de94c62fab1394c11fe50614c897f7f68ee3

3 years agoEevee: SSS: Fix SSS perturbating SSR normals.
Clément Foucault [Wed, 31 Jan 2018 13:41:06 +0000 (14:41 +0100)]
Eevee: SSS: Fix SSS perturbating SSR normals.

3 years agoMerge branch 'master' into blender2.8
Sergey Sharybin [Wed, 31 Jan 2018 13:24:38 +0000 (14:24 +0100)]
Merge branch 'master' into blender2.8

3 years agoOutliner: Fix crash when invoking operators of a collection or group
Germano [Wed, 31 Jan 2018 13:07:25 +0000 (11:07 -0200)]
Outliner: Fix crash when invoking operators of a collection or group

The crash occurred when trying to see a tooltip or activate any of the operator's tools with the cursor outside the outliner area.

3 years agoFix possible concurency issue in mesh normals computation.
Bastien Montagne [Wed, 31 Jan 2018 11:30:39 +0000 (12:30 +0100)]
Fix possible concurency issue in mesh normals computation.

Failure in own code from last December, thanks @sergey for finding it.

To be backported to 2.79a.

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Wed, 31 Jan 2018 08:03:45 +0000 (19:03 +1100)]
Merge branch 'master' into blender2.8

3 years agoWM: correct comment, variable name for addons
Campbell Barton [Wed, 31 Jan 2018 08:02:43 +0000 (19:02 +1100)]
WM: correct comment, variable name for addons

3 years agoEevee: Render: Fix crash when using a sun lamps with shadow.
Clément Foucault [Wed, 31 Jan 2018 01:13:45 +0000 (02:13 +0100)]
Eevee: Render: Fix crash when using a sun lamps with shadow.

3 years agoEevee: Render: Add Normal pass output.
Clément Foucault [Wed, 31 Jan 2018 00:09:38 +0000 (01:09 +0100)]
Eevee: Render: Add Normal pass output.

3 years agoEevee: Fix indentation and fix output normal of emission shader.
Clément Foucault [Wed, 31 Jan 2018 00:08:24 +0000 (01:08 +0100)]
Eevee: Fix indentation and fix output normal of emission shader.

3 years agoEevee: Fix Crash when rendering using Render Border.
Clément Foucault [Tue, 30 Jan 2018 22:24:28 +0000 (23:24 +0100)]
Eevee: Fix Crash when rendering using Render Border.

3 years agoEevee: Fix crash when Rendering (F12) using camera mapping.
Clément Foucault [Tue, 30 Jan 2018 22:23:02 +0000 (23:23 +0100)]
Eevee: Fix crash when Rendering (F12) using camera mapping.

3 years agoEevee: Display compositing tab.
Clément Foucault [Tue, 30 Jan 2018 22:22:17 +0000 (23:22 +0100)]
Eevee: Display compositing tab.

3 years agoUI: re-enable alt-key for editing selection
Campbell Barton [Wed, 31 Jan 2018 00:54:04 +0000 (11:54 +1100)]
UI: re-enable alt-key for editing selection

Fixes T53950 where changing node layers applies to all selected nodes.

3 years agoMake layers unittest pass after filter cleanup
Dalai Felinto [Tue, 30 Jan 2018 21:01:43 +0000 (19:01 -0200)]
Make layers unittest pass after filter cleanup

Update your svn lib.

Unittests broken since 76289613910073.

3 years agoCompositor / Render Layer Node: Fix wrong layer after deleting view layers
Dalai Felinto [Tue, 30 Jan 2018 20:31:32 +0000 (18:31 -0200)]
Compositor / Render Layer Node: Fix wrong layer after deleting view layers

I was calling the ntree syncing function too late. So the index of the layer
was -1 since it was no longer in the ListBase, making all RenderLayer nodes
to decrease their respective `custom1` (even going to negative sometimes).

3 years agoFix blender player (tm)
Sergey Sharybin [Tue, 30 Jan 2018 15:11:58 +0000 (16:11 +0100)]
Fix blender player (tm)

3 years agoFix Cycles incorrect principled BSDF mixing with some parameter variatons.
Brecht Van Lommel [Tue, 30 Jan 2018 11:40:05 +0000 (12:40 +0100)]
Fix Cycles incorrect principled BSDF mixing with some parameter variatons.

Spotted by Ha Hyung-jin, thanks!

3 years agoFix blender player (tm)
Sergey Sharybin [Tue, 30 Jan 2018 15:11:58 +0000 (16:11 +0100)]
Fix blender player (tm)

3 years agoFix FOREACH_OBJECT_RENDERABLE using stack data
Dalai Felinto [Tue, 30 Jan 2018 15:05:43 +0000 (13:05 -0200)]

Since 30a966a7262308 when I removed the recursion, the code was still relying
on stack data. This would crash in release often, and it should crash always.

Big thanks to Sergey Sharybin for spotting the issue.

3 years agoFix Cycles incorrect principled BSDF mixing with some parameter variatons.
Brecht Van Lommel [Tue, 30 Jan 2018 11:40:05 +0000 (12:40 +0100)]
Fix Cycles incorrect principled BSDF mixing with some parameter variatons.

Spotted by Ha Hyung-jin, thanks!

3 years agoMerge branch 'master' into blender2.8
Sergey Sharybin [Tue, 30 Jan 2018 13:32:27 +0000 (14:32 +0100)]
Merge branch 'master' into blender2.8

3 years agoFix FOREACH_OBJECT_RENDERABLE going over the same object twice
Dalai Felinto [Tue, 30 Jan 2018 13:23:50 +0000 (11:23 -0200)]
Fix FOREACH_OBJECT_RENDERABLE going over the same object twice

Which is really silly because we were already tagging the ids, but simply
never checking them back.

3 years agoFix T52520: Metaballs in edit mode causes infinite Cycles viewport reset
Sergey Sharybin [Tue, 30 Jan 2018 13:14:26 +0000 (14:14 +0100)]
Fix T52520: Metaballs in edit mode causes infinite Cycles viewport reset

The issue was introduced by eb016eb as a fix for T41258, which added depsgraph
tagging with zero flag. The comment was saying that it's to make derived caches
to be updated, however bot sure how that could possibly work: tagging ID for
update with 0 flag only sets updated tags in bmain in old dependency graph.

In the new depsgraph, where object data is a part of depsgraph, doing such a
tag forces object to be updated, which re-triggers viewport rendering, which
is causing such an infinite viewport render rest.

Can not reproduce any crashes here, so maybe it's fine to move on with this

3 years agoFix FOREACH_OBJECT_RENDERABLE recursion going over the roof
Dalai Felinto [Tue, 30 Jan 2018 12:52:25 +0000 (10:52 -0200)]
Fix FOREACH_OBJECT_RENDERABLE recursion going over the roof

This was leading to so much recursion that it was failing here.
How to test it: Open wanderer.blend and try to render (F12).

Note: This won't fix F12 rendering for wanderer with Eevee. Something else is
going wrong there.

3 years agoCleanup: warning, spelling
Campbell Barton [Tue, 30 Jan 2018 10:02:27 +0000 (21:02 +1100)]
Cleanup: warning, spelling

3 years agoFix T53943: Weight paint crash in new scene
Campbell Barton [Tue, 30 Jan 2018 09:33:20 +0000 (20:33 +1100)]
Fix T53943: Weight paint crash in new scene

3 years agoFix T50630: Fluid fails on win32 w/ unicode paths
Campbell Barton [Tue, 30 Jan 2018 03:30:28 +0000 (14:30 +1100)]
Fix T50630: Fluid fails on win32 w/ unicode paths

Allow overriding gzip open w/ elbeem.

3 years agoFix crash drawing light probe
Campbell Barton [Tue, 30 Jan 2018 02:36:41 +0000 (13:36 +1100)]
Fix crash drawing light probe

3 years agoFix light probe callbacks
Campbell Barton [Tue, 30 Jan 2018 02:14:17 +0000 (13:14 +1100)]
Fix light probe callbacks

Even though this wasn't crashing here, the arg types were wrong.

3 years agoDRW / Render: Make render result show when using final render with eevee.
Clément Foucault [Mon, 29 Jan 2018 21:27:22 +0000 (22:27 +0100)]
DRW / Render: Make render result show when using final render with eevee.

3 years agoEevee: Remove unused variable.
Clément Foucault [Mon, 29 Jan 2018 20:59:53 +0000 (21:59 +0100)]
Eevee: Remove unused variable.

3 years agoEevee: Add Z pass render result.
Clément Foucault [Mon, 29 Jan 2018 20:59:34 +0000 (21:59 +0100)]
Eevee: Add Z pass render result.

3 years agoEevee: Display render button in render panel
Clément Foucault [Mon, 29 Jan 2018 18:40:07 +0000 (19:40 +0100)]
Eevee: Display render button in render panel

3 years agoEevee: Add support for TAA/SuperSampling for final render.
Clément Foucault [Mon, 29 Jan 2018 18:39:53 +0000 (19:39 +0100)]
Eevee: Add support for TAA/SuperSampling for final render.

3 years agoEevee: Add new "render samples" properties.
Clément Foucault [Mon, 29 Jan 2018 18:39:07 +0000 (19:39 +0100)]
Eevee: Add new "render samples" properties.

3 years agoEevee: Initial Final Render support.
Clément Foucault [Mon, 29 Jan 2018 17:16:11 +0000 (18:16 +0100)]
Eevee: Initial Final Render support.

TAA / multiple samples is not working at the moment.

3 years agoRender: Abort operator if there is no render_to_image() function
Clément Foucault [Mon, 29 Jan 2018 16:09:38 +0000 (17:09 +0100)]
Render: Abort operator if there is no render_to_image() function

3 years agoDRW / Render: Add support for render pipeline in drawmanager.
Clément Foucault [Mon, 29 Jan 2018 13:56:16 +0000 (14:56 +0100)]
DRW / Render: Add support for render pipeline in drawmanager.

For simplicity we choose to execute the rendering of Opengl engines in the main thread and block the interface.
This might be addressed in the future at least for video rendering.

A drawmanager wrapper (DRW_render_to_image) is called by the render pipeline to set up the Opengl state and then call the specific draw_engine->render_to_image function.

3 years agoDRW: Add "hardcoded" stipples for sun ray display.
Clément Foucault [Mon, 22 Jan 2018 15:14:12 +0000 (16:14 +0100)]
DRW: Add "hardcoded" stipples for sun ray display.

3 years agoOutliner: Moving object context menu to Python, and adding hierarchy
Dalai Felinto [Mon, 29 Jan 2018 20:01:53 +0000 (18:01 -0200)]
Outliner: Moving object context menu to Python, and adding hierarchy

As suggested by Pablo Vazquez, though I think we can refine it a bit with icons.
I will wait for his feedback on it.

3 years agouvedit_draw: Ensure first if it has any UV to draw
Germano [Mon, 29 Jan 2018 18:56:52 +0000 (16:56 -0200)]
uvedit_draw: Ensure first if it has any UV to draw

Otherwise an assert could be launched

3 years agoDeduplicate GLSL frag code in particle drawing
Germano [Mon, 29 Jan 2018 17:51:23 +0000 (15:51 -0200)]
Deduplicate GLSL frag code in particle drawing

Differential Revision: D2993

3 years agoFix T53598: OpenGL Render Animation does not update shadows
Sergey Sharybin [Mon, 29 Jan 2018 15:42:04 +0000 (16:42 +0100)]
Fix T53598: OpenGL Render Animation does not update shadows

General idea of the fix: skip the whole draw manager callback madness which
was used to tag object's engine specific data as dirty. Use generic recalc
flag in ObjectEngineData structure instead. This gives us the following

- Sovles mentioned bug report.
- Avoids whole interface lookup for opened viewports for EVERY changed ID.
- Fixes missing updates when viewport is temporarily invisible.

Reviewers: dfelinto, fclem

Differential Revision:

3 years agoRefactor object engine data storage
Sergey Sharybin [Mon, 29 Jan 2018 15:28:24 +0000 (16:28 +0100)]
Refactor object engine data storage

Main idea is to make specific engine types be a subclass of generic
ObjectEngineData structure.

This required following changes:

- Have extra size argument to engine data allocation function.

  Not sure whether there is less error-prone way of doing this.

- Add init() callback to engine data allocation function.

Additionally, added some extra checks to Eevee's engine data getters, so we do
not silently cast lamp data to lightprobe data.

Reviewers: dfelinto, fclem

Differential Revision:

3 years agoFix Cycles viewport render not updating when tweaking displacement shader.
Brecht Van Lommel [Wed, 24 Jan 2018 19:19:48 +0000 (20:19 +0100)]
Fix Cycles viewport render not updating when tweaking displacement shader.

This was disabled to avoid updating the geometry every time when the
material includes displacement, because there was no way to distinguish
between surface shader and displacement updates.

As a solution, we now compute an MD5 hash of the nodes linked to the
displacement socket, and only update the mesh if that changes.

Differential Revision:

3 years agoFix Cycles allocating too much device memory, after recent memory refactoring.
Brecht Van Lommel [Mon, 29 Jan 2018 13:51:22 +0000 (14:51 +0100)]
Fix Cycles allocating too much device memory, after recent memory refactoring.

Spotted by Ha Hyung-jin, thanks!

3 years agoRevert "Fix T53914: Volumetric scattering now goes correctly through transparent...
Brecht Van Lommel [Mon, 29 Jan 2018 14:59:46 +0000 (15:59 +0100)]
Revert "Fix T53914: Volumetric scattering now goes correctly through transparent surfaces."

This reverts commit 3c852ba0741f794a697f95073b04921e9ff94039. This is breaking
the regression tests, and maybe requires some deeper changes to really fix.

3 years agoFix nan problem in previous bevel commit.
Howard Trickey [Mon, 29 Jan 2018 15:01:19 +0000 (10:01 -0500)]
Fix nan problem in previous bevel commit.

For chains, access to g_prod[0] was undefined.
And two minor style (whitespace) changes.

3 years agoDepsgraph: Correction for previous fix
Sergey Sharybin [Mon, 29 Jan 2018 14:06:44 +0000 (15:06 +0100)]
Depsgraph: Correction for previous fix

Original fix only worked when there is one custom property.

3 years agoOutliner: Remove Toggle options from object RMB
Dalai Felinto [Mon, 29 Jan 2018 14:04:45 +0000 (12:04 -0200)]
Outliner: Remove Toggle options from object RMB

Task suggested by Pablo Vazquez (venomgfx).

3 years agoDepsgraph: Fix missing update when property from proxy rig drives something
Sergey Sharybin [Mon, 29 Jan 2018 13:53:27 +0000 (14:53 +0100)]
Depsgraph: Fix missing update when property from proxy rig drives something

3 years agoDepsgraph: Disable labels on relations
Sergey Sharybin [Mon, 29 Jan 2018 13:45:45 +0000 (14:45 +0100)]
Depsgraph: Disable labels on relations

This code was disable a while back and got re-enabled by some previous debug
process. Having relation names in dot file helps understanding what's going
on in one cases, but makes things spread too far away in others.

3 years agoDepsgraph: Cleanup, line wraps
Sergey Sharybin [Mon, 29 Jan 2018 13:43:12 +0000 (14:43 +0100)]
Depsgraph: Cleanup, line wraps

3 years agoFix more filebrowser not refreshing correctly after new message bus system.
Bastien Montagne [Mon, 29 Jan 2018 11:50:15 +0000 (12:50 +0100)]
Fix more filebrowser not refreshing correctly after new message bus system.

This does not affect current blender2.8, but is mandatory for asset
engine branch.

Bottom line being, we also need to 'survey' changes in actual
SpaceFileBrowser struct, not only its FileSelectParams sub-struct.

3 years agoFix filebrowser not refreshing correctly after new message bus system.
Bastien Montagne [Mon, 29 Jan 2018 09:24:30 +0000 (10:24 +0100)]
Fix filebrowser not refreshing correctly after new message bus system.

Generic ED_area_do_msg_notify_tag_refresh callback only tags area for
refresh, not redraw. This was not updating view e.g. when changing
ordering options in top region, until you'd mouse-over main filelisting

So now, always tag area for redraw in filbrowser's refresh callback.

3 years agoManipulator: ignore mouse location w/ view widgets
Campbell Barton [Mon, 29 Jan 2018 06:40:19 +0000 (17:40 +1100)]
Manipulator: ignore mouse location w/ view widgets

When pressing on a button to zoom for eg,
using zoom-to-mouse-position doesn't make any sense.

There is also zoom speed scaling which increases the closer the cursor
is to the top-edge of the screen, which was noticable since the
navigation widget is currently at the top of the screen.

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Mon, 29 Jan 2018 06:32:20 +0000 (17:32 +1100)]
Merge branch 'master' into blender2.8

3 years agoFix T53614: New Depsgraph ignores NLA strips
Joshua Leung [Mon, 29 Jan 2018 06:01:44 +0000 (19:01 +1300)]
Fix T53614: New Depsgraph ignores NLA strips

The new depsgraph was only considering the active action
when attaching relations from the AnimData component/operation
to the properties that are affected by the animation data.
As a result, only properties animated by the active action
were working, while those animated by NLA strips did not change
when playing back/scrubbing the timeline.

This commit fixes this introducing a recursive method to properly
visit all NLA strips, and calling DepsRelBuilder::build_animdata_curves_targets()
on each of those strips.

3 years ago3D View: use_mouse_init for zoom & trackball orbit
Campbell Barton [Mon, 29 Jan 2018 05:17:47 +0000 (16:17 +1100)]
3D View: use_mouse_init for zoom & trackball orbit

3 years agoCleanup: move boolean options into flag
Campbell Barton [Mon, 29 Jan 2018 04:34:39 +0000 (15:34 +1100)]
Cleanup: move boolean options into flag

- Rename eViewOpsOrbit to eViewOpsFlag
  since VIEWOPS_ORBIT_DEPTH isn't just used for orbiting.
- Move use_ensure_persp & use_mouse_init into the flag.
- Remove viewops_data_create_ex.

3 years agoFix: Disable leftover debug prints from earlier work on the rna path renaming/fixing...
Joshua Leung [Mon, 29 Jan 2018 04:16:31 +0000 (17:16 +1300)]
Fix: Disable leftover debug prints from earlier work on the rna path renaming/fixing code

3 years agoFix T53909: Joining armatures did not remap names on merged action data
Joshua Leung [Mon, 29 Jan 2018 04:13:23 +0000 (17:13 +1300)]
Fix T53909: Joining armatures did not remap names on merged action data

Technically this was not a bug, as this functionality was not meant to
work. (Drivers were already handled though, as they are part of the rig)
It was assumed that there was little value in having this functionality
available, as in most pipelines, animation production only begins after
the rig has been locked down (see bug report comments for more details).

On reflection, in most common situations, there's probably no harm in
doing these rna path fixups. This commit takes advantage of some similar
code I recently put in place in the Grease Pencil branch (for joining GP
objects and their layers).

Important Note for Animators/Riggers/TD's:
Please be aware that after joining armatures, some of the animation may
still need to be redone (due to changes in the transform hierarchies/
transform spaces that the animation is applied in). We do not attempt
to correct for these problems, and it is unlikely that we will in future.

3 years agoApply Pose as Rest Pose: Bendy Bone support
Joshua Leung [Mon, 29 Jan 2018 01:46:03 +0000 (14:46 +1300)]
Apply Pose as Rest Pose: Bendy Bone support

The "Apply Pose as Rest Pose" operator now affects Bendy Bone settings
too, making it possible to use interactive posing tools (e.g. Pose Sculpting
brushes) to get the desired shape for the rest-pose shape of Bendy Bones.
When such posing tools are available, this change makes it easier to get
the desired Bendy Bone shapes, as you are no longer restricted to using
buttons to get the desired effects.

3 years agoCleanup: rename user preference flags
Campbell Barton [Mon, 29 Jan 2018 04:06:23 +0000 (15:06 +1100)]
Cleanup: rename user preference flags

The name didn't make sense since it's used for all view navigation.

Also rename USER_ZBUF_CURSOR -> USER_DEPTH_CURSOR since zbuf
is an internal detail.

3 years agoCleanup: comments & whitespace
Campbell Barton [Mon, 29 Jan 2018 03:59:56 +0000 (14:59 +1100)]
Cleanup: comments & whitespace

3 years agoCleanup: ViewOpsData struct members
Campbell Barton [Mon, 29 Jan 2018 03:36:40 +0000 (14:36 +1100)]
Cleanup: ViewOpsData struct members

- Group initial/previous/current members
  Was using terms old/prev/last/orig in confusing way.
- Replace x,y variables with vectors.
- Remove unused members.

3 years ago3D View: internal option not to use mouse location
Campbell Barton [Mon, 29 Jan 2018 02:46:18 +0000 (13:46 +1100)]
3D View: internal option not to use mouse location

When accessing view-port operators from widgets
we need the ability not to use auto-depth or zoom-to-mouse.

Trackball rotation still needs to be supported.

3 years agoCleanup: minor simplification for zoom/dolly
Campbell Barton [Mon, 29 Jan 2018 02:42:28 +0000 (13:42 +1100)]
Cleanup: minor simplification for zoom/dolly

Make args more consistent.

3 years agoCleanup: de-duplicate common 3D view properties
Campbell Barton [Sun, 28 Jan 2018 07:22:54 +0000 (18:22 +1100)]
Cleanup: de-duplicate common 3D view properties

3 years agoFix T53459, inconsistent bevel on identical edges.
Howard Trickey [Mon, 29 Jan 2018 00:19:02 +0000 (19:19 -0500)]
Fix T53459, inconsistent bevel on identical edges.

The old algorithm depended on vertex order.
The new one uses a global least squares solution on chains
and cycles of edges where loop slide induces a dependency.

in the "Consistent Widths for Even Bevels" for derivation of
the new algorithm.

3 years agoMerge branch 'master' into blender2.8
Bastien Montagne [Sun, 28 Jan 2018 16:49:58 +0000 (17:49 +0100)]
Merge branch 'master' into blender2.8

3 years agoUsual i18n/UI messages fixes.
Bastien Montagne [Sun, 28 Jan 2018 16:27:53 +0000 (17:27 +0100)]
Usual i18n/UI messages fixes.

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Sun, 28 Jan 2018 06:18:56 +0000 (17:18 +1100)]
Merge branch 'master' into blender2.8

3 years agoCleanup: style, spelling
Campbell Barton [Sun, 28 Jan 2018 06:00:39 +0000 (17:00 +1100)]
Cleanup: style, spelling

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Sun, 28 Jan 2018 05:40:23 +0000 (16:40 +1100)]
Merge branch 'master' into blender2.8

3 years agoCleanup: use doxy sections for view3d_view.c
Campbell Barton [Sun, 28 Jan 2018 05:22:34 +0000 (16:22 +1100)]
Cleanup: use doxy sections for view3d_view.c

Also move ..._needs_opengl functions into view3d_utils.c

3 years agoUse factory startup for icon generation
Campbell Barton [Sun, 28 Jan 2018 05:03:32 +0000 (16:03 +1100)]
Use factory startup for icon generation

Avoids using local preferences.

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Sun, 28 Jan 2018 04:20:19 +0000 (15:20 +1100)]
Merge branch 'master' into blender2.8

3 years agoMerge branch 'master' into blender2.8
Campbell Barton [Sun, 28 Jan 2018 04:18:33 +0000 (15:18 +1100)]
Merge branch 'master' into blender2.8

3 years agoCleanup: warning
Campbell Barton [Sun, 28 Jan 2018 04:15:32 +0000 (15:15 +1100)]
Cleanup: warning

3 years agoCleanup: move 3D view utilities into own file
Campbell Barton [Sun, 28 Jan 2018 03:44:42 +0000 (14:44 +1100)]
Cleanup: move 3D view utilities into own file

Operators and utility functions were getting too mixed up,
the files were also quite large.

3 years agoFix T53914: Volumetric scattering now goes correctly through transparent surfaces.
Stefan Werner [Sat, 27 Jan 2018 09:36:22 +0000 (10:36 +0100)]
Fix T53914: Volumetric scattering now goes correctly through transparent surfaces.

There was a check for volume bounces at every surface intersection. That could lead to a volume scattered path being terminated
when passing through a transparent surface. This check was superfluous, as the volume shader evaluation already checks the
number of volume bounces and once it passes the max, volume shaders will not return scatter events any more.

Reviewers: #cycles, brecht

Reviewed By: #cycles, brecht

Subscribers: brecht, #cycles

Tags: #cycles

Maniphest Tasks: T53914

Differential Revision:

3 years agoSpeed up a little drawing of UVs in the Image Editor
Germano [Fri, 26 Jan 2018 22:42:30 +0000 (20:42 -0200)]
Speed up a little drawing of UVs in the Image Editor

In my tests the previous loop was running in 200 ms. With this change it now runs in 17 ms.

The difference in the end is still not great because the `draw_uvs_lineloop_bmface` function is called for each face and has an ImmBegin and ImmEnd in the function itself

3 years agoCode refactor: make mixed small/large BSSRDF radii more robust.
Brecht Van Lommel [Fri, 26 Jan 2018 21:11:28 +0000 (22:11 +0100)]
Code refactor: make mixed small/large BSSRDF radii more robust.

3 years agoCollections: As it turned out, this is quite harmless to have accessible everwhere
Dalai Felinto [Fri, 26 Jan 2018 21:41:45 +0000 (19:41 -0200)]
Collections: As it turned out, this is quite harmless to have accessible everwhere

I think ultimately we may move these operators from the outliner space to scene.

Partial revert of a08f687b91a2a7880889.

3 years agoMake outliner new collection operator work via viewport too
Dalai Felinto [Fri, 26 Jan 2018 21:33:28 +0000 (19:33 -0200)]
Make outliner new collection operator work via viewport too

Technically this revert b3bcbc9e85aa. This however doesn't seem to be needed
any longer.

3 years agoOutliner: If a collection is empty and you drag something inside it, it opens up.
Dalai Felinto [Fri, 26 Jan 2018 18:55:44 +0000 (16:55 -0200)]
Outliner: If a collection is empty and you drag something inside it, it opens up.

Idea by Pablo Vazquez.

3 years agoFix mixed BSDF + BSSRDF sampling bug in path tracing, after 095a01a73a35.
Brecht Van Lommel [Fri, 26 Jan 2018 17:31:36 +0000 (18:31 +0100)]
Fix mixed BSDF + BSSRDF sampling bug in path tracing, after 095a01a73a35.

Spotted by Ha Hyung-jin, thanks!

3 years agoCode refactor: store RGB BSSRDF in a single closure.
Brecht Van Lommel [Fri, 26 Jan 2018 13:09:55 +0000 (14:09 +0100)]
Code refactor: store RGB BSSRDF in a single closure.

Previously we stored each color channel in a single closure, which was
convenient for sampling a closure and channel together. But this doesn't
work so well for algorithms where we want to render multiple color
channels together.

3 years agoIMB: Add asserts that returned fps and fps base are strictly positives.
Bastien Montagne [Fri, 26 Jan 2018 14:13:35 +0000 (15:13 +0100)]
IMB: Add asserts that returned fps and fps base are strictly positives.

Forgot to add that in previous commit, also related to T53003.