blender.git
3 years agobuild_environment: support for msvc2017 and newer cmake.
Ray Molenkamp [Sat, 2 Jun 2018 19:59:56 +0000 (13:59 -0600)]
build_environment: support for msvc2017 and newer cmake.

-expanded build_deps.cmd with 2017 support, it can't locate msvc2017 so needs to be run from developer prompt.
-Newer cmake was unhappy with openal's cmakelists.txt
-collada has warning as error on and errored out on new msvc2017 warnings.

3 years agobuild_environment: fix paths in osl.diff
Ray Molenkamp [Sat, 2 Jun 2018 19:12:42 +0000 (13:12 -0600)]
build_environment: fix paths in osl.diff

3 years ago--debug-gpu-shader: Dump GLSL shaders to disk
Dalai Felinto [Wed, 27 Sep 2017 16:03:00 +0000 (18:03 +0200)]
--debug-gpu-shader: Dump GLSL shaders to disk

This is really convenient for development. Either for profiling the
generated shaders or to check if the generated code is correct.

It writes the shaders to the temporary blender session folder.

(ported over from blender2.8)

3 years agoCleanup: warning
Campbell Barton [Sat, 2 Jun 2018 09:58:01 +0000 (11:58 +0200)]
Cleanup: warning

3 years agoCleanup: trailing whitespace (comment blocks)
Campbell Barton [Fri, 1 Jun 2018 16:19:39 +0000 (18:19 +0200)]
Cleanup: trailing whitespace (comment blocks)

Strip unindented comment blocks - mainly headers to avoid conflicts.

3 years agoCleanup: some more G.main removal from editor code.
Bastien Montagne [Fri, 1 Jun 2018 15:08:38 +0000 (17:08 +0200)]
Cleanup: some more G.main removal from editor code.

3 years agoAdd Asan support for clang on windows.
Ray Molenkamp [Thu, 31 May 2018 17:50:30 +0000 (11:50 -0600)]
Add Asan support for clang on windows.

This will currently only work for the RelWithDebInfo configuration since asan
does not support the debug crt. for source line information in the reports,
you need a copy of llvm-symbolizer in the blender folder or set the
ASAN_SYMBOLIZER_PATH environment variable to point to it. Currently (as of
6.0.0) llvm-symbolizer does not ship with the binary clang/llvm distribution.

Reviewers: campbellbarton

Differential Revision: https://developer.blender.org/D3446

3 years agoCleanup: Remove G.main from some editor files.
Bastien Montagne [Thu, 31 May 2018 16:23:20 +0000 (18:23 +0200)]
Cleanup: Remove G.main from some editor files.

3 years agoCleanup: remove G.main from BKE mball code.
Bastien Montagne [Thu, 31 May 2018 14:44:05 +0000 (16:44 +0200)]
Cleanup: remove G.main from BKE mball code.

3 years agoCleanup: get rid of last G.main usages in BKE library code.
Bastien Montagne [Thu, 31 May 2018 14:04:04 +0000 (16:04 +0200)]
Cleanup: get rid of last G.main usages in BKE library code.

3 years agoCleanup: remove G.main from BKE modifier.
Bastien Montagne [Thu, 31 May 2018 13:24:30 +0000 (15:24 +0200)]
Cleanup: remove G.main from BKE modifier.

3 years agoCleanup: remove G.main from BKE object
Bastien Montagne [Thu, 31 May 2018 10:27:47 +0000 (12:27 +0200)]
Cleanup: remove G.main from BKE object

Had to add some G.main to modifiers, but in 2.8 we do not need that
anymore, so it's not that bad! ;)

3 years agoCleanup: nuke G.main out of BKE PackedFile code.
Bastien Montagne [Thu, 31 May 2018 09:07:14 +0000 (11:07 +0200)]
Cleanup: nuke G.main out of BKE PackedFile code.

3 years agoCleanup: use doxy sections for space types
Campbell Barton [Thu, 31 May 2018 07:49:58 +0000 (09:49 +0200)]
Cleanup: use doxy sections for space types

Also use struct names in enum/define comments.

3 years agoCleanup: return types in stubs
Campbell Barton [Thu, 31 May 2018 07:49:44 +0000 (09:49 +0200)]
Cleanup: return types in stubs

3 years agoFix OpenCL compilation error - BPT without SSS.
Hristo Gueorguiev [Wed, 30 May 2018 22:08:56 +0000 (00:08 +0200)]
Fix OpenCL compilation error - BPT without SSS.

3 years agomake.bat: fix support for building with just the build tools installed.
Ray Molenkamp [Wed, 30 May 2018 16:54:06 +0000 (10:54 -0600)]
make.bat: fix support for building with just the build tools installed.

3 years agoFix missing movieclip ID type in allowed ones for Outliner...
Bastien Montagne [Wed, 30 May 2018 14:14:55 +0000 (16:14 +0200)]
Fix missing movieclip ID type in allowed ones for Outliner...

3 years agoEdit Mode: add success return value
Campbell Barton [Wed, 30 May 2018 06:41:06 +0000 (08:41 +0200)]
Edit Mode: add success return value

Also remove fix for T6614, since BKE_object_obdata_is_libdata
no longer checks proxy.

3 years agoDNA: add OB_DATA_SUPPORT_EDITMODE macro
Campbell Barton [Wed, 30 May 2018 05:31:35 +0000 (07:31 +0200)]
DNA: add OB_DATA_SUPPORT_EDITMODE macro

3 years agoCleanup: Get rid of G.main in BKE_material.
Bastien Montagne [Tue, 29 May 2018 13:49:21 +0000 (15:49 +0200)]
Cleanup: Get rid of G.main in BKE_material.

Note that in some cases, this only moves the G.main case to somne other
places - in particular, RNA getters/setters are becoming annoying here...

3 years agomake.bat : fix release build not getting the right settings.
Ray Molenkamp [Tue, 29 May 2018 03:50:59 +0000 (21:50 -0600)]
make.bat : fix release build not getting the right settings.

3 years agomake.bat : improve error message while detecting the msvc runtime when using clang
Ray Molenkamp [Tue, 29 May 2018 02:07:24 +0000 (20:07 -0600)]
make.bat : improve error message while detecting the msvc runtime when using clang

3 years agomake.bat : add support for building with ninja and clang together.
Ray Molenkamp [Tue, 29 May 2018 01:56:17 +0000 (19:56 -0600)]
make.bat : add support for building with ninja and clang together.

3 years agoWindows: Add support for building with clang.
Ray Molenkamp [Mon, 28 May 2018 20:34:47 +0000 (14:34 -0600)]
Windows: Add support for building with clang.

This commit contains the minimum to make clang build/work with blender, asan and ninja build support is forthcoming

Things to note:

1) Builds and runs, and is able to pass all tests (except for the freestyle_stroke_material.blend test which was broken at that time for all platforms by the looks of it)

2) It's slightly faster than msvc when using cycles. (time in seconds, on an i7-3370)

victor_cpu
msvc:3099.51
clang:2796.43

pavillon_barcelona_cpu
msvc:1872.05
clang:1827.72

koro_cpu
msvc:1097.58
clang:1006.51

fishy_cat_cpu
msvc:815.37
clang:722.2

classroom_cpu
msvc:1705.39
clang:1575.43

bmw27_cpu
msvc:552.38
clang:561.53

barbershop_interior_cpu
msvc:2134.93
clang:1922.33

3) clang on windows uses a drop in replacement for the Microsoft cl.exe (takes some of the Microsoft parameters, but not all, and takes some of the clang parameters but not all) and uses ms headers + libraries + linker, so you still need visual studio installed and will use our existing vc14 svn libs.

4) X64 only currently, X86 builds but crashes on startup.

5) Tested with llvm/clang 6.0.0

6) Requires visual studio integration, available at https://github.com/LazyDodo/llvm-vs2017-integration

7) The Microsoft compiler spawns a few copies of cl in parallel to get faster build times, clang doesn't, so the build time is 3-4x slower than with msvc.

8) No openmp support yet. Have not looked at this much, the binary distribution of clang doesn't seem to include it on windows.

9) No ASAN support yet, some of the sanitizers can be made to work, but it was decided to leave support out of this commit.

Reviewers: campbellbarton

Differential Revision: https://developer.blender.org/D3304

3 years agoFix Cycles + OSL build error, pass main to node editing functions.
Brecht Van Lommel [Sun, 27 May 2018 21:46:02 +0000 (23:46 +0200)]
Fix Cycles + OSL build error, pass main to node editing functions.

3 years agoUI: center align number buttons w/o text
Campbell Barton [Sun, 27 May 2018 19:06:38 +0000 (21:06 +0200)]
UI: center align number buttons w/o text

This makes supporting split properties and text possible, see T54951

3 years agoCleanup: Nuke most of remaining evil G.main from RNA.
Bastien Montagne [Sun, 27 May 2018 16:46:39 +0000 (18:46 +0200)]
Cleanup: Nuke most of remaining evil G.main from RNA.

The few ones in getters/setters we cannot remove as easily, for now we
can live with those I think...

3 years agoCycles: Fix problems in the IES loader when rendering with no file selected
Lukas Stockner [Sun, 27 May 2018 15:14:01 +0000 (17:14 +0200)]
Cycles: Fix problems in the IES loader when rendering with no file selected

3 years agoUI: replace BLI_strncpy w/ memcpy
Campbell Barton [Sun, 27 May 2018 10:50:03 +0000 (12:50 +0200)]
UI: replace BLI_strncpy w/ memcpy

Size is already checked.

3 years agoRecently added IES conflicts w/ EEVEE
Campbell Barton [Sun, 27 May 2018 09:01:46 +0000 (11:01 +0200)]
Recently added IES conflicts w/ EEVEE

3 years ago3D View: minor change to NDOF view orbit
Campbell Barton [Sun, 27 May 2018 08:34:01 +0000 (10:34 +0200)]
3D View: minor change to NDOF view orbit

This change is needed for 2.8, where the NULL check isn't a reliable way
of testing if dynamic offset is needed.

3 years agoFix restrict error in BLI_str_format_byte_unit
Campbell Barton [Sun, 27 May 2018 08:25:52 +0000 (10:25 +0200)]
Fix restrict error in BLI_str_format_byte_unit

Don't use sprintf to append a string to it's self.

Also correct BLI_str_rstrip_float_zero's return value.

3 years agomake.bat : Fix builtime.txt being written in the wrong folder.
Ray Molenkamp [Sun, 27 May 2018 01:20:07 +0000 (19:20 -0600)]
make.bat : Fix builtime.txt being written in the wrong folder.

3 years agoCycles: Add Support for IES files as textures for light strength
Lukas Stockner [Sat, 26 May 2018 22:46:37 +0000 (00:46 +0200)]
Cycles: Add Support for IES files as textures for light strength

This patch adds support for IES files, a file format that is commonly used to store the directional intensity distribution of light sources.
The new IES node is supposed to be plugged into the Strength input of the Emission node of the lamp.

Since people generating IES files do not really seem to care about the standard, the parser is flexible enough to accept all test files I have tried.
Some common weirdnesses are distributing values over multiple lines that should go into one line, using commas instead of spaces as delimiters and adding various useless stuff at the end of the file.

The user interface of the node is similar to the script node, the user can either select an internal Text or load a file.
Internally, IES files are handled similar to Image textures: They are stored in slots by the LightManager and each unique IES is assigned to one slot.

The local coordinate system of the lamp is used, so that the direction of the light can be changed. For UI reasons, it's usually best to add an area light,
rotate it and then change its type, since especially the point light does not immediately show its local coordinate system in the viewport.

Reviewers: #cycles, dingto, sergey, brecht

Reviewed By: #cycles, dingto, brecht

Subscribers: OgDEV, crazyrobinhood, secundar, cardboard, pisuke, intrah, swerner, micah_denn, harvester, gottfried, disnel, campbellbarton, duarteframos, Lapineige, brecht, juicyfruit, dingto, marek, rickyblender, bliblubli, lockal, sergey

Differential Revision: https://developer.blender.org/D1543

3 years agoThreads: add spinlock hit for hyperthreading processors on Windows.
Brecht Van Lommel [Sat, 26 May 2018 20:29:10 +0000 (22:29 +0200)]
Threads: add spinlock hit for hyperthreading processors on Windows.

Suggested by Percy Ross Tiglao.

3 years agomake.bat: Add support for building with ninja.
Ray Molenkamp [Sat, 26 May 2018 03:46:42 +0000 (21:46 -0600)]
make.bat: Add support for building with ninja.

ninja is an alternative to msbuild designed for fast rebuilds. However there is no IDE support, builds only from the command line.

Comparison between msbuild and ninja for a full build, build time in seconds.

Full Clean Build
msbuild     867.5
Ninja       801.2
Difference  -66.3 (-7.6%)

Minor Change
msbuild      43.0
Ninja        14.9
Difference  -28.1 (-64.4%)

No Changes
msbuild      23.0
Ninja         6.1
Difference  -16.9 (-73.5%)

3 years agomake.bat/cleanup: removed stray echo in make.bat
Ray Molenkamp [Fri, 25 May 2018 23:59:07 +0000 (17:59 -0600)]
make.bat/cleanup: removed stray echo in make.bat

3 years agomake.bat: refactor make.bat
Ray Molenkamp [Fri, 25 May 2018 23:57:13 +0000 (17:57 -0600)]
make.bat: refactor make.bat

make.bat was starting to become hard to maintain, this refactors it into separate batch files for each stage of the process.

-Improved detection of msvc2013/2015
-Improved failure handling.
-Added check for working msbuild and C++ compiler
-Added verbose switch to ease trouble shooting.
-Added Check if svn/cmake/git are in the path before using them
-Display the build configuration before asking to download the libraries
-Offer an option to recover an interrupted checkout of the libraries.
-Automatically check out sub-modules in-case they are missing.

3 years agoAdd number and memory size formatting throughout the UI
Diego Gangl [Fri, 25 May 2018 20:17:15 +0000 (22:17 +0200)]
Add number and memory size formatting throughout the UI

This commit adds number formatting (thousands separator) to the baking panel. It also adds a new function to format memory sizes (KB/GB/etc) and applies it to the baking panel and scene stats. The new function is unit tested.

Reviewers: Severin
Tags: #user_interface
Differential Revision: https://developer.blender.org/D1248

3 years ago[windows/make.bat] use a more reliable way of locating visual studio 2017.
Ray Molenkamp [Fri, 25 May 2018 16:24:01 +0000 (10:24 -0600)]
[windows/make.bat] use a more reliable way of locating visual studio 2017.

The registry hack we were using wasn't very reliable, the recommended way to locating visual studio is using vswhere (15.2 and up), using it also allows to switch between the regular and pre-release versions.

3 years agoWM: check modal handlers for keymap lookups
Campbell Barton [Fri, 25 May 2018 08:51:05 +0000 (10:51 +0200)]
WM: check modal handlers for keymap lookups

Keep in sync with 2.8x

3 years agoUI: fix assert
Campbell Barton [Fri, 25 May 2018 08:45:48 +0000 (10:45 +0200)]
UI: fix assert

Replace hard-coded button size check with UI_UNIT_X.

Caused icon-only buttons to have strings assigned based on UI-scale.

3 years ago3D View: add pixelsize function w/o UI scale
Campbell Barton [Fri, 25 May 2018 08:00:33 +0000 (10:00 +0200)]
3D View: add pixelsize function w/o UI scale

3 years agoCycles: Cleanup: Remove duplicated atan2f definition for OpenCL
Lukas Stockner [Thu, 24 May 2018 17:06:50 +0000 (19:06 +0200)]
Cycles: Cleanup: Remove duplicated atan2f definition for OpenCL

Turns out that atan2f was already defined for OpenCL.

3 years agoCycles Denoising: Don't use atomics in the accumulation kernel on CPUs
Lukas Stockner [Sun, 1 Apr 2018 00:10:27 +0000 (02:10 +0200)]
Cycles Denoising: Don't use atomics in the accumulation kernel on CPUs

The GPU kernel needs to use atomics for accumulation since all offsets are processed in
parallel, but on CPUs that's not the case, so we can disable them there for a considerable speedup.

3 years agoCycles/Compositor: Add arctan2 operation to the Math node
Lukas Stockner [Thu, 24 May 2018 00:51:41 +0000 (02:51 +0200)]
Cycles/Compositor: Add arctan2 operation to the Math node

The Math node currently has the normal atan() function, but for
actual angles this is fairly useless without additional nodes to handle the signs.

Since the node has two inputs anyways, it only makes sense to add an arctan2 option.

Reviewers: sergey, brecht

Differential Revision: https://developer.blender.org/D3430

3 years ago3D View: remove poll 3D view for copy/paste
Campbell Barton [Thu, 24 May 2018 14:40:33 +0000 (16:40 +0200)]
3D View: remove poll 3D view for copy/paste

These operators only need selected objects.

3 years agoFix T55034: Setting duplication group for multiple selected items only
Philipp Oeser [Mon, 14 May 2018 10:54:23 +0000 (12:54 +0200)]
Fix T55034: Setting duplication group for multiple selected items only
affects one item

UI editing multiple selected items missed the case of PROP_POINTER
properties

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D3373

3 years agoFix Extend property of Lasso select tool in Mask editor not working
Philipp Oeser [Sun, 13 May 2018 08:46:00 +0000 (10:46 +0200)]
Fix Extend property of Lasso select tool in Mask editor not working

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D3361

3 years agoFix T54336: Extend property of Lasso select tool in Node editor does not
Philipp Oeser [Sun, 13 May 2018 07:37:53 +0000 (09:37 +0200)]
Fix T54336: Extend property of Lasso select tool in Node editor does not
work

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D3360

3 years agoFix T55137: Compilation failing on non-x86-64 architectures
Lukas Stockner [Wed, 23 May 2018 23:41:18 +0000 (01:41 +0200)]
Fix T55137: Compilation failing on non-x86-64 architectures

Some conversion helper functions were (most likely by accident) contained
inside an ifdef for SSE2 support, so on e.g. ARM they would be undefined
and therefore cause compilation to fail.

3 years agoCleanup: strip trailing space from interface files
Campbell Barton [Wed, 23 May 2018 08:47:12 +0000 (10:47 +0200)]
Cleanup: strip trailing space from interface files

3 years agoFix incorrect size in aligned lockfree realloc
Campbell Barton [Wed, 23 May 2018 05:24:57 +0000 (07:24 +0200)]
Fix incorrect size in aligned lockfree realloc

Thanks to @alikendarfen for finding.

3 years agoblenderplayer: add stubs
Campbell Barton [Tue, 22 May 2018 15:56:56 +0000 (17:56 +0200)]
blenderplayer: add stubs

3 years agoFix T55093: Bisect + fill crash
Campbell Barton [Tue, 22 May 2018 15:22:29 +0000 (17:22 +0200)]
Fix T55093: Bisect + fill crash

3 years agoMemory allocator: use lockfree calls internally
Campbell Barton [Tue, 22 May 2018 06:45:47 +0000 (08:45 +0200)]
Memory allocator: use lockfree calls internally

Was already used in some areas.

3 years agoCMake: only include licences for enabled libs
Campbell Barton [Mon, 21 May 2018 16:41:59 +0000 (18:41 +0200)]
CMake: only include licences for enabled libs

3 years agoCleanup: use const for transform internal API
Campbell Barton [Mon, 21 May 2018 15:24:14 +0000 (17:24 +0200)]
Cleanup: use const for transform internal API

3 years agoRNA: support for PARM_OUTPUT & PARM_RNAPTR
Campbell Barton [Mon, 21 May 2018 10:34:11 +0000 (12:34 +0200)]
RNA: support for PARM_OUTPUT & PARM_RNAPTR

3 years agoFix too much memory usage for Cycles attribute map.
Brecht Van Lommel [Mon, 21 May 2018 09:08:03 +0000 (11:08 +0200)]
Fix too much memory usage for Cycles attribute map.

Thanks to Thomas Krebs for identifying the problem and solution.

3 years agoFix/workaround RNA build error in C++ API.
Brecht Van Lommel [Mon, 21 May 2018 09:13:56 +0000 (11:13 +0200)]
Fix/workaround RNA build error in C++ API.

It seems output parameter needs to be the last one.

3 years agoCleanup: correct variable names
Campbell Barton [Mon, 21 May 2018 08:53:50 +0000 (10:53 +0200)]
Cleanup: correct variable names

3 years agoWM: utility to find a keymap item from an operator
Campbell Barton [Mon, 21 May 2018 08:33:27 +0000 (10:33 +0200)]
WM: utility to find a keymap item from an operator

Also RNA access to WM_keyconfig_update,
needed when generating dynamic keymaps used in menus immediately after.

3 years agoCycles tests: move to render/ folder, to share with Eevee.
Brecht Van Lommel [Fri, 18 May 2018 14:46:48 +0000 (16:46 +0200)]
Cycles tests: move to render/ folder, to share with Eevee.

3 years agoCMake: Add WITH_COMPILER_ASAN option
Campbell Barton [Fri, 18 May 2018 13:21:18 +0000 (15:21 +0200)]
CMake: Add WITH_COMPILER_ASAN option

This supports easy toggling of Address Sanitizer.

3 years agoCleanup: remove deprecated definitions
Campbell Barton [Fri, 18 May 2018 12:26:02 +0000 (14:26 +0200)]
Cleanup: remove deprecated definitions

3 years agoFix T55115: crash when iterating SmokeDomainSettings color_grid property
Philipp Oeser [Fri, 18 May 2018 10:58:46 +0000 (12:58 +0200)]
Fix T55115: crash when iterating SmokeDomainSettings color_grid property
through python

3 years agoFix crash drawing polygon curves
Campbell Barton [Fri, 18 May 2018 12:23:53 +0000 (14:23 +0200)]
Fix crash drawing polygon curves

3 years agoAdd missing header
Campbell Barton [Fri, 18 May 2018 11:43:30 +0000 (13:43 +0200)]
Add missing header

3 years agoLogging: add --show-log-backtrace
Campbell Barton [Fri, 18 May 2018 09:00:47 +0000 (11:00 +0200)]
Logging: add --show-log-backtrace

Useful in debug builds to see a functions callers.

3 years agoColor: Assume Rec 709 in remaining comp nodes
Aaron Carlisle [Thu, 17 May 2018 21:20:32 +0000 (17:20 -0400)]
Color: Assume Rec 709 in remaining comp nodes

Part of T54798

3 years agoRNA: move enums to rna_rna.c
Campbell Barton [Thu, 17 May 2018 17:10:45 +0000 (19:10 +0200)]
RNA: move enums to rna_rna.c

Needed for use in rna non runtime code.

3 years agomakesrna: error check from 2.8
Campbell Barton [Thu, 17 May 2018 17:05:46 +0000 (19:05 +0200)]
makesrna: error check from 2.8

3 years agoFix T55032: Redo w/ file saved in edit-mode failed
Campbell Barton [Tue, 15 May 2018 17:30:59 +0000 (19:30 +0200)]
Fix T55032: Redo w/ file saved in edit-mode failed

It's important edit-mode has a step stored for redo to work,
file load now ensures this in a generic way.

3 years agoFix assert using '//' on an unsaved file
Campbell Barton [Tue, 15 May 2018 15:27:36 +0000 (17:27 +0200)]
Fix assert using '//' on an unsaved file

Annoying for debug builds.

3 years agoCleanup: last spacetype enum name
Campbell Barton [Tue, 15 May 2018 09:12:49 +0000 (11:12 +0200)]
Cleanup: last spacetype enum name

3 years agoUndo System: remove nested edit-mode undo calls
Campbell Barton [Tue, 15 May 2018 08:02:01 +0000 (10:02 +0200)]
Undo System: remove nested edit-mode undo calls

Regression in recent undo system changes,
This caused T55048.

When each mode had its own undo stack it was important
to initialize it when entering edit-mode.

3 years agoFix BMesh bisect not flagging dirty indices
Campbell Barton [Tue, 15 May 2018 07:04:12 +0000 (09:04 +0200)]
Fix BMesh bisect not flagging dirty indices

3 years agoCleanup: quiet GCC -Wtype-limits
Campbell Barton [Mon, 14 May 2018 06:58:09 +0000 (08:58 +0200)]
Cleanup: quiet GCC -Wtype-limits

While the warning can normally be disabled, we don't have have as much
control of warnings when macros are used.

3 years agoBLI_utildefines: re-ordering array delete macro
Campbell Barton [Mon, 14 May 2018 05:37:17 +0000 (07:37 +0200)]
BLI_utildefines: re-ordering array delete macro

3 years agoCleanup: trailing space
Campbell Barton [Sun, 13 May 2018 04:44:03 +0000 (06:44 +0200)]
Cleanup: trailing space

3 years agoCleanup: modifier arg wrapping
Campbell Barton [Sat, 12 May 2018 06:04:56 +0000 (08:04 +0200)]
Cleanup: modifier arg wrapping

3 years agoPlatform: macOS. Allow building on directory with whitespace (For example /Volumes...
Arto Kitula [Fri, 11 May 2018 18:56:13 +0000 (21:56 +0300)]
Platform: macOS. Allow building on directory with whitespace (For example /Volumes/External HD/blender-build)

3 years agoEditMesh: remove duplicate rip macro
Campbell Barton [Fri, 11 May 2018 18:02:12 +0000 (20:02 +0200)]
EditMesh: remove duplicate rip macro

Change the fill setting in the keymap,
this allows tool access the macro with either setting.

3 years agoWM: initialize last used macro properties
Campbell Barton [Fri, 11 May 2018 18:01:51 +0000 (20:01 +0200)]
WM: initialize last used macro properties

3 years agoFix (unreported) broken freeing code for Sequencer.
Bastien Montagne [Fri, 11 May 2018 09:21:30 +0000 (11:21 +0200)]
Fix (unreported) broken freeing code for Sequencer.

Freeing sequencer would always do usercount, which is now forbidden when
called from main ID freeing code.

Annoying in 2.7x, much more critical issue in 2.8!

Also, moved RNA sequencer API functions to proper rna_scene_api.c file.

3 years agoFix (unreported) load image code calling icin/preview update from non-Main thread.
Bastien Montagne [Fri, 11 May 2018 08:48:04 +0000 (10:48 +0200)]
Fix (unreported) load image code calling icin/preview update from non-Main thread.

Icin/preview only works in main thread, while image loading can be done
from others too... This could have generated random crashes and such.

3 years agoFix broken 'check/validate libs' code with indirect libs.
Bastien Montagne [Wed, 9 May 2018 13:46:22 +0000 (15:46 +0200)]
Fix broken 'check/validate libs' code with indirect libs.

Readcode always set relative paths of indirectly linked libs relative to
*current* .blend file, not to the library using it.

But BKE_library_filepath_set was then setting them relative to their
parent library, breaking checking code (and saved files even :((( ).

3 years agoFix T54992: Lattice modifier on another Lattice object does not take the
Philipp Oeser [Tue, 8 May 2018 09:05:42 +0000 (11:05 +0200)]
Fix T54992: Lattice modifier on another Lattice object does not take the
Influence vertexgroup into account

3 years agoFix T54997: simple typo in property description
Philipp Oeser [Wed, 9 May 2018 12:26:47 +0000 (14:26 +0200)]
Fix T54997: simple typo in property description

3 years agoFix (unreported) bug in BVHTree 'free tessfaces' flag setting.
Bastien Montagne [Wed, 9 May 2018 10:33:21 +0000 (12:33 +0200)]
Fix (unreported) bug in BVHTree 'free tessfaces' flag setting.

Could lead to atempt to free NULL pointer, and/or memory leak.

3 years agoMSVC: resolve near/far issue take2
Campbell Barton [Wed, 9 May 2018 09:20:12 +0000 (11:20 +0200)]
MSVC: resolve near/far issue take2

Previous fix failed w/ compositor,
tested on MSVC2015, full build.

3 years agoMSVC: remove hack for near/far name collision
Campbell Barton [Wed, 9 May 2018 08:00:55 +0000 (10:00 +0200)]
MSVC: remove hack for near/far name collision

windows headers define these, conflicting w/ View3D.near/far.

3 years agoColor: Combine/Separate YCbCrA node default to rec. 709
Aaron Carlisle [Wed, 9 May 2018 02:24:58 +0000 (22:24 -0400)]
Color: Combine/Separate YCbCrA node default to rec. 709

This commit is part of T54798

Differential Revision: https://developer.blender.org/D3183

3 years agoCleanup: includes
Campbell Barton [Tue, 8 May 2018 16:01:47 +0000 (18:01 +0200)]
Cleanup: includes

3 years agoCleanup: move mesh conversion into own function
Campbell Barton [Tue, 8 May 2018 15:44:54 +0000 (17:44 +0200)]
Cleanup: move mesh conversion into own function

3 years agoFix building with latest versions of ffmpeg.
Bastien Montagne [Tue, 8 May 2018 14:00:52 +0000 (16:00 +0200)]
Fix building with latest versions of ffmpeg.

Some years-old deprecated stuff has now been removed.

Correct solution is probably to use valid defines etc. in own code, but
this is more FFMEPG maintainer task (since it also may change how old
FFMPEG we do support...).

3 years agoFix (unreported) bloody modifiers messing with ID user count in copy.
Bastien Montagne [Tue, 8 May 2018 13:27:10 +0000 (15:27 +0200)]
Fix (unreported) bloody modifiers messing with ID user count in copy.

User count of IDs is handled by higher-level, generic function,
low-level copydata functions *MUST NOT* touch them anymore, ever!

3 years agoCleanup: Nuke empty dummy wrappers around modifier_copyData_generic().
Bastien Montagne [Tue, 8 May 2018 13:04:10 +0000 (15:04 +0200)]
Cleanup: Nuke empty dummy wrappers around modifier_copyData_generic().

This also changes signature of modifier copy callback, first (source)
parameter is now a const, which is saner anyway!