blender.git
9 months agoCleanup: name macros w/ matching BEGIN/END
Campbell Barton [Fri, 30 Nov 2018 04:08:47 +0000 (15:08 +1100)]
Cleanup: name macros w/ matching BEGIN/END

9 months agoCleanup: duplicate include
Campbell Barton [Fri, 30 Nov 2018 03:21:28 +0000 (14:21 +1100)]
Cleanup: duplicate include

9 months agoCleanup: style
Campbell Barton [Fri, 30 Nov 2018 03:20:41 +0000 (14:20 +1100)]
Cleanup: style

9 months agoCleanup: unused return arg
Campbell Barton [Fri, 30 Nov 2018 02:21:12 +0000 (13:21 +1100)]
Cleanup: unused return arg

9 months agoFix T58183: crash with CPU + GPU rendering after profiling changes.
Brecht Van Lommel [Thu, 29 Nov 2018 22:30:17 +0000 (23:30 +0100)]
Fix T58183: crash with CPU + GPU rendering after profiling changes.

Multi-device was not passing along profiler to the CPU.

9 months agoCleanup: trailing space
Campbell Barton [Thu, 29 Nov 2018 21:38:25 +0000 (08:38 +1100)]
Cleanup: trailing space

9 months agoadd: visual studio Compiler warning (order of attribute init in c++ constructors)
Gaia Clary [Thu, 29 Nov 2018 15:56:33 +0000 (16:56 +0100)]
add: visual studio Compiler warning (order of attribute init in c++ constructors)

9 months agoFix internal compiler error when building with VS 2017 (15.9.3).
Brecht Van Lommel [Thu, 29 Nov 2018 15:41:10 +0000 (16:41 +0100)]
Fix internal compiler error when building with VS 2017 (15.9.3).

It doesn't like alignment for function arguments, and I don't think this
alignment is needed.

Solution found by Ray Molenkamp.

9 months agoAtomic: Avoid conflicts with definitions in other areas
Sergey Sharybin [Thu, 29 Nov 2018 08:33:50 +0000 (09:33 +0100)]
Atomic: Avoid conflicts with definitions in other areas

While atomics library was trying to use "user-space" defined
LIKELY() and UNLIKELY(), this is not always true that user
code was checking for those macro coming from an unrelated
area.

9 months agoCleanup: correct typo, no need for ./ prefix
Campbell Barton [Thu, 29 Nov 2018 01:53:48 +0000 (12:53 +1100)]
Cleanup: correct typo, no need for ./ prefix

9 months agoFix leak in CPU brand check
Campbell Barton [Wed, 28 Nov 2018 21:22:15 +0000 (08:22 +1100)]
Fix leak in CPU brand check

9 months agoCycles: Add sample-based runtime profiler that measures time spent in various parts...
Lukas Stockner [Thu, 29 Nov 2018 01:06:30 +0000 (02:06 +0100)]
Cycles: Add sample-based runtime profiler that measures time spent in various parts of the CPU kernel

This commit adds a sample-based profiler that runs during CPU rendering and collects statistics on time spent in different parts of the kernel (ray intersection, shader evaluation etc.) as well as time spent per material and object.

The results are currently not exposed in the user interface or per Python yet, to see the stats on the console pass the "--cycles-print-stats" argument to Cycles (e.g. "./blender -- --cycles-print-stats").

Unfortunately, there is no clear way to extend this functionality to CUDA or OpenCL, so it is CPU-only for now.

Reviewers: brecht, sergey, swerner

Reviewed By: brecht, swerner

Differential Revision: https://developer.blender.org/D3892

9 months agoCMake: update checker
Campbell Barton [Wed, 28 Nov 2018 21:49:50 +0000 (08:49 +1100)]
CMake: update checker

Support skipping cmake files

9 months agoMore fixes for NUMA on macOS
Sergey Sharybin [Wed, 28 Nov 2018 17:05:35 +0000 (18:05 +0100)]
More fixes for NUMA on macOS

9 months agoFix compilation error on macOS
Sergey Sharybin [Wed, 28 Nov 2018 16:57:04 +0000 (17:57 +0100)]
Fix compilation error on macOS

9 months agoFix compilation error on 32bit Windows
Sergey Sharybin [Wed, 28 Nov 2018 16:54:05 +0000 (17:54 +0100)]
Fix compilation error on 32bit Windows

9 months agoFix building gtests and bplayer after recent NumaAPI addition.
Bastien Montagne [Wed, 28 Nov 2018 15:50:02 +0000 (16:50 +0100)]
Fix building gtests and bplayer after recent NumaAPI addition.

Seriously... like, seriously...

9 months agoTweaks for threading schedule for Threadripper2 and EPYC
Sergey Sharybin [Tue, 27 Nov 2018 17:21:43 +0000 (18:21 +0100)]
Tweaks for threading schedule for Threadripper2 and EPYC

The idea is to make main thread and job threads to be scheduled
on CPU dies which has direct access to memory (those are NUMA
nodes 0 and 2).

We also do this for new EPYC CPUs since their NUMA nodes 1 and 3
do have access but only to a higher range DDR slots. By preferring
nodes 0 and 2 on EPYC we make it so users with partially filled
DDR slots has fast memory access.

One thing which is not really solved yet is localization of
memory allocation: we do not guarantee that memory is allocated
on the closest to the NUMA node DDR slot and hope that memory
manager of OS is acting in favor of us.

9 months agoAdd utility function to query CPU brand string
Sergey Sharybin [Tue, 27 Nov 2018 16:28:36 +0000 (17:28 +0100)]
Add utility function to query CPU brand string

9 months agoAdd cross-platform NUMA library
Sergey Sharybin [Tue, 27 Nov 2018 16:13:54 +0000 (17:13 +0100)]
Add cross-platform NUMA library

Makes it simple to use NUMA libraries on various platforms.

9 months agoFix T56872: Edge slide gives invalid normals
Campbell Barton [Tue, 27 Nov 2018 00:39:51 +0000 (11:39 +1100)]
Fix T56872: Edge slide gives invalid normals

Add the ability to skip overwriting normals.

9 months agoCMake: Remove Cycles specific OpenSubdiv options
Sergey Sharybin [Mon, 26 Nov 2018 10:41:38 +0000 (11:41 +0100)]
CMake: Remove Cycles specific OpenSubdiv options

Just use one flag which enables OpenSubdiv globally for all the
areas of Blender.

9 months agoFix T58006: smart UV project island margin should not use length units.
Brecht Van Lommel [Sat, 24 Nov 2018 22:01:50 +0000 (23:01 +0100)]
Fix T58006: smart UV project island margin should not use length units.

This distance is in UV space, not world space.

9 months agoSequencer: remove unnecessary limit on transform rotation.
Brecht Van Lommel [Fri, 9 Nov 2018 09:05:06 +0000 (10:05 +0100)]
Sequencer: remove unnecessary limit on transform rotation.

9 months agoFix X11 tablet pen and eraser distinction being wrong in some cases.
Brecht Van Lommel [Sat, 24 Nov 2018 22:21:13 +0000 (23:21 +0100)]
Fix X11 tablet pen and eraser distinction being wrong in some cases.

This extends the earlier fix to use the latest logic from Wine's wintab.c,
to better handle eraser detection.

9 months agoCleanup: remove unused file
Campbell Barton [Sat, 24 Nov 2018 21:05:42 +0000 (08:05 +1100)]
Cleanup: remove unused file

9 months agoCleanup: trailing space
Campbell Barton [Sat, 24 Nov 2018 21:01:14 +0000 (08:01 +1100)]
Cleanup: trailing space

9 months agoFix penpressure for tablets that use libinput on linux
Jens Verwiebe [Sat, 24 Nov 2018 17:23:57 +0000 (18:23 +0100)]
Fix penpressure for tablets that use libinput on linux

9 months agoCycles: Fixed a warning.
Stefan Werner [Fri, 23 Nov 2018 12:47:25 +0000 (13:47 +0100)]
Cycles: Fixed a warning.

9 months agoCycles: Improved robustness of hair motion blur.
Stefan Werner [Fri, 23 Nov 2018 12:21:55 +0000 (13:21 +0100)]
Cycles: Improved robustness of hair motion blur.

In some instances, the number of control vertices of a hair could change mid-frame.
Cycles would then be unable to calculate proper motion blur for those hairs. This adds
interpolated CVs to fill in for the missing data. While this will not necessarily result in
a fully accurate reconstruction of the guide hair, it preserves motion blur instead of disabling it.

Reviewers: #cycles, sergey

Reviewed By: #cycles, sergey

Subscribers: sergey, brecht, #cycles

Tags: #cycles

Differential Revision: https://developer.blender.org/D3695

9 months agoFix T57998: crash at start with jemalloc package on some Linux distributions.
Brecht Van Lommel [Fri, 23 Nov 2018 10:24:04 +0000 (11:24 +0100)]
Fix T57998: crash at start with jemalloc package on some Linux distributions.

The jemalloc library must be ahead of pthread in linking order, so jemalloc
can find the pthread symbols for its background thread.

10 months agoFix T57989: File loaded as startup
Campbell Barton [Thu, 22 Nov 2018 03:57:41 +0000 (14:57 +1100)]
Fix T57989: File loaded as startup

The file contents was used to check if the file was a startup file.

Now pass in an argument from startup loading code instead.

10 months agoFix T57811: Render crashes in certain scenes when AO Bounces are used
Sergey Sharybin [Wed, 21 Nov 2018 13:17:26 +0000 (14:17 +0100)]
Fix T57811: Render crashes in certain scenes when AO Bounces are used

10 months agoCycles: Cleanup, use utility function
Sergey Sharybin [Wed, 21 Nov 2018 12:51:18 +0000 (13:51 +0100)]
Cycles: Cleanup, use utility function

Replaces inlined platform-specific code.

10 months agoCycles: Cleanup, reduce indentation level
Sergey Sharybin [Wed, 21 Nov 2018 11:23:54 +0000 (12:23 +0100)]
Cycles: Cleanup, reduce indentation level

10 months agoCycles: Cleanup, comments and dead code
Sergey Sharybin [Wed, 21 Nov 2018 10:33:11 +0000 (11:33 +0100)]
Cycles: Cleanup, comments and dead code

10 months agoCycles: Cleanup, CUDA code path is not possible inside AVX2
Sergey Sharybin [Wed, 21 Nov 2018 10:28:49 +0000 (11:28 +0100)]
Cycles: Cleanup, CUDA code path is not possible inside AVX2

10 months agoFix T57923: Freeze in mesh vnors computation code with some degenerated geometry.
Bastien Montagne [Tue, 20 Nov 2018 16:54:48 +0000 (17:54 +0100)]
Fix T57923: Freeze in mesh vnors computation code with some degenerated geometry.

Second part of the fix: do not try at all to compute normals in degenerated
geometry. Just loss of time and potential issues later with weird
invalid computed values.

10 months agoFix T57923: Freeze in mesh vnors computation code with some degenerated geometry.
Bastien Montagne [Tue, 20 Nov 2018 16:52:21 +0000 (17:52 +0100)]
Fix T57923: Freeze in mesh vnors computation code with some degenerated geometry.

Fix first part of it, the freeze itself being caused by float NAN values
never comparing equal to anything, not even themselves.

10 months agoTask scheduler: Optimize parallel loop over lists
Sergey Sharybin [Tue, 20 Nov 2018 11:17:03 +0000 (12:17 +0100)]
Task scheduler: Optimize parallel loop over lists

The goal is to address performance regression when going from
few threads to 10s of threads. On a systems with more than 32
CPU threads the benefit of threaded loop was actually harmful.

There are following tweaks now:

- The chunk size is adaptive for the number of threads, which
  minimizes scheduling overhead.

- The number of tasks is adaptive to the list size and chunk
  size.

Here comes performance comparison on the production shot:

 Number of threads        DEG time before        DEG time after
       44                     0.09                   0.02
       32                     0.055                  0.025
       16                     0.025                  0.025
       8                      0.035                  0.033

10 months agoRemoved superfluous NULL check
Sybren A. Stüvel [Tue, 20 Nov 2018 09:46:17 +0000 (10:46 +0100)]
Removed superfluous NULL check

10 months agoAdded MovieClip.fps read-only property to RNA
Sybren A. Stüvel [Tue, 20 Nov 2018 09:32:24 +0000 (10:32 +0100)]
Added MovieClip.fps read-only property to RNA

This makes it possible for a Python script that loads a MovieClip into the
clip editor to also change the scene frame rate to match.

10 months agoLinux: list GVFS mount points
Roel Koster [Sun, 18 Nov 2018 21:34:04 +0000 (08:34 +1100)]
Linux: list GVFS mount points

10 months agoCall PRE_VIEW and POST_VIEW draw callbacks in movie clip editor
Sybren A. Stüvel [Fri, 16 Nov 2018 12:58:11 +0000 (13:58 +0100)]
Call PRE_VIEW and POST_VIEW draw callbacks in movie clip editor

10 months agoCycles: Cleanup, code style
Sergey Sharybin [Thu, 15 Nov 2018 16:16:40 +0000 (17:16 +0100)]
Cycles: Cleanup, code style

10 months agoCleanup: Comments
Sergey Sharybin [Thu, 15 Nov 2018 15:28:07 +0000 (16:28 +0100)]
Cleanup: Comments

10 months agoCleanup: comment block tabs
Campbell Barton [Wed, 14 Nov 2018 01:53:15 +0000 (12:53 +1100)]
Cleanup: comment block tabs

10 months agoCleanup: naming for paint modes
Campbell Barton [Wed, 14 Nov 2018 00:20:08 +0000 (11:20 +1100)]
Cleanup: naming for paint modes

- Rename ePaint* -> PAINT_MODE_*.
- Use PAINT_OVERLAY_ prefix for eOverlayControlFlags.

10 months agoWM: enforce descriptions being NULL or defined
Campbell Barton [Tue, 13 Nov 2018 22:47:23 +0000 (09:47 +1100)]
WM: enforce descriptions being NULL or defined

Without this bugs slip through that don't null check the descriptions
since many were set to empty strings.

10 months agoCleanup: python doc-strings
Campbell Barton [Tue, 13 Nov 2018 22:04:24 +0000 (09:04 +1100)]
Cleanup: python doc-strings

Indentation & trailing space.

10 months agoCleanup: use lowercase 2d/3d in function names
Campbell Barton [Tue, 13 Nov 2018 03:21:42 +0000 (14:21 +1100)]
Cleanup: use lowercase 2d/3d in function names

10 months agoWM: avoid string replace w/ appconfig-activate
Campbell Barton [Mon, 12 Nov 2018 19:59:23 +0000 (06:59 +1100)]
WM: avoid string replace w/ appconfig-activate

Better construct an exact path, this would fail if the path exists
multiple times in the string.

10 months agoCycles: Fix/workaround for gcc-7.2
Sergey Sharybin [Mon, 12 Nov 2018 11:10:33 +0000 (12:10 +0100)]
Cycles: Fix/workaround for gcc-7.2

For some reason when building with gcc-7.2 (which is default
in previous Ubuntu LTS) the guarded allocator is not being
properly instantiated.

Doesn't happen with newer version of gcc-7 which is 7.3, and
also doesn't happen with gcc-6 and gcc-8.

Would be nice to know what is wrong, but for the time being
committing workaround which keeps Blender users happy.

10 months agoCycles: Proper comment for closing header guard
Sergey Sharybin [Mon, 12 Nov 2018 10:02:10 +0000 (11:02 +0100)]
Cycles: Proper comment for closing header guard

10 months agoPyAPI: update keyword list
Campbell Barton [Sat, 10 Nov 2018 22:37:26 +0000 (09:37 +1100)]
PyAPI: update keyword list

10 months agoBMesh: backport minor changes from 2.8
Campbell Barton [Sat, 10 Nov 2018 08:54:49 +0000 (19:54 +1100)]
BMesh: backport minor changes from 2.8

10 months agoPyAPI: add imports arg to BPY_execute_string
Campbell Barton [Fri, 9 Nov 2018 23:55:04 +0000 (10:55 +1100)]
PyAPI: add imports arg to BPY_execute_string

Allows for avoiding `__import__` in expressions,
was already supported for BPY_execute_string_as_* API calls.

10 months agoRevert "Cycles: Cleanup, move Embree BVH logic to own file"
Sergey Sharybin [Fri, 9 Nov 2018 16:54:09 +0000 (17:54 +0100)]
Revert "Cycles: Cleanup, move Embree BVH logic to own file"

While we shouldn't have logic in an entry point, and since one should
not be making typos when moving lines around, there is bigger entanglement
issue with BVH host code using kernel function. This is bad violation,
but is tricky to get solved moments before the weekly.

In order to keep things in a (less) broken state than before own cleanup
reverting the changes.

This reverts commit 2bad10be96540ff50a149230d656e599775b3f47.
This reverts commit ddabb21d0584e9874e8e5c62c04abe496ec7334b

10 months agoCycles: Cleanup, remove unused method declaration
Sergey Sharybin [Fri, 9 Nov 2018 14:21:19 +0000 (15:21 +0100)]
Cycles: Cleanup, remove unused method declaration

Was never defined. If it's really needed, consider using `const string&`.

10 months agoCycles; Cleanup, line length
Sergey Sharybin [Fri, 9 Nov 2018 11:31:46 +0000 (12:31 +0100)]
Cycles; Cleanup, line length

There are some more sanitization which would be cool to be done
in the neighbourhood of those functions, but that could also happen
later.

10 months agoCycles: Cleanup, move Embree BVH logic to own file
Sergey Sharybin [Fri, 9 Nov 2018 11:28:55 +0000 (12:28 +0100)]
Cycles: Cleanup, move Embree BVH logic to own file

There is no way we can keep generic entry point functions easy to
follow if we start adding actual logic in them.

10 months agoCycles: Cleanup, indentation in preprocessor
Sergey Sharybin [Fri, 9 Nov 2018 11:12:11 +0000 (12:12 +0100)]
Cycles: Cleanup, indentation in preprocessor

10 months agoCycles: Cleanup, indentation
Sergey Sharybin [Fri, 9 Nov 2018 11:10:48 +0000 (12:10 +0100)]
Cycles: Cleanup, indentation

10 months agoCycles: Cleanup, space after (void)
Sergey Sharybin [Fri, 9 Nov 2018 11:08:51 +0000 (12:08 +0100)]
Cycles: Cleanup, space after (void)

It was used in like 95% of places.

10 months agoCycles: Cleanup, don't use strict C prototypes
Sergey Sharybin [Fri, 9 Nov 2018 11:01:38 +0000 (12:01 +0100)]
Cycles: Cleanup, don't use strict C prototypes

Those are more like a legacy of language, which is not
needed in C++.

10 months agoCycles: Cleanup, split array from vector
Sergey Sharybin [Fri, 9 Nov 2018 10:54:24 +0000 (11:54 +0100)]
Cycles: Cleanup, split array from vector

Those are similar but different types, no reason to keep
their definitions in a single file.

10 months agoCycles: Cleanup, some documentation
Sergey Sharybin [Fri, 9 Nov 2018 10:46:09 +0000 (11:46 +0100)]
Cycles: Cleanup, some documentation

10 months agoCycles: Cleanup, remove unneeded manual constructors specification
Sergey Sharybin [Fri, 9 Nov 2018 10:44:33 +0000 (11:44 +0100)]
Cycles: Cleanup, remove unneeded manual constructors specification

10 months agoCycles: Cleanup, remove unneeded method from vector
Sergey Sharybin [Fri, 9 Nov 2018 10:37:56 +0000 (11:37 +0100)]
Cycles: Cleanup, remove unneeded method from vector

Since we've defaulted to C++11, no need to override this
method manually anymore.

10 months agoCycles: Cleanup, spacing after preprocessor
Sergey Sharybin [Fri, 9 Nov 2018 10:34:54 +0000 (11:34 +0100)]
Cycles: Cleanup, spacing after preprocessor

It is supposed to be two spaces before comment stating which if
else/endif statements corresponds to. Was mainly violated in the
header guards.

10 months agoreadme: use name 'macOS'
Campbell Barton [Fri, 9 Nov 2018 00:49:49 +0000 (11:49 +1100)]
readme: use name 'macOS'

10 months agoFix build on 32bit after Embree changes.
Brecht Van Lommel [Thu, 8 Nov 2018 13:48:54 +0000 (14:48 +0100)]
Fix build on 32bit after Embree changes.

10 months agobuild: add proper embree support to platform_win32.cmake
Ray Molenkamp [Thu, 8 Nov 2018 02:34:49 +0000 (19:34 -0700)]
build: add proper embree support to platform_win32.cmake

made the use of findpackage optional and add support for debug builds

10 months agobuild_environment: add debug libs for embree on windows
Ray Molenkamp [Thu, 8 Nov 2018 02:33:07 +0000 (19:33 -0700)]
build_environment: add debug libs for embree on windows

10 months agobuild_deps_windows: add option to to only create project files.
Ray Molenkamp [Thu, 8 Nov 2018 02:18:53 +0000 (19:18 -0700)]
build_deps_windows: add option to to only create project files.

10 months agoCycles: Write Cryptomatte metadata according to the specification
Lukas Stockner [Wed, 7 Nov 2018 03:05:47 +0000 (04:05 +0100)]
Cycles: Write Cryptomatte metadata according to the specification

Reviewers: brecht, sergey, swerner

Subscribers: creamsurfer, Tanguy, Noss, SteffenD

Differential Revision: https://developer.blender.org/D3862

10 months agoRender API: Support arbitrary length for custom image metadata fields
Lukas Stockner [Thu, 8 Nov 2018 00:05:55 +0000 (01:05 +0100)]
Render API: Support arbitrary length for custom image metadata fields

10 months agoCleanup: minor simplification to user-addon check
Campbell Barton [Wed, 7 Nov 2018 22:54:13 +0000 (09:54 +1100)]
Cleanup: minor simplification to user-addon check

10 months agoinstall_deps: Added optional build of Embree to install_deps.sh, turned off by default.
Stefan Werner [Wed, 7 Nov 2018 19:36:03 +0000 (20:36 +0100)]
install_deps: Added optional build of Embree to install_deps.sh, turned off by default.

10 months agoCycles: Rearranged macros in kernel_types.h to fix Embree build.
Stefan Werner [Wed, 7 Nov 2018 14:20:24 +0000 (15:20 +0100)]
Cycles: Rearranged macros in kernel_types.h to fix Embree build.

10 months agoFix build with OSL, remove unneeded file after Embree changes.
Brecht Van Lommel [Wed, 7 Nov 2018 12:29:20 +0000 (13:29 +0100)]
Fix build with OSL, remove unneeded file after Embree changes.

10 months agoCycles: Fixed a warning.
Stefan Werner [Wed, 7 Nov 2018 13:04:22 +0000 (14:04 +0100)]
Cycles: Fixed a warning.

10 months agoCycles: Fixed OpenCL render after the Embree checkin.
Stefan Werner [Wed, 7 Nov 2018 12:53:56 +0000 (13:53 +0100)]
Cycles: Fixed OpenCL render after the Embree checkin.

10 months agoCycles: Added Embree as BVH option for CPU renders.
Stefan Werner [Wed, 7 Nov 2018 11:58:12 +0000 (12:58 +0100)]
Cycles: Added Embree as BVH option for CPU renders.

Note that this is turned off by default and must be enabled at build time with the CMake WITH_CYCLES_EMBREE flag.
Embree must be built as a static library with ray masking turned on, the `make deps` scripts have been updated accordingly.
There, Embree is off by default too and must be enabled with the WITH_EMBREE flag.

Using Embree allows for much faster rendering of deformation motion blur while reducing the memory footprint.

TODO: GPU implementation, deduplication of data, leveraging more of Embrees features (e.g. tessellation cache).

Differential Revision: https://developer.blender.org/D3682

10 months agoCleanup: use STRPREFIX for mount point checks
Campbell Barton [Wed, 7 Nov 2018 02:37:42 +0000 (13:37 +1100)]
Cleanup: use STRPREFIX for mount point checks

From D3846 by @kostex

10 months agoCleanup: use BLI_compiler_compat.h for BLI_INLINE
Campbell Barton [Wed, 7 Nov 2018 01:17:58 +0000 (12:17 +1100)]
Cleanup: use BLI_compiler_compat.h for BLI_INLINE

10 months agoCleanup: renmae ePaintTexture(Projective) -> 3D
Campbell Barton [Wed, 7 Nov 2018 00:44:51 +0000 (11:44 +1100)]
Cleanup: renmae ePaintTexture(Projective) -> 3D

Matches ePaintTexture2D, less verbose.

10 months agoFix T56055: color discrepancy between viewport and render for Filmic transforms.
Troy Sobotka [Tue, 6 Nov 2018 18:35:50 +0000 (19:35 +0100)]
Fix T56055: color discrepancy between viewport and render for Filmic transforms.

10 months agoFix T57388: Blender Internal + Freestyle viewport render wrongly using FSAA.
Irie Shinsuke [Sun, 4 Nov 2018 19:34:02 +0000 (20:34 +0100)]
Fix T57388: Blender Internal + Freestyle viewport render wrongly using FSAA.

10 months agoFix assert rendering hair tests on some systems.
Brecht Van Lommel [Sun, 4 Nov 2018 19:25:57 +0000 (20:25 +0100)]
Fix assert rendering hair tests on some systems.

10 months agoFix assert rendering with denoising, after recent changes.
Brecht Van Lommel [Sun, 4 Nov 2018 19:13:55 +0000 (20:13 +0100)]
Fix assert rendering with denoising, after recent changes.

10 months agoFix ghash masking out upper bits on 64bit systems
Campbell Barton [Sun, 4 Nov 2018 05:44:28 +0000 (16:44 +1100)]
Fix ghash masking out upper bits on 64bit systems

The code this was taken from assumes a 'size_t' result,
which isn't the case here.

In practice the bucket distribution wasn't bad,
even so this was a nop so best fix.

10 months agoFix T57529: 2D image paint fill tool not taking into account alpha.
Brecht Van Lommel [Thu, 1 Nov 2018 11:06:04 +0000 (12:06 +0100)]
Fix T57529: 2D image paint fill tool not taking into account alpha.

10 months agoCleanup: move progress utility module into bpy_extras
Campbell Barton [Thu, 1 Nov 2018 05:17:40 +0000 (16:17 +1100)]
Cleanup: move progress utility module into bpy_extras

Try avoid having too many toplevel modules with generic names.

10 months agoCycles: Fix wrong BVH used when disabling AVX2 in debug settings
Sergey Sharybin [Wed, 31 Oct 2018 10:46:52 +0000 (11:46 +0100)]
Cycles: Fix wrong BVH used when disabling AVX2 in debug settings

Mainly useful for debugging. Previously, when AVX2 was disabled
in the debug panel but BVH layout was kept on BVH8 nothing was
rendered.

Needed to make it so supported BVH layout mask for devices is
queried in "dynamic", so it is possible to use DebugFlags there.

10 months agomake.bat: fix unquoted variables.
Ray Molenkamp [Tue, 30 Oct 2018 23:36:36 +0000 (17:36 -0600)]
make.bat: fix unquoted variables.

causing build issues for some users.

10 months agoFix build error on Windows 32bit, alignment was wrong.
Brecht Van Lommel [Tue, 30 Oct 2018 10:39:44 +0000 (11:39 +0100)]
Fix build error on Windows 32bit, alignment was wrong.

10 months agoUI: add uiItemMenuFN which frees it's argument
Campbell Barton [Mon, 29 Oct 2018 23:46:29 +0000 (10:46 +1100)]
UI: add uiItemMenuFN which frees it's argument

10 months agoCycles: Support generating Denoising passes without actually denoising
Lukas Stockner [Mon, 29 Oct 2018 14:45:58 +0000 (15:45 +0100)]
Cycles: Support generating Denoising passes without actually denoising

Needed for the animation denoiser since the denoising filter is done separately there.

Reviewers: brecht, sergey

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D3833

10 months agoCycles: more detailed tooltips for cryptomatte options.
Brecht Van Lommel [Mon, 29 Oct 2018 12:05:29 +0000 (13:05 +0100)]
Cycles: more detailed tooltips for cryptomatte options.