4 months agoSequencer: Drag outside of sequence to initiate box select
Jacques Lucke [Tue, 28 May 2019 15:47:26 +0000 (17:47 +0200)]
Sequencer: Drag outside of sequence to initiate box select

4 months agoDRW: Fix issue introduce in removal of DRW_STATE_POINT
Clément Foucault [Tue, 28 May 2019 15:18:39 +0000 (17:18 +0200)]
DRW: Fix issue introduce in removal of DRW_STATE_POINT

Fix issue raised by mano-wii in rB97d22e12b521

Fix T65050 knife tool snapping indicator not visible

4 months agoCleanup: DRW: Codestyle
Clément Foucault [Tue, 28 May 2019 15:15:10 +0000 (17:15 +0200)]
Cleanup: DRW: Codestyle

4 months agoCleanup: GPU: Move program point size to GPU_state
Clément Foucault [Tue, 28 May 2019 15:14:22 +0000 (17:14 +0200)]
Cleanup: GPU: Move program point size to GPU_state

4 months agoFix T64005: GPencil clamping pixels do not always work
Antonioya [Tue, 28 May 2019 15:10:58 +0000 (17:10 +0200)]
Fix T64005: GPencil clamping pixels do not always work

4 months agoDepsgraph: Add query for whether graph is up to date
Sergey Sharybin [Tue, 28 May 2019 14:05:32 +0000 (16:05 +0200)]
Depsgraph: Add query for whether graph is up to date

Depsgraph: Only invoke callbacks when there are changes

Only affects when an evaluated dependency graph is requested via

Makes it cheap to call when there are no changes made to the graph

Transform: Ensure depsgraph is evaluated when needed

Fix based on D4455 from Campbell, utilizes some recently
introduced functions and allows to not have any extra checks
in the transform code.

Fixes T61904
Fixes T62135

Reviewers: brecht

Maniphest Tasks: T62135, T61904

Differential Revision:

4 months agoDepsgraph: Only invoke callbacks when there are changes
Sergey Sharybin [Tue, 28 May 2019 13:52:26 +0000 (15:52 +0200)]
Depsgraph: Only invoke callbacks when there are changes

Only affects when an evaluated dependency graph is requested via

Makes it cheap to call when there are no changes made to the graph

4 months agoDepsgraph: Add query for whether graph is up to date
Sergey Sharybin [Tue, 28 May 2019 13:42:08 +0000 (15:42 +0200)]
Depsgraph: Add query for whether graph is up to date

4 months agoCleanup: use doxy comments for wmOperatoType.flag
Campbell Barton [Tue, 28 May 2019 15:00:16 +0000 (01:00 +1000)]
Cleanup: use doxy comments for wmOperatoType.flag

4 months agoCleanup: use WM_ prefix for cursor enum
Campbell Barton [Tue, 28 May 2019 15:03:26 +0000 (01:03 +1000)]
Cleanup: use WM_ prefix for cursor enum

4 months agoWM: support X/Y axis cursor wrapping
Campbell Barton [Tue, 28 May 2019 14:48:48 +0000 (00:48 +1000)]
WM: support X/Y axis cursor wrapping

Operator flags to wrap on a single axis.

D4865 by @Gvgeo with updates.

Resolves T64585

4 months agoCleanup: clang-format
Campbell Barton [Tue, 28 May 2019 14:24:16 +0000 (00:24 +1000)]
Cleanup: clang-format

4 months agoFix T64829: Active point of Curve objects is not displayed correctly
Philipp Oeser [Fri, 24 May 2019 10:10:27 +0000 (12:10 +0200)]
Fix T64829: Active point of Curve objects is not displayed correctly

three issues here:
- when curves had multiple nurbs, the active vert is per nurb
[curve_create_edit_data_and_handles() wasnt taking that into account]
- code could go wrong when points where hidden
- upon selection, tag curve ID_RECALC_COPY_ON_WRITE for batch cache

Reviewers: brecht, fclem, sergey

Maniphest Tasks: T64829

Differential Revision:

4 months agoFix T65187: Overlay blend increase wrongly the opacity
Antonioya [Tue, 28 May 2019 13:55:17 +0000 (15:55 +0200)]
Fix T65187: Overlay blend increase wrongly the opacity

The calculation of the mix color was not using the bottom color when the alpha was lower than 1.0.

Also added clamp code to avoid values outside valid ranges.

4 months agoGPencil: Minor cleanup
Antonioya [Tue, 28 May 2019 11:31:09 +0000 (13:31 +0200)]
GPencil: Minor cleanup

4 months agoCodestyle: Remove trailing spaces
Jeroen Bakker [Tue, 28 May 2019 13:12:29 +0000 (15:12 +0200)]
Codestyle: Remove trailing spaces

4 months agoMeshAnalysis: Disable when XRay is turned on
Jeroen Bakker [Tue, 28 May 2019 11:00:40 +0000 (13:00 +0200)]
MeshAnalysis: Disable when XRay is turned on

When XRay is turned on the mesh analysis did not draw correct. This
change won't draw the mesh analysis overlay when xray is turned on.

In terms of giving the user a visual feedback of this limitation we
render the overlay options inactive.

Reviewed By: brecht, fclem

Maniphest Tasks: T65225

Differential Revision:

4 months agoFix T64536 Eevee: Reflection texco no longer works
Clément Foucault [Tue, 28 May 2019 13:00:56 +0000 (15:00 +0200)]
Fix T64536 Eevee: Reflection texco no longer works

4 months agoFix T65226 Crash on entering in Edit mode with ASAN build
Clément Foucault [Tue, 28 May 2019 12:37:40 +0000 (14:37 +0200)]
Fix T65226 Crash on entering in Edit mode with ASAN build

4 months agoCleanup: DRW: Rename DRW_STATE_BLEND_* for API clarity
Clément Foucault [Mon, 27 May 2019 21:21:39 +0000 (23:21 +0200)]
Cleanup: DRW: Rename DRW_STATE_BLEND_* for API clarity

4 months agoFix T65141 Bevel did not curve.
Howard Trickey [Tue, 28 May 2019 11:56:56 +0000 (07:56 -0400)]
Fix T65141 Bevel did not curve.

The previous fix to the spike bug T64582 was not really right.
This fixes that one properly and restores the desired curving
profile in the bug's example.

4 months agoFix T57090: selected node group input sockets circles not drawing in
Philipp Oeser [Mon, 27 May 2019 21:10:35 +0000 (23:10 +0200)]
Fix T57090: selected node group input sockets circles not drawing in
sidebar UIList

nodesockets were actually drawn, but immediately drawn over by widgets
from the widget draw batch cache.

solution here is to "widgify" nodesocket drawing as well.

Reviewers: brecht

Maniphest Tasks: T57090

Differential Revision:

4 months agoFix T57483: Driver on grease pencil modifier does not update
Sergey Sharybin [Tue, 28 May 2019 09:10:35 +0000 (11:10 +0200)]
Fix T57483: Driver on grease pencil modifier does not update

4 months agoFix T65212: Cycles_render_layer test grease pencil crashes.
Antonioya [Tue, 28 May 2019 08:24:51 +0000 (10:24 +0200)]
Fix T65212: Cycles_render_layer test grease pencil crashes.

Theme colors should not be accessed for rendering.

Also some minor cleanups.

Thanks @brecht for catching the bug.

4 months agoCleanup: unused args/vars
Campbell Barton [Tue, 28 May 2019 06:22:21 +0000 (16:22 +1000)]
Cleanup: unused args/vars

4 months agoCleanup: use time scrub instead of scrubbing
Campbell Barton [Tue, 28 May 2019 06:17:15 +0000 (16:17 +1000)]
Cleanup: use time scrub instead of scrubbing

Renaming was only done to ED_time_scrub_ui.h, function names
and struct members used term 'scrubbing' which is ambiguous.

4 months agoCleanup: clang format
Campbell Barton [Tue, 28 May 2019 06:11:49 +0000 (16:11 +1000)]
Cleanup: clang format

4 months agoCleanup: rename gizmo keymaps
Campbell Barton [Tue, 28 May 2019 05:26:18 +0000 (15:26 +1000)]
Cleanup: rename gizmo keymaps

Don't use plural because single/multiple isn't relevant
for keymap definitions and reads badly for specific gizmo types
that only use a single gizmo.

4 months agoCleanup: remove unused modal gizmo keymap
Campbell Barton [Tue, 28 May 2019 05:18:25 +0000 (15:18 +1000)]
Cleanup: remove unused modal gizmo keymap

An operator can only have one modal keymap,
there is no use in defining multiple.

4 months agoGizmo: only highlight when held modifier keys are used
Campbell Barton [Tue, 28 May 2019 04:33:13 +0000 (14:33 +1000)]
Gizmo: only highlight when held modifier keys are used

Check the current events modifiers against the gizmo keymap,
only highlighting when keymap items match.

Needed to resolve T63996

4 months agoGizmo: changes to internal drag logic
Campbell Barton [Tue, 28 May 2019 03:26:50 +0000 (13:26 +1000)]
Gizmo: changes to internal drag logic

Minor changes to recent gizmo click/drag logic 08dff7b40bc6a

Changing the gizmos highlighted part in the invoke_prepare
callback is too error prone since it needs to run
before it's known which operator will execute.

Add back 'drag_part', since it simplifies click-drag use.
While this isn't essential with custom keymaps per gizmo
it avoids having to define a keymap in the case a drag
event needs a different action.

4 months agoFix show face-dot check
Campbell Barton [Tue, 28 May 2019 01:46:26 +0000 (11:46 +1000)]
Fix show face-dot check

Match edit-mesh drawing.

4 months agoDocs: correct descriptions
Campbell Barton [Tue, 28 May 2019 01:39:49 +0000 (11:39 +1000)]
Docs: correct descriptions

4 months agocmake: Fix building with clang on windows.
Ray Molenkamp [Mon, 27 May 2019 19:48:40 +0000 (13:48 -0600)]
cmake: Fix building with clang on windows.

4 months agoCleanup: Fix const warning in makesrna
Ray Molenkamp [Mon, 27 May 2019 17:34:04 +0000 (11:34 -0600)]
Cleanup: Fix const warning in makesrna

rna_function_string was not const correct leading to
different 'const' qualifiers (C4090) warnings in MSVC.

4 months agoFix T65190: GPencil stroke not correctly initializated using python API
Antonioya [Mon, 27 May 2019 17:30:27 +0000 (19:30 +0200)]
Fix T65190: GPencil stroke not correctly initializated using python API

The value of new gradient fields was wrong.

4 months agoCleanup: Fix warnings in bf_physics
Ray Molenkamp [Mon, 27 May 2019 17:29:24 +0000 (11:29 -0600)]
Cleanup: Fix warnings in bf_physics

MSVC did not detect the usage of i in the openmp loops
and emitted a unused variable warning.

4 months agoCleanup: Fix build warning in bf_editor_interface
Ray Molenkamp [Mon, 27 May 2019 16:46:50 +0000 (10:46 -0600)]
Cleanup: Fix build warning in bf_editor_interface

widget_draw_text_ime_underline was not const correct
leading to warnings with MSVC

4 months agoGizmo: add per gizmo keymaps
Campbell Barton [Mon, 27 May 2019 16:14:31 +0000 (02:14 +1000)]
Gizmo: add per gizmo keymaps

Remove click-drag support for tweak gizmo,
rely on keymap events instead.

This is needed for some gizmos to use modifiers keys
without having all gizmos use all modifier keys (see: T63996).

4 months agocleanup: Collada exporter renamed 'transrotloc' to 'decomposed'
Gaia Clary [Mon, 27 May 2019 16:35:34 +0000 (18:35 +0200)]
cleanup: Collada exporter renamed 'transrotloc' to 'decomposed'

The collada exporter allows to export transforms either as Matrix
or as a decomposition of Translation, Rotation aand Scale.
The decomposition option was falsely named "TransRotLoc".
I renamed it to the much more descriptive word "Decomposed".
The tooltip already contains sufficient information, so there
is no need to change that.

4 months agoFix tweak/drag event use with gizmos
Campbell Barton [Mon, 27 May 2019 15:19:02 +0000 (01:19 +1000)]
Fix tweak/drag event use with gizmos

It was possible to use a drag event for a gizmo
that dragged away from the gizmo, changing the active gizmo.

Now use gizmo located at the location that was clicked on.

4 months agoCleanup: Fix warnings in bf_intern_elbeem
Ray Molenkamp [Mon, 27 May 2019 15:28:50 +0000 (09:28 -0600)]
Cleanup: Fix warnings in bf_intern_elbeem

Truncating a pointer to long gave warnings with MSVC on x64

4 months agoFix T65080: handle case when View2D has 0 scale
Jacques Lucke [Mon, 27 May 2019 15:15:10 +0000 (17:15 +0200)]
Fix T65080: handle case when View2D has 0 scale

4 months agoEevee: Fix Aliasing in Light Probes
Adam Nydahl [Mon, 27 May 2019 15:07:17 +0000 (17:07 +0200)]
Eevee: Fix Aliasing in Light Probes

Differential Revision:

4 months agoCleanup: Fix warning in bf_editor_mesh
Ray Molenkamp [Mon, 27 May 2019 15:12:11 +0000 (09:12 -0600)]
Cleanup: Fix warning in bf_editor_mesh

Declaration and implementation of EDBM_select_id_context_create got
out of sync leading to warning with msvc.

4 months agoCleanup: Fix warning in blenlib with MSVC
Ray Molenkamp [Mon, 27 May 2019 14:57:39 +0000 (08:57 -0600)]
Cleanup: Fix warning in blenlib with MSVC

Some versions of the Windows SDK headers have a dbghelp.h that will emit
C4091 warnings, repress them just this once, since the warn can be helpful
in other places.

4 months agoFix T65145: Draw curve draw tool settings in column
Jacques Lucke [Mon, 27 May 2019 14:55:43 +0000 (16:55 +0200)]
Fix T65145: Draw curve draw tool settings in column

4 months agoCleanup: Fix warnings in bf_dna
Ray Molenkamp [Mon, 27 May 2019 14:49:19 +0000 (08:49 -0600)]
Cleanup: Fix warnings in bf_dna

Passing a const char** to MEM_recallocN lead to

C4090 'function': different 'const' qualifiers

warnings with MSVC

4 months agoFix (unreported) invalid handling of IDs usercount in `BKE_mesh_new_from_object_to_bm...
Bastien Montagne [Mon, 27 May 2019 14:46:45 +0000 (16:46 +0200)]
Fix (unreported) invalid handling of IDs usercount in `BKE_mesh_new_from_object_to_bmain()`.

Would have broken usercount of mesh used as texco reference e.g.

4 months agoCleanup: Fix warning in makesdna
Ray Molenkamp [Mon, 27 May 2019 14:44:37 +0000 (08:44 -0600)]
Cleanup: Fix warning in makesdna

passing a const pointer to BLI_ghash_insert causes warning

C4090 'function': different 'const' qualifiers

with MSVC

4 months agoFix T63173: Dragging hidden collection inside a visible one unhides it
Dalai Felinto [Fri, 24 May 2019 19:13:22 +0000 (16:13 -0300)]
Fix T63173: Dragging hidden collection inside a visible one unhides it

Same for holdout, indirect only and exclude.

Reviewers: brecht

Differential Revision:

4 months agoFix annotations not drawing correctly on Cycles rendered view
Brecht Van Lommel [Mon, 27 May 2019 14:33:38 +0000 (16:33 +0200)]
Fix annotations not drawing correctly on Cycles rendered view

4 months agoCleanup: Fix warnings in gpu_batch
Ray Molenkamp [Mon, 27 May 2019 14:30:53 +0000 (08:30 -0600)]
Cleanup: Fix warnings in gpu_batch

Passing a const pointer to MEM_freeN/MEM_recallocN lead to

C4090 'function': different 'const' qualifiers

warnings with MSVC

4 months agoCleanup: Fix warnings in bf_gpu
Ray Molenkamp [Mon, 27 May 2019 14:22:38 +0000 (08:22 -0600)]
Cleanup: Fix warnings in bf_gpu

Declaration and implementation got out of sync leading to warnings.

4 months agoEevee/GPencil: Fix depth reading after render
Clément Foucault [Mon, 27 May 2019 14:14:03 +0000 (16:14 +0200)]
Eevee/GPencil: Fix depth reading after render

4 months agodraw_manager: fix warning with msvc.
Ray Molenkamp [Mon, 27 May 2019 14:10:51 +0000 (08:10 -0600)]
draw_manager: fix warning with msvc.

32 bit shift stored in 64 bit field gave a warning with MSVC.

4 months agoFix (unreported) API doc generation script after removal of some ObjectBase ietms...
Bastien Montagne [Mon, 27 May 2019 14:06:09 +0000 (16:06 +0200)]
Fix (unreported) API doc generation script after removal of some ObjectBase ietms from context.

4 months agofix: collada transformtype must be identical for animation export and object export
Gaia Clary [Mon, 27 May 2019 13:34:05 +0000 (15:34 +0200)]
fix: collada transformtype must be identical for animation export and object export

When exporting an object we can choose the transformation type 'Matrix'
or 'trans/rot/scale' When exporting an animation we have the same choice
regarding the used transformation type.

However we must make sure that animations and objects use the same
transformation type within one colleda export. The user interface is
now reworked such that the correct settings are always guaranteed.

I also reworked the tool tips

4 months agorefactor collada: rename add_node_transform() to add_joint_transform()
Gaia Clary [Mon, 27 May 2019 13:02:11 +0000 (15:02 +0200)]
refactor collada: rename add_node_transform() to add_joint_transform()

4 months agoGizmo: add event argument to invoke_prepare callback
Campbell Barton [Mon, 27 May 2019 13:58:12 +0000 (23:58 +1000)]
Gizmo: add event argument to invoke_prepare callback

4 months agoblenloader: Fix warnings with MSVC
Ray Molenkamp [Mon, 27 May 2019 13:54:56 +0000 (07:54 -0600)]
blenloader: Fix warnings with MSVC

these macros are mostly used with size_t types, leading to msvc warning :

warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits

4 months agoFix T65052: "Convert to mesh from curve" fail if the curve has a bevel
Sergey Sharybin [Mon, 27 May 2019 10:05:35 +0000 (12:05 +0200)]
Fix T65052: "Convert to mesh from curve" fail if the curve has a bevel

Use evaluated object as an input for mesh construction. This ensures
all dependencies are ready.

Reviewers: brecht, mont29

Reviewed By: brecht, mont29

Differential Revision:

4 months agoCleanup: remove redundant assignment
Campbell Barton [Mon, 27 May 2019 11:16:13 +0000 (21:16 +1000)]
Cleanup: remove redundant assignment

4 months agoFix T65177: Camera frame visible in viewport render
Jacques Lucke [Mon, 27 May 2019 12:15:07 +0000 (14:15 +0200)]
Fix T65177: Camera frame visible in viewport render

4 months agoFix T65066 Armature and bone selection is broken on macOS
Clément Foucault [Mon, 27 May 2019 11:37:58 +0000 (13:37 +0200)]
Fix T65066 Armature and bone selection is broken on macOS

4 months agoFix poor display of time codes in sequencer Info panel
Mal Duffin [Mon, 27 May 2019 11:05:27 +0000 (13:05 +0200)]
Fix poor display of time codes in sequencer Info panel

Allow using : in labels inside buttons.

Differential Revision:

4 months agoEevee: Fix render z-depth for orthographic camera
Clément Foucault [Mon, 27 May 2019 11:29:29 +0000 (13:29 +0200)]
Eevee: Fix render z-depth for orthographic camera

Fix last commit

4 months agoEevee: Fix render depth pass being negative
Clément Foucault [Mon, 27 May 2019 11:18:47 +0000 (13:18 +0200)]
Eevee: Fix render depth pass being negative

4 months agoWireframe: Make wireframe's Xray slider default to 0
Clément Foucault [Mon, 27 May 2019 10:54:32 +0000 (12:54 +0200)]
Wireframe: Make wireframe's Xray slider default to 0

This removes the dither patterns visible in wireframe mode.
This does decrease de depth perception but many users complained
about the visual noise it produces.

4 months agoEditMeshMode: Reduce unselected face alpha
Clément Foucault [Mon, 27 May 2019 10:40:41 +0000 (12:40 +0200)]
EditMeshMode: Reduce unselected face alpha

Lowering it to 0.071 so that wireframe mode is not so much

4 months agoCleanup: DRW: Make clipped shader use UBO clip planes
Clément Foucault [Sun, 26 May 2019 19:32:48 +0000 (21:32 +0200)]
Cleanup: DRW: Make clipped shader use UBO clip planes

4 months agoCleanup: DRW: Move WorldClipPlanes to builtin uniform
Clément Foucault [Sun, 26 May 2019 18:36:24 +0000 (20:36 +0200)]
Cleanup: DRW: Move WorldClipPlanes to builtin uniform

4 months agoCleanup: DRW: Remove DRW_STATE_OFFSET
Clément Foucault [Sun, 26 May 2019 00:12:35 +0000 (02:12 +0200)]

4 months agoCleanup: Paint Overlays: Remove DRW_STATE_OFFSET_*
Clément Foucault [Sat, 25 May 2019 23:42:36 +0000 (01:42 +0200)]
Cleanup: Paint Overlays: Remove DRW_STATE_OFFSET_*

4 months agoCleanup: EditMesh: Remove DRW_STATE_OFFSET_*
Clément Foucault [Sat, 25 May 2019 23:13:20 +0000 (01:13 +0200)]
Cleanup: EditMesh: Remove DRW_STATE_OFFSET_*

4 months agoDepsgraph: Fix condition inverted by mistake
Sergey Sharybin [Mon, 27 May 2019 10:39:26 +0000 (12:39 +0200)]
Depsgraph: Fix condition inverted by mistake

Fixes T65165: Weights are not displayed in "Weight Paint" with modifiers

4 months agoRevert "Keymap: Drag in empty area to box select in animation editors"
Brecht Van Lommel [Mon, 27 May 2019 10:35:23 +0000 (12:35 +0200)]
Revert "Keymap: Drag in empty area to box select in animation editors"

This reverts commit ebf924e0b79b6ebea4401d0b0f2e59e2c103a66d. This is causing
the transform tool to start immediately which leads to lots of accidental
changes. We can bring this back when that issue is fixed.

4 months agoFix T65181: image View as Render should not affect file saving
Brecht Van Lommel [Mon, 27 May 2019 09:35:56 +0000 (11:35 +0200)]
Fix T65181: image View as Render should not affect file saving

4 months agoFix T65160: missing updates when setting origin on a collection instance
Philipp Oeser [Mon, 27 May 2019 09:33:15 +0000 (11:33 +0200)]
Fix T65160: missing updates when setting origin on a collection instance

Reviewers: sergey, brecht

Maniphest Tasks: T65160

Differential Revision:

4 months agoPython API: Tag for update on object.update_from_editmode()
Sergey Sharybin [Mon, 27 May 2019 09:29:22 +0000 (11:29 +0200)]
Python API: Tag for update on object.update_from_editmode()

This call modifies geometry but does not inform anyone about

After this change it's possible to load edit mesh, then request
evaluated dependency graph and do some interesting things with
the updated object.

This is part of T63244: object.to_mesh ignores object.update_from_editmode

4 months agoDepsgraph API: Allow preserving custom data layers
Sergey Sharybin [Fri, 24 May 2019 12:37:47 +0000 (14:37 +0200)]
Depsgraph API: Allow preserving custom data layers

This commit extends dependency graph API with an argument which
denotes that all custom data layers are to be preserved. This
forces modifier stack re-evaluation with more inclusive mask.

Far from ideal, since this might fail in certain configurations
with indirectly used objects which might be missing layers needed
for the current object evaluation. But this is how it worked for
a long time, so should be good enough for until more sophisticated
solution is found.

In order to use this new behavior two things are to be passed:

- Pass keep_all_data_layers=True
- Pass a valid dependency graph.

The dependency graph is only needed if keep_all_data_layers=True
and is NOT to be passed if keep_all_data_layers=False.

If keep_all_data_layers=True the dependency graph MUST be passed.

Reviewers: mont29, brecht

Reviewed By: mont29

Maniphest Tasks: T64994, T64794

Differential Revision:

4 months agoIndustry Compat keymap: Fix armature extrude
William Reynish [Mon, 27 May 2019 08:55:13 +0000 (10:55 +0200)]
Industry Compat keymap: Fix armature extrude

MMB wasn't working to extrude freely for Armature extrude

Also fix an issue with moving down the hierarchy in Pose Mode

4 months agoDepsgraph: Use threading guard in context.evaluated_depsgraph_get
Sergey Sharybin [Mon, 27 May 2019 08:42:30 +0000 (10:42 +0200)]
Depsgraph: Use threading guard in context.evaluated_depsgraph_get

This is a part of T65174.

4 months agoUI: use tool label instead of id-names for quick favorites
Campbell Barton [Mon, 27 May 2019 06:24:48 +0000 (16:24 +1000)]
UI: use tool label instead of id-names for quick favorites

4 months agoMitigate T64346: Quick Favorites items cant be removed
Campbell Barton [Mon, 27 May 2019 05:30:48 +0000 (15:30 +1000)]
Mitigate T64346: Quick Favorites items cant be removed

For now don't show missing quick favorite menu items which are missing.

Once menu editing is supported they could be displayed.

4 months agoFix T65074: Crash on switching color
Campbell Barton [Mon, 27 May 2019 03:58:02 +0000 (13:58 +1000)]
Fix T65074: Crash on switching color

Make buttons to take active `Paint` from the context.

D4946 by @Gvgeo

4 months agoRevert "UI: Edit Menu Operator Polling"
Brecht Van Lommel [Sun, 26 May 2019 22:29:34 +0000 (00:29 +0200)]
Revert "UI: Edit Menu Operator Polling"

This reverts part of commit b7eba20236ca6499a62a8ee2b0c852086bc46b8e. Polling
is causing issues in scripts, and the minor usability improvements are not worth
the extra work this may cause at this point in the release cycle.

Fixes T65149

4 months agocmake/msvc: Repress MSVC template warning C4661
Ray Molenkamp [Sun, 26 May 2019 22:13:31 +0000 (16:13 -0600)]
cmake/msvc: Repress MSVC template warning C4661

Draco emits about 60 of these, consulted with brecht before
repressing them.

4 months agoFix building with ninja on windows
Ray Molenkamp [Sun, 26 May 2019 15:25:17 +0000 (09:25 -0600)]
Fix building with ninja on windows

Broken by rB161908157d67ee8bcfa0c26917cccdc40e0c67ea

4 months agoFix T64989 Bevel hangs with Mark Sharp sometimes.
Howard Trickey [Sun, 26 May 2019 14:37:58 +0000 (10:37 -0400)]
Fix T64989 Bevel hangs with Mark Sharp sometimes.

Code for extending sharp edges assumes ADJ pattern and this
example uses TRI_FAN pattern. This change doesn't fix TRI_FAN
mark sharp bug at least won't infinite loop any more.

4 months agoFix misleading image color space and alpha tooltips
Brecht Van Lommel [Sun, 26 May 2019 10:37:51 +0000 (12:37 +0200)]
Fix misleading image color space and alpha tooltips

4 months agoFix Cycles packed images not handling channel packed alpha correctly
Brecht Van Lommel [Sun, 26 May 2019 10:16:58 +0000 (12:16 +0200)]
Fix Cycles packed images not handling channel packed alpha correctly

4 months agoFix: BLI_task_test deadlock on windows.
Ray Molenkamp [Sat, 25 May 2019 23:18:17 +0000 (17:18 -0600)]
Fix: BLI_task_test deadlock on windows.

This patch makes BLI_task_scheduler_create wait for all worker threads to have started before
returning to caller. For very short workloads (BLI_taks_test) there is the chance that the
worker threads have not fully started yet, and the main thread is calling pthread_join at
the same time as pthread_setspecific is being called on the worker threads which causes a
deadlock on pthreads4w.

Differential Revision:

Reviewed By: mont29, sergey, brecht

4 months agoblenlib: Fix build warning with MSVC
Ray Molenkamp [Sat, 25 May 2019 19:22:25 +0000 (13:22 -0600)]
blenlib: Fix build warning with MSVC

The declaration and implementation of BLI_path_name_at_index were
out of sync leading to build warning

C4028: formal parameter 1/3/4 different from declaration

4 months agocycles_render: Fix unused variable build warning with MSVC
Ray Molenkamp [Sat, 25 May 2019 19:05:59 +0000 (13:05 -0600)]
cycles_render: Fix unused variable build warning with MSVC

4 months agobf_intern_opencolorio: Fix unused variable build warning with MSVC.
Ray Molenkamp [Sat, 25 May 2019 19:04:24 +0000 (13:04 -0600)]
bf_intern_opencolorio: Fix unused variable build warning with MSVC.

4 months agoghost/windows: Fix Build warnings with MSVC.
Ray Molenkamp [Sat, 25 May 2019 18:58:14 +0000 (12:58 -0600)]
ghost/windows: Fix Build warnings with MSVC.

The order of the initializers did not follow the order they were
declared in the class definition leading to warning C5038

4 months agoblenlib: Fix debug build warning with MSVC.
Ray Molenkamp [Sat, 25 May 2019 18:45:58 +0000 (12:45 -0600)]
blenlib: Fix debug build warning with MSVC.

Wrong printf format specifier was used leading to warning C4477

4 months agoimbuf/oiio: Resolve build warnings with MSVC.
Ray Molenkamp [Sat, 25 May 2019 18:23:48 +0000 (12:23 -0600)]
imbuf/oiio: Resolve build warnings with MSVC.

math.h and oiio's missing_math.h where clashing over the
definitions of common math defines like M_PI.

4 months agoCMake/MSVC: Mark headers in the libdir as system headers.
Ray Molenkamp [Sat, 25 May 2019 18:13:06 +0000 (12:13 -0600)]
CMake/MSVC: Mark headers in the libdir as system headers.

This marks the headers in the LIBDIR as system headers
and changes the warn to /W0 on msvc versions that support it.

This resolves some warnings we would had to completely
repress otherwise.