23 months agoFix T61272: Undo fails to track multi-edit mode enter/exit
Campbell Barton [Thu, 7 Feb 2019 09:27:11 +0000 (20:27 +1100)]
Fix T61272: Undo fails to track multi-edit mode enter/exit

Objects leaving edit-mode weren't restored by edit-mode undo steps.

23 months agoFix sculpt undo steps not enabling dyntopo
Campbell Barton [Thu, 7 Feb 2019 06:54:53 +0000 (17:54 +1100)]
Fix sculpt undo steps not enabling dyntopo

Logic to disable dyntopo when entering sculpt mode was applied on undo.

23 months agoClose metadata panels by default
Sergey Sharybin [Thu, 7 Feb 2019 08:38:49 +0000 (09:38 +0100)]
Close metadata panels by default

They might be rather long, and not that commonly accessed.

23 months agoFix for images without metadata crashing
Sergey Sharybin [Thu, 7 Feb 2019 08:33:43 +0000 (09:33 +0100)]
Fix for images without metadata crashing

23 months agoFix T61049: Undo dynamic topology sculpt asserts
Campbell Barton [Thu, 7 Feb 2019 02:22:31 +0000 (13:22 +1100)]
Fix T61049: Undo dynamic topology sculpt asserts

23 months agoCleanup: remove unnecessary undo function
Campbell Barton [Wed, 6 Feb 2019 23:09:56 +0000 (10:09 +1100)]
Cleanup: remove unnecessary undo function

23 months agoPyAPI: message subscribe option arg now optional
Campbell Barton [Wed, 6 Feb 2019 22:29:01 +0000 (09:29 +1100)]
PyAPI: message subscribe option arg now optional

23 months agoCleanup: doxy header
Campbell Barton [Wed, 6 Feb 2019 22:28:21 +0000 (09:28 +1100)]
Cleanup: doxy header

23 months agoFix T61246: studiolights (un)install problems
Philipp Oeser [Wed, 6 Feb 2019 21:51:29 +0000 (22:51 +0100)]
Fix T61246: studiolights (un)install problems

- studiolights were not installed to their proper subfolder (thus not
recognized on blender restart)
- they were actually loaded with a wrong path which could lead to
deletion of the original source file when uninstalled again

23 months agoDRW: support clipping for octahedral & box bones
Campbell Barton [Wed, 6 Feb 2019 20:44:12 +0000 (07:44 +1100)]
DRW: support clipping for octahedral & box bones

23 months agoFix refresh on resetting header alignment
Campbell Barton [Wed, 6 Feb 2019 20:42:07 +0000 (07:42 +1100)]
Fix refresh on resetting header alignment

23 months agoRemove no-longer needed function
Dalai Felinto [Wed, 6 Feb 2019 20:47:47 +0000 (18:47 -0200)]
Remove no-longer needed function

23 months agoFixup for outliner visibility not changing disable state
Dalai Felinto [Wed, 6 Feb 2019 20:46:48 +0000 (18:46 -0200)]
Fixup for outliner visibility not changing disable state

Show Inside (shift + click) was still forcing objects to be visible.

23 months agoFix (unreported) crash when iterating on depsgraph instances from RNA.
Bastien Montagne [Wed, 6 Feb 2019 19:59:29 +0000 (20:59 +0100)]
Fix (unreported) crash when iterating on depsgraph instances from RNA.

This is a follow-up to rBb44e6f2b3d32, for some reason that issue was
not detected back then: in some cases, DEG_iterator_objects_next() will
free the temp list of dupli objects once it does not need it anymore,
henceforth freeing the dupli_object_current memory of the DEGObjectIterData
that we are storing in the RNA_Depsgraph_Instances_Iterator struct.

And yes, the uglyness of that hack is getting even better now...

Found while trying to export dupliobjects with FBX...

23 months agoOutliner visibility: Respect original viewport enable/disable state
Dalai Felinto [Wed, 6 Feb 2019 16:52:40 +0000 (16:52 +0000)]
Outliner visibility: Respect original viewport enable/disable state

Note: We still change it to the collection we are directly isolating/making
visible and its parents (in the case of isolating). But no longer its children.

Feedback and discussion on D4011. The motivation is that if we don't keep those
locked the disable state becomes useless.

23 months agoOutliner visibility unification: Prevent master collection visibility to change
Dalai Felinto [Wed, 6 Feb 2019 16:12:25 +0000 (16:12 +0000)]
Outliner visibility unification: Prevent master collection visibility to change

Also satinizing the checks for master collection. The outliner tree
iterators already take care of not including the master collection

23 months agoDepsgraph: Fix dependency cycle when rigid body is involved
Sergey Sharybin [Wed, 6 Feb 2019 16:04:29 +0000 (17:04 +0100)]
Depsgraph: Fix dependency cycle when rigid body is involved

Was introduced by point cache reset on manual edits. Needed to
split evaluation and introduce an explicit init key, which allows
to hook up relations which are "monitoring" manual edits to the

Noticed while looking into T61190.

23 months agoFix T61190: Crash in particles distribution
Sergey Sharybin [Wed, 6 Feb 2019 15:38:03 +0000 (16:38 +0100)]
Fix T61190: Crash in particles distribution

Was visible with certain configuration only, is a numeric
instability caused by degenerate ray direction.

Not sure the distribution is correct, just fixing crash
which was caused by usage of watertight intersection.

23 months agoImprovements and fixes to Cycles metadata
Sergey Sharybin [Wed, 6 Feb 2019 10:49:41 +0000 (11:49 +0100)]
Improvements and fixes to Cycles metadata

This is a request by the studio here to make it possible to see how
many samples were used to render a specific shot or a frame. It is a
bit more tricky than simply stamping number of samples from a scene
since rendering is happening in multiple ranges of samples.

This change makes it so Cycles saves configured number of samples for
the specific view layer, and also stores start sample and number of
samples when rendering only a subrange of all samples.

The format used is "cycles.<view_layer_name>.><field>", which allows
to have information about all layers in a multi-layer EXR file.

Ideally we can store simplified "cycles.<field>" if we know that there
is only one render layer in the file, but detecting this is somewhat
tricky since Cycles operates on an evaluated scene which always have
single view layer.

The metadata is shown in the Metadata panels for clip, image and
sequencer spaces.

Example screenshot which shows the metadata:


Reviewers: brecht

Reviewed By: brecht

Subscribers: fsiddi

Differential Revision:

23 months agoMerge branch 'blender2.7'
Brecht Van Lommel [Wed, 6 Feb 2019 14:22:53 +0000 (15:22 +0100)]
Merge branch 'blender2.7'

23 months agoCycles: animation denoising support in the kernel.
Lukas Stockner [Wed, 6 Feb 2019 13:19:20 +0000 (14:19 +0100)]
Cycles: animation denoising support in the kernel.

This is the internal implementation, not available from the API or
interface yet. The algorithm takes into account past and future frames,
both to get more coherent animation and reduce noise.

Ref D3889.

23 months agoCycles: tweak outlier detection, preparing for animation denoising.
Lukas Stockner [Wed, 6 Feb 2019 13:42:32 +0000 (14:42 +0100)]
Cycles: tweak outlier detection, preparing for animation denoising.

Ref D3889.

23 months agoCycles: prefilter feature passes separate from denoising.
Lukas Stockner [Wed, 6 Feb 2019 11:42:10 +0000 (12:42 +0100)]
Cycles: prefilter feature passes separate from denoising.

Prefiltering of feature passes will happen during rendering, which can
then be used for denoising immediately or written as a render pass for
later (animation) denoising.

The number of denoising data passes written is reduced because of this,
leaving out the feature variance passes. The passes are now Normal,
Albedo, Depth, Shadowing, Variance and Intensity.

Ref D3889.

23 months agoDRW: Support edit-metaball clipping
Campbell Barton [Wed, 6 Feb 2019 13:07:30 +0000 (00:07 +1100)]
DRW: Support edit-metaball clipping

23 months agoDRW: Support edit-curve clipping
Campbell Barton [Wed, 6 Feb 2019 12:19:39 +0000 (23:19 +1100)]
DRW: Support edit-curve clipping

23 months agoFix T57342: Crash on render with workbench render engine via command line
Clément Foucault [Wed, 6 Feb 2019 11:10:11 +0000 (12:10 +0100)]
Fix T57342: Crash on render with workbench render engine via command line

23 months agoCleanup: Remove deprecated ghosting code
Jacques Lucke [Wed, 6 Feb 2019 11:05:34 +0000 (12:05 +0100)]
Cleanup: Remove deprecated ghosting code

Most of this code is deprecated for many years already and does not
work at all in Blender 2.8.

Reviewers: brecht, aligorith

Differential Revision:

23 months agoFix T60935: More numerically stable distance to ray computation
Jacques Lucke [Wed, 6 Feb 2019 10:47:46 +0000 (11:47 +0100)]
Fix T60935: More numerically stable distance to ray computation

The old function was numerically very unstable for 2 reasons:
computing the square and then subtracting the results.

In the example in T60935 all precision was lost and it returned the distance 0
for all points.

I also removed the `depth` parameter since it wasn't used and computing
it would have made the code more complicated.

Reviewers: brecht, campbellbarton

Differential Revision:

23 months agoUI: tweak header position button
Campbell Barton [Wed, 6 Feb 2019 10:39:06 +0000 (21:39 +1100)]
UI: tweak header position button

Be less prominent.

23 months agoFix T61136: Header alignment preference has no effect
Campbell Barton [Wed, 6 Feb 2019 10:15:39 +0000 (21:15 +1100)]
Fix T61136: Header alignment preference has no effect

Users expect this to apply to existing files,
adjust this to apply on load, defaults to off.

23 months agoClip editor: Fix drawing metadata for RGBA images
Sergey Sharybin [Wed, 6 Feb 2019 09:48:09 +0000 (10:48 +0100)]
Clip editor: Fix drawing metadata for RGBA images

Need to disable blending prior to drawing metadata. Otherwise
text will be drawn on a transparent background.

23 months agoCleanup: Spelling in comment
Sergey Sharybin [Wed, 6 Feb 2019 09:10:59 +0000 (10:10 +0100)]
Cleanup: Spelling in comment

23 months agoFix T61124: Lag on physics simulation
Sergey Sharybin [Wed, 6 Feb 2019 09:09:00 +0000 (10:09 +0100)]
Fix T61124: Lag on physics simulation

Need to synchronize simulated frame back to original object.

Solves the lag during transformation, but amount of floppyness is
lower for some reason. Final animated object behaves the same as
in older Blender though.

23 months agoFix T61051: crash with multi-object mixed mode snapping
Philipp Oeser [Thu, 31 Jan 2019 12:01:52 +0000 (13:01 +0100)]
Fix T61051: crash with multi-object mixed mode snapping

rBec3357e03ab1 introduced multi-object snapping.
Seems like this was done without mixed-mode selections in mind.

So code assumed that all selected objects are actually armatures [which
can fail].
In 2.7 this was not a problem, because code only took active object into
account, 2.8 was iterating over all selected_editable_objects.

Now just iterate over objects in posemode instead

Reviewers: brecht, dfelinto

Maniphest Tasks: T61051

Differential Revision:

23 months agoCleanup: remove unused toolbox delay preferences
Campbell Barton [Wed, 6 Feb 2019 07:18:54 +0000 (18:18 +1100)]
Cleanup: remove unused toolbox delay preferences

23 months agoCleanup: use '_pad' prefix for padding vars
Campbell Barton [Wed, 6 Feb 2019 07:15:58 +0000 (18:15 +1100)]
Cleanup: use '_pad' prefix for padding vars

23 months agoCleanup: manually apply changes missed last commit
Campbell Barton [Wed, 6 Feb 2019 04:52:04 +0000 (15:52 +1100)]
Cleanup: manually apply changes missed last commit

Automatic edits failed for indented comment blocks,
removed indentation & adjusted.

23 months agoCleanup: remove redundant doxygen \file argument
Campbell Barton [Wed, 6 Feb 2019 04:42:22 +0000 (15:42 +1100)]
Cleanup: remove redundant doxygen \file argument

Move \ingroup onto same line to be more compact and
make it clear the file is in the group.

23 months agoDoxygen: don't warn on undocumented params
Campbell Barton [Wed, 6 Feb 2019 04:02:07 +0000 (15:02 +1100)]
Doxygen: don't warn on undocumented params

We don't attempt to have docs for all args, so don't warn about this.

23 months agoDoxygen: update doxyfile
Campbell Barton [Wed, 6 Feb 2019 04:01:04 +0000 (15:01 +1100)]
Doxygen: update doxyfile

23 months agoCleanup: remove deprecated/unused preferences DNA
Campbell Barton [Wed, 6 Feb 2019 03:34:00 +0000 (14:34 +1100)]
Cleanup: remove deprecated/unused preferences DNA

23 months agoCleanup: use doxy headers for preference comments
Campbell Barton [Wed, 6 Feb 2019 03:23:08 +0000 (14:23 +1100)]
Cleanup: use doxy headers for preference comments

23 months agoFix T61191: First undo step missing in text editor
Campbell Barton [Wed, 6 Feb 2019 01:55:26 +0000 (12:55 +1100)]
Fix T61191: First undo step missing in text editor

23 months agoUndo System: remove accumulate/store modes
Campbell Barton [Tue, 5 Feb 2019 03:24:11 +0000 (14:24 +1100)]
Undo System: remove accumulate/store modes

This complicated handling of undo steps in a generic way
especially switching between undo systems that stored data to ones
that accumulated changes.

Now each undo system must treat it's steps as check-point,
internally it can apply/rewind changes.

This commit also fixes projection paint where the object mode wasn't
following the undo steps.

23 months agoFix T61196: Mesh select ignores clipping
Campbell Barton [Tue, 5 Feb 2019 23:33:14 +0000 (10:33 +1100)]
Fix T61196: Mesh select ignores clipping

Select clipping now works when x-ray is disabled.

23 months agoGPU: refactor clipped drawing from DRW into GPU
Campbell Barton [Tue, 5 Feb 2019 22:15:16 +0000 (09:15 +1100)]
GPU: refactor clipped drawing from DRW into GPU

Needed to fix T61196, supporting clipped back-buffer in the 3D view
which is done outside the draw module.

It was also inconvenient having DRW_shader_* versions of GPU_shader_*
API calls.

- Clipping distances are now supported as a shader configuration
  for builtin shaders.
- Add shader config argument when accessing builtin shaders.
- Move GPU_shader_create_from_arrays() from DRW to GPU.

23 months agoCleanup: style
Campbell Barton [Tue, 5 Feb 2019 22:14:11 +0000 (09:14 +1100)]
Cleanup: style

23 months agoOutliner visibility unification: Implement 3 levels of viewport visibility
Dalai Felinto [Fri, 30 Nov 2018 04:24:06 +0000 (02:24 -0200)]
Outliner visibility unification: Implement 3 levels of viewport visibility

Now collection and objects can be either:
* Disabled for all the view layers.
* Hidden for a view layer but not necessarily for all others.
* Visible for a view layer but not necessarily for all others.

Regarding icons: Whatever we decide to use for the "Hidden for all view
layers" needs to be a toggle-like icon. Because when viewing "Scenes"
instead of "View Layer" in the outliner we should be able to edit the
collection "Hidden for all the view layers" as an on/off option.

The operators are accessible via a Visibility context menu or shortcuts:
* Ctrl + Click: Isolate collection (use shift to extend).
* Alt + Click: Disable collection.
* Shift + Click: Hide/Show collection and its children (objects and collections)

Things yet to be tackled:
* Object outliner context menu can also get a Visibility sub-menu.
* Get better icons for viewport enable/disable.

* When using emulate 3 button mouse alt+click is used for 2d panning.
  In this case users have to use the operator from the menu.

See T57857 for discussion.

Reviewers: brecht and sergey

Thanks to the reviewers and William Reynish and Julien Kasper in
particular for the feedback.

23 months agoOutliner: eyes for collection affect collection visibility
Dalai Felinto [Thu, 29 Nov 2018 21:43:52 +0000 (19:43 -0200)]
Outliner: eyes for collection affect collection visibility

As oppose to affect the collection objects' visibility.

23 months agoOutliner: Gray out collections only when they are invisible
Dalai Felinto [Thu, 29 Nov 2018 20:56:10 +0000 (18:56 -0200)]
Outliner: Gray out collections only when they are invisible

Re-factor of 4521d3e7074d.

23 months agoFix/workaround issues in pose and edit mode
Sergey Sharybin [Wed, 28 Nov 2018 09:36:07 +0000 (10:36 +0100)]
Fix/workaround issues in pose and edit mode


Edit mode was unable to select, pose mode was unable to move bones.

23 months agoPer view-layer collection visibility
Dalai Felinto [Wed, 28 Nov 2018 02:49:36 +0000 (00:49 -0200)]
Per view-layer collection visibility


We still control this in the viewport collections visibility menu. But
now we are actually changing the visibility of the collections, not of
the objects.

If a collection is indirectly invisible (because one of its parents are
invisible) we gray it out.

Also if you click directly in the collection names, it "isolates" the
collection by hiding all collections, and showing the direct parents and
all the children of the selected collection.

Development Note:

Right now I'm excluding the hidden collections from the depsgraph.
Thus the need for tagging relations to update.

If this proves to be too slow, we can change.

23 months agoFix T61204: Can't select Camera in stereoscopy mode
Dalai Felinto [Tue, 5 Feb 2019 20:37:42 +0000 (18:37 -0200)]
Fix T61204: Can't select Camera in stereoscopy mode

This was deliberately disabled since I didn't get the drawing working
originally. It is fully working now.

Note: camera lens widget still needs to be fixed since it still draws it

23 months agoUI: make drag lock work also when buttons have > 2 states or use callbacks.
Brecht Van Lommel [Tue, 5 Feb 2019 19:03:55 +0000 (20:03 +0100)]
UI: make drag lock work also when buttons have > 2 states or use callbacks.

This will help with upcoming outliner visibility icons with 3 states.

It is done by using the icon to identify the state. If that is not unique
there is no visible difference to users anyway.

23 months agoFix new EEVEE bloom / motion blur defaults not being applied to startup.blend.
Brecht Van Lommel [Tue, 5 Feb 2019 13:01:45 +0000 (14:01 +0100)]
Fix new EEVEE bloom / motion blur defaults not being applied to startup.blend.

23 months agoFix strict compiler warning, breaking MSVC
Sergey Sharybin [Tue, 5 Feb 2019 16:02:01 +0000 (17:02 +0100)]
Fix strict compiler warning, breaking MSVC

23 months agoClip editor: Fixes for prefetch
Sergey Sharybin [Tue, 5 Feb 2019 15:50:57 +0000 (16:50 +0100)]
Clip editor: Fixes for prefetch

Seems metadata was never read while prefetching, at least was
never requested to be read.

Also fixed prefetch for multilayer EXR.

23 months agoBKE_mesh_new_from_object(): do not generate temp obj/cu in Main.
Bastien Montagne [Tue, 5 Feb 2019 15:36:14 +0000 (16:36 +0100)]
BKE_mesh_new_from_object(): do not generate temp obj/cu in Main.

When generating a mesh from a curve object, do not generate temp objects
and curves in main, but rather as 'localized' copies.

This is cleaner, and might add a marginal speed-up in some cases (like
rendering thousands of curve objects), since we save some processing.
Note that this is the function behind py API's `Object.to_mesh()` too.

23 months agoMovieclip: Improve support of multilayer EXR files
Sergey Sharybin [Tue, 5 Feb 2019 15:23:53 +0000 (16:23 +0100)]
Movieclip: Improve support of multilayer EXR files

Use first combined pass if possible. Is not ideal but better than
showing completely empty image.

Also, covers quite a lot of usecases when movie clip editor is
used to review animation render of single-layer renders but with
multiple passes.

23 months agoEdit Mode: Increase depth Bias for vertices
Clément Foucault [Tue, 5 Feb 2019 15:12:50 +0000 (16:12 +0100)]
Edit Mode: Increase depth Bias for vertices

23 months agoEdit Mode: Fix loose edges edit mode normal display broken
Clément Foucault [Tue, 5 Feb 2019 13:58:47 +0000 (14:58 +0100)]
Edit Mode: Fix loose edges edit mode normal display broken

23 months agoEdit Mode: Fix Xray edit mode broken due to recent refactor
Clément Foucault [Tue, 5 Feb 2019 13:47:05 +0000 (14:47 +0100)]
Edit Mode: Fix Xray edit mode broken due to recent refactor

23 months agoEdit Mesh: Add workaround for system that does not support wide lines
Clément Foucault [Mon, 4 Feb 2019 21:28:39 +0000 (22:28 +0100)]
Edit Mesh: Add workaround for system that does not support wide lines

This adds a new geometry shader (specific to edit mesh for now) that
reproduces the effect of glLineWidth > 1.0, since this is not supported on
all platform.

This fix could be generalized to other shaders later.

23 months agoEdit Mesh: Fix some problem with new implementation
Clément Foucault [Mon, 4 Feb 2019 19:06:30 +0000 (20:06 +0100)]
Edit Mesh: Fix some problem with new implementation

- Add manual depth offset to vertices and edges.
- Revert to plain edge decoration.
- Fix active edge coloring.
- Remove active face display if not in face selection mode.
- Add wide line support.

23 months agoEdit Mesh: Remove old unused code and files
Clément Foucault [Mon, 4 Feb 2019 00:35:21 +0000 (01:35 +0100)]
Edit Mesh: Remove old unused code and files

Cleanup after recent refactor.

23 months agoEdit Mesh: Refactor Edit cage drawing to use old style drawing
Clément Foucault [Mon, 4 Feb 2019 00:13:51 +0000 (01:13 +0100)]
Edit Mesh: Refactor Edit cage drawing to use old style drawing

This is work in progress. Look is not final.

This align data VBO data structure used for edti cage drawing to the one
use for normal drawing.

We no longer use barycentric coords to draw the lines an just rasterize
line primitives for edge drawing. This is a bit slower than using the
previous fast method but faster than the "correct" (edge artifact free)
method. This also make the code way simpler.

This also makes it possible to reuse possible and normal vbos used for
shading if the edit cage matches the

This also touches the UV batch code to share as much render data as
possible. The code also prepare for edit cage "modified" drawing cage (with
modifier applied) but is not enabled since selection and operators does not
work with modified cage yet.

23 months agoUVEdit: Add function variants based on ToolSettings
Clément Foucault [Mon, 4 Feb 2019 00:12:05 +0000 (01:12 +0100)]
UVEdit: Add function variants based on ToolSettings

This is better than passing a scene pointer when we don't have one.

23 months agoSupport showing metadata for multilayer EXR files
Sergey Sharybin [Tue, 5 Feb 2019 13:23:50 +0000 (14:23 +0100)]
Support showing metadata for multilayer EXR files

Quite straightforward: first, convert metadata from file to
stamp data which is stored in the render result, and then
for every requested layer/pass use that as a metadata.

23 months agoUI: Add collection move & link to menu
William Reynish [Tue, 5 Feb 2019 11:36:09 +0000 (22:36 +1100)]
UI: Add collection move & link to menu

23 months agoCleanup: Add precision to comment.
Bastien Montagne [Tue, 5 Feb 2019 08:48:15 +0000 (09:48 +0100)]
Cleanup: Add precision to comment.

23 months agoFix (unreported) linestyle/greasepencil actions not being duplicated by full scene...
Bastien Montagne [Mon, 4 Feb 2019 19:43:06 +0000 (20:43 +0100)]
Fix (unreported) linestyle/greasepencil actions not being duplicated by full scene copy.

Noted those as missing in XXX comments some time ago, running again on
that code I still see no reason for this missing feature, so now when
doing a full scene copy, including duplication of Freestyl's linestyles
and scene's greasepencil data, their potential Actions will also be
properly duplicated (like it was already the case for world, and scene

23 months agoCleanup: typo in comment.
Bastien Montagne [Mon, 4 Feb 2019 19:39:59 +0000 (20:39 +0100)]
Cleanup: typo in comment.

23 months agoCleanup: replace BKE_id_copy_ex by BKE_id_copy where possible.
Bastien Montagne [Mon, 4 Feb 2019 19:38:01 +0000 (20:38 +0100)]
Cleanup: replace BKE_id_copy_ex by BKE_id_copy where possible.

That way it is obvious when we are using default ID copy behaviour, and
when we are using advanced/specialized ones.

23 months agoCleanup: use LIB_ID_COPY_LOCALIZE in BKE_libblock_copy_for_localize().
Bastien Montagne [Mon, 4 Feb 2019 19:09:26 +0000 (20:09 +0100)]
Cleanup: use LIB_ID_COPY_LOCALIZE in BKE_libblock_copy_for_localize().

This is a slightly more risky commit, as it is very difficult to fathom
all that may happen when localazing IDs. Would not expect any issue

Note that a big TODO remain to refactor fully that ID localization
process (for 'shading IDs'), it's still doing pretty much same thing as
regular out-of-main copies, but the infamous ntree topic makes it
delicate to handle...

23 months agoCleanup: sanitize BKE_libblock_copy_for_localize() copy flags.
Bastien Montagne [Mon, 4 Feb 2019 17:23:50 +0000 (18:23 +0100)]
Cleanup: sanitize BKE_libblock_copy_for_localize() copy flags.

Asking to not copy animdata, but copy actions, is pure nonsense (and
make LIB_ID_COPY_ACTIONS flag totally useless/no-op).

23 months agoCleanup: Remove old deprecated BKE_libblock_copy_nolib() from BKE_library.
Bastien Montagne [Mon, 4 Feb 2019 17:20:53 +0000 (18:20 +0100)]
Cleanup: Remove old deprecated BKE_libblock_copy_nolib() from BKE_library.

Was not used anymore, time to get rid of it.

23 months agoBKE_library: id_copy: More general usage of LIB_ID_COPY_LOCALIZE.
Bastien Montagne [Mon, 4 Feb 2019 16:51:15 +0000 (17:51 +0100)]
BKE_library: id_copy: More general usage of LIB_ID_COPY_LOCALIZE.

Turns out most of our 'local working copy' cases can use same set of

Note that this commit adds LIB_ID_COPY_CACHES to all our local meshes
copying, however this is no-op since that flag is unused during mesh
copying... We may want to add another set of flags without that one at
some point, but for now it would not be useful imho.

23 months agoBKE_library: add 'no preview' flag to LIB_ID_COPY_LOCALIZE.
Bastien Montagne [Mon, 4 Feb 2019 16:37:19 +0000 (17:37 +0100)]
BKE_library: add 'no preview' flag to LIB_ID_COPY_LOCALIZE.

No local work copy is expected to need preview data, at least it should
not. Part of copy flags cleanup, done in separate commit in case
something goes wrong here...

23 months agoCleanup: initial regrouping of ID create/copy flags.
Bastien Montagne [Mon, 4 Feb 2019 16:27:01 +0000 (17:27 +0100)]
Cleanup: initial regrouping of ID create/copy flags.

Those two first sets of flags should represent some common use cases.
The goal here is to reduce verbosity of calls to BKE_id_copy_ex, and
help make it more obvious the 'common behaviours' of ID copying across

23 months agoCleanup: comments before items in enums.
Bastien Montagne [Mon, 4 Feb 2019 15:29:02 +0000 (16:29 +0100)]
Cleanup: comments before items in enums.

23 months agoCleanup: BKE_library: rename id_copy to BKE_id_copy.
Bastien Montagne [Mon, 4 Feb 2019 15:22:28 +0000 (16:22 +0100)]
Cleanup: BKE_library: rename id_copy to BKE_id_copy.

Time to follow conventions for that one as well.

23 months agoCleanup: BKE_library: remove 'test' param of id_copy.
Bastien Montagne [Mon, 4 Feb 2019 14:34:31 +0000 (15:34 +0100)]
Cleanup: BKE_library: remove 'test' param of id_copy.

This was used in *one* place only... much better to have a dedicated
helper for that kind of things. ;)

23 months agoFix T61107: wmGizmo.test_select can't return -1
Campbell Barton [Tue, 5 Feb 2019 07:38:31 +0000 (18:38 +1100)]
Fix T61107: wmGizmo.test_select can't return -1

This is used to skip selection.

23 months agoFix: Ensure that KeyingSet.bl_description field is properly escaped when using the...
Joshua Leung [Tue, 5 Feb 2019 03:21:35 +0000 (16:21 +1300)]
Fix: Ensure that KeyingSet.bl_description field is properly escaped when using the Export to File operator

Previously, if double-quotes appeared in the KeyingSet.bl_description field,
these would cause a syntax error in the resulting .py script export of the
KeyingSet. Since single quotes are even more likely to appear
(e.g. as apostrophes), we now use triple quotes here.

Unreported bug, noticed earlier when investigating T61010.

23 months agoFix T58221: Spin tool w/ merge first/last crashes
Campbell Barton [Tue, 5 Feb 2019 02:25:55 +0000 (13:25 +1100)]
Fix T58221: Spin tool w/ merge first/last crashes

Spinning geometry that included non boundary/wire edges
crashed when merge first/last enabled.

23 months agoFix empty object front/back display in perspective views
Campbell Barton [Mon, 4 Feb 2019 23:39:43 +0000 (10:39 +1100)]
Fix empty object front/back display in perspective views

23 months agoFix T61163: Single sided images show when viewed from side
Campbell Barton [Mon, 4 Feb 2019 23:29:19 +0000 (10:29 +1100)]
Fix T61163: Single sided images show when viewed from side

23 months agoCleanup: remove contributors for Python files
Campbell Barton [Mon, 4 Feb 2019 22:15:18 +0000 (09:15 +1100)]
Cleanup: remove contributors for Python files

Following removal from C source code.

See: 8c68ed6df16d8893

23 months agoCleanup: remove contributors for CMake files
Campbell Barton [Mon, 4 Feb 2019 22:10:32 +0000 (09:10 +1100)]
Cleanup: remove contributors for CMake files

Following removal from C source code.

See: 8c68ed6df16d8893

23 months agoT61148: Particle properties can not be edited after keyframing
Sergey Sharybin [Mon, 4 Feb 2019 13:06:49 +0000 (14:06 +0100)]
T61148: Particle properties can not be edited after keyframing

Was happening with certain settings for hair. Need to make a copy
of particle settings before modifying them via animation system.

23 months agoPyAPI: use _PyObject_LookupAttr
Campbell Barton [Mon, 4 Feb 2019 12:35:23 +0000 (23:35 +1100)]
PyAPI: use _PyObject_LookupAttr

Unlike PyObject_GetAttr, this avoids setting the attribute error
only to clear it - under some conditions.

23 months agoCleanup: use sys.platform instead of platform module
Campbell Barton [Mon, 4 Feb 2019 12:07:06 +0000 (23:07 +1100)]
Cleanup: use sys.platform instead of platform module

This was indirectly importing other modules we don't use at startup.
`sys.platform` is sufficient.

23 months agoPython: bump minimum version to 3.7
Campbell Barton [Mon, 4 Feb 2019 10:58:34 +0000 (21:58 +1100)]
Python: bump minimum version to 3.7

All platforms use 3.7 now, supporting both increases chance some scripts
will fail on older versions.

23 months agoFix T61172: Crash in texture paint undo/redo
Campbell Barton [Mon, 4 Feb 2019 08:50:46 +0000 (19:50 +1100)]
Fix T61172: Crash in texture paint undo/redo

Mixing texture paint undo w/ memfile undo was crashing.

The gputextures and render result are written to the FileData.imamap
but weren't read back.

23 months agoUndo System: add function to print undo steps
Campbell Barton [Mon, 4 Feb 2019 04:01:55 +0000 (15:01 +1100)]
Undo System: add function to print undo steps

Useful for debugging.

23 months agoFix adding a paint texture slot not refreshing
Campbell Barton [Mon, 4 Feb 2019 03:40:11 +0000 (14:40 +1100)]
Fix adding a paint texture slot not refreshing

Adding a new slot wasn't refreshing when the
object had no material.

23 months agoUI: Use 'None' label instead of 'No' for Physics Type
Pablo Vazquez [Mon, 4 Feb 2019 00:45:53 +0000 (01:45 +0100)]
UI: Use 'None' label instead of 'No' for Physics Type

Matches other enums in particle settings and pretty much all over Blender.

23 months agoCleanup: Typos in comments (to to)
Pablo Vazquez [Mon, 4 Feb 2019 00:23:48 +0000 (01:23 +0100)]
Cleanup: Typos in comments (to to)

23 months agoUI: clarify ruler tooltip text
Campbell Barton [Sun, 3 Feb 2019 23:32:17 +0000 (10:32 +1100)]
UI: clarify ruler tooltip text

See T61151

23 months agoGP: Fix compiler error
Antonioya [Sun, 3 Feb 2019 18:56:57 +0000 (19:56 +0100)]
GP: Fix compiler error