6 years agoWorkaround failing with msgfmt
Campbell Barton [Tue, 5 May 2015 17:23:20 +0000 (03:23 +1000)]
Workaround failing with msgfmt

6 years agoFix reading uninitialized memory finding paths
Campbell Barton [Tue, 5 May 2015 16:22:00 +0000 (02:22 +1000)]
Fix reading uninitialized memory finding paths

6 years agoBGE: Remove function DisableCcdPhysicsController and EnableCcdPhysicsController in...
Porteries Tristan [Tue, 5 May 2015 13:18:29 +0000 (15:18 +0200)]
BGE: Remove function DisableCcdPhysicsController and EnableCcdPhysicsController in CcdPhysicsEnvironment

Replace EnableCcdPhysicsController by AddCcdPhysicsController and DisableCcdPhysicsController by RemoveCcdPhysicsController.
Tested with compound shapes and collision sensors.

Reviewers:agoose77, ideasman42

6 years agoCleanup: Remove leftover from Distorted Noise node in XML reader.
Thomas Dinges [Tue, 5 May 2015 08:38:45 +0000 (10:38 +0200)]
Cleanup: Remove leftover from Distorted Noise node in XML reader.

6 years agoMath Lib: rename fill_*, to copy_*
Campbell Barton [Tue, 5 May 2015 07:08:29 +0000 (17:08 +1000)]
Math Lib: rename fill_*, to copy_*

matching convention for fixed length api, eg: copy_v3_fl

6 years agoCleanup: function arg wrapping
Campbell Barton [Tue, 5 May 2015 05:59:26 +0000 (15:59 +1000)]
Cleanup: function arg wrapping

6 years agoCleanup: rip tool
Campbell Barton [Tue, 5 May 2015 05:10:53 +0000 (15:10 +1000)]
Cleanup: rip tool

6 years agoCycles: Use curve approximation for blackbody instead of lookup table
Sv. Lockal [Tue, 5 May 2015 06:11:54 +0000 (06:11 +0000)]
Cycles: Use curve approximation for blackbody instead of lookup table

Now we calculate color in range 800..12000 using an approximation a/x+bx+c for R and G and ((at + b)t + c)t + d) for B.
Max absolute error for RGB for non-lut function is less than 0.0001, which is enough to get the same 8 bit/channel color as for OSL with a noticeable performance difference.
However there is a slight visible difference between previous non-OSL implementation because of lookup table interpolation and offset-by-one mistake.
The previous implementation gave black color outside of soft range (t > 12000), now it gives the same color as for 12000.

Also blackbody node without input connected is being converted to value input at shader compile time.

Reviewers: dingto, sergey

Reviewed By: dingto

Subscribers: nutel, brecht, juicyfruit

Differential Revision:

6 years agoBMesh: improve rip tool /w mon-manifold verts
Campbell Barton [Mon, 4 May 2015 21:11:31 +0000 (07:11 +1000)]
BMesh: improve rip tool /w mon-manifold verts

Can now rip from multiple fans (mixed single faces or larger regions)

Also add BM_vert_is_manifold_region which only checks if a vert has disconnected fans.

6 years agoCleanup: style & const's
Campbell Barton [Mon, 4 May 2015 19:17:25 +0000 (05:17 +1000)]
Cleanup: style & const's

6 years agoCleanup: wrapped function indentation
Campbell Barton [Mon, 4 May 2015 17:13:47 +0000 (03:13 +1000)]
Cleanup: wrapped function indentation

6 years agoCleanup: deduplicate code.
Bastien Montagne [Mon, 4 May 2015 19:12:28 +0000 (21:12 +0200)]
Cleanup: deduplicate code.

FileBrowser had its own 'shorten_string' func, when we have a full fledge one in interface_widget code...

6 years agoRevert "Different drawing for object centers."
Antony Riakiotakis [Mon, 4 May 2015 16:00:29 +0000 (18:00 +0200)]
Revert "Different drawing for object centers."

This reverts commit 5a8629c0d7da6cfb4b696f1787111c9492e03aba.

It does not really work that well since objects can draw in front of
selection circles now.

6 years agoUI: location/scale were snapping to 10s
Campbell Barton [Mon, 4 May 2015 15:20:40 +0000 (01:20 +1000)]
UI: location/scale were snapping to 10s

In practice this isn't useful (for scale especially).

For float buttons with a very large range, don't attempt to match the snap to the range.

6 years agoUI: button snap (ctrl) was rounding down
Campbell Barton [Mon, 4 May 2015 15:05:09 +0000 (01:05 +1000)]
UI: button snap (ctrl) was rounding down

6 years agoFix T44503 full sample does not display any preview any more.
Antony Riakiotakis [Mon, 4 May 2015 14:57:17 +0000 (16:57 +0200)]
Fix T44503 full sample does not display any preview any more.

The fix exposes another error not fixed in this commit, escaping the
render will not flush the full sample render result correctly.

6 years agoFix eyedropper with quad-view
Campbell Barton [Mon, 4 May 2015 13:48:10 +0000 (23:48 +1000)]
Fix eyedropper with quad-view

6 years agoFix T44592: Zero scale on an axis, zeros all
Campbell Barton [Mon, 4 May 2015 12:26:38 +0000 (22:26 +1000)]
Fix T44592: Zero scale on an axis, zeros all

6 years agoFollow up to previous commit, remove depth of field from UI in
Antony Riakiotakis [Mon, 4 May 2015 12:38:02 +0000 (14:38 +0200)]
Follow up to previous commit, remove depth of field from UI in
wireframe/boundbox mode.

6 years agoFix T44594 disable depth of field in wireframe/bounding box modes. We
Antony Riakiotakis [Mon, 4 May 2015 12:34:44 +0000 (14:34 +0200)]
Fix T44594 disable depth of field in wireframe/bounding box modes. We
don't supply depth information in those modes so supporting the effects
does not really make sense

6 years agoFixed comment.
Lukas Tönne [Mon, 4 May 2015 12:30:46 +0000 (14:30 +0200)]
Fixed comment.

6 years agoCycles: Fix copy / paste mistake in XML reader.
Thomas Dinges [Mon, 4 May 2015 12:29:38 +0000 (14:29 +0200)]
Cycles: Fix copy / paste mistake in XML reader.

6 years agoFix possible crash with datatransfer operator when source object was hidden.
Bastien Montagne [Mon, 4 May 2015 12:28:52 +0000 (14:28 +0200)]
Fix possible crash with datatransfer operator when source object was hidden.

Mismatch in poll and exec funcs when getting active (source) object...

6 years agoDifferent drawing for object centers.
Antony Riakiotakis [Mon, 4 May 2015 11:53:07 +0000 (13:53 +0200)]
Different drawing for object centers.

Code here did depth test always and depth range 0.0.

There is no real reason for object centers to write and get tested
against depth buffer in this case, just disable the depth test instead

Helps with blurry object centers in depth of field mode too (centers
wrote depth 0 and were always blurry)

6 years agoBGE: Cleanup KX_BlenderSceneConverter.cpp
Porteries Tristan [Mon, 4 May 2015 11:32:28 +0000 (13:32 +0200)]
BGE: Cleanup KX_BlenderSceneConverter.cpp

This commit is a little cleanup for whitspaces, braces, spaces around operators and useless keywords struct/class.


6 years agoSeparate scene simplification into viewport and render
Sergey Sharybin [Mon, 4 May 2015 11:26:28 +0000 (16:26 +0500)]
Separate scene simplification into viewport and render

This way it is possible to have viewport simplification bumped all the way up,
making viewport really responsive but still have final render to use highest
subdivision possible.

Reviewers: lukastoenne, campbellbarton, dingto

Reviewed By: campbellbarton, dingto

Subscribers: dingto, nutel, eyecandy, venomgfx

Differential Revision:

6 years agoSkin Modifier: remove redundant edge-calculation
Campbell Barton [Mon, 4 May 2015 10:59:34 +0000 (20:59 +1000)]
Skin Modifier: remove redundant edge-calculation

6 years agoFix T42893: Skin Modifier, changes randomly toggling editmode
Campbell Barton [Mon, 4 May 2015 10:36:43 +0000 (20:36 +1000)]
Fix T42893: Skin Modifier, changes randomly toggling editmode

Own regression, previously it would do a full mesh normal calculation for each isolated shape
(could hang on meshes with many loose parts).

However the normals are needed, instead of doing a full calculation,
just set normals on new faces.

Thanks to Brecht for finding cause!

6 years agoSkin Modifier: Add missing operator stack pop
Brecht Van Lommel [Mon, 4 May 2015 10:25:59 +0000 (20:25 +1000)]
Skin Modifier: Add missing operator stack pop

6 years agoFix metadata display in sequencer lost after doing a preprocess
Antony Riakiotakis [Mon, 4 May 2015 10:52:58 +0000 (12:52 +0200)]
Fix metadata display in sequencer lost after doing a preprocess

IMB_makeSingleUser makes a copy and destroys metadata. I am not sure if
this is the safest way to make a single user ImBuf (setting the refcount
to 0 is simpler and there's less, but no zero, risk of dangling
pointers) but I will leave this as is for now in case there is an actual
need for a copy here. The alternative approach should be tested at some

6 years agoFreestyle: Fix for line style ID datablocks not copied when fully copying a scene.
Tamito Kajiyama [Mon, 4 May 2015 06:45:32 +0000 (15:45 +0900)]
Freestyle: Fix for line style ID datablocks not copied when fully copying a scene.

6 years agoDon't scale metadata font with zoom - makes strings not consistently
Antony Riakiotakis [Mon, 4 May 2015 10:30:26 +0000 (12:30 +0200)]
Don't scale metadata font with zoom - makes strings not consistently
adhere to the string length

6 years agoSupport displaying metadata for images in sequencer preview windows (not
Antony Riakiotakis [Mon, 4 May 2015 10:17:49 +0000 (12:17 +0200)]
Support displaying metadata for images in sequencer preview windows (not

6 years agoBGE Player: Fix compilation error after cleanup commit da8a62a
Sergey Sharybin [Mon, 4 May 2015 09:38:46 +0000 (14:38 +0500)]
BGE Player: Fix compilation error after cleanup commit da8a62a

6 years agoFix T29029: Grease pencil fails in Quad View
Campbell Barton [Mon, 4 May 2015 09:11:08 +0000 (19:11 +1000)]
Fix T29029: Grease pencil fails in Quad View

6 years agoFreestyle: Compilation error fix after recent changes in BKE_object_add()
Sergey Sharybin [Mon, 4 May 2015 08:51:51 +0000 (13:51 +0500)]
Freestyle: Compilation error fix after recent changes in BKE_object_add()

6 years agoCMake: Only consider it INFO is is missing
Campbell Barton [Mon, 4 May 2015 08:33:37 +0000 (18:33 +1000)]
CMake: Only consider it INFO is is missing

6 years agoCorrect own error in recent quad-view ruler fix
Campbell Barton [Mon, 4 May 2015 08:32:47 +0000 (18:32 +1000)]
Correct own error in recent quad-view ruler fix

6 years agoFix Buttons context, invalid object data access
Campbell Barton [Mon, 4 May 2015 08:02:56 +0000 (18:02 +1000)]
Fix Buttons context, invalid object data access

Another instance of T44376.
Crash where the Python context would access a stale pointer to the active object.

6 years agoButton Space: clear pin flag when NULL'ing pointer
Campbell Barton [Mon, 4 May 2015 06:12:12 +0000 (16:12 +1000)]
Button Space: clear pin flag when NULL'ing pointer

6 years agoFix T44376: Buttons context, invalid data access
Campbell Barton [Mon, 4 May 2015 05:07:24 +0000 (15:07 +1000)]
Fix T44376: Buttons context, invalid data access

Removing a scene from the buttons window would crash from a Python operator.

6 years agoCleanup: WM_main_remove_notifier_reference
Campbell Barton [Mon, 4 May 2015 02:40:38 +0000 (12:40 +1000)]
Cleanup: WM_main_remove_notifier_reference

Assumed the `reference` pointer is an ID, currently true, but may not always be.
Add a callback specifically for this purpose since cleaning up notifiers and space-types are different operations.

6 years agoCleanup: naming for callback wrappers
Campbell Barton [Mon, 4 May 2015 02:29:38 +0000 (12:29 +1000)]
Cleanup: naming for callback wrappers

6 years agoRemove redundant outliner lookup freeing objects
Campbell Barton [Mon, 4 May 2015 05:55:52 +0000 (15:55 +1000)]
Remove redundant outliner lookup freeing objects

6 years agoAdd name argument to data creation API calls
Campbell Barton [Mon, 4 May 2015 02:25:33 +0000 (12:25 +1000)]
Add name argument to data creation API calls

Was adding then renaming, unnecessarily.

6 years agoBGE: Added 'ghost' arg to KX_GameObject.suspendDynamics() method
Sybren A. Stüvel [Mon, 4 May 2015 04:04:09 +0000 (12:04 +0800)]
BGE: Added 'ghost' arg to KX_GameObject.suspendDynamics() method

The implementation of this 'ghost' argument already existed in the C++
source, but wasn't exposed to Python yet.

6 years agoBGE: Fix: Activate collision mask/group in UI.
Porteries Tristan [Sun, 3 May 2015 17:12:45 +0000 (19:12 +0200)]
BGE: Fix: Activate collision mask/group in UI.

6 years agoFix typos.
Tamito Kajiyama [Sun, 8 Mar 2015 07:47:30 +0000 (16:47 +0900)]
Fix typos.

6 years agoRigidbody: Fix viewport update when changing collision shape in toolbar
Sergej Reich [Sun, 3 May 2015 15:52:54 +0000 (17:52 +0200)]
Rigidbody: Fix viewport update when changing collision shape in toolbar

6 years agoFix T44591: Set PBone Group operator did not handled predifined group index in its...
Bastien Montagne [Sun, 3 May 2015 14:51:16 +0000 (16:51 +0200)]
Fix T44591: Set PBone Group operator did not handled predifined group index in its invoke func.

6 years agoFix T44185, Fix T44090: hair texture density working unreliable.
Krzysztof Recko [Sun, 3 May 2015 14:01:07 +0000 (16:01 +0200)]
Fix T44185, Fix T44090: hair texture density working unreliable.

"Unexisting" particles must be freed after the unexist flag has been set,
which was no longer the case after 78c491e62a5.

Reviewers: brecht

Differential Revision:

6 years agoFix T41739: 3D view solid draw mode missing some material node updates.
Brecht Van Lommel [Sun, 3 May 2015 13:36:47 +0000 (15:36 +0200)]
Fix T41739: 3D view solid draw mode missing some material node updates.

6 years agoFix T41893: inconsistent color management on sculpt texture nodes previews.
Brecht Van Lommel [Sun, 3 May 2015 13:06:17 +0000 (15:06 +0200)]
Fix T41893: inconsistent color management on sculpt texture nodes previews.

6 years agoCleanup: rename clear_skin & clear_mask operators to skin_clear and mask_clear.
Bastien Montagne [Sun, 3 May 2015 13:18:27 +0000 (15:18 +0200)]
Cleanup: rename clear_skin & clear_mask operators to skin_clear and mask_clear.

So that they match all other op names around - and sensible logic as well.

6 years agoFix T44589: No way to add a skin data layer manualy.
Bastien Montagne [Sun, 3 May 2015 13:09:48 +0000 (15:09 +0200)]
Fix T44589: No way to add a skin data layer manualy.

There are several ways to end up with an object with skin modifier, but no
skin data on the geometry. So we need an operator to add it by hands.

Also tweaked a bit UI of this modifier.

6 years agoWe do need to transform lnors in BKE_mesh_transform(), much handy for scripts.
Bastien Montagne [Sun, 3 May 2015 09:55:58 +0000 (11:55 +0200)]
We do need to transform lnors in BKE_mesh_transform(), much handy for scripts.

6 years agoAdded name attribute to instance_geometry nodes (request for Second Life)
Gaia Clary [Fri, 1 May 2015 10:15:55 +0000 (12:15 +0200)]
Added name attribute to instance_geometry nodes (request for Second Life)

6 years agoBMesh: rip-tool can now split off isolated fans
Campbell Barton [Sat, 2 May 2015 20:15:51 +0000 (06:15 +1000)]
BMesh: rip-tool can now split off isolated fans

Useful since there wasn't a good way to do this previously.

6 years agoBMesh: utility to split isolated loop regions
Campbell Barton [Sat, 2 May 2015 20:15:24 +0000 (06:15 +1000)]
BMesh: utility to split isolated loop regions

6 years agoCleanup: redundant vars
Campbell Barton [Sat, 2 May 2015 19:20:36 +0000 (05:20 +1000)]
Cleanup: redundant vars

6 years agoFix rna default value in BGE UI.
Porteries Tristan [Sat, 2 May 2015 17:46:27 +0000 (19:46 +0200)]
Fix rna default value in BGE UI.

6 years agoBMesh: rework BM_vert_is_manifold (simplify logic)
Campbell Barton [Sat, 2 May 2015 18:40:02 +0000 (04:40 +1000)]
BMesh: rework BM_vert_is_manifold (simplify logic)

- simplify boundary handling (walk from boundary - no need to reset walking)
- early exit when the vert has >2 boundaries
- use BM_vert_step_fan_loop to walk the fan

6 years agoBMesh: replace radial count with simple checks
Campbell Barton [Sat, 2 May 2015 07:12:32 +0000 (17:12 +1000)]
BMesh: replace radial count with simple checks

6 years agoSound now returns even if file fails to load
Campbell Barton [Sat, 2 May 2015 17:28:43 +0000 (03:28 +1000)]
Sound now returns even if file fails to load

With various codecs its hard to ensure a sound will load or not.

6 years agoFix ghash assert during BGE libload.
Porteries Tristan [Sat, 2 May 2015 16:02:19 +0000 (18:02 +0200)]
Fix ghash assert during BGE libload.

The assert message was caused by the multi call of BLO_library_append_begin in KX_BlenderSceneConverter::LinkBlendFile.

6 years agoFix T44586: Viet language problem for Blender Interface
Bastien Montagne [Sat, 2 May 2015 14:49:12 +0000 (16:49 +0200)]
Fix T44586: Viet language problem for Blender Interface

We were missing many of the complex diacritics combinations in latin extended additional code block...

Alawyas a pleasure to edit this font... :|

6 years agoCMake: use linker when available
Campbell Barton [Sat, 2 May 2015 12:11:29 +0000 (22:11 +1000)]
CMake: use linker when available

Gives noticeable speedup linking blender

6 years agoTurn bpy.utils into a package, so that we can easily add submodules to it.
Bastien Montagne [Sat, 2 May 2015 08:38:51 +0000 (10:38 +0200)]
Turn bpy.utils into a package, so that we can easily add submodules to it.

6 years agoBMesh: BM_mesh_edgesplit
Campbell Barton [Sat, 2 May 2015 06:05:32 +0000 (16:05 +1000)]
BMesh: BM_mesh_edgesplit

Did quite a few checks not to tag bad splits (which wasn't working perfectly)

Instead rely on BM_vert_separate not to create invalid geometry.

6 years agoBMesh: BM_vert_separate double edge fix
Campbell Barton [Sat, 2 May 2015 06:04:02 +0000 (16:04 +1000)]
BMesh: BM_vert_separate double edge fix

Splitting edges could give duplicates.

6 years agoBMesh: return error on mesh validate
Campbell Barton [Sat, 2 May 2015 05:52:27 +0000 (15:52 +1000)]
BMesh: return error on mesh validate

6 years agoCleanup: bmesh src/dst order in API args
Campbell Barton [Fri, 1 May 2015 09:30:41 +0000 (19:30 +1000)]
Cleanup: bmesh src/dst order in API args

6 years agoCleanup: use function attrs for BMesh inline funcs
Campbell Barton [Fri, 1 May 2015 09:16:58 +0000 (19:16 +1000)]
Cleanup: use function attrs for BMesh inline funcs

6 years agoObject Align Operator: Make it use modifiers in high quality bounding box calculation
Daniel Salazar [Fri, 1 May 2015 22:17:23 +0000 (16:17 -0600)]
Object Align Operator: Make it use modifiers in high quality bounding box calculation

6 years agoUpdated install_deps' Collada to 3335ac164e68b2512a40914b14c74db260e6ff7d.
Bastien Montagne [Fri, 1 May 2015 19:18:08 +0000 (21:18 +0200)]
Updated install_deps' Collada to 3335ac164e68b2512a40914b14c74db260e6ff7d.

6 years agoOSX: remove collada from fading out 32bit buildbot
Jens Verwiebe [Fri, 1 May 2015 19:09:21 +0000 (21:09 +0200)]
OSX: remove collada from fading out 32bit buildbot

6 years agoFix T44353, Fix T43981: random particle distribution overlaps if number is greater...
Brecht Van Lommel [Fri, 1 May 2015 17:14:28 +0000 (19:14 +0200)]
Fix T44353, Fix T43981: random particle distribution overlaps if number is greater than 256.

6 years agoFix T43711: dual quaternion deform bug with shearing in deform matrix.
Brecht Van Lommel [Fri, 1 May 2015 14:19:06 +0000 (16:19 +0200)]
Fix T43711: dual quaternion deform bug with shearing in deform matrix.

This also increases the tolerances in is_orthogonal / is_orthonormal functions,
which were much too low for practical purposes.

6 years agoAuto pack: don't show "No new files have been packed" on every .blend file save.
Brecht Van Lommel [Fri, 1 May 2015 14:03:45 +0000 (16:03 +0200)]
Auto pack: don't show "No new files have been packed" on every .blend file save.

6 years agoFix T44433: print "unknown" rather than "1970-01-01" when .blend date is unknown.
Brecht Van Lommel [Fri, 1 May 2015 13:52:53 +0000 (15:52 +0200)]
Fix T44433: print "unknown" rather than "1970-01-01" when .blend date is unknown.

6 years agoFix a couple of harmless compiler warnings.
Brecht Van Lommel [Fri, 1 May 2015 17:17:14 +0000 (19:17 +0200)]
Fix a couple of harmless compiler warnings.

6 years agoFix T44560: Merge Collapse tool - UVs operator panel option ignored with Collapse...
Bastien Montagne [Fri, 1 May 2015 15:10:39 +0000 (17:10 +0200)]
Fix T44560: Merge Collapse tool - UVs operator panel option ignored with Collapse but not with other merge types.

Was missing parameter for collapse bmesh operator...

6 years agoFix T44577: writing tessellated cddata when we should not...
Bastien Montagne [Fri, 1 May 2015 14:11:55 +0000 (16:11 +0200)]
Fix T44577: writing tessellated cddata when we should not...

Own mistake in rBf75c89b3f42ffac51603e6e53459f9d94a8782cc...

6 years agoUse mono font for metadata
Antony Riakiotakis [Fri, 1 May 2015 12:27:44 +0000 (14:27 +0200)]
Use mono font for metadata

6 years agoFix T44565 World background artifacts when world shader is void (or
Antony Riakiotakis [Fri, 1 May 2015 10:06:05 +0000 (12:06 +0200)]
Fix T44565 World background artifacts when world shader is void (or
compilation fails).

6 years agoLeft some debug prints in here...
Joshua Leung [Fri, 1 May 2015 00:42:40 +0000 (12:42 +1200)]
Left some debug prints in here...

6 years agoFix T43867: Clicking outside the viewport exits now Grease Pencil "Continous Draw...
Joshua Leung [Fri, 1 May 2015 00:42:10 +0000 (12:42 +1200)]
Fix T43867: Clicking outside the viewport exits now Grease Pencil "Continous Draw" mode

When working with a pen only, it was previously impossible to exit Grease Pencil
draw mode (when continous drawing was enabled). Now, clicking outside the drawing region
(e.g. in the timeline, properties editor, or the header/properties/toolshelf regions)
where you are drawing will exit this mode.

Some corner cases to be aware of:
* When Region Overlap is enabled, clicking on the overlapping panels still exits
  draw mode (even though you can see behind the buttons)
* In the Nodes Editor, clicking on a node (while in drawmode) will still draw a
  dot/stroke. But, you can still exit drawmode by clicking on any of the panels
  (properties/toolshelf/header) mentioned earlier
* To cope with cases where the operator is launched from the toolshelf, the
  code now sets a new "active region" when the first stroke is performed
  (based on what region is under the cursor at the time of that stroke),
  overwriting the setting that got stored when invoking the operator (i.e. the toolshelf).
  This change doesn't have any real user-visible effects, other than making it possible for
  this fix to actually work without breaking that use case.

6 years agoBMesh: correct bmesh_edge_vert_swap
Campbell Barton [Thu, 30 Apr 2015 20:51:16 +0000 (06:51 +1000)]
BMesh: correct bmesh_edge_vert_swap

Missed swapping out loops.

6 years agoBMesh: add bmesh_disk_vert_replace
Campbell Barton [Thu, 30 Apr 2015 20:18:04 +0000 (06:18 +1000)]
BMesh: add bmesh_disk_vert_replace

6 years agoCleanup: typos
Campbell Barton [Thu, 30 Apr 2015 19:45:41 +0000 (05:45 +1000)]
Cleanup: typos

6 years agoData transfer - Loop Islands Hell Fixes.
Bastien Montagne [Thu, 30 Apr 2015 18:58:34 +0000 (20:58 +0200)]
Data transfer - Loop Islands Hell Fixes.

This commit fixes several issues:
* island_store->items_to_islands_num was reset each time we added a new island, this is stupid! Harmless too, though, afaikt.
* partial verts bvhtree (with several islands) was hugely over-allocated...
* we would 'leak' in neighbor islands when geometry itself was contiguous.
* best_nor_dot was used incorrectly, leading to smaller weights for better matching normal!

All those fixes are related to T44522 (through personal communications with reporter).

6 years agoUI: use enum for thumbnail size
Campbell Barton [Thu, 30 Apr 2015 15:49:58 +0000 (01:49 +1000)]
UI: use enum for thumbnail size

6 years agoCorrect warning
Campbell Barton [Thu, 30 Apr 2015 15:36:36 +0000 (01:36 +1000)]
Correct warning

6 years agoRNA defaults test
Campbell Barton [Thu, 30 Apr 2015 15:03:55 +0000 (01:03 +1000)]
RNA defaults test

Alternative to T32894, simple test which creates new data and compares with RNA defaults.

Can be used to keep the values in sync without having to maintain a large set of defines.

6 years agoBetter fix for T44556: Crash on the World Properties > Preview
Dalai Felinto [Thu, 30 Apr 2015 15:11:48 +0000 (12:11 -0300)]
Better fix for T44556: Crash on the World Properties > Preview

6 years agoRevert "Fix T44556: Crash on the World Properties > Preview"
Dalai Felinto [Thu, 30 Apr 2015 13:22:47 +0000 (10:22 -0300)]
Revert "Fix T44556: Crash on the World Properties > Preview"

This reverts commit 4bcc7a2ec6bf6937778a2227c7f938c50a0fafe5.

6 years agoPy/RNA: support to load and remove sounds
Campbell Barton [Thu, 30 Apr 2015 14:57:12 +0000 (00:57 +1000)]
Py/RNA: support to load and remove sounds

6 years agoFix opengl rendering always looking through camera
Antony Riakiotakis [Thu, 30 Apr 2015 13:06:10 +0000 (15:06 +0200)]
Fix opengl rendering always looking through camera

Actually check if we have a camera and looking through it before
rendering in multiview.

6 years agoFix T44439: outliner's treestore could keep invalid ID pointers, could crash on undo...
Bastien Montagne [Thu, 30 Apr 2015 12:04:41 +0000 (14:04 +0200)]
Fix T44439: outliner's treestore could keep invalid ID pointers, could crash on undo due to invalid mem access.

We cannot nuke treestore in readfile's `blo_lib_link_screen_restore()`, because this will
destroy all UI-state data (like opened/closed items, etc.).

Since we cannot know for sure whether an ID pointer from tselem->id is valid here, we
have to ensure they are never invalid, i.e. to always set them to NULL when we delete them.

To do so, this commit uses a similar approach as what already exists for ID references
in WM notifiers - it extends `free_notifier_reference_cb()` to also nullify those IDs in
all outliners.

Note that some ID types are not used(shown) by outliner currently, so `TREESTORE_ID_TYPE` macro
was added, that checks whether an ID is possibly used by outliner. Avoids a few searches
in whole tree whene deleting some IDs.

Reviewers: campbellbarton, sergey

Maniphest Tasks: T44439

Differential Revision:

6 years agoMissed this last commit
Antony Riakiotakis [Thu, 30 Apr 2015 12:24:05 +0000 (14:24 +0200)]
Missed this last commit