2 months agoFix T66742: Frame selected last weightpaint/vertexpaint stroke not
Philipp Oeser [Mon, 15 Jul 2019 21:35:11 +0000 (23:35 +0200)]
Fix T66742: Frame selected last weightpaint/vertexpaint stroke not

Mouse values [for 'paint_last_stroke_update()'] gone missing in

Thx @campbellbarton for hinting at convention to get mouse from sculpt

Reviewers: campbellbarton

Maniphest Tasks: T66742

Differential Revision:

2 months agoFix T66835: Dynamic Paint weight group isn't updated unless weight has been assigned
Sebastian Parborg [Tue, 16 Jul 2019 09:42:03 +0000 (11:42 +0200)]
Fix T66835: Dynamic Paint weight group isn't updated unless weight has been assigned

The dvert layer was not assigned to the mesh data if it had to be
created by the dpaint modifier.

Reviewed By: Brecht

Differential Revision:

2 months agoFix error in app-template image size check
Campbell Barton [Tue, 16 Jul 2019 09:40:23 +0000 (19:40 +1000)]
Fix error in app-template image size check

2 months agoFix assert unlinking text
Campbell Barton [Tue, 16 Jul 2019 07:27:53 +0000 (17:27 +1000)]
Fix assert unlinking text

Interferes with debugging.

2 months agoFix T67040: Undo crashes after renaming
Campbell Barton [Tue, 16 Jul 2019 07:14:19 +0000 (17:14 +1000)]
Fix T67040: Undo crashes after renaming

Caused by error keeping the first memfile undo step.

2 months agoCleanup: typos in comments
Campbell Barton [Tue, 16 Jul 2019 06:57:54 +0000 (16:57 +1000)]
Cleanup: typos in comments

2 months agoFix typo in background_job template
Campbell Barton [Tue, 16 Jul 2019 06:56:25 +0000 (16:56 +1000)]
Fix typo in background_job template

D5264 by @dimtion

2 months agoFix T67002: Crash redoing an action after ID rename
Campbell Barton [Tue, 16 Jul 2019 05:53:15 +0000 (15:53 +1000)]
Fix T67002: Crash redoing an action after ID rename

2 months agoDocs: remove debug value, matching source
Campbell Barton [Tue, 16 Jul 2019 03:26:37 +0000 (13:26 +1000)]
Docs: remove debug value, matching source

2 months agoFix T67009, T67013: crash with Intel HD Graphics and some older drivers
Brecht Van Lommel [Mon, 15 Jul 2019 20:40:50 +0000 (22:40 +0200)]
Fix T67009, T67013: crash with Intel HD Graphics and some older drivers

Add more versions to the workaround list.

2 months agoFix T64827: "Batch-Generate Previews" crashes.
Bastien Montagne [Mon, 15 Jul 2019 20:29:59 +0000 (22:29 +0200)]
Fix T64827: "Batch-Generate Previews" crashes.

Second completely unrelated issue reported in same task (tssst...),
caused by missing doversion code of some changes in recent-ish 2.80
development (tsst... again).

Proper fix for the issue (reverted rB8a5a8282ce48 was merely sweeping
the dirt under the carpet...).

2 months agoRevert "Fix T64827 (part two): "Batch-Generate Previews" fails with certain files"
Bastien Montagne [Mon, 15 Jul 2019 16:25:25 +0000 (18:25 +0200)]
Revert "Fix T64827 (part two): "Batch-Generate Previews" fails with certain files"

This reverts commit 8a5a8282ce48704e60e70cb02d747aede71e70b8.

2 months agoFix T66986: fix dylib plugins on macOS not working in code signed release
Brecht Van Lommel [Mon, 15 Jul 2019 20:13:11 +0000 (22:13 +0200)]
Fix T66986: fix dylib plugins on macOS not working in code signed release

Add more entitlements for code signing.

2 months agoFix T67016: crash drawing image editor without image
Brecht Van Lommel [Mon, 15 Jul 2019 20:20:51 +0000 (22:20 +0200)]
Fix T67016: crash drawing image editor without image

2 months agoFix T66983 Wireframe Display in edit mode edges missing when overlays are disabled
Clément Foucault [Mon, 15 Jul 2019 17:55:09 +0000 (19:55 +0200)]
Fix T66983 Wireframe Display in edit mode edges missing when overlays are disabled

2 months agoFix T66707 Modifying bone's 'Custom Object' reference shape causes blender to crash
Clément Foucault [Mon, 15 Jul 2019 17:24:32 +0000 (19:24 +0200)]
Fix T66707 Modifying bone's 'Custom Object' reference shape causes blender to crash

This was caused by an instancing batch not being initialized correctly.

2 months agoFix T66955: Cannot delete data from file in outliner.
Bastien Montagne [Mon, 15 Jul 2019 16:06:32 +0000 (18:06 +0200)]
Fix T66955: Cannot delete data from file in outliner.

That switch on ID types had not been updated since quiet some time it’d
seem... Using the ID_Type enum type now, so this should not happen again
(compiler will yell at you if you forget to add here any new ID type ;) ).

Also had to change a bit the code layout then, to deal with fake NLA ID

Note that for now, Screen IDs remain excluded from the ID menu usage,
due to T67004.

2 months agoFix T66712: A model shows artifacts in the sculpt mode
Sergey Sharybin [Mon, 15 Jul 2019 09:28:37 +0000 (11:28 +0200)]
Fix T66712: A model shows artifacts in the sculpt mode

Was a mistake in normals calculation: need to consider all grids for correct
average in the center of the face.

Reviewers: brecht

Reviewed By: brecht

Maniphest Tasks: T66712

Differential Revision:

2 months agoFix compositor ignoring mask parenting
Sergey Sharybin [Mon, 15 Jul 2019 11:59:07 +0000 (13:59 +0200)]
Fix compositor ignoring mask parenting

There are two aspects to the problem:

- Dependency graph update for compositor preview was missing
  updates flush.

  Apparently, update for new frame style of update will take
  care of flushing, but not the update tagged style of update.

  This goes to a legacy dependency graph and is to be changed
  at some point, but not so close to the release.

- Movie clips were missing from the compositor dependency graph.

This fixes part of T66519.

Reviewers: brecht

Reviewed By: brecht

Differential Revision:

2 months agoFix T66870: AutoIK-Len stops working after releasing the mouse
Sebastian Parborg [Mon, 15 Jul 2019 15:28:06 +0000 (17:28 +0200)]
Fix T66870: AutoIK-Len stops working after releasing the mouse

The code didn't check if we should initialize the transform auto IK parameters.
Cleaned up the code a bit too.

Reviewed By: Brecht

Differential Revision:

2 months agoFix T63349: image texture garbage collection causing freezes
Brecht Van Lommel [Mon, 15 Jul 2019 13:40:09 +0000 (15:40 +0200)]
Fix T63349: image texture garbage collection causing freezes

Images were being freed often because the tagging for when the image was last
used was missing.

Differential Revision:

2 months agoFix T66812: Particles + Build Modifier = Crash
Sergey Sharybin [Mon, 15 Jul 2019 12:09:57 +0000 (14:09 +0200)]
Fix T66812: Particles + Build Modifier = Crash

Particles can not be used with a destructive modifiers, so we can not
maker such configuration fully reliable.

Not sure this specific setup ever worked in 2.7x, maybe DM index was
somehow reset somewhere in particle system in older Blender version,
or maybe all of Blender version were crashing.

Anyway, seems to be very easy to avoid obvious index past the array
boundary in the mapping,

Reviewers: brecht, zeddb

Reviewed By: brecht

Maniphest Tasks: T66812

Differential Revision:

2 months agoFix T66941: GPencil wrong interpolation calculation for last keyframe
Antonioya [Mon, 15 Jul 2019 14:56:32 +0000 (16:56 +0200)]
Fix T66941: GPencil wrong interpolation calculation for last keyframe

The range used for frames was wrong and the last keyframe was way off of the correct place.

Thanks to @MagnumOctopus for catching the bug.

2 months agoFix T64827 (part two): "Batch-Generate Previews" fails with certain files
Philipp Oeser [Mon, 15 Jul 2019 09:53:57 +0000 (11:53 +0200)]
Fix T64827 (part two): "Batch-Generate Previews" fails with certain files

Some values (not properly handled by do_versions?) could cause
'rna_backup_restore()' to throw an error resulting in the whole preview
generation not being saved to the .blend file.

I've checked folowwing demo files:
- race_spaceship.blend
- wasp_bot.blend

Here the offending seetings were:
- `UnitSettings` (`length_unit`, ...)
- `FFmpegSettings` (`ffmpeg_preset`, ...)

For now, these are now excluded in `exclude_props`

Reviewers: brecht

Differential Revision:

2 months agoFix T66668: frame selected bone not working in weight paint mode
Philipp Oeser [Mon, 15 Jul 2019 14:20:11 +0000 (16:20 +0200)]
Fix T66668: frame selected bone not working in weight paint mode

'viewselected_exec()' [which uses evaluated view layer] would query
BASE_SELECTED flag, but it was not set on base_eval, but on its

reason for this is 'ed_object_select_pick()' would modify base flags
[through 'ED_object_base_select()'], but not tag scene

thx @sergey for hinting.

Reviewers: sergey, brecht

Maniphest Tasks: T66668

Differential Revision:

2 months agoFix T66686: Crash on Particle Edit, then Render
Sergey Sharybin [Mon, 15 Jul 2019 13:27:22 +0000 (15:27 +0200)]
Fix T66686: Crash on Particle Edit, then Render

Reviewers: brecht, zeddb

Reviewed By: brecht

Maniphest Tasks: T66686

Differential Revision:

2 months agoFix T66991 Crash when deleting edit bones when pchan is referenced by bendybone
Clément Foucault [Mon, 15 Jul 2019 13:13:33 +0000 (15:13 +0200)]
Fix T66991 Crash when deleting edit bones when pchan is referenced by bendybone

This was caused by loose pointers.

This diff takes care of clearing the fields of other bones before deleting the pchan.

Reviewers: brecht, sergey

Reviewed By: brecht, sergey

Differential Revision:

2 months agoFix T66986: errors with add-ons using ctypes in macOS release
Brecht Van Lommel [Mon, 15 Jul 2019 12:18:42 +0000 (14:18 +0200)]
Fix T66986: errors with add-ons using ctypes in macOS release

Add extra entitlements to allow the kind of unsigned executable memory access
that cytpes does.

2 months agoFix T66774 Lookdev: Assert switching from rendered to lookdev
Clément Foucault [Mon, 15 Jul 2019 11:14:50 +0000 (13:14 +0200)]
Fix T66774 Lookdev: Assert switching from rendered to lookdev

The View was being reused accross different redraw (not allowed).

2 months agoFix T66860 Crash on opening .blend file from 2.79
Clément Foucault [Mon, 15 Jul 2019 11:07:42 +0000 (13:07 +0200)]
Fix T66860 Crash on opening .blend file from 2.79

This was caused by the preview render of the material property panel being
1px wide. The computed half buffers width were rounded to 0.

2 months agoFix showing "__pycache__" in templates menu
Campbell Barton [Mon, 15 Jul 2019 09:39:24 +0000 (19:39 +1000)]
Fix showing "__pycache__" in templates menu

2 months agoFix reading directory as file content on Linux
Campbell Barton [Mon, 15 Jul 2019 09:24:59 +0000 (19:24 +1000)]
Fix reading directory as file content on Linux

Reading a directory as a file on Linux was attempting to allocate LONG_MAX,
this happens in template file lists (fix for that coming next).

2 months agoFix crash running GPU shader.format_calc() with attributes like gl_VertexID
Jeroen Bakker [Mon, 15 Jul 2019 09:24:18 +0000 (11:24 +0200)]
Fix crash running GPU shader.format_calc() with attributes like gl_VertexID

When using opengl attributes such as gl_VertexID in a shader its
location is set to -1. This location was used without checking in an
attribute array. This fails big time when called from python. For
example `print(shader.format_calc())` made python crash immediately.

this fixes

Reviewed By: fclem, brecht

Differential Revision:

2 months agoFix crash HD Graphics 4000 Series On Windows
Jeroen Bakker [Mon, 15 Jul 2019 06:21:26 +0000 (08:21 +0200)]
Fix crash HD Graphics 4000 Series On Windows

There was an workaround implemented for specific the Intel HD Graphics
4000 GPU on Windows platform. Other GPU from the same series also need
this workaround.

We will enable the workaround for specific drivers.

Reviewed By: brecht

Differential Revision:

2 months agoFix T66587: Can't bake second dynamic paint canvas to image sequence
Sebastian Parborg [Mon, 15 Jul 2019 08:46:36 +0000 (10:46 +0200)]
Fix T66587: Can't bake second dynamic paint canvas to image sequence

The issue was the the copy data function didn't copy the active canvas number.
So it would always be 0 and thus use the first canvas when trying to bake.

Also fix not copying unused type data (unused canvas/brush settings).

Reviewed By: Brecht

Differential Revision:

2 months agoFix T66957: GPencil material isolate crash when slot is empty
Antonioya [Mon, 15 Jul 2019 07:52:14 +0000 (09:52 +0200)]
Fix T66957: GPencil material isolate crash when slot is empty

When the slot of the material is empty, the loop to lock the materials tried to use the material but this was NULL.

Check if material is NULL before using it in other operators too.

2 months agoFix T66953: Duplicate items in pose context menu
Campbell Barton [Mon, 15 Jul 2019 04:21:58 +0000 (14:21 +1000)]
Fix T66953: Duplicate items in pose context menu

2 months agocleanup: typo in cycles 'min_transparent_bounces' tooltip
Philipp Oeser [Fri, 12 Jul 2019 19:27:37 +0000 (21:27 +0200)]
cleanup: typo in cycles 'min_transparent_bounces' tooltip

Reviewers: brecht

Differential Revision:

2 months agoCleanup: Do not use camel case for "Freestyle"
Aaron Carlisle [Sun, 14 Jul 2019 19:19:50 +0000 (15:19 -0400)]
Cleanup: Do not use camel case for "Freestyle"

2 months agomacOS: clarify bundle script instructions
Brecht Van Lommel [Fri, 12 Jul 2019 16:00:54 +0000 (18:00 +0200)]
macOS: clarify bundle script instructions

2 months agomacOS: allow bundle script to re-codesign a that was already signed
Brecht Van Lommel [Fri, 12 Jul 2019 16:58:44 +0000 (18:58 +0200)]
macOS: allow bundle script to re-codesign a that was already signed

2 months agomacOS: remove hardcoded paths for code signing python/dylib/so
Arto Kitula [Fri, 12 Jul 2019 12:44:16 +0000 (14:44 +0200)]
macOS: remove hardcoded paths for code signing python/dylib/so

Differential Revision:

2 months agoFix T66601: Redo Panels are empty the first time a workspace is active
mano-wii [Fri, 12 Jul 2019 14:37:18 +0000 (11:37 -0300)]
Fix T66601: Redo Panels are empty the first time a workspace is active

We need to indicate a preferred size to avoid `RGN_FLAG_TOO_SMALL` the first time the region is created.

Differential revision:

2 months agoFix T66773: Active edit-bone isn't updating
Campbell Barton [Fri, 12 Jul 2019 14:20:28 +0000 (00:20 +1000)]
Fix T66773: Active edit-bone isn't updating

2 months agoCleanup: use `_orig` as a suffix
Campbell Barton [Fri, 12 Jul 2019 14:14:14 +0000 (00:14 +1000)]
Cleanup: use `_orig` as a suffix

2 months agoUI: increase contrast for active bone
Campbell Barton [Fri, 12 Jul 2019 12:29:23 +0000 (22:29 +1000)]
UI: increase contrast for active bone

Follow up for T66747 fix, active color didn't contrast enough.

2 months agoFix T66747: Active bone not showing in edit-mode
Campbell Barton [Fri, 12 Jul 2019 12:23:39 +0000 (22:23 +1000)]
Fix T66747: Active bone not showing in edit-mode

2 months agoFix AttributeError in mesh properties panel when mesh is pinned
Sybren A. Stüvel [Fri, 12 Jul 2019 12:18:17 +0000 (14:18 +0200)]
Fix AttributeError in mesh properties panel when mesh is pinned

When a mesh datablock is pinned in the properties panel,
`context.object` is `None`. This in turn causes `obj.mode` to raise an
`AttributeError` exception as `None.mode` doesn't exist.

Since there is no (fast/simple) way to check whether the owning object
is in edit mode or not, the properties will be disabled. Not ideal, but
better than spewing an exception on every panel draw.

Reviewed By: campbellbarton, brecht

Differential Revision:

2 months agoFix T66689: Viewport isn't updating children hair particle on particle edit
Philipp Oeser [Thu, 11 Jul 2019 13:11:03 +0000 (15:11 +0200)]
Fix T66689: Viewport isn't updating children hair particle on particle edit

Reviewers: fclem, brecht

Maniphest Tasks: T66689

Differential Revision:

2 months agoFix T66694: depthdropper (camera focus distance) not working from View3D context...
Philipp Oeser [Thu, 11 Jul 2019 15:53:13 +0000 (17:53 +0200)]
Fix T66694: depthdropper (camera focus distance) not working from View3D context menu

Reviewers: campbellbarton, brecht

Maniphest Tasks: T66694

Differential Revision:

2 months agoFix T66446: UV editor "Deselect on Nothing" not working
Campbell Barton [Fri, 12 Jul 2019 09:17:17 +0000 (19:17 +1000)]
Fix T66446: UV editor "Deselect on Nothing" not working

2 months agoFix keymap editor missing tools for UV/Image space
Campbell Barton [Fri, 12 Jul 2019 09:05:03 +0000 (19:05 +1000)]
Fix keymap editor missing tools for UV/Image space

2 months agoFix T66675: Auto-Save override button has no tooltip
Campbell Barton [Fri, 12 Jul 2019 05:45:52 +0000 (15:45 +1000)]
Fix T66675: Auto-Save override button has no tooltip

2 months agoPreferences: disable reading preferences for regular file loading
Campbell Barton [Fri, 12 Jul 2019 04:58:37 +0000 (14:58 +1000)]
Preferences: disable reading preferences for regular file loading

Although the Auto-Run Python Scripts flag isn't used,
this is still a security risk since exclude paths list is.

Further this isn't what users would expect when loading a file &
only some preferences were being loaded so it's not useful.

2 months agoFix T66604: Cycles bake crash on specific scene with volume
Sergey Sharybin [Thu, 11 Jul 2019 13:22:03 +0000 (15:22 +0200)]
Fix T66604: Cycles bake crash on specific scene with volume

The issue was caused by un-initialized local storage for volume
intersection hits which are supposed to be stored in per-thread

Fix is to make thread_shader() be the same as thread_render() in
respect of KernelGlobals.

Reviewers: brecht

Reviewed By: brecht

Differential Revision:

2 months agoFix T66706: crash in viewport shading popover for workbench engine
Brecht Van Lommel [Thu, 11 Jul 2019 12:13:22 +0000 (14:13 +0200)]
Fix T66706: crash in viewport shading popover for workbench engine

Differential Revision:

2 months agoFix T66672: auto and manual texture space affected by modifiers
Brecht Van Lommel [Thu, 11 Jul 2019 11:39:19 +0000 (13:39 +0200)]
Fix T66672: auto and manual texture space affected by modifiers

It should be based on the mesh bounds before modifier stack evaluation, but
some modifiers were causing it to be recomputed. The flag to disable texture
space recomputation was not preserved through modifier evaluation.

Differential Revision:

2 months agoFix T66691: Ceash trying to render the 2.80 splash image
Sergey Sharybin [Thu, 11 Jul 2019 10:59:19 +0000 (12:59 +0200)]
Fix T66691: Ceash trying to render the 2.80 splash image

Was caused by ray direction becoming NaN after some of the bounces.

2 months agoAPI Doc link: make releases/RC's point to their own version of the doc.
Bastien Montagne [Thu, 11 Jul 2019 10:04:27 +0000 (12:04 +0200)]
API Doc link: make releases/RC's point to their own version of the doc.

Sounds kind of stupid to have 2.79 pointing to "current" which is now
2.80 API doc... Let's try to avoid that in future.

2 months agoFix for RC release step to also point at 'current' API doc link.
Bastien Montagne [Thu, 11 Jul 2019 09:50:58 +0000 (11:50 +0200)]
Fix for RC release step to also point at 'current' API doc link.

RC's are supposed to be like "real" releases...

2 months agoFix T66628: "Auto Saved Modified Image" not working
Jacques Lucke [Thu, 11 Jul 2019 10:06:21 +0000 (12:06 +0200)]
Fix T66628: "Auto Saved Modified Image" not working

Reviewer: brecht

2 months agoText: buffer from text, optional length return arg
Campbell Barton [Thu, 11 Jul 2019 04:18:39 +0000 (14:18 +1000)]
Text: buffer from text, optional length return arg

No functional changes (currently unused).

2 months agoFix T66658: Undo steps gets out sync with text/edit-mode
Campbell Barton [Wed, 10 Jul 2019 23:42:36 +0000 (09:42 +1000)]
Fix T66658: Undo steps gets out sync with text/edit-mode

2 months agoUndo System: add is_final argument (no functional changes)
Campbell Barton [Wed, 10 Jul 2019 23:36:59 +0000 (09:36 +1000)]
Undo System: add is_final argument (no functional changes)

This is needed step out of undo steps which accumulate changes,
larger changes could be made to handle this but better not
make them at this point.

2 months agoCleanup: avoid recursion for undo/redo step skipping
Campbell Barton [Wed, 10 Jul 2019 23:11:49 +0000 (09:11 +1000)]
Cleanup: avoid recursion for undo/redo step skipping

Simplifies making further changes.

2 months agoCleanup: clang-format
Campbell Barton [Wed, 10 Jul 2019 23:14:31 +0000 (09:14 +1000)]
Cleanup: clang-format

2 months agoCleanup: quiet warning
Campbell Barton [Wed, 10 Jul 2019 23:22:19 +0000 (09:22 +1000)]
Cleanup: quiet warning

2 months agoFix T66654: wireframe overlay crash in vertex paint in some cases
Jeroen Bakker [Wed, 10 Jul 2019 15:05:15 +0000 (17:05 +0200)]
Fix T66654: wireframe overlay crash in vertex paint in some cases

Differential Revision:

2 months agoSplash: new image for 2.80 by Andy Goralczyk and the Spring team
Brecht Van Lommel [Wed, 10 Jul 2019 13:54:41 +0000 (15:54 +0200)]
Splash: new image for 2.80 by Andy Goralczyk and the Spring team

2 months agoFix T66567: Weight painting crashes with specific mesh
Sergey Sharybin [Wed, 10 Jul 2019 14:03:19 +0000 (16:03 +0200)]
Fix T66567: Weight painting crashes with specific mesh

Seems the deform group index and deform vertices went out of sync somehow.

Added extra NULL pointer check, which seems to be safe and matches checks
in other places in the neighbourhood.

2 months agoFix strict compiler warning
Sergey Sharybin [Wed, 10 Jul 2019 13:03:57 +0000 (15:03 +0200)]
Fix strict compiler warning

2 months agoSplash: put version number in top right, refactor code for easier changes
Brecht Van Lommel [Wed, 10 Jul 2019 12:53:47 +0000 (14:53 +0200)]
Splash: put version number in top right, refactor code for easier changes

2 months agoSplash: use red heart icon for development fund
Brecht Van Lommel [Wed, 10 Jul 2019 10:40:18 +0000 (12:40 +0200)]
Splash: use red heart icon for development fund

Now that the development fund image will disappear from the splash, this
draws a little more attention to this link.

2 months agoFix splash screen margins not being even and buttons not centered
Brecht Van Lommel [Wed, 10 Jul 2019 12:48:58 +0000 (14:48 +0200)]
Fix splash screen margins not being even and buttons not centered

2 months agoFix release notes not showing in splash without recent files
Brecht Van Lommel [Wed, 10 Jul 2019 12:42:08 +0000 (14:42 +0200)]
Fix release notes not showing in splash without recent files

2 months agoFix T61770 Multiple Hair Systems Not visible while in particle edit mode
Clément Foucault [Wed, 10 Jul 2019 12:43:58 +0000 (14:43 +0200)]
Fix T61770 Multiple Hair Systems Not visible while in particle edit mode

The check was for the whole object instead of individual particle system.

2 months agoFix T66631: Crash when converting objects from Curve to Mesh
Sybren A. Stüvel [Wed, 10 Jul 2019 10:58:39 +0000 (12:58 +0200)]
Fix T66631: Crash when converting objects from Curve to Mesh

When `BKE_mesh_new_from_object()` cannot convert an object to a mesh, it
returns `NULL`. This case was not handled at all in
`BKE_mesh_new_from_object_to_bmain()` or `curvetomesh()`, causing a
segmentation fault.

This commit fixes the segmentation fault, and leaves the curve object as
a curve object.

Reviewed By: mont29, brecht, sergey

Differential Revision:

2 months agoFix T66530: set_stereo_3d (pageflip) exists Blender
Dalai Felinto [Tue, 9 Jul 2019 18:50:45 +0000 (15:50 -0300)]
Fix T66530: set_stereo_3d (pageflip) exists Blender

Note: Although this fixes the issue (as in, it prevents a crash)
BKE_reports are not working because of CTX_wm_window_set().

Reviewers: campbellbarton

Differential Revision:

2 months agoFix T66627: Multiobject Edit UV constraint to image bounds
Dalai Felinto [Tue, 9 Jul 2019 23:07:08 +0000 (20:07 -0300)]
Fix T66627: Multiobject Edit UV constraint to image bounds

This was broken since the original commit to handle multi-object
editing: rBbfc9d426bb95.

2 months agoFix T57489 Eevee: Texture coordinate object reference not working for world
Clément Foucault [Wed, 10 Jul 2019 11:46:23 +0000 (13:46 +0200)]
Fix T57489 Eevee: Texture coordinate object reference not working for world

2 months agoUndo System: ensure the text ID for each undo step is used
Campbell Barton [Wed, 10 Jul 2019 11:29:31 +0000 (21:29 +1000)]
Undo System: ensure the text ID for each undo step is used

In practice this wasn't causing errors,
however it could be an issue in the future.

2 months agoFix T65850 Sculpt: Vertices not hidden if using shape keys
Clément Foucault [Wed, 10 Jul 2019 11:23:47 +0000 (13:23 +0200)]
Fix T65850 Sculpt: Vertices not hidden if using shape keys

2 months agoFix T66560 Sequencer: Shortcut keys no showing in menu for 'Move' and 'Refresh All'
Sebastian Parborg [Wed, 10 Jul 2019 10:55:15 +0000 (12:55 +0200)]
Fix T66560 Sequencer: Shortcut keys no showing in menu for 'Move' and 'Refresh All'

The menu shortcut context for 'Refresh All' was wrong and the actual operation
exectuted in the menu for the 'Move' command was different from the shortcut.

2 months agoFix crash when clicking in window while Blender starts
Sybren A. Stüvel [Wed, 10 Jul 2019 10:32:10 +0000 (12:32 +0200)]
Fix crash when clicking in window while Blender starts

A mouse click in the window will trigger the `VIEW3D_OT_cursor3d` operator
before the viewport is available. This causes a segfault in

Other callers of `WM_draw_region_get_viewport()` already check for `NULL`
being returned and handle it gracefully.

Reviewed By: jbakker, fclem

Differential Revision:

2 months agoDrawManager: Crash Face Selection
Jeroen Bakker [Wed, 10 Jul 2019 09:06:14 +0000 (11:06 +0200)]
DrawManager: Crash Face Selection

Init the scene of the draw context when selecting. When using face dot selection on
when the subsurf modifier is active on the cage, the scene needs to be
valid. It is read from the context in the
`DRW_mesh_batch_cache_create_requested` and used in the `isDisabled`
method of the SubSurfModifier.

Reviewers: fclem, sergey

Differential Revision:

2 months agoFix T66630 X-Ray + Subdivision surface Face select problem
Clément Foucault [Wed, 10 Jul 2019 10:12:50 +0000 (12:12 +0200)]
Fix T66630 X-Ray + Subdivision surface Face select problem

2 months agoFix T66626: Crash when using JACK audio device
Sergey Sharybin [Wed, 10 Jul 2019 09:57:13 +0000 (11:57 +0200)]
Fix T66626: Crash when using JACK audio device

Restore some context overrides which were originally happening in 2.79.

Made it a bit more paranoid, by storing old values and restoring them
afterwards, so the context is not being changed at the end of the function.

2 months agoUndo: print the undo stack when ed.undo logging is enabled
Campbell Barton [Wed, 10 Jul 2019 09:37:33 +0000 (19:37 +1000)]
Undo: print the undo stack when ed.undo logging is enabled

Print the undo stack on undo/redo when ed.undo logging is enabled.

2 months agoC Logging: add macro to check if logging is enabled
Campbell Barton [Wed, 10 Jul 2019 09:36:54 +0000 (19:36 +1000)]
C Logging: add macro to check if logging is enabled

2 months agoDocs: note about select debug value
Campbell Barton [Wed, 10 Jul 2019 09:07:16 +0000 (19:07 +1000)]
Docs: note about select debug value

2 months agoFix broken Mesh 'calc_smooth_groups' logic.
Bastien Montagne [Wed, 10 Jul 2019 09:21:43 +0000 (11:21 +0200)]
Fix broken Mesh 'calc_smooth_groups' logic.

We need to check both polygons of a manifold edge to be sure it is
actually smooth...

Reported by Hugo Sales (@someonewithpc) on, thanks.

2 months agoFix T66571: Unable to change input color space of PSD
Sergey Sharybin [Wed, 10 Jul 2019 08:08:18 +0000 (10:08 +0200)]
Fix T66571: Unable to change input color space of PSD

Image reader must not override file's color space specification if it
is already specified.

2 months agoAlembic export: avoid BLI_assert() failure when object is not in depsgraph
Sybren A. Stüvel [Wed, 10 Jul 2019 07:56:27 +0000 (09:56 +0200)]
Alembic export: avoid BLI_assert() failure when object is not in depsgraph

When the object we iterate over is not part of the depsgraph, we cannot
get the evaluated copy to export. This workaround is temporary to avoid
a BLI_assert() failure getting the evaluated mesh of this object.

This will be handled more elegantly in the new AbstractHierarchyIterator
that I'm working on, but that requires a bigger change than we should
allow this close to the 2.80 release candidate.

This fixes a problem described in T58686.

2 months agoCleanup: avoid line breaks from trailing comments
Campbell Barton [Wed, 10 Jul 2019 04:41:19 +0000 (14:41 +1000)]
Cleanup: avoid line breaks from trailing comments

2 months agoCleanup: avoid accessing same vars multiple times
Campbell Barton [Wed, 10 Jul 2019 03:59:01 +0000 (13:59 +1000)]
Cleanup: avoid accessing same vars multiple times

2 months agoUI: use a label for strip 'frame_final_end'
Campbell Barton [Wed, 10 Jul 2019 03:48:03 +0000 (13:48 +1000)]
UI: use a label for strip 'frame_final_end'

This is intended for Python access and allows temporary negative frames
which is a problem when accessed from the UI.

This allows:

    seq.frame_final_start, seq.frame_final_end = frame_range

However it allows invalid sequence strips,
using a label is fine since there is a duration property here which
can change the length.

2 months agoCleanup: reserve single quotes for enums
Campbell Barton [Wed, 10 Jul 2019 03:39:56 +0000 (13:39 +1000)]
Cleanup: reserve single quotes for enums

2 months agoRevert strip start property to strip_start
Richard Antalik [Tue, 9 Jul 2019 22:45:08 +0000 (15:45 -0700)]
Revert strip start property to strip_start

Using strip_final_start affects strip offset while not moving content.

2 months agoFix T62580 Workbench: Shadow glitch due to degenerate threshold
Clément Foucault [Tue, 9 Jul 2019 18:38:40 +0000 (20:38 +0200)]
Fix T62580 Workbench: Shadow glitch due to degenerate threshold

Fix by adding a threshold instead of direct null comparison.

2 months agoFix T66565: crash linking unused light datablock during Cycles preview render
Brecht Van Lommel [Tue, 9 Jul 2019 17:48:38 +0000 (19:48 +0200)]
Fix T66565: crash linking unused light datablock during Cycles preview render