3 months agoFix T66605: Operation on origins not working correct
Sergey Sharybin [Tue, 9 Jul 2019 16:52:41 +0000 (18:52 +0200)]
Fix T66605: Operation on origins not working correct

3 months agoRaise particle count limit for 2.8 release
Sergey Sharybin [Tue, 9 Jul 2019 15:43:24 +0000 (17:43 +0200)]
Raise particle count limit for 2.8 release

Blender 2.8 features significant improvements in the creation of particles.
Removed hard limit and increased soft limit.

Patch by Gottfried Hofmann.
Differential Revision:

3 months agoAlembic import: fix crash when loading invalid mesh
Sybren A. Stüvel [Tue, 9 Jul 2019 14:57:30 +0000 (16:57 +0200)]
Alembic import: fix crash when loading invalid mesh

These were just some missing nullptr checks.

3 months agoFix T52814 and T58686: Alembic crashing on fluid sim export
Sybren A. Stüvel [Tue, 9 Jul 2019 14:22:52 +0000 (16:22 +0200)]
Fix T52814 and T58686: Alembic crashing on fluid sim export

The velocities std::vector was allocated in too narrow a scope, causing
use-after-free errors.

3 months agoFix T66456: UV Editor missing update after selection change in 3D viewport
Philipp Oeser [Tue, 9 Jul 2019 11:28:27 +0000 (13:28 +0200)]
Fix T66456: UV Editor missing update after selection change in 3D viewport

Reviewers: brecht

Maniphest Tasks: T66456

Differential Revision:

3 months agoFix T66610: Planar Track extremely laggy when 3D View is open
Sergey Sharybin [Tue, 9 Jul 2019 13:43:42 +0000 (15:43 +0200)]
Fix T66610: Planar Track extremely laggy when 3D View is open

The issue was caused by modifications to planar track tagging clip for
copy-on-write, which was invalidating its cache and forcing current
frame in 3D viewport to be re-load.

Ideal solution would be to share movie cache across original and
evaluated movie clips which will reduce memory usage. However, doing
such ownership changes so close to the code freeze is not something
comfortable to do.

3 months agoFix (minor) some typos and other errors in UI messages.
Bastien Montagne [Tue, 9 Jul 2019 13:29:54 +0000 (15:29 +0200)]
Fix (minor) some typos and other errors in UI messages.

3 months agoFix crash on redo applying transforms
Philipp Oeser [Tue, 9 Jul 2019 12:59:30 +0000 (14:59 +0200)]
Fix crash on redo applying transforms

When accessing evaluated objects, make sure access to an
evaluated dependency graph is done. This solves possible
access to NULL data on redo.


3 months agoFix uninitialized loop variable
Clément Foucault [Tue, 9 Jul 2019 12:55:27 +0000 (14:55 +0200)]
Fix uninitialized loop variable

Fix commit 226c6f086aa2

3 months agoFix T64149: Texture paint can act as a canvas and brush at the same time
Sebastian Parborg [Tue, 9 Jul 2019 12:43:25 +0000 (14:43 +0200)]
Fix T64149: Texture paint can act as a canvas and brush at the same time

I don't know if it was the intended behavior or not, but having brush
and canvas data at the same time with dymanic paint, would lead to the
object trying to act as a brush and a canvas at the same time.

We can't currently handle this with the new depsgraph, and it could
legitimately lead to bad feedback loops.

So now, to be more consistent with the GUI, I've made it only use the
current set type (brush or canvas) as the final type of the object.
That is, you can only have a object be a brush or a canvas, not both at
the same time.

3 months agoFix crash when redoing Set Origin operator
Sybren A. Stüvel [Tue, 9 Jul 2019 12:45:08 +0000 (14:45 +0200)]
Fix crash when redoing Set Origin operator

The operator was using a non-evaluated depsgraph to get the evaluated
scene, which caused the crash.

This fixes the crash reported in T66605, but not the problem where
sometimes object origins aren't set.

3 months agoEevee: Fix first sample being accumulated without SSR
Clément Foucault [Tue, 9 Jul 2019 12:34:38 +0000 (14:34 +0200)]
Eevee: Fix first sample being accumulated without SSR

We check if the previous iteration (sample) was using a valid double buffer.
If it wasn't, we request another iteration.

This fix the issue for viewport,viewport render and image render.

Related to T65761 Eevee render inconsistency between 3D View, Viewport render, and F12 Render

3 months agoFix T65761 Eevee: SSRefraction not working on first sample
Clément Foucault [Tue, 9 Jul 2019 12:32:02 +0000 (14:32 +0200)]
Fix T65761 Eevee: SSRefraction not working on first sample

There is no reason to disable the refraction on the first sample like SSR

This was caussing issues when rendering.

3 months agoCleanup: GPU: Correct comment
Clément Foucault [Tue, 9 Jul 2019 10:46:20 +0000 (12:46 +0200)]
Cleanup: GPU: Correct comment

3 months agoFix T61474: laggy interaction on Windows/NVIDIA when gizmos are visible
Brecht Van Lommel [Tue, 9 Jul 2019 11:20:25 +0000 (13:20 +0200)]
Fix T61474: laggy interaction on Windows/NVIDIA when gizmos are visible

Thanks to Sergey and Clément for helping to track this down.

3 months agoFix T57652: Multires undo broken with shared object data
Sergey Sharybin [Tue, 9 Jul 2019 10:12:18 +0000 (12:12 +0200)]
Fix T57652: Multires undo broken with shared object data

3 months agoGPU: ATI Proxy check
Jeroen Bakker [Tue, 9 Jul 2019 09:36:11 +0000 (11:36 +0200)]
GPU: ATI Proxy check

The AMD PRO driver on linux PROXY check also fails. Now the
configuration ATI/Unix/Official driver  will also bypass the
Proxy test.

Reviewed By: fclem

Differential Revision:

3 months agoFix T64483: crash when hovering over outliner after closing render window
Sybren A. Stüvel [Tue, 9 Jul 2019 09:51:56 +0000 (11:51 +0200)]
Fix T64483: crash when hovering over outliner after closing render window

The `tselem->id` pointer can also be used for non-ID data (according to
this comment in DNA_outliner_types.h:

/* XXX We actually also store non-ID data in this pointer for identifying
 * the TreeStoreElem for a TreeElement when rebuilding the tree. Ugly! */

As such, I don't mind adding a `NULL`-check in the
`is_object_data_in_editmode()` function. After all, when there is no
object, its data certainly is not in edit mode.

3 months agoFix T66274: Object Texture Coordinate mode not updating in Lookdev / Eevee
Sergey Sharybin [Tue, 9 Jul 2019 09:24:39 +0000 (11:24 +0200)]
Fix T66274: Object Texture Coordinate mode not updating in Lookdev / Eevee

3 months agoImplement Movieclip filter for action editors
Sergey Sharybin [Mon, 8 Jul 2019 15:27:57 +0000 (17:27 +0200)]
Implement Movieclip filter for action editors

Allows to disable keyframes from movie clips in dopesheet.

Reviewers: brecht

Reviewed By: brecht

Subscribers: sebastian_k

Differential Revision:

3 months agoFix T66516: WPaint crash selecting bone with wire & face-mask
Campbell Barton [Tue, 9 Jul 2019 05:13:58 +0000 (15:13 +1000)]
Fix T66516: WPaint crash selecting bone with wire & face-mask

3 months agoFix T66359: UV editor ignores face-dot size
Campbell Barton [Tue, 9 Jul 2019 02:24:16 +0000 (12:24 +1000)]
Fix T66359: UV editor ignores face-dot size

D5178 by @deadpin

3 months agoAPI Docs: Change handling of Blender Version
Aaron Carlisle [Tue, 9 Jul 2019 00:52:29 +0000 (20:52 -0400)]
API Docs: Change handling of Blender Version

3 months agoAPI Docs: Hide Home Icon in Seach Area
Aaron Carlisle [Mon, 8 Jul 2019 23:44:47 +0000 (19:44 -0400)]
API Docs: Hide Home Icon in Seach Area

3 months agoGPU: added debug value to investigate lagging issue in T6147
Brecht Van Lommel [Mon, 8 Jul 2019 23:20:44 +0000 (01:20 +0200)]
GPU: added debug value to investigate lagging issue in T6147

3 months agoFix T55192: Speed fx applied to scene messed up animation
Richard Antalik [Mon, 8 Jul 2019 21:53:40 +0000 (14:53 -0700)]
Fix T55192: Speed fx applied to scene messed up animation

Don't update animdata after rendering scene
Rendering host scene from sequencer is not supported, removed code is unnecessary.

Reviewed By: brecht

Differential Revision:

3 months agoFix T66573 Heap Corruption when baking to irradiance volume probe
Clément Foucault [Mon, 8 Jul 2019 21:24:15 +0000 (23:24 +0200)]
Fix T66573 Heap Corruption when baking to irradiance volume probe

This is an AMD Proprietary driver bug. Will be reported upstream.

3 months agoFix (unreported) UI: useless setting shown for Text data-blocks.
Bastien Montagne [Mon, 8 Jul 2019 20:44:57 +0000 (22:44 +0200)]
Fix (unreported) UI: useless setting shown for Text data-blocks.

Since we do not have start/end settings for bevel object for Text,
mapping taper to those ends makes no sense here, we can hide that

3 months agoFix T61401: Failure to register a `GizmoGroup` after unregistering it
mano-wii [Mon, 8 Jul 2019 16:48:01 +0000 (13:48 -0300)]
Fix T61401: Failure to register a `GizmoGroup` after unregistering it

It does not seem right to rely on the python code to fix problems in the C code.
But this already works like this with the other Python Classes.

3 months agoRevert "Fix T61401: Failure to register a `GizmoGroup` after unregistering it"
mano-wii [Mon, 8 Jul 2019 16:44:03 +0000 (13:44 -0300)]
Revert "Fix T61401: Failure to register a `GizmoGroup` after unregistering it"

Problems with ClangFormat

This reverts commit c1bcde0c0feaf8bcfbd3664a52c50611806538ac.

3 months agoRevert "Revert "Fix T63447 Particle system: No particles after switching from hair...
mano-wii [Mon, 8 Jul 2019 16:41:27 +0000 (13:41 -0300)]
Revert "Revert "Fix T63447 Particle system: No particles after switching from hair to ...""

This reverts commit 45761e4c7cbbed2141afc97fb20b2bf26ce19ac2.

3 months agoRevert "Fix T63447 Particle system: No particles after switching from hair to ..."
mano-wii [Mon, 8 Jul 2019 16:40:06 +0000 (13:40 -0300)]
Revert "Fix T63447 Particle system: No particles after switching from hair to ..."

Problems with clang style

This reverts commit 8d6a5fb5d3c45cdfb0d06dd7f1f18aa8c870f8c1.

3 months agoFix T61401: Failure to register a `GizmoGroup` after unregistering it
mano-wii [Mon, 8 Jul 2019 16:37:17 +0000 (13:37 -0300)]
Fix T61401: Failure to register a `GizmoGroup` after unregistering it

3 months agoFix T63447 Particle system: No particles after switching from hair to ...
Clément Foucault [Mon, 8 Jul 2019 16:00:57 +0000 (18:00 +0200)]
Fix T63447 Particle system: No particles after switching from hair to ...

... emitter type

3 months agoFix T63659 "Viewport render image" don't process corectly "Display As" option
Clément Foucault [Mon, 8 Jul 2019 14:53:01 +0000 (16:53 +0200)]
Fix T63659 "Viewport render image" don't process corectly "Display As" option

3 months agoFix T66008 Viewport: hidden edges are partially visible
Clément Foucault [Mon, 8 Jul 2019 12:18:12 +0000 (14:18 +0200)]
Fix T66008 Viewport: hidden edges are partially visible

This was a regression from 2.79. The zoffset was doubled for some reason.

3 months agoFix T65534 Eevee don't respect active UVmap
Clément Foucault [Mon, 8 Jul 2019 11:35:55 +0000 (13:35 +0200)]
Fix T65534 Eevee don't respect active UVmap

3 months agoFix T66351 Wireframe display in sculpt-mode broke when hiding parts
Clément Foucault [Mon, 8 Jul 2019 09:56:57 +0000 (11:56 +0200)]
Fix T66351 Wireframe display in sculpt-mode broke when hiding parts

3 months agoFix T66348 Eevee: Broken shader if using textures and shader_to_rgb node
Clément Foucault [Sun, 7 Jul 2019 21:04:45 +0000 (23:04 +0200)]
Fix T66348 Eevee: Broken shader if using textures and shader_to_rgb node

Was caused by a missing texture resource.

3 months agoFix T66475 Spin Modifier: Merge Vert Makes mesh disappear
Clément Foucault [Sun, 7 Jul 2019 17:01:37 +0000 (19:01 +0200)]
Fix T66475 Spin Modifier: Merge Vert Makes mesh disappear

3 months agoFix T66470 Planar track is not adjustable
Clément Foucault [Sun, 7 Jul 2019 16:59:19 +0000 (18:59 +0200)]
Fix T66470 Planar track is not adjustable

The issue was that the shader used was expecting GL_LINES and the points
were using GL_TRIANGLE_FAN.

3 months agoFix T62941 Subdivision Modifier Showing all face dots
Clément Foucault [Sun, 7 Jul 2019 16:58:11 +0000 (18:58 +0200)]
Fix T62941 Subdivision Modifier Showing all face dots

Previously in 2.79 we were using a specialized drawing using derivedMesh.

Now the subsurf modifier tag each center vertex as facedot and let the
DRWManager pick it up.

Some modifiers (deforming ones) do not clear the tag so we can use this
technique even if there is deforming modifiers after subsurf modifiers.

3 months agoFix T61129 Eevee: alpha texture shadow bug
Clément Foucault [Fri, 5 Jul 2019 19:11:27 +0000 (21:11 +0200)]
Fix T61129 Eevee: alpha texture shadow bug

Seems like the AMD pro driver does not consider dead code the same as other
glsl compiler.

3 months agoAPI Docs: Fix file name
Aaron Carlisle [Mon, 8 Jul 2019 15:43:04 +0000 (11:43 -0400)]
API Docs: Fix file name

3 months agoFix T66556: Noisy drivers relations in certain cases
Sergey Sharybin [Mon, 8 Jul 2019 15:37:58 +0000 (17:37 +0200)]
Fix T66556: Noisy drivers relations in certain cases

3 months agoFix T62903: black line in UV editor on 32 bit
Brecht Van Lommel [Mon, 8 Jul 2019 15:34:22 +0000 (17:34 +0200)]
Fix T62903: black line in UV editor on 32 bit

3 months agoFix T66538: Menus in popups opening on mouse over
Campbell Barton [Mon, 8 Jul 2019 14:21:26 +0000 (00:21 +1000)]
Fix T66538: Menus in popups opening on mouse over

Caused by b708917d94afa

Solve by restricting this change to popovers
instead of other kinds of menus (enums mainly).

3 months agoFix T66554: Measure doesn't snap with Ctrl
Campbell Barton [Mon, 8 Jul 2019 14:06:59 +0000 (00:06 +1000)]
Fix T66554: Measure doesn't snap with Ctrl

3 months agoFix (unreported) broken 'compse' feature when editing text.
Bastien Montagne [Mon, 8 Jul 2019 14:09:28 +0000 (16:09 +0200)]
Fix (unreported) broken 'compse' feature when editing text.

Looks like that code was not updated when we switched to unicode, it was
still returning axtended ascii codes (iso-8859-15 ones I think)...

That was breaking some chars, which have a very different value in
unicode. Found while working on Text section of the Manual! ;)

3 months agoFix T66431: SE - Audio Caching crash
Sergey Sharybin [Mon, 8 Jul 2019 13:57:33 +0000 (15:57 +0200)]
Fix T66431: SE - Audio Caching crash

Moved the caching code from direct calls in DNA to dependency graph.

In fact, not much was needed to be done apart form removing the direct
cache updates. The rest seemed to work fine.

Possible to avoid full sound file re-load, but doesn't seem this is
causing any issues.

3 months agoFix T66499: Parenting a Mask to Plane Track doesnt work
Sergey Sharybin [Mon, 8 Jul 2019 12:48:24 +0000 (14:48 +0200)]
Fix T66499: Parenting a Mask to Plane Track doesnt work

3 months agoUI: Update tooltip of Vertex Selection masking
Pablo Vazquez [Mon, 8 Jul 2019 12:40:48 +0000 (14:40 +0200)]
UI: Update tooltip of Vertex Selection masking

Since it is now possible to use it in Vertex Paint, not just Weight Paint.

3 months agoFix T66526: child's objects move if change their origin position
Philipp Oeser [Mon, 8 Jul 2019 10:31:27 +0000 (12:31 +0200)]
Fix T66526: child's objects move if change their origin position

Reviewers: sergey

Maniphest Tasks: T66526

Differential Revision:

3 months agoFix T66524: Eyedropper in popover crashes
Campbell Barton [Mon, 8 Jul 2019 10:39:27 +0000 (20:39 +1000)]
Fix T66524: Eyedropper in popover crashes

3 months agoFix T66525: Wrong apply scale for children chain
Sergey Sharybin [Mon, 8 Jul 2019 10:23:24 +0000 (12:23 +0200)]
Fix T66525: Wrong apply scale for children chain

The operator did not behave correct when there was a chain of parents
longer than 1.

3 months agoFix T66517: Clip editor doesn't respect the 2D cursor
Sergey Sharybin [Mon, 8 Jul 2019 09:45:54 +0000 (11:45 +0200)]
Fix T66517: Clip editor doesn't respect the 2D cursor

Was caused by 91b768ccb1f4 which re-defined masks menu with the wrong
invoke type.

3 months agoFix wrong colors when creating a float normal map image in texture paint
Brecht Van Lommel [Fri, 5 Jul 2019 12:30:31 +0000 (14:30 +0200)]
Fix wrong colors when creating a float normal map image in texture paint

3 months agoCleanup: Spelling in function name
Sergey Sharybin [Mon, 8 Jul 2019 08:53:37 +0000 (10:53 +0200)]
Cleanup: Spelling in function name

3 months agoKeymap: Vertex Paint: Add ctrl to temporarily swich colors
Aaron Carlisle [Sun, 7 Jul 2019 23:52:57 +0000 (19:52 -0400)]
Keymap: Vertex Paint: Add ctrl to temporarily swich colors

This now matches Texture Painting
This was added in rB7d5fb2e103e03046194d69640aadf7e76a700620 but was
lost probably when migrating to python keymap.

3 months agoFix T66376: Problem with Gpencil fill tool
Antonioya [Sun, 7 Jul 2019 20:28:41 +0000 (22:28 +0200)]
Fix T66376: Problem with Gpencil fill tool

The fill material has an alpha > 0, but the show fill is disabled, but as the fill tool is considered the fill as visible and the stroke is not drawn, the fill area had a gap.

3 months agoCleanup: split enum types, use PF_CMP prefix
Campbell Barton [Sun, 7 Jul 2019 14:40:56 +0000 (00:40 +1000)]
Cleanup: split enum types, use PF_CMP prefix

3 months agoCleanup: move enum unto BKE_packedFile.h
Campbell Barton [Sun, 7 Jul 2019 14:06:52 +0000 (00:06 +1000)]
Cleanup: move enum unto BKE_packedFile.h

Use enum type for functions arguments.

Removed -1 check in switch statement, this isn't needed.

3 months agoCleanup: use BKE_packedfile prefix for function names
Campbell Barton [Sun, 7 Jul 2019 13:57:35 +0000 (23:57 +1000)]
Cleanup: use BKE_packedfile prefix for function names

Avoid ambiguity with terms check & compare.

3 months agoCleanup: clang-format
Campbell Barton [Sun, 7 Jul 2019 13:45:35 +0000 (23:45 +1000)]
Cleanup: clang-format

3 months agoFix crash running an operator from a popup,
Campbell Barton [Sun, 7 Jul 2019 12:30:19 +0000 (22:30 +1000)]
Fix crash running an operator from a popup,

Cell fracture redraw option was crashing.
Change operator popup behavior to close the UI before executing
since the operator may perform operations which change/remove the UI.

3 months agoCleanup: unused vars, redundant parenthisis
Campbell Barton [Sun, 7 Jul 2019 12:24:11 +0000 (22:24 +1000)]
Cleanup: unused vars, redundant parenthisis

3 months agoCleanup: use static set
Campbell Barton [Sun, 7 Jul 2019 12:33:18 +0000 (22:33 +1000)]
Cleanup: use static set

3 months agoGPencil: Hide reference points when use Parallel or Grid guide
Antonioya [Sun, 7 Jul 2019 07:38:52 +0000 (09:38 +0200)]
GPencil: Hide reference points when use Parallel or Grid guide

These options are not used by these modes. Detected while writing the manual.

3 months agoCleanup: spelling
Campbell Barton [Sun, 7 Jul 2019 05:38:41 +0000 (15:38 +1000)]
Cleanup: spelling

3 months agoDocs: update window/screen introduction
Campbell Barton [Sun, 7 Jul 2019 05:22:16 +0000 (15:22 +1000)]
Docs: update window/screen introduction

Include global region/areas.

3 months agoFix T66493: Enable Add-on name not showing in favorites
Campbell Barton [Sun, 7 Jul 2019 04:17:33 +0000 (14:17 +1000)]
Fix T66493: Enable Add-on name not showing in favorites

3 months agoFix Filter Add-ons panel display for missing add-ons
Campbell Barton [Sun, 7 Jul 2019 04:15:28 +0000 (14:15 +1000)]
Fix Filter Add-ons panel display for missing add-ons

Check the add-on exists before getting it's info.

3 months agoCleanup: rename gpencil chess -> checker
Campbell Barton [Sun, 7 Jul 2019 03:43:42 +0000 (13:43 +1000)]
Cleanup: rename gpencil chess -> checker

Match existing texture name.

3 months agoUI: Correct tooltip
Aaron Carlisle [Sun, 7 Jul 2019 00:35:52 +0000 (20:35 -0400)]
UI: Correct tooltip

3 months agoAPI Docs: Fix Links
Aaron Carlisle [Sat, 6 Jul 2019 23:46:05 +0000 (19:46 -0400)]
API Docs: Fix Links

3 months agoUI: Cleanup tooltip format
Aaron Carlisle [Sat, 6 Jul 2019 23:39:23 +0000 (19:39 -0400)]
UI: Cleanup tooltip format

3 months agoUI: Cleanup tooltip format
Aaron Carlisle [Sat, 6 Jul 2019 22:58:03 +0000 (18:58 -0400)]
UI: Cleanup tooltip format

3 months agoAPI Docs: Update Changlog for 2.80
Aaron Carlisle [Sat, 6 Jul 2019 20:54:42 +0000 (16:54 -0400)]
API Docs: Update Changlog for 2.80

3 months agoAPI Docs: Fix Update changelog script to python3
Aaron Carlisle [Sat, 6 Jul 2019 20:48:49 +0000 (16:48 -0400)]
API Docs: Fix Update changelog script to python3

3 months agoAPI Docs: Use Opensearch
Aaron Carlisle [Sat, 6 Jul 2019 20:01:49 +0000 (16:01 -0400)]
API Docs: Use Opensearch

3 months agoAPI Docs: Theme: Prevent Super Long Enums
Aaron Carlisle [Sat, 6 Jul 2019 19:53:39 +0000 (15:53 -0400)]
API Docs: Theme: Prevent Super Long Enums

3 months agoCleanup: API Doc Gen: move copying static dir to own function
Aaron Carlisle [Sat, 6 Jul 2019 00:17:42 +0000 (20:17 -0400)]
Cleanup: API Doc Gen: move copying static dir to own function

3 months agoGPencil: Close Box and Circle primitives with geometry
Antonioya [Sat, 6 Jul 2019 14:10:21 +0000 (16:10 +0200)]
GPencil: Close Box and Circle primitives with geometry

Before the primitives were closed only with cyclic flag, but this doesn't create geometry for the gap. Now, a new geometry is created using close stroke function to have geometry for sculpt or edit.

3 months agoFix T66501: Eraser very slow with guides
Antonioya [Sat, 6 Jul 2019 11:50:24 +0000 (13:50 +0200)]
Fix T66501: Eraser very slow with guides

After testing the file, the problem was related to the fill material. As the fill material had the alpha channel set to 1.0, the fill triangulation was calculated, but the fill was disabled.

Now, the fill flag is checked in order to avoid fill triangulation update.

3 months agoGPencil: Don't add missing events for Eraser mode
Antonioya [Sat, 6 Jul 2019 11:10:51 +0000 (13:10 +0200)]
GPencil: Don't add missing events for Eraser mode

This avoid some code that can delay the easer, but still some problems with the test file.

Related to T66501

3 months agoFix T62101: GPencil: selection order is wrong
Antonioya [Fri, 5 Jul 2019 21:11:53 +0000 (23:11 +0200)]
Fix T62101:  GPencil: selection order is wrong

Following the advices of @Germano Cavalcante (mano-wii) , I have exposed as a workaround the free function to be called from draw manager for selection.

Now, the free function is not called for selection inside gpencil draw_scene, but it's called from draw_manager.c.

The real fix would be create a new Scene_finish callback in draw manager, but as the release of 2.80 is almost here, we fix this with a workaround that must be removed when new callback is in place.

Differential Revision:

3 months agotransform_snap_object: return type of element snapped.
mano-wii [Fri, 5 Jul 2019 21:23:06 +0000 (18:23 -0300)]
transform_snap_object: return type of element snapped.

This can be useful for filtering some of the returns.

3 months agoFix T66282: Make Instances Real: Keep Hierarchy option broken with recursive instancing.
Bastien Montagne [Fri, 5 Jul 2019 16:09:17 +0000 (18:09 +0200)]
Fix T66282: Make Instances Real: Keep Hierarchy option broken with recursive instancing.

Preserving/rebuilding relashionships in recursive instancing was simply
not supported at all, code handling that was assuming a single level of

This commit makes the following changes:
* Mixing DupliCollection and DupliVerts/Faces in the recursive chain is
now supported (by using a same GHash in all cases, differences of
persistent_id handling in hashing and comparison is now down inside the
relevant functions).
* When both "keep hierarchy" and "parent" options are enabled, code will
attempt to parent new objects to their version of instancer (instead of
parenting them systematically to the root object). This will preserve
the hierarchy much better.
* Collection is removed from dupli empties that have been made 'real'
(the duplication flag itself was already cleared, but the link to the
instantiated collection was kept).

3 months agoFix T66327 2/2: Make instance real does not clear collection
Dalai Felinto [Tue, 2 Jul 2019 21:16:55 +0000 (18:16 -0300)]
Fix T66327 2/2: Make instance real does not clear collection

3 months agoFix T66327 1/2: Outliner dupli empty is shown as collection when a different duplitype
Dalai Felinto [Tue, 2 Jul 2019 21:12:11 +0000 (18:12 -0300)]
Fix T66327 1/2: Outliner dupli empty is shown as collection when a different duplitype

3 months agoTransform Snap: Fix dependency cycle between transformed object and object with modifiers
mano-wii [Fri, 5 Jul 2019 15:13:08 +0000 (12:13 -0300)]
Transform Snap: Fix dependency cycle between transformed object and object with modifiers

3 months agoFix strict compiler warnings
Sergey Sharybin [Fri, 5 Jul 2019 14:08:51 +0000 (16:08 +0200)]
Fix strict compiler warnings

3 months agoFix T64342: Incorrect snapping of focus object in camera view
Sergey Sharybin [Thu, 4 Jul 2019 13:15:30 +0000 (15:15 +0200)]
Fix T64342: Incorrect snapping of focus object in camera view

Use more granular dependency graph traversal, which allows to ignore
dependencies which are not related on transform.

Reviewers: mano-wii, brecht

Differential Revision:

3 months agoDepsgraph: Cleanup, more clear naming
Sergey Sharybin [Thu, 4 Jul 2019 13:15:02 +0000 (15:15 +0200)]
Depsgraph: Cleanup, more clear naming

3 months agoDepsgraph: Make component traversal more granular
Sergey Sharybin [Thu, 4 Jul 2019 13:13:26 +0000 (15:13 +0200)]
Depsgraph: Make component traversal more granular

Now it is possible to start traversal from a given component.

3 months agoDepsgraph: Add dependencies traversal which is aware of component
Sergey Sharybin [Thu, 4 Jul 2019 13:04:03 +0000 (15:04 +0200)]
Depsgraph: Add dependencies traversal which is aware of component

Sometimes it is required to know which exact part of ID is being
dependent on the given iD. Now it is possible.

3 months agoDepsgraph: Add inverse of node type conversion functions
Sergey Sharybin [Thu, 4 Jul 2019 12:50:59 +0000 (14:50 +0200)]
Depsgraph: Add inverse of node type conversion functions

3 months agoDepsgraph: Make object component conversion more accessible
Sergey Sharybin [Thu, 4 Jul 2019 12:43:54 +0000 (14:43 +0200)]
Depsgraph: Make object component conversion more accessible

3 months agoFix "child of" constraint "set inverse" problematic with bones
Philipp Oeser [Fri, 5 Jul 2019 13:50:48 +0000 (15:50 +0200)]
Fix "child of" constraint "set inverse" problematic with bones

For bone owners we want to do this in evaluated domain since
BKE_pose_where_is() / BKE_pose_where_is_bone() rely on (re)evaluating
parts of the scene and copying new evaluated stuff back to original.

Fixes T66080, T66397

Reviewers: sergey

Maniphest Tasks: T66080

Differential Revision:

3 months agoGPencil: Remove select keymap definition for Weight Paint mode
Antonioya [Fri, 5 Jul 2019 14:00:10 +0000 (16:00 +0200)]
GPencil: Remove select keymap definition for Weight Paint mode

This removes the keymap, but the B key is still available, so in some top level the selection is enabled.

Related to T66458.