4 months agoEevee: Fix volumetric shaders compilation error
Clément Foucault [Tue, 14 May 2019 17:58:26 +0000 (19:58 +0200)]
Eevee: Fix volumetric shaders compilation error

4 months agoFix T64455 Texture extension mode 'clip' defaults to 'extend'
Clément Foucault [Tue, 14 May 2019 17:34:31 +0000 (19:34 +0200)]
Fix T64455 Texture extension mode 'clip' defaults to 'extend'

4 months agoCleanup: isolate image dirty flag access in functions
Brecht Van Lommel [Tue, 14 May 2019 15:28:13 +0000 (17:28 +0200)]
Cleanup: isolate image dirty flag access in functions

4 months agoFix T64514: wrong grease pencil icon preview renders
Brecht Van Lommel [Tue, 14 May 2019 15:57:10 +0000 (17:57 +0200)]
Fix T64514: wrong grease pencil icon preview renders

This broken when the new Cycles/Eevee preview scene was added, make it work
the same as before for Grease Pencil now.

4 months agoGPencil: Rename property Follow Drawing Path to Alignment
Antonioya [Tue, 14 May 2019 15:28:31 +0000 (17:28 +0200)]
GPencil: Rename property Follow Drawing Path to Alignment

The old name was not clear and with new options the new name is more easy to understand.

4 months agoFix T60984: Can't perform viewport navigation with left mouse button and active manip...
William Reynish [Tue, 14 May 2019 15:24:16 +0000 (17:24 +0200)]
Fix T60984: Can't perform viewport navigation with left mouse button and active manipulator

This was fixed for active tool gizmos but not viewport gizmos.

Note that this applies only to the Industry Compatible keymap, which is where this issue manifested itself.

4 months agoFix T64551 Crash on leaving local view on the shading tab
Clément Foucault [Tue, 14 May 2019 15:15:48 +0000 (17:15 +0200)]
Fix T64551 Crash on leaving local view on the shading tab

Was causing by garbage collection free the surf_per_mat_tris array.
The cache validate did not take care of ensuring the array was alloc again.

4 months agoFix Shader compilation error on MacOS & some other platform/driver
Clément Foucault [Tue, 14 May 2019 14:43:37 +0000 (16:43 +0200)]
Fix Shader compilation error on MacOS & some other platform/driver

texture2D() is no longer supported by modern opengl, use texture() instead.

4 months agoFix T64601 Error division by zero in GPUVertexFormat
Clément Foucault [Tue, 14 May 2019 14:31:04 +0000 (16:31 +0200)]
Fix T64601 Error division by zero in GPUVertexFormat

The windows compiler use signed int by default for enums so that broke
the bit count I carefully did. Forcing uint fixes it.

4 months agoFix T63994: Node Editor: Move All Selected Nodes when dragging.
Bastien Montagne [Tue, 14 May 2019 13:51:49 +0000 (15:51 +0200)]
Fix T63994: Node Editor: Move All Selected Nodes when dragging.

Left-click select broke that behavior, since it puts both action and
select buttons on the same physical mouse button...

To support this behavior again, we have to split selection process in
two steps, hence make it modal... While I remain rather skeptical about
that global design decision, and complexity it adds to many UI/UX areas,
this solution ends up being OK-ish I think.

Thanks to @brecht for some final tweaks on the patch.

4 months agoInterface: Free argument callback for popups
Jacques Lucke [Tue, 14 May 2019 13:38:51 +0000 (15:38 +0200)]
Interface: Free argument callback for popups

Reviewers: brecht

Differential Revision:

4 months agoUI: Improve naming for Collections Enable/Disable
William Reynish [Tue, 14 May 2019 13:12:41 +0000 (15:12 +0200)]
UI: Improve naming for Collections Enable/Disable

  - Fix 'ddisable' typo
  - Use clearer names for the operators in the Collections context menu

Instead of Set Exclude / Clear Exclude, we now use Enable in View Layer / Disable from View Layer

4 months agoFix T64567: Rename Viewport to Viewport Render
Jeroen Bakker [Tue, 14 May 2019 13:07:31 +0000 (15:07 +0200)]
Fix T64567: Rename Viewport to Viewport Render

4 months agoFix Cycles build error after recent changes
Brecht Van Lommel [Tue, 14 May 2019 13:05:24 +0000 (15:05 +0200)]
Fix Cycles build error after recent changes

We need to do aligned alloc of the services instead of globals now since the
concurrent map moved there.

4 months agoGPU: Windows+Intel Selection Fix
Jeroen Bakker [Tue, 14 May 2019 11:55:35 +0000 (13:55 +0200)]
GPU: Windows+Intel Selection Fix

On Windows 10 with a post Februari 2019 Intel driver, the box selection
is not working. It only detects the object centers, but not the drawn
triangles of the basic engine.

Reviewed By: fclem

Maniphest Tasks: T62947

Differential Revision:

4 months agoUI: Confirm dialog when closing an unsaved file
Jacques Lucke [Tue, 14 May 2019 12:13:02 +0000 (14:13 +0200)]
UI: Confirm dialog when closing an unsaved file

The complexity in this patch comes from the fact
that the current operator system does not support
multi-step user interactions well.

More specifically, for this to work, we need to show
a confirm dialog and a file browser afterwards.
We decided that it is easier to keep everything in
a single operator, instead of creating separate
operators that invoke each other.

So, now the `WM_OT_open_mainfile` operator invokes
itself in different states. It implements a simple
finite state machine to manage the states.

The dialog itself is expected to be improved in
a future commit. See D4829 for more details.

Reviewers: brecht

Differential Revision:

4 months agoFix zfighting from edit mode face overlays
Clément Foucault [Tue, 14 May 2019 12:13:00 +0000 (14:13 +0200)]
Fix zfighting from edit mode face overlays

4 months agoFix T64574 : Weird shadow mesh glitches in viewport
Clément Foucault [Tue, 14 May 2019 11:57:41 +0000 (13:57 +0200)]
Fix T64574 : Weird shadow mesh glitches in viewport

This is not the most clean but this is what is needed to make
point_object_to_ndc equivalent to
point_object_to_world + point_world_to_ndc

4 months agoFix T64574 : Weird shadow mesh glitches in viewport
Clément Foucault [Tue, 14 May 2019 11:57:41 +0000 (13:57 +0200)]
Fix T64574 : Weird shadow mesh glitches in viewport

This is not the most clean but this is what is needed to make
point_object_to_ndc equivalent to
point_object_to_world + point_world_to_ndc

4 months agoGPU: Fixup and add assert to GPU_VERT_ATTR_NAMES_BUF_LEN
Clément Foucault [Tue, 14 May 2019 11:45:55 +0000 (13:45 +0200)]
GPU: Fixup and add assert to GPU_VERT_ATTR_NAMES_BUF_LEN

4 months agoEevee: Fix Auto Tangent not working if active UV layer is greater than 3
Clément Foucault [Tue, 14 May 2019 10:33:25 +0000 (12:33 +0200)]
Eevee: Fix Auto Tangent not working if active UV layer is greater than 3

4 months agoFix T64592: Assign Shortcut does not autosave preferences
Brecht Van Lommel [Tue, 14 May 2019 10:27:28 +0000 (12:27 +0200)]
Fix T64592: Assign Shortcut does not autosave preferences

4 months agoFix T63542: Imported FBX doesn't show keyframes in Shape Key editor.
Bastien Montagne [Tue, 14 May 2019 10:23:31 +0000 (12:23 +0200)]
Fix T63542: Imported FBX doesn't show keyframes in Shape Key editor.

While shapekeys RNA path handling does support keyblocks (ShapeKeys)
with an `id_data` wrongly set to the geometry instead of the shapkey,
this is really not something to promote. ideally it should be removed at
some point. At least, let's not generate such RNA pointer if we can
avoid it.

Here it was breaking proper showing of animated shapekeys in the UI,
since this expects animated datablocks to have their own animation data
(and 'rooting' keyblocks to their mesh instead of their shapekey ended
up defining their animation in the mesh, not in the shapekey).

4 months agoFix T64515, T60434: crash in OSL and preview render after recent changes
Brecht Van Lommel [Tue, 14 May 2019 10:13:43 +0000 (12:13 +0200)]
Fix T64515, T60434: crash in OSL and preview render after recent changes

The refactoring of texture handles did not take into account that render
services are shared between multiple render session. Now the texture
to handle map is also shared between render sessions.

4 months agoScreen: replace show footer operator with property
Campbell Barton [Tue, 14 May 2019 10:17:43 +0000 (20:17 +1000)]
Screen: replace show footer operator with property

This matches 'show header' internal logic.

4 months agoCleanup: sort struct declarations
Campbell Barton [Tue, 14 May 2019 10:20:01 +0000 (20:20 +1000)]
Cleanup: sort struct declarations

4 months agoCleanup: quiet warning
Campbell Barton [Tue, 14 May 2019 10:20:42 +0000 (20:20 +1000)]
Cleanup: quiet warning

4 months agoFix T64441: GPencil textures weird rotation
Antonioya [Tue, 14 May 2019 09:57:32 +0000 (11:57 +0200)]
Fix T64441: GPencil textures weird rotation

New option to disable the follow drawing path. Before it had only a switch property, now there is a list of options.


Path: Follows drawing stroke and rotate with object.
Object: Only follows object rotation.
None: Don't rotate.

4 months agoCleanup: rename ED_scrubbing.h to ED_time_scrub_ui.h
Jacques Lucke [Tue, 14 May 2019 09:39:15 +0000 (11:39 +0200)]
Cleanup: rename ED_scrubbing.h to ED_time_scrub_ui.h

Also renames the corresponding .c file.

4 months agoRNA: fix the id_data pointer of PoseBone.bone to point at the Armature.
Alexander Gavrilov [Tue, 14 May 2019 09:38:04 +0000 (12:38 +0300)]
RNA: fix the id_data pointer of PoseBone.bone to point at the Armature.

The owning ID reference of RNA pointers is supposed to point at the
ID container that owns the object, but for PoseBone.bone it wasn't
updated to point at the Armature data ID instead of Armature Object.

This caused issues, like pose_bone.bone.driver_add() adding the
driver to the Armature Object animation data, which violates the
intended design of the animation data structures.

Since RNA code generally assumes that all pointers that don't
refer directly to an ID remain within the current ID, a custom
getter is required to fix this.

4 months agoDepsgraph: detect bbone_segments drivers from Object animation data.
Alexander Gavrilov [Tue, 14 May 2019 09:09:02 +0000 (12:09 +0300)]
Depsgraph: detect bbone_segments drivers from Object animation data.

4 months agoFix T64578: Cycles clamps HDR colors for 16bit integer image with colorspace
Brecht Van Lommel [Tue, 14 May 2019 09:22:07 +0000 (11:22 +0200)]
Fix T64578: Cycles clamps HDR colors for 16bit integer image with colorspace

4 months agoCleanup: DRW: Move ModelMatrix declaration to common_view_lib
Clément Foucault [Mon, 13 May 2019 22:48:17 +0000 (00:48 +0200)]
Cleanup: DRW: Move ModelMatrix declaration to common_view_lib

4 months agoGPUVertexFormat: Reduce size of structs
Clément Foucault [Mon, 13 May 2019 21:31:43 +0000 (23:31 +0200)]
GPUVertexFormat: Reduce size of structs

With this patch, the size of GPUVertFormat goes from 1240 to 388.

4 months agoCleanup: DRW: Add and use DRW_shgroup_uniform_vec2_copy
Clément Foucault [Mon, 13 May 2019 17:20:58 +0000 (19:20 +0200)]
Cleanup: DRW: Add and use DRW_shgroup_uniform_vec2_copy

4 months agoCleanup: DRW: Remove unused Uniform types
Clément Foucault [Mon, 13 May 2019 17:20:27 +0000 (19:20 +0200)]
Cleanup: DRW: Remove unused Uniform types

4 months agoCleanup: DRW: Remove uneeded _add suffix from DRW_shgroup_call_add
Clément Foucault [Mon, 13 May 2019 16:28:36 +0000 (18:28 +0200)]
Cleanup: DRW: Remove uneeded _add suffix from DRW_shgroup_call_add

4 months agoDRW: Refactor: Use DRWCall to accumulate per instance attributes
Clément Foucault [Mon, 13 May 2019 15:56:20 +0000 (17:56 +0200)]
DRW: Refactor: Use DRWCall to accumulate per instance attributes

This is a big change that cleanup a lot of confusing code.
- The instancing/batching data buffer distribution in draw_instance_data.c.
- The selection & drawing code in draw_manager_exec.c
- Prety much every non-meshes object drawing (object_mode.c).

Most of the changes are just renaming but there still a chance a typo might
have sneek through.

The Batching/Instancing Shading groups are replace by DRWCallBuffers. This
is cleaner and conceptually more in line with what a DRWShadingGroup should

There is still some little confusion in draw_common.c where some function
takes shgroup as input and some don't.

4 months agoGPU: Add GPU_vertbuf_discard and GPU_BATCH_UNUSED
Clément Foucault [Mon, 13 May 2019 15:27:35 +0000 (17:27 +0200)]
GPU: Add GPU_vertbuf_discard and GPU_BATCH_UNUSED

GPU_vertbuf_discard to clear buffer containers in place.
GPU_BATCH_UNUSED to tag batch that are cleared and not immediatly usable.

4 months agoBLI_memblock: Add more options
Clément Foucault [Mon, 13 May 2019 13:57:03 +0000 (15:57 +0200)]
BLI_memblock: Add more options

- Use int instead of uint for safety and less conversions.
- Add free callback
- Add cleared alloc option

4 months agoCleanup: Remove DRWCallType
Clément Foucault [Sat, 11 May 2019 17:16:46 +0000 (19:16 +0200)]
Cleanup: Remove DRWCallType

This simplify the rendering logic.

4 months agoDRW: Fix threading hazard when rendering and using auto depth
Clément Foucault [Sat, 11 May 2019 17:13:54 +0000 (19:13 +0200)]
DRW: Fix threading hazard when rendering and using auto depth

4 months agoCleanup: DRW: Remove unused functions
Clément Foucault [Sat, 11 May 2019 15:45:45 +0000 (17:45 +0200)]
Cleanup: DRW: Remove unused functions

4 months agoDRW: Change Procedural function to use a GPUBatch
Clément Foucault [Sat, 11 May 2019 15:45:20 +0000 (17:45 +0200)]
DRW: Change Procedural function to use a GPUBatch

This is in order to have VAO handled by thoses batches instead of using a
common VAO. Even if the VAO has no importance in these case using a batch
will help when transitioning to Vulkan.

4 months agoEevee: Replace DRW_shgroup_empty_tri_batch_create by procedural calls
Clément Foucault [Sat, 11 May 2019 15:42:36 +0000 (17:42 +0200)]
Eevee: Replace DRW_shgroup_empty_tri_batch_create by procedural calls

4 months agoMesh Batch Cache: Fix use of uninitialized variable
Clément Foucault [Sat, 11 May 2019 14:49:17 +0000 (16:49 +0200)]
Mesh Batch Cache: Fix use of uninitialized variable

4 months agoDRW: Make Instance count not a pointer
Clément Foucault [Sat, 11 May 2019 14:14:25 +0000 (16:14 +0200)]
DRW: Make Instance count not a pointer

Goal is still to simplify the draw manager.

4 months agoCleanup: Eevee: Make planar downsampling not use instance drawing
Clément Foucault [Sat, 11 May 2019 13:58:49 +0000 (15:58 +0200)]
Cleanup: Eevee: Make planar downsampling not use instance drawing

4 months agoCleanup: DRW: Remove pointers to materials
Clément Foucault [Sat, 11 May 2019 12:42:26 +0000 (14:42 +0200)]
Cleanup: DRW: Remove pointers to materials

4 months agoGPU: Move Material index to nodetree evaluation
Clément Foucault [Sat, 11 May 2019 12:37:27 +0000 (14:37 +0200)]
GPU: Move Material index to nodetree evaluation

This removes the need to pass the Material* all over the place in the draw
manager. Cleanup comming right after.

4 months agoDRW: Remove ModelViewMatrix and ModelViewMatrixInverse
Clément Foucault [Sat, 11 May 2019 12:04:18 +0000 (14:04 +0200)]
DRW: Remove ModelViewMatrix and ModelViewMatrixInverse

4 months agoGPU: Remove ModelViewMatrix and ModelViewMatrixInverse usage
Clément Foucault [Sat, 11 May 2019 11:59:10 +0000 (13:59 +0200)]
GPU: Remove ModelViewMatrix and ModelViewMatrixInverse usage

4 months agoFix T64588: some new theme preferences not saving
Brecht Van Lommel [Tue, 14 May 2019 08:42:53 +0000 (10:42 +0200)]
Fix T64588: some new theme preferences not saving

4 months agoFix T64339: Crash with UV sculpt after undo
Campbell Barton [Tue, 14 May 2019 06:44:21 +0000 (16:44 +1000)]
Fix T64339: Crash with UV sculpt after undo

4 months agoKeymap: add option for tilde key preference
Campbell Barton [Tue, 14 May 2019 05:05:19 +0000 (15:05 +1000)]
Keymap: add option for tilde key preference

Since the view menu is redundant for people with a numpad,
add a preference for it to switch between gizmos instead.

4 months agoPreferences: file menu item to temporarily load factory settings
Campbell Barton [Tue, 14 May 2019 02:23:55 +0000 (12:23 +1000)]
Preferences: file menu item to temporarily load factory settings

It's common to load factory settings as a test without wanting to
overwrite your own settings on exit.

4 months agoPreferences: set dirty flag when dragging
Campbell Barton [Tue, 14 May 2019 01:15:38 +0000 (11:15 +1000)]
Preferences: set dirty flag when dragging

4 months agoFix property update setting dirty flag
Campbell Barton [Tue, 14 May 2019 01:12:02 +0000 (11:12 +1000)]
Fix property update setting dirty flag

4 months agoFix missing preference dirty tagging
Campbell Barton [Tue, 14 May 2019 00:08:24 +0000 (10:08 +1000)]
Fix missing preference dirty tagging

Tagging dirty was failing for UI scale, line width, hinting & others.

Checking for an update function means all update functions
need to tag preferences as dirty.

Since this check was added to prevent the active section marking the
preferences as dirty, only exclude this property.

4 months agoUI: grey out 'Revert' when preferences aren't dirty
Campbell Barton [Tue, 14 May 2019 00:00:00 +0000 (10:00 +1000)]
UI: grey out 'Revert' when preferences aren't dirty

4 months agoFix T63802: textured lights not working with OSL
Brecht Van Lommel [Mon, 13 May 2019 22:40:25 +0000 (00:40 +0200)]
Fix T63802: textured lights not working with OSL

4 months agoFix T64561: wrong colorspace for Cycles displacement nodes
Brecht Van Lommel [Mon, 13 May 2019 21:40:45 +0000 (23:40 +0200)]
Fix T64561: wrong colorspace for Cycles displacement nodes

4 months agoFix compiler warning with OpenGL icon textures
Brecht Van Lommel [Mon, 13 May 2019 21:30:23 +0000 (23:30 +0200)]
Fix compiler warning with OpenGL icon textures

4 months agoFix T64292: world missing from outliner Scenes view
Brecht Van Lommel [Mon, 13 May 2019 20:37:45 +0000 (22:37 +0200)]
Fix T64292: world missing from outliner Scenes view

4 months agoFix T64297: edit light energy not working for Eevee, when nodes exist
Brecht Van Lommel [Mon, 13 May 2019 20:32:50 +0000 (22:32 +0200)]
Fix T64297: edit light energy not working for Eevee, when nodes exist

Simplify code now that Cycles also has energy outside nodes.

4 months agoFix T64407: crash adding workspace after appending datablock
Brecht Van Lommel [Mon, 13 May 2019 20:18:11 +0000 (22:18 +0200)]
Fix T64407: crash adding workspace after appending datablock

The files operator property should not be remembered for next
operator executions, gives unexpected effects when using the
operator again.

4 months agomake.bat: add option for enabling the OpenGL based tests.
Ray Molenkamp [Mon, 13 May 2019 20:08:27 +0000 (14:08 -0600)]
make.bat: add option for enabling the OpenGL based tests.

4 months agoPython API: expose conversion between tweaked NLA strip and scene time.
Alexander Gavrilov [Mon, 13 May 2019 18:01:03 +0000 (21:01 +0300)]
Python API: expose conversion between tweaked NLA strip and scene time.

This is necessary to correctly do low-level keyframe manipulation
in tweak mode, and the logic is complex enough that re-implementing
it in Python is impractical.

4 months agoBetter support for (mirrored) bbone scaling in pose mode
Philipp Oeser [Mon, 13 May 2019 11:16:22 +0000 (13:16 +0200)]
Better support for (mirrored) bbone scaling in pose mode

since own rB5d9d32fd1fa3 (mirror bbone scaling in editmode)
- bbone scaling in posemode was missing immediate updates
- bbone scaling in posemode could crash

This now properly supports mirroring in posemode as well.
note: for bbone scaling, I made both X-Axis-Mirror options (editmode
option as well as posemode option) valid.

Fixes T64091

Reviewers: brecht

Maniphest Tasks: T64091

Differential Revision:

4 months agoApply Pose as Rest Pose: implement an Only Selected bones option.
Alexander Gavrilov [Sun, 8 Jul 2018 14:10:15 +0000 (17:10 +0300)]
Apply Pose as Rest Pose: implement an Only Selected bones option.

The most difficult part is handling parent-child relations correctly:
when a parent is applied, the children should be moved accordingly,
and when applying a child, it should not include transformation from
unapplied parents. All this requires walking bones as a tree, instead
of a flat list.

Limitation: Applying bones with non-uniform scaling without also applying
children will distort non-rest posing on said children for reasons related
to T54159 (basically, non-uniform scale plus rotation creates shear, and
Blender matrix decomposition utilities don't have tools to deal with it).

Reviewers: campbellbarton, brecht, mont29

Differential Revision:

4 months agoI18n Disambiguation: "Shift".
Bastien Montagne [Mon, 13 May 2019 15:57:13 +0000 (17:57 +0200)]
I18n Disambiguation: "Shift".

Give WM context to the shortcut, since this is more specific meaning
than usual 'shifting' one...

Part of T43295.

4 months agoI18n Disambiguation: One more case of 'Root' falloff without 'Curve' context.
Bastien Montagne [Mon, 13 May 2019 15:33:12 +0000 (17:33 +0200)]
I18n Disambiguation: One more case of 'Root' falloff without 'Curve' context.

Part of T43295.

4 months agoI18n Disambiguation: "Add" in menu labels.
Bastien Montagne [Mon, 13 May 2019 15:27:40 +0000 (17:27 +0200)]
I18n Disambiguation: "Add" in menu labels.

This one is usually a verb/action one in menus' labels,
hence we give it the Operator default context.

Part of T43295.

4 months agoFix T63325: Drivers freezing input value
Sergey Sharybin [Mon, 13 May 2019 15:54:27 +0000 (17:54 +0200)]
Fix T63325: Drivers freezing input value

Not sure why driver would be affecting on the behavior, the actual
issue was caused by lack of proper relations built for lamps and

4 months agoFix T64387: Crash with driver copy/paste
Sergey Sharybin [Mon, 13 May 2019 14:45:03 +0000 (16:45 +0200)]
Fix T64387: Crash with driver copy/paste

Was missing copy-on-write tag since lamp itself has no geometry or

Now tagging for animation, and taking care of special case in the
dependency graph.

4 months agoCycles/Eevee: add Emission and Alpha inputs to Principled BSDF
Brecht Van Lommel [Sun, 12 May 2019 12:39:30 +0000 (14:39 +0200)]
Cycles/Eevee: add Emission and Alpha inputs to Principled BSDF

This makes it easier to set up materials with emission and transparency.
Importers/exporters and add-ons are recommended to now use these rather than
creating separate transparent BSDF and emission nodes.

4 months agoCycles/Eevee: unify light strength and color
Brecht Van Lommel [Sun, 12 May 2019 11:41:23 +0000 (13:41 +0200)]
Cycles/Eevee: unify light strength and color

Cycles lights now use strength and color properties of the light outside
of the shading nodes, just like Eevee. The shading nodes then act as a
multiplier on this, and become optional unless textures, fallof or other
effects are desired.

Backwards compatibility is not exact, as we can't be sure which renderer
the .blend was designed for or even if it was designed for a single one.

If the render engine in the active scene is set to Cycles, lights are
converted to ensure overall light strength remains the same, and removing
unnecessary shader node setups that only included a single emission node.

If the engine is set to Eevee, we increase strength to remove the automatic
100x multiplier that was there to match Cycles.

Differential Revision:

4 months agoCycles/Eevee: unified and improved texture image color space handling
Brecht Van Lommel [Tue, 23 Apr 2019 11:56:30 +0000 (13:56 +0200)]
Cycles/Eevee: unified and improved texture image color space handling

Cycles now uses the color space on the image datablock, and uses OpenColorIO
to convert to scene linear as needed. Byte images do not take extra memory,
they are compressed in scene linear + sRGB transfer function which in common
cases is a no-op.

Eevee and workbench were changed to work similar. Float images are stored as
scene linear. Byte images are compressed as scene linear + sRGB and stored in
a GL_SRGB8_ALPHA8 texture. From the GLSL shader side this means they are read
as scene linear, simplifying the code and taking advantage of hardware support.

Further, OpenGL image textures are now all stored with premultiplied alpha.
Eevee texture sampling looks a little different now because interpolation
happens premultiplied and in scene linear space.

Overlays and grease pencil work in sRGB space so those now have an extra
conversion to sRGB after reading from image textures. This is not particularly
elegant but as long as engines use different conventions, one or the other
needs to do conversion.

This change breaks compatibility for cases where multiple image texture nodes
were using the same image with different color space node settings. However it
gives more predictable behavior for baking and texture painting if save, load
and image editing operations have a single color space to handle.

Differential Revision:

4 months agoTests: disable DoF in Eevee tests for now, it adds blurring with default values
Brecht Van Lommel [Mon, 13 May 2019 10:04:54 +0000 (12:04 +0200)]
Tests: disable DoF in Eevee tests for now, it adds blurring with default values

4 months agoDepsgraph: Use for_render flag for curves from depsgraph
Sergey Sharybin [Mon, 13 May 2019 13:24:43 +0000 (15:24 +0200)]
Depsgraph: Use for_render flag for curves from depsgraph

Fixes issue with Eevee always using viewport curve resolution.

4 months agoCurve: Remove duplicated and confusing argument
Sergey Sharybin [Mon, 13 May 2019 07:42:32 +0000 (09:42 +0200)]
Curve: Remove duplicated and confusing argument

Curve function had two arguments:

- for_render, which was originally supposed to be used to control
  whether viewport or render visibility for modifiers is to be

- use_render_resolution, which sounds like it is supposed to control
  whether viewport or render resolution for curves is to be used.

What is totally confusing is that those arguments were used
interchangeably: sometimes use_render_resolution would control
modifiers visibility.

This commit makes it so there is one single argument for this.

Reviewers: brecht

Reviewed By: brecht

Differential Revision:

4 months agoPreferences: set dirty when editing quick favourites menu
Campbell Barton [Mon, 13 May 2019 12:28:43 +0000 (22:28 +1000)]
Preferences: set dirty when editing quick favourites menu

4 months agoUI: Don't display markers in driver editor
Jacques Lucke [Mon, 13 May 2019 09:55:38 +0000 (11:55 +0200)]
UI: Don't display markers in driver editor

4 months agoFix T64403: crash sampling coloring in texture paint mode
Brecht Van Lommel [Mon, 13 May 2019 09:45:16 +0000 (11:45 +0200)]
Fix T64403: crash sampling coloring in texture paint mode

4 months agoFix T64041: Vertex Sharp not working.
Bastien Montagne [Mon, 13 May 2019 09:48:55 +0000 (11:48 +0200)]
Fix T64041: Vertex Sharp not working.

Broken in rB0ac3d5f7db67 last year...

4 months agoUI: rename Load Preferences to Revert
Campbell Barton [Mon, 13 May 2019 09:30:36 +0000 (19:30 +1000)]
UI: rename Load Preferences to Revert

4 months agoFix T64120: Dynamic Paint Doesn't Recalculate Normals with Smooth Shading.
Bastien Montagne [Mon, 13 May 2019 09:37:22 +0000 (11:37 +0200)]
Fix T64120: Dynamic Paint Doesn't Recalculate Normals with Smooth Shading.

For wome reason, tag to mark normals as needing recompute was commented
out instead of updated to new system, during conversion of DynaPaint
code for 2.8 new evaluation stack... Trivial fix.

4 months agoRNA: disable undo on OperatorProperties and its subclasses.
Alexander Gavrilov [Mon, 13 May 2019 09:36:39 +0000 (12:36 +0300)]
RNA: disable undo on OperatorProperties and its subclasses.

Since these are temporary properties, changing them shouldn't cause
undo pushes. There already is a flag to disable that, but since each
operator inherits its own properties from the base, RNA define code
also had to be changed to allow inheriting the flag.

4 months agoFix unintended autosaving of preferences in a few cases
Brecht Van Lommel [Mon, 13 May 2019 08:52:14 +0000 (10:52 +0200)]
Fix unintended autosaving of preferences in a few cases

* Dirty flag was not cleared on load
* Navigating tabs should not cause save
* Background mode should not autosave (for e.g. render farms and tests)

4 months agoPython API: expose preferences.is_dirty
Brecht Van Lommel [Mon, 13 May 2019 08:51:50 +0000 (10:51 +0200)]
Python API: expose preferences.is_dirty

4 months agocleanup: typo in comment
Philipp Oeser [Mon, 13 May 2019 08:14:41 +0000 (10:14 +0200)]
cleanup: typo in comment

4 months agoFix T64427: WITH_HEADLESS build option
Campbell Barton [Mon, 13 May 2019 07:41:14 +0000 (17:41 +1000)]
Fix T64427: WITH_HEADLESS build option

4 months agoFix T64461: Sub-panels allow pinning
Campbell Barton [Mon, 13 May 2019 06:53:40 +0000 (16:53 +1000)]
Fix T64461: Sub-panels allow pinning

4 months agoUI: disable decorators for workspace buttons
Campbell Barton [Mon, 13 May 2019 06:45:30 +0000 (16:45 +1000)]
UI: disable decorators for workspace buttons

4 months agoPreferences: auto-save on exit
Campbell Barton [Mon, 13 May 2019 05:59:27 +0000 (15:59 +1000)]
Preferences: auto-save on exit

Save modified preferences on exit by default,
with the option to disable this.

4 months agoPreferences: tag as dirty for add-ons & loading factory startup
Campbell Barton [Mon, 13 May 2019 05:51:49 +0000 (15:51 +1000)]
Preferences: tag as dirty for add-ons & loading factory startup

4 months agoUI: add load preferences operators to header
Campbell Barton [Mon, 13 May 2019 03:49:40 +0000 (13:49 +1000)]
UI: add load preferences operators to header

Recent changes only included them in the side-bar.

4 months agoPreferences: support loading factory preferences
Campbell Barton [Mon, 13 May 2019 03:25:51 +0000 (13:25 +1000)]
Preferences: support loading factory preferences

Previously it was only possible to load factory startup & preferences.

4 months agoPrefernces: support loading last saved preferences
Campbell Barton [Mon, 13 May 2019 02:44:08 +0000 (12:44 +1000)]
Prefernces: support loading last saved preferences

4 months agoreadfile: support preferences without loading data-blocks
Campbell Barton [Mon, 13 May 2019 02:36:14 +0000 (12:36 +1000)]
readfile: support preferences without loading data-blocks

Needed to support reading preferences without replacing blend file data.