6 years agoWe're entering 2.71rc state now
Sergey Sharybin [Thu, 12 Jun 2014 16:16:43 +0000 (22:16 +0600)]
We're entering 2.71rc state now

Meaning we do subversion bump and hopefully only splash
screen separates us from the final release. Unless some
bad regression is being discovered..

6 years agoQuiet double promotion warning & ws edit
Campbell Barton [Thu, 12 Jun 2014 16:22:40 +0000 (02:22 +1000)]
Quiet double promotion warning & ws edit

6 years agoFix crash running in background mode
Campbell Barton [Thu, 12 Jun 2014 15:05:20 +0000 (01:05 +1000)]
Fix crash running in background mode

6 years agoFix Bevel bug T39746, small scale gives flat profile.
Howard Trickey [Thu, 12 Jun 2014 14:22:10 +0000 (10:22 -0400)]
Fix Bevel bug T39746, small scale gives flat profile.

With very small meshes or very small bevel amounts, the bevel
profile would be flat even if a round one was requested.
Problem was that the code was checking the length of a cross
product for closeness to zero to test coplanarity. Needed
to normalize things before making that test to account for scale.

6 years agoUI: correct __contains__ use, no need for substring check
Campbell Barton [Thu, 12 Jun 2014 12:00:26 +0000 (22:00 +1000)]
UI: correct __contains__ use, no need for substring check

6 years agoFix T40559: Maya keymap node selection bug
Sergey Sharybin [Thu, 12 Jun 2014 08:33:28 +0000 (14:33 +0600)]
Fix T40559: Maya keymap node selection bug

6 years agoFix T40582: issues with apply scale when having multires and scene simplify
Sergey Sharybin [Thu, 12 Jun 2014 07:49:46 +0000 (13:49 +0600)]
Fix T40582: issues with apply scale when having multires and scene simplify

Reshape and applying scale matrix on multires needs to create DM with simplify
setting disabled. Added a special flag to modifier apply for this now.

6 years agoBake-API: Set Custom Cage to be Cage Object
Dalai Felinto [Thu, 12 Jun 2014 01:46:35 +0000 (22:46 -0300)]
Bake-API: Set Custom Cage to be Cage Object

Suggestion by Andy Davies (metalliandy) to conform with industry standard (custom cage is something else apparently)

Note: this is the last bake related commit I plan for 2.71/rc (unless
everyone agrees that we could squeeze in D546 - custom UVs, which would
be really nice to add for 2.71 scripters)

Note 2: I'll update the wiki docs shortly

6 years agoblenderplayer stuff
Antony Riakiotakis [Wed, 11 Jun 2014 23:28:48 +0000 (02:28 +0300)]
blenderplayer stuff

6 years agoFix flickering when transform snapping in edit mode and cursor is
Antony Riakiotakis [Wed, 11 Jun 2014 22:43:38 +0000 (01:43 +0300)]
Fix flickering when transform snapping in edit mode and cursor is
slightly outside the mesh.

Reported by Thomas Beck on irc. Issue here is that the mesh bounding box
changes as we are transforming the vertices. Solution is to collide
against the initial bounding box. Unfortunately the snapping functions
are made in a way that a lot of code needed to be tweaked here, but the
change should be straightforward and harmless (famous last words, I

Ideally we might want to even increase the size of the bounding box a
little (as seen in screen space) to allow snapping even in cases where,
cursor is slightly outside the bounding box, but since this is not so
straightforward to do for all cases, at least for me, leaving this as

6 years agoFix T40561: cycles refraction node with sharp distribution gives black.
Brecht Van Lommel [Wed, 11 Jun 2014 17:52:14 +0000 (19:52 +0200)]
Fix T40561: cycles refraction node with sharp distribution gives black.

6 years agoAdd patchset to recent Carve changes
Sergey Sharybin [Wed, 11 Jun 2014 07:13:36 +0000 (13:13 +0600)]
Add patchset to recent Carve changes

In the future i'd rather have this reported to an
upstream instead of adding local changes. It's really
easy to override this changes if patchset is not added
and this is to be fixed in upstream. Also the function
was never used so it was rather totally harmless warning
for us.

6 years agoCMake: quite warnings with 3.0 (without breaking < 3.0 CMakes)
Campbell Barton [Wed, 11 Jun 2014 05:59:03 +0000 (02:59 -0300)]
CMake: quite warnings with 3.0 (without breaking < 3.0 CMakes)

6 years agoBake-API: new approach for cage
Dalai Felinto [Wed, 11 Jun 2014 05:39:35 +0000 (02:39 -0300)]
Bake-API: new approach for cage

There is a new option to select whether you want to use cage or not.
When not using cage the results will be more similar with Blender
Internal, where the inwards rays (trying to hit the highpoly objects)
don't always come from smooth normals. So if the active object has sharp
edges and an EdgeSplit modifier you get bad corners.

This is useful, however, to bake to planes without the need of adding
extra loops around the edges.

When cage is "on" the user can decide on setting a cage extrusion or to
pick a Custom Cage object. The cage extrusion option works in a
duplicated copy of the active object with EdgeSplit modifiers removed to
inforce smooth normals. The custom cage option takes an object with the
same number of faces as the active object (and the same face ordering).

The custom cage now controls the direction and the origin of the
rays casted to the highpoly objects. The direction is a ray from the
point in the cage mesh to the equivalent point to the base mesh. That
means the face normals are entirely ignored when using a cage object.

For developers:
When using an object cage the ray is calculated from the cage mesh to
the base mesh. It uses the barycentric coordinate from the base mesh UV,
so we expect both meshes to have the same primitive ids (which won't be
the case if the cage gets edited in a destructive way).

That fixes T40023 (giving the expected result when 'use_cage' is false).

Thanks for Andy Davies (metalliandy) for the consulting with normal
baking workflow and extensive testing. His 'stress-test' file will be
added later to our svn tests folder. (The file itself is not public yet
since he still has to add testing notes to it).

Many thanks for the reviewers.

More on cages:

Reviewers: campbellbarton, sergey

CC: adriano, metalliandy, brecht, malkavian
Differential Revision:

6 years agoRevert "CMake: quiet warnings with 3.0"
Dalai Felinto [Wed, 11 Jun 2014 05:39:16 +0000 (02:39 -0300)]
Revert "CMake: quiet warnings with 3.0"

This reverts commit da7bdf1b47d4490c1a6f35740a9392cb9b5dd42e.

This broke compilation in OSX and some Linux boxes.
Error:  Policy "CMP0043" is not known to this version of CMake

Shall we leave those for after RC (or even 2.71) is out? ;)

6 years agoRegression Bugfix T40332: Bad driver behaviour on small distances.
Joshua Leung [Wed, 11 Jun 2014 03:48:43 +0000 (15:48 +1200)]
Regression Bugfix T40332: Bad driver behaviour on small distances.


I've reduced the size of the threshold for the keyframe lookup here. This threshold
determines the minimum time in frames between keyframes (i.e. "how close" to each
other they can get). Making this too small causes problems like T39207, but it seems
that the threshold we've been using makes it impossible to get accurate behaviour on
driver curves with keyframes, when the driver target only moves 2cm (i.e. 0.02 BU).

So far, all of the test cases from T39207 seem to work fine, as well as Caminandes 2
files, and Kenny the Caterpillar. The Kiribati rigs/shots (thanks jpbouza for helping
to check on these!) also seem to be fine.

6 years agoCMake: quiet warnigns with 3.0
Campbell Barton [Wed, 11 Jun 2014 03:46:19 +0000 (13:46 +1000)]
CMake: quiet warnigns with 3.0

6 years agocorrection from last commit
Dalai Felinto [Wed, 11 Jun 2014 00:36:48 +0000 (21:36 -0300)]
correction from last commit

6 years agoBake-API: removal of unecessary UV tests, as suggested by Campbell Barton
Dalai Felinto [Tue, 10 Jun 2014 23:50:55 +0000 (20:50 -0300)]
Bake-API: removal of unecessary UV tests, as suggested by Campbell Barton

6 years agoFix a warning in carve by initializing var
Jens Verwiebe [Tue, 10 Jun 2014 18:15:50 +0000 (20:15 +0200)]
Fix a warning in carve by initializing var

6 years agoFix Bevel multisegment profile bugs T39184, T37502 and last part of T40365.
Howard Trickey [Tue, 10 Jun 2014 15:07:06 +0000 (11:07 -0400)]
Fix Bevel multisegment profile bugs T39184, T37502 and last part of T40365.

When doing a 'weld' type join where there are two non-beveled edges
in the same plane one beveled one but not the other, then there
should be a curved profile; bug was creating a straight one.

6 years agoFix missing notifier when inserting keyframe
Sergey Sharybin [Tue, 10 Jun 2014 15:15:35 +0000 (21:15 +0600)]
Fix missing notifier when inserting keyframe

Reported by Sebastian Koenig in IRC

6 years agoFix T40551: Boolean Modifier distorts UVs
Sergey Sharybin [Tue, 10 Jun 2014 13:25:35 +0000 (19:25 +0600)]
Fix T40551: Boolean Modifier distorts UVs

Mapping to original face was never working 100% reliably actually,
now use more robust method for this.

6 years agoCurve: skip curves when matching bevel-fac (like 2.70)
Campbell Barton [Tue, 10 Jun 2014 12:32:33 +0000 (22:32 +1000)]
Curve: skip curves when matching bevel-fac (like 2.70)

6 years agoFix wrong memory write in partial render update with Save Buffers enabled
Sergey Sharybin [Tue, 10 Jun 2014 11:10:37 +0000 (17:10 +0600)]
Fix wrong memory write in partial render update with Save Buffers enabled

No idea why this issue hasn't been spotted before. Took several hours to
figure out where exactly wrong memory access happens..

P.S. I really want to switch ImBuf->rect from int* to unsigned char*...

6 years agoFix T40498 invalid textures flickering.
Antony Riakiotakis [Mon, 9 Jun 2014 22:36:53 +0000 (01:36 +0300)]
Fix T40498 invalid textures flickering.

Issue here is most likely sampler uniforms and textures not being
updated properly when zero binding is created. Solution for now is to
allow zero binding but when this happens use sexy pink invalid texture
instead :p.

6 years agoUsual UI message handling...
Bastien Montagne [Mon, 9 Jun 2014 19:52:10 +0000 (21:52 +0200)]
Usual UI message handling...

6 years agoFix for slowdown converting mesh to curve with large polygons
Campbell Barton [Mon, 9 Jun 2014 15:18:05 +0000 (01:18 +1000)]
Fix for slowdown converting mesh to curve with large polygons

Walk the linked list rather then doing index lookups.

6 years agoFix T40549: box selection starting point in the file requester.
Bastien Montagne [Mon, 9 Jun 2014 13:31:27 +0000 (15:31 +0200)]
Fix T40549: box selection starting point in the file requester.

We need to 'reset' mouse coordinates to the one it was when the gesture handling started,
else org coords are where the tweak event is created, which gives a noticeable gap
(several pixels) and unwanted behavior like the one retported about file box selection.

6 years agoFix T40057: invisible hair particles slowing down mesh edits
Sergey Sharybin [Mon, 9 Jun 2014 11:32:19 +0000 (17:32 +0600)]
Fix T40057: invisible hair particles slowing down mesh edits

Skip doing particle update in object_handle_update if object is in
edit mode.

Object will be re-evaluated on exit from edit mode anyway, so it's
_expected_ to be a safe change.

6 years agoQuiet assert in debug mode, deleting mask/gpencil keys
Campbell Barton [Mon, 9 Jun 2014 10:03:28 +0000 (20:03 +1000)]
Quiet assert in debug mode, deleting mask/gpencil keys

6 years agoFix T40534: Multi-button editing, hard to distinguish sliders
Campbell Barton [Mon, 9 Jun 2014 08:47:56 +0000 (18:47 +1000)]
Fix T40534: Multi-button editing, hard to distinguish sliders

6 years agoFix T40547: Can't read single channel EXRs
Sergey Sharybin [Mon, 9 Jun 2014 10:41:28 +0000 (16:41 +0600)]
Fix T40547: Can't read single channel EXRs

The root of the issue goes to the fact that we only can
read RGB EXR files, but they could be YCbCr or just Luma.
Added support for this two cases.

Note: internally EXR would still be 3 channels, so no
big memory save would happen here, at least yet.

6 years agoFix cycles CUDA error when trying to use >= 100 image textures.
Brecht Van Lommel [Mon, 9 Jun 2014 10:38:46 +0000 (12:38 +0200)]
Fix cycles CUDA error when trying to use >= 100 image textures.

6 years agoRevert "Fix T40382: 2D stabilization uses disabled markers"
Sergey Sharybin [Mon, 9 Jun 2014 08:11:48 +0000 (14:11 +0600)]
Revert "Fix T40382: 2D stabilization uses disabled markers"

It's not that trivial to support disapearing tracks in the sequence,
and since we're having ongoing 2D stabilization rework patch wouldn't
want to start doing rather bigger changes here now.

Let's just stick to legacy behavior for this release.

This reverts commits 91429d0543ce85

6 years agoFix T40529: Euler Rotation F-Curve Handlers wrong behaviour on moving keyframes
Sergey Sharybin [Mon, 9 Jun 2014 07:43:56 +0000 (13:43 +0600)]
Fix T40529: Euler Rotation F-Curve Handlers wrong behaviour on moving keyframes

6 years agoFix T40543: Duplicators draw with 'Render Only'
Campbell Barton [Mon, 9 Jun 2014 05:55:18 +0000 (15:55 +1000)]
Fix T40543: Duplicators draw with 'Render Only'

6 years agoFix T40538: Multi-button canceling edit-text could leave edited value
Campbell Barton [Mon, 9 Jun 2014 05:35:34 +0000 (15:35 +1000)]
Fix T40538: Multi-button canceling edit-text could leave edited value

6 years agoFix mempool bottleneck alloc & freeing a single item
Campbell Barton [Sun, 8 Jun 2014 13:07:00 +0000 (23:07 +1000)]
Fix mempool bottleneck alloc & freeing a single item

Would continuously reinitialize the first chunk of the mempool,
now check for at least 2 blocks.

6 years agoBMesh: avoid recursion for BM_mesh_edgenet, runs out stack memory on large nets
Campbell Barton [Sun, 8 Jun 2014 12:20:03 +0000 (22:20 +1000)]
BMesh: avoid recursion for BM_mesh_edgenet, runs out stack memory on large nets

6 years agoFix T40510, revert openmp thread count to how it was in
Antony Riakiotakis [Sat, 7 Jun 2014 22:13:28 +0000 (01:13 +0300)]
Fix T40510, revert openmp thread count to how it was in
2.70 for non Apple systems.

Also refactored the code that restores the previous openmp thread count.
The logic here was weird, mostly due to all the commit madness with
Apple openmp support. The restored thread count though should not depend
on the on/off state of threaded sculpting (since it has to do with
systems other than sculpting only). For OSX threads are restored to the
system thread count but Jens should recheck here.

6 years agoReplace open() with BLI_open
Campbell Barton [Sat, 7 Jun 2014 01:30:08 +0000 (11:30 +1000)]
Replace open() with BLI_open

6 years agoOSX: Ideasman does not like using utsname, so i use the always satisfactorily working...
Jens Verwiebe [Fri, 6 Jun 2014 20:06:26 +0000 (22:06 +0200)]
OSX: Ideasman does not like using utsname, so i use the always satisfactorily working sysctl method now for runtime OS detection

6 years agoFix T40514: Cycles world MIS segfault
Campbell Barton [Fri, 6 Jun 2014 14:08:40 +0000 (00:08 +1000)]
Fix T40514: Cycles world MIS segfault

6 years agoBMesh: avoid OpenMP use for low poly meshes (counting selection)
Campbell Barton [Fri, 6 Jun 2014 13:52:29 +0000 (23:52 +1000)]
BMesh: avoid OpenMP use for low poly meshes (counting selection)

also use schedule(static) for simple for loops.

6 years agoFix T40370: cycles CUDA baking timeout with high number of AA samples.
Brecht Van Lommel [Fri, 6 Jun 2014 12:40:09 +0000 (14:40 +0200)]
Fix T40370: cycles CUDA baking timeout with high number of AA samples.

Now baking does one AA sample at a time, just like final render. There is
also some code for shader antialiasing that solves T40369 but it is disabled
for now because there may be unpredictable side effects.

6 years agoFix T40520: Properties panel in properties region in 3D view does not go away.
Bastien Montagne [Fri, 6 Jun 2014 12:38:07 +0000 (14:38 +0200)]
Fix T40520: Properties panel in properties region in 3D view does not go away.

Ignore '_RNA_UI' IDP...

6 years agoFix T38668: When using Maya Input style, there is no way to snap Knife tool to midpoints
Sergey Sharybin [Fri, 6 Jun 2014 12:49:41 +0000 (18:49 +0600)]
Fix T38668: When using Maya Input style, there is no way to snap Knife tool to midpoints

6 years agoFix T40519: Keyed parameter are not redrawed
Sergey Sharybin [Fri, 6 Jun 2014 12:15:18 +0000 (18:15 +0600)]
Fix T40519: Keyed parameter are not redrawed

The issue has been introduced in 1fabfc9 by changing
notifiers being sent.

6 years agoFix T40522: Viewport layer name is not redrawed.
Bastien Montagne [Fri, 6 Jun 2014 12:14:56 +0000 (14:14 +0200)]
Fix T40522: Viewport layer name is not redrawed.

Yet another missing redraw flag catching (only affecting Cycles, in this case).

6 years agoFix compilation error after recent changes
Sergey Sharybin [Fri, 6 Jun 2014 10:07:58 +0000 (16:07 +0600)]
Fix compilation error after recent changes

fmc->script is a text datablock, for which we need to
access to it's IT property.

6 years agoFix T40282: Renaming node sockets in Cycles nodes causes crash.
Lukas Tönne [Fri, 6 Jun 2014 07:25:05 +0000 (09:25 +0200)]
Fix T40282: Renaming node sockets in Cycles nodes causes crash.

Cycles expects to find all node sockets with their correct names, but
this can be changed via the API (see bug report discussion).

Solution for now is to let cycles accept this case gracefully instead
of crashing. The shader will simply use the internal default values for
inputs and any connections will be ignored.

Would be nice to report the error somewhere, but cycles doesn't have a
proper logging system for this purpose yet.

6 years agoFix for missing visits of ID's within SceneRenderLayer in BKE_library_foreach_ID_link().
Tamito Kajiyama [Fri, 6 Jun 2014 03:51:14 +0000 (12:51 +0900)]
Fix for missing visits of ID's within SceneRenderLayer in BKE_library_foreach_ID_link().

Just noticed them while working on the previous commit (rB00f722042c07).

6 years agoFix for missing visits of Freestyle-related ID data blocks in BKE_library_foreach_ID_...
Tamito Kajiyama [Fri, 6 Jun 2014 03:44:48 +0000 (12:44 +0900)]
Fix for missing visits of Freestyle-related ID data blocks in BKE_library_foreach_ID_link().

6 years agoCode cleanup: remove redundant void*->int->bool cast on NULL pointer
Campbell Barton [Fri, 6 Jun 2014 01:44:34 +0000 (11:44 +1000)]
Code cleanup: remove redundant void*->int->bool cast on NULL pointer

6 years agoFix T40508: Calculating normals crashes
Campbell Barton [Fri, 6 Jun 2014 01:24:59 +0000 (11:24 +1000)]
Fix T40508: Calculating normals crashes

6 years agoFreestyle: Fix for viewport render not updating with changes of Freestyle settings.
Tamito Kajiyama [Thu, 5 Jun 2014 15:56:04 +0000 (00:56 +0900)]
Freestyle: Fix for viewport render not updating with changes of Freestyle settings.

6 years agoFreestyle: Fix for operator error messages with no active line set and associated...
Tamito Kajiyama [Thu, 5 Jun 2014 13:58:51 +0000 (22:58 +0900)]
Freestyle: Fix for operator error messages with no active line set and associated line style.

This commit amends a de-duplication of error messages in the commit rB6067fa682b0c.

6 years agoUI: higher precision for IK poll angle
Campbell Barton [Thu, 5 Jun 2014 23:50:38 +0000 (09:50 +1000)]
UI: higher precision for IK poll angle

6 years agoCode cleanup: style
Campbell Barton [Thu, 5 Jun 2014 21:54:05 +0000 (07:54 +1000)]
Code cleanup: style

6 years agoOSX: replace deprecated (10.8 ) Gestalt function with utsname, no functional change
Jens Verwiebe [Thu, 5 Jun 2014 20:14:14 +0000 (22:14 +0200)]
OSX: replace deprecated (10.8 ) Gestalt function with utsname, no functional change

6 years agoFix T40228: cycles CUDA multi GPU + world MIS giving error.
Brecht Van Lommel [Thu, 5 Jun 2014 16:10:06 +0000 (18:10 +0200)]
Fix T40228: cycles CUDA multi GPU + world MIS giving error.

6 years agoFix T40429: cycles CUDA + use persistent images problem.
Brecht Van Lommel [Thu, 5 Jun 2014 15:39:16 +0000 (17:39 +0200)]
Fix T40429: cycles CUDA + use persistent images problem.

6 years agoFix subpixel precision in transform node
Sergey Sharybin [Thu, 5 Jun 2014 16:05:05 +0000 (22:05 +0600)]
Fix subpixel precision in transform node

The node was using sampler from the callee node and passed
it to the input nodes. Since the fact that compositor output
node uses NEAREST interpolation (why it uses nearest is the
whole separate story) it's not possible to have subpixel
precision in such cases:

  <image> -> <translate> -> <output>

For now solving by hard-coding translate node to use BILINEAR
interpolation. It can't become worse in this node anyway and
the sampling pipeline is to be re-visited from scratch.

6 years agoTweak to previous commit
Sergey Sharybin [Thu, 5 Jun 2014 13:37:12 +0000 (19:37 +0600)]
Tweak to previous commit

6 years agoFix T40382: 2D stabilization uses disabled markers
Sergey Sharybin [Thu, 5 Jun 2014 13:25:21 +0000 (19:25 +0600)]
Fix T40382: 2D stabilization uses disabled markers

This lead to unpredictable results in some cases.

6 years agoAvoid openmp sections in BM_mesh_elem_index_ensure
Campbell Barton [Thu, 5 Jun 2014 08:50:10 +0000 (18:50 +1000)]
Avoid openmp sections in BM_mesh_elem_index_ensure

6 years agoCode cleanup: mixup hflag/htype
Campbell Barton [Thu, 5 Jun 2014 08:37:53 +0000 (18:37 +1000)]
Code cleanup: mixup hflag/htype

6 years agoFix T40436: No preview in Brush with Cycles
Sergey Sharybin [Thu, 5 Jun 2014 07:15:01 +0000 (13:15 +0600)]
Fix T40436: No preview in Brush with Cycles

More like a feature request, but after i've implemented preview for
icons it was rather simple to support nodes previews.

6 years agoBlender Internal: Fix for lamp option "Specular" not working when "Only Shadow" is...
IRIE Shinsuke [Fri, 30 May 2014 13:11:06 +0000 (22:11 +0900)]
Blender Internal: Fix for lamp option "Specular" not working when "Only Shadow" is enabled.

This is followup to rB8008d9bdfd57. Blender Render and GLSL preview
now produce the same results.

6 years agoCorrect hard-coded height for UV-Vertex buttons
Campbell Barton [Thu, 5 Jun 2014 05:00:26 +0000 (15:00 +1000)]
Correct hard-coded height for UV-Vertex buttons

6 years agoFreestyle: Fix for Interface0DIterator.object docstring with additional notes.
Tamito Kajiyama [Thu, 5 Jun 2014 05:06:25 +0000 (14:06 +0900)]
Freestyle: Fix for Interface0DIterator.object docstring with additional notes.

6 years agoFix T40423: UV Editing 'Draw Other Objects' fails with Cycles
Campbell Barton [Thu, 5 Jun 2014 03:55:50 +0000 (13:55 +1000)]
Fix T40423: UV Editing 'Draw Other Objects' fails with Cycles

6 years agoFreestyle: Fix for a wrong formula used for RGB to grayscale conversion.
Tamito Kajiyama [Thu, 5 Jun 2014 03:55:22 +0000 (12:55 +0900)]
Freestyle: Fix for a wrong formula used for RGB to grayscale conversion.

This bug fix is likely to affect the visual results of existing Freestyle setups using the
Material color/alpha/thickness modifiers with the 'material_attribute' parameter set to
either 'Diffuse' (default) or 'Specular', and also the Ramp option enabled in the case
of the Material color modifier.

6 years agoBMesh: avoid using OpenMP when nothing to do
Campbell Barton [Wed, 4 Jun 2014 22:10:26 +0000 (08:10 +1000)]
BMesh: avoid using OpenMP when nothing to do

Gave slowdown drawing on high poly meshes

6 years agoFix T40482: Cycles matlib file crashes
Sergey Sharybin [Wed, 4 Jun 2014 20:29:48 +0000 (02:29 +0600)]
Fix T40482: Cycles matlib file crashes

it's possible that runtime optimizer would call get_attribute
with NULL renderstate. As per documentation, it's valid to
return false in that cases and in worst case we'll just miss
some possible optimization.

Supporting such cases would require some bigger changes to
Cycles since attributes are only set to up for the kernel
after shader compilation.

Thanks Brecht for review!

6 years agoFix T40478: wrong cycles fresnel with GLSL materials in the viewport.
Brecht Van Lommel [Wed, 4 Jun 2014 17:35:56 +0000 (19:35 +0200)]
Fix T40478: wrong cycles fresnel with GLSL materials in the viewport.

6 years agoFix issues when ungrouping meta changes the final sequencer render
Sergey Sharybin [Wed, 4 Jun 2014 16:05:33 +0000 (22:05 +0600)]
Fix issues when ungrouping meta changes the final sequencer render

Seems to be caused by the way how the most bottom strip in the stack
used to apply effect. Just rendering strip in this cases will not give
proper results.

Made it so effect is applying between empty imbuf and actual strip.
Seems to work by tests, but more intense testing is required.

6 years agoFix T40456: cycles bug with branched path + sss + no sample all direct lights.
Brecht Van Lommel [Wed, 4 Jun 2014 15:54:10 +0000 (17:54 +0200)]
Fix T40456: cycles bug with branched path + sss + no sample all direct lights.

6 years agoOptimize editmode drawing edgees
Campbell Barton [Wed, 4 Jun 2014 10:40:42 +0000 (20:40 +1000)]
Optimize editmode drawing edgees

Was interpolating and setting the color twice per edge.
Now only set the color when needed (can be once per draw),
~2x speedup for edge drawing.

6 years agoOSX 10.10: fix for Blender crashing on fsmenu due icloud in the favorite list but...
Jens Verwiebe [Wed, 4 Jun 2014 08:54:21 +0000 (10:54 +0200)]
OSX 10.10: fix for Blender crashing on fsmenu due icloud in the favorite list but pointer is NULL when not activated
This does not break other OSX versions, just add a check for pathString

6 years agoFreestyle: Fix for a potential infinite loop in stroke resampling by vertex count.
Tamito Kajiyama [Wed, 4 Jun 2014 05:51:39 +0000 (14:51 +0900)]
Freestyle: Fix for a potential infinite loop in stroke resampling by vertex count.

Changes were made in Stroke::Resample(int) in C++ to prevent a potential infinite loop
caused by an inconsistency between Stroke::_Length and the stroke length computed
based on stroke vertices.  Such a stroke length inconsistency is usually caused by missing
calls of Stroke::UpdateLength() (i.e., API implementation bugs), but also may occur due
to scripting errors in user-defined style modules.  This commit is meant to help script
writters to identify the latter error cases.  Now Stroke.resample(int) may raise a runtime
error to signal an error condition.

6 years agoFix for dupli's ignoring color in set-scenes
Campbell Barton [Wed, 4 Jun 2014 04:22:29 +0000 (14:22 +1000)]
Fix for dupli's ignoring color in set-scenes

also skip setting wire color drawing depth

6 years agoFix T40489: Curve drawing skipped loose-wire when mixed with solid faces
Campbell Barton [Tue, 3 Jun 2014 22:36:22 +0000 (08:36 +1000)]
Fix T40489: Curve drawing skipped loose-wire when mixed with solid faces

6 years agoTweaks to bevel and crease transform
Sergey Sharybin [Tue, 3 Jun 2014 16:02:02 +0000 (22:02 +0600)]
Tweaks to bevel and crease transform

They were using INPUT_SPRING in a way which didn't allow
it to easily redo the operator because INPUT_SPRING internally
is stored as a ration between old value and new one and crease
and bevel were converting this to value delta.

Now made it special input type INPUT_SPRING_DELTA which is
storing delta of the spring, meaning now values in the redo
panel kind of makes sense -- they mean how much to add/remove
to the crease/bevel weight.

Expect to be no functional changes from interactive transform
POV, just a bit more convenient to use redo panel.

6 years agoChange to key modifier should trigger re-evaluation of drag-and-drop
Campbell Barton [Tue, 3 Jun 2014 13:00:39 +0000 (23:00 +1000)]
Change to key modifier should trigger re-evaluation of drag-and-drop

This change is part of a fix for T40435, but will postpone for now.

Original patch by Sergey Sharybin

6 years agoCode cleanup: replace macro with function to reduce binary size
Campbell Barton [Tue, 3 Jun 2014 09:25:07 +0000 (19:25 +1000)]
Code cleanup: replace macro with function to reduce binary size

6 years agoBake-API small cleanup
Dalai Felinto [Tue, 3 Jun 2014 05:14:28 +0000 (02:14 -0300)]
Bake-API small cleanup

6 years agoFix T40476 - Baking multiple selected objects in Cycles final result
Dalai Felinto [Tue, 3 Jun 2014 05:14:12 +0000 (02:14 -0300)]
Fix T40476 - Baking multiple selected objects in Cycles final result
depends on last selected object

Reviewers: campbellbarton

Differential Revision:

6 years agoBake-API prevent baking for engines that dont support the baking API
Dalai Felinto [Tue, 3 Jun 2014 03:34:20 +0000 (00:34 -0300)]
Bake-API prevent baking for engines that dont support the baking API

In the future we can fallback to the Blender Internal baking.

Review/Suggestions by Campbell Barton

6 years agoView3d Toolbar: project-paint tools were in options, move into own panel
Campbell Barton [Tue, 3 Jun 2014 02:05:47 +0000 (12:05 +1000)]
View3d Toolbar: project-paint tools were in options, move into own panel

6 years agoFix T39053: Replace mesh actuator does not replace material (only mesh)
Mitchell Stokes [Tue, 3 Jun 2014 01:52:13 +0000 (18:52 -0700)]
Fix T39053: Replace mesh actuator does not replace material (only mesh)

The replace mesh actuator was reconverting the mesh data which causes
conflicts with the LoD code. Instead, we just look for an already
converted mesh, which should already be in the scene.

6 years agoCorrect last commit: workaround for BGE
Campbell Barton [Tue, 3 Jun 2014 01:32:45 +0000 (11:32 +1000)]
Correct last commit: workaround for BGE

6 years agoCode cleanup: use typedefs for ui handler functions
Campbell Barton [Mon, 2 Jun 2014 22:58:16 +0000 (08:58 +1000)]
Code cleanup: use typedefs for ui handler functions

6 years agoFix T40448: Blurring bug in the compositor
Sergey Sharybin [Mon, 2 Jun 2014 12:33:19 +0000 (18:33 +0600)]
Fix T40448: Blurring bug in the compositor

This commit pretty much reverts all the changes related on tile-ability
of the fast gaussian blur. It's not tilable by definition and would almost
always give you seams on the tile boundaries.

Atmind already met the issue and tried to solve it by increasing some
magic constant, which is pretty much likely simply made it so compositor
switched to full-frame calculation in that particular .blend file.

Fast gaussian is really not a production thing and need to be avoided.
We're to improve speed of normal gaussian blur instead.

6 years agoDisable key-modifier detection when activating windows
Campbell Barton [Mon, 2 Jun 2014 12:31:32 +0000 (22:31 +1000)]
Disable key-modifier detection when activating windows

Causes issues on X11 for some users

6 years agoOSX: Set and creation and modification date to compilet...
Jens Verwiebe [Mon, 2 Jun 2014 12:19:56 +0000 (14:19 +0200)]
OSX: Set and creation and modification date to compiletime, else we would always have the time from checkout here

6 years agoFix compilation on unofficial 64bit archs
Matteo F. Vescovi [Mon, 24 Mar 2014 07:48:07 +0000 (08:48 +0100)]
Fix compilation on unofficial 64bit archs

6 years agoFix compilation error non non-linux architectures
Matteo F. Vescovi [Mon, 26 May 2014 07:37:54 +0000 (09:37 +0200)]
Fix compilation error non non-linux architectures

6 years agoFix T40457: Subsurf modifier with Freestyle edges
Sergey Sharybin [Mon, 2 Jun 2014 08:24:25 +0000 (14:24 +0600)]
Fix T40457: Subsurf modifier with Freestyle edges

You can't use ORIG index as an index to copy CD from source DM.