blender.git
12 months agoCleanup: unused headers
Campbell Barton [Tue, 11 Feb 2020 00:51:12 +0000 (11:51 +1100)]
Cleanup: unused headers

12 months agoCleanup: add license header, use header guards
Campbell Barton [Tue, 11 Feb 2020 00:37:35 +0000 (11:37 +1100)]
Cleanup: add license header, use header guards

12 months agoDoc: update to T73699 fix
Campbell Barton [Tue, 11 Feb 2020 00:29:19 +0000 (11:29 +1100)]
Doc: update to T73699 fix

It's important to refer to "other selected objects" in this case.

12 months agoDoc: simplify T72883 fix
Campbell Barton [Tue, 11 Feb 2020 00:27:01 +0000 (11:27 +1100)]
Doc: simplify T72883 fix

Code example made it seem setting the active object was more complex
than a single assignment.

12 months agoRNA: Raise error assigning an active object which doesn't exist
Campbell Barton [Mon, 10 Feb 2020 10:58:52 +0000 (21:58 +1100)]
RNA: Raise error assigning an active object which doesn't exist

Previously this silently cleared the view layers active object.

12 months agoFix T72883: Correct Context Usage
Aaron Carlisle [Mon, 10 Feb 2020 19:08:34 +0000 (14:08 -0500)]
Fix T72883: Correct Context Usage

12 months agoFix T73699: Unhelpful error message when trying to knife project a manifold object
Aaron Carlisle [Mon, 10 Feb 2020 18:38:16 +0000 (13:38 -0500)]
Fix T73699: Unhelpful error message when trying to knife project a manifold object

12 months agoRevert "Sculpt: Remove partial viewport updates from sculpt stroke code"
Pablo Dobarro [Tue, 28 Jan 2020 00:22:30 +0000 (01:22 +0100)]
Revert "Sculpt: Remove partial viewport updates from sculpt stroke code"

This reverts commit 394b48029c5335381f774f83524ad6ee5cb986da.

Leaving this here does not affect performance in any significant way and it may be useful in the future.

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D6688

12 months agoFix T72690: Do not draw points behind the viewport camera in the paint cursor
Pablo Dobarro [Thu, 23 Jan 2020 20:41:30 +0000 (21:41 +0100)]
Fix T72690: Do not draw points behind the viewport camera in the paint cursor

In some situations the symmetry point may be behind the camera, so the
projection is inverted and it looks wrong. This avoids drawing points in
screen space when they are behind the camera.

Reviewed By: jbakker

Maniphest Tasks: T72690

Differential Revision: https://developer.blender.org/D6487

12 months agoFix T66349: Add missing update for face orientation overlay
Pablo Dobarro [Thu, 23 Jan 2020 20:36:58 +0000 (21:36 +0100)]
Fix T66349: Add missing update for face orientation overlay

This forces the full geometry when that overlay is enabled.
I would rather not support this and leave that bug as a know issues/
limitation because this is terrible for performance and people may not
be aware that by enabling the option they are disabling the
optimization.

Reviewed By: jbakker

Maniphest Tasks: T66349

Differential Revision: https://developer.blender.org/D6552

12 months agoCleanup: Fix warning (unused variable)
Dalai Felinto [Mon, 10 Feb 2020 18:09:53 +0000 (19:09 +0100)]
Cleanup: Fix warning (unused variable)

12 months agoCleanup: Rename `BKE_library_override_` functions to `BKE_lib_override_library_`
Bastien Montagne [Mon, 10 Feb 2020 17:05:19 +0000 (18:05 +0100)]
Cleanup: Rename `BKE_library_override_` functions to `BKE_lib_override_library_`

pqrt of T72604.

12 months agoUpdated install_deps to latest required OSL/LLVM.
Bastien Montagne [Mon, 10 Feb 2020 16:35:17 +0000 (17:35 +0100)]
Updated install_deps to latest required OSL/LLVM.

12 months agoCTest: Disable the cross test from the avxf unit tests.
Ray Molenkamp [Mon, 10 Feb 2020 16:27:11 +0000 (09:27 -0700)]
CTest: Disable the cross test from the avxf unit tests.

Test fails on AVX2, I'll look into this but until the
cause is determined the test will be disabled

12 months agoRefactor: move `Library`-specific functions into proper `BKE_library` file.
Bastien Montagne [Mon, 10 Feb 2020 16:10:17 +0000 (17:10 +0100)]
Refactor: move `Library`-specific functions into proper `BKE_library` file.

Even though we do not have much of those, this might change in the
future, and in any case having specific functions for this ID type in
generic `BKE_lib` area was really confusing.

12 months agoFix mismatch in BKE headers' multi-include safeguards naming.
Bastien Montagne [Mon, 10 Feb 2020 15:54:24 +0000 (16:54 +0100)]
Fix mismatch in BKE headers' multi-include safeguards naming.

Forgot to update those in recent `BKE_lib_` files renames.

12 months agoCleanup CLOG identifiers in BKE_lib' implementation files.
Bastien Montagne [Mon, 10 Feb 2020 15:30:41 +0000 (16:30 +0100)]
Cleanup CLOG identifiers in BKE_lib' implementation files.

12 months agoMerge branch 'blender-v2.82-release'
Lukas Stockner [Mon, 10 Feb 2020 15:26:44 +0000 (16:26 +0100)]
Merge branch 'blender-v2.82-release'

12 months agoFix unreported: Packing/unpacking errors don't mention tiled images
Lukas Stockner [Mon, 10 Feb 2020 15:19:30 +0000 (16:19 +0100)]
Fix unreported: Packing/unpacking errors don't mention tiled images

Thanks to @dfelinto for spotting this!

12 months agoGPencil: Fix unreported missing annotation popover menu
Antonio Vazquez [Mon, 10 Feb 2020 10:55:49 +0000 (11:55 +0100)]
GPencil: Fix unreported missing annotation popover menu

This was introduced when annotations was splited.

12 months agoFix T73713: Tiled textures (UDIM) getting lost when saving the .blend but not the...
Lukas Stockner [Mon, 10 Feb 2020 15:12:45 +0000 (16:12 +0100)]
Fix T73713: Tiled textures (UDIM) getting lost when saving the .blend but not the textures

The issue here is simple, IMA_SRC_TILED was missing from a check for whether the image should
be saved.

Note that tiled images won't be automatically saved if they have never been saved before.
For single images this is handled by packing them, but packing of tiled images isn't
supported yet.

However, in that case the file closing dialog will at least show a warning now instead of
completely ignoring tiled images.

12 months agoCleanup/Refactor: Move ID deletion into its own .c file.
Bastien Montagne [Mon, 10 Feb 2020 14:55:43 +0000 (15:55 +0100)]
Cleanup/Refactor: Move ID deletion into its own .c file.

Having functions defined in `BKE_lib_id.h` implemented into
`lib_remap.c` was confusing at best.

Besides trivial code splitting and header includes cleanup, had to add a
new `lib_intern.h` header for callbacks used by both remapping and
deletion code.

12 months agoBLI: add utilities for defining non-movable and non-copyable classes
Jacques Lucke [Mon, 10 Feb 2020 14:29:17 +0000 (15:29 +0100)]
BLI: add utilities for defining non-movable and non-copyable classes

Structs and classes can subclass these member-free classes privately.
Then they become non-movable, non-copyable or both.

12 months agoUSD: Install USD library via install_deps.sh
Sybren A. Stüvel [Mon, 10 Feb 2020 14:07:49 +0000 (15:07 +0100)]
USD: Install USD library via install_deps.sh

This commit adds the download, extract, patch, build, and install of the
Universal Scene Description (USD) library to the `install_deps.sh`
script.

Reviewed By: mont29, LazyDodo

Differential Revision: https://developer.blender.org/D6478

12 months agoCleanup: Add basic doc about each `BKE_main` and `BKE_lib` files.
Bastien Montagne [Mon, 10 Feb 2020 14:05:54 +0000 (15:05 +0100)]
Cleanup: Add basic doc about each `BKE_main` and `BKE_lib` files.

Including expected prefixes for functions in those files.

Part of T72604.

12 months agoFix missed include update in recent BKE_library renaming.
Bastien Montagne [Mon, 10 Feb 2020 13:21:34 +0000 (14:21 +0100)]
Fix missed include update in recent BKE_library renaming.

12 months agoBLI: improve various C++ data structures
Jacques Lucke [Mon, 10 Feb 2020 12:54:57 +0000 (13:54 +0100)]
BLI: improve various C++ data structures

The changes come from the `functions` branch, where I'm using
these structures a lot.

This also includes a new `BLI::Optional<T>` type, which is similar
to `std::Optional<T>` which can be used when Blender starts using
C++17.

12 months agoCycles: internal support for constant object/mesh attribute values
Alex Fuller [Mon, 10 Feb 2020 10:04:26 +0000 (11:04 +0100)]
Cycles: internal support for constant object/mesh attribute values

None are currently exported from Blender, this fixes the Cycles side
implementation.

Differential Revision: https://developer.blender.org/D6794

12 months agoUI: Graph Editor Show Cursor panel
William Reynish [Mon, 10 Feb 2020 12:26:08 +0000 (13:26 +0100)]
UI: Graph Editor Show Cursor panel

Make the Graph Editor Cursor panel fit in and use the split layout.

Also removed the snap buttons, since they were only a subset of the snapping possibilities, all of which are in Key > Snap anyway, and also in the context menu.

Update the theme to use correct hierarchy progression like in other editors.

Differential Revision: https://developer.blender.org/D6785

Reviewed by Brecht van Lommel

12 months agoCleanup/refactor: Rename `BKE_library` files to `BKE_lib`.
Bastien Montagne [Mon, 10 Feb 2020 11:58:59 +0000 (12:58 +0100)]
Cleanup/refactor: Rename `BKE_library` files to `BKE_lib`.

Note that `BKE_library.h`/`library.c` were renamed to
`BKE_lib_id.h`/`lib_id.c` to avoid having a too generic name here.

Part of T72604.

12 months agoTracking: Clarify calculation of camera matrix for object solver
Sergey Sharybin [Mon, 10 Feb 2020 11:46:01 +0000 (12:46 +0100)]
Tracking: Clarify calculation of camera matrix for object solver

It might be confusing why matrix is constructed from scratch rather
than using already calculated one.

12 months agoTracking: Cleanup, more clear variable name
Sergey Sharybin [Mon, 10 Feb 2020 11:40:54 +0000 (12:40 +0100)]
Tracking: Cleanup, more clear variable name

12 months agoTracking: Fix usage PLACEHOLDER function
Sergey Sharybin [Mon, 10 Feb 2020 11:36:49 +0000 (12:36 +0100)]
Tracking: Fix usage PLACEHOLDER function

Don't use BKE_view_layer_context_active_PLACEHOLDER which is marked
as "never use this".

In fact, it isn't needed to lookup for camera in the tracking function
at all: camera object is always explicitly passed to it.

12 months agoPY API doc generation: Add option for multi-tasking sphinx.
Bastien Montagne [Mon, 10 Feb 2020 11:37:15 +0000 (12:37 +0100)]
PY API doc generation: Add option for multi-tasking sphinx.

12 months agoFix T61138: Difficulty in aligning handles of Stroke of type Curve
mano-wii [Mon, 10 Feb 2020 11:17:26 +0000 (08:17 -0300)]
Fix T61138: Difficulty in aligning handles of Stroke of type Curve

The user has preference to select the center point for alignment.
But in this case, it was not available for selection.

Also prioritizes selection of the middle point over the handles.

Reviewed By: #user_interface, brecht

Differential Revision: https://developer.blender.org/D6780

12 months agoGPencil: Fix unreported missing annotation popover menu
Antonio Vazquez [Mon, 10 Feb 2020 10:55:49 +0000 (11:55 +0100)]
GPencil: Fix unreported missing annotation popover menu

This was introduced when annotations was splited.

12 months agoCycles: Fix linking error of new avxf unit tests
Sergey Sharybin [Mon, 10 Feb 2020 10:13:08 +0000 (11:13 +0100)]
Cycles: Fix linking error of new avxf unit tests

Was happening on macOS. The reason of this is because OpenImageIO
depends on boost, so it is to be passed to the linker after the
OpenImageIO libraries.

12 months agoFix: Missed this line in last commit
William Reynish [Mon, 10 Feb 2020 10:04:34 +0000 (11:04 +0100)]
Fix: Missed this line in last commit

12 months agoUI: Bone Custom Shape layout
William Reynish [Mon, 10 Feb 2020 09:53:59 +0000 (10:53 +0100)]
UI: Bone Custom Shape layout

The layout was somewhat poor - hard to see what relates to the custom object, and also weirdly we show the Wireframe toggle above the Custom Object control, even though it can only be active if a bone has a custom object set.

Instead, I grouped everything in a Custom Shape sub-panel and used greying out.

Differential Revision: https://developer.blender.org/D6789

Reviewed by Brecht van Lommel

12 months agoFix T73681: Python exception adding Empty objects via `object_data_add`
Philipp Oeser [Mon, 10 Feb 2020 09:26:34 +0000 (10:26 +0100)]
Fix T73681: Python exception adding Empty objects via `object_data_add`
with "Enter Edit Mode" enabled

It is valild to add Empties this way, but we cannot enter editmode on
those.

12 months agoFix T73696: Text editor scroll glitch
Kai Jægersen [Mon, 10 Feb 2020 06:04:01 +0000 (17:04 +1100)]
Fix T73696: Text editor scroll glitch

Scrolling a short text buffer could show the cursor offset.

12 months agoCleanup: spelling
Campbell Barton [Sun, 9 Feb 2020 23:33:00 +0000 (10:33 +1100)]
Cleanup: spelling

12 months agoCleanup: sort file, struct lists
Campbell Barton [Sun, 9 Feb 2020 23:08:31 +0000 (10:08 +1100)]
Cleanup: sort file, struct lists

12 months agoCleanup: keymap formatting, unused arg
Campbell Barton [Sun, 9 Feb 2020 23:07:58 +0000 (10:07 +1100)]
Cleanup: keymap formatting, unused arg

12 months agoVSE: Add option to select handles with box selection
Richard Antalik [Sun, 9 Feb 2020 16:59:13 +0000 (17:59 +0100)]
VSE: Add option to select handles with box selection

Patch adds an "Handle" option to the `SEQUENCER_OT_box_select` operator,
that allows to select the handles instead of whole strips.
Feature is mapped to Alt key modifier

A difference from the proposed design in T70730 is that covering the entire strip with the box actually selects both handles.

Reviewed By: iss

Differential Revision: https://developer.blender.org/D6372

12 months agoMerge branch 'blender-v2.82-release'
Sebastián Barschkis [Sun, 9 Feb 2020 16:27:15 +0000 (17:27 +0100)]
Merge branch 'blender-v2.82-release'

12 months agoFluid: Optimization for fluid domain obstacle boundary handling
Sebastián Barschkis [Thu, 6 Feb 2020 18:27:47 +0000 (19:27 +0100)]
Fluid: Optimization for fluid domain obstacle boundary handling

This fix should especially improve liquid obstacles boundaries, i.e. help with the problem of particles sticking to the surface.

12 months agoFluid: Fixed file formats for script exporter
Sebastián Barschkis [Sun, 9 Feb 2020 16:17:24 +0000 (17:17 +0100)]
Fluid: Fixed file formats for script exporter

File formats in the exported scripts were using hardcoded file extensions and not the ones specified in the UI.

12 months agoFluid: Fixes for fluid guiding
Sebastián Barschkis [Sun, 9 Feb 2020 16:15:41 +0000 (17:15 +0100)]
Fluid: Fixes for fluid guiding

Fluid guiding functionality was broken in the bake / read cache loop in fluid.c. Committing this to the release branch as otherwise fluid guiding would not have worked as expected (i.e. not at all).

12 months agoFluid: Updated manta pp files
Sebastián Barschkis [Sun, 9 Feb 2020 16:09:00 +0000 (17:09 +0100)]
Fluid: Updated manta pp files

Includes the OpenVDB read/write functions for int grids. This essential for the resume bake functionality in modular fluid caches.

12 months agoFix eigen/openmp link error in some build configurations
Brecht Van Lommel [Sun, 9 Feb 2020 15:29:07 +0000 (16:29 +0100)]
Fix eigen/openmp link error in some build configurations

12 months ago3D View: support axis views with axis-aligned roll
Campbell Barton [Sun, 9 Feb 2020 00:50:25 +0000 (11:50 +1100)]
3D View: support axis views with axis-aligned roll

Previously any of the named views could not have any roll,
this commit supports roll as long as it's axis-aligned (90,180,270 deg).

This is useful for snapping to views,
an improvement on cebd025e02f11.

12 months agoBLI_string_utils: add utility to join a string into a fixed buffer
Campbell Barton [Sun, 9 Feb 2020 14:23:43 +0000 (01:23 +1100)]
BLI_string_utils: add utility to join a string into a fixed buffer

12 months ago3D View: check view quaternion alignment which orbiting
Bataev Artem [Sun, 9 Feb 2020 00:32:08 +0000 (11:32 +1100)]
3D View: check view quaternion alignment which orbiting

This makes auto-perspective work as expected
when orbiting out of a snapped view.

12 months agoCleanup/CMake: Fix superfluous warning of WITH_BOOST being turned off
Ray Molenkamp [Sun, 9 Feb 2020 00:17:28 +0000 (17:17 -0700)]
Cleanup/CMake: Fix superfluous warning of WITH_BOOST being turned off

The check for turning boost off did not actually check if WITH_BOOST
was on to start with leading to a superfluous warning during configuration.

12 months agoWindows: Improve rebuild.cmd
Ray Molenkamp [Sun, 9 Feb 2020 00:14:47 +0000 (17:14 -0700)]
Windows: Improve rebuild.cmd

Previously the MSVC environment was setup every time using vcvarsall.bat
when you ran you ran rebuild.cmd, Generally not an issue but after many
rebuilds on the same console, it grows the path environment variable
beyond what is supported and building breaks.

This patch adds a check to see if the environment is setup already
and skips the call to vcvarsall.bat

Also cleans up the double build in the msbuild's version of rebuild.cmd
install.vcxproj will build all that is needed, so no need to do a regular
build first.

12 months agoCycles: Add avxf unit tests.
Ray Molenkamp [Sat, 8 Feb 2020 23:01:28 +0000 (16:01 -0700)]
Cycles: Add avxf unit tests.

Differential Revision: https://developer.blender.org/D3706

Reviewers: brecht

12 months agoBuild_environment: Fix unwanted exports from oidn on windows.
Ray Molenkamp [Sat, 8 Feb 2020 22:32:19 +0000 (15:32 -0700)]
Build_environment: Fix unwanted exports from oidn on windows.

oidn puts dllexport on all its functions causing the
blender binary to export these symbols.

this patch fixes this unwanted behaviour.

Differential Revision: https://developer.blender.org/D6647

Reviewers: brecht , sergey

12 months agoFix Cycles error with hair and spatial splits after recent changes
Brecht Van Lommel [Sat, 8 Feb 2020 22:26:09 +0000 (23:26 +0100)]
Fix Cycles error with hair and spatial splits after recent changes

12 months agoUI: Cleanup Liquid Settings Code Style
Aaron Carlisle [Sat, 8 Feb 2020 22:19:34 +0000 (17:19 -0500)]
UI: Cleanup Liquid Settings Code Style

This makes the code more consitent with the rest of blender

The `fractions_threshold` was changed to be active than enabled which is
also more consistent. This needs to be changed in other areas also.

12 months agoBuild_environment: Fix unwanted exports from libxml on windows.
Ray Molenkamp [Sat, 8 Feb 2020 22:04:09 +0000 (15:04 -0700)]
Build_environment: Fix unwanted exports from libxml on windows.

libxml puts dllexport on all its functions causing the
blender binary to export these symbols.

this patch fixes this unwanted behaviour.

Differential Revision: https://developer.blender.org/D6646

Reviewers: brecht , sergey

12 months agoBuild_environment: Freetype 2.10.1
Ray Molenkamp [Sat, 8 Feb 2020 21:23:28 +0000 (14:23 -0700)]
Build_environment: Freetype 2.10.1

Freeetype 2.9.1 tags dllexport on most of its functions so these
are now exported from the blender binary. (Same issue as D6563
which fixed it for USD)

Issue has already been fixed upstream so a simple version bump
fixes it.

This patch bumps freetype to 2.10.1

Differential Revision: https://developer.blender.org/D6645

Reviewers: brecht , sergey

12 months agoFix Cycles embree render crash after recent refactor
Brecht Van Lommel [Sat, 8 Feb 2020 20:28:32 +0000 (21:28 +0100)]
Fix Cycles embree render crash after recent refactor

12 months agoCleanup: fix compiler warning
Brecht Van Lommel [Sat, 8 Feb 2020 19:03:55 +0000 (20:03 +0100)]
Cleanup: fix compiler warning

12 months agoBuild_environment: OSL 1.10.9 / llvm 9.0.1
Ray Molenkamp [Sat, 8 Feb 2020 20:01:31 +0000 (13:01 -0700)]
Build_environment: OSL 1.10.9 / llvm 9.0.1

OSL 1.10.9 fixes osl-bug 866 [1] which is long standing issue
on windows where paths get un-escaped and osl breaks when you
install it to for instance c:\blender-tests\new-boolean

This patch bumps osl to 1.10.9, and since osl is llvm's
only consumer, llvm/clang were bumped 9.0.1

Removed some of the patches that were no longer needed

Builds and passes all tests on windows and linux

[1] https://github.com/imageworks/OpenShadingLanguage/issues/866

Differential Revision: https://developer.blender.org/D6744

Reviewers: brecht

12 months agoMerge branch 'blender-v2.82-release'
Aaron Carlisle [Sat, 8 Feb 2020 19:00:44 +0000 (14:00 -0500)]
Merge branch 'blender-v2.82-release'

12 months agoUpdate RNA Manual References
Aaron Carlisle [Sat, 8 Feb 2020 18:58:26 +0000 (13:58 -0500)]
Update RNA Manual References

12 months agoCleanup: remove old VSE prefetching code.
Richard Antalik [Fri, 7 Feb 2020 22:49:37 +0000 (23:49 +0100)]
Cleanup: remove old VSE prefetching code.

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D6774

12 months agoMerge branch 'blender-v2.82-release'
Sebastián Barschkis [Fri, 7 Feb 2020 18:38:33 +0000 (19:38 +0100)]
Merge branch 'blender-v2.82-release'

12 months agoFluid: Fixed cache reading issue with larger resolution noise grids
Sebastián Barschkis [Fri, 7 Feb 2020 18:37:44 +0000 (19:37 +0100)]
Fluid: Fixed cache reading issue with larger resolution noise grids

Important fix that needs to go into the release. The upscaled noise cache was not read into upscaled grids.

12 months agoCode Quality Day: Comment formatting in bmesh_bevel.c
Hans Goudey [Fri, 7 Feb 2020 18:32:02 +0000 (13:32 -0500)]
Code Quality Day: Comment formatting in bmesh_bevel.c

12 months agoFix T73660: Hide envelop option for Grease Pencil weights generation
Antonio Vazquez [Fri, 7 Feb 2020 16:46:29 +0000 (17:46 +0100)]
Fix T73660: Hide envelop option for Grease Pencil weights generation

As this feature is not supported yet, it's better to hide for grease pencil.
Differential Revision: https://developer.blender.org/D6777

12 months agoremove poll for OBJECT_OT_parent_clear
Philipp Oeser [Fri, 7 Feb 2020 11:09:09 +0000 (12:09 +0100)]
remove poll for OBJECT_OT_parent_clear

This works on selected_editable_objects, so no active object mandatory.

After deletion of the active object and using slection tools such as
e.g. box select, the lack of an active object would prevent this
operator from being called without good reason.

Also cannot think of any other existing poll that would really make
sense (Editor type, ...).

ref T68975

Maniphest Tasks: T68975

Differential Revision: https://developer.blender.org/D6773

12 months agoCleanup: add extern "C"
Jacques Lucke [Fri, 7 Feb 2020 16:23:50 +0000 (17:23 +0100)]
Cleanup: add extern "C"

12 months agoBLI: add index_range method to some data structures
Jacques Lucke [Fri, 7 Feb 2020 16:23:25 +0000 (17:23 +0100)]
BLI: add index_range method to some data structures

This can be used to iterate over all indices with less code.

12 months agoCleanup: Improve usage of extern "C"
Jacques Lucke [Fri, 7 Feb 2020 16:22:11 +0000 (17:22 +0100)]
Cleanup: Improve usage of extern "C"

12 months agoCleanup: Animation, split driver evaluation into separate functions
Sybren A. Stüvel [Fri, 7 Feb 2020 13:26:26 +0000 (14:26 +0100)]
Cleanup: Animation, split driver evaluation into separate functions

No functional changes.

12 months agoCleanup: Animation, reduce indentation by reordering conditions
Sybren A. Stüvel [Fri, 7 Feb 2020 13:02:11 +0000 (14:02 +0100)]
Cleanup: Animation, reduce indentation by reordering conditions

This turns error condition checks into precondition checks, grouping the
non-error functionality together towards the bottom of the function and
error-handling functionality towards the top.

No functional changes.

12 months agoFix T73625: GPencil array offset wrong whe use Scale or Rotation
Antonio Vazquez [Fri, 7 Feb 2020 15:35:26 +0000 (16:35 +0100)]
Fix T73625: GPencil array offset wrong whe use Scale or Rotation

This is not 100% a bug but a design change. The old method used the object origin as pivot point for Scale a nd Rotation, so when you moved the stroke in edit mode, the whole array ittems where offset because the pivot point distance changed.

Now, before applying scale and rotation, the stroke is moved to object origin to keep the offset when scale or rotate, so these transformations are done in stroke local space.

12 months agoCleanup: Rename `BKE_library_idmap` file to `BKE_main_idmap`
Bastien Montagne [Fri, 7 Feb 2020 15:29:02 +0000 (16:29 +0100)]
Cleanup: Rename `BKE_library_idmap` file to `BKE_main_idmap`

Part of T72604:
> Proposal: BKE_library and BKE_main API naming: prefixes conventions

12 months agoBuild optimization: Compile glew for size rather than speed with msvc.
Ray Molenkamp [Fri, 7 Feb 2020 14:35:17 +0000 (07:35 -0700)]
Build optimization: Compile glew for size rather than speed with msvc.

Glew.obj is one of the more expensive targets we have to build clocking in
at 34.907 seconds.

The root cause [1] is the msvc inliner is not super thrilled with the
glewIsSupported supported function, this patch changes the buildflags
of extern_glew to optimize for size rather than speed.

Given glew is only in play at initalization time there will be no
performance impact.

Time to build glew.obj

Before: 34.907s
After :  1.961s

[1] https://developercommunity.visualstudio.com/content/problem/732941/slow-compilation-of-glewc-for-visual-studio-2019-x.html

Differential Revision: https://developer.blender.org/D6656

Reviewers: brecht, sergey, fclem

12 months agoCleanup: `make format`
Dalai Felinto [Fri, 7 Feb 2020 14:26:35 +0000 (15:26 +0100)]
Cleanup: `make format`

Remember to run `make format` after cleanups/renames/...

12 months agoBuildSystem/Cleanup: Fix warning behaviour regarding library dependencies
Ray Molenkamp [Fri, 7 Feb 2020 14:27:40 +0000 (07:27 -0700)]
BuildSystem/Cleanup: Fix warning behaviour regarding library dependencies

Adding USD to a lite build fails to build due to boost errors, when you turn
boost on and rebuild still boost errors, boost was silently turned off since
it was not deemed needed. Once boost was forced on, it still fails due to TBB
being off.

This patch fixes:

- The Silent disabling of boost
- Add a check that USD is is not on before doing that
- move the TBB checks to a central location rather than the individual platform files
- Add USD to the TBB checks.

Differential Revision: https://developer.blender.org/D6479

Reviewers: brecht, sybren

12 months agoMerge branch 'blender-v2.82-release'
Sebastián Barschkis [Fri, 7 Feb 2020 14:21:26 +0000 (15:21 +0100)]
Merge branch 'blender-v2.82-release'

12 months agoOpenVDB: Added missing macros in fluid wrapper file
Sebastián Barschkis [Fri, 7 Feb 2020 14:19:17 +0000 (15:19 +0100)]
OpenVDB: Added missing macros in fluid wrapper file

These were needed to compile when WITH_FLUID=1 and WITH_OPENVDB=0.

12 months agoCleanup: use of 'unsigned'
Campbell Barton [Fri, 7 Feb 2020 14:02:18 +0000 (01:02 +1100)]
Cleanup: use of 'unsigned'

- Replace 'unsigned' used on it's own with 'uint'.
- Replace 'unsigned const char' with 'const uchar'.

12 months agoCleanup: remove legacy OpenGL viewport clipping code
Campbell Barton [Fri, 7 Feb 2020 13:38:40 +0000 (00:38 +1100)]
Cleanup: remove legacy OpenGL viewport clipping code

12 months agoCodeCleanup: Remove unused studiolight algorithm
Jeroen Bakker [Fri, 7 Feb 2020 13:19:08 +0000 (14:19 +0100)]
CodeCleanup: Remove unused studiolight algorithm

Code was originally added to test a different approach to calculate the
irradiance buffer. The approach was just to slow so we never used it.

This change will remove it from the code base

12 months agoCodeCleanup: Workbench
Jeroen Bakker [Fri, 7 Feb 2020 13:14:50 +0000 (14:14 +0100)]
CodeCleanup: Workbench

Code was already hidden by a compile directive.

12 months agoCleanup: transform_convert comment and spacing
mano-wii [Fri, 7 Feb 2020 13:02:11 +0000 (10:02 -0300)]
Cleanup: transform_convert comment and spacing

12 months agoCleanup: Animation, match parameter names in declaration with implementation
Sybren A. Stüvel [Fri, 7 Feb 2020 12:56:04 +0000 (13:56 +0100)]
Cleanup: Animation, match parameter names in declaration with implementation

The implementation had more descriptive parameter names, so I copied those
to the declarations.

No functional changes.

12 months agoConstraint: Fix forced request of evaluated camera
Sergey Sharybin [Fri, 7 Feb 2020 12:52:01 +0000 (13:52 +0100)]
Constraint: Fix forced request of evaluated camera

Constraint stack similarly to modifier stack is fully operate on what
have been given to it, without requesting original or evaluated IDs.
Validness of datablocks passed to constraint stack are to be handled
on dependency graph/evaluation stream levels.

12 months agoCleanup: Tracking, use LISTBASE_FOREACH
Sergey Sharybin [Fri, 7 Feb 2020 11:51:18 +0000 (12:51 +0100)]
Cleanup: Tracking, use LISTBASE_FOREACH

Makes loops declaration shorter and cleaner.

12 months agoCleanup: Tracking, reduce scope of variables
Sergey Sharybin [Fri, 7 Feb 2020 11:20:05 +0000 (12:20 +0100)]
Cleanup: Tracking, reduce scope of variables

12 months agoCleanup: reduced indentations by returning/continuing early
Sybren A. Stüvel [Fri, 7 Feb 2020 11:58:01 +0000 (12:58 +0100)]
Cleanup: reduced indentations by returning/continuing early

No functional changes.

12 months agoCleanup: simplify Cycles primitive attribute map storage
Brecht Van Lommel [Mon, 3 Feb 2020 20:40:58 +0000 (21:40 +0100)]
Cleanup: simplify Cycles primitive attribute map storage

12 months agoCleanup: split Cycles Hair and Mesh classes, with Geometry base class
Brecht Van Lommel [Sun, 2 Feb 2020 11:04:19 +0000 (12:04 +0100)]
Cleanup: split Cycles Hair and Mesh classes, with Geometry base class

12 months agoCleanup: remove unnecessary operations in Cycles curves export
Brecht Van Lommel [Mon, 3 Feb 2020 20:21:11 +0000 (21:21 +0100)]
Cleanup: remove unnecessary operations in Cycles curves export

Clearing and computing bounds is already done elsewhere.

12 months agoCleanup: split Cycles export into smaller files
Brecht Van Lommel [Sun, 2 Feb 2020 12:09:18 +0000 (13:09 +0100)]
Cleanup: split Cycles export into smaller files

12 months agoCleanup: export particle hair as a separate Cycles object
Brecht Van Lommel [Sun, 2 Feb 2020 12:09:18 +0000 (13:09 +0100)]
Cleanup: export particle hair as a separate Cycles object