6 years agoFix T35328: Disk caches of multiple particle systems on a single object overwrite...
Sergey Sharybin [Wed, 5 Feb 2014 17:46:10 +0000 (23:46 +0600)]
Fix T35328: Disk caches of multiple particle systems on a single object overwrite each other

It was intended to work actually using particle cache's stack index
but this index might have been calculated incorrect in special case:

* With default cube scene, add particle system to the cube
* Add disk cache to the particle system
* Save file and reload it
* Add another particle system and enable disk cache

This would lead to two point caches with the same stack index of zero.
This happened because point cache indices list wasn't stored in the
.blend file so once you've reload your file blender doesn't know anything
about number or point caches used.

And what was even more confusing is that point cache indices list was
trying to be load from the file, but this failed because it wasn't in the

This commit solves the root of the issue which is ability of producing
.blend file with two point caches using the same disk cache. This is
done by making it sure that point cache indices list is stored in the
.blend file. And also made it so disabling disk cache will tag it to
recalculate stack index.

Old broken files wouldn't magically start working, but fixing them is
rather simple manually by toggling Disk Cache option.

Reviewers: lukastoenne, brecht

CC: sergof
Differential Revision:

6 years agoFix T35810: Texture faces display white in 3D view, when used as a Particle Object
Sergey Sharybin [Wed, 5 Feb 2014 17:42:11 +0000 (23:42 +0600)]
Fix T35810: Texture faces display white in 3D view, when used as a Particle Object

This in fact seems some kind of video driver limitation, because it worked fine
on windows but failed on linux here. The guess is that textures doesn't always
work on display lists, or we simply do have some wrong OGL context somewhere.

This is a workaround for until bigger viewport draw refactor is done (as Brecht
mentioned display lists are deprecated in new OGL anyway).

6 years agoFix T35247: Particle texture behaves incorrectly after changing the number of particles
Sergey Sharybin [Wed, 5 Feb 2014 17:37:19 +0000 (23:37 +0600)]
Fix T35247: Particle texture behaves incorrectly after changing the number of particles

Root of the issue goes to the order of particle initialization which does
texture evaluation (which does depend on particle coordinate) and particle
birth coordinate calculation. So basically what happened is:

* Changing number of particles re-allocated all the particles,
  which sets their coordinate to (0,0,0)
* Texture evaluation used this non-initialized coordinate
* Coordinates were calculated for particles

Reshuffled code a bit so now texture evaluation happens after particles.
coordinate calculation. Basically moved texture evaluation to particle
reset function. Reset happens after initialization anyway and it does
know particle coordinates. Also, if reset is being called without init
then it's also kind of logical to re-evaluate texture because particle
coordinates might change.

6 years agoCode cleanup: replace magic constants with more verbose bitnames
Sergey Sharybin [Wed, 5 Feb 2014 15:30:18 +0000 (21:30 +0600)]
Code cleanup: replace magic constants with more verbose bitnames

6 years agoAdd debug print to ID update tagging
Sergey Sharybin [Wed, 5 Feb 2014 10:15:58 +0000 (16:15 +0600)]
Add debug print to ID update tagging

6 years agoFix player stubs after change in compositor
Jens Verwiebe [Wed, 5 Feb 2014 17:44:48 +0000 (18:44 +0100)]
Fix player stubs after change in compositor

6 years agoBuilding elbeem without openmp failed
Campbell Barton [Wed, 5 Feb 2014 15:26:08 +0000 (02:26 +1100)]
Building elbeem without openmp failed

6 years agoFix compilation
Sergej Reich [Wed, 5 Feb 2014 15:18:46 +0000 (16:18 +0100)]
Fix compilation

6 years agoScanfill: use poly_nr as an index rather then index + 1
Campbell Barton [Wed, 5 Feb 2014 15:10:19 +0000 (02:10 +1100)]
Scanfill: use poly_nr as an index rather then index + 1

6 years agoQuiet warning
Campbell Barton [Wed, 5 Feb 2014 14:11:42 +0000 (01:11 +1100)]
Quiet warning

6 years agoFix T36769: fluid sim modifier can crash blender
Daniel Genrich [Wed, 5 Feb 2014 14:30:10 +0000 (15:30 +0100)]
Fix T36769: fluid sim modifier can crash blender

Crash only happened when the number of openmp threads were greater than the resolution.

6 years agoScanfill: avoid converting int<>intptr_t for displist indices
Campbell Barton [Wed, 5 Feb 2014 14:07:18 +0000 (01:07 +1100)]
Scanfill: avoid converting int<>intptr_t for displist indices

6 years agoScanfill: malloc arrays and zero init members
Campbell Barton [Wed, 5 Feb 2014 14:02:22 +0000 (01:02 +1100)]
Scanfill: malloc arrays and zero init members

6 years agoFix T38340 and T38473: fixed Scene pointers in Composite and Defocus nodes don't...
Lukas Tönne [Wed, 5 Feb 2014 12:51:51 +0000 (13:51 +0100)]
Fix T38340 and T38473: fixed Scene pointers in Composite and Defocus nodes don't get updated based on context.

As discussed in T38340 the solution is to use the current scene from
context whenever feasible.

Composite does not use node->id at all now, the scene which owns the
compositing node tree is retrieved from context instead.

Defocus node->id is made editable by the user. By default it is not set,
which also will make it use the contextual scene and camera info.
The node->id pointer in Defocus is **not** cleared in older blend files.
This is done for backward compatibility: the node will then behave as
before in untouched scenes.

File Output nodes also don't store scene in node->id. This is only needed
when creating a new node for initializing the file format.

Reviewers: brecht, jbakker, mdewanchand

Reviewed By: brecht

Differential Revision:

6 years agoFix T38476: incorrect hair draw type after editing particle system in edit mode.
Brecht Van Lommel [Wed, 5 Feb 2014 12:53:34 +0000 (13:53 +0100)]
Fix T38476: incorrect hair draw type after editing particle system in edit mode.

6 years agoFix T38478: pin panel, then ctrl+click to collapse others incorrectly unpinned panels.
Brecht Van Lommel [Wed, 5 Feb 2014 12:39:39 +0000 (13:39 +0100)]
Fix T38478: pin panel, then ctrl+click to collapse others incorrectly unpinned panels.

6 years agoPyAPI: mathutils.Vector.cross now works for 2d vectors (returns a float)
Campbell Barton [Wed, 5 Feb 2014 12:32:51 +0000 (23:32 +1100)]
PyAPI: mathutils.Vector.cross now works for 2d vectors (returns a float)

also fixed crash when running on large vectors (raises exception now)

6 years agoFix T38466: F12 / ctrl F12 shortcuts not showing in Render menu.
Brecht Van Lommel [Wed, 5 Feb 2014 12:32:35 +0000 (13:32 +0100)]
Fix T38466: F12 / ctrl F12 shortcuts not showing in Render menu.

This is tricking the keymap system a bit to make it match, this use_viewport
option has no effect when invoked from the info space.

6 years agoFix T38471: parenting in the outliner was possible with library linked objects.
Brecht Van Lommel [Wed, 5 Feb 2014 12:16:15 +0000 (13:16 +0100)]
Fix T38471: parenting in the outliner was possible with library linked objects.

6 years agoFix for RNA stringifying enum-flags freeing wrong pointer.
Campbell Barton [Wed, 5 Feb 2014 12:08:34 +0000 (23:08 +1100)]
Fix for RNA stringifying enum-flags freeing wrong pointer.

6 years agoCode cleanup: use bool for static methods
Campbell Barton [Wed, 5 Feb 2014 11:36:15 +0000 (22:36 +1100)]
Code cleanup: use bool for static methods

6 years agoFix for vpaint_stroke_test_start returning operator flags, not bool
Campbell Barton [Wed, 5 Feb 2014 11:18:33 +0000 (22:18 +1100)]
Fix for vpaint_stroke_test_start returning operator flags, not bool

also use bools for paint callbacks

6 years agoChange confusing check discovered while working on HCL color wheel:
Antony Riakiotakis [Wed, 5 Feb 2014 08:45:14 +0000 (10:45 +0200)]
Change confusing check discovered while working on HCL color wheel:

COLOR widgets never get created with UI_GRAD_V_ALT values. This is
intended for HSVCUBE color sliders only so reverting this to old value
before it was substituted with a define, which was -1.

There's one case where COLOR buttons get defined with a1 value different
than -1 which is in ui_def_but_rna. There the step value of the RNA
property is used. However, that meant that if step equaled to 9, which
is UI_GRAD_V_ALT value (unlikely) or if UI_GRAD_V_ALT was changed to 10
in future, or we added check for e.g. UI_GRAD_L_ALT which is 10 in HCL
branch, color widget would not get a color selection menu spawned.

6 years agoBGE: Fixing memory corruption/double free when duplicating (e.g., addObject) LibLoade...
Mitchell Stokes [Tue, 4 Feb 2014 18:54:09 +0000 (10:54 -0800)]
BGE: Fixing memory corruption/double free when duplicating (e.g., addObject) LibLoaded lights.

6 years agoAttempt to fix OSL build error on Linux with latest OSL master.
Brecht Van Lommel [Tue, 4 Feb 2014 21:48:32 +0000 (22:48 +0100)]
Attempt to fix OSL build error on Linux with latest OSL 

6 years agoCycles: bvh_cardinal_curve_intersect intro SSE optimization
Sv. Lockal [Tue, 4 Feb 2014 19:38:53 +0000 (23:38 +0400)]
Cycles: bvh_cardinal_curve_intersect intro SSE optimization

Gives 5% speedup for koro_final.blend, 10-15% for hair.blend

Reviewed By: brecht

Differential Revision:

6 years agoCode cleanup: remove scdata from ScanFillContext
Campbell Barton [Tue, 4 Feb 2014 18:39:28 +0000 (05:39 +1100)]
Code cleanup: remove scdata from ScanFillContext

6 years agoScanfill: optimize filling curves, text, masks - skip calculating holes
Campbell Barton [Tue, 4 Feb 2014 18:22:21 +0000 (05:22 +1100)]
Scanfill: optimize filling curves, text, masks - skip calculating holes

Support for tagging polygon numbers when adding scanfill data,
saves having to calculate connectivity afterwards (which can take approx half overall scanfill time for complex curves).

6 years agoScanfill: minor optimization, comment unused code, avoid vert loop
Campbell Barton [Tue, 4 Feb 2014 18:00:17 +0000 (05:00 +1100)]
Scanfill: minor optimization, comment unused code, avoid vert loop

6 years agoCorrect 3d text editing update logic
Campbell Barton [Tue, 4 Feb 2014 16:49:39 +0000 (03:49 +1100)]
Correct 3d text editing update logic

- editmode operations were converting text->nurbs twice.
- cursor and selection operations were re-tessellating text every time.

6 years agoSCons: code cleanup, shorter way to determine makesrna output directory.
Lawrence D'Oliveiro [Tue, 4 Feb 2014 18:08:17 +0000 (19:08 +0100)]
SCons: code cleanup, shorter way to determine makesrna output directory.

Reviewed By: brecht

Differential Revision:

6 years agoSCons: cleaner determination of 32-bit/64-bit builds
Lawrence D'Oliveiro [Tue, 4 Feb 2014 17:55:32 +0000 (18:55 +0100)]
SCons: cleaner determination of 32-bit/64-bit builds

Try not to be x86-centric, remove unneeded blenderdeps variable.

Reviewed By: brecht

Differential Revision:

6 years agoFix missing $BLENDER_USER_DATAFILES in command line help text.
Lawrence D'Oliveiro [Tue, 4 Feb 2014 17:49:30 +0000 (18:49 +0100)]
Fix missing $BLENDER_USER_DATAFILES in command line help text.

Reviewed By: brecht

Differential Revision:

6 years agoCorrect help: -b/--background does not take a file argument
Lawrence D'Oliveiro [Tue, 4 Feb 2014 17:38:59 +0000 (18:38 +0100)]
Correct help: -b/--background does not take a file argument

The documentation for the -b/--background option incorrectly states that it
takes a <file>, however it can run also without a file with e.g. a script.

Reviewed By: brecht

Differential Revision:

6 years agoCleanup: remove completely all-static option, just too complex to support in modern...
Bastien Montagne [Tue, 4 Feb 2014 15:51:41 +0000 (16:51 +0100)]
Cleanup: remove completely all-static option, just too complex to support in modern linuxes!

6 years agoDeb-like distro may use either jack or jack2, add support for this.
Bastien Montagne [Tue, 4 Feb 2014 15:40:15 +0000 (16:40 +0100)]
Deb-like distro may use either jack or jack2, add support for this.

6 years agoFix cycles crash with float image textures on CPU without AVX support.
Brecht Van Lommel [Tue, 4 Feb 2014 15:04:07 +0000 (16:04 +0100)]
Fix cycles crash with float image textures on CPU without AVX support.

The AVX kernel functions for reading image textures could be get used from non-AVX
kernels. These are C++ class methods and need to be marked for inlining, all other
functions are static so they don't leak into other kernels.

6 years agoFix T38427: Sculpt mode dimension changes don't Undo
Sergey Sharybin [Tue, 4 Feb 2014 13:47:17 +0000 (19:47 +0600)]
Fix T38427: Sculpt mode dimension changes don't Undo

6 years agoFix T38411: Free keyframe handles do not snap to frames when duplicating
Sergey Sharybin [Tue, 4 Feb 2014 13:12:19 +0000 (19:12 +0600)]
Fix T38411: Free keyframe handles do not snap to frames when duplicating

6 years agoNode UI: Improved layout for the Shader Mapping node, to match UI guidelines better...
Thomas Dinges [Tue, 4 Feb 2014 12:21:30 +0000 (13:21 +0100)]
Node UI: Improved layout for the Shader Mapping node, to match UI guidelines better (top -> bottom layout).

Patch by Sebastian König. Thanks!

6 years agoFix T37577: Joining two objects with different UVs destroys UVs of one object in...
Bastien Montagne [Tue, 4 Feb 2014 11:09:12 +0000 (12:09 +0100)]
Fix T37577: Joining two objects with different UVs destroys UVs of one object in some specific, reproducable, cases

MLOOPUV CDlayers had "UV Coord" default name, instead of "UVMap", when it is mandatory matching MTEXPOLY and MLOOPUV to have the same name!

6 years agoView3d: fix for roll operating on locked views, now apply to user view
Campbell Barton [Tue, 4 Feb 2014 10:44:37 +0000 (21:44 +1100)]
View3d: fix for roll operating on locked views, now apply to user view

6 years agoView3d: move lock check for orbit into a function and use for dolly too
Campbell Barton [Tue, 4 Feb 2014 10:31:52 +0000 (21:31 +1100)]
View3d: move lock check for orbit into a function and use for dolly too

6 years agoFix for view lock checks with ndof ops, was incorrectly comparing flags
Campbell Barton [Tue, 4 Feb 2014 10:04:36 +0000 (21:04 +1100)]
Fix for view lock checks with ndof ops, was incorrectly comparing flags

6 years agoFix T38440: Segmentation fault in Movie Clip Editor
Alex Babahin [Tue, 4 Feb 2014 09:16:21 +0000 (15:16 +0600)]
Fix T38440: Segmentation fault in Movie Clip Editor

Issue was caused by NULL-pointer de-reference when post-processing
the frame without putting the frame to movie cache.

Differential Revision:

6 years agoFix T38469: Strip delimiter handlers don't move strip correctly with keyboard input
Bastien Montagne [Tue, 4 Feb 2014 08:52:32 +0000 (09:52 +0100)]
Fix T38469: Strip delimiter handlers don't move strip correctly with keyboard input

Issue was in fact in strip update code when transforming, in case we move both left and right
handles the strip is handled twice in the loop, but it was always updated at the end of the
first loop only...

6 years agoFix T38472: allow orbiting locked view when they are already 'user'.
Campbell Barton [Tue, 4 Feb 2014 08:45:22 +0000 (19:45 +1100)]
Fix T38472: allow orbiting locked view when they are already 'user'.

6 years agoBlenderplayer: Fixing a memory leak.
Mitchell Stokes [Wed, 29 Jan 2014 21:39:44 +0000 (13:39 -0800)]
Blenderplayer: Fixing a memory leak.

IMB_moviecache_destruct() was not being called.

6 years agoCode cleanup: removed unnecessary #defines causing re-definition warnings
Andrea Weikert [Mon, 3 Feb 2014 20:24:42 +0000 (21:24 +0100)]
Code cleanup: removed unnecessary #defines causing re-definition warnings

Fixing warnings in own recent commit

6 years agoCode cleanup: declarations for removed functions
Campbell Barton [Mon, 3 Feb 2014 20:11:28 +0000 (07:11 +1100)]
Code cleanup: declarations for removed functions

6 years agoCycles_server also needs to link to libdl on linux
Martijn Berger [Mon, 3 Feb 2014 19:19:15 +0000 (20:19 +0100)]
Cycles_server also needs to link to libdl on linux

6 years agoCycles: small optimization for SSE 4.1 bvh intersector
Sv. Lockal [Mon, 3 Feb 2014 16:46:13 +0000 (20:46 +0400)]
Cycles: small optimization for SSE 4.1 bvh intersector

Gives 0.7% - 1.3% speedup for BMW1M-MikePan scene.

Reviewers: juicyfruit

Differential Revision:

6 years agoFix T38439: allow IOR in range [0, inf] instead of [1, inf] in Cycles.
Brecht Van Lommel [Mon, 3 Feb 2014 16:06:37 +0000 (17:06 +0100)]
Fix T38439: allow IOR in range [0, inf] instead of [1, inf] in Cycles.

The same can be achieved by flipping normals on the mesh, but it can be
convenient to do this in the shader.

6 years agoScanfill: skip checks for loose edges when they can't occur
Campbell Barton [Mon, 3 Feb 2014 15:54:19 +0000 (02:54 +1100)]
Scanfill: skip checks for loose edges when they can't occur

Only editmesh needs this, text, curves, masks - can all skip this check

6 years agoFix T38452: on OS X 10.9, now always use Lion style fullscreen.
Brecht Van Lommel [Mon, 3 Feb 2014 15:45:51 +0000 (16:45 +0100)]
Fix T38452: on OS X 10.9, now always use Lion style fullscreen.

On earlier versions there is no proper multi-monitor support, so we leave the
choice still. But for 10.9 this just interacts better with other elements like
spaces and the dock.

6 years agoCode cleanup: replace while -> for loops
Campbell Barton [Mon, 3 Feb 2014 15:23:01 +0000 (02:23 +1100)]
Code cleanup: replace while -> for loops

6 years agoBevel: remove unused assignments.
Howard Trickey [Mon, 3 Feb 2014 14:51:54 +0000 (09:51 -0500)]
Bevel: remove unused assignments.

Caught by coverity.

6 years agoFix T38424: modal number input ctrl - did not work, only ctrl numpad -.
Brecht Van Lommel [Mon, 3 Feb 2014 14:47:48 +0000 (15:47 +0100)]
Fix T38424: modal number input ctrl - did not work, only ctrl numpad -.

Since there isn't always a numpad available this should work.

6 years agoFix part of T38425: keymap editor search for "1" only showed numpad 1, not 1-key.
Brecht Van Lommel [Mon, 3 Feb 2014 14:44:24 +0000 (15:44 +0100)]
Fix part of T38425: keymap editor search for "1" only showed numpad 1, not 1-key.

6 years agoFix T38420: Segfault when curve deform modifier and cyclic dependency
Sergey Sharybin [Mon, 3 Feb 2014 13:39:49 +0000 (19:39 +0600)]
Fix T38420: Segfault when curve deform modifier and cyclic dependency

Crash was caused by missing curve_cache due to cyclic dependency.
This commit is rather a workaround, but we couldn't really guarantee
proper behavior in cases with cyclic dependency. So rather than calling
object update directly as it used to be let's don't perform curve
deform and be safe for threading instead.

6 years agoOSX: tentative set back TEST_BLENDER_EXE to Debug hardcoded for xcode case,
Jens Verwiebe [Mon, 3 Feb 2014 13:34:47 +0000 (14:34 +0100)]
OSX: tentative set back TEST_BLENDER_EXE to Debug hardcoded for xcode case,
did not found a way yet to use Configuration or run CTEST out of xcode

6 years agoFix T38450: Remove unused Children Offset option
Sergey Sharybin [Mon, 3 Feb 2014 13:33:15 +0000 (19:33 +0600)]
Fix T38450: Remove unused Children Offset option

This option was only exposed to the interface and internally
was doing basically nothing.

Removing it to prevent artists from being confused.

6 years agoCycles: enable /arch:AVX in msvc 11 and later versions for avx kernel
Sv. Lockal [Mon, 3 Feb 2014 13:22:50 +0000 (17:22 +0400)]
Cycles: enable /arch:AVX in msvc 11 and later versions for avx kernel

This enables VEX-encoding in AVX kernel for windows msvc builds and gives 5-10% speedup for different scenes.

Reviewers: juicyfruit, dingto, brecht

Reviewed By: brecht

CC: brecht
Differential Revision:

6 years agoFix T38421: Vertex Parenting & Triangle Vertex Parenting causes segfaults.
Sergey Sharybin [Mon, 3 Feb 2014 13:12:04 +0000 (19:12 +0600)]
Fix T38421: Vertex Parenting & Triangle Vertex Parenting causes segfaults.

Issue was caused by clearing dirty flags from element table in bmesh before
the data was fully ready.

This confused checks happening from threads and some threads did consider
element table is usable while other thread was still filling it in.

6 years agoAdd compatibility for older Collada files
gaiaclary [Mon, 3 Feb 2014 12:04:51 +0000 (13:04 +0100)]
Add compatibility for older Collada files

The Fix in 273 creates a backward incompatibility:
Collada files that have been created with an older Blender version
will contain the spotlight_size in Radians where Collada wants
this value to be in DEGREE.

This fix adds a check for the Blender Version that was used to create the
Collada file. If the Collada file was made by an older version of Blender
then the importer will assume that spotlight_size is specified in RADIANS.

Reviewers: campbellbarton, sauraedron

Reviewed By: sauraedron

CC: jesterking
Differential Revision:

6 years agoFix EXECUTABLE_OUTPUT_PATH binpath for OSX makefiles ( no CMAKE_BUILD_TYPE dir used...
Jens Verwiebe [Mon, 3 Feb 2014 11:57:50 +0000 (12:57 +0100)]
Fix EXECUTABLE_OUTPUT_PATH binpath for OSX makefiles ( no CMAKE_BUILD_TYPE dir used here )

6 years agoFix T38455: Blenderplayer is not working
Sergey Sharybin [Mon, 3 Feb 2014 11:24:25 +0000 (17:24 +0600)]
Fix T38455: Blenderplayer is not working

Was a regression since avg_frame_rate changes.

Didn't find reliable way to get stream duration which will
work with both FFmpeg and Libav so added some freaking black
magic to distinguish one from another.

6 years agoAdd include for FreeBSD and clang
Campbell Barton [Mon, 3 Feb 2014 11:04:23 +0000 (22:04 +1100)]
Add include for FreeBSD and clang

6 years agoFix another player stub after type change
Jens Verwiebe [Mon, 3 Feb 2014 10:55:55 +0000 (11:55 +0100)]
Fix another player stub after type change

6 years agoBGE: correct for last commit
Campbell Barton [Mon, 3 Feb 2014 10:41:00 +0000 (21:41 +1100)]
BGE: correct for last commit

6 years agoImage/Animation loading, remove user-pref extension check.
Campbell Barton [Mon, 3 Feb 2014 08:33:17 +0000 (19:33 +1100)]
Image/Animation loading, remove user-pref extension check.

don't use extension checking preference for low level loading functions,
otherwise a user preference may impact a script loading a file for example.

looked into making this an argument and passing it in, but theres no
real advantage and its simpler just to remove.

6 years agoCode cleanup: check -1 for error return explicitly
Campbell Barton [Mon, 3 Feb 2014 07:59:36 +0000 (18:59 +1100)]
Code cleanup: check -1 for error return explicitly

6 years agoCode cleanup: use bools where possible
Campbell Barton [Mon, 3 Feb 2014 07:55:59 +0000 (18:55 +1100)]
Code cleanup: use bools where possible

6 years agoFixed a possible access to null pointer reference.
Sergey Sharybin [Mon, 3 Feb 2014 07:51:26 +0000 (13:51 +0600)]
Fixed a possible access to null pointer reference.

Patch by tamerlan311 (Alex Babahin)

Reviewers: sergey

Reviewed By: sergey

Differential Revision:

6 years agoFix T38447: Deactivated hotkeys are still showing in menu
Joshua Leung [Mon, 3 Feb 2014 06:23:17 +0000 (19:23 +1300)]
Fix T38447: Deactivated hotkeys are still showing in menu

6 years agoUse bool where appropriate
Joshua Leung [Tue, 28 Jan 2014 01:41:33 +0000 (14:41 +1300)]
Use bool where appropriate

6 years agoCode cleanup: white space and cmake was broken on all platforms
Campbell Barton [Mon, 3 Feb 2014 02:55:26 +0000 (13:55 +1100)]
Code cleanup: white space and cmake was broken on all platforms

6 years agoAssure test works in all OSX buildenvironments/build-types
Jens Verwiebe [Sun, 2 Feb 2014 22:35:00 +0000 (23:35 +0100)]
Assure  test works in all OSX buildenvironments/build-types

6 years agoFix T38435: Crash when pressing MMB in walk mode
Bastien Montagne [Sun, 2 Feb 2014 19:34:23 +0000 (20:34 +0100)]
Fix T38435: Crash when pressing MMB in walk mode

Snap code may be called with a NULL region, add check about this and assume ray_start is OK in this case!

6 years agoCode cleanup / Cycles: Remove unused "curverender" variable from Object class, was...
Thomas Dinges [Sun, 2 Feb 2014 19:11:50 +0000 (20:11 +0100)]
Code cleanup / Cycles: Remove unused "curverender" variable from Object class, was never used.

6 years agoCode cleanup / Cycles: Remove encasing_ratio variable, it was already hard coded...
Thomas Dinges [Sun, 2 Feb 2014 18:52:46 +0000 (19:52 +0100)]
Code cleanup / Cycles: Remove encasing_ratio variable, it was already hard coded, so define it in the kernel only.

6 years agoAdded bevel regression test to tests.
Howard Trickey [Sun, 2 Feb 2014 18:29:08 +0000 (13:29 -0500)]
Added bevel regression test to tests.

Goes with companion files bevel_regression.blend
and just added to svn lib/tests/modeling.

Also changed the blender executable path for Apple case:
needed either 'Debug' or 'Release' in the path. I chose
'Debug', because not sure how to add otherwise. At any
rate, what was currently there didn't work at all.

6 years agoAdd "Create" tab and panel for Metaball Edit Mode
Jonathan Williamson [Sun, 2 Feb 2014 18:27:26 +0000 (12:27 -0600)]
Add "Create" tab and panel for Metaball Edit Mode

This makes the Create tab consistent in metaball editmode with other object types.

6 years agoReorder Curve "Create" tab and add "Create" tab for Surfaces
Jonathan Williamson [Sun, 2 Feb 2014 18:05:13 +0000 (12:05 -0600)]
Reorder Curve "Create" tab and add "Create" tab for Surfaces

This ensures the Create tab doesn't move and that it's available for Surface object types.

6 years agoRemove Grease Pencil panels from toolbar, has own tab
Jonathan Williamson [Sun, 2 Feb 2014 17:38:14 +0000 (11:38 -0600)]
Remove Grease Pencil panels from toolbar, has own tab

The Grease Pencil has it's own dedicated tab. It's no longer necessary to draw in a panel for each object type.

6 years agoUpdate tabs for non-mesh object types
Jonathan Williamson [Sun, 2 Feb 2014 17:31:24 +0000 (11:31 -0600)]
Update tabs for non-mesh object types

This adds appropriate tabs, panels, etc for curves, surfaces, metaballs, text, and armatures. This brings it in line with the changes in rB0972c422c3ac4ed725414baa47838f833b3f4c90

6 years agoUpdate Object Mode Toolbar Tabs
Jonathan Williamson [Sun, 2 Feb 2014 17:00:01 +0000 (11:00 -0600)]
Update Object Mode Toolbar Tabs

This updates the object mode toolbar tabs to reflect the rationale from the Edit Mode tabs.
- Rename "Basic" to "Tools"
- Put "Transform" into it's own panel within Tools
- Also rename Edit Mode "Mesh Tools" to "Tools" for consistency and shorter names
- Ensure Tools tabs are in same location between Edit and Object modes
- Remove redundant "Transform" label from Transform panel

6 years agoCode cleanup: suffix vars to make obvious they are squared
Campbell Barton [Sun, 2 Feb 2014 15:46:45 +0000 (02:46 +1100)]
Code cleanup: suffix vars to make obvious they are squared

6 years agoFix: Compile error due to missing #define for MSVC9 (VisualC++ 2008)
Andrea Weikert [Sun, 2 Feb 2014 13:37:41 +0000 (14:37 +0100)]
Fix: Compile error due to missing #define for MSVC9 (VisualC++ 2008)

Added some relevant #defines copied from extern\libmv\third_party\msinttypes to BLI_sys_types.h so they can be used in blenlib. Made smallhash.c use the BLI_sys_types.h include rather than including <stdint.h> directly

6 years agoFreestyle: Fix for iterations over 0D elements in the reversed order.
Tamito Kajiyama [Sun, 2 Feb 2014 12:59:15 +0000 (21:59 +0900)]
Freestyle: Fix for iterations over 0D elements in the reversed order.

The revision is concerned with Interface0DIterator and StrokeVertexIterator.
These iterators can be generated by Interface1D::vertices_end() and
Stroke::stroke_vertices_end(), respectively.  These methods return an
iterator poinitng the next index of the last 0D element (i.e., iterator's is_end
property is true).  When the iterators created in this way are used with
Python's iterator protocol (e.g., in a for-loop), iterations over 0D elements
are automatically performed in the reversed order.  This functionality was
broken after recent revisions concerning Freestyle iterators.

Also made minor code cleanup (white space).

6 years agoDocstring updates and code cleanup by flokkievids (Folkert de Vries).
Tamito Kajiyama [Sun, 2 Feb 2014 11:58:01 +0000 (20:58 +0900)]
Docstring updates and code cleanup by flokkievids (Folkert de Vries).

6 years agoCode cleanup (mostly indentation and white space).
Tamito Kajiyama [Sat, 1 Feb 2014 07:45:06 +0000 (16:45 +0900)]
Code cleanup (mostly indentation and white space).

6 years agoFix for iterators' at_start flag left unset in C++ to Python conversion utility funct...
Tamito Kajiyama [Sat, 1 Feb 2014 07:30:14 +0000 (16:30 +0900)]
Fix for iterators' at_start flag left unset in C++ to Python conversion utility functions.
Also changed the type of the 'reversed' flag from int to bool.

6 years agoImported D222 Diff 2 (ID 781) by flokkievids (Folkert de Vries).
Tamito Kajiyama [Fri, 31 Jan 2014 04:40:24 +0000 (13:40 +0900)]
Imported D222 Diff 2 (ID 781) by flokkievids (Folkert de Vries).

6 years agoAdd include needed for clang, quiet warning
Campbell Barton [Sun, 2 Feb 2014 10:33:52 +0000 (21:33 +1100)]
Add include needed for clang, quiet warning

6 years agoBMesh: optimize loop_find_regions, reserve array size
Campbell Barton [Sun, 2 Feb 2014 06:41:02 +0000 (17:41 +1100)]
BMesh: optimize loop_find_regions, reserve array size

6 years agoBMesh: optimize lookups for triangle fill
Campbell Barton [Sun, 2 Feb 2014 06:09:38 +0000 (17:09 +1100)]
BMesh: optimize lookups for triangle fill

6 years agoSmallhash: add reserve option to avoid resizing when size is known
Campbell Barton [Sun, 2 Feb 2014 06:08:26 +0000 (17:08 +1100)]
Smallhash: add reserve option to avoid resizing when size is known

6 years agoSmallhash: fixes/improvements
Campbell Barton [Sun, 2 Feb 2014 05:22:05 +0000 (16:22 +1100)]
Smallhash: fixes/improvements

- use magic numbers based on uintptr max, not uint max, to avoid possible collisions with real pointer values on 64bit systems.
- comment BLI_smallhash_remove for now, its not used.
- added smallhash_val_is_used replacing ELEM() checks
- updated docs

6 years agoSmallhash: optimizations
Campbell Barton [Sat, 1 Feb 2014 15:19:11 +0000 (02:19 +1100)]
Smallhash: optimizations

- remove static array used only for copying (use alloca on resize)
- set SMSTACKSIZE to one of the values in 'hashsizes' since the full available size was never used.
- ensure ~1.5x as many buckets as entries, was 3x which caused malloc's quite early on.