blender.git
9 months agoFix T60320: Cycles OpenCL volume rendering error on some drivers.
Brecht Van Lommel [Tue, 8 Jan 2019 14:50:14 +0000 (15:50 +0100)]
Fix T60320: Cycles OpenCL volume rendering error on some drivers.

9 months agoFix T60300: Cycles SSS render hanging with AMD OpenCL.
Brecht Van Lommel [Tue, 8 Jan 2019 14:35:54 +0000 (15:35 +0100)]
Fix T60300: Cycles SSS render hanging with AMD OpenCL.

9 months agoMake DNA and RNA errors more meaningful and friendly
Sergey Sharybin [Tue, 8 Jan 2019 10:43:15 +0000 (11:43 +0100)]
Make DNA and RNA errors more meaningful and friendly

9 months agoRecognize llvmpipe renderer as software OpenGL
Sergey Sharybin [Fri, 4 Jan 2019 11:41:35 +0000 (12:41 +0100)]
Recognize llvmpipe renderer as software OpenGL

9 months agoFix T60099: Inconsistent normals from spin tool
Campbell Barton [Fri, 4 Jan 2019 05:23:04 +0000 (16:23 +1100)]
Fix T60099: Inconsistent normals from spin tool

9 months agoSpin Tool: don't flip when using a negative angle
Campbell Barton [Fri, 4 Jan 2019 05:17:49 +0000 (16:17 +1100)]
Spin Tool: don't flip when using a negative angle

The intention was to flip normals when extruding in the opposite
direction, however the sign of the angle isn't meaningful unless
the geometry center and region normal are taken into account.

Disable, may add back in a way that works more predictably.

9 months agoFix eternal loop in spin tool merge first/last
Campbell Barton [Fri, 4 Jan 2019 05:08:42 +0000 (16:08 +1100)]
Fix eternal loop in spin tool merge first/last

9 months agoHaiku: build fix
Campbell Barton [Fri, 4 Jan 2019 06:04:04 +0000 (17:04 +1100)]
Haiku: build fix

D4130 by @miqlas

9 months agoCleanup: use typed unsigned ints
Campbell Barton [Fri, 4 Jan 2019 00:09:18 +0000 (11:09 +1100)]
Cleanup: use typed unsigned ints

9 months agoFix T60073: can't unlink by dragging from some node input sockets.
Brecht Van Lommel [Thu, 3 Jan 2019 17:20:30 +0000 (18:20 +0100)]
Fix T60073: can't unlink by dragging from some node input sockets.

9 months agoFix T54962: Cycles crash using subsurface scattering texture blur.
Brecht Van Lommel [Thu, 3 Jan 2019 16:08:46 +0000 (17:08 +0100)]
Fix T54962: Cycles crash using subsurface scattering texture blur.

9 months agoFix T60014: material link pref ignored
Campbell Barton [Thu, 3 Jan 2019 01:15:03 +0000 (12:15 +1100)]
Fix T60014: material link pref ignored

The PreferencesEdit.material_link only worked for adding slots,
adding an initial new material didn't respect the preference.

9 months agoFix T60061: Cycles OSL point density not working.
Brecht Van Lommel [Wed, 2 Jan 2019 18:55:26 +0000 (19:55 +0100)]
Fix T60061: Cycles OSL point density not working.

Add override keywords so we can detect when the function definitions change.

9 months agoFix (unreported) broken Cycles tests after numaapi changes today.
Bastien Montagne [Thu, 27 Dec 2018 21:38:22 +0000 (22:38 +0100)]
Fix (unreported) broken Cycles tests after numaapi changes today.

Please always build tests when messing with build system/libs, am tired
of fixing that kind of issues...

Also, that fix is probably not working for standalone, no idea where's
the numaapi lib then, but committing since I need a building blender
here (with the tests, yes).

9 months agoAPI Doc: point to blender2.7 new folder.
Bastien Montagne [Thu, 27 Dec 2018 22:02:20 +0000 (23:02 +0100)]
API Doc: point to blender2.7 new folder.

master is now for 2.8. ;)

9 months agoFix T59874: Cycles CPU 25% load only during rendering
Sergey Sharybin [Thu, 27 Dec 2018 18:01:19 +0000 (19:01 +0100)]
Fix T59874: Cycles CPU 25% load only during rendering

The issue was introduced by a Threadripper2 commit back in
ce927e15e0e3. This boils down to threads inheriting affinity
from the parent thread. It is a question how this slipped
through the review (we definitely run benchmark round).

Quick fix could have been to always set CPU group affinity
in Cycles, and it would work for Windows. On other platforms
we did not have CPU groups API finished.

Ended up making Cycles aware of NUMA topology, so now we
bound threads to a specific NUMA node. This required adding
an external dependency to Cycles, but made some code there
shorter.

9 months agoFix T59900: duplicate font loading error and memory leak.
Brecht Van Lommel [Thu, 27 Dec 2018 14:22:20 +0000 (15:22 +0100)]
Fix T59900: duplicate font loading error and memory leak.

9 months agoX11: support multiple tablet devices.
Brecht Van Lommel [Thu, 27 Dec 2018 14:22:20 +0000 (15:22 +0100)]
X11: support multiple tablet devices.

Previously we would try to guess what the main tablet device is, but this is
error prone. Now we keep a list of X11 devices and try to match events to
them. On the Blender side there are still some limitations in regards to using
multiple devices at the same time, but this should improve things already.

Fixes T59645.

9 months agoFix T56595: Hair Dynamics stop working after saving new file
Sergey Sharybin [Thu, 27 Dec 2018 10:35:31 +0000 (11:35 +0100)]
Fix T56595: Hair Dynamics stop working after saving new file

The issue was caused by NaN valid of the average spring length being
stored in the file. This caused accumulation in the springs builder
to also deliver NaNs, which then caused solver itself to not do
anything.

Not sure why these values where never initialized prior to the
accumulation. Or even, why this runime data is stored in a DNA.

Some sanitizing is possible here, but needs to be done with care
to not disrupt Spring production.

9 months agoPoint locale sub-repo to blender2.7 branch.
Bastien Montagne [Sat, 22 Dec 2018 14:10:24 +0000 (15:10 +0100)]
Point locale sub-repo to blender2.7 branch.

Since we start translating for 2.8 very soon, better to archive 2.7x
translations in their own branch. ;)

9 months agoFix T59565: NaN/crash with zero radius tip of hair curves.
Brecht Van Lommel [Fri, 21 Dec 2018 17:51:13 +0000 (18:51 +0100)]
Fix T59565: NaN/crash with zero radius tip of hair curves.

9 months agoCleanup: fix more ATTR_FALLTHROUGH warnings.
Brecht Van Lommel [Fri, 21 Dec 2018 16:23:49 +0000 (17:23 +0100)]
Cleanup: fix more ATTR_FALLTHROUGH warnings.

Ref D3960.

9 months agoCleanup: fix ATTR_FALLTHROUGH warnings.
Brecht Van Lommel [Fri, 21 Dec 2018 16:02:04 +0000 (17:02 +0100)]
Cleanup: fix ATTR_FALLTHROUGH warnings.

Ref D3960.

9 months agoUpdate .arcconfig for moving master to blender2.7 branch.
Brecht Van Lommel [Fri, 21 Dec 2018 11:12:32 +0000 (12:12 +0100)]
Update .arcconfig for moving master to blender2.7 branch.

9 months agoUpdate for moving master to blender2.7 branch.
Brecht Van Lommel [Thu, 20 Dec 2018 13:42:01 +0000 (14:42 +0100)]
Update for moving master to blender2.7 branch.

9 months agoCycles: Fixes for recent curve robustness
Sergey Sharybin [Thu, 20 Dec 2018 15:45:38 +0000 (16:45 +0100)]
Cycles: Fixes for recent curve robustness

The key indices were wrong: need to offset curve key index
by first curve key index. Also corrected calculation of the
interpolation step.

Annoyingly, can not reproduce this on a simple file, need
production rig. For the possible future look the following
file from Spring was used: 03_005_A.lighting.debug.blend

9 months agoFix T59074: BMesh intersect hangs
Campbell Barton [Thu, 20 Dec 2018 06:50:36 +0000 (17:50 +1100)]
Fix T59074: BMesh intersect hangs

This is a degenerate intersection, exit early instead of hanging.

9 months agoPyAPI: don't truncate enums in exception messages
Campbell Barton [Thu, 20 Dec 2018 01:19:42 +0000 (12:19 +1100)]
PyAPI: don't truncate enums in exception messages

Not necessary and confusing when only some of the items are displayed.

See: T59044

9 months agoBuild info: Ensure hash length is same across all platforms and has no conflicts
Sergey Sharybin [Wed, 19 Dec 2018 11:47:25 +0000 (12:47 +0100)]
Build info: Ensure hash length is same across all platforms and has no conflicts

The original issue was that different platforms will use different
hash lengths, just because defaults on Git client were different.

Now we use explicit length for the hash, and length is the same as
is used for short hashes in Linux -- apparently they started to have
collisions with length of 11.

9 months agoFix Proportional Edit Projected 2D method skiped center calculation
Philipp Oeser [Wed, 19 Dec 2018 10:46:42 +0000 (11:46 +0100)]
Fix Proportional Edit Projected 2D method skiped center calculation

rBa520e7c85c83 defined T_OVERRIDE_CENTER(1 << 25)
which was already in use T_PROP_PROJECTED(1 << 25)
thus skipping center calculation

Fixes T58882, T59518

Reviewers: campbellbarton, brecht

Maniphest Tasks: T58882, T59518

Differential Revision: https://developer.blender.org/D4100

9 months agoFix invalid string comparison
Campbell Barton [Wed, 19 Dec 2018 00:38:20 +0000 (11:38 +1100)]
Fix invalid string comparison

9 months agoCleanup: spelling
Campbell Barton [Tue, 18 Dec 2018 23:16:08 +0000 (10:16 +1100)]
Cleanup: spelling

9 months agoCleanup: use static struct for app-template state
Campbell Barton [Tue, 18 Dec 2018 23:07:30 +0000 (10:07 +1100)]
Cleanup: use static struct for app-template state

9 months agoFix T59104: Snapping: Align rotation to target broken in edit mode.
Bastien Montagne [Tue, 18 Dec 2018 19:27:50 +0000 (20:27 +0100)]
Fix T59104: Snapping: Align rotation to target broken in edit mode.

This has been unbelievably painful to understand... And solution is only
partially good actually, we may even want a single axis for all the
islands in that case? But for now this is giving much better results
already, compared to the random crazyness it used to produce.

9 months agoFix T55105: Smoke Emission from particles was ignoring lattice deformer
Philipp Oeser [Tue, 22 May 2018 07:25:23 +0000 (09:25 +0200)]
Fix T55105: Smoke Emission from particles was ignoring lattice deformer
on the particles

10 months agoCleanup: use 'tool_settings' name everywhere in UI scripts
Campbell Barton [Mon, 17 Dec 2018 06:20:24 +0000 (17:20 +1100)]
Cleanup: use 'tool_settings' name everywhere in UI scripts

10 months agoCleanup: use bit-shifted flag definitions in DNA
Campbell Barton [Sun, 16 Dec 2018 22:55:02 +0000 (09:55 +1100)]
Cleanup: use bit-shifted flag definitions in DNA

10 months agoDependencies builder: Don't rely on system-wide PugiXML
Sergey Sharybin [Fri, 14 Dec 2018 16:39:38 +0000 (17:39 +0100)]
Dependencies builder: Don't rely on system-wide PugiXML

10 months agoCMake: Fixes for OpenGL library preferences
Sergey Sharybin [Fri, 14 Dec 2018 13:48:05 +0000 (14:48 +0100)]
CMake: Fixes for OpenGL library preferences

Prefer legacy OpenGL library, for the compatibility and portability
reasons.

Also use proper OpenGL libraries to be linked against, so we can
change preference to GLVND.

10 months agoFix selection history clearing when selecting all
Campbell Barton [Fri, 14 Dec 2018 00:38:02 +0000 (11:38 +1100)]
Fix selection history clearing when selecting all

10 months agoMissed last commit
Campbell Barton [Fri, 14 Dec 2018 00:14:57 +0000 (11:14 +1100)]
Missed last commit

10 months agoMissed last commit
Campbell Barton [Fri, 14 Dec 2018 00:01:01 +0000 (11:01 +1100)]
Missed last commit

10 months agoCleanup: naming (mean -> median) see T47811
Campbell Barton [Thu, 13 Dec 2018 23:54:11 +0000 (10:54 +1100)]
Cleanup: naming (mean -> median) see T47811

10 months agoFix typo in context docs.
Campbell Barton [Thu, 13 Dec 2018 21:13:55 +0000 (08:13 +1100)]
Fix typo in context docs.

10 months agodeps: add missing sqlite dll to windows build.
Ray Molenkamp [Thu, 13 Dec 2018 13:59:37 +0000 (06:59 -0700)]
deps: add missing sqlite dll to windows build.

10 months agoCycles: Update standalone app to OIIO 2.0
Sergey Sharybin [Thu, 13 Dec 2018 13:31:38 +0000 (14:31 +0100)]
Cycles: Update standalone app to OIIO 2.0

10 months agoFix T59213: Application menu links to outdated version of Python API.
Bastien Montagne [Wed, 12 Dec 2018 10:55:40 +0000 (11:55 +0100)]
Fix T59213: Application menu links to outdated version of Python API.

Somehow those links were forgotten when we renamed API doc to simpler
names last year...

10 months agoCleanup: use colon separator after parameter
Campbell Barton [Wed, 12 Dec 2018 01:50:58 +0000 (12:50 +1100)]
Cleanup: use colon separator after parameter

Helps separate variable names from descriptive text.
Was already used in some parts of the code,
double space and dashes were used elsewhere.

10 months agodependencies windows: Replace pthreads-win32 2.9.1 with pthreads4w 3.0.0
Ray Molenkamp [Tue, 11 Dec 2018 22:12:56 +0000 (15:12 -0700)]
dependencies windows: Replace pthreads-win32 2.9.1 with pthreads4w 3.0.0

maintenance seems to have stopped for pthreads-win32

10 months agoUpdate code to be compatible with OIIO 2.0
Sergey Sharybin [Tue, 11 Dec 2018 11:17:26 +0000 (12:17 +0100)]
Update code to be compatible with OIIO 2.0

There are some changes in API of OpenImageIO, but those are quite
simple to keep working with older and newer library versions.

Reviewers: brecht

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D4064

10 months agoCleanup: remove accidentally committed debug code.
Brecht Van Lommel [Tue, 11 Dec 2018 14:18:01 +0000 (15:18 +0100)]
Cleanup: remove accidentally committed debug code.

10 months agoCycles: Add strict assert when assigning input socket stack offset
Sergey Sharybin [Tue, 11 Dec 2018 13:34:28 +0000 (14:34 +0100)]
Cycles: Add strict assert when assigning input socket stack offset

10 months agoCycles: Remove old nasty workaround
Sergey Sharybin [Tue, 11 Dec 2018 13:33:24 +0000 (14:33 +0100)]
Cycles: Remove old nasty workaround

It used to be used for some sort of ignoring automatically
generated bump nodes. But nowadays it causes one of the shaders
in Classroom demo file to be compiled wrong.

10 months agoFix macOS buildbot build, wrong CUDA version check.
Brecht Van Lommel [Tue, 11 Dec 2018 13:14:52 +0000 (14:14 +0100)]
Fix macOS buildbot build, wrong CUDA version check.

10 months agoCycles: Cleanup, indentation
Sergey Sharybin [Tue, 11 Dec 2018 11:57:57 +0000 (12:57 +0100)]
Cycles: Cleanup, indentation

10 months agoFix T59161: Edge Rotate CW is CCW
Campbell Barton [Tue, 11 Dec 2018 03:03:42 +0000 (14:03 +1100)]
Fix T59161: Edge Rotate CW is CCW

10 months agoFix T52051: Orthographic camera display size error
Campbell Barton [Tue, 11 Dec 2018 02:02:39 +0000 (13:02 +1100)]
Fix T52051: Orthographic camera display size error

It was impractical to create a small orthographic camera with a usable
size in the view-port.

No longer scale the draw-size by ortho-size.

10 months agoFix T53544: Undo in pose mode selects all fcurves
Campbell Barton [Mon, 10 Dec 2018 01:30:41 +0000 (12:30 +1100)]
Fix T53544: Undo in pose mode selects all fcurves

10 months agoDNA: add runtime struct to for graph & action editor
Campbell Barton [Mon, 10 Dec 2018 00:46:36 +0000 (11:46 +1100)]
DNA: add runtime struct to for graph & action editor

Move struct members, no functional change

10 months agoFix T59059: Blender crashing after adding particle system and dynamic paint (Brush).
Bastien Montagne [Sun, 9 Dec 2018 20:48:37 +0000 (21:48 +0100)]
Fix T59059: Blender crashing after adding particle system and dynamic paint (Brush).

Looks like this bug has been there since ages (at least present before
2.79 official release...).

10 months agoFix T57994: Particle Instance modifiers 'Index Layer' off by one
Philipp Oeser [Thu, 22 Nov 2018 10:52:38 +0000 (11:52 +0100)]
Fix T57994: Particle Instance modifiers 'Index Layer' off by one

better have this vertex color layer cover the whole 0-1 range

thx @sergey for checking

Maniphest Tasks: T57994

Differential Revision: https://developer.blender.org/D3976

10 months agoCycles: Do more user-friendly indication that GPU devices are not found
Sergey Sharybin [Fri, 7 Dec 2018 13:47:35 +0000 (14:47 +0100)]
Cycles: Do more user-friendly indication that GPU devices are not found

10 months agoCycles: Disable OpenCL on macOS
Sergey Sharybin [Fri, 7 Dec 2018 13:37:47 +0000 (14:37 +0100)]
Cycles: Disable OpenCL on macOS

This is unfortunate, but the number of bugs in this configuration
keeps growing, and almost all of them are caused by bug in OpenCL
compiler.

The compiler is not likely to be fixed, since Apple declared OpenCL
deprecated.

This evil commit is aimed to keep officially supported features
of Blender in a good working and stable state.

10 months agoCleanup: redundant counter
Campbell Barton [Fri, 7 Dec 2018 06:06:21 +0000 (17:06 +1100)]
Cleanup: redundant counter

10 months agoFix error in Main cleanup
Campbell Barton [Fri, 7 Dec 2018 04:40:38 +0000 (15:40 +1100)]
Fix error in Main cleanup

See 481cdb08ed6f3

10 months agoFix Alembic indexed UVs being merged for different vertices.
Brecht Van Lommel [Thu, 6 Dec 2018 23:02:56 +0000 (00:02 +0100)]
Fix Alembic indexed UVs being merged for different vertices.

Other software uses this to define UV islands, so we can't just merge
any UVs with the same coordinate. They have to share a vertex too.

Contributed by Maxime Robinot, with changes by me.

Differential Revision: https://developer.blender.org/D4006

10 months agoFix T57963: Cycles crash using AO for displacement.
Brecht Van Lommel [Thu, 6 Dec 2018 18:50:05 +0000 (19:50 +0100)]
Fix T57963: Cycles crash using AO for displacement.

Note this is not supported, there exists no geometry at this point, but
it should not crash at least.

10 months agoFix T58832: Spin tool creates duplicate faces
Campbell Barton [Thu, 6 Dec 2018 03:50:25 +0000 (14:50 +1100)]
Fix T58832: Spin tool creates duplicate faces

10 months agoFix T58819: Weight paint gradient crash
Campbell Barton [Thu, 6 Dec 2018 00:19:18 +0000 (11:19 +1100)]
Fix T58819: Weight paint gradient crash

10 months agoCleanup: no need to access final mesh
Campbell Barton [Wed, 5 Dec 2018 21:36:36 +0000 (08:36 +1100)]
Cleanup: no need to access final mesh

10 months agoFix (devtalk 4053): Collada build with older cmake versions broken
Gaia Clary [Wed, 5 Dec 2018 21:04:10 +0000 (22:04 +0100)]
Fix (devtalk 4053): Collada build with older cmake versions broken

10 months agofix: Collada: remove Class from method definition in header file
Gaia Clary [Wed, 5 Dec 2018 19:28:06 +0000 (20:28 +0100)]
fix: Collada: remove Class from method definition in header file

10 months agodeps: update opencollada to v1.6.68
Ray Molenkamp [Wed, 5 Dec 2018 15:44:19 +0000 (08:44 -0700)]
deps: update opencollada to v1.6.68

10 months agoFix (unreported) building Cycles tests with Embree enabled.
Bastien Montagne [Wed, 5 Dec 2018 14:14:16 +0000 (15:14 +0100)]
Fix (unreported) building Cycles tests with Embree enabled.

10 months agoFix T58776, T58030: pressure sensitivity on Linux not working for some tablets.
Brecht Van Lommel [Wed, 5 Dec 2018 12:58:38 +0000 (13:58 +0100)]
Fix T58776, T58030: pressure sensitivity on Linux not working for some tablets.

10 months agoInstall_deps: bump collada version to 1.6.68.
Bastien Montagne [Wed, 5 Dec 2018 12:52:39 +0000 (13:52 +0100)]
Install_deps: bump collada version to 1.6.68.

10 months agoFix build with old CMake versions.
Brecht Van Lommel [Wed, 5 Dec 2018 11:53:08 +0000 (12:53 +0100)]
Fix build with old CMake versions.

10 months agoFix T49624: Fly uses camera settings outside camera view
Campbell Barton [Tue, 4 Dec 2018 21:36:37 +0000 (08:36 +1100)]
Fix T49624: Fly uses camera settings outside camera view

10 months agofix T58568: used wrong case in variable name
Gaia Clary [Tue, 4 Dec 2018 19:28:20 +0000 (20:28 +0100)]
fix T58568: used wrong case in variable name

10 months agofix T58568 build errors when using collada 1.6.68 or newer
Gaia Clary [Tue, 4 Dec 2018 18:11:33 +0000 (19:11 +0100)]
fix T58568 build errors when using collada 1.6.68 or newer

10 months agoFix T58466: bug in macOS GHOST_GetSwapInterval.
Niels [Tue, 4 Dec 2018 17:40:09 +0000 (18:40 +0100)]
Fix T58466: bug in macOS GHOST_GetSwapInterval.

No user level changes since this function is not used in active code.

10 months agoBuildbot: enable support for NVIDIA Turing cards in Cycles (like GTX 20xx).
Brecht Van Lommel [Tue, 4 Dec 2018 10:49:57 +0000 (11:49 +0100)]
Buildbot: enable support for NVIDIA Turing cards in Cycles (like GTX 20xx).

We currently only build the sm_7x kernels with CUDA 10.0, older cards still
use 9.1 until rendering errors are solved for them.

10 months agoCycles: add initial CUDA 10.0 support, but only recommend use for Turing cards.
Brecht Van Lommel [Tue, 4 Dec 2018 11:34:59 +0000 (12:34 +0100)]
Cycles: add initial CUDA 10.0 support, but only recommend use for Turing cards.

There may still be rendering errors when used for older graphics cards.

10 months agoCleanup: Spelling
Sergey Sharybin [Tue, 4 Dec 2018 10:43:53 +0000 (11:43 +0100)]
Cleanup: Spelling

10 months agoFix T58600: update OSL scripts to work with OSL 1.10.x.
Shane Ambler [Mon, 3 Dec 2018 11:16:30 +0000 (12:16 +0100)]
Fix T58600: update OSL scripts to work with OSL 1.10.x.

10 months agoFix T54580: Pointer buttons skip undo push
Campbell Barton [Mon, 3 Dec 2018 07:43:33 +0000 (18:43 +1100)]
Fix T54580: Pointer buttons skip undo push

10 months agoUse scene active object for sculptmode enter/exit calls
Campbell Barton [Mon, 3 Dec 2018 07:00:20 +0000 (18:00 +1100)]
Use scene active object for sculptmode enter/exit calls

Match logic in previous commit.

10 months agoFix T56331: Undo crash w/ sculpt on hidden layer
Campbell Barton [Mon, 3 Dec 2018 06:42:26 +0000 (17:42 +1100)]
Fix T56331: Undo crash w/ sculpt on hidden layer

10 months agoCleanup: BKE b-bone API naming
Campbell Barton [Sun, 2 Dec 2018 03:29:54 +0000 (14:29 +1100)]
Cleanup: BKE b-bone API naming

Use BKE_pchan_bbone prefix.

10 months agoCleanup: BKE_effect.h naming
Campbell Barton [Sun, 2 Dec 2018 03:14:51 +0000 (14:14 +1100)]
Cleanup: BKE_effect.h naming

10 months agoCleanup: style
Campbell Barton [Fri, 30 Nov 2018 21:15:25 +0000 (08:15 +1100)]
Cleanup: style

10 months agoFix T58275: WITH_OPENSUBDIV not enabled by default with some CMake versions.
Brecht Van Lommel [Fri, 30 Nov 2018 10:50:23 +0000 (11:50 +0100)]
Fix T58275: WITH_OPENSUBDIV not enabled by default with some CMake versions.

Solution provided by Ulysse Martin.

10 months agoRevert "3D View: locked camera was using the original view offset"
Campbell Barton [Fri, 30 Nov 2018 08:01:03 +0000 (19:01 +1100)]
Revert "3D View: locked camera was using the original view offset"

This reverts commit 3f31c28a025cf61e2c4df33f28467771ae603965.

Gives issues zooming, could be resolved but it mostly worked OK before,
and it's not a priority to spend time on, so leave as is for now.

10 months ago3D View: locked camera was using the original view offset
Campbell Barton [Fri, 30 Nov 2018 07:11:04 +0000 (18:11 +1100)]
3D View: locked camera was using the original view offset

Now used the original dist instead, since using the distance between
the camera and the views offset may seem random from the users POV.

This addresses strange behavior noticed in T56934.

10 months agoCorrect missing semicolon in recent commit
Campbell Barton [Fri, 30 Nov 2018 06:07:13 +0000 (17:07 +1100)]
Correct missing semicolon in recent commit

10 months agoCleanup: ensure '_END' macros end with a semicolon
Campbell Barton [Fri, 30 Nov 2018 04:35:15 +0000 (15:35 +1100)]
Cleanup: ensure '_END' macros end with a semicolon

Missing these breaks auto-indent for editors that don't expand macros.

10 months agoCleanup: name macros w/ matching BEGIN/END
Campbell Barton [Fri, 30 Nov 2018 04:22:01 +0000 (15:22 +1100)]
Cleanup: name macros w/ matching BEGIN/END

10 months agoCleanup: name macros w/ matching BEGIN/END
Campbell Barton [Fri, 30 Nov 2018 04:08:47 +0000 (15:08 +1100)]
Cleanup: name macros w/ matching BEGIN/END

10 months agoCleanup: duplicate include
Campbell Barton [Fri, 30 Nov 2018 03:21:28 +0000 (14:21 +1100)]
Cleanup: duplicate include

10 months agoCleanup: style
Campbell Barton [Fri, 30 Nov 2018 03:20:41 +0000 (14:20 +1100)]
Cleanup: style