blender.git
21 months agoFix T58117: Crash with keyframing
Sergey Sharybin [Tue, 4 Dec 2018 10:28:23 +0000 (11:28 +0100)]
Fix T58117: Crash with keyframing

21 months agoFix T58220: EdgeSplit at Split Angle: 0 doesn't split flat faces.
Bastien Montagne [Tue, 4 Dec 2018 09:48:48 +0000 (10:48 +0100)]
Fix T58220: EdgeSplit at Split Angle: 0 doesn't split flat faces.

Add special handling for both edge cases (:p):
* 180° is same as no splitting by angle;
* 0° is same as split on all edges unconditionnaly.

In both cases we can also avoid computing poly normals.

21 months agoFix T58481: "Make duplicates real" operator settings crashes
Sergey Sharybin [Tue, 4 Dec 2018 09:18:21 +0000 (10:18 +0100)]
Fix T58481: "Make duplicates real" operator settings crashes

21 months agoFix error reloading scripts
Campbell Barton [Tue, 4 Dec 2018 06:54:31 +0000 (17:54 +1100)]
Fix error reloading scripts

Operator.is_registered needs to use RNAMeta class.

21 months agoCleanup: remove unused brush set by index
Campbell Barton [Tue, 4 Dec 2018 06:33:47 +0000 (17:33 +1100)]
Cleanup: remove unused brush set by index

21 months agoShow tool title for favorites menu
Philipp Oeser [Tue, 4 Dec 2018 05:14:21 +0000 (16:14 +1100)]
Show tool title for favorites menu

21 months agoFix T57076: Remove property from favourites menu fails
Campbell Barton [Tue, 4 Dec 2018 04:11:26 +0000 (15:11 +1100)]
Fix T57076: Remove property from favourites menu fails

21 months agoEdit last commit
Campbell Barton [Tue, 4 Dec 2018 03:29:23 +0000 (14:29 +1100)]
Edit last commit

Split out ensure-tool check into its own function.

21 months agoFix T58256: error message w/ missing Select Box tool
Campbell Barton [Tue, 4 Dec 2018 02:34:11 +0000 (13:34 +1100)]
Fix T58256: error message w/ missing Select Box tool

Support space modes not having tools.

21 months agoFix T58670: Spin tool crashes w/o gizmo overlay
Campbell Barton [Tue, 4 Dec 2018 02:00:10 +0000 (13:00 +1100)]
Fix T58670: Spin tool crashes w/o gizmo overlay

21 months agoCleanup: unused args
Campbell Barton [Mon, 3 Dec 2018 23:39:03 +0000 (10:39 +1100)]
Cleanup: unused args

21 months agoFix T58474: Gizmo Operator template fails on rerun
Campbell Barton [Mon, 3 Dec 2018 23:15:02 +0000 (10:15 +1100)]
Fix T58474: Gizmo Operator template fails on rerun

21 months agoGP: Draw Mode: Add Arc Primitive
Charlie Jolly [Mon, 3 Dec 2018 14:55:57 +0000 (14:55 +0000)]
GP: Draw Mode: Add Arc Primitive

This adds an elliptical arc primitive.
Press CKEY for toggling closed/open arc.
Press FKEY key for flipping arc.

Additional changes to gpencil primitives.
Increases default edges of circle to 64.
Keymap changes to allow primitives to be drawn with Shift or Alt key.
Allow Plus/Minus key to adjust number of edges.

Missing: Toolbar icon

Differential Revision: https://developer.blender.org/D4024

21 months agoFix T58636: repeat image in UV editor not working.
Brecht Van Lommel [Mon, 3 Dec 2018 19:06:10 +0000 (20:06 +0100)]
Fix T58636: repeat image in UV editor not working.

A little too much code got removed in fb24813.

21 months agoFix T58635: 2.8 - "3D Markers to Mesh" error.
Bastien Montagne [Mon, 3 Dec 2018 19:06:35 +0000 (20:06 +0100)]
Fix T58635: 2.8 - "3D Markers to Mesh" error.

21 months agoDepsgraph: immediately free object's derived caches in the COW step.
Alexander Gavrilov [Mon, 3 Dec 2018 17:48:36 +0000 (20:48 +0300)]
Depsgraph: immediately free object's derived caches in the COW step.

After update of the mesh some of that data is so broken that using
it would crash. To reduce the risk of crashes in case of dependency
cycles, clean it up immediately.

21 months agoFix T58448: Cloth presets fails to load due to missing attribute structural_stiffness.
Bastien Montagne [Mon, 3 Dec 2018 16:45:17 +0000 (17:45 +0100)]
Fix T58448: Cloth presets fails to load due to missing attribute structural_stiffness.

Presets were not updated when parameter were changed in rBe3d31b8dfbdc.

Note that will also check on generating more resistent py code for that
kind of presets, since that will also affect any custom preset made by
users...

21 months agoFix T58280: Blender 2.8 hangs when the LookDev mode is enabled
Clément Foucault [Mon, 3 Dec 2018 16:19:04 +0000 (17:19 +0100)]
Fix T58280: Blender 2.8 hangs when the LookDev mode is enabled

The hang was due to the nodes being "evaluated" for every incomming link.

Solution: only evaluate once per nodetree.

Also merge the tagging of SSS and SSR into one traversal only.

21 months agoDRW: Make default debug mode a bit more silent
Clément Foucault [Mon, 3 Dec 2018 14:24:21 +0000 (15:24 +0100)]
DRW: Make default debug mode a bit more silent

Use --debug-gpu for debugging non found uniforms

21 months agoWorkbench: Encode Roughness and metallic into 8bits
Clément Foucault [Mon, 3 Dec 2018 13:51:30 +0000 (14:51 +0100)]
Workbench: Encode Roughness and metallic into 8bits

This reduces the bandwidth + vram usage of workbench even further.

21 months agoWorkbench: Make object ID pass optionnal
Clément Foucault [Mon, 3 Dec 2018 01:42:23 +0000 (02:42 +0100)]
Workbench: Make object ID pass optionnal

We separate the background and foreground shading passes to be able to make
the object id pass optionnal if we don't need it.

This saves a bit more memory. Also not clearing all rendertargets saves
some GPU time too.

21 months agoDRW: Make fullscreen quad in the background
Clément Foucault [Mon, 3 Dec 2018 01:36:13 +0000 (02:36 +0100)]
DRW: Make fullscreen quad in the background

This is to be able to only draw the background pixels by using a depth
test EQUAL.

21 months agoWorkbench: Cleanup: Remove Spherical harmonic evaluation
Clément Foucault [Mon, 3 Dec 2018 01:33:27 +0000 (02:33 +0100)]
Workbench: Cleanup: Remove Spherical harmonic evaluation

It is not used anymore

21 months agoView3D: Grid: Don't make the Zaxis produce any fragment is not needed
Clément Foucault [Sun, 2 Dec 2018 23:38:29 +0000 (00:38 +0100)]
View3D: Grid: Don't make the Zaxis produce any fragment is not needed

This was a bug that was making the grid drawing even more slower than it
is.

21 months agoWorkbench: Reduce VRAM usage depending on mode
Clément Foucault [Sun, 2 Dec 2018 23:36:54 +0000 (00:36 +0100)]
Workbench: Reduce VRAM usage depending on mode

We exploit the fact that we are using the metallic workflow for material
and pass the metallic parameter instead of the specular color.

Pack the front facing bit in the color buffer only for matcap display.

Change buffer formats to use less bytes as possible.

Also don't request buffers that we won't use.

Saved 40MB on 2K screen on StudioLight + Shadows + Specular Lighting.

Includes several cleanups.

21 months agoSubdiv: Set edge render flags according to Optimal Display
Sergey Sharybin [Mon, 3 Dec 2018 15:59:11 +0000 (16:59 +0100)]
Subdiv: Set edge render flags according to Optimal Display

This is a part of T58609, but work is still needed to properly
support this flag in the draw manager.

21 months agoDepsgraph: completely move customdata_mask to the ID node.
Alexander Gavrilov [Mon, 3 Dec 2018 15:09:45 +0000 (18:09 +0300)]
Depsgraph: completely move customdata_mask to the ID node.

Move all mask-related fields from Object and OperationDepsNode
to Object_Runtime and IDDepsNode. Auto-apply DEG_TAG_GEOMETRY
if the mask changes after DEG rebuild. Update DEG API and all
code that uses it.

This fixes "source mesh data is not ready" errors from Data
Transfer modifier when parameters are changed in the UI after
the recent mesh_get_eval_final fix.

Reviewers: sergey

Differential Revision: https://developer.blender.org/D4025

21 months agoT58338 Edit Mode rotation doesn't work if object is far away from world origin
Antonioya [Mon, 3 Dec 2018 15:26:31 +0000 (16:26 +0100)]
T58338 Edit Mode rotation doesn't work if object is far away from world origin

The fix code was done by Brecht Van Lommel, I only tested that the solution works.

21 months agoFix T57858: Add validation callback to CustomData layers.
Bastien Montagne [Mon, 3 Dec 2018 15:19:08 +0000 (16:19 +0100)]
Fix T57858: Add validation callback to CustomData layers.

Our mesh validation was only checking cd layout so far, not their actual
data. While this might only be needed for a few types, this is a
required addition for things like imported UVs, else we have no way to
avoid nasty things like NANs & co.

Note that more layer types may need that callback, time will say. For
now added it to some obvious missing cases...

21 months agoCleanup: Use BLI's is_finite_v helpers instead of manualy checking each item.
Bastien Montagne [Mon, 3 Dec 2018 13:42:22 +0000 (14:42 +0100)]
Cleanup: Use BLI's is_finite_v helpers instead of manualy checking each item.

21 months agoDepsgraph: Add missing cache file handling in build_id()
Sergey Sharybin [Mon, 3 Dec 2018 15:05:17 +0000 (16:05 +0100)]
Depsgraph: Add missing cache file handling in build_id()

21 months agoData Transfer Modifier: fix mesh_get_eval_final usage.
Alexander Gavrilov [Mon, 3 Dec 2018 13:56:11 +0000 (16:56 +0300)]
Data Transfer Modifier: fix mesh_get_eval_final usage.

It can't be used during modifier evaluation, and rna
enum code should access the evaluated objects.

21 months agoDepsgraph: assert that mesh_get_eval_final/deform aren't used in eval.
Alexander Gavrilov [Mon, 3 Dec 2018 12:22:19 +0000 (15:22 +0300)]
Depsgraph: assert that mesh_get_eval_final/deform aren't used in eval.

Using those functions during multithreaded evaluation is a sure
way to have a race condition and crash.

21 months agoFix T58258: Select Objects in Collection not working
Philipp Oeser [Mon, 3 Dec 2018 11:55:12 +0000 (12:55 +0100)]
Fix T58258: Select Objects in Collection not working

Maniphest Tasks: T58258

Differential Revision: https://developer.blender.org/D4023

21 months ago3D View: remove non tool-system ruler
Campbell Barton [Mon, 3 Dec 2018 10:20:05 +0000 (21:20 +1100)]
3D View: remove non tool-system ruler

There was duplicate code for the ruler being accessed
as a tool and an operator.

Remove the modal operator code in favor of tool access.

21 months agoFix T58556: Some remaining 'dupli_types' in pycode after renaming.
Bastien Montagne [Mon, 3 Dec 2018 09:38:46 +0000 (10:38 +0100)]
Fix T58556: Some remaining 'dupli_types' in pycode after renaming.

21 months agoFix T58594: Modal circle select can't select & de-select
Campbell Barton [Mon, 3 Dec 2018 08:29:06 +0000 (19:29 +1100)]
Fix T58594: Modal circle select can't select & de-select

21 months agoMerge branch 'master' into blender2.8
Campbell Barton [Mon, 3 Dec 2018 08:31:54 +0000 (19:31 +1100)]
Merge branch 'master' into blender2.8

21 months agoFix T58535 Crash on Load
Antonioya [Mon, 3 Dec 2018 08:12:29 +0000 (09:12 +0100)]
Fix T58535 Crash on Load

The particles was not ready when the drawing cache try to use it.

21 months agoFix T54580: Pointer buttons skip undo push
Campbell Barton [Mon, 3 Dec 2018 07:43:33 +0000 (18:43 +1100)]
Fix T54580: Pointer buttons skip undo push

21 months agoMerge branch 'master' into blender2.8
Campbell Barton [Mon, 3 Dec 2018 07:01:19 +0000 (18:01 +1100)]
Merge branch 'master' into blender2.8

21 months agoUse scene active object for sculptmode enter/exit calls
Campbell Barton [Mon, 3 Dec 2018 07:00:20 +0000 (18:00 +1100)]
Use scene active object for sculptmode enter/exit calls

Match logic in previous commit.

21 months agoFix T56331: Undo crash w/ sculpt on hidden layer
Campbell Barton [Mon, 3 Dec 2018 06:42:26 +0000 (17:42 +1100)]
Fix T56331: Undo crash w/ sculpt on hidden layer

21 months agoFix T56642: 3D view gizmo orientation wont update
Campbell Barton [Mon, 3 Dec 2018 05:52:21 +0000 (16:52 +1100)]
Fix T56642: 3D view gizmo orientation wont update

21 months agoCleanup: warning, style
Campbell Barton [Mon, 3 Dec 2018 05:50:50 +0000 (16:50 +1100)]
Cleanup: warning, style

21 months agoFix T58528: Assign material skips non-active
Campbell Barton [Mon, 3 Dec 2018 04:26:25 +0000 (15:26 +1100)]
Fix T58528: Assign material skips non-active

21 months agoFix/workaround T58368: Crash w/ mapped mesh + autosmooth
Campbell Barton [Mon, 3 Dec 2018 03:58:29 +0000 (14:58 +1100)]
Fix/workaround T58368: Crash w/ mapped mesh + autosmooth

21 months agoCleanup: remove flag from GizmoCommonData
Campbell Barton [Mon, 3 Dec 2018 02:01:04 +0000 (13:01 +1100)]
Cleanup: remove flag from GizmoCommonData

Use struct member instead,
there are already many gizmo flags to keep track of.

21 months agoFix T58573: Camera lens gizmo error on click
Campbell Barton [Mon, 3 Dec 2018 01:55:55 +0000 (12:55 +1100)]
Fix T58573: Camera lens gizmo error on click

21 months agoFix camera lens gizmo sensor comparison
Campbell Barton [Mon, 3 Dec 2018 00:26:03 +0000 (11:26 +1100)]
Fix camera lens gizmo sensor comparison

21 months agoFix T58566: Blender 2.7x keymap not correct for select all toggle and spacebar.
Brecht Van Lommel [Sun, 2 Dec 2018 23:38:40 +0000 (00:38 +0100)]
Fix T58566: Blender 2.7x keymap not correct for select all toggle and spacebar.

21 months agoFix T56996: MacOS: Lagging when rotating the view
Clément Foucault [Sun, 2 Dec 2018 21:33:31 +0000 (22:33 +0100)]
Fix T56996: MacOS: Lagging when rotating the view

It happens on multiple configuration so we cannot isolate the fix to only
some config.

Thanks Hugo Lamarche for helping finding the fix.

21 months agoFix T58101 : Image empties are only rendering their border when using MSAA
Clément Foucault [Sun, 2 Dec 2018 19:11:23 +0000 (20:11 +0100)]
Fix T58101 : Image empties are only rendering their border when using MSAA

21 months agoTexture Paint: fix fast selection update to also work without modifiers.
Alexander Gavrilov [Sun, 2 Dec 2018 16:59:57 +0000 (19:59 +0300)]
Texture Paint: fix fast selection update to also work without modifiers.

If there are no (non-deform) modifiers, the evaluated mesh simply
shares arrays with the base COW copy instead of having CD_ORIGINDEX.

21 months agoGP: Fix line primitive when using to square behaviour
Charlie Jolly [Fri, 30 Nov 2018 12:06:04 +0000 (12:06 +0000)]
GP: Fix line primitive when using to square behaviour

Previously the shift key for line primitives only allowed diagonals.
This change allows the line to constrain to vertical and horizontal lines.

Differential Revision: https://developer.blender.org/D4012

21 months agoFix texture previews not updating when parameters are changed.
Alexander Gavrilov [Sun, 2 Dec 2018 11:57:38 +0000 (14:57 +0300)]
Fix texture previews not updating when parameters are changed.

Maybe there is a more correct way, but this works for now.

21 months agoPartial fix for T58113 bevel harden normals bug.
Howard Trickey [Sun, 2 Dec 2018 11:29:58 +0000 (06:29 -0500)]
Partial fix for T58113 bevel harden normals bug.

This fixes the problem where not all faces got hardened properly
when using a hardening mode in the bevel modifier.

21 months agoKeymap: fix error in recent enum-menu support
Campbell Barton [Sun, 2 Dec 2018 04:09:15 +0000 (15:09 +1100)]
Keymap: fix error in recent enum-menu support

21 months agoMerge branch 'master' into blender2.8
Campbell Barton [Sun, 2 Dec 2018 03:32:31 +0000 (14:32 +1100)]
Merge branch 'master' into blender2.8

21 months agoCleanup: BKE b-bone API naming
Campbell Barton [Sun, 2 Dec 2018 03:29:54 +0000 (14:29 +1100)]
Cleanup: BKE b-bone API naming

Use BKE_pchan_bbone prefix.

21 months agoMerge branch 'master' into blender2.8
Campbell Barton [Sun, 2 Dec 2018 03:15:43 +0000 (14:15 +1100)]
Merge branch 'master' into blender2.8

21 months agoCleanup: BKE_effect.h naming
Campbell Barton [Sun, 2 Dec 2018 03:14:51 +0000 (14:14 +1100)]
Cleanup: BKE_effect.h naming

21 months agoKeymap: use strict format for keymap definitions
Campbell Barton [Sun, 2 Dec 2018 02:58:52 +0000 (13:58 +1100)]
Keymap: use strict format for keymap definitions

Ensure we use lists for keymap items and item properties.

This means scripts can access keymap definitions from other layouts,
manipulating them without sometimes encountering a tuple that needs
to be converted into a list.

21 months agoCleanup: simplify poll function
Campbell Barton [Sun, 2 Dec 2018 02:59:43 +0000 (13:59 +1100)]
Cleanup: simplify poll function

21 months agoFix T57455: Fix faulty gpu detection
Clément Foucault [Sun, 2 Dec 2018 02:49:26 +0000 (03:49 +0100)]
Fix T57455: Fix faulty gpu detection

21 months agoCleanup: de-duplicate gpencil material UI
Campbell Barton [Sun, 2 Dec 2018 02:26:10 +0000 (13:26 +1100)]
Cleanup: de-duplicate gpencil material UI

Top-bar and properties-editor were near duplicates.

21 months agoCleanup: remove redundant gpencil material checks
Campbell Barton [Sun, 2 Dec 2018 02:09:15 +0000 (13:09 +1100)]
Cleanup: remove redundant gpencil material checks

Poll checks for an object, no need to check for non-object
materials in the draw function.

21 months agoAdd missing include
Campbell Barton [Sun, 2 Dec 2018 02:11:47 +0000 (13:11 +1100)]
Add missing include

21 months agoFix T57455: Laggy, freezing UI with Linux and Intel UHD 620
Clément Foucault [Sun, 2 Dec 2018 00:57:22 +0000 (01:57 +0100)]
Fix T57455: Laggy, freezing UI with Linux and Intel UHD 620

Seems like a driver bug but doing glFlush() before these calls fixes it.

21 months agoOptimize ghash usage
Campbell Barton [Sat, 1 Dec 2018 21:13:31 +0000 (08:13 +1100)]
Optimize ghash usage

Avoid double hash calculation.

21 months agoFix button data access for python context menus
Campbell Barton [Sat, 1 Dec 2018 20:50:25 +0000 (07:50 +1100)]
Fix button data access for python context menus

D4016 by @raa

21 months agoFix T58460: Proportional edit icon disappears
Antonioya [Sat, 1 Dec 2018 23:05:01 +0000 (00:05 +0100)]
Fix T58460: Proportional edit icon disappears

21 months agoWorkbench: Don't use alpha channel if not doing render
Clément Foucault [Sat, 1 Dec 2018 19:38:30 +0000 (20:38 +0100)]
Workbench: Don't use alpha channel if not doing render

Lower Vram usage a bit

21 months agoWM: Optimization: Don't clear the window color buffer
Clément Foucault [Sat, 1 Dec 2018 19:15:23 +0000 (20:15 +0100)]
WM: Optimization: Don't clear the window color buffer

This is not needed and is rather costly.

Can be reverted if that causes problem.

21 months agoUI: Simplify the area border drawing
Clément Foucault [Sat, 1 Dec 2018 18:49:31 +0000 (19:49 +0100)]
UI: Simplify the area border drawing

Instead of doing a lot of alpha blended drawing with jittering, use the
fragment shader to do the masking using a circle mask.

This is much simpler and requires much less resources.

Hopefully this may solve the issue we have with the Intels UHD Graphics 620
on linux.

21 months agoFix T58433: Limit Distance constraint distance not auto-computed.
Alexander Gavrilov [Sat, 1 Dec 2018 17:02:14 +0000 (20:02 +0300)]
Fix T58433: Limit Distance constraint distance not auto-computed.

Another case of a value that needs to be written back to non-COW copy.

21 months agoFix T58412: in weight paint + pose mode certain armature operations crash.
Alexander Gavrilov [Sat, 1 Dec 2018 16:43:10 +0000 (19:43 +0300)]
Fix T58412: in weight paint + pose mode certain armature operations crash.

The cause is that FOREACH_OBJECT_IN_MODE_BEGIN assumed that the active
object is in the correct mode, which is wrong in this case. It also
only considered objects of the same type as active, which had to be
replaced with an explicit type parameter.

21 months agoFix more cases of evaluated mesh being built for non-COW objects.
Alexander Gavrilov [Sat, 1 Dec 2018 16:06:44 +0000 (19:06 +0300)]
Fix more cases of evaluated mesh being built for non-COW objects.

21 months agofix: Collada exporter has similar issue as reproted in T58150
Gaia Clary [Sat, 1 Dec 2018 14:38:18 +0000 (15:38 +0100)]
fix: Collada exporter has similar issue as reproted in T58150

21 months agofix T58293 Collada: Does not export Texture coordinates when option 'only selected...
Gaia Clary [Sat, 1 Dec 2018 13:18:11 +0000 (14:18 +0100)]
fix T58293 Collada: Does not export Texture coordinates when option 'only selected UV Map' is enabled

21 months agoTexture Paint: implement efficient face selection updates.
Alexander Gavrilov [Sat, 1 Dec 2018 12:40:48 +0000 (15:40 +0300)]
Texture Paint: implement efficient face selection updates.

Fix the old code that propagates selection changes to the
evaluated mesh directly without rebuilding, and avoid tagging
DEG_TAG_COPY_ON_WRITE if it succeeds.

21 months agoFix usage of mesh_get_eval_final in vertex selection.
Alexander Gavrilov [Sat, 1 Dec 2018 11:46:55 +0000 (14:46 +0300)]
Fix usage of mesh_get_eval_final in vertex selection.

It's a very bad idea to call this on non-COW instances - see T58150.
Also, when rebuilding mesh it's better to accumulate mask flags to
avoid possible repeated rebuilds from different users.

21 months agoTexture Paint: fix face selection with subsurface.
Alexander Gavrilov [Sat, 1 Dec 2018 11:38:11 +0000 (14:38 +0300)]
Texture Paint: fix face selection with subsurface.

21 months agoTexture Paint: emulate subsurf optimal display in paint mode wireframe.
Alexander Gavrilov [Sat, 1 Dec 2018 10:44:29 +0000 (13:44 +0300)]
Texture Paint: emulate subsurf optimal display in paint mode wireframe.

The wireframe is intended for showing selected faces, and selection is
based on original faces, so the extra wireframe lines are pure noise.

21 months agoTexture Paint: fix wireframe and hiding not working with subsurf.
Alexander Gavrilov [Sat, 1 Dec 2018 10:20:18 +0000 (13:20 +0300)]
Texture Paint: fix wireframe and hiding not working with subsurf.

The editflag field is only valid in the original mesh instance.

21 months agoTexture Paint: avoid rebuilding evaluated mesh on first stroke.
Alexander Gavrilov [Sat, 1 Dec 2018 09:12:18 +0000 (12:12 +0300)]
Texture Paint: avoid rebuilding evaluated mesh on first stroke.

Ensure all relevant CustomDataMask bits are set during normal evaluation.

21 months agoFix camera gizmo sensor check
Campbell Barton [Sat, 1 Dec 2018 08:38:37 +0000 (19:38 +1100)]
Fix camera gizmo sensor check

Also correct wrong but harmless assignment.

21 months agoCleanup: style
Campbell Barton [Sat, 1 Dec 2018 08:55:37 +0000 (19:55 +1100)]
Cleanup: style

21 months agoCleanup: redundant NULL checks
Campbell Barton [Sat, 1 Dec 2018 08:36:57 +0000 (19:36 +1100)]
Cleanup: redundant NULL checks

Also use unsigned shifting for values not in int range.

21 months agoRevert "Win32: Use the nicer looking blender-drawn confirmation message box when"
Antony Ryakiotakis [Fri, 30 Nov 2018 22:25:45 +0000 (23:25 +0100)]
Revert "Win32: Use the nicer looking blender-drawn confirmation message box when"

This reverts commit 60d6eb0b5d578eb02c5f1f31cb51a6cbeea6ee6f.

There is already a full patch (D3118) by brecht for this, will leave it up to him.

21 months agoCleanup: duplicate include
Campbell Barton [Fri, 30 Nov 2018 21:29:26 +0000 (08:29 +1100)]
Cleanup: duplicate include

21 months agoMerge branch 'master' into blender2.8
Campbell Barton [Fri, 30 Nov 2018 21:17:00 +0000 (08:17 +1100)]
Merge branch 'master' into blender2.8

21 months agoCleanup: style
Campbell Barton [Fri, 30 Nov 2018 21:15:25 +0000 (08:15 +1100)]
Cleanup: style

21 months agoWin32: Use the nicer looking blender-drawn confirmation message box when
Antony Ryakiotakis [Fri, 30 Nov 2018 20:11:59 +0000 (21:11 +0100)]
Win32: Use the nicer looking blender-drawn confirmation message box when
quitting with unsaved changes, instead of an ugly messagebox

21 months agoFix file browsers thumbnail selection with tablet failing, after recent changes.
Brecht Van Lommel [Fri, 30 Nov 2018 18:11:14 +0000 (19:11 +0100)]
Fix file browsers thumbnail selection with tablet failing, after recent changes.

21 months agoFix T58244: Proportional editing center is wrong
Antonioya [Fri, 30 Nov 2018 18:04:14 +0000 (19:04 +0100)]
Fix T58244: Proportional editing center is wrong

The global center was not calculated at all. Now a center is calculated using the selected points

21 months agoFix T58267: node socket grabbing not working well with box select tool.
Brecht Van Lommel [Fri, 30 Nov 2018 17:27:04 +0000 (18:27 +0100)]
Fix T58267: node socket grabbing not working well with box select tool.

21 months agoFix T58235: broken baking of tangent space normals.
Brecht Van Lommel [Fri, 30 Nov 2018 14:54:46 +0000 (15:54 +0100)]
Fix T58235: broken baking of tangent space normals.

21 months agoAnnotation: Replace ALT key to CTRL for Eraser
Antonioya [Fri, 30 Nov 2018 15:23:22 +0000 (16:23 +0100)]
Annotation: Replace ALT key to CTRL for Eraser

This makes the keymap consistent with Grease Pencil.

21 months agoStudioLight Editor: Add copy settings and overwrite prompt
Clément Foucault [Fri, 30 Nov 2018 14:40:46 +0000 (15:40 +0100)]
StudioLight Editor: Add copy settings and overwrite prompt

Copy settings let users create variations more easily.

Ovewrite prompt is there to be able to edit already existing studiolight.