5 years agoCMake: Remove mention of extern_redcode, it was removed
Sergey Sharybin [Sat, 6 Feb 2016 13:37:29 +0000 (14:37 +0100)]
CMake: Remove mention of extern_redcode, it was removed

5 years agoFix T47204: selection failing directly after disabling multisample in user prefs.
Brecht Van Lommel [Thu, 4 Feb 2016 21:26:46 +0000 (22:26 +0100)]
Fix T47204: selection failing directly after disabling multisample in user prefs.

Now store the multisample setting each window was created with.

5 years agoCode cleanup: resolve minor Cycles todo's.
Brecht Van Lommel [Fri, 29 Jan 2016 19:10:38 +0000 (20:10 +0100)]
Code cleanup: resolve minor Cycles todo's.

5 years agoCode cleanup: remove unused Cycles code from BVH cache.
Brecht Van Lommel [Fri, 29 Jan 2016 19:01:35 +0000 (20:01 +0100)]
Code cleanup: remove unused Cycles code from BVH cache.

5 years agoFix Burley BSSRDF NaNs and fireflies.
Brecht Van Lommel [Thu, 4 Feb 2016 22:35:08 +0000 (23:35 +0100)]
Fix Burley BSSRDF NaNs and fireflies.

Explicitly truncate to Rm same way as the Gaussian BSSRDF, and use safe_sqrtf()
to be sure in case of float precision issues.

5 years agoCleanup: Remove support for OSL versions < 1.6.
Thomas Dinges [Fri, 5 Feb 2016 23:07:20 +0000 (00:07 +0100)]
Cleanup: Remove support for OSL versions < 1.6.

We can get rid of more ifdefs once all platforms are on OSL 1.7 soon.

5 years agoCycles: Change several default values (second batch).
Thomas Dinges [Fri, 5 Feb 2016 21:45:36 +0000 (22:45 +0100)]
Cycles: Change several default values (second batch).

This change the following values:
- World settings:
- Use MIS: On
- MIS Samples: 1
- MIS Resolution: 1024

Enabling World MIS per default won't make simple backgrounds (flat background color) slower,
see previous commit. This gets disabled internally if World MIS is not actually needed.

5 years agoCycles: Auto disable World MIS, if we only use a simple color.
Thomas Dinges [Fri, 5 Feb 2016 21:13:51 +0000 (22:13 +0100)]
Cycles: Auto disable World MIS, if we only use a simple color.

When World MIS is enabled by the user, we now check if we actually need it.
In case of a simple node setup (no procedurals, no HDRs..) we auto disable MIS internally to save render time.

This change is important for upcoming default changes.

5 years agoCleanup: Rename has_heterogeneous_volume variable.
Thomas Dinges [Fri, 5 Feb 2016 20:33:37 +0000 (21:33 +0100)]
Cleanup: Rename has_heterogeneous_volume variable.

No functional changes, this change is done for consistency of upcoming changes.

5 years agoFix error in last commit.
Bastien Montagne [Fri, 5 Feb 2016 17:48:15 +0000 (18:48 +0100)]
Fix error in last commit.

treedata could have a non-initialized tree in case of edge_snapping, leading to segfault.

Spotted by @mano-wii, thanks.

5 years agoFix T47326: Snap to vertices not working properly in orthogonal view mode.
Bastien Montagne [Fri, 5 Feb 2016 17:12:07 +0000 (18:12 +0100)]
Fix T47326: Snap to vertices not working properly in orthogonal view mode.

Same causes as when snapping to faces, so same solution: in case of ortho view,
offset start of ray to be just slightly outside of the target's bbox, to avoid
too much far away start point that generate floating point computation instability
in BVH raycasting.

Note that this lead to some refactoring, to avoid duplicating too much of code.

For now, edge snapping seems to behave OK (uses different logic), so not touched.

Based on patch by Germano Cavalcante (@mano-wii), thanks!

5 years agoFix T47329: Compositing fails to render unless each included scene was rendered since...
Sergey Sharybin [Fri, 5 Feb 2016 13:57:53 +0000 (14:57 +0100)]
Fix T47329: Compositing fails to render unless each included scene was rendered since opening

5 years agoFix T45915: Cannot select keyframes in summary channels in Dope Sheet in TweakMode
Joshua Leung [Fri, 5 Feb 2016 13:34:57 +0000 (02:34 +1300)]
Fix T45915: Cannot select keyframes in summary channels in Dope Sheet in TweakMode

When in TweakMode on NLA strips that had an offset, it was not possible to select
those keyframes in the Summary Channel in the Dope Sheet.

The main gist of it is that the current code is from before the summary track was
introduced, and so could assume that ANIM_nla_mapping_get() would work for all channels
present. Thus, simply converting the clicked frame to nla-mapped time once would be
enough. However, for summary channels, nla-mapping_get() doesn't do anything, since
we can potentially include keyframes from several different objects!

5 years agoFix T46037: Moving keys in NLA tweak mode on offset actions results in Bezier handles...
Joshua Leung [Fri, 5 Feb 2016 11:59:32 +0000 (00:59 +1300)]
Fix T46037: Moving keys in NLA tweak mode on offset actions results in Bezier handles getting stretched unreasonably

Patch by Alexander Gavrilov (angavrilov)

Reviewed by Joshua Leung (aligorith)

5 years agoCycles: ifdef some extra code when building split kernels
Sergey Sharybin [Fri, 5 Feb 2016 13:11:16 +0000 (14:11 +0100)]
Cycles: ifdef some extra code when building split kernels

5 years agoCycles: Don't gray out integrator settings when userprefs are set to OpenCL but scene...
Sergey Sharybin [Fri, 5 Feb 2016 12:40:51 +0000 (13:40 +0100)]
Cycles: Don't gray out integrator settings when userprefs are set to OpenCL but scene is set to CPU

5 years agoInstall_deps: update magic build numbers of OIIO and OSL.
Bastien Montagne [Fri, 5 Feb 2016 11:03:58 +0000 (12:03 +0100)]
Install_deps: update magic build numbers of OIIO and OSL.

Please remember to change those each time you update building code and there is no version change.
Otherwise poeple re-running the script won't get the updated builds.

5 years agoCycles: Fix for initial guess of the radius for Burley BSSRDF
Sergey Sharybin [Fri, 5 Feb 2016 09:06:08 +0000 (10:06 +0100)]
Cycles: Fix for initial guess of the radius for Burley BSSRDF

The value was too high, causing bad Newton iteration step.
Now the value is not so good, but it's still within 9 iterations
and those high number of iterations are only happening in
approx 1% of input values.

5 years agoCycles / OSL: Updare stdosl.h to 1.7.1.
Thomas Dinges [Thu, 4 Feb 2016 23:02:35 +0000 (00:02 +0100)]
Cycles / OSL: Updare stdosl.h to 1.7.1.

This updates our file to OSL 1.7.1, which comes with some new inbuilt

- linearstep()
- smooth_linearstep()

- hash()
- getchar()

5 years agoInstall Deps: Use SSE2 optimizations for OIIO and OSL.
Thomas Dinges [Thu, 4 Feb 2016 22:42:39 +0000 (23:42 +0100)]
Install Deps: Use SSE2 optimizations for OIIO and OSL.

5 years agoCleanup: Update BSSRDF code comment.
Thomas Dinges [Thu, 4 Feb 2016 21:42:55 +0000 (22:42 +0100)]
Cleanup: Update BSSRDF code comment.

5 years agoSupport for cubemap reflections in the viewport
Campbell Barton [Thu, 4 Feb 2016 17:28:16 +0000 (04:28 +1100)]
Support for cubemap reflections in the viewport

D1756 by @youle, uses existing texture mapping option.

5 years agoUpdate themes
Campbell Barton [Thu, 4 Feb 2016 16:57:58 +0000 (03:57 +1100)]
Update themes

Label text editing uses colors from text buttons

5 years agoInstall_deps: Disable building tests for OSL
Thomas Beck [Thu, 4 Feb 2016 17:10:20 +0000 (18:10 +0100)]
Install_deps: Disable building tests for OSL

Since we're now on 1.7 we can skip building the OSL testsuite. It was giving various compilation errors on different machines and we don't need them just disabling them in the script.

5 years agoFix T47324: Edit-text in list view theme glitch
Campbell Barton [Thu, 4 Feb 2016 15:57:53 +0000 (02:57 +1100)]
Fix T47324: Edit-text in list view theme glitch

Use existing text select colors when text matches select color.

5 years agoInstall_deps: tweak OSL build options.
Bastien Montagne [Thu, 4 Feb 2016 15:50:46 +0000 (16:50 +0100)]
Install_deps: tweak OSL build options.

5 years agoInstall_deps: updated OSL to 1.7.1.
Bastien Montagne [Thu, 4 Feb 2016 15:35:32 +0000 (16:35 +0100)]
Install_deps: updated OSL to 1.7.1.

5 years agoCycles: Speedup of Christensen-Burley SSS falloff function
Sergey Sharybin [Thu, 4 Feb 2016 14:25:29 +0000 (15:25 +0100)]
Cycles: Speedup of Christensen-Burley SSS falloff function

The idea is simply to pre-compute fitting and parameterization
in the bssrdf_setup() function and re-use the values in both
sample() and eval().

The only trick is where to store the pre-calculated values and
the answer is inside of ShaderClosure->custom{1,2,3}. There's
no memory bump here because we now simply re-use padding fields
for the pre-calculated values. Similar trick we can do for other

Seems to give nice speedup up to 7% here on my desktop with
Core i7 CPU, SSE4.1 kernel.

5 years agoFix T47323, no Fac output in Magic texture (OSL).
Thomas Dinges [Thu, 4 Feb 2016 13:08:36 +0000 (14:08 +0100)]
Fix T47323, no Fac output in Magic texture (OSL).

5 years agoNodes: Remove code which was dead for 2 years now
Sergey Sharybin [Thu, 4 Feb 2016 08:57:00 +0000 (09:57 +0100)]
Nodes: Remove code which was dead for 2 years now

5 years agoCycles: Make Christensen-Burley a default falloff function
Sergey Sharybin [Thu, 4 Feb 2016 08:52:56 +0000 (09:52 +0100)]
Cycles: Make Christensen-Burley a default falloff function

5 years agoCycles: Implement approximate reflectance profiles
Sergey Sharybin [Wed, 3 Feb 2016 22:34:49 +0000 (03:34 +0500)]
Cycles: Implement approximate reflectance profiles

Using this paper:

This model gives less blurry results than the Cubic and Gaussian
we had implemented:

- Cubic:
- Burley:

The model is called "Christensen-Burley" in the interface, which
actually should be read as "Physically based" or "Realistic".

Reviewers: juicyfruit, dingto, lukasstockner97, brecht

Reviewed By: brecht, dingto

Subscribers: robocyte

Differential Revision:

5 years agoUse contextlib for temporary py console overrides
Campbell Barton [Thu, 4 Feb 2016 06:40:02 +0000 (17:40 +1100)]
Use contextlib for temporary py console overrides

Using context overrides means stdout/stderr overrides can't be left set by accident.

5 years agoProject Paint: add sample merged option
Campbell Barton [Thu, 4 Feb 2016 04:26:07 +0000 (15:26 +1100)]
Project Paint: add sample merged option

This picks the on-screen color instead of using the active layers texture color.

5 years agoFix T47317: Dynamic paint crashes with no UV layer
Campbell Barton [Thu, 4 Feb 2016 03:17:52 +0000 (14:17 +1100)]
Fix T47317: Dynamic paint crashes with no UV layer

5 years agoCycles: Correction to asserts, they will never trigger before
Sergey Sharybin [Wed, 3 Feb 2016 14:01:26 +0000 (15:01 +0100)]
Cycles: Correction to asserts, they will never trigger before

5 years agoCycles: Cleanup, indentation and braces
Sergey Sharybin [Wed, 3 Feb 2016 14:00:55 +0000 (15:00 +0100)]
Cycles: Cleanup, indentation and braces

5 years agoFix T47266: Blender crashes from Scripted Expression in Driver
Sergey Sharybin [Wed, 3 Feb 2016 13:40:02 +0000 (14:40 +0100)]
Fix T47266: Blender crashes from Scripted Expression in Driver

Issue was caused by update RNA callbacks freeing the dependency
graph, which is only needed to tag depsgraph for rebuild.

Solved by using a flag for the depsgraph which indicated that it
is to be rebuilt.

5 years agoCycles: Cleanup, indentation
Sergey Sharybin [Wed, 3 Feb 2016 11:17:39 +0000 (12:17 +0100)]
Cycles: Cleanup, indentation

Not sure why it was mixed tabs and spaces, it's all just
confusing in different editors.

5 years agoFix T47302: Crash when OSL active with a viewport on rendered
Sergey Sharybin [Wed, 3 Feb 2016 11:10:00 +0000 (12:10 +0100)]
Fix T47302: Crash when OSL active with a viewport on rendered

Only happened when rendering second time with OSL enabled.
Was caused by fix for T47201. Hopefully now all the issues
are solved (meaning, we don't keep files opened and don't
crash either).

5 years agoCleanup: parenthesize macros
Campbell Barton [Wed, 3 Feb 2016 10:17:07 +0000 (21:17 +1100)]
Cleanup: parenthesize macros

5 years agoImbuf: remove libredcode
Campbell Barton [Wed, 3 Feb 2016 07:31:39 +0000 (18:31 +1100)]
Imbuf: remove libredcode

D1751, remove this library since its quite a specific - only supports an older version of this codec.

Also ffmpeg has added support for recent versions of the codec.

5 years agoCleanup: refactor tooltip data-access out of layout function
Campbell Barton [Wed, 3 Feb 2016 07:01:18 +0000 (18:01 +1100)]
Cleanup: refactor tooltip data-access out of layout function

5 years agoRemove redundant file exists checks
Campbell Barton [Wed, 3 Feb 2016 06:45:54 +0000 (17:45 +1100)]
Remove redundant file exists checks

5 years agoFix T47303: Voxel texture disappears after first frame
Campbell Barton [Wed, 3 Feb 2016 06:33:51 +0000 (17:33 +1100)]
Fix T47303: Voxel texture disappears after first frame

Failed reads didn't update the voxel 'ok' tag,
making successive reads fail (even on existing frames).

5 years agoRecent BLI_rename fix introduced error w/ blend file versioning
Campbell Barton [Wed, 3 Feb 2016 06:06:42 +0000 (17:06 +1100)]
Recent BLI_rename fix introduced error w/ blend file versioning

Rename calls didn't check if the file existed first, so missing file was counted as success and ignored.

5 years agoInclude why file operations fail in reports
Campbell Barton [Wed, 3 Feb 2016 05:37:02 +0000 (16:37 +1100)]
Include why file operations fail in reports

5 years agoFix BLI_rename returned success w/ missing source path
Campbell Barton [Wed, 3 Feb 2016 04:57:24 +0000 (15:57 +1100)]
Fix BLI_rename returned success w/ missing source path

5 years agoFix T47249: Wrong edit-mesh material color w/ hidden faces
Campbell Barton [Wed, 3 Feb 2016 04:01:50 +0000 (15:01 +1100)]
Fix T47249: Wrong edit-mesh material color w/ hidden faces

Regression in 700c40e2

Also avoid unnecessary flushes with material changes with hidden faces.

5 years agoCleanup: correct comment, unused var
Campbell Barton [Wed, 3 Feb 2016 00:51:58 +0000 (11:51 +1100)]
Cleanup: correct comment, unused var

5 years agoFix T47300: SHIFT TAB, CTRL SHIFT TAB shortcuts does not toggle snap, snap mode on...
Bastien Montagne [Tue, 2 Feb 2016 20:27:33 +0000 (21:27 +0100)]
Fix T47300: SHIFT TAB, CTRL SHIFT TAB shortcuts does not toggle snap, snap mode on off anymore.

Regression from rB12c71508c2d7.

Now, we systematically first try keycode from `XLookupKeysym()`, and only fall back to
the one from `XLookupString()` if it failed to convert to a valid gkey.

5 years agoUsual i18n/UI message fixes...
Bastien Montagne [Tue, 2 Feb 2016 19:40:23 +0000 (20:40 +0100)]
Usual i18n/UI message fixes...

5 years agoCycles: Cleanup and reference actual paper used for BSSRDF sampling
Sergey Sharybin [Tue, 2 Feb 2016 17:06:03 +0000 (18:06 +0100)]
Cycles: Cleanup and reference actual paper used for BSSRDF sampling

5 years agoFix T46933: Bone axes letters may not be visible
Campbell Barton [Tue, 2 Feb 2016 16:30:36 +0000 (03:30 +1100)]
Fix T46933: Bone axes letters may not be visible

Now axis letters are view aligned.

5 years agoFix T46583: Sculpt symmetry don't work in clipping border view mode
Sergey Sharybin [Tue, 2 Feb 2016 15:04:33 +0000 (16:04 +0100)]
Fix T46583: Sculpt symmetry don't work in clipping border view mode

This is an attempt to solve the issue by doing clip test on the original
side of the stroke. Some extra testing is required.

5 years agoFix T46411: Experimental deps graph causes particles to jump around
Sergey Sharybin [Tue, 2 Feb 2016 14:43:20 +0000 (15:43 +0100)]
Fix T46411: Experimental deps graph causes particles to jump around

5 years agoDepsgraph: Fix particle system component nodes not being displayed in debug graph
Sergey Sharybin [Tue, 2 Feb 2016 14:33:50 +0000 (15:33 +0100)]
Depsgraph: Fix particle system component nodes not being displayed in debug graph

5 years agoFix T46382: Crash sharing particle system with clump or rough curves
Sergey Sharybin [Tue, 2 Feb 2016 14:01:58 +0000 (15:01 +0100)]
Fix T46382: Crash sharing particle system with clump or rough curves

Made those curves local to thread evaluation now, so there is no
threading conflict accessing them from evaluation threads anymore.

5 years agoFix T46481: Volume grid particles out of volume
Sergey Sharybin [Tue, 2 Feb 2016 12:54:53 +0000 (13:54 +0100)]
Fix T46481: Volume grid particles out of volume

The issue was caused by fix for 31017 which resulted in some
missing intersecitons recorded which screwed inner/outer checks.

This is an old bug, so didn't bother with forcing re-distribution
to happen on file open to avoid possible other regressions.

5 years agoFix T47207: Material shading incorrectly handles colorramp node
Sergey Sharybin [Tue, 2 Feb 2016 11:48:18 +0000 (12:48 +0100)]
Fix T47207: Material shading incorrectly handles colorramp node

The issue was introduced by a fix for T44713 which only made GLSL
consistent with Cycles.

Now we do have conditional averaging or proper luma weighting based
on whether we're new old old shading system. Not totally ideal but
should work for until we re-design viewport possibly breaking how
Blender Internal does implicit conversion.

5 years agoCleanup: rename uvflag -> flag for dm drawing
Campbell Barton [Tue, 2 Feb 2016 06:37:00 +0000 (17:37 +1100)]
Cleanup: rename uvflag -> flag for dm drawing

Was called both, however this isn't mainly for uv's so just call 'flag'.
Also remove redundant NULL check.

5 years agoPartial Fix T47221: Sculpt Hide fails w/ texture drawing
Campbell Barton [Tue, 2 Feb 2016 05:06:45 +0000 (16:06 +1100)]
Partial Fix T47221: Sculpt Hide fails w/ texture drawing

Support for skipping hidden faces in sculpt mode w/ texture drawing.

5 years agoUI: update dynamic tips
Campbell Barton [Tue, 2 Feb 2016 03:13:57 +0000 (14:13 +1100)]
UI: update dynamic tips

Useful for progress ETA to continuously update.

This adds API option not to activate new regions GL state which isn't needed in many cases.

5 years agoFix T47256: Progress bar doesn't update w/ mouse-over
Campbell Barton [Tue, 2 Feb 2016 03:06:06 +0000 (14:06 +1100)]
Fix T47256: Progress bar doesn't update w/ mouse-over

5 years agoUse simpler method to check the planes view aligned
Campbell Barton [Tue, 2 Feb 2016 01:03:32 +0000 (12:03 +1100)]
Use simpler method to check the planes view aligned

5 years agoMatch armature/object select grouped order
Campbell Barton [Tue, 2 Feb 2016 01:39:31 +0000 (12:39 +1100)]
Match armature/object select grouped order

5 years agoCleanup: style
Campbell Barton [Tue, 2 Feb 2016 00:56:30 +0000 (11:56 +1100)]
Cleanup: style

5 years agoArmature select similar: children, immediate-children en sibligns selection.
Michał Ziobro [Mon, 1 Feb 2016 23:28:34 +0000 (00:28 +0100)]
Armature select similar: children, immediate-children en sibligns selection.

Reviewed By: brecht

Differential Revision:

5 years agoFix build error on OS X in previous commit, this define should stay.
Brecht Van Lommel [Mon, 1 Feb 2016 23:38:14 +0000 (00:38 +0100)]
Fix build error on OS X in previous commit, this define should stay.

5 years agoFix T47293: game engine crashes since Bullet upgrade.
Brecht Van Lommel [Mon, 1 Feb 2016 23:16:31 +0000 (00:16 +0100)]
Fix T47293: game engine crashes since Bullet upgrade.

This restores a modification that was there before.

5 years agoFix double metadata prefix when using strip's metadata
Sergey Sharybin [Mon, 1 Feb 2016 17:09:15 +0000 (18:09 +0100)]
Fix double metadata prefix when using strip's metadata

5 years agoCorrection to previous fix of multiple releases of same ImBuf
Sergey Sharybin [Mon, 1 Feb 2016 16:10:40 +0000 (17:10 +0100)]
Correction to previous fix of multiple releases of same ImBuf

Original change in d631252 was not quite correct because it
was missing release since the acquire() will return NULL.

Hopefully now all the cases are covered.

5 years agoFix T47288 Vector transform not behaving correctly with camera space and cycles
Alexander Romanov [Mon, 1 Feb 2016 15:46:32 +0000 (18:46 +0300)]
Fix T47288 Vector transform not behaving correctly with camera space and cycles

5 years agoFix potential access uninitialized metadata
Sergey Sharybin [Mon, 1 Feb 2016 15:33:29 +0000 (16:33 +0100)]
Fix potential access uninitialized metadata

5 years agoRemove debug-only code which sneaked in
Sergey Sharybin [Mon, 1 Feb 2016 15:29:45 +0000 (16:29 +0100)]
Remove debug-only code which sneaked in

5 years agoFix wrong information used for stamp when "Strip Metadata" is used
Sergey Sharybin [Mon, 1 Feb 2016 15:09:21 +0000 (16:09 +0100)]
Fix wrong information used for stamp when "Strip Metadata" is used

Such configuration used to cause quite confusing situation when
stamp will use actual scene's statistics but metadata from strip
will be used for the saved file (basically, causing different
information stamped and saved as metadata).

Don't think it was desired behavior and it's something what
artists here in the studio wants to be fixed.

5 years agoAdd theme settings for keyframe indication in 3D View
Gaia Clary [Mon, 1 Feb 2016 13:01:02 +0000 (14:01 +0100)]
Add theme settings for keyframe indication in 3D View

5 years agoCleanup: FileData->flags: Convert defines to anonymous enum.
Bastien Montagne [Mon, 1 Feb 2016 13:03:31 +0000 (14:03 +0100)]
Cleanup: FileData->flags: Convert defines to anonymous enum.

5 years agoFix T47238: Bug w/ view aligned constraint plane
Campbell Barton [Mon, 1 Feb 2016 10:42:39 +0000 (21:42 +1100)]
Fix T47238: Bug w/ view aligned constraint plane

When constraining on 2 axis, it was possible the plane was view-aligned causing odd glitches.

5 years agoAvoid duplicate getConstraintSpaceDimension calls
Campbell Barton [Mon, 1 Feb 2016 07:06:34 +0000 (18:06 +1100)]
Avoid duplicate getConstraintSpaceDimension calls

5 years agoCMake: Silent Numpy warning on OSX
Sergey Sharybin [Mon, 1 Feb 2016 09:39:16 +0000 (10:39 +0100)]
CMake: Silent Numpy warning on OSX

It is in the archive actually and being installed nicely by the looks of it.

5 years agoCMake: Attempt to fix wrong installation folder for requests on OSX
Sergey Sharybin [Mon, 1 Feb 2016 09:38:34 +0000 (10:38 +0100)]
CMake: Attempt to fix wrong installation folder for requests on OSX

5 years agoSequencer: IF effect strip only affects on a single strip use source metadata for...
Sergey Sharybin [Mon, 1 Feb 2016 09:19:55 +0000 (10:19 +0100)]
Sequencer: IF effect strip only affects on a single strip use source metadata for the result

This way it's possible to have some color-correction modifications on
top of the render result and yet still have proper metadata stored.

Usecase: Access per-frame render-time of the movie frames from the
final export.

5 years agoCycles: Fix wrong clamping used for camera border
Sergey Sharybin [Mon, 1 Feb 2016 09:02:24 +0000 (10:02 +0100)]
Cycles: Fix wrong clamping used for camera border

5 years agoFix missing return after NULL check, from Coverity reports.
Bastien Montagne [Mon, 1 Feb 2016 07:34:29 +0000 (08:34 +0100)]
Fix missing return after NULL check, from Coverity reports.

5 years agoView2D: avoid divide-by-zero
Campbell Barton [Mon, 1 Feb 2016 04:05:45 +0000 (15:05 +1100)]
View2D: avoid divide-by-zero

5 years agoCleanup: unused TransInfo members
Campbell Barton [Mon, 1 Feb 2016 02:33:22 +0000 (13:33 +1100)]
Cleanup: unused TransInfo members

5 years agoFix transform crash in rare cases
Campbell Barton [Mon, 1 Feb 2016 04:15:10 +0000 (15:15 +1100)]
Fix transform crash in rare cases

In some cases transform modes would use the custom-data pointer,
other times the transform conversion functions would.

However with some combinations (bone mirror + bend for eg),
both conversion & transform mode would use this pointer causing a crash.

Fix this by having 2 custom-data pointers:
one for the mode, another for the data-type.

This also simplifies time-slide which was conditionally mixing mode/type data in the one array.

5 years agoFix T47289: Edges don't transform in face-mode
Campbell Barton [Mon, 1 Feb 2016 02:15:02 +0000 (13:15 +1100)]
Fix T47289: Edges don't transform in face-mode

5 years agoDocs: warning for loading duplicate movie-clips
Campbell Barton [Mon, 1 Feb 2016 00:55:59 +0000 (11:55 +1100)]
Docs: warning for loading duplicate movie-clips

5 years agoUI: minor tweaks to view orbit shortcuts show
Campbell Barton [Mon, 1 Feb 2016 00:01:00 +0000 (11:01 +1100)]
UI: minor tweaks to view orbit shortcuts show

5 years agoCleanup: pep8
Campbell Barton [Sun, 31 Jan 2016 13:47:10 +0000 (00:47 +1100)]
Cleanup: pep8

5 years agoDocs: add preset menu example
Campbell Barton [Sun, 31 Jan 2016 07:04:57 +0000 (18:04 +1100)]
Docs: add preset menu example

5 years agoPoint Cache: fix typo in smoke_openvdb_read.
Kévin Dietrich [Sat, 30 Jan 2016 22:29:59 +0000 (23:29 +0100)]
Point Cache: fix typo in smoke_openvdb_read.

5 years agoFix T47153: scroll wheel zoom fails with mouses that support smooth scroll on OS X.
Brecht Van Lommel [Sat, 30 Jan 2016 21:33:20 +0000 (22:33 +0100)]
Fix T47153: scroll wheel zoom fails with mouses that support smooth scroll on OS X.

5 years agoFix T47263: numpad4/6 rotates around worl Z axis and not view Y axis.
Bastien Montagne [Sat, 30 Jan 2016 18:07:36 +0000 (19:07 +0100)]
Fix T47263: numpad4/6 rotates around worl Z axis and not view Y axis.

Those two were the only one rotating around some world axis (turntable mode),
so better make their behavior consistent with other rotating numpad keys.

This breaks the turntable-rotation with numpad keys, though.

5 years agoFix T46455: Array modifier could generate chained mapping of vertices, leading to...
Bastien Montagne [Sat, 30 Jan 2016 16:17:05 +0000 (17:17 +0100)]
Fix T46455: Array modifier could generate chained mapping of vertices, leading to corrupted geometry.

That was the main issue (in both T46455 and T46690), solved by 'flattening' those chains (v1 -> v2 ->v3 etc.)
before calling `CDDM_merge_verts()`.

Also added note to `CDDM_merge_verts()` that it does not support chained mapping, along with
a basic assert that should catch most of those cases in future.

The logic of 'following mapping' was also rather broken, making a special case here when using
object-controlled offset is very weak. Further more, blindly following mapping in this case
was far from ideal, this could end to merging vertices rather far from each other.

To address this issue, we now always follow mapping, but only as long as 'final' vertex remains
close enough from mapped one.

Finally, the search of 'closest' vertex to merge with was also quite bad, would just pick the first
one matching distance limit, instead of using the actual closest one - could lead to rather ugly
geometry deformations in case one would use not-so-small merge threashold!

5 years agoFix memory leak in hook modifier's data copy
Sergey Sharybin [Sat, 30 Jan 2016 14:40:24 +0000 (15:40 +0100)]
Fix memory leak in hook modifier's data copy

5 years agoCycles: Pass Blender's C++ RNA structures by reference
Sergey Sharybin [Sat, 30 Jan 2016 13:18:29 +0000 (14:18 +0100)]
Cycles: Pass Blender's C++ RNA structures by reference

This way we avoid passing structures which could be up to
few hundred bytes by value to the utility functions.

Ideally we'll also have to add `const` qualifier in majority
of the calls, but C++ RNA does not allow us to do that because
it does not know if some function modifies contents or not.

5 years agoCleanup: correct qsort comments
Campbell Barton [Sat, 30 Jan 2016 02:26:11 +0000 (13:26 +1100)]
Cleanup: correct qsort comments

Also add link to original source & parenthesize min macro.