6 months agoCleanup: remove unused menu bl_spacetype
Campbell Barton [Wed, 27 Mar 2019 13:24:51 +0000 (00:24 +1100)]
Cleanup: remove unused menu bl_spacetype

6 months agoFix T62978: grease pencil 3D view header layout broken after recent changes.
Brecht Van Lommel [Wed, 27 Mar 2019 12:59:18 +0000 (13:59 +0100)]
Fix T62978: grease pencil 3D view header layout broken after recent changes.

6 months agoRevert "RNA: error on register when classes use invalid identifiers"
Campbell Barton [Wed, 27 Mar 2019 12:29:42 +0000 (23:29 +1100)]
Revert "RNA: error on register when classes use invalid identifiers"

This reverts commit b24a255ca67841ff2d6121327791e933ce8e3602.

The warning wasn't being printed, so many add-ons weren't yet updated.

Re-enable now warnings are printed to allow addon developers to update.

6 months agoFix T62926: allow using shift click drag to extend selection in file browser.
Brecht Van Lommel [Wed, 27 Mar 2019 12:13:05 +0000 (13:13 +0100)]
Fix T62926: allow using shift click drag to extend selection in file browser.

Standard behavior on most operating systems.

6 months agoCleanup: style, use braces for bmesh
Campbell Barton [Wed, 27 Mar 2019 06:14:36 +0000 (17:14 +1100)]
Cleanup: style, use braces for bmesh

6 months agoFix popovers from enums failing on drag-release
Campbell Barton [Wed, 27 Mar 2019 04:35:49 +0000 (15:35 +1100)]
Fix popovers from enums failing on drag-release

6 months agoFix class registration ignoring info/warnings
Campbell Barton [Wed, 27 Mar 2019 03:03:16 +0000 (14:03 +1100)]
Fix class registration ignoring info/warnings

Only errors were displayed in the console.

6 months agoPyAPI: utility function to print reports
Campbell Barton [Wed, 27 Mar 2019 03:01:25 +0000 (14:01 +1100)]
PyAPI: utility function to print reports

6 months agoCleanup: unused variables
Campbell Barton [Wed, 27 Mar 2019 02:19:02 +0000 (13:19 +1100)]
Cleanup: unused variables

6 months agoCleanup: style, use braces for blenlib
Campbell Barton [Wed, 27 Mar 2019 02:16:10 +0000 (13:16 +1100)]
Cleanup: style, use braces for blenlib

6 months agoPython API: add more detailed example for RenderEngine.
Brecht Van Lommel [Tue, 26 Mar 2019 18:48:16 +0000 (19:48 +0100)]
Python API: add more detailed example for RenderEngine.

6 months agoPython API: allow passing None to some BGL functions instead of bgl.Buffer
Brecht Van Lommel [Tue, 26 Mar 2019 18:48:44 +0000 (19:48 +0100)]
Python API: allow passing None to some BGL functions instead of bgl.Buffer

Many OpenGL functions take NULL pointers, passing those was quite complicated
with some addons even using ctypes to manipulate internal bgl.Buffer pointers.

6 months agoFix vertex array leak in Cycles viewport drawing.
Brecht Van Lommel [Tue, 26 Mar 2019 16:26:57 +0000 (17:26 +0100)]
Fix vertex array leak in Cycles viewport drawing.

6 months agoDRW manager: Use existing viewport instead of creating a viewport in DRW_draw_depth_loop.
mano-wii [Tue, 26 Mar 2019 15:19:00 +0000 (12:19 -0300)]
DRW manager: Use existing viewport instead of creating a viewport in DRW_draw_depth_loop.

6 months agoFix T62952: remove lamp as camera using the lamp clip start/end.
Brecht Van Lommel [Tue, 26 Mar 2019 15:07:42 +0000 (16:07 +0100)]
Fix T62952: remove lamp as camera using the lamp clip start/end.

Eevee and Cycles don't use these clipping distances the same as Blender
Internal did, or at all in most cases. Just remove this since it makes no
sense anymore.

6 months agoFix T62958: Improve exponential easing formula
Jacques Lucke [Tue, 26 Mar 2019 14:43:51 +0000 (15:43 +0100)]
Fix T62958: Improve exponential easing formula

Reviewers: brecht

Differential Revision:

6 months agoFix T62955: Missing panels in workbench engine
Jacques Lucke [Tue, 26 Mar 2019 14:41:56 +0000 (15:41 +0100)]
Fix T62955: Missing panels in workbench engine

Afaik all the panels in the scene settings are render
engine independent. So it does not make sense to have
this extra complexity in every panel class.

Reviewers: brecht, billreynish

Differential Revision:

6 months agoFix T62626: Python errors when pinning particle settings.
Brecht Van Lommel [Tue, 26 Mar 2019 14:41:43 +0000 (15:41 +0100)]
Fix T62626: Python errors when pinning particle settings.

6 months agoMerge branch 'blender2.7'
Brecht Van Lommel [Tue, 26 Mar 2019 14:30:52 +0000 (15:30 +0100)]
Merge branch 'blender2.7'

6 months agoFix Cycles standalone build, needs OpenJPEG libraries with OIIO now.
Brecht Van Lommel [Tue, 26 Mar 2019 13:38:37 +0000 (14:38 +0100)]
Fix Cycles standalone build, needs OpenJPEG libraries with OIIO now.

6 months agoFix T62189: Wires Occluded When Edit Mesh Faces Disabled
Jeroen Bakker [Tue, 26 Mar 2019 14:18:47 +0000 (15:18 +0100)]
Fix T62189: Wires Occluded When Edit Mesh Faces Disabled

Reviewed By: fclem
Maniphest Tasks: T62189
Differential Revision:

6 months agoEdit Mesh: Fix interpolation of gradient on edit edges
Clément Foucault [Mon, 25 Mar 2019 21:47:36 +0000 (22:47 +0100)]
Edit Mesh: Fix interpolation of gradient on edit edges

This fix some issue with the AA on edit mesh edges.

6 months agoFix T62260 edges display bug on big geometries when looked up close
Clément Foucault [Mon, 25 Mar 2019 21:46:47 +0000 (22:46 +0100)]
Fix T62260 edges display bug on big geometries when looked up close

6 months agoRevert "DRW Manager: create and use new DRW_framebuffer_depth_read utility."
Jeroen Bakker [Tue, 26 Mar 2019 14:06:29 +0000 (15:06 +0100)]
Revert "DRW Manager: create and use new DRW_framebuffer_depth_read utility."

This reverts commit 40f8f445a3f9b6bc24b58e45be46060cc36c0394.

There are many paths that lead to uninitialized depth buffer where the
depth read would fail.

Fix T62965

6 months agoUI: Avoid double separators in some circumstances in the object context menu
William Reynish [Tue, 26 Mar 2019 13:48:35 +0000 (14:48 +0100)]
UI: Avoid double separators in some circumstances in the object context menu

Also make placement of Rename more consistent between object and bones.

6 months agoCycles: sync various master changes to blender2.7.
Brecht Van Lommel [Tue, 26 Mar 2019 13:34:18 +0000 (14:34 +0100)]
Cycles: sync various master changes to blender2.7.

Many of these were left out accidentally. We will only do important bugfixes
in blender2.7 for Cycles from this point on.

6 months agoFix (unreported) crash when making object single user in some cases.
Bastien Montagne [Tue, 26 Mar 2019 13:39:43 +0000 (14:39 +0100)]
Fix (unreported) crash when making object single user in some cases.

Issue would happen in case affected object is linked to collections that
are shared between different scenes' ViewLayers. When switching back to
another scene after making single user, you'd get immediate crash.

6 months agoFix T62929: Linked To Scene Object cannot be made single user.
Bastien Montagne [Tue, 26 Mar 2019 13:30:45 +0000 (14:30 +0100)]
Fix T62929: Linked To Scene Object cannot be made single user.

Code was still 2.7x one here, Object's IDtemplate in properties editor
is now based on current view layer's collection of objects, not scene's
one anymore.

6 months agoUI: Make naming clearer for the motion paths commands in the pose context menu
William Reynish [Tue, 26 Mar 2019 13:37:10 +0000 (14:37 +0100)]
UI: Make naming clearer for the motion paths commands in the pose context menu

6 months agoUI: Add rename to object and bone context menus
William Reynish [Tue, 26 Mar 2019 13:36:15 +0000 (14:36 +0100)]
UI: Add rename to object and bone context menus

6 months agoFix T62887: When searching for fonts, thumbnail display mode will crash Blender
Sebastian Parborg [Tue, 26 Mar 2019 13:08:42 +0000 (14:08 +0100)]
Fix T62887: When searching for fonts, thumbnail display mode will crash Blender

We do not support special color fonts (like colored emoji fonts), so
don't crash when trying to create a preview for unsupported fonts.

Reviewed By: Brecht

Differential Revision:

6 months agoFix T62957: Camera frame returns zeros
Campbell Barton [Tue, 26 Mar 2019 11:50:40 +0000 (22:50 +1100)]
Fix T62957: Camera frame returns zeros

6 months agoFix T62756, T62131: moving stencil texture fails after moving stencil mask
Brecht Van Lommel [Tue, 26 Mar 2019 11:34:10 +0000 (12:34 +0100)]
Fix T62756, T62131: moving stencil texture fails after moving stencil mask

6 months agoFix T62925: shift+F1 append shortcut not working in Blender 2.7 keymap.
Brecht Van Lommel [Tue, 26 Mar 2019 11:13:14 +0000 (12:13 +0100)]
Fix T62925: shift+F1 append shortcut not working in Blender 2.7 keymap.

6 months agoFix T62515: crash when rendering finishes with mouse over progress bar.
Brecht Van Lommel [Tue, 26 Mar 2019 11:02:49 +0000 (12:02 +0100)]
Fix T62515: crash when rendering finishes with mouse over progress bar.

Tooltip should be copied entirely, not just the the argument because then the
function and argument don't always match.

6 months agoCleanup: style, use braces for editor/spaces
Campbell Barton [Tue, 26 Mar 2019 10:16:47 +0000 (21:16 +1100)]
Cleanup: style, use braces for editor/spaces

6 months agoCleanup: style, use braces for editor/metaball
Campbell Barton [Tue, 26 Mar 2019 10:16:26 +0000 (21:16 +1100)]
Cleanup: style, use braces for editor/metaball

6 months agoCleanup: style, use braces for editor/interface
Campbell Barton [Tue, 26 Mar 2019 10:16:13 +0000 (21:16 +1100)]
Cleanup: style, use braces for editor/interface

6 months agoCleanup: style, use braces for editor/curve
Campbell Barton [Tue, 26 Mar 2019 10:15:47 +0000 (21:15 +1100)]
Cleanup: style, use braces for editor/curve

6 months agoDepsgraph: Standardize parameters nodes
Sergey Sharybin [Tue, 26 Mar 2019 09:47:41 +0000 (10:47 +0100)]
Depsgraph: Standardize parameters nodes

Makes it possible to handle them the same from drivers
relations builder.

Solves missing operations errors printed when opening
autumn character.

6 months ago3D View: move deselect all logic into an option
Campbell Barton [Tue, 26 Mar 2019 07:47:55 +0000 (18:47 +1100)]
3D View: move deselect all logic into an option

This removes `VIEW3D_OT_select_or_deselect_all`, adding a
deselect_all option to the `VIEW3D_OT_select` operator.

- Add utility functions to simplify de-selecting all.

- Return true from selection functions when they change the selection
  to avoid redundant updates.

- Use arrays of bases when passing objects between selection utility
  functions since some users require bases.

- Fix logical error in box selection that updated all objects after
  the first hit.

6 months agoFix T62774: Respect Show Overlays
Jeroen Bakker [Tue, 26 Mar 2019 06:58:14 +0000 (07:58 +0100)]
Fix T62774: Respect Show Overlays

Some draw code did not respect Show Overlays option. These were:

 * All mode based drawing engines (edit mode)
 * Wireframe drawing

This change make them respect the Show Overlays Option.

Reviewed By: fclem, billreynish

Maniphest Tasks: T62774

Differential Revision:

6 months agoFix use of uninitialized variable in grease pencil materials.
Brecht Van Lommel [Tue, 26 Mar 2019 03:26:47 +0000 (04:26 +0100)]
Fix use of uninitialized variable in grease pencil materials.

6 months agoFix T62946: function abs() not working in driver expressions.
Brecht Van Lommel [Tue, 26 Mar 2019 03:10:46 +0000 (04:10 +0100)]
Fix T62946: function abs() not working in driver expressions.

6 months agoFix T62946: missing warning when Python driver expression execution is disabled.
Brecht Van Lommel [Tue, 26 Mar 2019 02:57:39 +0000 (03:57 +0100)]
Fix T62946: missing warning when Python driver expression execution is disabled.

6 months agoCleanup: remove unused function
Campbell Barton [Tue, 26 Mar 2019 01:50:36 +0000 (12:50 +1100)]
Cleanup: remove unused function

6 months agoCleanup: style
Campbell Barton [Mon, 25 Mar 2019 23:15:46 +0000 (10:15 +1100)]
Cleanup: style

6 months agoCleanup: warnings, correct assert
Campbell Barton [Mon, 25 Mar 2019 23:15:36 +0000 (10:15 +1100)]
Cleanup: warnings, correct assert

6 months agoFix T62927: Assert when opening default 2.79 startup file in 2.80.
Bastien Montagne [Mon, 25 Mar 2019 20:08:27 +0000 (21:08 +0100)]
Fix T62927: Assert when opening default 2.79 startup file in 2.80.

Not sure why that was asserted on instead of handling the flag properly,
if base is not selectable, then just do not select it...

Have the feeling this code handling sync of flags between bases and
objects could use some cleanup, but that will be for another day.

6 months agoFix T62856 Toon BSDF and viewport/UI oddities
Clément Foucault [Mon, 25 Mar 2019 19:36:31 +0000 (20:36 +0100)]
Fix T62856 Toon BSDF and viewport/UI oddities

This was caused by the material not tagged to use Diffuse lighting data.

6 months agoGPU: State: Replace GL_BLEND by GPU_blend
Clément Foucault [Mon, 25 Mar 2019 19:26:52 +0000 (20:26 +0100)]
GPU: State: Replace GL_BLEND by GPU_blend

6 months agoGPencil: Remove unused var
Clément Foucault [Mon, 25 Mar 2019 19:24:02 +0000 (20:24 +0100)]
GPencil: Remove unused var

6 months agoFix T62930 Eevee: Wireframe input node not working with certain compiler
Clément Foucault [Mon, 25 Mar 2019 18:44:31 +0000 (19:44 +0100)]
Fix T62930 Eevee: Wireframe input node not working with certain compiler

6 months agoGPencil: Only brushes with pinned materials have materials
Antonioya [Mon, 25 Mar 2019 16:02:42 +0000 (17:02 +0100)]
GPencil: Only brushes with pinned materials have materials

Using GP_BRUSH_MATERIAL_PINNED to switch between active material and brush material, instead of updating all brushes on active material changes. This will allow brushes to have no material and therefore to not inflate the user count.

This fix T62465.

Patch contributed by @matc
Reviewers: @brecht @antoniov @billreynish @mendio

6 months agoFix T62776: Face maps are initialized incorrectly
Jacques Lucke [Mon, 25 Mar 2019 15:32:01 +0000 (16:32 +0100)]
Fix T62776: Face maps are initialized incorrectly

Reviewers: brecht

Differential Revision:

6 months agoFix T62536: incorrect context when selecting particles
Jacques Lucke [Mon, 25 Mar 2019 14:54:00 +0000 (15:54 +0100)]
Fix T62536: incorrect context when selecting particles

Reviewers: brecht

Differential Revision:

6 months agoFix T62865: Make Single User after Objects to Scene must be done twice.
Bastien Montagne [Mon, 25 Mar 2019 14:22:35 +0000 (15:22 +0100)]
Fix T62865: Make Single User after Objects to Scene must be done twice.

Selected status was not properly moved from new object to new created base.
This prevented next steps (making obdata, materials etc. local) to ever

6 months agoFix T61577: collapse nodes hide arrow hit zone overlaps with node sockets.
Brecht Van Lommel [Mon, 25 Mar 2019 12:59:11 +0000 (13:59 +0100)]
Fix T61577: collapse nodes hide arrow hit zone overlaps with node sockets.

Patch by EitanSomething.

Differential Revision:

6 months agoFix T62891: particle even distribution is not even.
Brecht Van Lommel [Mon, 25 Mar 2019 12:55:03 +0000 (13:55 +0100)]
Fix T62891: particle even distribution is not even.

CD_ORCO coordinates are stored normalized by convention, this code path did
not store them correctly.

6 months agoUI: Add Copy/Paste to top level Outliner context menus
William Reynish [Mon, 25 Mar 2019 12:40:55 +0000 (13:40 +0100)]
UI: Add Copy/Paste to top level Outliner context menus

6 months agoKeymap: Add support for the Cmd key on macOS for copy/paste in the Outliner.
William Reynish [Mon, 25 Mar 2019 12:30:21 +0000 (13:30 +0100)]
Keymap: Add support for the Cmd key on macOS for copy/paste in the Outliner.

Consistent with other areas.

6 months agoMerge branch 'blender2.7'
Sergey Sharybin [Mon, 25 Mar 2019 10:23:00 +0000 (11:23 +0100)]
Merge branch 'blender2.7'

6 months agoCleanup: Spelling in comment
Sergey Sharybin [Mon, 25 Mar 2019 10:02:06 +0000 (11:02 +0100)]
Cleanup: Spelling in comment

6 months agoChange remaining FTP server URIs to HTTP(s)
Stephen Hassard [Mon, 25 Mar 2019 10:14:07 +0000 (11:14 +0100)]
Change remaining FTP server URIs to HTTP(s)

Most of the source tarballs are retrieved via http, but a few remain
that are still downloaded via ftp. This causes some pain with corporate
firewalls, so moving the last two URIs to http helps ease the build process.

Reviewers: sergey

Differential Revision:

6 months agoMerge branch 'blender2.7'
Bastien Montagne [Mon, 25 Mar 2019 10:05:03 +0000 (11:05 +0100)]
Merge branch 'blender2.7'

6 months agoInclude blosc, embree and opencollada into BUILD_NOTES.txt file.
Bastien Montagne [Mon, 25 Mar 2019 10:03:52 +0000 (11:03 +0100)]
Include blosc, embree and opencollada into BUILD_NOTES.txt file.

For custom path selected during '' using '--source'/'--install', paths for blosc, embree and opencollada are not printed/inclued into BUILD_NOTES.txt file.
As '/opt/lib/<package>' paths are hardcoded into CMakes's Find* modules, this error is not noticeable, but for custom paths it is.
This patch includes those fixes/prints for those packages.

Reviewers: mont29

Reviewed By: mont29

Differential Revision:

6 months agoFix T62912: Blender 2.7 keymap missing ctrl+tab select mode switching.
Brecht Van Lommel [Mon, 25 Mar 2019 09:39:59 +0000 (10:39 +0100)]
Fix T62912: Blender 2.7 keymap missing ctrl+tab select mode switching.

6 months agoMerge branch 'blender2.7'
Bastien Montagne [Mon, 25 Mar 2019 09:46:20 +0000 (10:46 +0100)]
Merge branch 'blender2.7'

6 months agoFix T62175: Crash on Undo.
Bastien Montagne [Mon, 4 Mar 2019 15:44:33 +0000 (16:44 +0100)]
Fix T62175: Crash on Undo.

Again nodetree broken code... as usual...

6 months agoRNA: add UILayout.prop_with_menu function
Campbell Barton [Mon, 25 Mar 2019 09:31:06 +0000 (20:31 +1100)]
RNA: add UILayout.prop_with_menu function

Matches prop_with_popover, supporting menu types,
useful if we want to control behavior of enum switching.

6 months agoRNA: rename prop_popover_enum to prop_with_popover
Campbell Barton [Mon, 25 Mar 2019 09:10:32 +0000 (20:10 +1100)]
RNA: rename prop_popover_enum to prop_with_popover

A version for menu's is going to be added next and we already have

This name indicates the popover is added behavior instead of a
different kind of widget.

6 months agoCleanup: UI messages of copy/paste in 3DView.
Bastien Montagne [Mon, 25 Mar 2019 09:19:56 +0000 (10:19 +0100)]
Cleanup: UI messages of copy/paste in 3DView.

Remove references to buffer or temp file, some other minor edits.

6 months agoAdd copy/paste of any IDs in Outliner.
Bastien Montagne [Thu, 21 Mar 2019 13:59:25 +0000 (14:59 +0100)]
Add copy/paste of any IDs in Outliner.

This adds entries to copy/paste (selected) IDs in the Outliner, as well
as usual ctrl-C/ctrl-V shortcuts.

Note that the clipboard is shared with other IDs copying (currently, the
one for objects in 3DView).

Reviewers: brecht, dfelinto, billreynish, pablovazquez

Differential Revision:

6 months agoCopy/Paste: refactor to be able to paste any kind of IDs, by type.
Bastien Montagne [Mon, 25 Mar 2019 08:55:36 +0000 (09:55 +0100)]
Copy/Paste: refactor to be able to paste any kind of IDs, by type.

This commit does not add anything new from user perspective, but make it
possible to paste any kind of IDs, not only objects/collections.

Will be used by new copy/paste in the outliner in next commit.

6 months agoUI: replace popovers with prop_popover_enum
Campbell Barton [Mon, 25 Mar 2019 08:30:59 +0000 (19:30 +1100)]
UI: replace popovers with prop_popover_enum

6 months agoUI: add icon_only option to prop_popover_enum
Campbell Barton [Mon, 25 Mar 2019 08:21:55 +0000 (19:21 +1100)]
UI: add icon_only option to prop_popover_enum

6 months agoError in last commit
Campbell Barton [Mon, 25 Mar 2019 08:08:02 +0000 (19:08 +1100)]
Error in last commit

6 months agoUI: add UILayout.prop_popover_enum function
Campbell Barton [Mon, 25 Mar 2019 07:55:38 +0000 (18:55 +1100)]
UI: add UILayout.prop_popover_enum function

Support for RNA enum buttons that activate popovers when clicked.

This means we get useful tooltips, shortcuts and Ctrl-Wheel cycling
over enum items.

It also avoids inconvenient & slow access of enum values currently done
via RNA type lookups on the type to get the name & icon to use for a
regular popover button.

Resolves T57738

6 months agoCleanup: simplify toggle button logic
Campbell Barton [Mon, 25 Mar 2019 05:17:39 +0000 (16:17 +1100)]
Cleanup: simplify toggle button logic

6 months agoGizmo: use fill select for scale/transform center
Campbell Barton [Mon, 25 Mar 2019 04:41:24 +0000 (15:41 +1100)]
Gizmo: use fill select for scale/transform center

Resolves T58072

6 months agoGizmo: add option to move & dial gizmos to select as filled
Campbell Barton [Mon, 25 Mar 2019 04:40:23 +0000 (15:40 +1100)]
Gizmo: add option to move & dial gizmos to select as filled

Draw as an outline while using solid selection.

6 months agoUI: Material slot selector for the shader editor
Campbell Barton [Mon, 25 Mar 2019 03:44:45 +0000 (14:44 +1100)]
UI: Material slot selector for the shader editor

D4583 by @HooglyBoogly

6 months agoRNA: error on register when classes use invalid identifiers
Campbell Barton [Mon, 25 Mar 2019 03:39:55 +0000 (14:39 +1100)]
RNA: error on register when classes use invalid identifiers

Ensure conventions are met since we're in beta and all instances should
be updated before release.

6 months agoFix T62859: UV circle select options don't work
Campbell Barton [Mon, 25 Mar 2019 03:12:25 +0000 (14:12 +1100)]
Fix T62859: UV circle select options don't work

6 months agoFix T62866: 3D text not filled by default
Alex Strand [Mon, 25 Mar 2019 02:32:24 +0000 (13:32 +1100)]
Fix T62866: 3D text not filled by default

Regression in bc5b0f7a091c395526370

See D4581

6 months agoCleanup: return argument naming
Campbell Barton [Mon, 25 Mar 2019 01:19:55 +0000 (12:19 +1100)]
Cleanup: return argument naming

6 months agoCleanup: style (render module)
Campbell Barton [Mon, 25 Mar 2019 00:55:36 +0000 (11:55 +1100)]
Cleanup: style (render module)

6 months agoCleanup: style
Campbell Barton [Mon, 25 Mar 2019 00:42:28 +0000 (11:42 +1100)]
Cleanup: style

6 months agoCleanup: use braces for interface code
Campbell Barton [Sun, 24 Mar 2019 23:15:20 +0000 (10:15 +1100)]
Cleanup: use braces for interface code

6 months agoCleanup: pass const image data to IMB_ibImageFromMemory
Campbell Barton [Sun, 24 Mar 2019 22:08:29 +0000 (09:08 +1100)]
Cleanup: pass const image data to IMB_ibImageFromMemory

6 months agoCleanup: style, array wrapping
Campbell Barton [Sun, 24 Mar 2019 05:24:29 +0000 (16:24 +1100)]
Cleanup: style, array wrapping

Add trailing comma for clang-format.

6 months agoFix uninitialized variable use for right aligned checkbox
Campbell Barton [Sun, 24 Mar 2019 20:34:06 +0000 (07:34 +1100)]
Fix uninitialized variable use for right aligned checkbox

6 months agoFix T49979: HSV/HSL 'Far' interpolation in colorbands when both stops have same hue.
Bastien Montagne [Tue, 19 Mar 2019 18:50:30 +0000 (19:50 +0100)]
Fix T49979: HSV/HSL 'Far' interpolation in colorbands when both stops have same hue.

When two stops had the exact same color, 'Far' interpolation would
behave like the three others and generate constant colors, instead of
generating expected 'full turn' in Hue space.

Note that this will break the 'constant' color between two stops with
same value in the 'Far' interpolation mode, but think that change is

This fix also exposed that 'early out' case when we are after last stop
was not working properly, still triggering actual interpolation
computation in all cases, thus the refactor in `BKE_colorband_evaluate()`
itself. We also now avoid computing factors in constant case, and get
out early in all interpolation cases but the 'spline' ones (where color
ramping can start before first stop, and end after last one).

Work initiated by patch from Charlie Jolly (@charlie) in T49979, thanks.

Reviewers: brecht, sergey

Subscribers: charlie

Differential Revision:

6 months agoFix missing version patching from lamp/light and subsurface changes.
Brecht Van Lommel [Sun, 24 Mar 2019 13:48:23 +0000 (14:48 +0100)]
Fix missing version patching from lamp/light and subsurface changes.

6 months agoCleanup: redundant use of string formatting functions
Campbell Barton [Sun, 24 Mar 2019 05:09:46 +0000 (16:09 +1100)]
Cleanup: redundant use of string formatting functions

6 months agoCleanup: redundant NULL initialization
Campbell Barton [Sun, 24 Mar 2019 00:06:18 +0000 (11:06 +1100)]
Cleanup: redundant NULL initialization

6 months agoCleanup: use shader config for worldspace clipping lib
Campbell Barton [Sun, 24 Mar 2019 00:01:28 +0000 (11:01 +1100)]
Cleanup: use shader config for worldspace clipping lib

6 months agoUI: support Ctrl-C copy for popover buttons
Campbell Barton [Sat, 23 Mar 2019 23:50:01 +0000 (10:50 +1100)]
UI: support Ctrl-C copy for popover buttons

Match menu logic that sets the Python expression to call the popover.

6 months agoGPU: State: Replace GL_LINE_SMOOTH by GPU_line_smooth
Clément Foucault [Sat, 23 Mar 2019 22:54:01 +0000 (23:54 +0100)]
GPU: State: Replace GL_LINE_SMOOTH by GPU_line_smooth

6 months agoGPU: State: Disable polygon smooth and line smooth when running --debug-gpu
Clément Foucault [Sat, 23 Mar 2019 22:47:12 +0000 (23:47 +0100)]
GPU: State: Disable polygon smooth and line smooth when running --debug-gpu

This might prove usefull when debugging some driver perf issues.