22 months agoOutliner: Collection - Duplicate Hierarchy, and Duplicate Linked Hierarchy
Dalai Felinto [Tue, 26 Feb 2019 19:15:30 +0000 (16:15 -0300)]
Outliner: Collection - Duplicate Hierarchy, and Duplicate Linked Hierarchy

As per the suggestion on T57064, this introduces two new options to duplicate collections.
We then have:
* Duplicate > Collection (New collection with linked content).
* Duplicate > Hierachy (Duplicate entire hierarchy and make all contents single user).
* Duplicate > Linked Hierarchy (Duplicate entire hierarchy keeping content linked with original).

Development TODO: `single_object_users` can/should use the new functions.

Reviewers: brecht, mont29

Subscribers: pablovazquez, billreynish, JulienKaspar

Differential Revision:

22 months agoCleanup: Update comment
Dalai Felinto [Tue, 26 Feb 2019 21:30:01 +0000 (18:30 -0300)]
Cleanup: Update comment

22 months agoCleanup: Set BKE_key_from_object/_p to take const Object *
Dalai Felinto [Tue, 26 Feb 2019 21:14:09 +0000 (18:14 -0300)]
Cleanup: Set BKE_key_from_object/_p to take const Object *

22 months agoCleanup: use variable instead of define
Campbell Barton [Fri, 1 Mar 2019 14:30:59 +0000 (01:30 +1100)]
Cleanup: use variable instead of define

22 months agoCleanup: move theme reset into it's own operator file
Campbell Barton [Fri, 1 Mar 2019 13:52:00 +0000 (00:52 +1100)]
Cleanup: move theme reset into it's own operator file

22 months agoFix: Better fix for KeyingSet "Export to File" and unescaped characters
Joshua Leung [Fri, 1 Mar 2019 13:15:54 +0000 (02:15 +1300)]
Fix: Better fix for KeyingSet "Export to File" and unescaped characters

Use Python's native raw formatting instead, which should take care of any issues
we may face.

22 months agoCleanup: Adding braces around all cases here to make it easier for the next step
Joshua Leung [Fri, 1 Mar 2019 13:11:14 +0000 (02:11 +1300)]
Cleanup: Adding braces around all cases here to make it easier for the next step

22 months agoFix T62057: Particle settings keyframes not showing in Graph Editor channels
Joshua Leung [Fri, 1 Mar 2019 13:10:43 +0000 (02:10 +1300)]
Fix T62057: Particle settings keyframes not showing in Graph Editor channels

In short, the settings to expand/collapse the Particles Animation Dopesheet expander
were no longer getting exposed, so the F-Curves attached to the particle settings
were not showing up in the channels list as that section was collapsed and couldn't
be opened from the UI.

Early on during the development of 2.8, we originally wanted to completely remove
the Particle System. Eventually that decision got walked back, and so particles
were reinstated. Well... most of the relevant code was! One of the areas that was
the most messed up during this process was the animation editor support for these
channels. It seems that there was almost a two-step removal process here -
the first pass tried to keep the channel definitions while removing all references
to particle stuff, while the second pass tried to remove the definitions completely
and/or re-added them in the wrong places, etc. To say the removal/reverting history is
here is "colourful" is an understatement...

22 months agoCleanup: use preferences prefix for Python operators
Campbell Barton [Fri, 1 Mar 2019 13:21:05 +0000 (00:21 +1100)]
Cleanup: use preferences prefix for Python operators

22 months agoCollections: mark visibility properties as not animatable.
Brecht Van Lommel [Fri, 1 Mar 2019 12:39:30 +0000 (13:39 +0100)]
Collections: mark visibility properties as not animatable.

Better to communicate the current state clearly until this is supported,
for now only object visibility can be animated.

22 months agoCleanup: use unsigned types in 3D view editor
Campbell Barton [Fri, 1 Mar 2019 12:43:34 +0000 (23:43 +1100)]
Cleanup: use unsigned types in 3D view editor

22 months agoTool System: add a mode option to 3D view circle select
Campbell Barton [Fri, 1 Mar 2019 12:18:34 +0000 (23:18 +1100)]
Tool System: add a mode option to 3D view circle select

Support only basic operations: new/add/subtract.

22 months ago3D View: avoid redundant circle select updates
Campbell Barton [Fri, 1 Mar 2019 12:09:22 +0000 (23:09 +1100)]
3D View: avoid redundant circle select updates

This refreshes on cursor motion so it's worth avoiding redundant
updates, especially for multi-object edit-modes where many objects
aren't even near the object being selected.

This commit also moves to passing eSelectOp to circle select functions
in preparation for adding a select mode tool option.

22 months agoWM: add gesture variable to detect first execution
Campbell Barton [Fri, 1 Mar 2019 12:00:11 +0000 (23:00 +1100)]
WM: add gesture variable to detect first execution

Needed for circle select to replace the current selection.

22 months agoFix T62053: Composite rendering more images than needed
Philipp Oeser [Fri, 1 Mar 2019 09:59:37 +0000 (10:59 +0100)]
Fix T62053: Composite rendering more images than needed

Reviewers: brecht

Maniphest Tasks: T62053

Differential Revision:

22 months ago3D View: move particle circle select out of object mode loop
Campbell Barton [Fri, 1 Mar 2019 11:25:29 +0000 (22:25 +1100)]
3D View: move particle circle select out of object mode loop

This doesn't support multi-object editing, no reason to check others.

22 months agoRevert "UI: File menu tweaks."
Brecht Van Lommel [Fri, 1 Mar 2019 10:13:32 +0000 (11:13 +0100)]
Revert "UI: File menu tweaks."

This reverts commit b104b3cdcff and 04baefcc2fc. Changes to core UI like
this should go through review, and doing them during Beta development is
not generally the right moment unless they fix an important problem.

22 months agoUI: Make Auto Smooth panel open by default
William Reynish [Fri, 1 Mar 2019 09:45:59 +0000 (10:45 +0100)]
UI: Make Auto Smooth panel open by default

22 months agoFix T62015: Duplicating object, rotating, pivot point not used
Sergey Sharybin [Fri, 1 Mar 2019 09:25:14 +0000 (10:25 +0100)]
Fix T62015: Duplicating object, rotating, pivot point not used

Was caused by another fix in the area, and root to the wrong though that
transformation is only initialized from a fully evaluated dependency graph.

The latter one is not a case when changing transformation mode.

Solved by copying transform to an evaluated object.

22 months agoFix flag on wrong object being modified
Sergey Sharybin [Fri, 1 Mar 2019 09:00:14 +0000 (10:00 +0100)]
Fix flag on wrong object being modified

The intention was to disable constraints prior evaluation of
the object.

Spotted by Campbell, thanks!

22 months agobuild_environment: Fixed `make deps` on macOS
Stefan Werner [Fri, 1 Mar 2019 09:01:55 +0000 (10:01 +0100)]
build_environment: Fixed `make deps` on macOS

Two changes:
Removed the explicit version for the macOS SDK, recent
versions of Xcode have a symlink to the newest SDK.
Fixed the build script for OpenMP by removing extra ' marks that
install_name_tool took literally and replaced INSTALL_PATH with

22 months agoWM: improve support for binding actions to modifier keys
Campbell Barton [Fri, 1 Mar 2019 05:46:10 +0000 (16:46 +1100)]
WM: improve support for binding actions to modifier keys

Previously a modifier key-map type only worked when the same key was
enabled as a modifier as well.

This allows for users to assign an action to double-tap-shift for eg.

22 months agoCleanup: Use braces in event matching logic
Campbell Barton [Fri, 1 Mar 2019 05:38:22 +0000 (16:38 +1100)]
Cleanup: Use braces in event matching logic

Also no need to map the event type for inactive keys.

22 months agoFix object mode lasso de-selection
Campbell Barton [Fri, 1 Mar 2019 03:08:05 +0000 (14:08 +1100)]
Fix object mode lasso de-selection

Lasso actions that only de-selected were handled as if nothing changed.

22 months agoCleanup: de-duplicate RNA array default args
Campbell Barton [Fri, 1 Mar 2019 02:21:08 +0000 (13:21 +1100)]
Cleanup: de-duplicate RNA array default args

22 months agoFix T62068: rotation incorrectly re-uses axis
Campbell Barton [Fri, 1 Mar 2019 02:05:24 +0000 (13:05 +1100)]
Fix T62068: rotation incorrectly re-uses axis

Regression in recent transform changes.

22 months agoRNA: move cursor into own struct
Campbell Barton [Fri, 1 Mar 2019 01:35:48 +0000 (12:35 +1100)]
RNA: move cursor into own struct

Without this it's impractical to subscribe to any change to the cursor.

Fixes T61969 by having gizmos update on any change to the cursor.

22 months agoFix T61825: animated images not working immediately when enabling auto refresh.
Brecht Van Lommel [Fri, 1 Mar 2019 01:12:40 +0000 (02:12 +0100)]
Fix T61825: animated images not working immediately when enabling auto refresh.

22 months agoFix T61929: crash on undo in some files with local view.
Brecht Van Lommel [Thu, 28 Feb 2019 23:34:25 +0000 (00:34 +0100)]
Fix T61929: crash on undo in some files with local view.

22 months agoComments: add comments for new transform struct members.
Campbell Barton [Thu, 28 Feb 2019 23:12:26 +0000 (10:12 +1100)]
Comments: add comments for new transform struct members.

22 months agoCleanup: minor improvements to transform comments.
Campbell Barton [Thu, 28 Feb 2019 23:45:22 +0000 (10:45 +1100)]
Cleanup: minor improvements to transform comments.

22 months agoCleanup: Use const for static number.
Campbell Barton [Thu, 28 Feb 2019 23:18:58 +0000 (10:18 +1100)]
Cleanup: Use const for static number.

Also use double indent instead of mixed tab/spaces.

22 months agoCleanup: pep8
Campbell Barton [Thu, 28 Feb 2019 23:55:23 +0000 (10:55 +1100)]
Cleanup: pep8

22 months agoCleanup and refactor sequencer proxy properties panel
Richard Antalik [Thu, 28 Feb 2019 23:10:19 +0000 (15:10 -0800)]
Cleanup and refactor sequencer proxy properties panel

Split SEQUENCER_PT_proxy to:

 - global settings and operators
 - proxy settings per strip

Author: Guillaume M (mathers)

Reviewed by: ISS, campbellbarton

Differential Revision:

22 months agoHair Particle: Fix issue on OSX due to hardware accelerated subdivision
Clément Foucault [Thu, 28 Feb 2019 21:56:27 +0000 (22:56 +0100)]
Hair Particle: Fix issue on OSX due to hardware accelerated subdivision

Workaround to tranform feedback not working on mac.
On some system it crashes (see T58489) and on some other it outputs
garbage (see T60171).

So instead of using transform feedback we render to a texture,
readback the result to system memory and reupload as VBO data.
It is really not ideal performance wise, but it is the simplest
and the most local workaround that still uses the power of the GPU.

This should fix T59426, T60171 and T58489.

22 months agoUI: hierarchical nesting
William Reynish [Thu, 28 Feb 2019 21:54:06 +0000 (22:54 +0100)]
UI: hierarchical nesting

Use correct hierarchical nesting in camera and mesh obdata properties

22 months agoUI: un-expand enum
William Reynish [Thu, 28 Feb 2019 20:58:36 +0000 (21:58 +0100)]
UI: un-expand enum

Enums don't work well when expanded vertically like this

22 months agoUI: Properties hierarchical nesting
William Reynish [Thu, 28 Feb 2019 20:53:14 +0000 (21:53 +0100)]
UI: Properties hierarchical nesting

Make hierarchy more clear and consistent in Render, Object and Particles

22 months agoCleanup/refactor clnor code: add high-level helpers to set custom normals.
Bastien Montagne [Thu, 28 Feb 2019 19:40:21 +0000 (20:40 +0100)]
Cleanup/refactor clnor code: add high-level helpers to set custom normals.

Now it will be simpler for code jsut wanting to preserve custom normals
around to set them, without having to add same boiler plate code all the
time around actual code.

22 months agoFix (unreported) assert in modifier evaluation of weighted normals.
Bastien Montagne [Thu, 28 Feb 2019 18:54:22 +0000 (19:54 +0100)]
Fix (unreported) assert in modifier evaluation of weighted normals.

Currently modifier stack assumes there are no poly normals data passed
around, so in case a modifier generates such data, it has to clean it up
after usage.

Whole handling of normals is a bit annoying and week currently, we can
probably enhance that once fully per-mesh item type cddata masks are in?

22 months ago'Fix' T61942: Triangulate modifier breaks custom normals.
Bastien Montagne [Thu, 28 Feb 2019 17:03:48 +0000 (18:03 +0100)]
'Fix' T61942: Triangulate modifier breaks custom normals.

Not a bug, but supporting preservation of custom normals in that
specific modifier makes sense, in game pipeline contexts.

Could also ease work of IO add-ons that want to export
triangulated geometry...

22 months agoCustomData: add function to clear layers' flags.
Bastien Montagne [Thu, 28 Feb 2019 17:03:01 +0000 (18:03 +0100)]
CustomData: add function to clear layers' flags.

We only had one to set those flags, up til now...

22 months agoUI: Particles
William Reynish [Thu, 28 Feb 2019 19:46:05 +0000 (20:46 +0100)]
UI: Particles

Nicer alignment in Vertex Groups panel

22 months agoUI: File menu tweaks.
Pablo Vazquez [Thu, 28 Feb 2019 19:32:39 +0000 (20:32 +0100)]
UI: File menu tweaks.

* Group Export with Save, Save As, Save Copy.
* Group Import with Link, Append.

Suggested by @fsiddi

22 months agoUI: Minor tweak on Object Type Visibility popover.
Pablo Vazquez [Thu, 28 Feb 2019 19:09:40 +0000 (20:09 +0100)]
UI: Minor tweak on Object Type Visibility popover.

Mirror order of items as in 'Add' object menu.

22 months agoGPencil: Cleanup style
Antonioya [Thu, 28 Feb 2019 18:53:43 +0000 (19:53 +0100)]
GPencil: Cleanup style

22 months agoUI: File menu tweaks.
Pablo Vazquez [Thu, 28 Feb 2019 18:45:16 +0000 (19:45 +0100)]
UI: File menu tweaks.

* Move Revert, Recover Last Session, Recover Auto Save to its own sub-menu.
  Had three entries of the same category, and solves user reports on "Revert" being dangerously accessible under Open.
* Move up Link, Append, Import, Export as they are used more often than e.g. Save Startup File.

22 months agoMerge branch 'blender2.7'
Brecht Van Lommel [Thu, 28 Feb 2019 18:17:54 +0000 (19:17 +0100)]
Merge branch 'blender2.7'

22 months agoFix T60366: texture paint slots not updating when editing material.
Brecht Van Lommel [Thu, 28 Feb 2019 13:09:19 +0000 (14:09 +0100)]
Fix T60366: texture paint slots not updating when editing material.

Now always refresh when the material changes. Depsgraph tag moved out
of the refresh function since that gets called on depsgraph update,
which should not trigger a second depsgraph update.

22 months agoFix Cycles animation denoising not working for files on a network drive.
Brecht Van Lommel [Thu, 28 Feb 2019 18:15:40 +0000 (19:15 +0100)]
Fix Cycles animation denoising not working for files on a network drive.

Can't do cross-device renaming, so put temporary file in same folder as
output file.

22 months agoUI: 3D View 'Add' Menu tweaks
Pablo Vazquez [Thu, 28 Feb 2019 17:53:49 +0000 (18:53 +0100)]
UI: 3D View 'Add' Menu tweaks

* Remove single item Armature sub-menu. Add Armature straight away, unless the menu is expanded (like with Rigify enabled)
* Group Light and Light Probe between separators
* Move the lesser used Speaker item below Camera

22 months agoDepsgraph: Fix wrong disabled bases deletion
Sergey Sharybin [Thu, 28 Feb 2019 17:47:07 +0000 (18:47 +0100)]
Depsgraph: Fix wrong disabled bases deletion

Original optimization idea was wrong: it is possible that some other
ID would reference an object which is also used by a base.

Rolled back to a bit more fragile solution.

In the future would be nice to make it somewhat less duplicated with
the builder itself.

Fixes assert failure (and possibly crashes) when adding grease pencil
object and switching to a draw mode.

22 months agoCleanup: Snake style in depsgraph
Sergey Sharybin [Thu, 28 Feb 2019 17:39:55 +0000 (18:39 +0100)]
Cleanup: Snake style in depsgraph

While it's kind of common to use camel case in C++ this is not
currently agreed style for C++ in Blender.

Got confused by working on other areas with 3rd party libraries.

22 months agoUI: Contextual menus
William Reynish [Thu, 28 Feb 2019 17:09:32 +0000 (18:09 +0100)]
UI: Contextual menus

-Rename 'Specials' menus to 'Context' menus for Grease Pencil
-Make Grease Pencil contextual menus follow the design of the regular contextual menus more
-Add more useful operators to the contextual menus in the paint modes

22 months agoFix T62012: Non-animated property, stuck in previously keyframed values
Sergey Sharybin [Thu, 28 Feb 2019 17:08:22 +0000 (18:08 +0100)]
Fix T62012: Non-animated property, stuck in previously keyframed values

Was missing ID recalc tag.

22 months agoGPencil: Rename variable name and add alpha to outline
Antonioya [Thu, 28 Feb 2019 15:11:30 +0000 (16:11 +0100)]
GPencil: Rename variable name and add alpha to outline

The outline now has some alpha to be more consistent with other Blender areas.

22 months agoGPencil: Disable Outline if Overlay is disabled
Antonioya [Thu, 28 Feb 2019 14:58:03 +0000 (15:58 +0100)]
GPencil: Disable Outline if Overlay is disabled

The main overlay switch and outline option must be checked.

22 months agoGPencil: Remove comment line added by error to header text
Antonioya [Thu, 28 Feb 2019 11:23:58 +0000 (12:23 +0100)]
GPencil: Remove comment line added by error to header text

This line was added accidentally in the header text.

22 months agoGPencil: Increase outline to 2 pixels
Antonioya [Thu, 28 Feb 2019 11:12:52 +0000 (12:12 +0100)]
GPencil: Increase outline to 2 pixels

The selection outline of 1 pixel was too thin.

22 months agoGPencil: Hide selecction outline when play animation
Antonioya [Thu, 28 Feb 2019 10:45:23 +0000 (11:45 +0100)]
GPencil: Hide selecction outline when play animation

22 months agoGPencil: Draw Outline to Active and Selected objects
Antonioya [Thu, 28 Feb 2019 09:47:57 +0000 (10:47 +0100)]
GPencil: Draw Outline to Active and Selected objects

Now an outline is drawn when the grease pencil is selected.

22 months agoGPencil: Remove dummy marker for Grease Pencil objects
Antonioya [Wed, 27 Feb 2019 19:46:04 +0000 (20:46 +0100)]
GPencil: Remove dummy marker for Grease Pencil objects

After adding selecction using strokes, the dummy is not required because it was added as a provisional solution while we implement stroke selection.

22 months agoGPencil: Add selection support for objects using strokes
Antonioya [Wed, 27 Feb 2019 18:49:16 +0000 (19:49 +0100)]
GPencil: Add selection support for objects using strokes

Now it's possible to select a grease pencil object without using the dummy.

22 months agoWonky Menu Down Arrow
Pablo Vazquez [Thu, 28 Feb 2019 16:01:35 +0000 (17:01 +0100)]
Wonky Menu Down Arrow

Almost every pulldown menu and popover has a little dropdown arrow shape.

Unfortunately it is a bit wonky.  The top of the right side of it is wider than the top of the left side. And both sides are narrower at the bottom than the top. It might be hard to see, but this image should help:


The patch fixes the symmetry of the shape while keeping the weight as similar as possible. In the following image you can see the outline of the current version in red and this new version in green.


With patch applied the arrow looks perfect:


Reviewers: brecht, billreynish

Reviewed By: billreynish

Subscribers: pablovazquez

Tags: #bf_blender, #bf_blender_2.8, #user_interface

Differential Revision:

22 months agoRevert "Objects: Remove Textured from object display type"
Clément Foucault [Thu, 28 Feb 2019 15:51:10 +0000 (16:51 +0100)]
Revert "Objects: Remove Textured from object display type"

This reverts commit 6a4a984ff731070d0702821fe1e67dea40e593b9.

22 months agoSplit base flags on own and collection-defined
Sergey Sharybin [Wed, 27 Feb 2019 16:09:30 +0000 (17:09 +0100)]
Split base flags on own and collection-defined

This allows to update base flags to a proper state then object's restriction
flags are changed, without requiring to re-evaluate an entire tree of flags.

Some old unused flags are were removed by this change, and also disabling
menu items might not work the same as before. This is something we can bring
back if it's really needed (the way how flags are handled did change since
that interface code was done anyway, so code was looking weird anyway).

Reviewers: brecht

Differential Revision:

22 months agoRemove unused base flag
Sergey Sharybin [Wed, 27 Feb 2019 15:12:59 +0000 (16:12 +0100)]
Remove unused base flag

Was only set and read from a single location.
Removing to keep things more manageable.

22 months agoDepsgraph: Keep objects which has animated visibility
Sergey Sharybin [Wed, 27 Feb 2019 14:15:26 +0000 (15:15 +0100)]
Depsgraph: Keep objects which has animated visibility

This allows dependency graph to evaluate drivers of those objects
and put them to a correct state. It will increase memory usage
since now we can no longer save it by skipping copy-on-write for
such objects. It will also currently make things slower, because
we do not have granular enough visibility update of components in
the dependency graph. Can do it later when the rest of the changes
are finished.

This commit does not update restriction flags on the base, since
that is somewhat tricky to do currently: need to somehow see whether
object is disabled due to flags on collection or due to own flags.

Differential Revision:

22 months agoDepsgraph: Route visibility flags update to proper component
Sergey Sharybin [Wed, 27 Feb 2019 14:15:07 +0000 (15:15 +0100)]
Depsgraph: Route visibility flags update to proper component

22 months agoDepsgraph: Change the logic about keeping bases in the graph
Sergey Sharybin [Wed, 27 Feb 2019 13:57:52 +0000 (14:57 +0100)]
Depsgraph: Change the logic about keeping bases in the graph

The idea is to keep bases which are known for sure to be in the
dependency graph. Previously, this code was duplicating logic
around checking restriction flags, which becomes more hard to
maintain once we are moving towards to more comprehensive checks
about whether base is a part of evaluated scene or not.

22 months agoObjects: Remove Textured from object display type
Clément Foucault [Thu, 28 Feb 2019 14:29:04 +0000 (15:29 +0100)]
Objects: Remove Textured from object display type

As discussed with @billreynish this makes little sense now that we don't
have a dedicated textured mode. We don't have a superior texture or shaded
mode anymore and we also cannot mix different engines together (workbench
with eevee/lookdev).

The only feature it removes is the possibility to hide textures for certain
object in solid mode.

22 months agoFix T62040: Irradiance Volume broken
Clément Foucault [Thu, 28 Feb 2019 14:10:14 +0000 (15:10 +0100)]
Fix T62040: Irradiance Volume broken

Was broken by 6a03199b50e02d57a50eb24441ef7be0b7e965ac.

Reintroducing the padding along with a few comment to not reproduce the
same errors.

22 months agoFix T62050: remove non-persistent timers in load-pre callback
Jacques Lucke [Thu, 28 Feb 2019 15:07:56 +0000 (16:07 +0100)]
Fix T62050: remove non-persistent timers in load-pre callback

This actually makes more sense than removing them in the
load-post callback. During load, the file might register
timers that would be removed immediately.

22 months agoFix T61994: crash when box selecting instances
Jacques Lucke [Thu, 28 Feb 2019 14:53:01 +0000 (15:53 +0100)]
Fix T61994: crash when box selecting instances

Reviewers: brecht

Differential Revision:

22 months agoFix T62021: Wireframe input node doesn't work properly
Clément Foucault [Thu, 28 Feb 2019 12:56:03 +0000 (13:56 +0100)]
Fix T62021: Wireframe input node doesn't work properly

This fixes the general case. It is still not supported for hairs.

Added a hack in the geometry node to avoid unnecessary geometry shader

22 months agoFix T58405: viewport drawing issues with display device set to None.
Brecht Van Lommel [Thu, 28 Feb 2019 12:41:06 +0000 (13:41 +0100)]
Fix T58405: viewport drawing issues with display device set to None.

Disabling color management this way is not very useful, but as long as the
option is there it should work correct.

22 months agoFix T58875: object paste and append Active Collection property not working.
Brecht Van Lommel [Thu, 28 Feb 2019 12:00:38 +0000 (13:00 +0100)]
Fix T58875: object paste and append Active Collection property not working.

22 months agoPreferences: Remove warning concerning selection in edit mode with MSAA
Clément Foucault [Thu, 28 Feb 2019 10:09:25 +0000 (11:09 +0100)]
Preferences: Remove warning concerning selection in edit mode with MSAA

We don't use MSAA anymore for the selection buffers so this warning is no
longer relevant.

22 months agoFix T61878: Selection does not allways work in wireframe mode
Clément Foucault [Wed, 27 Feb 2019 17:16:58 +0000 (18:16 +0100)]
Fix T61878: Selection does not allways work in wireframe mode

This draw surfaces if the xray option is disabled even in wireframe mode.

22 months agoDRW: add back edge highlighting for active face drawing
Campbell Barton [Thu, 28 Feb 2019 06:55:49 +0000 (17:55 +1100)]
DRW: add back edge highlighting for active face drawing

Removed in aa7b013bd5d24 for performance reasons, however highlights
can't always be seen against specular shading, see: T55456#510873

Instead of having a highlighted inner-edge, use the active edge color.

22 months ago3D View: only calculate view center when needed
Campbell Barton [Thu, 28 Feb 2019 04:40:28 +0000 (15:40 +1100)]
3D View: only calculate view center when needed

When orbit around selection was enabled the selection center was being
calculated even when it wasn't needed.

22 months agoDRW: use active color for face dot
Campbell Barton [Thu, 28 Feb 2019 03:47:21 +0000 (14:47 +1100)]
DRW: use active color for face dot

Matches active vert/edge modes.

22 months agoUI: rename Quit Prompt to Save Prompt
Campbell Barton [Thu, 28 Feb 2019 02:20:21 +0000 (13:20 +1100)]
UI: rename Quit Prompt to Save Prompt

Eventually this should be used to prompt when loading a new file too.

22 months agoUI: change behavior for quit prompt
Campbell Barton [Thu, 28 Feb 2019 02:09:56 +0000 (13:09 +1100)]
UI: change behavior for quit prompt

Remove confirmation popup menu, just exit.

Note that this option is mainly for developers or people reviewing
blend files, see D4406 for discussion on reason for keeping this feature
while simplifying how it works.

22 months agoCleanup: style
Campbell Barton [Thu, 28 Feb 2019 01:15:42 +0000 (12:15 +1100)]
Cleanup: style

22 months agoUpdate for rename: constraint_orientation -> orient_type
Campbell Barton [Thu, 28 Feb 2019 01:30:06 +0000 (12:30 +1100)]
Update for rename: constraint_orientation -> orient_type

22 months agoicons_geom: update from svn rev 62198
Campbell Barton [Thu, 28 Feb 2019 00:59:02 +0000 (11:59 +1100)]
icons_geom: update from svn rev 62198

In the future we'll try to avoid such big updates,
adjusting to material colors could have caused so many files to change.

22 months agoFix missing NULL check in recent transform changes
Campbell Barton [Thu, 28 Feb 2019 01:14:14 +0000 (12:14 +1100)]
Fix missing NULL check in recent transform changes

Caused bevel to crash.

22 months agoCleanup: warning
Campbell Barton [Thu, 28 Feb 2019 01:12:29 +0000 (12:12 +1100)]
Cleanup: warning

22 months agoMakefile: icons target now uses make variables
Campbell Barton [Wed, 27 Feb 2019 23:34:50 +0000 (10:34 +1100)]
Makefile: icons target now uses make variables

Add examples in help text.

22 months agoMakefile: use BLENDER_BIN variable if passed in
Campbell Barton [Wed, 27 Feb 2019 23:33:58 +0000 (10:33 +1100)]
Makefile: use BLENDER_BIN variable if passed in

When the default build path isn't used,
it's still handy to be able to run utility commands.

22 months agoMakefile: move help text to string literal
Campbell Barton [Wed, 27 Feb 2019 23:07:50 +0000 (10:07 +1100)]
Makefile: move help text to string literal

Editing text in @echo commands wasn't convenient.

22 months agoRefactors preview drawing code with few functional modifications:
Richard Antalik [Wed, 27 Feb 2019 21:48:27 +0000 (13:48 -0800)]
Refactors preview drawing code with few functional modifications:

Fix T61241

 - Changing preview size does not affect drawn image size, only resolution.
 -- Consistent behavior, when changing full-size / proxy / scene render size
 -- Scopes are rendered in *same size* as source image
 -- Over all, user does not have to readjust preview zoom.

Reviewed by: Brecht

Differential revision:

22 months agoUI Particles: Minor tweaks to labels
Pablo Vazquez [Wed, 27 Feb 2019 18:50:04 +0000 (19:50 +0100)]
UI Particles: Minor tweaks to labels

* Capitalize 'Orientation Axis' and 'Multiply Mass with Size'
* Rename 'Scaling' to 'Radius Scale'

22 months agoUI: Rename 'Object' to 'Object Velocity' in particle settings
Pablo Vazquez [Wed, 27 Feb 2019 18:02:22 +0000 (19:02 +0100)]
UI: Rename 'Object' to 'Object Velocity' in particle settings

22 months agoUI: Rename Display -> Viewport Display panel
Pablo Vazquez [Wed, 27 Feb 2019 18:01:29 +0000 (19:01 +0100)]
UI: Rename Display -> Viewport Display panel

22 months agoCleanup: better names and comments for library ID linking code.
Brecht Van Lommel [Wed, 27 Feb 2019 18:25:21 +0000 (19:25 +0100)]
Cleanup: better names and comments for library ID linking code.

Differential Revision:

22 months agoFix T62007: Dial 3d being drawn out of rotating tool.
mano-wii [Wed, 27 Feb 2019 16:37:12 +0000 (13:37 -0300)]
Fix T62007: Dial 3d being drawn out of rotating tool.

It was being drawn when any Gizmo was highlighted.
There are several ways to solve this (creating a new parameter to the operator, checking the gizmos in the invoke or creating a global context).
Also, for a micro-optimization, all of those conditions in the `drawDial3d` could be done once in the invoke.
But since all of these changes involve changing the customdata (`TransInfo`), which is already a bit confusing with so many members, I thought it best to make minimal changes.

22 months agoFix T61988, Bevel miter on small scale.
Howard Trickey [Wed, 27 Feb 2019 16:51:24 +0000 (11:51 -0500)]
Fix T61988, Bevel miter on small scale.

Take two at fix, hopefully without unintended commits
to submodules this time.

22 months agoArmature: Make selection only work on outlines in wireframe mode
Clément Foucault [Wed, 27 Feb 2019 16:39:44 +0000 (17:39 +0100)]
Armature: Make selection only work on outlines in wireframe mode

This was not working in edit mode and broken in posemode + bounding box
display type.

This makes possible to select bones inside other bones.