7 weeks ago3D View: preferences for rotate sensitivity
Campbell Barton [Sat, 3 Aug 2019 15:22:38 +0000 (01:22 +1000)]
3D View: preferences for rotate sensitivity

Added because the current default is too fast
for painting with tablets, see D5385.

Turntable and trackball have different settings because
turn-table uses an angle-per-pixel, where as trackball
values are relative to the view-port size so a scale is used.

The sensitivity is scaled by the pixel size so hi-dpi views don't rotate faster.

7 weeks ago3D View: aspect correct trackball rotation
Campbell Barton [Sat, 3 Aug 2019 15:19:22 +0000 (01:19 +1000)]
3D View: aspect correct trackball rotation

Hard coded aspect was used, doubling horizontal input
however this caused sliding for views which didn't match this aspect.

Calculate the aspect based on the view bounds instead.

7 weeks agoCleanup: trackball direction calculation
Campbell Barton [Sat, 3 Aug 2019 15:18:23 +0000 (01:18 +1000)]
Cleanup: trackball direction calculation

Remove z axis flipping, only needed because x & y were flipped.

7 weeks agoFix T68161: typo in ui_text of RNA scene.objects
Philipp Oeser [Sat, 3 Aug 2019 10:14:49 +0000 (12:14 +0200)]
Fix T68161: typo in ui_text of RNA scene.objects

7 weeks agoDeps: Fix build error with theora on windows.
Lazydodo [Fri, 2 Aug 2019 19:29:02 +0000 (13:29 -0600)]
Deps: Fix build error with theora on windows.

7 weeks agoGPencil: Replace Separate menu by operator Enum to display assigned key
Antonio Vazquez [Fri, 2 Aug 2019 19:23:49 +0000 (21:23 +0200)]
GPencil: Replace Separate menu by operator Enum to display assigned key

As the operator was using a menu, the keymap was not displayed. Now, the operator is used directly and don't need the menu.

7 weeks agoFix freestyle tests failing when using WITH_PYTHON_SAFETY
Brecht Van Lommel [Fri, 2 Aug 2019 17:53:14 +0000 (19:53 +0200)]
Fix freestyle tests failing when using WITH_PYTHON_SAFETY

7 weeks agoBuild: disable RTTI for the entire Cycles module, not only the kernel
Brecht Van Lommel [Fri, 2 Aug 2019 15:07:44 +0000 (17:07 +0200)]
Build: disable RTTI for the entire Cycles module, not only the kernel

The partial disabling was causing issues with Clang and ASAN, and it seems we
don't need to restrict it to the kernel anymore now that we are no longer using
boost directly.

7 weeks agoFix T68129: Bridge edge loops fails on small edge loops
Campbell Barton [Fri, 2 Aug 2019 16:51:52 +0000 (02:51 +1000)]
Fix T68129: Bridge edge loops fails on small edge loops

7 weeks agoFix T68135: Do not return NULL/None when converting an object to a mesh.
Bastien Montagne [Fri, 2 Aug 2019 15:45:32 +0000 (17:45 +0200)]
Fix T68135: Do not return NULL/None when converting an object to a mesh.

Does not make sense in the use-cases of that function, especially since
we don't know whether it is actually due to an error, or some glitch
(like an empty curve).

Think we always want to get a mesh when using either operator
conversion, or the `` function.

Note that an assert was also added to ensure we do try to convert from a
valid 'geometry' object type.

7 weeks agoFix address sanitizer overflow warnings for bit manipulation functions
Brecht Van Lommel [Fri, 2 Aug 2019 13:46:36 +0000 (15:46 +0200)]
Fix address sanitizer overflow warnings for bit manipulation functions

Perform with unsigned int instead of signed int.

Differential Revision:

7 weeks agoTests: also don't fail on memory leaks for gtests
Brecht Van Lommel [Fri, 2 Aug 2019 14:09:59 +0000 (16:09 +0200)]
Tests: also don't fail on memory leaks for gtests

7 weeks agoDRW: Select Engine: Create DRWPass only when context requests it
mano-wii [Fri, 2 Aug 2019 15:14:03 +0000 (12:14 -0300)]
DRW: Select Engine: Create DRWPass only when context requests it

7 weeks agoUpgrade Python from 3.7.0 to 3.7.4
Sybren A. Stüvel [Fri, 2 Aug 2019 14:49:14 +0000 (16:49 +0200)]
Upgrade Python from 3.7.0 to 3.7.4

7 weeks agomake deps: avoid running pdflatex as part of building Theora
Sybren A. Stüvel [Fri, 2 Aug 2019 09:12:05 +0000 (11:12 +0200)]
make deps: avoid running pdflatex as part of building Theora

On machines with pdflatex installed, this is run to build Theora.pdf.
Unfortunately this process breaks, at least on my Ubuntu 18.04 LTS
system. By setting `HAVE_PDFLATEX=no` (or any other value that is not
"yes") this can be avoided. I don't think that it's important to have
this PDF file built anyway, as it's not a dependency of Blender itself.

7 weeks agoFix T68073: Wacom Intuos 5S no pen pressure on Wayland
Sebastian Parborg [Fri, 2 Aug 2019 14:40:04 +0000 (16:40 +0200)]
Fix T68073: Wacom Intuos 5S no pen pressure on Wayland

The issue is that wayland seems to impose a generic device naming scheme
when using Xwayland For example any table stylus will show up with the
following naming convention: xwayland-stylus:33

For this to work in blender, I had to modify how the identifier string
is extracted. I also renamed the two char pointers in the search
algorithm to be more logical.

Reviewed By: Brecht

Differential Revision:

7 weeks agoFix T68021: GPencil After using eraser when draw primitives, next primitive has missi...
Antonio Vazquez [Fri, 2 Aug 2019 14:24:24 +0000 (16:24 +0200)]
Fix T68021: GPencil After using eraser when draw primitives, next primitive has missing handles

The problem was related to wrong Brush. After using the Eraser or Fill, the default brush was not the drawing one, so the handles were missing.

Now, the operator force the drawing brush.

Reviewer: @campbellbarton
Differential Revision:

7 weeks agoCleanup/Win: Fix build folder name if no target is set
Lazydodo [Fri, 2 Aug 2019 14:24:55 +0000 (08:24 -0600)]
Cleanup/Win: Fix build folder name if no target is set

When you call make.bat without a target the build folder name would
have a double underscore in it which looked odd.

7 weeks agoFix T66731: Translated texts remain original english (Tools' tips part).
Bastien Montagne [Fri, 2 Aug 2019 14:17:41 +0000 (16:17 +0200)]
Fix T66731: Translated texts remain original english (Tools' tips part).

This should fix all remaining issues reported in T66731 I think.

7 weeks agoFix (unreported) missing/broken translations in Text space.
Bastien Montagne [Fri, 2 Aug 2019 13:36:58 +0000 (15:36 +0200)]
Fix (unreported) missing/broken translations in Text space.

As a reminder, no new fancy python string formatting is just
not working (tm) with i18n translations system...

7 weeks agoFix most (if not all) untranslated Panel-labels reported in T66731.
Bastien Montagne [Fri, 2 Aug 2019 13:01:02 +0000 (15:01 +0200)]
Fix most (if not all) untranslated Panel-labels reported in T66731.

7 weeks agoCleanup/Win: Remove unused game engine variables in build helper scripts
Lazydodo [Fri, 2 Aug 2019 14:18:34 +0000 (08:18 -0600)]
Cleanup/Win: Remove unused game engine variables in build helper scripts

7 weeks agoFix T67670: Sculpt doesn't mark the file as modified
Campbell Barton [Fri, 2 Aug 2019 14:07:32 +0000 (00:07 +1000)]
Fix T67670: Sculpt doesn't mark the file as modified

Was also an issue for texture & paint curve.

7 weeks agoFix T68122: Settings for Select root and Select tip in particle edit mode are missing
Sebastian Parborg [Fri, 2 Aug 2019 14:02:16 +0000 (16:02 +0200)]
Fix T68122: Settings for Select root and Select tip in particle edit mode are missing

Do not hide the redo window for root/tip select anymore.

7 weeks agoCleanup: clang format
mano-wii [Fri, 2 Aug 2019 14:00:49 +0000 (11:00 -0300)]
Cleanup: clang format

Strange, this was not applied automatically.

7 weeks agoDRW: Select Engine: Set uniform only once per ShadowGroup
mano-wii [Fri, 2 Aug 2019 13:44:22 +0000 (10:44 -0300)]
DRW: Select Engine: Set uniform only once per ShadowGroup

7 weeks agoView3D Mesh Selection: Specify select_mode directly for Circle, Lasso and Box selection
mano-wii [Fri, 2 Aug 2019 13:38:44 +0000 (10:38 -0300)]
View3D Mesh Selection: Specify select_mode directly for Circle, Lasso and Box selection

No functional changes.

7 weeks agoFix broken add_python_test after recent changes
Brecht Van Lommel [Fri, 2 Aug 2019 13:19:59 +0000 (15:19 +0200)]
Fix broken add_python_test after recent changes

7 weeks agoFix T68112: Align View on object add is broken
Sergey Sharybin [Fri, 2 Aug 2019 13:13:59 +0000 (15:13 +0200)]
Fix T68112: Align View on object add is broken

No need to use BKE_object_where_is_calc() in this case: there is no
parenting or constraint system involved on object add.

So simply use direct object matrix calculation from it's local
transform. No need in dependency graph either in this case.

7 weeks agoFix edge selection ignoring clipping in wire-frame display
Campbell Barton [Fri, 2 Aug 2019 12:53:27 +0000 (22:53 +1000)]
Fix edge selection ignoring clipping in wire-frame display

7 weeks agoFix ignored window clipping test in foreach edge function
Campbell Barton [Fri, 2 Aug 2019 12:44:03 +0000 (22:44 +1000)]
Fix ignored window clipping test in foreach edge function

7 weeks agoTests: don't fail on leaks detected by leak sanitizer
Brecht Van Lommel [Fri, 2 Aug 2019 12:29:53 +0000 (14:29 +0200)]
Tests: don't fail on leaks detected by leak sanitizer

These often happen in external libraries that we can't fix. The leaks are
still printed in the logs.

7 weeks agoCleanup: refactor tests executing Blender to use add_blender_test function
Brecht Van Lommel [Fri, 2 Aug 2019 12:25:40 +0000 (14:25 +0200)]
Cleanup: refactor tests executing Blender to use add_blender_test function

7 weeks agoFix scene units test failure after recent changes
Brecht Van Lommel [Fri, 2 Aug 2019 12:27:16 +0000 (14:27 +0200)]
Fix scene units test failure after recent changes

7 weeks agoFix T68126: Cycles not enabled with factory settings
Brecht Van Lommel [Fri, 2 Aug 2019 11:04:10 +0000 (13:04 +0200)]
Fix T68126: Cycles not enabled with factory settings

7 weeks agoCleanup: clang-format, also typo fix.
Campbell Barton [Fri, 2 Aug 2019 10:01:35 +0000 (20:01 +1000)]
Cleanup: clang-format, also typo fix.

7 weeks agoFix text editor undo sync when mixed with other undo systems
Campbell Barton [Fri, 2 Aug 2019 09:48:08 +0000 (19:48 +1000)]
Fix text editor undo sync when mixed with other undo systems

Undo rewrite broke test_undo.text_editor_edit_mode_mix.

Relatively harmless since it's only out of sync by one action.

7 weeks agoCleanup: correct name for scene frame conversion
Campbell Barton [Fri, 2 Aug 2019 09:25:43 +0000 (19:25 +1000)]
Cleanup: correct name for scene frame conversion

Thanks to @sybren for pointing out issue from 299ff91ea1fe5

7 weeks agoCleanup: GPencil dissolve operator now uses GP_EDITABLE_STROKES_BEGIN macro
Antonio Vazquez [Fri, 2 Aug 2019 09:26:38 +0000 (11:26 +0200)]
Cleanup: GPencil dissolve operator now uses GP_EDITABLE_STROKES_BEGIN macro

This reduces the number of loops

7 weeks agoGPencil: Make GP_EDITABLE_STROKES_BEGIN macro safe when stroke is removed
Antonio Vazquez [Fri, 2 Aug 2019 09:22:08 +0000 (11:22 +0200)]
GPencil: Make GP_EDITABLE_STROKES_BEGIN macro safe when stroke is removed

If the macro was used in a loop where the stroke was removed, the macro failed.

7 weeks agoGPencil: New function to dissolve points in stroke
Antonio Vazquez [Fri, 2 Aug 2019 09:01:00 +0000 (11:01 +0200)]
GPencil: New function to dissolve points in stroke

This function will be used for new operators.

7 weeks agoBrightContrast not working correctly with negative contrast
Philipp Oeser [Thu, 1 Aug 2019 16:17:56 +0000 (18:17 +0200)]
BrightContrast not working correctly with negative contrast

followup to rB8dd95abb2ff9 (which fixed this for the Compositor node),
turns out this was also wrong for the VSE modifier and in vertex color

- also adjust min/max for VSE modifier
- also guard against division by zero

Reviewers: brecht

Maniphest Tasks: T67808

Differential Revision:

7 weeks agoGPencil: Add Frame parameter to modifier deformStroke Callback
Antonio Vazquez [Fri, 2 Aug 2019 07:50:33 +0000 (09:50 +0200)]
GPencil: Add Frame parameter to modifier deformStroke Callback

This commit adds the frame to deformStroke Callback as a preparation for new modifiers that will need this variable.

Actually, the existing modifiers are not using the frame.

7 weeks agoFix unreported: length measure displayed on the "Sequence Slide" operator panel
mano-wii [Fri, 2 Aug 2019 04:49:41 +0000 (01:49 -0300)]
Fix unreported: length measure displayed on the "Sequence Slide" operator panel

7 weeks agoDocs: correct comment for PROP_THICK_WRAP
Campbell Barton [Fri, 2 Aug 2019 03:12:07 +0000 (13:12 +1000)]
Docs: correct comment for PROP_THICK_WRAP

7 weeks agoFix T63570: Proportional editing resets scaling along Y and Z axis on mouse wheel
mano-wii [Fri, 2 Aug 2019 04:15:33 +0000 (01:15 -0300)]
Fix T63570: Proportional editing resets scaling along Y and Z axis on mouse wheel

`applyResize(...)` considers that `t->values` always represents a `ratio`.
But this is only `true` with the `MOUSEMOVE` event.
The solution proposed is to never change `t->values`.
The result of the final transformation is now written to `t->values_final`.

Reviewers: campbellbarton

Differential Revision:

7 weeks agoCleanup: doxy sections
Campbell Barton [Fri, 2 Aug 2019 02:25:39 +0000 (12:25 +1000)]
Cleanup: doxy sections

7 weeks agoFix unreported: Selection of mesh_cage element occluded by the mesh_cage itself.
mano-wii [Fri, 2 Aug 2019 02:18:44 +0000 (23:18 -0300)]
Fix unreported: Selection of mesh_cage element occluded by the mesh_cage itself.

The right thing is to be occluded by the visible mesh (in the case with modifiers).

7 weeks agoCleanup: spelling
Campbell Barton [Fri, 2 Aug 2019 02:00:07 +0000 (12:00 +1000)]
Cleanup: spelling

7 weeks agoCleanup: unused variable
Campbell Barton [Fri, 2 Aug 2019 02:04:59 +0000 (12:04 +1000)]
Cleanup: unused variable

7 weeks agoDRW: Select Engine: Add a utility to detect `select_node`
mano-wii [Fri, 2 Aug 2019 02:00:16 +0000 (23:00 -0300)]
DRW: Select Engine: Add a utility to detect `select_node`

7 weeks agoEdit Mesh Select: Remove redundant and deprecated `FAKE_SELECT_MODE_...`
mano-wii [Fri, 2 Aug 2019 01:58:46 +0000 (22:58 -0300)]
Edit Mesh Select: Remove redundant and deprecated `FAKE_SELECT_MODE_...`

7 weeks agoDRW: Select Engine: Use specified offset.
mano-wii [Fri, 2 Aug 2019 01:27:04 +0000 (22:27 -0300)]
DRW: Select Engine: Use specified offset.

Due to current uses, this does not bring functional changes.

7 weeks agoDRW: Select Engine: remove unnecessary DRWShadingGroup creations
mano-wii [Fri, 2 Aug 2019 01:24:07 +0000 (22:24 -0300)]
DRW: Select Engine: remove unnecessary DRWShadingGroup creations

7 weeks agoObject Mode: add back non '_ex' versions of mode-switching functions
Campbell Barton [Fri, 2 Aug 2019 01:33:57 +0000 (11:33 +1000)]
Object Mode: add back non '_ex' versions of mode-switching functions

While these aren't currently used, its strange to have
extended versions of a function without the non-extended versions
it also avoids callers needing to add them back if they need -
or duplicating the same boiler plate when calling the '_ex' versions.

Reverts 11da3b132aff111da3b132aff1, adds depsgraph argument
so the caller is responsible for the evaluation state.

7 weeks agoCleanup: quiet maybe-unused warnings
Campbell Barton [Fri, 2 Aug 2019 01:18:07 +0000 (11:18 +1000)]
Cleanup: quiet maybe-unused warnings

While harmless, use flow control that always sets the variable.

7 weeks agoCleanup: quiet maybe-unused warning
Campbell Barton [Fri, 2 Aug 2019 01:18:07 +0000 (11:18 +1000)]
Cleanup: quiet maybe-unused warning

While harmless, use flow control that always sets the variable.

7 weeks agoCleanup: padding in windowmanager
Nathan Craddock [Fri, 2 Aug 2019 00:32:12 +0000 (18:32 -0600)]
Cleanup: padding in windowmanager

7 weeks agoKeymap: add fractional zoom shortcuts for sequencer preview
Campbell Barton [Thu, 1 Aug 2019 22:36:03 +0000 (08:36 +1000)]
Keymap: add fractional zoom shortcuts for sequencer preview

Matches shortcuts from the image editor.

D5341 by @tintwotin

7 weeks agoVSE: Use sequencer boundbox for view_all operator
Richard Antalik [Thu, 1 Aug 2019 19:43:15 +0000 (12:43 -0700)]
VSE: Use sequencer boundbox for view_all operator

Fix T67279
Fix T59954

Reviewed By: brecht

Differential Revision:

7 weeks agoFix T66028: Move sequence, movieclip and text editor progressbars to status bar
Richard Antalik [Thu, 1 Aug 2019 19:40:57 +0000 (12:40 -0700)]
Fix T66028: Move sequence, movieclip and text editor progressbars to status bar

Reviewed By: brecht

Differential Revision:

7 weeks agoGPU: more complete coverage of drivers for Intel shader compilation workaround
Brecht Van Lommel [Thu, 1 Aug 2019 18:43:13 +0000 (20:43 +0200)]
GPU: more complete coverage of drivers for Intel shader compilation workaround

7 weeks agoFix T67939: GPencil Noise modifier wrong random calculation
Antonioya [Thu, 1 Aug 2019 15:54:51 +0000 (17:54 +0200)]
Fix T67939: GPencil Noise modifier wrong random calculation

There were several problems in the old random calculation:

* Different result in the viewport and render.
* Noise "pop" in some frames.
* Random number was calculated every time the file was opened, so get different results.

Now, instead to calculate the random numbers when n number of frames changed, the random values are calculated using a unique seed by stroke.

Also, a new Seed parameter has been added and this adds more control in the noise generated. This value can be animated and get more variations.

Differential Revision:

7 weeks agoCleanup: remove unnecessary include
mano-wii [Thu, 1 Aug 2019 14:31:17 +0000 (11:31 -0300)]
Cleanup: remove unnecessary include

7 weeks agoFix T66040: Make Data Transfer' Mix Factor multiply with vgroup weights when given...
Bastien Montagne [Thu, 1 Aug 2019 14:00:37 +0000 (16:00 +0200)]
Fix T66040: Make Data Transfer' Mix Factor multiply with vgroup weights when given, instead of ignoring it.

Brings behavior of those options in line with the VGroup editing
modifiers ones e.g.

7 weeks agoAlembic: fix heap-use-after-free error
Sybren A. Stüvel [Thu, 1 Aug 2019 13:14:57 +0000 (15:14 +0200)]
Alembic: fix heap-use-after-free error

The mesh can be freed by BKE_mesh_nomain_to_mesh(), so we need to get
the `ME_AUTOSMOOTH` flag before that call, and not after.

7 weeks agoFix T61935: load camera transforms from Alembic files written by Meshroom
Sybren A. Stüvel [Thu, 1 Aug 2019 12:54:22 +0000 (14:54 +0200)]
Fix T61935: load camera transforms from Alembic files written by Meshroom

Meshroom writes two hierarchies to Alembic, one rooted at
`/mvgRoot/mvgCameras` and the other at `/mvgRoot/mvgCamerasUndefined`.
These paths have no schema definition, and thus are ignored by Blender.
The cameras themselves have those schemaless paths as parent, and have
their transforms marked as "inherited", e.g. relative to their parent.
As these cameras have no valid parent, there is no Blender object to use
to convert their local matrices to world matrices, and Blender just
decided to reset them to the unit matrix.

Now "inherited" transforms without a parent in Blender are interpreted
as world transforms. Reparenting those objects to a Blender object will
re-interpret the transforms as local to the parent again.

7 weeks agoFFmpeg pixel format conversion improvements
Sybren A. Stüvel [Thu, 1 Aug 2019 11:01:53 +0000 (13:01 +0200)]
FFmpeg pixel format conversion improvements

FFmpeg expects Blender to feed it pixels in the output pixel format. If
the output pixel format is different than Blender's RGBA, a conversion
is needed (via FFmpeg's `sws_scale()` function). There were a few issues
with this conversion (and surrounding code) that are fixed in this

- When conversion was necessary a temporary buffer was allocated and
  deallocated for every frame. This is now allocated once and re-used.
- Copying data to the buffer was done byte-for-byte. On little-endian
  machines it is now done line-by-line using `memcpy` for a little speedup.
- The decision whether pixel format conversion is necessary is now
  correctly done based on the pixel format Blender is actually using.
- The pixel format of the buffer sent to FFmpeg is no longer hard-coded
  incorrectly to a fixed pixel format, but uses the actual output pixel
  format. This is fixes T53058 properly, making RGB QTRLE export possible.
- I added some comments to make it clear which pixel format is referred
  to (either Blender's internal format or the FFmpeg output format).

Combined these improvements not only correct a bug (T53058) but also
results in approximately 5% speed improvement (tested with a 117-frame
shot from Spring, loaded as PNGs in the VSE, encoding to h.264 with
preset 'realtime').

Reviewed By: brecht, sergey

Differential Revision:

7 weeks agoFix T68055: mesh selection issues, once blend is loaded second time in a Blender...
mano-wii [Thu, 1 Aug 2019 11:30:57 +0000 (08:30 -0300)]
Fix T68055: mesh selection issues, once blend is loaded second time in a Blender session

The depth attachment of the framebuffer was missing.

7 weeks agoAdded FFmpeg preset for WebM + VP9 video + Opus audio
Sybren A. Stüvel [Thu, 1 Aug 2019 09:52:02 +0000 (11:52 +0200)]
Added FFmpeg preset for WebM + VP9 video + Opus audio

This is a standard combination (VP9 video, Opus audio, in WebM container),
so it's nice to have as a preset.

7 weeks agoI18n messages extraction: do not report multi-lines messages anymore.
Bastien Montagne [Thu, 1 Aug 2019 10:52:10 +0000 (12:52 +0200)]
I18n messages extraction: do not report multi-lines messages anymore.

Those are now supported for tooltips.

7 weeks agoCleanup a bit i18n message extraction code.
Bastien Montagne [Thu, 1 Aug 2019 10:26:21 +0000 (12:26 +0200)]
Cleanup a bit i18n message extraction code.

7 weeks agoKeymap: use Ctrl-/ to toggle comments
Campbell Barton [Thu, 1 Aug 2019 10:32:19 +0000 (20:32 +1000)]
Keymap: use Ctrl-/ to toggle comments

Consistent with many code editors, see: D5175

7 weeks agoText: toggle comment operator
Campbell Barton [Thu, 1 Aug 2019 10:31:57 +0000 (20:31 +1000)]
Text: toggle comment operator

7 weeks agoCleanup: quiet gcc warning 'alloc-size-larger-than'
Campbell Barton [Thu, 1 Aug 2019 10:28:39 +0000 (20:28 +1000)]
Cleanup: quiet gcc warning 'alloc-size-larger-than'

7 weeks agoCleanup: use doxy sections for text operators
Campbell Barton [Thu, 1 Aug 2019 09:27:25 +0000 (19:27 +1000)]
Cleanup: use doxy sections for text operators

7 weeks agoFix T68036: VSE: 'Remove Gaps' causes audio to go out of sync
Philipp Oeser [Thu, 1 Aug 2019 08:19:19 +0000 (10:19 +0200)]
Fix T68036: VSE: 'Remove Gaps' causes audio to go out of sync

Reviewers: sergey

Maniphest Tasks: T68036

Differential Revision:

7 weeks agoLinux: resolve issue compiling on mint 18.3
Campbell Barton [Thu, 1 Aug 2019 09:14:48 +0000 (19:14 +1000)]
Linux: resolve issue compiling on mint 18.3

size_t wasn't declared. While this could be resolved differently,
convention is to include BKE after BLI.

7 weeks agoCleanup: use _ex suffix instead of _ext
Campbell Barton [Thu, 1 Aug 2019 08:34:52 +0000 (18:34 +1000)]
Cleanup: use _ex suffix instead of _ext

Convention is to use ex, not ext for extended
versions of a functions.

7 weeks agoCleanup: misc spelling fixes in variable names & defines
Campbell Barton [Thu, 1 Aug 2019 07:32:42 +0000 (17:32 +1000)]
Cleanup: misc spelling fixes in variable names & defines

T68045 by @luzpaz

7 weeks agoCleanup: remove redundant LMB select default.
Campbell Barton [Thu, 1 Aug 2019 07:23:58 +0000 (17:23 +1000)]
Cleanup: remove redundant LMB select default.

7 weeks agoFix error setting the user preferences
Campbell Barton [Thu, 1 Aug 2019 07:23:41 +0000 (17:23 +1000)]
Fix error setting the user preferences

User preferences from the startup.blend was still being used,
fixing this exposed missing theme initialization, now fixed.

7 weeks agoFix error de-duplicating BLI_file_read functions
Campbell Barton [Thu, 1 Aug 2019 06:12:39 +0000 (16:12 +1000)]
Fix error de-duplicating BLI_file_read functions

Own error in recent code de-duplication: a345f56ce3331
causing issues on Windows.

Flipped argument for reading the exact size.

7 weeks agoCleanup: misc spelling fixes
Campbell Barton [Thu, 1 Aug 2019 03:53:25 +0000 (13:53 +1000)]
Cleanup: misc spelling fixes

T68035 by @luzpaz

7 weeks agoCleanup/msvc: Remove math.h from creator_signals.c
Lazydodo [Thu, 1 Aug 2019 03:36:52 +0000 (21:36 -0600)]
Cleanup/msvc: Remove math.h from creator_signals.c

Was never needed, looks like it was copy/pasted from creator.c

spotted by @campbellbarton

7 weeks agoCleanup: Remove FMA3 Disable for msvc
Lazydodo [Thu, 1 Aug 2019 02:18:44 +0000 (20:18 -0600)]
Cleanup: Remove FMA3 Disable for msvc

We no longer build with or support msvc2013, so this hack can be removed.

Reviewed By: brecht

Differential Revision:

7 weeks agoCleanup: remove unused member
mano-wii [Thu, 1 Aug 2019 01:46:41 +0000 (22:46 -0300)]
Cleanup: remove unused member

7 weeks agoCleanup: move defaults into U_default struct
Campbell Barton [Thu, 1 Aug 2019 00:03:20 +0000 (10:03 +1000)]
Cleanup: move defaults into U_default struct

7 weeks agoCleanup: remove unused compute-id from preferences
Campbell Barton [Wed, 31 Jul 2019 23:08:43 +0000 (09:08 +1000)]
Cleanup: remove unused compute-id from preferences

7 weeks agoCleanup: use braces, unused variable, unused enum
Campbell Barton [Wed, 31 Jul 2019 23:03:50 +0000 (09:03 +1000)]
Cleanup: use braces, unused variable, unused enum

7 weeks agoFix T67951: Bone selection is broken on some Intel GPUs
mano-wii [Wed, 31 Jul 2019 19:35:06 +0000 (16:35 -0300)]
Fix T67951: Bone selection is broken on some Intel GPUs

The problem is that the `glDrawArraysInstancedBaseInstance` is ignoring the last parameter.
The solution is to indicate that `GLEW_ARB_base_instance` is not supported in these cases.

Reviewers: fclem, brecht, jbakker

Reviewed By: fclem, brecht

Differential Revision:

7 weeks agoFix several undefined-behaviour-sanitizer warnings
Lukas Stockner [Wed, 31 Jul 2019 19:13:29 +0000 (12:13 -0700)]
Fix several undefined-behaviour-sanitizer warnings

Reviewers: brecht

Reviewed By: brecht

Differential Revision:

7 weeks agoUI: Correct Spacing for Short Unit Names
Harley Acheson [Wed, 31 Jul 2019 19:14:29 +0000 (12:14 -0700)]
UI: Correct Spacing for Short Unit Names

This adds a space between a value and its short unit name except for foot, inch, degree, arcminute, arcsecond

Differential Revision:

Reviewed by Brecht Van Lommel

7 weeks agoAdd operator for removing unused material slots
Lukas Stockner [Wed, 31 Jul 2019 19:04:52 +0000 (12:04 -0700)]
Add operator for removing unused material slots

Reviewers: campbellbarton, brecht

Reviewed By: brecht

Subscribers: brecht

Differential Revision:

7 weeks agoMerge per-shader SVM nodes in the main update thread to avoid locking and resizing...
Lukas Stockner [Wed, 31 Jul 2019 06:29:18 +0000 (23:29 -0700)]
Merge per-shader SVM nodes in the main update thread to avoid locking and resizing overhead

In a test file containing 1300 copies of the same shader, this reduces shader update time from 3.1 sec to 0.05 sec.

Thanks to @swerner for noticing this issue.

Reviewers: brecht, sergey, swerner

Subscribers: swerner

Differential Revision:

7 weeks agoFix T66785: Blender Menu As Text When Main Menu Collapsed
Harley Acheson [Wed, 31 Jul 2019 18:37:06 +0000 (11:37 -0700)]
Fix T66785: Blender Menu As Text When Main Menu Collapsed

This makes the blender logo menu appear as text if 'Show Menus' is off

Differential Revision:

Reviewed by Brecht Van Lommel

7 weeks agoClarify in FloatProperty generated docs: single precision floats.
Howard Trickey [Wed, 31 Jul 2019 17:58:09 +0000 (13:58 -0400)]
Clarify in FloatProperty generated docs: single precision floats.

At least one script writer was upset that this was not specified,
as it is different from "floating point" in Python.
Also, docstring for hard and soft min and max for FloatProperty
was wrong, using sys.float_info.min and sys.float_info.max.

7 weeks agoRevert "UI: remove checks for other popovers when switching menu"
Sebastian Parborg [Wed, 31 Jul 2019 17:10:44 +0000 (19:10 +0200)]
Revert "UI: remove checks for other popovers when switching menu"

This reverts commit 77616571292ab1eeb9805797bfdd4525cc306923.

This commit broke overlapping popovers. For example in the color
management tab it would be impossible to select and of the popover
alternatives as it would switch to the menu button under the cursor.

7 weeks agoFix build error after recent cleanup
Brecht Van Lommel [Wed, 31 Jul 2019 16:57:39 +0000 (18:57 +0200)]
Fix build error after recent cleanup

7 weeks agoCleanup: typo in parameter name in function declarations.
Bastien Montagne [Wed, 31 Jul 2019 16:47:26 +0000 (18:47 +0200)]
Cleanup: typo in parameter name in function declarations.